[pgadmin-hackers] pgAdmin III commit: Tag REL-1_14_0-BETA3 has been created.

2011-07-08 Thread Dave Page
Tag REL-1_14_0-BETA3 has been created. View: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=tag;h=refs/tags/REL-1_14_0-BETA3 Log Message --- Tag beta 3 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

[pgadmin-hackers] Overhaul of type attributes modification

2011-07-08 Thread Thom Brown
Hi all, I noticed that if you add, delete, rename or change the type, collation or precision of a composite type attribute, it deletes all of them then adds them all back in. Obviously attribute additions, deletions and modifications may only occur for types under PostgreSQL 9.1, but I thought it

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-08 Thread Thom Brown
On 8 July 2011 15:19, Thom Brown wrote: > Hi all, > > I noticed that if you add, delete, rename or change the type, > collation or precision of a composite type attribute, it deletes all > of them then adds them all back in.  Obviously attribute additions, > deletions and modifications may only oc

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-08 Thread Thom Brown
On 8 July 2011 15:38, Thom Brown wrote: > On 8 July 2011 15:19, Thom Brown wrote: >> Hi all, >> >> I noticed that if you add, delete, rename or change the type, >> collation or precision of a composite type attribute, it deletes all >> of them then adds them all back in.  Obviously attribute addi

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > On 7 July 2011 23:20, Guillaume Lelarge wrote: > > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: > >> add_schemas_to_all_items_filtered.patch - same patch as before, but > >> with the above patch contents removed or adjusted to assume t

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 19:46, Guillaume Lelarge wrote: > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: >> On 7 July 2011 23:20, Guillaume Lelarge wrote: >> > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: >> >> add_schemas_to_all_items_filtered.patch - same patch as before, but >> >> with th

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Dave Page
>>  * all extension changes are wrong according to me because they aren't >>   schema objects, but database objects. I don't keep them. > > The reason why I based it on schema is because I wanted it to inherit > the schema combobox object and its source for a list of schemas so > lots of redundant

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 20:15, Dave Page wrote: >>>  * all extension changes are wrong according to me because they aren't >>>   schema objects, but database objects. I don't keep them. >> >> The reason why I based it on schema is because I wanted it to inherit >> the schema combobox object and its source

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Dave Page
On Friday, July 8, 2011, Thom Brown wrote: > On 8 July 2011 20:15, Dave Page wrote:  * all extension changes are wrong according to me because they aren't   schema objects, but database objects. I don't keep them. >>> >>> The reason why I based it on schema is because I wanted it to inh

[pgadmin-hackers] pgAdmin III commit: Beautify SQL code for comments and owners

2011-07-08 Thread Guillaume Lelarge
Beautify SQL code for comments and owners Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=d2a8c8ea0f98de4fec9ec6ee4e1a9289f43b542a Author: Thom Brown Modified Files -- pgadmin/dlg/dlgProperty.cpp |2 +- pgadmin/schema/pgObject.c

[pgadmin-hackers] pgAdmin III commit: Beautify SQL code for comments and owners

2011-07-08 Thread Guillaume Lelarge
Beautify SQL code for comments and owners Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=514d8f56f02910ff67c281eb5d98ebe5d6a15ce7 Author: Thom Brown Modified Files -- pgadmin/dlg/dlgProperty.cpp |2 +- pgadmin/schem

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 20:46 +0200, Guillaume Lelarge wrote: > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > > On 7 July 2011 23:20, Guillaume Lelarge wrote: > > > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: > > >> add_schemas_to_all_items_filtered.patch - same patch as before, bu

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 20:52, Guillaume Lelarge wrote: > On Fri, 2011-07-08 at 20:46 +0200, Guillaume Lelarge wrote: >> On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: >> > On 7 July 2011 23:20, Guillaume Lelarge wrote: >> > > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: >> > >> add_schemas_

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: > On 8 July 2011 19:46, Guillaume Lelarge wrote: > > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > >> On 7 July 2011 23:20, Guillaume Lelarge wrote: > >> > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: > >> >> add_schemas_to_all

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 20:53 +0100, Thom Brown wrote: > On 8 July 2011 20:52, Guillaume Lelarge wrote: > > On Fri, 2011-07-08 at 20:46 +0200, Guillaume Lelarge wrote: > >> On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > >> > On 7 July 2011 23:20, Guillaume Lelarge wrote: > >> > > On Wed, 20

Re: [pgadmin-hackers] pgAdmin III commit: Beautify SQL code for comments and owners

2011-07-08 Thread Dave Page
This isn't a bug fix, so really shouldn't be applied during beta. On Friday, July 8, 2011, Guillaume Lelarge wrote: > Beautify SQL code for comments and owners > > Branch > -- > REL-1_14_0_PATCHES > > Details > --- > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=514d8f56

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: > On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: > > On 8 July 2011 19:46, Guillaume Lelarge wrote: > > > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: > > >> On 7 July 2011 23:20, Guillaume Lelarge wrote: > > >> > On Wed, 2

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 8 July 2011 20:57, Guillaume Lelarge wrote: > It's not easy to do, I understand you got carried away. Happened > sometimes to me too. Still happens actually. Found out this patch doesn't contain my removal of a duplicate section of code in dlgTextSearchConfiguration.cpp, so now if the name of

Re: [pgadmin-hackers] pgAdmin III commit: Beautify SQL code for comments and owners

2011-07-08 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 21:11 +0100, Dave Page wrote: > This isn't a bug fix, so really shouldn't be applied during beta. > Well, it's not a new feature, it's not a bugfix, it's in-between. Strictly speaking, you're probably right. I can revert the patch if you want, it's no big deal. But I mean, I

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 00:12 +0100, Thom Brown wrote: > On 8 July 2011 20:57, Guillaume Lelarge wrote: > > It's not easy to do, I understand you got carried away. Happened > > sometimes to me too. Still happens actually. > > Found out this patch doesn't contain my removal of a duplicate section >

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-08 Thread Thom Brown
On 9 July 2011 00:12, Guillaume Lelarge wrote: > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: >> On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: >> > On 8 July 2011 19:46, Guillaume Lelarge wrote: >> > > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote: >> > >> On 7 July 20