Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 01:15 +0200, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 00:12 +0100, Thom Brown wrote: > > On 8 July 2011 20:57, Guillaume Lelarge wrote: > > > It's not easy to do, I understand you got carried away. Happened > > > sometimes to me too. Still happens actually. > > > > F

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: > On 9 July 2011 00:12, Guillaume Lelarge wrote: > > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: > >> On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: > >> > On 8 July 2011 19:46, Guillaume Lelarge wrote: > >> > > On Thu, 20

[pgadmin-hackers] Enabling/disabling triggers and rules

2011-07-09 Thread Guillaume Lelarge
Hi, Right now, the enabled/disabled state of a trigger and a rule is not displayed in the SQL pane of the browser. I can understand we don't display its state if the object is enabled, but shouldn't we display that the object is disabled in the SQL pane if it is? Just like we show a FK is invalid

[pgadmin-hackers] pgAdmin III commit: Make sure the SQL pane is updated when validating a

2011-07-09 Thread Guillaume Lelarge
Make sure the SQL pane is updated when validating a FK Before this patch, when a user validates a FK, the properties of the object were updated in the browser, but the SQL query in the query pane wasn't. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3

[pgadmin-hackers] pgAdmin III commit: Make sure the SQL pane is updated when validating a

2011-07-09 Thread Guillaume Lelarge
Make sure the SQL pane is updated when validating a FK Before this patch, when a user validates a FK, the properties of the object were updated in the browser, but the SQL query in the query pane wasn't. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commi

Re: [pgadmin-hackers] Enabling/disabling triggers and rules

2011-07-09 Thread Dave Page
On Sat, Jul 9, 2011 at 10:12 AM, Guillaume Lelarge wrote: > Hi, > > Right now, the enabled/disabled state of a trigger and a rule is not > displayed in the SQL pane of the browser. I can understand we don't > display its state if the object is enabled, but shouldn't we display > that the object is

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Thom Brown
On 9 July 2011 09:28, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: >> On 9 July 2011 00:12, Guillaume Lelarge wrote: >> > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: >> >> On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote: >> >> > On 8 July 201

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Guillaume Lelarge
On Fri, 2011-07-08 at 16:01 +0100, Thom Brown wrote: > On 8 July 2011 15:38, Thom Brown wrote: > > On 8 July 2011 15:19, Thom Brown wrote: > >> Hi all, > >> > >> I noticed that if you add, delete, rename or change the type, > >> collation or precision of a composite type attribute, it deletes all

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 10:33 +0100, Thom Brown wrote: > On 9 July 2011 09:28, Guillaume Lelarge wrote: > > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: > >> On 9 July 2011 00:12, Guillaume Lelarge wrote: > >> > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote: > >> >> On Fri, 201

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 12:52, Guillaume Lelarge wrote: > I took a look at this patch. The new function is really good (I love the > "hold" trick), but I have found two issues, one major and one minor. > > The minor issue is simple, and could probably get fixed easily. Let's > say I have a composite type d

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: > On 9 July 2011 12:52, Guillaume Lelarge wrote: > > I took a look at this patch. The new function is really good (I love the > > "hold" trick), but I have found two issues, one major and one minor. > > > > The minor issue is simple, and could p

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 13:25, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: >> > The major issue is why we use the "drop all, add all" method.  Let's say >> > I have a composite type declared like this: >> > >> > CREATE TYPE s1.ty2 AS >> >   (c1 integer, >> >    c2 intege

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Dave Page
On Saturday, July 9, 2011, Guillaume Lelarge wrote: > I would prefer to only refresh the old parent node, and the new parent > node. But we have no way to know the new parent node. So I refresh all > schemas. Which will bring other performance issues for users with big > schemas. I wonder if we

[pgadmin-hackers] pgAdmin III commit: Fix SQL query for enabled/disabled triggers and rul

2011-07-09 Thread Guillaume Lelarge
Fix SQL query for enabled/disabled triggers and rules When a user enables/disables a trigger, the icon changes, and the properties are updated. But the SQL query in the query pane of the browser wasn't. Same happens to enabled/disabled rules. This patch fixes both. Branch -- REL-1_14_0_PATCHE

[pgadmin-hackers] pgAdmin III commit: Fix SQL query for enabled/disabled triggers and rul

2011-07-09 Thread Guillaume Lelarge
Fix SQL query for enabled/disabled triggers and rules When a user enables/disables a trigger, the icon changes, and the properties are updated. But the SQL query in the query pane of the browser wasn't. Same happens to enabled/disabled rules. This patch fixes both. Branch -- master Details -

Re: [pgadmin-hackers] Enabling/disabling triggers and rules

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 10:18 +0100, Dave Page wrote: > On Sat, Jul 9, 2011 at 10:12 AM, Guillaume Lelarge > wrote: > > Hi, > > > > Right now, the enabled/disabled state of a trigger and a rule is not > > displayed in the SQL pane of the browser. I can understand we don't > > display its state if th

Re: [pgadmin-hackers] [pgAdmin III] #5: Modifying an object's schema via the UI

2011-07-09 Thread pgAdmin Trac
#5: Modifying an object's schema via the UI -+-- Reporter: gleu | Owner: Thom Brown Type: feature | Status: assigned Priority: minor| Milestone: Component: pgadmin | Version

Re: [pgadmin-hackers] [pgAdmin III] #183: Copy/Paste objects between schemas.

2011-07-09 Thread pgAdmin Trac
#183: Copy/Paste objects between schemas. -+-- Reporter: Simon Riggs | Owner: Vladimir Kokovic Type: feature | Status: assigned Priority: minor| Milestone: Compon

Re: [pgadmin-hackers] [pgAdmin III] #225: Database designer

2011-07-09 Thread pgAdmin Trac
#225: Database designer -+-- Reporter: Luis Ochoa | Owner: Luis Ochoa Type: feature | Status: closed Priority: major | Milestone: 1.16 Component: pgadmin

Re: [pgadmin-hackers] [pgAdmin III] #243: Add security label support

2011-07-09 Thread pgAdmin Trac
#243: Add security label support +--- Reporter: gleu| Owner: gleu Type: feature | Status: assigned Priority: minor | Milestone: Component: pgadmin |

Re: [pgadmin-hackers] [pgAdmin III] #323: CLUSTER in maintenance window

2011-07-09 Thread pgAdmin Trac
#323: CLUSTER in maintenance window +--- Reporter: Thom Brown | Owner: Thom Brown Type: feature | Status: assigned Priority: minor | Milestone: Component: pgadmin | Ver

Re: [pgadmin-hackers] [pgAdmin III] #323: CLUSTER in maintenance window

2011-07-09 Thread pgAdmin Trac
#323: CLUSTER in maintenance window -+-- Reporter: Thom Brown | Owner: Thom Brown Type: feature | Status: closed Priority: minor | Milestone: 1.14 Component: pgadmin |

Re: [pgadmin-hackers] [pgAdmin III] #323: CLUSTER in maintenance window

2011-07-09 Thread pgAdmin Trac
#323: CLUSTER in maintenance window -+-- Reporter: Thom Brown | Owner: Thom Brown Type: feature | Status: closed Priority: minor | Milestone: 1.16 Component: pgadmin |

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Thom Brown
On 9 July 2011 12:56, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 10:33 +0100, Thom Brown wrote: >> On 9 July 2011 09:28, Guillaume Lelarge wrote: >> > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: >> >> On 9 July 2011 00:12, Guillaume Lelarge wrote: >> >> > On Fri, 2011-07-08 at 21:

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 13:26, Thom Brown wrote: > On 9 July 2011 13:25, Guillaume Lelarge wrote: >> On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: >>> > The major issue is why we use the "drop all, add all" method.  Let's say >>> > I have a composite type declared like this: >>> > >>> > CREATE TYPE

[pgadmin-hackers] Re: [pgAdmin III] #7: Better display of the logfile in the server status window

2011-07-09 Thread pgAdmin Trac
#7: Better display of the logfile in the server status window -+-- Reporter: gleu | Owner: gleu Type: feature | Status: assigned Priority: minor| Milestone: Component: pgadmin |

[pgadmin-hackers] Re: [pgAdmin III] #7: Better display of the logfile in the server status window

2011-07-09 Thread pgAdmin Trac
#7: Better display of the logfile in the server status window -+-- Reporter: gleu | Owner: gleu Type: feature | Status: assigned Priority: minor| Milestone: Component: pgadmin |

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 13:39 +0100, Dave Page wrote: > On Saturday, July 9, 2011, Guillaume Lelarge wrote: > > > I would prefer to only refresh the old parent node, and the new parent > > node. But we have no way to know the new parent node. So I refresh all > > schemas. Which will bring other per

[pgadmin-hackers] pgAdmin III commit: Allow change of schema in the UI

2011-07-09 Thread Guillaume Lelarge
Allow change of schema in the UI Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=3e05c4d832e5658419094c34ce0ee6959bc1d85a Author: Thom Brown Modified Files -- CHANGELOG |2 + pgadmin/dlg/dlgAggre

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 15:14 +0100, Thom Brown wrote: > On 9 July 2011 12:56, Guillaume Lelarge wrote: > > On Sat, 2011-07-09 at 10:33 +0100, Thom Brown wrote: > >> On 9 July 2011 09:28, Guillaume Lelarge wrote: > >> > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote: > >> >> On 9 July 2011 00:

Re: [pgadmin-hackers] [pgAdmin III] #5: Modifying an object's schema via the UI

2011-07-09 Thread pgAdmin Trac
#5: Modifying an object's schema via the UI --+- Reporter: gleu | Owner: Thom Brown Type: feature | Status: closed Priority: minor| Milestone: 1.16 Component: pgadmin | Ver

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Thom Brown
On 9 July 2011 20:55, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 15:14 +0100, Thom Brown wrote: > BTW, just commited and pushed your patch. Thanks again. \o/ Thanks again Guillaume. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB U

[pgadmin-hackers] Prevent duplicate attributes

2011-07-09 Thread Thom Brown
Hi (yes, me... again), Tiny patch attached to prevent adding attributes with a duplicate name to a type. It seems previous versions prevented this, but must have been allowed in a commit since the last release. Regards Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux u

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Guillaume Lelarge
On Sat, 2011-07-09 at 17:54 +0100, Thom Brown wrote: > On 9 July 2011 13:26, Thom Brown wrote: > > On 9 July 2011 13:25, Guillaume Lelarge wrote: > >> On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: > >>> > The major issue is why we use the "drop all, add all" method. Let's say > >>> > I ha

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 21:07, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 17:54 +0100, Thom Brown wrote: >> On 9 July 2011 13:26, Thom Brown wrote: >> > On 9 July 2011 13:25, Guillaume Lelarge wrote: >> >> On Sat, 2011-07-09 at 13:14 +0100, Thom Brown wrote: >> >>> > The major issue is why we use t

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-09 Thread Dave Page
On Saturday, July 9, 2011, Guillaume Lelarge wrote: > On Sat, 2011-07-09 at 13:39 +0100, Dave Page wrote: >> On Saturday, July 9, 2011, Guillaume Lelarge wrote: >> >> > I would prefer to only refresh the old parent node, and the new parent >> > node. But we have no way to know the new parent node

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 21:11, Thom Brown wrote: > On 9 July 2011 21:07, Guillaume Lelarge wrote: >> On Sat, 2011-07-09 at 17:54 +0100, Thom Brown wrote: >>> On 9 July 2011 13:26, Thom Brown wrote: >>> > On 9 July 2011 13:25, Guillaume Lelarge wrote: >>> >> On Sat, 2011-07-09 at 13:14 +0100, Thom Brown

Re: [pgadmin-hackers] Overhaul of type attributes modification

2011-07-09 Thread Thom Brown
On 9 July 2011 23:58, Thom Brown wrote: > I've found a corner-case bug btw, which requires a tiny amendment. > But I'm also rebasing the patch for current master and 1.14_patches > (or whatever it's called), so you'll get these shortly Okay, here are the two rebased patches, both with the extra f