[pgadmin-hackers] PATCH: Security label was not properly handled (pgAdmin4)

Hi, PFA patch to fix the issue in security label model validation where it was not properly throwing error on partial inputs. Additionally, I have updated tablespace required fields validation which not proper. (RM#1110) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com Th

[pgadmin-hackers] Pgadmin4: emoji in comments

Hi, i just pulled the latest git, and tried to display a table with an emoji in comments of the table and i got an exception... using python3.5 4398d1d8694024b3f357e74fba4683d5f3cd5745 here is the traceback 2016-06-04 00:23:15,050: ERRORpgadmin:Exception on /browser/table/sql/1/1/25554/

Re: [pgadmin-hackers] Pgadmin4: emoji in comments

Hi On Fri, Jun 3, 2016 at 11:28 PM, eMerzh wrote: > Hi, > > i just pulled the latest git, > and tried to display a table with an emoji in comments of the table > and i got an exception... > > using python3.5 > 4398d1d8694024b3f357e74fba4683d5f3cd5745 > > here is the traceback > > 2016-06-04 00:23

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Yeah, I got the point. To distinguish between v1 and v2, we can have blank __init__.py in the v1 and v2 directories. I tried it and could successfully import the pgAdmin4 using "import pgadmin4_web_v1.pgAdmin4" and "import pgadmin4_web_v2.pgAdmin4". Please note that I had to rename hyphen to under

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

I have no idea. I would ask one of the Python guru's sitting next to you (as well as whether the way we'd handle side-by-side packages is appropriate). Also, look at what the PIP package does (does that even work properly in a SxS scenario? I don't know if we thought to check that). BTW; on the RP

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

Hi On Sun, Jun 5, 2016 at 6:56 PM, Priyanka Shendge wrote: > Hi, > > PFA patch for API test cases for tree nodes/modules. This patch does not > include > api tests for following modules: > > 1. Type > 2. Table child nodes > 3. FTS modules > > Kindly, review the same and let me know for any modifi

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

On 6 June 2016 at 14:03, Dave Page wrote: > Hi > > On Sun, Jun 5, 2016 at 6:56 PM, Priyanka Shendge > wrote: > > Hi, > > > > PFA patch for API test cases for tree nodes/modules. This patch does not > > include > > api tests for following modules: > > > > 1. Type > > 2. Table child nodes > > 3. F

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1277 - Few cosmetic issues with preference dialog

Hi, Please find the patch for issues fixed: 1. Foreign keys listed twice The label for Exclusion constraint was set to 'Foreign keys'. fixed it. 2. Trigger function, Unique constraint, Primary key should be in title case 3. if user click outside of Preferences window it disappear (it should not di

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi On Fri, Jun 3, 2016 at 10:52 PM, Harshal Dhumal wrote: > Hi, > > > PFA attached patch (V5) for user management functionality. > > Note: If you've applied any of the previous patch of this functionality then > set ConfigDB value to 10 in version table of and also delete role 'Standard' > from r

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

I already asked them about the APIs, though I didn't ask them about what is the best way to handle SxS installation. Will check with them. PIP package for pgadmin4 doesn't support SxS as it creates the directory with the name 'pgadmin4' only. Googling about the SxS with PIP says that people use vi

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Hmm, virtualenv's a good point. I wonder if for the RPMs (and DEBs) we're just trying too hard. Is there any good reason to support SxS there? Stability I suppose, but then we don't support back-branches long term anyway. Does anyone think we need to support side-by-side RPM/DEB installation of m

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

--Adding back Devrim :-) On Mon, Jun 6, 2016 at 2:44 PM, Dave Page wrote: > Hmm, virtualenv's a good point. > > I wonder if for the RPMs (and DEBs) we're just trying too hard. Is there > any good reason to support SxS there? Stability I suppose, but then we > don't support back-branches long te

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

On Mon, Jun 6, 2016 at 2:44 PM, Dave Page wrote: > Hmm, virtualenv's a good point. > > I wonder if for the RPMs (and DEBs) we're just trying too hard. Is there > any good reason to support SxS there? Stability I suppose, but then we > don't support back-branches long term anyway. > pgAdmin IV may

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

Hi, On Fri, Jun 3, 2016 at 9:30 PM, Paresh More wrote: > Hello Dave. > > There was problem with the Make.bat file ^M characters which is been > removed. > > Issues are fixed along with some code and README tidied > I'm still seeing the same error: copy "C:\Users\dpage\Documents\pgadmin4\pkg\wi

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

Hello Dave, Can you please attached the file C:\Users\dpage\Documents\ pgadmin4\pkg\win32\installer.iss On Mon, Jun 6, 2016 at 2:51 PM, Dave Page wrote: > Hi, > > On Fri, Jun 3, 2016 at 9:30 PM, Paresh More > wrote: > >> Hello Dave. >> >> There was problem with the Make.bat file ^M character

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

PFA. On Mon, Jun 6, 2016 at 10:46 AM, Paresh More wrote: > Hello Dave, > > Can you please attached the file C:\Users\dpage\Documents\ > pgadmin4\pkg\win32\installer.iss > > > > On Mon, Jun 6, 2016 at 2:51 PM, Dave Page wrote: > >> Hi, >> >> On Fri, Jun 3, 2016 at 9:30 PM, Paresh More > > wrote:

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA updated patch (V6) for user management functionality. Changes: As per Ashesh's suggestion I have disabled email update of existing user. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 6, 2016 at 2:

[pgadmin-hackers] pgAdmin 4 commit: User management.

User management. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3ab4501d50f3938de998d7bafdf2872aa81d3a5 Author: Harshal Dhumal Modified Files -- web/config.py | 2 +- web/pgadmin/browser/__in

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi Thanks - I've commit as-is (with some minor tweaks), however the following issues are present: 1) I get an error: "Invalid Email id: dpage...@pgadmin.org". That is a perfectly valid email address, but I guess we're not recognising the +. 2) When I mouse-over the Users menu option, the cursor

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1110 - Proper validation for the security labe

Fixes #1110 - Proper validation for the security labels. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ed2530b1f5da91a24235d2e60280df4d0bbda0b Author: Murtuza Zabuawala Modified Files -- .../templates/tablespaces/js/tablespaces.

Re: [pgadmin-hackers] PATCH: Security label was not properly handled (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Jun 6, 2016 at 12:35 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterp

[pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

Hi, I have resolved the issue and patch is attached with this mail. Please review it and let me know in case any issues. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Jun 6, 2016 at 4:23 PM, wrote: > Issue #1292 has been updated by Sanket Mehta. > >- *Assignee* set to *Sa

[pgadmin-hackers] pgAdmin 4 commit: Remove the header controls of subnode control properl

Remove the header controls of subnode control properly, when removing it from the VariableControl, and the customized TokenControl in the fts_configuration javascript module during clean up process. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;

Re: [pgadmin-hackers] Destroy header controls properly [pgadmin4]

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Jun 3, 2016 at 4:00 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.

[pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

Hi, Please find updated patch: *Issue*: Code changes are not consistent with the present code in functions/__init__.py, like don't rename variable func_def to func_defintion until it is required. Review comment given by Ashesh personally. Please review. On Fri, Jun 3, 2016 at 3:31 PM, Surinder K

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

Hello Dave, Windows batch has problem with file search and replace when it comes to white spaces. Now the search and replace code is change to python. So the installer creation issue is resolve. Attached is the updated patch. On Mon, Jun 6, 2016 at 2:51 PM, Dave Page wrote: > Hi, > > On Fri,

[pgadmin-hackers] pgAdmin 4 commit: Fixing the decryption issue during restoring the conn

Fixing the decryption issue during restoring the connection on restart. As we convert the binary password to string during storing the connection information, we also need to convert it back to byte-arrays during restoring the connections. Hence - decode the passowrd using 'utf-8' encoding during

Re: [pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

Hi, This will not work, this is generic issue and not specific to database name only, we need to do proper unescaping of special character for every object name. ( eg: create a schema with name as 'test\’ not go to table node and try to create table by selecting 'test\’ schema, it will fail al