Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

[Murtuza Zabuawala]

Hi Dave,

> On 01-Jun-2016, at 12:03 am, Ashesh Vashi  
> wrote:
> 
> On Tue, May 31, 2016 at 11:56 PM, Dave Page  > wrote:
> 
> On 31 May 2016, at 19:08, Ashesh Vashi  > wrote:
> 
>> On Tue, May 31, 2016 at 8:28 PM, Dave Page > > wrote:
>> 
>> Hi
>> 
>> On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala
>> > > wrote:
>> > Hi,
>> >
>> > As advised by Ashesh, I have tried flask 'threaded' options for this issues
>> > & it fixed the issue.
>> >
>> > PFA patches to fix long load delay when expanding server if server is
>> > inaccessible.
>> > (RM#1185).
>> 
>> That'll only affect users running under Werkzeug. What about Apache?
>> Is it an issue there?
>> A while ago - we discussed about the connection management issue, and we 
>> decided to write a deployment guide about using pgAdmin 4 as WSGI 
>> application under HTTPD using mod_wsgi.
>> And, while configuring Apache, we will need to use the WSGIDaemon option 
>> with mod_wsgi, which will allow us to specify the number of threads to be 
>> used for request handling at a time.
>> 
>> Reference:
>> http://flask.pocoo.org/docs/0.11/deploying/mod_wsgi/#configuring-apache 
>> 
> 
> Right, and I wrote that guide - it's in the docs :-)
> :-).
> 
> Good - I was thinking - you would ask me to write.. :P 
> 
> I just wanted to be sure that this particular issue isn't a problem in such a 
> configuration.
> 
> It is not.
> 
> --
> Thanks & Regards,
> 
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company 
> 
> 
> http://www.linkedin.com/in/asheshvashi 
>  
> 
>> 
>> --
>> Thanks & Regards,
>> 
>> Ashesh Vashi 
>> 
>> > --
>> > Additional patches to enhance misc validations in
>> > menu.js/schema.js/dashboard.js.
>> 
>> Please detail what these are intended to fix.
>> 
>> 

Here, we have added validation checks before accessing object.
Mostly we get object 'XYZ is undefined' OR 'XYZ Null' errors.

PFA screenshot for example.





>> > (There are no RM's for these fixes, these are just enhancements)
>> >
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com 
>> > The Enterprise PostgreSQL Company
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org 
>> > )
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers 
>> > 
>> >
>> 
>> 
>> 
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com 
>> Twitter: @pgsnake
>> 
>> EnterpriseDB UK: http://www.enterprisedb.com 
>> The Enterprise PostgreSQL Company
>> 
>> 
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org 
>> )
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers 
>> 
>> 
> 

[pgadmin-hackers] Regarding issue 1241

[Harshal Dhumal]

Hi Dave,

Regarding Issue 1241 :

We have added header section for parameter tab deliberately so that we can
force user to select parameter name (and therefore parameter's data type)
before adding new row. This is required because behavior of second cell
(Value cell) is dependent on what parameter name user has selected in first
cell (Name cell). See attached screen-shot.

For example:
1. If user selects parameter 'array_nulls' then value for this should be
either true or false (and hence switch cell).
2. If user selects parameter 'cpu_index_tuple_cost' then value for this
should be Integer (and hence Integer cell).

Without the custom header (and forcing user to select parameter) we cannot
decide what type of cell we need in second column.

Let me know your opinion on this.

Apart from this I have fixed column resize issue for Security label tab.
For Privileges tab I have reduced column resizing margin at some extent but
not 100%.



Regards,
-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB 

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

[Ashesh Vashi]

On Tue, May 31, 2016 at 11:56 PM, Dave Page  wrote:

>
> On 31 May 2016, at 19:08, Ashesh Vashi 
> wrote:
>
> On Tue, May 31, 2016 at 8:28 PM, Dave Page  wrote:
>
> Hi
>>
>> On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala
>>  wrote:
>> > Hi,
>> >
>> > As advised by Ashesh, I have tried flask 'threaded' options for this
>> issues
>> > & it fixed the issue.
>> >
>> > PFA patches to fix long load delay when expanding server if server is
>> > inaccessible.
>> > (RM#1185).
>>
>> That'll only affect users running under Werkzeug. What about Apache?
>> Is it an issue there?
>>
> A while ago - we discussed about the connection management issue, and we
> decided to write a deployment guide about using pgAdmin 4 as WSGI
> application under HTTPD using mod_wsgi.
> And, while configuring Apache, we will need to use the WSGIDaemon option
> with mod_wsgi, which will allow us to specify the number of threads to be
> used for request handling at a time.
>
> Reference:
> http://flask.pocoo.org/docs/0.11/deploying/mod_wsgi/#configuring-apache
>
>
> Right, and I wrote that guide - it's in the docs :-)
>
:-).

Good - I was thinking - you would ask me to write.. :P

>
> I just wanted to be sure that this particular issue isn't a problem in
> such a configuration.
>

It is not.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
>
>>
>> > --
>> > Additional patches to enhance misc validations in
>> > menu.js/schema.js/dashboard.js.
>>
>> Please detail what these are intended to fix.
>>
>>
>> > (There are no RM's for these fixes, these are just enhancements)
>> >
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

[Dave Page]

> On 31 May 2016, at 19:08, Ashesh Vashi  wrote:
> 
>> On Tue, May 31, 2016 at 8:28 PM, Dave Page  wrote:
> 
>> Hi
>> 
>> On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala
>>  wrote:
>> > Hi,
>> >
>> > As advised by Ashesh, I have tried flask 'threaded' options for this issues
>> > & it fixed the issue.
>> >
>> > PFA patches to fix long load delay when expanding server if server is
>> > inaccessible.
>> > (RM#1185).
>> 
>> That'll only affect users running under Werkzeug. What about Apache?
>> Is it an issue there?
> A while ago - we discussed about the connection management issue, and we 
> decided to write a deployment guide about using pgAdmin 4 as WSGI application 
> under HTTPD using mod_wsgi.
> And, while configuring Apache, we will need to use the WSGIDaemon option with 
> mod_wsgi, which will allow us to specify the number of threads to be used for 
> request handling at a time.
> 
> Reference:
> http://flask.pocoo.org/docs/0.11/deploying/mod_wsgi/#configuring-apache

Right, and I wrote that guide - it's in the docs :-)

I just wanted to be sure that this particular issue isn't a problem in such a 
configuration.

> 
> --
> Thanks & Regards,
> 
> Ashesh Vashi 
>> 
>> > --
>> > Additional patches to enhance misc validations in
>> > menu.js/schema.js/dashboard.js.
>> 
>> Please detail what these are intended to fix.
>> 
>> 
>> > (There are no RM's for these fixes, these are just enhancements)
>> >
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>> 
>> 
>> 
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>> 
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>> 
>> 
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
> 

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

[Ashesh Vashi]

On Tue, May 31, 2016 at 8:28 PM, Dave Page  wrote:

> Hi
>
> On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala
>  wrote:
> > Hi,
> >
> > As advised by Ashesh, I have tried flask 'threaded' options for this
> issues
> > & it fixed the issue.
> >
> > PFA patches to fix long load delay when expanding server if server is
> > inaccessible.
> > (RM#1185).
>
> That'll only affect users running under Werkzeug. What about Apache?
> Is it an issue there?
>
A while ago - we discussed about the connection management issue, and we
decided to write a deployment guide about using pgAdmin 4 as WSGI
application under HTTPD using mod_wsgi.
And, while configuring Apache, we will need to use the WSGIDaemon option
with mod_wsgi, which will allow us to specify the number of threads to be
used for request handling at a time.

Reference:
http://flask.pocoo.org/docs/0.11/deploying/mod_wsgi/#configuring-apache

--
Thanks & Regards,

Ashesh Vashi

>
> > --
> > Additional patches to enhance misc validations in
> > menu.js/schema.js/dashboard.js.
>
> Please detail what these are intended to fix.
>
>
> > (There are no RM's for these fixes, these are just enhancements)
> >
> >
> > --
> > Regards,
> > Murtuza Zabuawala
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

[pgadmin-hackers] pgAdmin 4 commit: Fixed a typo in Type node javascript module.

[Ashesh Vashi]

Fixed a typo in Type node javascript module.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4482bbb1ba6a86c1330d341d1124df4771ba232e
Author: Murtuza Zabuawala 

Modified Files
--
.../servers/databases/schemas/types/templates/type/js/type.js   | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Minor patch to fix typo in Type node

[Ashesh Vashi]

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Tue, May 31, 2016 at 2:56 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> ++ Patch Attached
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Tue, May 31, 2016 at 2:55 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Last commit (Link
>> )
>> introduced a typo in code due to which we are not able to open dialog,
>> PFA fix for the same. (RM#1271)
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1278 - Load the foreign server node javascript

[Ashesh Vashi]

Fixes #1278 - Load the foreign server node javascript module when
databases (not when servers) are being loaded.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4d195aafe40a1f027eb66903a5e5d09ca92cea8
Author: Khushboo Vashi 

Modified Files
--
.../databases/foreign_data_wrappers/foreign_servers/__init__.py   | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

[Sandeep Thakkar]

Hi Dave,


On Tue, May 31, 2016 at 9:29 PM, Dave Page  wrote:

> Hi,
>
> On the first run, I get:
>
> App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin
> 4.app
> ./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory
> Cleaning up
> Copying data into temporary directory
> cp: ./../mac-build/pgAdmin 4.app: No such file or directory
> create-dmg.sh failed
> make: *** [appbundle] Error 1
>
> If I run it again, I get:
>
> App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin
> 4.app
> ./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory
> Directory ./pgadmin4-1.0-dev.dmg.src already exists. Please delete it
> manually.
> create-dmg.sh failed
> make: *** [appbundle] Error 1
>
> If I manually create $SRC/dist, it's much happier.
>
> I have used variable for dist. It will create the directory if doesn't
exist. The clean-appbunde will also remove the .src directory in dist just
in case it is present.

Other issues:
>
> - Your changes to the runtime don't seem to help. I've been staring at
> the code for an hour or so now, and I can't see the issue though. We
> may need some fresh eyes.
>
> yeah, I also spent more time to see the code and test it. Infact, I could
hardly reproduce it 1 or 2 times.


> - pkg/mac/create-dmg.sh is mixing upper and lower case variable names
> and with/without _, e.g. $dmgname vs $DMG_NAME
>
> not sure, why I used lower case, I prefer upper case always. I have made
the changes now to use upper case for all variables.


> - Shoudn't DMG_NAME be initialised to `grep "^APP_NAME" web/config.py
> | cut -d"=" -f2 | sed "s/'//g"` ?
>
> yes, I have used the couple of more variables that gives proper
understanding.

Thanks! I have attached the updated patch. (runtime changes remains same).

>
> On Tue, May 31, 2016 at 1:19 PM, Sandeep Thakkar
>  wrote:
> > Somehow the patch skipped the Makefile changes. Attached is the updated
> > patch.
> >
> > On Mon, May 30, 2016 at 6:00 PM, Sandeep Thakkar
> >  wrote:
> >>
> >> Thanks. I have fixed all the issues.
> >>
> >> Regarding the app not running from within the DMG for the first time, I
> >> was unable to reproduce it on Zilan's machine which didn't have the
> >> development env. On Murali's machine, it was reproducible for 1 time
> after
> >> couple of attempts.
> >>
> >> So, I just added the sync statement after settings the pythonpath value
> in
> >> the settings. May be this will resolve the issue. Please confirm.
> >> settings.sync();
> >>
> >> Attached is the updated patch. Thanks.
> >>
> >> On Fri, May 27, 2016 at 9:28 PM, Dave Page  wrote:
> >>>
> >>> On Fri, May 27, 2016 at 4:48 PM, Dave Page  wrote:
> >>> >
> >>> >
> >>> > On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar
> >>> >  wrote:
> >>> >>
> >>> >> Sure. Thanks.
> >>> >>
> >>> >> There is a typo in pkg/mac/build.sh. i.e
> >>> >>
> >>> >> s/HTML_HELP/HELP_PATH/
> >>> >>
> >>> >>
> >>> >> On Fri, May 27, 2016 at 5:26 PM, Dave Page 
> wrote:
> >>> >>>
> >>> >>> Not entirely - we definitely need to improve it. I'll review the
> code
> >>> >>> as
> >>> >>> it is now though.
> >>> >
> >>> >
> >>> > OK, review time :-)
> >>> >
> >>> > - The appbundle name should be created from APP_NAME.app in
> config.py,
> >>> > e.g.
> >>> > 'pgAdmin 4.app'
> >>> >
> >>> > - The DMG name should be created from
> >>> > to_lower(remove_spaces(APP_NAME-APP_VERSION)) in config.py, e.g.
> >>> > pgadmin4-1.0-dev.dmg
> >>> >
> >>> > - Use #ifdef Q_OS_MAC in the QT code for Mac-specific code. There's
> no
> >>> > need
> >>> > to define another macro.
> >>> >
> >>> > - Please add "MINIFY_HTML = False" to config_local.py (and have
> Paresh
> >>> > do
> >>> > the same on his packages). This works around a code issue with the
> docs
> >>> > that
> >>> > I'll log a bug for.
> >>> >
> >>> > - In testing, I found that running the app from within the DMG
> doesn't
> >>> > seem
> >>> > to work the first time - it prompts for the path, then exits. Once I
> >>> > save
> >>> > the path it offers, it's fine on subsequent runs.
> >>> >
> >>> > - Once copied to my laptop, I saw the same issue as above.
> >>> >
> >>> > Once these issues are resolved, I think we're good to commit.
> >>>
> >>> Oh, a couple more things:
> >>>
> >>> - There should not be a copy of the app bundle in dist/ following the
> >>> build. Only the dmg should be there.
> >>>
> >>> - I think mac-build/ should be removed following a successful build,
> >>> rather than waiting for make clean (please talk to Paresh - his code
> >>> should do the same).
> >>>
> >>> --
> >>> Dave Page
> >>> Blog: http://pgsnake.blogspot.com
> >>> Twitter: @pgsnake
> >>>
> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>
> >>
> >>
> >>
> >> --
> >> Sandeep Thakkar
> >>
> >
> >
> >
> > --
> > 

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

[Dave Page]

Hi,

On the first run, I get:

App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin 4.app
./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory
Cleaning up
Copying data into temporary directory
cp: ./../mac-build/pgAdmin 4.app: No such file or directory
create-dmg.sh failed
make: *** [appbundle] Error 1

If I run it again, I get:

App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin 4.app
./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory
Directory ./pgadmin4-1.0-dev.dmg.src already exists. Please delete it manually.
create-dmg.sh failed
make: *** [appbundle] Error 1

If I manually create $SRC/dist, it's much happier.

Other issues:

- Your changes to the runtime don't seem to help. I've been staring at
the code for an hour or so now, and I can't see the issue though. We
may need some fresh eyes.

- pkg/mac/create-dmg.sh is mixing upper and lower case variable names
and with/without _, e.g. $dmgname vs $DMG_NAME

- Shoudn't DMG_NAME be initialised to `grep "^APP_NAME" web/config.py
| cut -d"=" -f2 | sed "s/'//g"` ?



On Tue, May 31, 2016 at 1:19 PM, Sandeep Thakkar
 wrote:
> Somehow the patch skipped the Makefile changes. Attached is the updated
> patch.
>
> On Mon, May 30, 2016 at 6:00 PM, Sandeep Thakkar
>  wrote:
>>
>> Thanks. I have fixed all the issues.
>>
>> Regarding the app not running from within the DMG for the first time, I
>> was unable to reproduce it on Zilan's machine which didn't have the
>> development env. On Murali's machine, it was reproducible for 1 time after
>> couple of attempts.
>>
>> So, I just added the sync statement after settings the pythonpath value in
>> the settings. May be this will resolve the issue. Please confirm.
>> settings.sync();
>>
>> Attached is the updated patch. Thanks.
>>
>> On Fri, May 27, 2016 at 9:28 PM, Dave Page  wrote:
>>>
>>> On Fri, May 27, 2016 at 4:48 PM, Dave Page  wrote:
>>> >
>>> >
>>> > On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar
>>> >  wrote:
>>> >>
>>> >> Sure. Thanks.
>>> >>
>>> >> There is a typo in pkg/mac/build.sh. i.e
>>> >>
>>> >> s/HTML_HELP/HELP_PATH/
>>> >>
>>> >>
>>> >> On Fri, May 27, 2016 at 5:26 PM, Dave Page  wrote:
>>> >>>
>>> >>> Not entirely - we definitely need to improve it. I'll review the code
>>> >>> as
>>> >>> it is now though.
>>> >
>>> >
>>> > OK, review time :-)
>>> >
>>> > - The appbundle name should be created from APP_NAME.app in config.py,
>>> > e.g.
>>> > 'pgAdmin 4.app'
>>> >
>>> > - The DMG name should be created from
>>> > to_lower(remove_spaces(APP_NAME-APP_VERSION)) in config.py, e.g.
>>> > pgadmin4-1.0-dev.dmg
>>> >
>>> > - Use #ifdef Q_OS_MAC in the QT code for Mac-specific code. There's no
>>> > need
>>> > to define another macro.
>>> >
>>> > - Please add "MINIFY_HTML = False" to config_local.py (and have Paresh
>>> > do
>>> > the same on his packages). This works around a code issue with the docs
>>> > that
>>> > I'll log a bug for.
>>> >
>>> > - In testing, I found that running the app from within the DMG doesn't
>>> > seem
>>> > to work the first time - it prompts for the path, then exits. Once I
>>> > save
>>> > the path it offers, it's fine on subsequent runs.
>>> >
>>> > - Once copied to my laptop, I saw the same issue as above.
>>> >
>>> > Once these issues are resolved, I think we're good to commit.
>>>
>>> Oh, a couple more things:
>>>
>>> - There should not be a copy of the app bundle in dist/ following the
>>> build. Only the dmg should be there.
>>>
>>> - I think mac-build/ should be removed following a successful build,
>>> rather than waiting for make clean (please talk to Paresh - his code
>>> should do the same).
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>>
>>
>> --
>> Sandeep Thakkar
>>
>
>
>
> --
> Sandeep Thakkar
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

[Dave Page]

Hi

On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala
 wrote:
> Hi,
>
> As advised by Ashesh, I have tried flask 'threaded' options for this issues
> & it fixed the issue.
>
> PFA patches to fix long load delay when expanding server if server is
> inaccessible.
> (RM#1185).

That'll only affect users running under Werkzeug. What about Apache?
Is it an issue there?

> --
> Additional patches to enhance misc validations in
> menu.js/schema.js/dashboard.js.

Please detail what these are intended to fix.


> (There are no RM's for these fixes, these are just enhancements)
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

[Dave Page]

Oh - in addition, pgadmin4.db is being shipped.

On Tue, May 31, 2016 at 3:04 PM, Dave Page  wrote:

> Hi
>
> This still doesn't build for me:
>
> > make x86
> ...
> ...
>
> Generating Code...
> link /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO
> /SUBSYSTEM:WINDOWS "/MANIFESTDEPENDENCY:type='win32' name='M
> icrosoft.Windows.Common-Controls' version='6.0.0.0'
> publicKeyToken='6595b64144ccf1df' language='*' processorArchitecture
> ='*'" /MANIFEST:embed /OUT:release\pgAdmin4.exe
> @C:\Users\dpage\AppData\Local\Temp\nm5F51.tmp
> Qt5Core.lib(Qt5Core.dll) : fatal error LNK1112: module machine type 'x64'
> conflicts with target machine type 'X86'
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
> Studio 12.0\VC\BIN\link.EXE"' : return code '0x458'
>
> Stop.
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
> Studio 12.0\VC\bin\nmake.exe"' : return code '0x2'
> Stop.
>
> Aborting build!
> "Preparing Creation of windows installer"
> cp: cannot create regular file
> `C:\\Users\\dpage\\Documents\\pgadmin4\\pkg\\win32\\win-build\\/C:\\Users\\dpage\\Documen
> ts\\pgadmin4\\pkg\\win32\\Resources\\pgAdmin4.ico': No such file or
> directory
> "C:\Program Files (x86)\Inno Setup 5\ISCC.exe" /q
> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
> Error on line 101 in
> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
> Semicolon (';') expected.
> Compile aborted.
>
> (note that the build doesn't abort). I then try a different QTDIR, this
> time a 32 bit one:
>
> link /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO
> /SUBSYSTEM:WINDOWS "/MANIFESTDEPENDENCY:type='win32' name='M
> icrosoft.Windows.Common-Controls' version='6.0.0.0'
> publicKeyToken='6595b64144ccf1df' language='*' processorArchitecture
> ='*'" /MANIFEST /MANIFESTFILE:release\pgAdmin4.exe.embed.manifest
> /OUT:release\pgAdmin4.exe @C:\Users\dpage\AppData\Loca
> l\Temp\nm1C68.tmp
> qtmain.lib(qtmain_win.obj) : error LNK2038: mismatch detected for
> '_MSC_VER': value '1700' doesn't match value '1800' in
>  pgAdmin4.obj
> release\pgAdmin4.exe : fatal error LNK1319: 1 mismatches detected
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
> Studio 12.0\VC\BIN\link.EXE"' : return code '0x527'
>
> Stop.
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
> Studio 12.0\VC\bin\nmake.exe"' : return code '0x2'
> Stop.
>
> Aborting build!
> "Preparing Creation of windows installer"
> cp: cannot create regular file
> `C:\\Users\\dpage\\Documents\\pgadmin4\\pkg\\win32\\win-build\\/C:\\Users\\dpage\\Documen
> ts\\pgadmin4\\pkg\\win32\\Resources\\pgAdmin4.ico': No such file or
> directory
> "C:\Program Files (x86)\Inno Setup 5\ISCC.exe" /q
> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
> Error on line 101 in
> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
> Semicolon (';') expected.
> Compile aborted.
>
> If I then try a 64bit build:
>
> > make amd64
> ...
> ...
>
> Generating Code...
> link /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO
> /SUBSYSTEM:WINDOWS "/MANIFESTDEPENDENCY:type='win32' name='M
> icrosoft.Windows.Common-Controls' version='6.0.0.0'
> publicKeyToken='6595b64144ccf1df' language='*' processorArchitecture
> ='*'" /MANIFEST:embed /OUT:release\pgAdmin4.exe
> @C:\Users\dpage\AppData\Local\Temp\nmF7B9.tmp
> Server.obj : error LNK2019: unresolved external symbol
> __imp_PyString_FromString referenced in function "public: __cdecl
>  Server::Server(unsigned short)" (??0Server@@QEAA@G@Z)
> Server.obj : error LNK2019: unresolved external symbol __imp_PyList_Append
> referenced in function "public: __cdecl Serve
> r::Server(unsigned short)" (??0Server@@QEAA@G@Z)
> Server.obj : error LNK2019: unresolved external symbol
> __imp_PyFile_FromString referenced in function "protected: virtua
> l void __cdecl Server::run(void)" (?run@Server@@MEAAXXZ)
> Server.obj : error LNK2019: unresolved external symbol __imp_PyFile_AsFile
> referenced in function "protected: virtual vo
> id __cdecl Server::run(void)" (?run@Server@@MEAAXXZ)
> Server.obj : error LNK2019: unresolved external symbol
> __imp_Py_SetProgramName referenced in function "public: __cdecl S
> erver::Server(unsigned short)" (??0Server@@QEAA@G@Z)
> Server.obj : error LNK2019: unresolved external symbol __imp_Py_Initialize
> referenced in function "public: __cdecl Serve
> r::Server(unsigned short)" (??0Server@@QEAA@G@Z)
> Server.obj : error LNK2019: unresolved external symbol __imp_Py_Finalize
> referenced in function "public: virtual __cdecl
>  Server::~Server(void)" (??1Server@@UEAA@XZ)
> Server.obj : error LNK2019: unresolved external symbol
> __imp_PyRun_SimpleStringFlags referenced in function "protected:
> virtual void __cdecl Server::run(void)" (?run@Server@@MEAAXXZ)
> Server.obj : error LNK2019: unresolved external symbol
> __imp_PyRun_SimpleFileExFlags referenced in function "protected:
> virtual void __cdecl 

[pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

[Murtuza Zabuawala]

Hi,

As advised by Ashesh, I have tried flask 'threaded' options for this issues
& it fixed the issue.

PFA patches to fix long load delay when expanding server if server is
inaccessible.
(RM#1185).


--
Additional patches to enhance misc validations in
menu.js/schema.js/dashboard.js.
(There are no RM's for these fixes, these are just enhancements)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1185.patch
Description: Binary data


misc_added_validation.patch
Description: Binary data


menu_validation.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

[Dave Page]

Hi

This still doesn't build for me:

> make x86
...
...

Generating Code...
link /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO
/SUBSYSTEM:WINDOWS "/MANIFESTDEPENDENCY:type='win32' name='M
icrosoft.Windows.Common-Controls' version='6.0.0.0'
publicKeyToken='6595b64144ccf1df' language='*' processorArchitecture
='*'" /MANIFEST:embed /OUT:release\pgAdmin4.exe
@C:\Users\dpage\AppData\Local\Temp\nm5F51.tmp
Qt5Core.lib(Qt5Core.dll) : fatal error LNK1112: module machine type 'x64'
conflicts with target machine type 'X86'
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio
12.0\VC\BIN\link.EXE"' : return code '0x458'

Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio
12.0\VC\bin\nmake.exe"' : return code '0x2'
Stop.

Aborting build!
"Preparing Creation of windows installer"
cp: cannot create regular file
`C:\\Users\\dpage\\Documents\\pgadmin4\\pkg\\win32\\win-build\\/C:\\Users\\dpage\\Documen
ts\\pgadmin4\\pkg\\win32\\Resources\\pgAdmin4.ico': No such file or
directory
"C:\Program Files (x86)\Inno Setup 5\ISCC.exe" /q
"C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
Error on line 101 in
C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
Semicolon (';') expected.
Compile aborted.

(note that the build doesn't abort). I then try a different QTDIR, this
time a 32 bit one:

link /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO
/SUBSYSTEM:WINDOWS "/MANIFESTDEPENDENCY:type='win32' name='M
icrosoft.Windows.Common-Controls' version='6.0.0.0'
publicKeyToken='6595b64144ccf1df' language='*' processorArchitecture
='*'" /MANIFEST /MANIFESTFILE:release\pgAdmin4.exe.embed.manifest
/OUT:release\pgAdmin4.exe @C:\Users\dpage\AppData\Loca
l\Temp\nm1C68.tmp
qtmain.lib(qtmain_win.obj) : error LNK2038: mismatch detected for
'_MSC_VER': value '1700' doesn't match value '1800' in
 pgAdmin4.obj
release\pgAdmin4.exe : fatal error LNK1319: 1 mismatches detected
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio
12.0\VC\BIN\link.EXE"' : return code '0x527'

Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio
12.0\VC\bin\nmake.exe"' : return code '0x2'
Stop.

Aborting build!
"Preparing Creation of windows installer"
cp: cannot create regular file
`C:\\Users\\dpage\\Documents\\pgadmin4\\pkg\\win32\\win-build\\/C:\\Users\\dpage\\Documen
ts\\pgadmin4\\pkg\\win32\\Resources\\pgAdmin4.ico': No such file or
directory
"C:\Program Files (x86)\Inno Setup 5\ISCC.exe" /q
"C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
Error on line 101 in
C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
Semicolon (';') expected.
Compile aborted.

If I then try a 64bit build:

> make amd64
...
...

Generating Code...
link /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO
/SUBSYSTEM:WINDOWS "/MANIFESTDEPENDENCY:type='win32' name='M
icrosoft.Windows.Common-Controls' version='6.0.0.0'
publicKeyToken='6595b64144ccf1df' language='*' processorArchitecture
='*'" /MANIFEST:embed /OUT:release\pgAdmin4.exe
@C:\Users\dpage\AppData\Local\Temp\nmF7B9.tmp
Server.obj : error LNK2019: unresolved external symbol
__imp_PyString_FromString referenced in function "public: __cdecl
 Server::Server(unsigned short)" (??0Server@@QEAA@G@Z)
Server.obj : error LNK2019: unresolved external symbol __imp_PyList_Append
referenced in function "public: __cdecl Serve
r::Server(unsigned short)" (??0Server@@QEAA@G@Z)
Server.obj : error LNK2019: unresolved external symbol
__imp_PyFile_FromString referenced in function "protected: virtua
l void __cdecl Server::run(void)" (?run@Server@@MEAAXXZ)
Server.obj : error LNK2019: unresolved external symbol __imp_PyFile_AsFile
referenced in function "protected: virtual vo
id __cdecl Server::run(void)" (?run@Server@@MEAAXXZ)
Server.obj : error LNK2019: unresolved external symbol
__imp_Py_SetProgramName referenced in function "public: __cdecl S
erver::Server(unsigned short)" (??0Server@@QEAA@G@Z)
Server.obj : error LNK2019: unresolved external symbol __imp_Py_Initialize
referenced in function "public: __cdecl Serve
r::Server(unsigned short)" (??0Server@@QEAA@G@Z)
Server.obj : error LNK2019: unresolved external symbol __imp_Py_Finalize
referenced in function "public: virtual __cdecl
 Server::~Server(void)" (??1Server@@UEAA@XZ)
Server.obj : error LNK2019: unresolved external symbol
__imp_PyRun_SimpleStringFlags referenced in function "protected:
virtual void __cdecl Server::run(void)" (?run@Server@@MEAAXXZ)
Server.obj : error LNK2019: unresolved external symbol
__imp_PyRun_SimpleFileExFlags referenced in function "protected:
virtual void __cdecl Server::run(void)" (?run@Server@@MEAAXXZ)
Server.obj : error LNK2019: unresolved external symbol
__imp_PySys_GetObject referenced in function "public: __cdecl Ser
ver::Server(unsigned short)" (??0Server@@QEAA@G@Z)
Server.obj : error LNK2019: unresolved external symbol __imp_Py_NoSiteFlag
referenced in function "public: __cdecl Serve

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

[Sandeep Thakkar]

Somehow the patch skipped the Makefile changes. Attached is the updated
patch.

On Mon, May 30, 2016 at 6:00 PM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:

> Thanks. I have fixed all the issues.
>
> Regarding the app not running from within the DMG for the first time, I
> was unable to reproduce it on Zilan's machine which didn't have the
> development env. On Murali's machine, it was reproducible for 1 time after
> couple of attempts.
>
> So, I just added the sync statement after settings the pythonpath value in
> the settings. May be this will resolve the issue. Please confirm.
> settings.sync();
>
> Attached is the updated patch. Thanks.
>
> On Fri, May 27, 2016 at 9:28 PM, Dave Page  wrote:
>
>> On Fri, May 27, 2016 at 4:48 PM, Dave Page  wrote:
>> >
>> >
>> > On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar
>> >  wrote:
>> >>
>> >> Sure. Thanks.
>> >>
>> >> There is a typo in pkg/mac/build.sh. i.e
>> >>
>> >> s/HTML_HELP/HELP_PATH/
>> >>
>> >>
>> >> On Fri, May 27, 2016 at 5:26 PM, Dave Page  wrote:
>> >>>
>> >>> Not entirely - we definitely need to improve it. I'll review the code
>> as
>> >>> it is now though.
>> >
>> >
>> > OK, review time :-)
>> >
>> > - The appbundle name should be created from APP_NAME.app in config.py,
>> e.g.
>> > 'pgAdmin 4.app'
>> >
>> > - The DMG name should be created from
>> > to_lower(remove_spaces(APP_NAME-APP_VERSION)) in config.py, e.g.
>> > pgadmin4-1.0-dev.dmg
>> >
>> > - Use #ifdef Q_OS_MAC in the QT code for Mac-specific code. There's no
>> need
>> > to define another macro.
>> >
>> > - Please add "MINIFY_HTML = False" to config_local.py (and have Paresh
>> do
>> > the same on his packages). This works around a code issue with the docs
>> that
>> > I'll log a bug for.
>> >
>> > - In testing, I found that running the app from within the DMG doesn't
>> seem
>> > to work the first time - it prompts for the path, then exits. Once I
>> save
>> > the path it offers, it's fine on subsequent runs.
>> >
>> > - Once copied to my laptop, I saw the same issue as above.
>> >
>> > Once these issues are resolved, I think we're good to commit.
>>
>> Oh, a couple more things:
>>
>> - There should not be a copy of the app bundle in dist/ following the
>> build. Only the dmg should be there.
>>
>> - I think mac-build/ should be removed following a successful build,
>> rather than waiting for make clean (please talk to Paresh - his code
>> should do the same).
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Sandeep Thakkar
>
>


-- 
Sandeep Thakkar


pgadmin-mac-appbundle-may31.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

[Ashesh Vashi]

On Tue, May 31, 2016 at 2:45 PM, Dave Page  wrote:

>
>
> On Tue, May 31, 2016 at 9:52 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>>
>>
>>
>> On Tue, May 31, 2016 at 1:26 PM, Dave Page  wrote:
>>
>>> Yeah, I was about to reply on this too;
>>>
>>> - Why do we need Marshmallow?
>>>
>>> - Why do we need a role system? Perhaps in the future we might have
>>> shared servers, and roles that cannot modify them, but not now.
>>>
>> Hmm..
>> He just added one more role - 'Standard'.
>> 'Administrator' role was already presents in it.
>>
>
> Oh yes, sorry, misread that. 'pgAdmin User Role' would be a better
> description though I think.
>
Yeah - that can be done. :-)

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] PATCH:Treeview item sorting (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA patch to add server & client side sorting of nodes when node is renamed
or newly added in tree.
Bug #1244

*TODO://*
Need a way to handle a case on client side when in object is moved out of
collection.

*[ For time being, I've included workaround that we will close the tree *
*till parent node if we are not able to find object in parent ] *


Regards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sat, May 28, 2016 at 6:53 PM, Ashesh Vashi  wrote:

> On Fri, May 27, 2016 at 7:34 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch, To address RM#1244.
>>
>> Now we are sorting all collection nodes based on it's labels.
>>
> The patch takes care sorting the nodes at server side.
> When we rename a node, or add a new node object, we will need to add the
> necessary logic at client side.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>


tree_sorting.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Minor patch to fix typo in Type node

[Murtuza Zabuawala]

++ Patch Attached

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, May 31, 2016 at 2:55 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Last commit (Link
> )
> introduced a typo in code due to which we are not able to open dialog,
> PFA fix for the same. (RM#1271)
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


Fixed_typo.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: Minor patch to fix typo in Type node

[Murtuza Zabuawala]

Hi,

Last commit (Link
)
introduced a typo in code due to which we are not able to open dialog,
PFA fix for the same. (RM#1271)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

[Dave Page]

On Tue, May 31, 2016 at 9:52 AM, Ashesh Vashi  wrote:

>
>
>
> On Tue, May 31, 2016 at 1:26 PM, Dave Page  wrote:
>
>> Yeah, I was about to reply on this too;
>>
>> - Why do we need Marshmallow?
>>
>> - Why do we need a role system? Perhaps in the future we might have
>> shared servers, and roles that cannot modify them, but not now.
>>
> Hmm..
> He just added one more role - 'Standard'.
> 'Administrator' role was already presents in it.
>

Oh yes, sorry, misread that. 'pgAdmin User Role' would be a better
description though I think.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

[Ashesh Vashi]

On Tue, May 31, 2016 at 1:26 PM, Dave Page  wrote:

> Yeah, I was about to reply on this too;
>
> - Why do we need Marshmallow?
>
> - Why do we need a role system? Perhaps in the future we might have shared
> servers, and roles that cannot modify them, but not now.
>
Hmm..
He just added one more role - 'Standard'.
'Administrator' role was already presents in it.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> - Why is the editing not done in-grid? It's only a single line per record.
> Seems like an awful lot of code for what should be a simple backgrid
> implementation.
>
> On Tue, May 31, 2016 at 8:42 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Harshal,
>>
>> Please find the updated patch with some improvement, we should not show
>> any of the functions to the non-administrator user.
>>
>> * Please handle unauthorised routes call using our own wrapper function.
>>Because - role_required wrapper redirect the call to unauthorised
>> page, which we don't required. We needed proper ajax response.
>> * Add search filter on top of grid.
>> * Open the form of user, when we add new user.
>> * Do not allow to add new user, if the form is not complete for the new
>> user.
>> * Do not allow to close the form of new user with incomplete data.
>> (Though - allow it to remove it.)
>> * Close the form on save button call.
>> * Allow to change attributes of existing users from the grid itself.
>>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>> On Tue, May 31, 2016 at 12:12 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer *
>>>
>>>
>>>
>>> EenterpriseDB 
>>>
>>> On Mon, May 30, 2016 at 4:09 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Harshal,

 PFA comments as below,

 1) While running setup.py for the first time, We did not handle the
 case to create Standard user.

>>> Fixed
>>>
>>>
 2) Save button gets enable only clicking on input text box

>>> Fixed
>>>
>>>
 3) Remove delete button from sub-node

>>> Removed button.
>>>
>>> 4) If current user changes its own name/email, main page should reflect
 new changes.

>>> Moved to TODO
>>>
>>>


 Can be listed as TODO
 
 1) Erros description is missing, for example when have user
 t...@test.com presnt and user try to add user same as t...@test.com we
 get error as "Error during saving user" it should be descriptive like
 "ERRPR: User {XYZ} is already exists.."

>>> Fixed. (Added client side validation)
>>>
>>>
 2) There should be an option to delete multiple users at one shot.

>>> Moved to TODO
>>>
>>>
 3) There should be an option to active/deactivate multiple users in one
 shot.

>>> Moved to TODO
>>>
>>>
 4) In-place editing in backgrid.

>>> Moved to TODO
>>>
>>>


 Regards,
 Murtuza

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Fri, May 27, 2016 at 7:02 PM, Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> PFA initial patch for User management functionality.
>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB 
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

>>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

[Ashesh Vashi]

Committed - after rebased the patch.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Thu, May 26, 2016 at 4:41 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA updated patch which will also include new query given by Thom for "Of
> type" drop-down.
>
>
> Regards,
> Murtuza
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, May 26, 2016 at 4:04 PM, Thom Brown  wrote:
>
>> On 26 May 2016 at 11:20, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch for RM#1231 & RM#1237.
>>>
>>> Additionally I have shifted 'Advanced tab' after columns & constraint
>>> tab.
>>>
>>>
>>> @Thom,
>>>
>>> Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to
>>> populate "Of type" combo box as given below.
>>> I was not able to find a way to differentiate between table & composite
>>> type populating from below given query,
>>> I'll put in todo list, may be someone from community can help in future.
>>>
>>> SELECT t.oid,
>>>   quote_ident(n.nspname)||'.'||quote_ident(t.typname) AS typname
>>>   FROM pg_type t, pg_namespace n
>>> WHERE t.typtype='c' AND t.typnamespace=n.oid
>>>   AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
>>> ORDER BY typname;
>>>
>>>
>> This should work:
>>
>> SELECT c.oid,
>>   quote_ident(n.nspname)||'.'||quote_ident(c.relname) AS typname
>>   FROM pg_namespace n, pg_class c
>> WHERE c.relkind = 'c' AND c.relnamespace=n.oid
>>   AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
>> ORDER BY typname;
>>
>> Although, to avoid confusion, the "typname" alias should probably just be
>> "relname".
>>
>> Thom
>>
>
>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

[Surinder Kumar]

Hi,

Please find updated patch with following changes:
1. the sizeHandler is not calculating the position without resizing
2. Apply sizeable columns to history grid in query tool.
3. Table column *Label and Type* should not be in single line. Currently
*Backgrid* displays column and type in a single line considering it as text.
we have to extend *headerCell* class and override its render method to fix
this.

Please review.

On Mon, May 30, 2016 at 11:36 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Fri, May 27, 2016 at 6:27 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> Please find updated patch with following changes:
>>
>>1. Replaced the outdated code for *Backgrid Sizeable Columns plugin *with
>>https://github.com/FortesSolutions/backgrid-sizeable-columns library
>>because the updated code is available here.
>>2. I have figured out to calculate *offset* using the parameters of
>>listener provided, so we need not to tweak the original library code.
>>
>> As per our conversation, the sizeHandler is not calculating the position
> without resizing.
> It should calculate the position even after rendering is completed.
>
Fixed.

>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> On Fri, May 27, 2016 at 5:00 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Fri, May 27, 2016 at 4:43 PM, Dave Page  wrote:
>>>
 Hi

 On Fri, May 27, 2016 at 12:07 PM, Surinder Kumar
  wrote:
 > Hi
 >
 > Added support for Columns resizable in query tool. It allows user to
 resize
 > the table columns as much as needed.
 >
 > We are using Backgrid Sizeable Columns plugin:
 > https://github.com/WRidder/backgrid-sizeable-columns
 >
 > with one change in library on line no 185:
 > moved the following trigger event out of if condition:
 >
 > if (newWidth != oldWidth) {
 >
 > }
 >
 >
 > and added one additional parameter offset.
 > //Trigger event
 >
 > view.columns.trigger("resize", columnModel, newWidth, oldWidth,
 offset);
 >
 >
 > We are listening to this trigger event in sqleditor.js file where we
 need
 > offset
 > to calculate new table width on every resize event.

 Please ensure any changes to third party libraries are submitted
 upstream.

>>> yes, sure.
>>>

 > hence, here is the patch attached.

 ENOATTACHMENT!

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers

>>>
>>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>


column_resizable_in_query_tool_v2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1262 - Do not allow to delete the default serv

[Ashesh Vashi]

Fixes #1262 - Do not allow to delete the default server group.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=afcb62cfd67ec6c7f9a70a074afb071f5fc50f27
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/browser/server_groups/__init__.py  | 29 ++
.../templates/server_groups/server_groups.js   |  6 ++---
2 files changed, 21 insertions(+), 14 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

[Dave Page]

Yeah, I was about to reply on this too;

- Why do we need Marshmallow?

- Why do we need a role system? Perhaps in the future we might have shared
servers, and roles that cannot modify them, but not now.

- Why is the editing not done in-grid? It's only a single line per record.
Seems like an awful lot of code for what should be a simple backgrid
implementation.

On Tue, May 31, 2016 at 8:42 AM, Ashesh Vashi  wrote:

> Hi Harshal,
>
> Please find the updated patch with some improvement, we should not show
> any of the functions to the non-administrator user.
>
> * Please handle unauthorised routes call using our own wrapper function.
>Because - role_required wrapper redirect the call to unauthorised page,
> which we don't required. We needed proper ajax response.
> * Add search filter on top of grid.
> * Open the form of user, when we add new user.
> * Do not allow to add new user, if the form is not complete for the new
> user.
> * Do not allow to close the form of new user with incomplete data. (Though
> - allow it to remove it.)
> * Close the form on save button call.
> * Allow to change attributes of existing users from the grid itself.
>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
> On Tue, May 31, 2016 at 12:12 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB 
>>
>> On Mon, May 30, 2016 at 4:09 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Harshal,
>>>
>>> PFA comments as below,
>>>
>>> 1) While running setup.py for the first time, We did not handle the case
>>> to create Standard user.
>>>
>> Fixed
>>
>>
>>> 2) Save button gets enable only clicking on input text box
>>>
>> Fixed
>>
>>
>>> 3) Remove delete button from sub-node
>>>
>> Removed button.
>>
>> 4) If current user changes its own name/email, main page should reflect
>>> new changes.
>>>
>> Moved to TODO
>>
>>
>>>
>>>
>>> Can be listed as TODO
>>> 
>>> 1) Erros description is missing, for example when have user
>>> t...@test.com presnt and user try to add user same as t...@test.com we
>>> get error as "Error during saving user" it should be descriptive like
>>> "ERRPR: User {XYZ} is already exists.."
>>>
>> Fixed. (Added client side validation)
>>
>>
>>> 2) There should be an option to delete multiple users at one shot.
>>>
>> Moved to TODO
>>
>>
>>> 3) There should be an option to active/deactivate multiple users in one
>>> shot.
>>>
>> Moved to TODO
>>
>>
>>> 4) In-place editing in backgrid.
>>>
>> Moved to TODO
>>
>>
>>>
>>>
>>> Regards,
>>> Murtuza
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, May 27, 2016 at 7:02 PM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA initial patch for User management functionality.


 --
 *Harshal Dhumal*
 *Software Engineer *



 EenterpriseDB 


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers


>>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

[Harshal Dhumal]

Hi,


-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB 

On Mon, May 30, 2016 at 4:09 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Harshal,
>
> PFA comments as below,
>
> 1) While running setup.py for the first time, We did not handle the case
> to create Standard user.
>
Fixed


> 2) Save button gets enable only clicking on input text box
>
Fixed


> 3) Remove delete button from sub-node
>
Removed button.

4) If current user changes its own name/email, main page should reflect new
> changes.
>
Moved to TODO


>
>
> Can be listed as TODO
> 
> 1) Erros description is missing, for example when have user t...@test.com
> presnt and user try to add user same as t...@test.com we get error as
> "Error during saving user" it should be descriptive like "ERRPR: User {XYZ}
> is already exists.."
>
Fixed. (Added client side validation)


> 2) There should be an option to delete multiple users at one shot.
>
Moved to TODO


> 3) There should be an option to active/deactivate multiple users in one
> shot.
>
Moved to TODO


> 4) In-place editing in backgrid.
>
Moved to TODO


>
>
> Regards,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, May 27, 2016 at 7:02 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA initial patch for User management functionality.
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB 
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

[Harshal Dhumal]

Hi,

PFA updated patch for user management.

-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB 

On Mon, May 30, 2016 at 5:51 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi Harshal,
>
>
> Please find the review comments so far:
>
> *Issues:*
> 1. The UI design doesn't look interactive, especially add new user button.
>
Moved to TODO


> 2. In requirements.txt, while adding new dependent library the name of
> library and version should be separate by '==' instead of '--'
>
Fixed


> 3. Under File menu, "Users" menu item should not be visible for non-admin
> users. For now it is only disabled.
>
Moved to TODO


> 4. Change role of admin user to non-admin user, then navigate to File >
> Users. It doesn't show users in Dialog and Add user doesn't work. Instead
> it is better to reload the page. Please find attached screenshot.
>

Moved to TODO (We can write code to reload the page but we have
"onbeforeunload" listener on window which is preventing page reload unless
user clicks on "Leave page" button).


> 5. The data grid content should fill the unnecessary gap above the footer.
>
Moved to TODO (This is generic issue as I'm using common dialog)

6. The title of delete user confirmation dialog should be "Delete user ?",
> instead of "Delete User".
>
Fixed

7. The Edit and Delete column shouldn't be sortable.
>
Moved to TODO (This issue exist throughout the application)


> 8. Columns 'creation time' & 'last modified' are missing.
>

Moved to TODO. (We are not recording these user properties at this stage.
The purpose of User management functionality is to only update existing
user properties, add user and delete user.)


> 9. Password should have validation of minimum number of characters.
>
Fixed


>
> *Can be added into TODO list:*
> 1. There is no way to search a user by name or email id.
> 2. Pagination should be there if there are large number of users.
> 3. There should be a way of notifying the user once its password is
> changed by any administrator.
> 4. We can add 'created by' column.
>
All of above 4 Moved to TODO.

5. One administrator shouldn't have privilege to modify the details of
> other administrator.
> This is the role of super admin.
>
As per my offline discussion with Ashesh we don't need this.



>
>
> Thanks
> Surinder Kumar
>
> On Fri, May 27, 2016 at 7:02 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA initial patch for User management functionality.
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB 
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
diff --git a/TODO.txt b/TODO.txt
index 93abba0..05f84b3 100644
--- a/TODO.txt
+++ b/TODO.txt
@@ -45,3 +45,16 @@ Graphical Explain
 * Explanation on the statistic for the graphical explain plan.
 * Arrow colouring based on the percentage of the cost, and time taken on each
   explain node.
+
+
+User management
+---
+1. Dialog UI design improvement.
+2. Under File menu, "Users" menu item should not be visible for non-admin users. For now it is only disabled.
+3. Search a user by name or email id.
+4. Pagination should be there if there are large number of users.
+5. There should be a way of notifying the user once its password is changed by any administrator.
+6. We can add 'created by' column.
+7. User creation and last modified time.
+8. If current user changes its own name/email, main page should reflect new changes.
+9. In-place editing in backgrid.
\ No newline at end of file
diff --git a/requirements_py2.txt b/requirements_py2.txt
index a442e36..cff40b5 100644
--- a/requirements_py2.txt
+++ b/requirements_py2.txt
@@ -44,3 +44,5 @@ unittest2==1.1.0
 Werkzeug==0.9.6
 WTForms==2.0.2
 sqlparse==0.1.19
+flask-marshmallow==0.6.2
+marshmallow-sqlalchemy==0.8.1
diff --git a/requirements_py3.txt b/requirements_py3.txt
index 233b14f..70ab746 100644
--- a/requirements_py3.txt
+++ b/requirements_py3.txt
@@ -38,3 +38,5 @@ Werkzeug==0.9.6
 wheel==0.24.0
 WTForms==2.0.2
 sqlparse==0.1.19
+flask-marshmallow==0.6.2
+marshmallow-sqlalchemy==0.8.1
\ No newline at end of file
diff --git a/web/config.py b/web/config.py
index 36f1632..712ee2b 100644
--- a/web/config.py
+++ b/web/config.py
@@ -150,7 +150,7 @@ MAX_SESSION_IDLE_TIME = 60
 
 # The schema version number for the configuration database
 # DO NOT CHANGE UNLESS YOU ARE A PGADMIN DEVELOPER!!
-SETTINGS_SCHEMA_VERSION = 10
+SETTINGS_SCHEMA_VERSION = 11
 
 # The default path to the SQLite database used to store user accounts and
 # settings. This default places the file in the same directory as this
diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py
index f04897e..6d1a9b2 100644
--- a/web/pgadmin/__init__.py
+++ b/web/pgadmin/__init__.py
@@ -16,7 +16,7 @@ from 

Re: [pgadmin-hackers] PATCH: Do not allow user to delete default server-group

[Murtuza Zabuawala]

Hi,

PFA updated patch I have also included order by when we fetch server-group.

Regards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, May 31, 2016 at 11:35 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fixed the issue mentioned in RM#1262.
>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


Fixed_ServerGroup_delete_issue_v2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: Do not allow user to delete default server-group

[Murtuza Zabuawala]

Hi,

PFA patch to fixed the issue mentioned in RM#1262.



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Fixed_ServerGroup_delete_issue.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers