[pgadmin-hackers] pgAdmin 4 commit: Passing the arguments to the function appending the p

Passing the arguments to the function appending the path by reference. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b8e6fe59b17f39acf530e94734927acc704c833 Modified Files -- runtime/Server.cpp | 2 +- 1 file changed, 1

Re: [pgadmin-hackers] pgAdmin 4 commit: Use the python interpreter explicitly while running t

On Mon, Jun 20, 2016 at 9:55 PM, Dave Page wrote: > On Mon, Jun 20, 2016 at 5:15 PM, Ashesh Vashi > wrote: > > > > On Mon, Jun 20, 2016 at 9:37 PM, Dave Page wrote: > >> > >> Hi > >> > >> Is config.SERVER_MODE the best test

[pgadmin-hackers] pgAdmin 4 commit: Do not rely on config.SERVER_MODE for determining (if

Do not rely on config.SERVER_MODE for determining (if it is running from runtime, or time), instead check the environment variable PGADMIN_PORT to do that as per Dave. Branch -- master Details ---

Re: [pgadmin-hackers] pgAdmin 4 commit: Use the python interpreter explicitly while running t

On Mon, Jun 20, 2016 at 5:15 PM, Ashesh Vashi wrote: > > On Mon, Jun 20, 2016 at 9:37 PM, Dave Page wrote: >> >> Hi >> >> Is config.SERVER_MODE the best test here? pgAdmin4.py does it slightly >> differently now, to allow for users that run in

Re: [pgadmin-hackers] pgAdmin 4 commit: Use the python interpreter explicitly while running t

On Mon, Jun 20, 2016 at 9:37 PM, Dave Page wrote: > Hi > > Is config.SERVER_MODE the best test here? pgAdmin4.py does it slightly > differently now, to allow for users that run in desktop mode but > prefer to use their browser (it, in theory, also allows you have > multiple

Re: [pgadmin-hackers] pgAdmin 4 commit: Use the python interpreter explicitly while running t

Hi Is config.SERVER_MODE the best test here? pgAdmin4.py does it slightly differently now, to allow for users that run in desktop mode but prefer to use their browser (it, in theory, also allows you have multiple configurations (users) by using server mode on the desktop): # Start the web

[pgadmin-hackers] pgAdmin 4 commit: [Runtime] Setting few of the environment variables (i

[Runtime] Setting few of the environment variables (i.e. PATH and PYTHONPATH) to run the runtime with the virtual environment properly. And, also allow to use the python interpreter to be used with the background process modules. - Add binary directory of the virtual environment to PATH

[pgadmin-hackers] pgAdmin 4 commit: Use the python interpreter explicitly while running t

Use the python interpreter explicitly while running the background process from the runtime. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=800d5d71d7b6db10cf0d6ab588fa76af8e186161 Modified Files --

[pgadmin-hackers] pgAdmin Beta 2

FYI, I intend to tag beta 2 first thing tomorrow morning my time. I'll have a tarball available pretty quickly after that. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via

Re: [pgadmin-hackers] Fixed RM #1356

Another that may be worth looking into is Vaadin Elements Grid (and possibly some of the other Vaadin Element components where applicable): https://vaadin.com/elements/-/element/vaadin-grid On Mon, Jun 20, 2016 at 4:42 AM, Dave Page wrote: > > > On Mon, Jun 20, 2016 at 6:41

Re: [pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

Thanks, patch applied. On Mon, Jun 20, 2016 at 2:56 PM, Sanket Mehta wrote: > Hi, > > PFA the revised patch to resolve this issue which consists the change in > control formatter. > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Mon, Jun

[pgadmin-hackers] pgAdmin 4 commit: Ensure we properly escape data from Select2 controls.

Ensure we properly escape data from Select2 controls. Fixes #1292 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4e76a22b9941b284189f5e62bd1861078d963f4 Author: Sanket Mehta Modified Files --

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Mon, Jun 20, 2016 at 2:51 PM, Colin Beckingham wrote: > > On 20/06/16 09:33, Dave Page wrote: >> >> It's not that it's necessarily hard, it's that there are only 24 hours in >> the day to get things done. We've got a long list of improvements to make - >> some immediate

[pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

Hi, PFA the revised patch to resolve this issue which consists the change in control formatter. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Jun 13, 2016 at 3:12 PM, wrote: > Issue #1292 has been updated by Dave Page. > >- *Target version*

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On 20/06/16 09:33, Dave Page wrote: It's not that it's necessarily hard, it's that there are only 24 hours in the day to get things done. We've got a long list of improvements to make - some immediate (i.e. in time for betaX - 2 being today in fact), others for GA and others for future

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Mon, Jun 20, 2016 at 2:29 PM, Adam Brusselback wrote: > I'm just wondering what the thought process is for making the shortcuts > configurable, or why that's going to be significantly hard? I find that to > be highly desirable feature, one of the reasons being

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

I'm just wondering what the thought process is for making the shortcuts configurable, or why that's going to be significantly hard? I find that to be highly desirable feature, one of the reasons being avoiding something like this from happening (with browser bindings). Some of us have other tools

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Remove Query tool from object menu

Thanks, applied. On Mon, Jun 20, 2016 at 2:11 PM, Surinder Kumar wrote: > Hi, > > The attached patch to remove Query tool from the object menu. It is already > shown under tools menu, so no need to show under object menu. > Please review. > > Thanks, > Surinder

[pgadmin-hackers] pgAdmin 4 commit: Remove Query tool from object menu. It is already sho

Remove Query tool from object menu. It is already shown under tools menu, so no need to show under object menu. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f25e9331ffc5ed88591238ac8f68a1d5994e45f Author: Surinder Kumar

[pgadmin-hackers] [pgAdmin4][Patch]: Remove Query tool from object menu

Hi, The attached patch to remove Query tool from the object menu. It is already shown under tools menu, so no need to show under object menu. Please review. Thanks, Surinder Kumar remove_query_tool_from_object_menu.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] pgAdmin 4 commit: Add missing foreign table column options.

Add missing foreign table column options. Fixes #1351 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=40b075389fc9081b8a73edf5833b2e08a7309261 Author: Khushboo Vashi Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1351

Thanks, applied. On Mon, Jun 20, 2016 at 10:29 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix the RM #1351 - Foreign table column > options in pgAdmin 4. > > Added the functionality to add column level options in Foreign Table. > > >

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue where the save button was not getting en

Fix an issue where the save button was not getting enable when user revoke ADMIN option from Role privileges. Issue: validation callback was missing in the control model. Fixes #1302 Branch -- master Details ---

Re: [pgadmin-hackers] PATCH: To fix the issue in role node (pgAdmin4)

Thanks, applied. On Mon, Jun 20, 2016 at 12:14 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where save button was not getting enable when > user revoke ADMIN option from Role privileges. > Issue: validation callback was missing in the

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

OK, applied as-is for now. I guess all our shortcuts will probably end up being Ctrl+Shift+Something :-( On Mon, Jun 20, 2016 at 10:45 AM, Harshal Dhumal wrote: > Hi Dave, > > I tried to find unique shortcuts keys combination using function keys on > different

[pgadmin-hackers] pgAdmin 4 commit: Keyboard shortcuts in the Query Tool:

Keyboard shortcuts in the Query Tool: Execute --> Ctrl + Shift + E Explain -->Ctrl + Shift + X Explain analyze --> Ctrl + Shift + A Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=237f93591fe6500b96f18946302d4f80d8c7e9e0 Author:

[pgadmin-hackers] pgAdmin 4 commit: Allow QMAKE_[C|CXX|L]FLAGS to be set externally from

Allow QMAKE_[C|CXX|L]FLAGS to be set externally from PGADMIN_[C|CXX|LD]FLAGS environment variables respectively. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c16df45f2cad6a24eeb2a2d6e55f1d4e890aedc6 Modified Files --

[pgadmin-hackers] PATCH: To fix the issue in role node (pgAdmin4)

Hi, PFA patch to fix the issue where save button was not getting enable when user revoke ADMIN option from Role privileges. Issue: validation callback was missing in the control model. (RM#1302) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgadmin-hackers] pgAdmin 4 commit: Set the minimum value to 50 and maximum value to 2000

Set the minimum value to 50 and maximum value to 2000 for the items per page in the result grid Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c04b729c1dee14cee0b5655daece2814528cb859 Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Adding comment about setting some higher value for SQ

Adding comment about setting some higher value for SQLITE_TIMEOUT, on slower system - user may need to set the value to some higher value. This value decide - for how long SQLITE operation will wait, before throwing an operation timeout error because of the locked database. Fixes #1329 Branch

[pgadmin-hackers] pgAdmin 4 commit: Allow the python-config executable to be specified in

Allow the python-config executable to be specified in the environment. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c06ab4ac3be1526574609ee4a31d23de3f4380b Modified Files -- runtime/pgAdmin4.pro | 7 ++- 1 file changed, 6

[pgadmin-hackers] pgAdmin 4 commit: Fix runtime compatibility with newer Python versions

Fix runtime compatibility with newer Python versions Initial patch by Asser. Change restricted to Python 3.3 and above by me as PyUnicode_DecodeFSDefault was added in 3.3. Branch -- master Details ---

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Dave, I tried to find unique shortcuts keys combination using function keys on different platforms (windows, mac, linux ) but no success. Any combination of function keys with either of (or some of them together) Alt, Ctrl, Shift conflict with either browser functionality or with window

[pgadmin-hackers] [pgAdmin4][Patch]: RM #1351

Hi, Please find the attached patch to fix the RM #1351 - Foreign table column options in pgAdmin 4. Added the functionality to add column level options in Foreign Table. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py

[pgadmin-hackers] pgAdmin 4 commit: Fix debugger issues which could occur if one or more

Fix debugger issues which could occur if one or more of the ajax calls used to gather execution environment info completed in an unexpected order. To resolve this, we have callbacks from each ajax call initiate the next one so everything is guaranteed to be sequential. Fixes #1354 Fixes #1323

Re: [pgadmin-hackers] [pgAdmin4][debugger]: RM #1354 & RM #1323

Thanks, applied. On Mon, Jun 20, 2016 at 10:06 AM, Neel Patel wrote: > Hi Dave, > > Please find attached modified patch file. Do review it and let us know for > comments. > > Thanks, > Neel Patel > > On Mon, Jun 20, 2016 at 2:08 PM, Dave Page

[pgadmin-hackers] pgAdmin 4 commit: Fix date validation while creating new role.

Fix date validation while creating new role. Fixes #1370 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=01801e4acb20e97a2cb06bd9c99810ea7605d12e Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][debugger]: RM #1354 & RM #1323

Hi Dave, Please find attached modified patch file. Do review it and let us know for comments. Thanks, Neel Patel On Mon, Jun 20, 2016 at 2:08 PM, Dave Page wrote: > Hi > > On Sun, Jun 19, 2016 at 5:50 PM, Neel Patel > wrote: > > Hi Dave, > > >

[pgadmin-hackers] pgAdmin 4 commit: Fix the issue in Materialized view where user was not

Fix the issue in Materialized view where user was not able to create Materialized view with PPAS 9.5 due to incorrect template path. Fixes #1379 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac37d60c030b58fb259f61c7bc94bb29ce0f15bc Author:

Re: [pgadmin-hackers] PATCH: To fixed the issue in Materialized view (pgAdmin4)

Thanks, applied. On Mon, Jun 20, 2016 at 9:03 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue in Materialized view where user was not > able to create Materialized view with PPAS 9.5 due to incorrect template > path. > (RM#1379) > > --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1337 - Query Tool: Cannot copy result set to clipboard.

On Mon, Jun 20, 2016 at 5:16 AM, Surinder Kumar wrote: > Hi, > > Please find attached patch for RM#1337 - Query Tool: Cannot copy result set > to clipboard. > > In Query tool, add support for copy single grid row to clipboard using: > 1 ) CTRL+ c key > 2) Copy

Re: [pgadmin-hackers] Fixed RM #1356

On Mon, Jun 20, 2016 at 6:41 AM, Akshay Joshi wrote: > Hi Dave > > On Fri, Jun 17, 2016 at 9:00 PM, Dave Page wrote: > >> On Fri, Jun 17, 2016 at 4:25 PM, Ashesh Vashi >> wrote: >> > >> > On Jun 17, 2016 20:53,

Re: [pgadmin-hackers] [pgAdmin4][debugger]: RM #1354 & RM #1323

Hi On Sun, Jun 19, 2016 at 5:50 PM, Neel Patel wrote: > Hi Dave, > > make sense. We should ensure that operations happen sequentially. > Please find attached patch file for the fix. Hmm, using synchronous calls is not an option either. They're strongly discouraged,

[pgadmin-hackers] PATCH: To fixed the issue in Materialized view (pgAdmin4)

Hi, PFA minor patch to fix the issue in Materialized view where user was not able to create Materialized view with PPAS 9.5 due to incorrect template path. (RM#1379) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1379.patch

[pgadmin-hackers] pgAdmin 4 commit: Introduces the 'alertify.pgDialogBuild' function, whi

Introduces the 'alertify.pgDialogBuild' function, which will register different resize event callbacks for a particular dialog. This function needs to be executed from the 'build' function of any of the alertify dialog. Refs #1358 Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Use the same layout mechanism used as in the panel us

Use the same layout mechanism used as in the panel using elementary layout support in different dialogs. Fixes #1358. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3350eaceabf7b80d7fa444147f9907cb61752e1e Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Upgraded Alertify to v1.7.1

Upgraded Alertify to v1.7.1 This version includes the feature request about invoking the callbacks for different resize events. It will allows us to adjust the layout of the dialogs based on its width, just like we've in the panels. Branch -- master Details ---