[pgadmin-hackers] [pgAdmin4][Patch] Add formatted error message support in psycopg2

2016-03-29 Thread Akshay Joshi
eview it and let me know the review comments if any. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Psycopg_Formatted_Error.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make ch

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add formatted error message support in psycopg2

2016-03-31 Thread Akshay Joshi
Hi On Tue, Mar 29, 2016 at 8:09 PM, Akshay Joshi wrote: > Hi All > > While implementing Query Tool, I came to know we need error message's with > some extra information and also I have faced one issue regarding > asynchronous connection polling. I have added support

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add formatted error message support in psycopg2

2016-03-31 Thread Akshay Joshi
patch. Please review it and if it looks good please commit it. On Thu, Mar 31, 2016 at 12:37 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi > > On Tue, Mar 29, 2016 at 8:09 PM, Akshay Joshi .com> wrote: > >> Hi All >> >> While implementing

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add formatted error message support in psycopg2

2016-04-01 Thread Akshay Joshi
; *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi> > > On Thu, Mar 31, 2016 at 4:55 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> Please ignore the last two patches, While implementing Query T

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-07 Thread Akshay Joshi
Hi On Thu, Apr 7, 2016 at 6:01 PM, Dave Page wrote: > Hi > > On Thu, Apr 7, 2016 at 10:07 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >>> - The View Data menu option should be on the Object menu >>> >> >>OK.

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-07 Thread Akshay Joshi
Hi On Thu, Apr 7, 2016 at 6:38 PM, Dave Page wrote: > > > On Thu, Apr 7, 2016 at 2:03 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Thu, Apr 7, 2016 at 6:01 PM, Dave Page wrote: >> >>> Hi >>> &g

[pgadmin-hackers] [pgAdmin4][Patch] Add affected row count support in psycopg2

2016-04-12 Thread Akshay Joshi
Hi All While implementing Query Tool, we need the affected row count for the queries (DELETE, SELECT, UPDATE etc..) executed on the database server. I have implemented the same. Attached is the patch file, please review it and let me know the review comments if any. -- *Akshay Joshi

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-15 Thread Akshay Joshi
On Thu, Apr 14, 2016 at 7:40 PM, Dave Page wrote: > Hi > > On Thu, Apr 14, 2016 at 1:58 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> I have fixed review comments given by Dave and couple of them are >> remaining >&

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-21 Thread Akshay Joshi
we have CodeMirror. - The layout of the result tabs should be maintained if new Query Tool or Edit Grid tabs are opened. To solve the above I need some help/suggestions here. On Fri, Apr 15, 2016 at 1:22 PM, Dave Page wrote: > Thanks - committed. > > On Fri, Apr

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-05-02 Thread Akshay Joshi
Hi All Added support of code-folding for QueryTool. Please ignore previous patch, attached is the new combined patch. On Thu, Apr 21, 2016 at 2:00 PM, Akshay Joshi wrote: > Hi > > I have fixed following review comments given by Dave and attached is the > patch file: > >-

Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Akshay Joshi
On Fri, May 6, 2016 at 1:54 PM, Dave Page wrote: > All, > > I'm pleased to announce that Akshay Joshi has been added to the > pgAdmin 4 project as our newest committer. Akshay has been working on > pgAdmin 3 for a number of years now, and has done some excellent work &

[pgadmin-hackers] pgAdmin 4 commit: Fixed below review comments

2016-05-06 Thread Akshay Joshi
Fixed below review comments - Removed the "lineWrapping" option from the codemirror textarea because it was creating issue in the code folding. - Handle the values while depositing during debugging. - Properly handle the Array values while saving it to sqlite database and displayed in input dia

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-05-06 Thread Akshay Joshi
>>> >>>>>> - Let's make the stack pane tab part of the tabset at the bottom of >>>>>> the debugger, and ensure docking etc. works so tabs can be split off >>>>>> and arranged around the main source window. >>>>>> >>>>> >>>>> Fixed. Now stack pane will be displayed along with another panel at >>>>> bottom and also docking has been introduced for all the panels so tabs >>>>> will >>>>> be arranged around main debugger panel. >>>>> >>>>> >>>>>> >>>>>> - Stepping is quite slow. What's causing that? I wonder if we really >>>>>> need to have all the one line SQL templates - they're probably quite >>>>>> expensive to process. >>>>>> >>>>> Fixed. This is due to polling timeout was high (1 second) and we are >>>>> getting delay in getting the results. Now polling timeout has reduced to >>>>> to >>>>> 200ms. >>>>> >>>>>> >>>>>> - Is backend_running.sql required? I've removed both versions as I >>>>>> can't find any references to them. Are any other templates not >>>>>> required? >>>>>> >>>>> Ok. No other templates. >>>>> >>>>>> >>>>>> Will log any other issues that come up in further work. >>>>>> >>>>>> > Below functionalities are implemented but testing are pending. >>>>>> > >>>>>> > Trigger functions need to test with the debugger. >>>>>> > Functions are tested with data types (like text, integer etc.) but >>>>>> it needs >>>>>> > to be tested with all the data types for direct debugging. >>>>>> > Functions/Procedures need to test with PPAS 9.2 and earlier version >>>>>> where >>>>>> > debugger version is different. >>>>>> >>>>>> Thanks! >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Added dependency of messages 'pgadmin.browser.message

2016-05-06 Thread Akshay Joshi
Added dependency of messages 'pgadmin.browser.messages' in backfrom.pgadmin.js Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7867adaa5396d66a1fbb09e91cbb7d227e3a55df Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 2

[pgadmin-hackers] pgAdmin 4 commit: Fixed below review comments for QueryTool

2016-05-06 Thread Akshay Joshi
Fixed below review comments for QueryTool - The button bar be moved out into an HTML template - create.sql should perhaps be renamed to insert.sql - The "Add Row" button only works if you're on the last page of the resultset. - Use one wcDocker instead of two - Added support of code folding B

Re: [pgadmin-hackers] PATCH: Graphincal explain integrated in sql editor

2016-05-10 Thread Akshay Joshi
lines are not proper" bug is fixed in the same >>>>> which was reported by Dave in previous patch. >>>>> >>>>> Regards, >>>>> Sanket Mehta >>>>> Sr Software engineer >>>>> Enterprisedb >>>>> >>>>>

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue 'Reload Configuration' option is also ena

2016-05-10 Thread Akshay Joshi
Fixed issue 'Reload Configuration' option is also enabled on database node while it should only be enabled on server node Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8cfca280d4b2b44688706e199345f4b4e29dad5a Author: Neel Patel Modified Fil

Re: [pgadmin-hackers] [pgAdmin4]: Reload configuration Fix

2016-05-10 Thread Akshay Joshi
o make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgadmin-hackers] [pgAdmin4][Patch]: View and Materialised View Nodes

2016-05-10 Thread Akshay Joshi
"Event" in Rule node not working. - As per pgAdmin3 user can't be able to create columns inside View node. - User can't be able to delete/drop columns and system generated Rule's, Trigger's etc.. - Found one issue when changing value of "Security Barrier"

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Akshay Joshi
, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch for changing server password. >>> >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer * >>> >>&

Re: [pgadmin-hackers] PATCH: Added "Named restore point" functionality (pgAdmin4)

2016-05-12 Thread Akshay Joshi
on >>> >>>>> server. >>> >>>> >>> >>>> Create named restore point is action restricted to the superuser >>> only. >>> >>>> Please check that in the menu enable/disable functionality. >>> >>>> >>> >>>> The check also applicable to 'relaod configuration'. >>> >>>>> >>> >>>>> >>> >>>>> -- >>> >>>>> Regards, >>> >>>>> Murtuza Zabuawala >>> >>>>> EnterpriseDB: http://www.enterprisedb.com >>> >>>>> The Enterprise PostgreSQL Company >>> >>>>> >>> >>>>> >>> >>>>> -- >>> >>>>> Sent via pgadmin-hackers mailing list ( >>> pgadmin-hackers@postgresql.org) >>> >>>>> To make changes to your subscription: >>> >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>>>> >>> >>>> >>> >>> >>> >> >>> >> >>> >> >>> >> -- >>> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org >>> ) >>> >> To make changes to your subscription: >>> >> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >> >>> > >>> > >>> > >>> > -- >>> > Dave Page >>> > Blog: http://pgsnake.blogspot.com >>> > Twitter: @pgsnake >>> > >>> > EnterpriseDB UK: http://www.enterprisedb.com >>> > The Enterprise PostgreSQL Company >>> >>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Added input validation and title of the prompt for 'N

2016-05-12 Thread Akshay Joshi
Added input validation and title of the prompt for 'Named Restore point' functionality Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83b6a04763ec0bd87cec39394cebdae42e238646 Author: Murtuza Zabuawala Modified Files -- .../server

Re: [pgadmin-hackers] PATCH: Added "Named restore point" functionality (pgAdmin4)

2016-05-12 Thread Akshay Joshi
tp://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, May 12, 2016 at 4:45 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Murtuza >> >> Below are my review comments >> >>- Please change the title from &quo

Re: [pgadmin-hackers] variable scope issue in server js [pgadmin4]

2016-05-12 Thread Akshay Joshi
arshal Dhumal* > *Software Engineer * > > > > EenterpriseDB <http://www.enterprisedb.com> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Fixed variable scope issue in server.js

2016-05-12 Thread Akshay Joshi
Fixed variable scope issue in server.js Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=180630ce0e6046aa59825876321a54d58cc48082 Author: Harshal Dhumal Modified Files -- .../servers/templates/servers/servers.js | 20 +++

Re: [pgadmin-hackers] variable scope issue in server js [pgadmin4]

2016-05-12 Thread Akshay Joshi
> > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB <http://www.enterprisedb.com> > > On Thu, May 12, 2016 at 7:38 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Thu, May 12, 2016 at 5:0

[pgadmin-hackers] pgAdmin 4 commit: Fixed cStringIO and StringIO module compatibility in

2016-05-12 Thread Akshay Joshi
Fixed cStringIO and StringIO module compatibility in python Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e4e1640e7eefcf7721c35e3c9d64b77c23371dc Modified Files -- web/pgadmin/misc/bgprocess/process_executor.py | 4 ++-- web/pgadm

Re: [pgadmin-hackers] [pgAdmin4][patch] : cStringIO and StringIO module compatibility in python

2016-05-12 Thread Akshay Joshi
python3. > > Do review it and let us know for comments. > > Thanks, > Neel Patel > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers >

[pgadmin-hackers] pgAdmin 4 commit: Change server password feature

2016-05-13 Thread Akshay Joshi
Change server password feature Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4816f5ed125e8c8c60ac80d519d2fbce44ec21ff Author: Harshal Dhumal Modified Files -- .../browser/server_groups/servers/__init__.py | 102 -

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-13 Thread Akshay Joshi
h Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Harshal >>> >>> Below are my review comments : >>> >>>- Facing err

[pgadmin-hackers] pgAdmin 4 commit: Fixed typo for acl in tablespace node

2016-05-13 Thread Akshay Joshi
Fixed typo for acl in tablespace node Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=174363c9a7d380b9599fdb029997fa2c925322e0 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/server_groups/servers/tablespaces/__init

Re: [pgadmin-hackers] PATCH: Fixed typo in Tablespace node (pgAdmin4)

2016-05-13 Thread Akshay Joshi
The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Fixed following issues:

2016-05-13 Thread Akshay Joshi
Fixed following issues: 1) Grant wizard close issue. 2) Moved grant wizard specific css from wizard.css to grant_wizard.css 3) removed 'ajs_content' css from wizard.css causing padding issue in alertify dialog Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadm

Re: [pgadmin-hackers] PATCH: FTS configuration node

2016-05-13 Thread Akshay Joshi
gt; >>>> >>>> Regards, >>>> Sanket Mehta >>>> Sr Software engineer >>>> Enterprisedb >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgadmin-hackers][pgAdmin4][Patch]: Load/Save file in query tool

2016-05-13 Thread Akshay Joshi
Hi Surinder On 13-May-2016 7:12 pm, "Surinder Kumar" wrote: > > Hi, > > Please find updated patch > > Following are the review comments given by Akshay: > 1. Save button shouldn't enable when data grid is loaded. > 2. CodeMirror text area change event should only be enabled when query tool is loa

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue while using decode() without checking typ

2016-05-16 Thread Akshay Joshi
Fixed issue while using decode() without checking type of the variable. Type maybe string or byte. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76087f3df3d4cc1993fdfc679d942cd5a7c84602 Author: Ashesh Vashi Modified Files -- web

Re: [pgadmin-hackers] [pgAdmin4][Patch]: View and Materialised View Nodes

2016-05-16 Thread Akshay Joshi
es occurred because some code was missing in tables > subnodes patch. > Now I have shared the code related to table subnodes with harshal to > integrate in tables patch. > > This patch has dependency on tables patch. > > On Tue, May 10, 2016 at 7:46 PM, Akshay Joshi < > aksh

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue change 'Auto Commit' option from preferen

2016-05-17 Thread Akshay Joshi
Fixed issue change 'Auto Commit' option from preferences not reflacted properly on UI and also not set the class variable Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=216b6b16b5026404516613ec407564a31f53bbd3 Modified Files -- ..

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue of getting/setting preferences options fo

2016-05-17 Thread Akshay Joshi
Fixed issue of getting/setting preferences options for 'Explain' Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8312efe927bd38615f1071608504d9a2987e1530 Modified Files -- web/pgadmin/tools/sqleditor/__init__.py| 12 +-

[pgadmin-hackers] pgAdmin 4 commit: Remove testing code

2016-05-17 Thread Akshay Joshi
Remove testing code Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7d5d6dad28fd359c3fe05eee24f02a95dc3c3e7d Modified Files -- web/pgadmin/test/__init__.py | 87 - web/pgadmin/test/static/js/test

[pgadmin-hackers] [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

2016-05-18 Thread Akshay Joshi
ew it and let me know the review comments (if any). -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* SQLAutoCompletion.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to

Re: [pgadmin-hackers] [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

2016-05-18 Thread Akshay Joshi
Just to update Multi line support is not there right now. On Wed, May 18, 2016 at 8:09 PM, Akshay Joshi wrote: > Hi All > > I have implemented the sql auto complete feature for Query Tool in > pgAdmin4. To achieve this I have analyzed the code of "*pgcli (*http:// > pgcli.

[pgadmin-hackers] pgAdmin 4 commit: Change the priority of Tools menu item

2016-05-19 Thread Akshay Joshi
Change the priority of Tools menu item Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a9b331df6b4d554d8db6850cd306d9cf767b044 Modified Files -- .../server_groups/servers/templates/servers/servers.js | 6 +++--- web/pgadmin/t

Re: [pgadmin-hackers] [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

2016-05-19 Thread Akshay Joshi
Hi All Today I have added support for multi line and also improve searching logic. Please ignore the last patch. Attached is the new patch. Please review it and let me know the review comments (if any). On Wed, May 18, 2016 at 8:18 PM, Akshay Joshi wrote: > Just to update Multi line support

Re: [pgadmin-hackers] PATCH: FTS configuration node

2016-05-19 Thread Akshay Joshi
SQL Company > <http://www.enterprisedb.com/> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi> > >> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>&

[pgadmin-hackers] pgAdmin 4 commit: Added support for FTS configuration node

2016-05-19 Thread Akshay Joshi
Added support for FTS configuration node Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6895da9cbca9731b559c52df385a0ed5dcf7 Author: Sanket Mehta Modified Files -- .../schemas/fts_configurations/__init__.py | 939 +

[pgadmin-hackers] pgAdmin 4 commit: Implementation of Table, Column, Index, Trigger, Cons

2016-05-20 Thread Akshay Joshi
Implementation of Table, Column, Index, Trigger, Constraints and Rule Node. - Table, Column, Index and Trigger (Author:- Murtuza Zabuawala) - Constraints Primary Key/Unique/Check/Foreign Key/Exclusion with integration into Table node (Author:- Harshal Dhumal) - Rule (Author:- Surinder Kumar

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-20 Thread Akshay Joshi
gt; is removed then constraint will also remove the column "col2" from it's > definition. > > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB <http://www.enterprisedb.com> > > > > -- > Sent via pgadmin-hackers m

[pgadmin-hackers] pgAdmin 4 commit: Implementation of View & Materialized View

2016-05-20 Thread Akshay Joshi
Implementation of View & Materialized View Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ecde42cbed4f8238c3bbfe945e26da9f6eefdb79 Author: Surinder Kumar Modified Files -- .../servers/databases/schemas/views/__init__.py| 1471

Re: [pgadmin-hackers] Stalled post to pgadmin-hackers

2016-05-20 Thread Akshay Joshi
and I remove it then >> click on SQL there is no sql generated. >> > Fixed. > >> >> >> Regards, >> Murtuza >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Added Insert/Delete/Update script functionality for f

2016-05-24 Thread Akshay Joshi
Added Insert/Delete/Update script functionality for foreign table objects Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa1c283514d61dd9949eaaed06cfe2e80648f1d4 Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/fo

Re: [pgadmin-hackers] PATCH: CREATE Script Initial patch (pgAdmin4)

2016-05-24 Thread Akshay Joshi
hu, May 12, 2016 at 7:52 PM, Murtuza Zabuawala < >>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> PFA patch to add CREATE Script functionality for database objects. >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1275 Issue with Query tool for PPAS - not show

2016-06-03 Thread Akshay Joshi
Fixes #1275 Issue with Query tool for PPAS - not showing the correct output Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1bd37d1f76f23982ffb9f009863f7600f2a9 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqle

Re: [pgadmin-hackers] PATCH: Fix issue in Query tool not showing correct output (pgAdmin4)

2016-06-03 Thread Akshay Joshi
gt; Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1303 Query with Order by clause is not working

2016-06-03 Thread Akshay Joshi
Fixes #1303 Query with Order by clause is not working in Query Tool Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=967159664e617a04d86d62ed7652600d42822536 Modified Files -- web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqledi

[pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Akshay Joshi
;items_per_page" minimum value is 1. Attached is the patch file. Please review it. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_1356.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@pos

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Akshay Joshi
On Wed, Jun 15, 2016 at 5:25 PM, Dave Page wrote: > Hi > > On Wed, Jun 15, 2016 at 11:27 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> I have fixed RM #1356 "Query tool enhancement". I have added the logic to >> pr

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Akshay Joshi
Hi On Wed, Jun 15, 2016 at 5:54 PM, Dave Page wrote: > > > On Wed, Jun 15, 2016 at 1:16 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, Jun 15, 2016 at 5:44 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Akshay Joshi
Hi Please ignore the last patch. Attached is the latest patch. Please review it. On Wed, Jun 15, 2016 at 9:10 PM, Akshay Joshi wrote: > Hi > > On Wed, Jun 15, 2016 at 5:54 PM, Dave Page wrote: > >> >> >> On Wed, Jun 15, 2016 at 1:16 PM, Ashesh Vashi < >&g

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Akshay Joshi
mental > improvements, send them as you have them. > Sure. > > On Wed, Jun 15, 2016 at 4:50 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> Please ignore the last patch. Attached is the latest patch. Please review >> it.

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Akshay Joshi
Hi Dave On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi wrote: > > > On Thu, Jun 16, 2016 at 2:35 PM, Dave Page wrote: > >> Thanks, patch applied. >> >> However, whilst I was testing, I saw just how slow the tool is: >> >> SELECT * FROM pg_attribute >

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Akshay Joshi
ote: >> >>> >>> >>> On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote: >>> >>>> >>>> >>>> On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi < >>>> akshay.jo...@enterprisedb.com> wrote: >>>> >

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Akshay Joshi
On Thu, Jun 16, 2016 at 6:09 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wr

[pgadmin-hackers] pgAdmin 4 commit: Remove recusive call of _wait_timeout() due to which

2016-06-16 Thread Akshay Joshi
Remove recusive call of _wait_timeout() due to which python server is crashing Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc295f94a3712d857c353853ffab33ee02db30fb Author: Ashesh Vashi Modified Files -- web/pgadmin/utils/driver

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-17 Thread Akshay Joshi
Hi Dave On Thu, Jun 16, 2016 at 6:48 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 6:09 PM, Dave Page wrote: >> >>> >>> &g

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-19 Thread Akshay Joshi
Hi Dave On Fri, Jun 17, 2016 at 9:00 PM, Dave Page wrote: > On Fri, Jun 17, 2016 at 4:25 PM, Ashesh Vashi > wrote: > > > > On Jun 17, 2016 20:53, "Dave Page" wrote: > >> > >> > >> > >> On Fri, Jun 17, 2016 at 4:04 PM, Akshay J

[pgadmin-hackers] pgAdmin 4 commit: Set the minimum value to 50 and maximum value to 2000

2016-06-20 Thread Akshay Joshi
Set the minimum value to 50 and maximum value to 2000 for the items per page in the result grid Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c04b729c1dee14cee0b5655daece2814528cb859 Modified Files -- web/pgadmin/tools/sqleditor/

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-06-29 Thread Akshay Joshi
t; > > EnterpriseDB UK: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] Used font awesome icon instead of 'Add' caption for Add button

2016-07-26 Thread Akshay Joshi
Hi All I have used font awesome icon (+) for add button instead of caption "Add" where ever possible. Attached is the patch. Please review it and let me know the review comments. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 97

Re: [pgadmin-hackers] Used font awesome icon instead of 'Add' caption for Add button

2016-07-26 Thread Akshay Joshi
Hi Forgot to add css changes. Attached is the modified patch. On Tue, Jul 26, 2016 at 1:03 PM, Akshay Joshi wrote: > Hi All > > I have used font awesome icon (+) for add button instead of caption "Add" > where ever possible. Attached is the patch. Please review it and le

[pgadmin-hackers] Customisable delete row message

2016-07-31 Thread Akshay Joshi
review it and let me know the review comments if any. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* custom_delete_msg.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make chang

Re: [pgadmin-hackers] RM #1250 Collection node counts

2016-08-08 Thread Akshay Joshi
On Mon, Aug 8, 2016 at 5:33 PM, Dave Page wrote: > Hi > > On Mon, Aug 8, 2016 at 11:39 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> I have fixed the RM#1250 "Collection node counts". To fix this RM

Re: [pgadmin-hackers] RM #1250 Collection node counts

2016-08-09 Thread Akshay Joshi
; > On Mon, Aug 8, 2016 at 1:18 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Mon, Aug 8, 2016 at 5:33 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Aug 8, 2016 at 11:39 AM, Akshay Joshi < >>>

[pgadmin-hackers] RM #1461 Query tool button/menu inconsistencies

2016-08-09 Thread Akshay Joshi
Hi All Attached is the patch to fix RM #1461 Query tool button/menu inconsistencies. Please review it and let me know the review comments. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_1461.patch Description: Binary data -- Sent via

[pgadmin-hackers] Fix for RM 1252 Support CREATE LANGUAGE

2016-08-12 Thread Akshay Joshi
Hi All I have fixed RM #1252 "Support CREATE LANGUAGE". Attached is the patch file, please review it and let me know the review comments. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_1252.patch Description: Binary data --

[pgadmin-hackers] Fixes RM #1453 Reduce menu bar height

2016-08-18 Thread Akshay Joshi
Hi All I have fixed the RM #1453 "Reduce menu bar height". As per comment in the RM, I have kept size to 40px. Attached is the patch file, please review it and let me know the review comments. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 97

[pgadmin-hackers] pgAdmin 4 commit: Fixed typo in security labels macro Fixes #1457

2016-08-18 Thread Akshay Joshi
Fixed typo in security labels macro Fixes #1457 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e0a61f5564bb9b2dcf7fa90fc7f36d9c748ac5b Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/templates/macros/schemas/sec

Re: [pgadmin-hackers] PATCH: Fixed typo in security labels macro (pgAdmin4)

2016-08-18 Thread Akshay Joshi
//www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal

[pgadmin-hackers] Fixes RM #1567 Exception display if select Font size less then 1 for SQL text

2016-08-19 Thread Akshay Joshi
Hi All I have fixed the RM #1567 "Exception display if select Font size less then 1 for SQL text". Attached is the patch file, please review it and let me know the review comments. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] Fixed RM #1209 Trigger issues through right click

2016-08-23 Thread Akshay Joshi
is mentioned in the RM #1209. Attached is the patch file, please review it and let me know the review comments (if any) -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_1209.patch Description: Binary data -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Trigger issues through right click. Fixes #1209

2016-08-23 Thread Akshay Joshi
Trigger issues through right click. Fixes #1209 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e016869ad5b0377091ffd909ac9d5982e5574905 Modified Files -- .../templates/trigger/sql/9.1_plus/create.sql | 7 ++- .../trigger/sql/9

[pgadmin-hackers] pgAdmin 4 commit: domain node: id and pid is not being generated. Fixes

2016-08-25 Thread Akshay Joshi
domain node: id and pid is not being generated. Fixes #1586 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05473a7a35b0c09b73a5615a07cfe300ffd893bf Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/databases/sc

Re: [pgadmin-hackers] PATCH: id and pid is not being sent in response (pgAdmin4)

2016-08-25 Thread Akshay Joshi
ew. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgres

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-25 Thread Akshay Joshi
ostgreSQL Company >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Internal sever error displayed if create New user map

2016-08-25 Thread Akshay Joshi
Internal sever error displayed if create New user mapping with public user. Fixes #1468 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b72448ec92d725bd711e4449045830c5c8369e0 Modified Files -- .../user_mapping/templates/user_mapp

[pgadmin-hackers] pgAdmin 4 commit: Implemented Synonym node for EPAS

2016-08-26 Thread Akshay Joshi
Implemented Synonym node for EPAS Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a78dd7ad3e9361f9c3b7f1d9d593fe685eb3f66 Author: Murtuza Zabuawala Modified Files -- .../packages/templates/package/js/package.js | 30 +- .../

Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)

2016-08-26 Thread Akshay Joshi
tached) > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Aug 25, 2016 at 4:34 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Murtuza >> >> Follo

[pgadmin-hackers] pgAdmin 4 commit: Getting 'AttributeError' in pgadmin4/web/pgadmin/brow

2016-08-26 Thread Akshay Joshi
Getting 'AttributeError' in pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py. Fixes #1464 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b05464a04a533a36f30f808b1bc0ab6d3062180 Modified Files -- web/pgadmin/browser/

[pgadmin-hackers] pgAdmin 4 commit: SqlFieldControl enhancements

2016-08-29 Thread Akshay Joshi
SqlFieldControl enhancements Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d75eac1177c3c1f890f3423a0b31e2e1b0b3706 Author: Surinder Kumar Modified Files -- web/pgadmin/static/css/overrides.css | 11 +++ web/pgadmin/s

Re: [pgadmin-hackers] [pgAdmin4][Patch]: SqlFieldControl enhancements

2016-08-29 Thread Akshay Joshi
ight. set *line-height *css property to > fix the issue. > > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: &

[pgadmin-hackers] pgAdmin 4 commit: Set break point option should present in pgAdmin4 for

2016-08-29 Thread Akshay Joshi
Set break point option should present in pgAdmin4 for trigger. Fixes #1226 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5249f2e18c32a403a96b418669da738e50357c7 Author: Neel Patel Modified Files -- web/pgadmin/tools/debugger/__i

Re: [pgadmin-hackers] [pgAdmin4][patch]: RM #1226

2016-08-29 Thread Akshay Joshi
> trigger and trigger function node. Now with this patch, user can able to >> debug trigger function. >> >> Please review it and let us know for any comments. >> >> Thanks, >> Neel Patel >> >> >> -- >> Sent via pgadmin-hackers maili

[pgadmin-hackers] pgAdmin 4 commit: Debugger listener starting error displayed if user tr

2016-08-29 Thread Akshay Joshi
Debugger listener starting error displayed if user try to debug plpgsql cs_fmt_browser_version function that contains parameters. Fixes #1238 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c6f6609bc3dbe2dd61b5b92802389e2b310006e Author: Neel

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1238

2016-08-29 Thread Akshay Joshi
; formed proper SQL and now user can debug the function mentioned in RM case. >> >> Please review it and let us know for any comments. >> >> Thanks, >> Neel Patel >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)

[pgadmin-hackers] pgAdmin 4 commit: SlickGrid Integration in to query tool. Fixes #1618

2016-08-29 Thread Akshay Joshi
SlickGrid Integration in to query tool. Fixes #1618 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c56e4667df7979fe23fab0a0ee2f7809f144ff97 Author: Murtuza Zabuawala Modified Files -- libraries.txt

Re: [pgadmin-hackers] PATCH: SlickGrid integration in query tool (pgAdmin4)

2016-08-29 Thread Akshay Joshi
sedb.com> wrote: >> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> -- Forwarded message -- >>> From: Murtu

[pgadmin-hackers] Re: RM#1387 [Add-on PATCH] Bad handling of missing connection database server

2016-09-05 Thread Akshay Joshi
>> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi> >> >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise

[pgadmin-hackers] pgAdmin 4 commit: Improve the logic for Bad handling of missing connect

2016-09-06 Thread Akshay Joshi
Improve the logic for Bad handling of missing connection database server RM #1387 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ac65070bc791e1fc8fb0a9c72808f60d48471d7 Author: Ashesh Vashi Modified Files -- .../browser/server_g

[pgadmin-hackers] Re: RM#1387 [Add-on PATCH] Bad handling of missing connection database server

2016-09-06 Thread Akshay Joshi
Code looks good to me. Patch applied. On Tue, Sep 6, 2016 at 12:05 PM, Akshay Joshi wrote: > > > On Fri, Sep 2, 2016 at 7:49 PM, Dave Page wrote: > >> Akshay, can you review/commit this please? >> > > Sure. > >> >> Thanks. >> >> On

[pgadmin-hackers] [pgAdmin4][Patch]: RM 1847 SQL script generated by pgAdmin 4 to create table has errors.

2016-10-14 Thread Akshay Joshi
Hi All Please find the attached patch to fix the RM #1847 SQL script generated by pgAdmin 4 to create table has errors. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_1847.patch Description: Binary data -- Sent via pgadmin-hackers

  1   2   3   4   >