Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
Good point. How about just versioned_loader? On Fri, Jan 27, 2017 at 4:40 PM, George Gelashvili wrote: > That would work, but the versioned template loader can load anything that is > a template, as it extends from DispatchingJinjaLoader > > On Fri, Jan 27, 2017 at 11:39 AM, Dave

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
sql_loader ? On Fri, Jan 27, 2017 at 4:38 PM, George Gelashvili wrote: > Thanks! > Did you have a name in mind? We're not sure we could come up with a clear > name in fewer words. > > On Fri, Jan 27, 2017 at 11:27 AM, Dave Page wrote: >> >> Scrub that Khush

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-27 Thread Dave Page
On Fri, Jan 27, 2017 at 4:11 PM, Dave Page wrote: > On Thu, Jan 26, 2017 at 10:40 PM, George Gelashvili > wrote: >> instead of that patch, please use this no-zombies version that kills the >> started process group instead of pid-only. > > Very cool :-). The only minor ann

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
Scrub that Khushboo - Murtuza, can you review on Monday please? I'm being told Khushboo is on the critical path for something else at the moment. On Fri, Jan 27, 2017 at 4:22 PM, Dave Page wrote: > Very nice indeed! I didn't realise we'd ended up with quite so many >

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
versions. >> >> Cheers, >> George & Tira > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http:

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-27 Thread Dave Page
ould be the default). Of course, it should still be possible to just run any single test. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgad

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-27 Thread Dave Page
On Thu, Jan 26, 2017 at 7:22 PM, Jan Alexander Steffens wrote: > On Thu, Jan 26, 2017 at 3:58 PM Dave Page wrote: >> >> In the meantime, I'm thinking something like the attached patch would >> be more appropriate. The only issue I can find with it at the moment >&

[pgadmin-hackers] pgAdmin 4 commit: Request Six>=1.9.0 as the current version is 1.10.0 a

2017-01-27 Thread Dave Page
Request Six>=1.9.0 as the current version is 1.10.0 and it gets pre-installed in every new virtualenv. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=42d3121369df49e67a4556c7191466f4fd1014a2 Modified Files -- requirements_py2.txt

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-26 Thread Dave Page
> > On Thu, Jan 26, 2017 at 6:14 AM, Dave Page wrote: > >> Hi >> >> On Wed, Jan 25, 2017 at 8:02 PM, Raffi Holzer wrote: >> >>> As a summary of our findings in writing: >>> >>> Below is a table of user needs we discovered and solutions

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-26 Thread Dave Page
Hi On Wed, Jan 25, 2017 at 2:35 PM, Jan Alexander Steffens wrote: > > > On Wed, Jan 25, 2017 at 2:57 PM Dave Page wrote: >> >> One where the virtualenv is in a path that's not related to the >> location of the runtime. If I'm reading the code correctly, you&

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-26 Thread Dave Page
sions on what to change, and >>> focussing efforts in the areas where we gain most benefit. Of course, >>> the resources to do the work are also critical - the current team >>> already have a good years worth of work in various additional features >>> and improv

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-25 Thread Dave Page
of work in various additional features and improvements. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-25 Thread Dave Page
On Wed, Jan 25, 2017 at 1:43 PM, Jan Alexander Steffens wrote: > On Wed, Jan 25, 2017 at 12:39 PM Dave Page wrote: >> >> As far as I can see, this breaks usage in development environments, or >> any configurations where the Python code may be separated from the >> runt

[pgadmin-hackers] pgAdmin 4 commit: Enable/disable NULLs and ASC/DESC options for index c

2017-01-25 Thread Dave Page
Enable/disable NULLs and ASC/DESC options for index columns and exclusion constraints appropriately. Fixes #2061. Fixes #1840. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e01cf748eafcb53c4040500c099f2e06fabf8ea8 Author: Surinder Kumar Mod

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2017-01-25 Thread Dave Page
s_applicable' which is set to true for access > method 'btree'. > If its is true, the values for options 'ASC/DESC' and 'NULLS' are included > in 'create' sql for exclusion and index otherwise not. > > Please find updated patch and review

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-25 Thread Dave Page
ot;result":null,"success":0} The payload sent via PUT to http://127.0.0.1:5050/browser/database/obj/1/1/12403 was: {"id":12403,"variables":{"changed":[{"role":"pgweb","name":"bytea_output","value":&quo

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-25 Thread Dave Page
Company > > On Fri, Jan 20, 2017 at 6:59 PM, Dave Page wrote: >> >> FYI, I've reverted this patch for now, as I found it was causing other >> problems. >> >> On Fri, Jan 20, 2017 at 5:40 AM, Murtuza Zabuawala >> wrote: >> > Let

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-25 Thread Dave Page
kage is at > https://pkgbuild.com/~heftig/packages/pgadmin4/PKGBUILD . The interesting > stuff is in the build() and package() functions, which should be > self-explanatory. As far as I can see, this breaks usage in development environments, or any configurations where the Python code may b

Re: [pgadmin-hackers] User Research Findings into PgAdmin

2017-01-25 Thread Dave Page
column names @ ~3:03 and the comment on the bottom left @ ~3:22 (this is a great example of why email is better than a video :-) ). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmi

[pgadmin-hackers] pgAdmin 4 commit: Update copyright year. Fixes #2109

2017-01-25 Thread Dave Page
Update copyright year. Fixes #2109 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ebaf56cc4f30c1c998c9c9dc8a5391f734b9d1b Modified Files -- pkg/win32/Resources/license.rtf | Bin 1262 -> 1262 bytes 1 file changed, 0 insertions(+),

Re: [pgadmin-hackers] [Patch] Fix the Reset Statistic for a table pop up message

2017-01-24 Thread Dave Page
p://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake

[pgadmin-hackers] pgAdmin 4 commit: Fix Reset Statistics operation for which the popup me

2017-01-24 Thread Dave Page
Fix Reset Statistics operation for which the popup messages weren't displaying correctly. Fixes #2091 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29a6f2e1244579bfdc238bd9d026d2f20ea663d6 Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: A little message cleanup.

2017-01-24 Thread Dave Page
A little message cleanup. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=801c7688a39ad2ad2f52c3298962552b185476ba Modified Files -- .../server_groups/servers/databases/schemas/tables/__init__.py | 6 +++--- 1 file changed, 3 in

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-24 Thread Dave Page
ror: web/regression/test_utils.py: patch does not apply :-( > On Fri, Jan 20, 2017 at 10:38 AM, Dave Page wrote: >> >> On Thu, Jan 19, 2017 at 10:07 PM, George Gelashvili >> wrote: >> > >> > Here is an updated patch which starts the server up when the test starts &

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-20 Thread Dave Page
and >> it failed with the same error on the second and third as well, long >> after I clicked OK on the prompt): >> >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/acceptance/test_connects_to_database.py", >> line 32, in

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-20 Thread Dave Page
4 browser?} (Session info: chrome=55.0.2883.95) (Driver info: chromedriver=2.27.440174 (e97a722caafc2d3a8b807ee115bfb307f7d2cfd9),platform=Mac OS X 10.12.1 x86_64) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin

Re: [pgadmin-hackers][Patch] Python 3 compatibility

2017-01-20 Thread Dave Page
no attribute 'has_key' > > Please find attached a fix for this. > > - George & Tira > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pga

[pgadmin-hackers] pgAdmin 4 commit: Python 3 fix for the regression tests

2017-01-20 Thread Dave Page
Python 3 fix for the regression tests Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4d4cffc608c44a5574fbe433ab9fa1f9fbd58ed Author: George Gelashvili Modified Files -- web/regression/test_utils.py | 2 +- 1 file changed, 1 insert

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-20 Thread Dave Page
in/browser/server_groups/servers/databases/tests/utils.py", >> line 149, in disconnect_database >> assert db_con.status_code == 200 >> AssertionError >> >> - Tira & George >> >> >> On Mon, Jan 16, 2017 at 10:43 AM, Dave Page wrote: >&

[pgadmin-hackers] pgAdmin 4 commit: Revert "Handle comments on databases with datallowcon

2017-01-20 Thread Dave Page
Revert "Handle comments on databases with datallowconn=False correctly. Fixes #2024" This reverts commit e431eb9d8ecc28572b39d26c9effcf66f70f6ae1. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac4178233b8772f964825f8c8e0c95e23feddcc1 Modifi

Re: [pgadmin-hackers] Minor patch for subnode control clean up code [pgAdmin4]

2017-01-20 Thread Dave Page
erprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake

[pgadmin-hackers] pgAdmin 4 commit: Properly remove any event listeners added by subnode

2017-01-20 Thread Dave Page
Properly remove any event listeners added by subnode control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=415119d5814054cdce6f16a9545ccd35c91270a7 Author: Harshal Dhumal Modified Files -- web/pgadmin/static/js/backform.pgadmin.

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-01-20 Thread Dave Page
acked constraints) and ensure: - No default tablespace is selected when creating an object. - If the user selects a tablespace, the CREATE SQL must handle it properly. Similarly, if they leave it to the default. - The Properties views must display the actual tablespace in use, whether it is speci

[pgadmin-hackers] pgAdmin 4 commit: Fix typo in virtualenvwrapper's name. Fixes #2083

2017-01-18 Thread Dave Page
Fix typo in virtualenvwrapper's name. Fixes #2083 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ff199f4582dd1a0506952fb2f65e0bb68d403c96 Modified Files -- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

Re: [pgadmin-hackers] First time launch as simple user (improvement needed)

2017-01-17 Thread Dave Page
Hi On Tue, Jan 17, 2017 at 4:50 PM, Bruno Friedmann wrote: > On mardi, 17 janvier 2017 09.23:49 h CET Dave Page wrote: >> Hi >> >> On Mon, Jan 16, 2017 at 5:20 PM, Bruno Friedmann wrote: >> > In packaged world, the user will have a pgAdmin4.desktop file to be

[pgadmin-hackers] pgAdmin 4 commit: Fix display of enum GUCs on users/databases etc. Fixe

2017-01-17 Thread Dave Page
Fix display of enum GUCs on users/databases etc. Fixes #2067 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6557433061a471262e05080d16b2c6b34edc5aa2 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/server_groups/ser

Re: [pgadmin-hackers] PATCH: To fix the issue in Variable control (pgAdmin4)

2017-01-17 Thread Dave Page
egards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/

Re: [pgadmin-hackers] PATCH: To display column information properly in Properties Panel (pgAdmin4)

2017-01-17 Thread Dave Page
y though :-). Thanks - patch applied. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http:

[pgadmin-hackers] pgAdmin 4 commit: Improve display of columns of exclusion contraints an

2017-01-17 Thread Dave Page
Improve display of columns of exclusion contraints and foreign keys in the properties lists. Fixes #2065 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28621999f22805852cd19ad7dca2a72cfb676e7e Author: Murtuza Zabuawala Modified Files ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2017-01-17 Thread Dave Page
Hi On Tue, Jan 17, 2017 at 9:52 AM, Surinder Kumar wrote: > Hi > On Tue, Jan 17, 2017 at 3:08 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar >> wrote: >> > Hi >> > >> > Please find updated

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-17 Thread Dave Page
2017 at 2:55 PM, Fahar Abbas > wrote: > >> Please attached the log files output from the terminal and pgAdmin4.log. >> >> Kind Regards, >> >> >> On Tue, Jan 17, 2017 at 2:46 PM, Dave Page wrote: >> >>> Thanks. What log output do you get? >>&

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-17 Thread Dave Page
. > > Kind Regards, > > On Wed, Jan 11, 2017 at 6:19 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Wed, Jan 11, 2

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

2017-01-17 Thread Dave Page
hods > other than 'btree'. > 3) Add validation for name field. Those bits do though :-) Please fix 1). Thanks! > On Fri, Nov 25, 2016 at 5:16 PM, Dave Page wrote: >> >> On Thu, Nov 24, 2016 at 12:13 PM, Surinder Kumar >> wrote: >> > Hi >> >

Re: [pgadmin-hackers] First time launch as simple user (improvement needed)

2017-01-17 Thread Dave Page
o > give an anwser to openSUSE security team if they digg in, and also to > suspicious users. I have no idea what that is, and can't find any reference to either the IP or domain in the code. I also cannot reproduce it on my machine. I wonder if it could be Qt Web Engine loading some plugi

Re: [pgadmin-hackers] Location of user configuration (Linux)

2017-01-16 Thread Dave Page
D5C9B751C4653227 > irc: tigerfoot > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsna

Re: [pgadmin-hackers] pgAdmin 4 commit: Add runtime/pgAdmin4 to .gitignore, and re-order entr

2017-01-16 Thread Dave Page
On Mon, Jan 16, 2017 at 4:49 PM, Bruno Friedmann wrote: > On lundi, 16 janvier 2017 14.46:46 h CET Dave Page wrote: >> Add runtime/pgAdmin4 to .gitignore, and re-order entries for ease of >> maintenance. >> >> Branch >> -- >> master >> >> Det

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-01-16 Thread Dave Page
Hi On Fri, Jan 13, 2017 at 9:24 AM, Surinder Kumar wrote: > Hi > > Please find attached patch and review. > > On Sun, Jan 8, 2017 at 3:27 PM, Dave Page wrote: >> >> Hi >> >> On Friday, December 23, 2016, Surinder Kumar >> wrote: >>> >&g

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

2017-01-16 Thread Dave Page
sed up in my environment then. Patch applied - sorry for the noise! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To mak

[pgadmin-hackers] pgAdmin 4 commit: Handle comments on databases with datallowconn=False

2017-01-16 Thread Dave Page
Handle comments on databases with datallowconn=False correctly. Fixes #2024 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e431eb9d8ecc28572b39d26c9effcf66f70f6ae1 Author: Murtuza Zabuawala Modified Files -- .../server_groups/serv

Re: [pgadmin-hackers] [pgAdmin4][patch]: RM 1967 - Layout is not remembered

2017-01-16 Thread Dave Page
mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Comp

[pgadmin-hackers] pgAdmin 4 commit: Store layout changes on each adjustment, rather than

2017-01-16 Thread Dave Page
Store layout changes on each adjustment, rather than on unload which is unreliable. Fixes #1967 We also use an async request now, rather than a deprecated sync request. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0d4bc0d27d4fdcfb3ffc6a0b0c

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membership control display needs improvement

2017-01-16 Thread Dave Page
Thanks, patch applied! On Fri, Jan 13, 2017 at 4:55 AM, Khushboo Vashi wrote: > Hi, > > The updated patch attached. > > Thanks, > Khushboo > > On Sun, Jan 8, 2017 at 6:56 PM, Dave Page wrote: >> >> Hi >> >> On Friday, January 6, 2017, Khushboo

[pgadmin-hackers] pgAdmin 4 commit: Improve the display of role membership on both the pr

2017-01-16 Thread Dave Page
Improve the display of role membership on both the properties panel and role dialogue. Fixes #1730 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=024b664c211f7124f052e37c0102f94e4a0a35ee Author: Khushboo Vashi Modified Files -- .

[pgadmin-hackers] pgAdmin 4 commit: Remove some comments that don't fit with our normal p

2017-01-16 Thread Dave Page
Remove some comments that don't fit with our normal presentation of generated SQL. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a85861ca57c942f11cb04dc2a485a68ceddcf88e Modified Files -- .../servers/roles/templates/role/sql/post

[pgadmin-hackers] pgAdmin 4 commit: Add runtime/pgAdmin4 to .gitignore, and re-order entr

2017-01-16 Thread Dave Page
Add runtime/pgAdmin4 to .gitignore, and re-order entries for ease of maintenance. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2db705ad80ae8e7910d597662d69eac7fd5914d5 Author: Jonas Thelemann Modified Files -- .gitignore

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-16 Thread Dave Page
self.driver.title) AssertionError: 'pgAdmin 4' != u'localhost' - Please keep tests in the pgadmin. namespace (pgadmin.acceptance.??). - It looks like running a single test won't work yet (because of TestsGeneratorRegistry.load_generators('pgadmin.%s.tests' % arg

Re: [pgadmin-hackers] .gitignore Improvement Suggestion

2017-01-16 Thread Dave Page
he reordering > too: did I submit the .diff (patch) correctly? I'm new to Git via the > command line as you already know. Please tell me, if I made any mistakes. It all looks good to me - patch committed, thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB

[pgadmin-hackers] pgAdmin website commit: Update public key.

2017-01-16 Thread Dave Page
Update public key. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=27e739ecfbdaa39a8e1379740c14b987197d465e Modified Files -- pgp/davepage.pgp | 662 +++ 1 file changed, 662 inse

Re: [pgadmin-hackers] Driver Module

2017-01-12 Thread Dave Page
ter idea of the extent of the work involved. In principal I'm not against the idea of having a function in each driver that allows us to check for the presence of a given feature, including by-version as required. What I'm against is that becoming a mess of spaghetti... -- Dave Page Blog: h

Re: [pgadmin-hackers] Driver Module

2017-01-11 Thread Dave Page
asically did: return isEdb && BackendMinimumVersion(x, y); Something like that could check other elements of the GP version number. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Building server without Apache

2017-01-11 Thread Dave Page
ally that's all that stands in your way. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subs

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-11 Thread Dave Page
Hi On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Jan 11, 2017 at 12:03 PM, Dave Page wrote: > >> >> KeyError: u'end_time' >> >> The status file contains: >> >>

[pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2017-01-10 Thread Dave Page
r the > process information. > And, it will be used to check the status information about the process. > > Thanks Dave for helping find out the root cause of the issue, and point > out the correct reference point. > Please find the updated patch with the latest changes. &g

Re: [pgadmin-hackers] Content Security Policy

2017-01-09 Thread Dave Page
replaced with ''. > If no one else is currently "working" [that's not serious work, I know] on > this and this can be realized, I'd like to make these small changes to get > to know Git a little bit better. Please feel free to submit a patch. I don't bel

[pgadmin-hackers] pgAdmin 4 commit: Fix copyright year on doc page. Fixes #2045

2017-01-09 Thread Dave Page
Fix copyright year on doc page. Fixes #2045 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe1d2f98050616c3be5d6a7c176e00510b0b2f2e Modified Files -- docs/en_US/coding_standards.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1938 - Backgrid sorting not working for Integer/Number types

2017-01-09 Thread Dave Page
Also, thanks to Murtuza for help. >>> >>> Please find attached patch and review. >> >> >> This works fine for ascending sorts, but if i click the row header a >> second time for a descending sort, the order isn't reversed as expected. >>

[pgadmin-hackers] pgAdmin 4 commit: Fix sorting of numerics in the statistics grids. Fixe

2017-01-09 Thread Dave Page
Fix sorting of numerics in the statistics grids. Fixes #1938 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86f6857cb75c342972186255f19832f93f0a6c45 Author: Surinder Kumar Modified Files -- web/pgadmin/static/js/backgrid/backgrid.

Re: [pgadmin-hackers] PATCH: To fix the issue in exclusion constraint (pgAdmin4)

2017-01-09 Thread Dave Page
Patch applied (once Murtuza showed me how to recreate the problem). Thanks! On Mon, Jan 9, 2017 at 2:42 PM, Dave Page wrote: > Hi > > On Mon, Jan 9, 2017 at 10:46 AM, Murtuza Zabuawala > wrote: >> Hi Dave, >> >> I followed, >> >> 1) First click

[pgadmin-hackers] pgAdmin 4 commit: Use the correct OID for retrieving properties of fres

2017-01-09 Thread Dave Page
Use the correct OID for retrieving properties of freshly created exclusion constraints. Fixes #1896 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c19f93b3b4ff749da1f94e559910fa7bf9f389c Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] PATCH: To fix the issue in exclusion constraint (pgAdmin4)

2017-01-09 Thread Dave Page
ble > ADD CONSTRAINT test_exclu EXCLUDE USING btree ( > col1 DESC NULLS LAST WITH =); > > Click on Save, Exclusion constraint will be created successfully but you > will get error as wrong OID was sent while generating node info. Nope - it works fine for me. I wonder what

Re: [pgadmin-hackers] PATCH: To fix the issue in exclusion constraint (pgAdmin4)

2017-01-08 Thread Dave Page
hat exclusion constraint . > RM#1896 > I can't reproduce this, even following the steps in the ticket. How did you manage to reproduce it? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][patch]: RM #1745 - Fixed Clear breakpoint issue

2017-01-08 Thread Dave Page
o review it and let us know for comments. > > Thanks, > Neel Patel > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Ensure breakpoints are cleared properly when clearing

2017-01-08 Thread Dave Page
Ensure breakpoints are cleared properly when clearing all of them. Fixes #1745 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d87345ef52657662ee936df759cd2a93bf9d80c0 Author: Neel Patel Modified Files -- .../tools/debugger/templat

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membership control display needs improvement

2017-01-08 Thread Dave Page
That should be fine then I think. The rest looks good, except: - If there are no roles listed, it still has a hint of "Select members" in the properties panel. - If there are roles listed, there's a non-functional but clickable x at the end of the control. C

Re: [pgadmin-hackers] pgAdmin IV: Minor code changes in API test cases

2017-01-08 Thread Dave Page
ed by Windows. Code change add for it. > > > > > -- > Regards, > Navnath Gadakh > > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

[pgadmin-hackers] pgAdmin 4 commit: Various improvements to the regression tests, notably

2017-01-08 Thread Dave Page
Various improvements to the regression tests, notably avoiding use of signals unavailable on Windows. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1325b30e0bcbfd951ded5ba754813251621604e2 Author: Navnath Gadakh Modified Files -

[pgadmin-hackers] pgAdmin 4 commit: Improve consistency of dialogue controls offered. Fix

2017-01-08 Thread Dave Page
Improve consistency of dialogue controls offered. Fixes #1364 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bdf9761472c215b84e49ed82ee481e237e151b7b Author: Murtuza Zabuawala Modified Files -- .../servers/templates/servers/server

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2017-01-08 Thread Dave Page
ced with the platform standard. > 2] Added unicode support. > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Dec 19, 2016 at 5:16 PM, Dave Page > wrote: > &g

Re: [pgadmin-hackers] PATCH: Dialogue control buttons should be consistent (pgAdmin4)

2017-01-08 Thread Dave Page
nce we have removed the button. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Improve detection of the pldbgapi extension and funct

2017-01-08 Thread Dave Page
Improve detection of the pldbgapi extension and functions before allowing debugging. Fixes #2026 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a33ee2ae32aa45a86b117f0d6352f21313079c11 Author: Neel Patel Modified Files -- web/pga

[pgadmin-hackers] pgAdmin 4 commit: Fix keyboard control of switches in the column grid.

2017-01-08 Thread Dave Page
Fix keyboard control of switches in the column grid. Fixes #1394 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=879a6bef5374f8ab1d409706b49d930ead51a2ac Author: Murtuza Zabuawala Modified Files -- .../tables/column/templates/colum

[pgadmin-hackers] pgAdmin 4 commit: Allow selection of message box contents for ease of e

2017-01-08 Thread Dave Page
Allow selection of message box contents for ease of error message copy/paste. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5d0a0e57e77d2a50c34bbda5ec82e89d3290192c Modified Files -- web/pgadmin/static/css/overrides.css | 2 +- 1 f

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2012 - Disable Save button if name is empty in Server-group

2017-01-08 Thread Dave Page
Thanks, patch applied. On Friday, December 23, 2016, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > The issue is with validation which is now fixed. > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > -- Dave Pa

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved

2017-01-08 Thread Dave Page
Thanks, patch applied. On Friday, December 23, 2016, Akshay Joshi wrote: > Hi Dave > > I have fixed all the comments given by you. Attached is the modified patch > file. Please review it. > > On Fri, Dec 16, 2016 at 7:08 PM, Dave Page > wrote: > >> >> >&g

Re: [pgadmin-hackers] [pgAdmin4][patch]: RM#2026 - Debugger enabled when pldbgapi extension not loaded

2017-01-08 Thread Dave Page
he debugger. > > *Solution:-* > Retrieve debugger plugin loaded information from database and return > appropriate message to user before staring debugger. > > Do review it and let us know for comments. > > Thanks, > Neel Patel > -- Dave Page Blog: http://pgsna

[pgadmin-hackers] pgAdmin 4 commit: Prevent attempts to create server groups with no name

2017-01-08 Thread Dave Page
Prevent attempts to create server groups with no name. Fixes #2012 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3c8cb2706a1e4e7ccdba2506d1f28d399141acd Author: Surinder Kumar Modified Files -- .../templates/server_groups/server

[pgadmin-hackers] pgAdmin 4 commit: Reset the column list properly if the access method i

2017-01-08 Thread Dave Page
Reset the column list properly if the access method is changed on an index to ensure error handling works correctly. Fixes #2009 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2787c5c207e3f5ed45834285e6f8318ec8d2059d Author: Neel Patel Modif

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-01-08 Thread Dave Page
ull values in Integer/String type, user need to keep the >>> field blank. >>> 3) Null values will be represented as *[null]*. >>> >>> Please find attached patch and review. >>> >>> On Fri, Dec 9, 2016 at 2:23 PM, Surinder Kumar < >&g

Re: [pgadmin-hackers] PATCH: Table dialogue column specification issues (pgAdmin4)

2017-01-08 Thread Dave Page
> earlier it was not working as expected when user presses Tab key and user > come to Switchcell for user input. > RM#1394 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave

[pgadmin-hackers] pgAdmin 4 commit: Properly detect when files have changed in the query

2017-01-08 Thread Dave Page
Properly detect when files have changed in the query tool and set the dirty flag accordingly. Fixes #1807 Note that (like pgAdmin 3) we don't make any attempt to detect if all changes have been undone and completely reverted as that could be very expensive with large scripts. Branch -- mas

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2000 - Add support for "effective_io_concurrency" tablespace option under parameter tab in tablespace

2017-01-08 Thread Dave Page
> And for 9.6 , the support for "*effective_io_concurrency*" is also added. > > The required changes are implemented in code and tested against > postgresql-9.5, 9.6 & edb-ppas 9.5 and 9.6 > > Please find patch and review. > > > Thanks, > Surinder Kumar > -- Dave P

[pgadmin-hackers] pgAdmin 4 commit: Remember the last used directory in the file manager.

2017-01-08 Thread Dave Page
Remember the last used directory in the file manager. Fixes #1910 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d71e888b4f02cd96bed3fecbc6e52e796d41c49 Author: Neel Patel Modified Files -- web/pgadmin/misc/file_manager/__init__.

[pgadmin-hackers] pgAdmin 4 commit: Allow setting of effective_io_concurrency on tablespa

2017-01-08 Thread Dave Page
Allow setting of effective_io_concurrency on tablespaces in 9.6+. Fixes #2000 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07e1c61eea471397fd98186af3f39cc278a0a8e5 Author: Surinder Kumar Modified Files -- .../browser/server_grou

[pgadmin-hackers] pgAdmin 4 commit: Show icons for unique and exclusion constraints in th

2017-01-08 Thread Dave Page
Show icons for unique and exclusion constraints in the dependency/dependents panels. Fixes #2033 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e14bef801f539c95a21daaf17632392f356acbb Author: Surinder Kumar Modified Files -- web

Re: [pgadmin-hackers] Driver Module

2017-01-08 Thread Dave Page
_groups/servers/ppas.py. Ashesh, can you help here? You know that code infinitely better than I do. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Improve query plan tooltip formatting.

2017-01-06 Thread Dave Page
Improve query plan tooltip formatting. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a93a99fdc0aded2a9c0b9ec99e21a742d75b20f6 Modified Files -- web/pgadmin/misc/static/explain/css/explain.css | 6 -- 1 file changed, 4 insertion

[pgadmin-hackers] pgAdmin 4 commit: Format JSON more efficiently. This can significantly

2017-01-06 Thread Dave Page
Format JSON more efficiently. This can significantly reduce response sizes from the server. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1504d05cddc4897df7880fc70326b416c6cf9c61 Modified Files -- web/pgadmin/utils/ajax.py | 4 ++

[pgadmin-hackers] pgAdmin 4 commit: Fix copyright notices.

2017-01-04 Thread Dave Page
Fix copyright notices. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe9bdc62a144bf605fbf26c97f495fdd738f841b Modified Files -- .../servers/databases/schemas/fts_configurations/__init__.py| 2 +- .../servers/databases/s

[pgadmin-hackers] pgAdmin 4 commit: Tidy up file header

2017-01-04 Thread Dave Page
Tidy up file header Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=560395e55773f9e99dbcbef94cf101bb8cd73b66 Modified Files -- web/pgadmin/preferences/__init__.py | 1 - 1 file changed, 1 deletion(-) -- Sent via pgadmin-hackers ma

[pgadmin-hackers] pgAdmin 4 commit: Update copyright notices for 2017.

2017-01-04 Thread Dave Page
Update copyright notices for 2017. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f221194bccddcee81977318907d79ad1f69c1dde Modified Files -- LICENSE | 2 +- Makefile

<    5   6   7   8   9   10   11   12   13   14   >