[pgadmin-hackers] PATCH: Error Handling while fetching Collection Node [pgAdmin4]

Hi, Please find attached patch for error handling while fetching collection node from the server. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/collection.js b/web/pgadmin/browser/templates/browser/js/collection.js index 96c49fc..d26daa1 100644 ---

Re: [pgadmin-hackers] pgadmin4 setup.py, first time run

Yes. I am looking into this. Thanks, Khushboo On Mon, Sep 7, 2015 at 1:31 PM, Dave Page wrote: > Khushboo, can you look at this please? > > Thanks. > > On Sun, Sep 6, 2015 at 12:42 AM, Prasad wrote: > > Hi, > > > > When you try to run pgadmin4 for first

Re: [pgadmin-hackers] pgadmin4 setup.py, first time run

ember 07, 2015 at 12:36 PM > From: "Khushboo Vashi" <khushboo.va...@enterprisedb.com> > To: "Dave Page" <dp...@pgadmin.org> > Cc: Prasad <prasa...@mail.com>, pgadmin-hackers < > pgadmin-hackers@postgresql.org> > Subject: Re: [pgadmin-hac

Re: [pgadmin-hackers] pgadmin4 setup.py, first time run

On Mon, Sep 7, 2015 at 5:28 PM, Dave Page <dp...@pgadmin.org> wrote: > On Mon, Sep 7, 2015 at 12:36 PM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi Dave, > > > > I have tried to reproduce the issue but couldn't reproduce it on UBUNTU >

Re: [pgadmin-hackers] pgadmin4 setup.py, first time run

, Khushboo On Mon, Sep 7, 2015 at 1:49 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Yes. I am looking into this. > > Thanks, > Khushboo > > On Mon, Sep 7, 2015 at 1:31 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Khushboo, can you look at this

[pgadmin-hackers] Unable to update Domain properly

Hi, While updating Domain from pgAdmin-III , I observed an error. When I update only Domain name it is working properly, but when I try to update multiple fields, I get an error. For example, if I try to rename Domain *TestDomain* to *TestDomain1* and also modifies one or more fields (except

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 5:07 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 4:42 PM, Dave Page <dp...@pgadmin.org> wro

Re: [pgadmin-hackers] Fixed RM #1356

On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi > .com> wrote: >> >>> >>> >>> On Thu,

[pgadmin-hackers] [pgAdmin4][Patch]: RM #1351

Hi, Please find the attached patch to fix the RM #1351 - Foreign table column options in pgAdmin 4. Added the functionality to add column level options in Foreign Table. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py

[pgadmin-hackers] [pgAdmin4 Patch]: NodeAjaxOptionsControl Formatter Fix

Hi, The current formatter of NodeAjaxOptionsControl doesn't parse JS Array properly. So, I have fixed this issue and attached the patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/browser/static/js/node.ui.js b/web/pgadmin/browser/static/js/node.ui.js index cd562af..f650961 100644

[pgadmin-hackers] [pgAdmin4 Patch]: Fixed Typos in JavaScript Files

Hi, There are typos in 3 JS files. Please find attachment for the fixes. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/static/js/variable.js b/web/pgadmin/browser/server_groups/servers/static/js/variable.js index d8ae58c..4c13215 100644 ---

Re: [pgadmin-hackers] PATCH: NodeAjaxOptionsControl in Subnode

Hi, With the previous patch *'Modified SQL'* tab was included in the sub-bode control, which is now fixed in the attached patch. Thanks, Khushboo On Wed, Feb 3, 2016 at 12:08 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > When we are using NodeAja

[pgadmin-hackers] PATCH: NodeAjaxOptionsControl in Subnode

Hi, When we are using NodeAjaxOptionsControl in main model, it is working fine, but while using it in subnode, giving an error of node is undefined. So, I have fixed that issue and the patch for the same is attached. Please review it and let me know in case of problem. Thanks, Khushboo diff

[pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

Hi, Please find attached patch for the Foreign Table Module. The patch will be modified after Types module implementation as we need to populate Base Type and some Type related validations from the Types module. Please review it and let me know the feedback. Thanks, Khushboo diff --git

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Formatter Functions for Security Labels and Variables

Thanks Dave. Attached patch for a minor fix to a variable name typo. Thanks, Khushboo On Fri, Feb 26, 2016 at 8:53 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks - applied with a minor fix to a variable name that was misspelt. > > On Fri, Feb 26, 2016 at 12:36 PM,

[pgadmin-hackers] [pgAdmin4][Patch]: Formatter Functions for Security Labels and Variables

Hi, The Security Labels and the Variables are used in many modules under the Database Node. The functions to parse and return them into desired format, are kept in the database utility file (databases/utils.py), so every node can use them. I have applied the related changes in the database

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

Macro' patch must be applied first as that is not committed yet. Please find attached Foreign Table Patch. Thanks, Khushboo On Tue, Feb 23, 2016 at 6:53 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for the Foreign Table Module

[pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Hi, Please find attached patch for the Domain Module. The patch will be modified after Types module implementation as we need to populate Base Type and some Type related validations from the Types module. Please review it and let me know the feedback. Thanks, Khushboo diff --git

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Resending patch with binary option. On Wed, Jan 20, 2016 at 10:18 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for the Domain Module. > > The patch will be modified after Types module implementation as we need to > popu

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

h ? > > Thanks, > Neel Patel > > On Wed, Jan 20, 2016 at 12:37 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Resending patch with binary option. >> >> On Wed, Jan 20, 2016 at 10:18 AM, Khushboo Vashi < >> khushboo.va...

[pgadmin-hackers] [pgAdmin4][Patch]: Updated Privileges macros under Schema

Hi, Please find attached patch for the updated Privileges macros under Schema node. The changes are required due to previous commit (8a7ec6b45221f042bc39c9bce2c577e12b43cc3a) regarding "parse_priv_to_db" function. Thanks, Khushboo diff --git

[pgadmin-hackers] [pgAdmin4][Patch]: Disable/Enable Edit Button: Sub-node Collection

Hi, Please find attached patch to disable/enable the Edit button of a sub-node collection grid. Thanks, Khushboo diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js index 6e7d062..735b53f 100644 --- a/web/pgadmin/static/js/backform.pgadmin.js +++

[pgadmin-hackers] [pgAdmin4][Patch]: Data-type Reader

Hi, Please find attached patch for the Data-type Reader. This common functionality is required under Schema node as many nodes uses the same functionality. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/datatype/sql/9.1_plus/get_types.sql

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Hi, Please find the updated Domain Module Patch. To test this patch, please apply Backgrid Textarea Cell Patch before this. Thanks, Khushboo On Wed, Mar 16, 2016 at 3:02 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Wed, Mar 16, 2016 at 2:55 PM

[pgadmin-hackers] [pgAdmin4][Patch]: Unique Collection Control and Variable Control Fixes

Hi, The current implementation of the unique-collection control does not pass the control data to the evaluation function like canAdd, canEdit etc., so that has been fixed. Also, the current implementation of the variable control does not honour the canAdd option settings, which has been fixed.

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

(i.e. S), then only I have used qtLiteral function to quote the default value. Is this right approach or not? Thanks, Khushboo On Wed, Mar 16, 2016 at 9:40 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi > <khushboo.v

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Hi, On Wed, Mar 16, 2016 at 2:55 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Wed, Mar 16, 2016 at 9:18 AM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > > >>> - Owner and schema should be allowed to be left blank (and the

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added Support for the Domain Dependencies

atch failed: web/pgadmin/browser/utils.py:424 > > error: web/pgadmin/browser/utils.py: patch does not apply > > On Fri, Mar 18, 2016 at 4:03 AM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi, > > > > Added support for the Domain Dependencies,

[pgadmin-hackers] [pgAdmin4][Patch]: Backgrid Textarea Cell

Hi, Introduced Backgrid Textarea cell. Please find attachment for the same. Thanks, Khushboo diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 7f25dca..fdefc74 100755 --- a/web/pgadmin/static/css/overrides.css +++

[pgadmin-hackers] [pgAdmin4][Patch]: Added Support for the Domain Dependencies

Hi, Added support for the Domain Dependencies, earlier it was coming as a Type. Please find attached Patch for the same. Akshay, Can you please verify the patch, as you have implemented this functionality. Thanks, Khushboo diff --git

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Hi Dave, On Fri, Mar 18, 2016 at 8:31 PM, Dave Page <dp...@pgadmin.org> wrote: > On Thu, Mar 17, 2016 at 5:39 PM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi Dave, > > > > I have a query regarding your below feedback : > > >

[pgadmin-hackers] [pgAdmin4][Patch]: Update the Browser Tree Node Icon after editing

Hi, Please find the attached Patch to update the Browser Tree Node Icon after editing. This will be applicable only when server will send the icon after editing. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

Hi Dave, I think you forgot to attach the updated patch. Thanks, Khushboo On Wed, Mar 23, 2016 at 5:33 PM, Dave Page <dp...@pgadmin.org> wrote: > On Tue, Mar 22, 2016 at 10:51 AM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi, > >

[pgadmin-hackers] [pgAdmin4][Patch]: Backgrid cell editable settings

Hi, In the current Backgrid implementation, the cell can be made editable through "editable: true/false" settings. It takes only boolean value. So, added support for the function, that can be set as an editable option value. *For Example:* editable: function(m) { return false; } Please find

[pgadmin-hackers] [pgAdmin4][Patch]: Macros for the functions module

Hi, Please find attached patch for the Security Labels, Privileges and Variables macros for the functions modules. *Usage of the macros:* *Security labels:* SECLABLE.SET(conn, 'FUNCTION', func_name, provider, security_label, func_schema, func_args) SECLABLE.UNSET(conn, 'FUNCTION',

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

Hi, Please find updated patch for the Foreign Table Module. This patch is dependent on 1. Backgrid Depscell Patch, (submitted by me) 2. NodeAjaxOptionsCell Transform change patch, on which Ashesh and Murtuza are working Thanks, Khushboo On Wed, Feb 24, 2016 at 2:57 PM, Khushboo Vashi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Backgrid StringDepsCell

Hi Ashesh, I have changed the function name (from *render_deps* to *updateUIDeps*), which will be called on the dependent field change, as per your suggestion. Please find attached patch for the same. Thanks, Khushboo On Fri, Apr 1, 2016 at 3:56 PM, Khushboo Vashi < khushboo

[pgadmin-hackers] [pgAdmin4][Patch]: Backgrid StringDepsCell

Hi, Please find the attached patch for the Backgrid *StringDepsCell.* The *StringDepsCell* displays HTML escaped strings and accepts anything typed in. Also, Listen to the dependent fields. Usage of the Backgrid Cell: If the Precision cell is dependent on the Datatype then: { id:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Backgrid StringDepsCell

pany > <http://www.enterprisedb.com> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi> > > On Wed, Mar 30, 2016 at 6:39 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Plea

[pgadmin-hackers] [pgAdmin4][Patch]: Collection Control Fixes

Hi, Please find attached patch to fix below issues in the Collection Control: 1> Unique Collection Control: Couldn't listen Change event 2> Subnode Collection Control: Add button Label was not in Upper case First Issue was reported by Murtuza. Thanks, Khushboo diff --git

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Updated one comment. On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find attached updated patch for the Domains module. > > On Wed, Mar 16, 2016 at 9:40 PM, Dave Page <dp...@pgadmin.org> wrote: > >>

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed the TypeError into session.py

Hi, Fixed an issue related to Type ( TypeError: 'str' does not support the buffer interface) for python3 in the session.py. Please find attachment for the same. Thanks, Khushboo diff --git a/web/pgadmin/utils/session.py b/web/pgadmin/utils/session.py index 6675e88..f4daefb 100644 ---

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed an issue related to update the tree

Hi, Fixed a minor bug related to update the tree in the node.js. Due to this bug, After updating the Node, if the response data is null then it gives an error. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/node.js

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, I have started reviewing the patch but the basic functionalities are breaking on python 2.7. Please test the patch on Python 2.7, fix the issues and resend the patch. Thanks, Khushboo On Thu, May 12, 2016 at 6:03 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > > -- >

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

at 5:24 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi > > PFA attached patches for table and it's child nodes with python 2.7 > compatibility. > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB <http://www.enterprisedb.com>

[pgadmin-hackers] [pgAdmin4][Patch]: SQL Tab Validation

Hi, Do not send the request to the server if a model contains any error on selection of the SQL Tab, while creating/updating any Node. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

Hi, On Wed, May 4, 2016 at 4:37 PM, Dave Page <dave.p...@enterprisedb.com> wrote: > Hi > > On Wed, May 4, 2016 at 7:51 AM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi Dave, > > > > In PG 9.5, for Foreign Table Editing, below new

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed an issue related to the Property dialogue buttons in IE 10

Hi, In IE (ver: 10), the Save/Reset buttons are not getting enabled even after changing the fields. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js index

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed an issue related to the Delete/Drop context Menu of the node

Hi, When we try to drop any node and the visibility of the Delete/Drop context Menu of that node is having dependency on some function then, after deleting that node object, it gives a JS error. Please find the attached patch to fix this issue. Thanks, Khushboo diff --git

Re: [pgadmin-hackers] New committer: Akshay Joshi

Congrats Akshay. On Fri, May 6, 2016 at 1:54 PM, Dave Page wrote: > All, > > I'm pleased to announce that Akshay Joshi has been added to the > pgAdmin 4 project as our newest committer. Akshay has been working on > pgAdmin 3 for a number of years now, and has done some

[pgadmin-hackers] []pgAdmin4[Patch]: Dependencies Tab: Type Icon Issue fix

Hi, In the Dependencies tab, the Icon of the Type is not showing up. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 1927ff1..cbb7ff8 100755 --- a/web/pgadmin/static/css/overrides.css +++

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

lly require to add > table constraint ? >- In alter foreign table, below are the new functionality > added. > 1. ALTER [ COLUMN ] column_name SET STORAGE { PLAIN > | EXTERNAL | EXTENDED | MAIN } > 2. DISABLE TRIGGER [ trigge

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Backgrid StringDepsCell

Hi, Please find the attached re-based patch. Thanks, Khushboo On Wed, Apr 6, 2016 at 2:38 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: > Hi Khushboo, > > > On Tue, Apr 5, 2016 at 10:59 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: &

[pgadmin-hackers] [pgAdmin4][Patch]: SQL Help Fix

Hi, The SQL Help Tab does not load the Help page on the Google Chrome (version: 39.0) browser. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js index 331d818..d38eee7

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed typos in datamodel.js

Hi, Due to some typos in datamodel.js, the application does not load properly in Google Chrome (ver: 39). Fixed typos in datamodel.js Thanks, Khushboo diff --git a/web/pgadmin/browser/static/js/datamodel.js b/web/pgadmin/browser/static/js/datamodel.js index 71bd959..fa60f7c 100644 ---

[pgadmin-hackers] [pgAdmin][Patch]: Fixed RM 1470

Hi, Please find the attached patch for the RM 1470: [Desktop Runtime Application] User can not drop domain. The issue was produced because of execute_2darray function change. Now I have changed the way of variable assignment to fix this issue. Thanks, Khushboo diff --git

[pgadmin-hackers] [pgAdmin][Patch]: Fixed RM 1467

Hi, Please find the attached patch for the fix of RM 1467: Unable to drop trigger function, function and procedures. The issue was produced because of execute_2darray function change. Thanks, Khushboo diff --git

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Navnath, I have just ran the automated test cases, I noticed that the login test-case gets called (which actually post data and gets logged-in) each time before every test case runs. I think this should not happen, user login should be done only once. Thanks, Khushboo On Mon, Jul 18, 2016

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

On Mon, Jul 11, 2016 at 7:15 PM, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > > > On 11 July 2016 at 18:35, Dave Page wrote: > >> On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge >> wrote: >> > Sorry, by mistake i copied

[pgadmin-hackers] [pgAdmin4][Patch]: RM 1527: XSS vulnerabilities

Hi, Please find the attached patch to fix the RM 1527: XSS vulnerabilities. Fixed items: 1. Tree Node labels while loading, adding and updating the node 2. Error and Success messages of Alertify dialogue 3. Properties dialogue: un-editable controls 4. SQL Editor title Please review the patch

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

Hi, Please find the attached rebased patch. Thanks, Khushboo On Mon, Jan 30, 2017 at 6:20 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > Can you rebase this please? > > Thanks. > > On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi > <khushboo.va..

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

Hi, On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached rebased patch. > > This patch also include fix for RM 2139: Message (Connection to the server has been lost.) displayed with Materialized view a

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

lized Views" collection node. > > Fixed > On Fri, Feb 3, 2017 at 12:14 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote

[pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

Hi, Please find the attached patch to fix RM 2089 : PARALLEL SAFE support for functions missing. Fix: Incorporated the PARALLEL SAFE support for the functions and procedures for PostgreSQL 9.6. Thanks, Khushboo diff --git

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

AGE sql >> >> *IMMUTABLE PARALLEL SAFE* >> >> AS $function$SELECT $1 OPERATOR(public.&&) $2 AND >> public._ST_Intersects($1,$2)$function$ >> >> >> is this behaviour correct?? >> >> >> >> On Fri, Feb 3, 2017 at 5:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Jan 20, 2017 at 5:31 PM, Dave Page <dp...@pgadmin.org> wrote: > On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi, > > > > Please find t

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

Hi, Please find the attached updated patch. Thanks, Khushboo On Wed, Feb 15, 2017 at 8:57 PM, Dave Page <dave.p...@enterprisedb.com> wrote: > Hi > > On Fri, Feb 10, 2017 at 7:28 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> &g

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Feb 3, 2017 at 7:53 PM, Dave Page <dave.p...@enterprisedb.com> wrote: > > > On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >&

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

mpany > > On Thu, Aug 18, 2016 at 12:34 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Harshal, >> >> Please see below review comments. >> >> 1. Please make one line space between every SQL block as per pgAdmin 4 >> standa

[pgadmin-hackers] [pgAdmin4][Patch]: RM 1785 - PPAS Servers are consider to be PostgreSQL until after the first disconnect/reconnect

Hi, Please find the attached patch to fix the RM 1785: PPAS Servers are consider to be PostgreSQL until after the first disconnect/reconnect Issue: After creating a new server, the icon and the server type were not set properly in the response, so fixed both in the response. Thanks, Khushboo

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

On Wed, Aug 17, 2016 at 4:35 PM, Dave Page wrote: > Hi, > > I did some quick testing, and found the following issues: > > - Package ACL is not shown in properties > > - Package header and body are not shown in properties > > - System package? is not shown in properties > > -

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

On Thu, Aug 18, 2016 at 10:50 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Aug 17, 2016 at 4:35 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi, >> >> I did some quick testing, and found the following issues: >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

On Sat, Oct 15, 2016 at 11:52 AM, Dave Page <dp...@pgadmin.org> wrote: > > > On Friday, October 14, 2016, Ashesh Vashi <ashesh.va...@enterprisedb.com> > wrote: > >> On Sat, Oct 15, 2016 at 4:59 AM, Dave Page <dp...@pgadmin.org> wrote: >> >>>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

Hi, The fix does not include a special case when database name has an equal to (=) character in it. Thanks, Khushboo On Fri, Oct 14, 2016 at 6:58 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the below 2 bugs. &g

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

Hi, Please find the attached patch to fix the below 2 bugs. RM 1603: [Web Based] Export database failed if object contains double quotes. RM 1220: Backup database is not working with special characters The issues which were fixed: 1. Client side data were not unescaped 2. Required command line

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

org> wrote: > On Thu, Oct 20, 2016 at 12:08 PM, Ashesh Vashi > <ashesh.va...@enterprisedb.com> wrote: > > On Thu, Oct 20, 2016 at 4:26 PM, Khushboo Vashi > > <khushboo.va...@enterprisedb.com> wrote: > >> > >> > >> > >&g

Re: [pgadmin-hackers] pgAdmin4 Chinese (Simplified) translation Patch

On Mon, Nov 14, 2016 at 5:37 PM, Dave Page wrote: > Hi > > (Khushboo, please see below) > > On Sun, Nov 13, 2016 at 1:26 PM, lambda wrote: > > for the first question, pybabel support Chinese with zh_Hans_CN > > > > #pybabel --list-locales |grep zh > >

[pgadmin-hackers] [pgAdmin4][Patch]: Dashboard JS - Set DOM Elements context

Hi, In dashboard.js, some of the DOM elements are in the global context, so, changed those elements to be used only for the Dashboard context. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/dashboard/templates/dashboard/js/dashboard.js

[pgadmin-hackers] [pgAdmin][Patch]: Backgrid password cell css

Hi, Please find the attached patch for the Backgrid password cell css. Currently the password cell does not have proper css in the edit mode. Thanks, Khushboo diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 5af03ba..9f8aa79 100755 ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

Hi, Please find the attached updated patch. On Fri, Nov 18, 2016 at 7:45 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Fri, Nov 18, 2016 at 1:03 PM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi, > > > > Please find the at

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Nov 25, 2016 at 2:56 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > This doesn't apply - can you rebase it please? > > Thanks. > > On Thu, Nov 24, 2016 at 8:57 AM, Khushboo Vashi > <khush

[pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

Hi, Please find the attached patch for RM #1801: Properly handle databases with datallowconn == false. Issue: While connecting the database, allowconn parameter was not in consideration. Also, the database properties query call was on the selected database which was not correct. Fix: Put the

[pgadmin-hackers] [pgAdmin4][Patch]: RM #1855

Hi, Please find attached patch to fix RM #1855: Displaying error message at the bottom of properties panel while creating Trigger Function. Issue: The status-bar context was getting changed in properties dialogue. I have removed status bar from properties (read-only mode) panel as that was not

[pgadmin-hackers] [pgAdmin4][Patch]: RM #1924: Editing View Bug

Hi, Please find the attached patch to fix the RM #1924. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/views/templates/view/pg/9.4_plus/sql/update.sql

Re: [pgadmin-hackers] pgAdmin4 Chinese (Simplified) translation Patch

use zh_cn. > > > >BTW; the second field above is just a label, so I'd probably put > >"Chinese (Simplified)" in there. > > > >Can you update your catalog with the latest changes please? > > > >> 在 2016-11-14 20:16:47，"Khushboo Vashi" <

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1887

Hi, Please find the patch to fix RM 1887: Preferences values ate not stored properly. Thanks, Khushboo diff --git a/web/pgadmin/preferences/templates/preferences/preferences.js b/web/pgadmin/preferences/templates/preferences/preferences.js index 09788fc..e02c926 100644 ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

Hi, Please find the attached updated patch. Thanks, Khushboo On Mon, Dec 5, 2016 at 11:09 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Friday, December 2, 2016, Khushboo Vashi <khushboo.vashi@enterprisedb. > com> wrote: > >> Hi. >> &g

[pgadmin-hackers] [pgAdmin4][Patch]: RM 2007: View Last 100 rows not working with Pgadmin4

Hi, Please find the attached patch to fix RM 2007: View Last 100 rows not working with Pgadmin4. To fix this issue I have changed the query which fetches the last 100 rows. The issue is reproducible when we have more than one primary keys; because the order by clause in the query was not

[pgadmin-hackers] [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines

Hi, Please find the attached patch to fix the RM 1780: Rendering glitches in the query editor line number column when editing many lines. Some codemirror css were overwritten to increase the width of the line number column in sql editor. Due to those changes this issue was coming, I have removed

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

h applied. > > On Fri, Dec 9, 2016 at 5:32 AM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi, > > > > Please find the attached updated patch. > > > > Thanks, > > Khushboo > > > > On Mon, Dec 5, 2016 at 11:09 PM, Dave Page <d

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines

Hi, Please find the attached updated patch. Thanks, Khushboo On Mon, Dec 12, 2016 at 3:30 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Fri, Dec 9, 2016 at 11:37 AM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi, > > > > Pl

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membership control display needs improvement

Hi, The updated patch attached. Thanks, Khushboo On Sun, Jan 8, 2017 at 6:56 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Friday, January 6, 2017, Khushboo Vashi <khushboo.vashi@enterprisedb. > com> wrote: > >> Hi, >> >> Please find the at

[pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

Hi, Please find the attached patch to fix the RM 2069 - Wrong tablespace displayed in table properties. When the table is created without a tablespace, the "pg_default" tablespace gets selected rather than the default tablespace (the current database tablespace). So, this issue has been fixed.

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

Hi. Please find the attached updated patch. Thanks, Khushboo On Fri, Nov 25, 2016 at 7:12 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Fri, Nov 25, 2016 at 12:19 PM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi, > > > &

[pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membership control display needs improvement

Hi, Please find the attached patch to fix RM 1730 - Role membership control display needs improvement *Fixed items:* - An alternate note is needed when shown on the properties panel - Remove the border - Align the label and control in columns as per other controls. *Remaining*: - Investigate

[pgadmin-hackers] [pgAdmin4][Patch]: RM 2006 - cannot modify table name or set schema on tables with postgis geometry column

Hi, Issue: Can not modify the table information when it has postgis geometry column. Fix: Properly handled the table column type (when it does not refer to pg_catalog) while creating SQL command. Please find attached patch to fix this issue. Thanks, Khushboo diff --git

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines

if any changes are required. > Thanks. > > On Fri, Dec 16, 2016 at 1:04 PM, Dave Page <dp...@pgadmin.org> wrote: > > Thanks, patch applied! > > > > On Fri, Dec 16, 2016 at 9:12 AM, Khushboo Vashi > > <khushboo.va...@enterprisedb.com> wrote: > &

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Mar 17, 2017 at 6:02 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Fri, Mar 17, 2017 at 12:17 PM, Khushboo Vashi > <khushboo.va...@enterprisedb.com> wrote: > > Hi, > > > &

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed Ascending/Descending order in backgrid

may help to add some jasmine tests around the makeComparator method. > > Tira & Matt > > > On Mon, Mar 27, 2017 at 8:01 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> The ascending/descending order is not working in the backg

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

ly patch I recall going anywhere near there > recently). If I check the Preferences dialogue, those options aren't > there at all. > > Can you take a look ASAP please? > > Thanks. > > On Fri, Mar 24, 2017 at 10:20 AM, Dave Page <dp...@pgadmin.org> wrote: > >

  1   2   >