Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Fri, Jun 9, 2017 at 9:03 AM, Dave Page wrote: > On Thu, Jun 8, 2017 at 7:31 PM, Sarah McAlear wrote: >>> Thanks. When I run the tests my browser opens in some default size >>> that's always consistent, but doesn't match my normal Chrome sessions, >>> or

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Thu, Jun 8, 2017 at 7:31 PM, Sarah McAlear wrote: >> Thanks. When I run the tests my browser opens in some default size >> that's always consistent, but doesn't match my normal Chrome sessions, >> or the 1024x1024 default set in app_starter.py. > > > This looks like an

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

> > Thanks. When I run the tests my browser opens in some default size > that's always consistent, but doesn't match my normal Chrome sessions, > or the 1024x1024 default set in app_starter.py. This looks like an issue with string edit box placement in the implementation. We created an issue for

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi On Thu, Jun 8, 2017 at 2:18 PM, Sarah McAlear wrote: > On Thu, Jun 8, 2017 at 8:34 AM, Dave Page wrote: >> - There are changes to SlickGrid, the addition of a function to scroll >> a column into view. Is this submitted upstream and accepted? > > We

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Thu, Jun 8, 2017 at 8:34 AM, Dave Page wrote: > Hi! > > Thanks, patch applied... but I have one issue and one question: > > - There are changes to SlickGrid, the addition of a function to scroll > a column into view. Is this submitted upstream and accepted? > We have

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi! Thanks, patch applied... but I have one issue and one question: - There are changes to SlickGrid, the addition of a function to scroll a column into view. Is this submitted upstream and accepted? - One of the regression tests now fails because it's trying to access an element that's out of

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Mon, Jun 5, 2017 at 9:09 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Matthew, > > Couple of review comments: > 1) Clicking on a new added row(after save) results in console error - > screenshot attached. > We'll check this out as soon as we can. > 2) If i drag to

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Dave! It looks like everything has been addressed with this current patch, aside from the feature test for for edit table tool. If we agree that Surinder can send that patch on a separate thread, is this patch good to be committed? Thanks, Matt On Thu, Jun 1, 2017 at 11:17 AM, Robert

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Awesome, thanks. -- Rob On Thu, Jun 1, 2017 at 11:13 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Robert, > > On Jun 1, 2017 8:22 PM, "Robert Eckhardt" wrote: > > > > Surindar, > > > > Have you sent this patch and I'm missing it or is it still in

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Robert, On Jun 1, 2017 8:22 PM, "Robert Eckhardt" wrote: > > Surindar, > > Have you sent this patch and I'm missing it or is it still in flight for you? I have found the solution, will test that patch and hopefully by tomorrow I will send. > > -- Rob > > On Wed, May 31,

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Surindar, Have you sent this patch and I'm missing it or is it still in flight for you? -- Rob On Wed, May 31, 2017 at 1:02 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Joao > > On Wed, May 31, 2017 at 1:19 AM, Joao Pedro De Almeida Pereira < >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Sat, May 27, 2017 at 9:02 AM, Surinder Kumar wrote: > Hi Dave, > On Sat, May 27, 2017 at 3:07 AM, Dave Page wrote: >> >> Hi >> >> OK, so we're getting somewhere now :-). Here's what I found: >> >> - The grid looks and feels great now.

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Fri, May 26, 2017 at 11:23 AM, Joao Pedro De Almeida Pereira wrote: > Maybe we should update the website with this information to help future > committers. I've committed a change showing some other ways to create patches with new files, including binary:

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi OK, so we're getting somewhere now :-). Here's what I found: - The grid looks and feels great now. Selection works nicely, and copying rows seems to work well. - Patch 5 doesn't apply - but only to slick.grid.js. I manually fixed it for testing, but the patch really doesn't look like it was

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi, These patches really don't look like they were created in the normal way: (pgadmin4)snake:web dpage$ git apply ~/Downloads/1-upgrade-slickgrid.patch /Users/dpage/Downloads/1-upgrade-slickgrid.patch:126: trailing whitespace. /Users/dpage/Downloads/1-upgrade-slickgrid.patch:129: trailing

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi We don't want this to be committed, even to a local tree (as there's a risk it may inadvertently get pushed). These patches are for review only at this stage. Once they are ready, they may or may not be committed individually, and even then it's very unlikely that we'll want to use the

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Dave, git am is also helpful to apply a patch that was created using git format-patch, which is how we created these four patches. git am will apply the diff in the patch and also make a commit using the commit message stored in the patch. Could you try it again using git am? If it still

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi git am is for applying patches from mailbox files: Splits mail messages in a mailbox into commit log message, authorship information and patches, and applies them to the current branch. That doesn't seem like it'll help me as a gmail user. Can you fix the patches to apply with git apply

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Dave, We see the same errors when doing *git apply* for each patch. However, if you do *git am* for each patch, it should proceed. Thanks, Shruti & Matt On Tue, May 23, 2017 at 4:55 PM, Dave Page wrote: > Hi! > > Looks great! I found a few issues which I think should be

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi! Looks great! I found a few issues which I think should be addressed before we continue too far. Note that I haven't reviewed the code at this stage: - When dragging a selection, the bounding box doesn't line up with the bottom of the grid rows. Note that I couldn't screen shot this