Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-23 Thread Dave Page
Thanks - committed. On Mon, Feb 22, 2016 at 1:23 PM, Akshay Joshi wrote: > Hi All > > Attached is the modified patch with support of Dependents and Dependencies > tabs. Please review it. > > On Mon, Feb 22, 2016 at 5:29 PM, Dave Page wrote: >

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-22 Thread Akshay Joshi
Hi All Attached is the modified patch with support of Dependents and Dependencies tabs. Please review it. On Mon, Feb 22, 2016 at 5:29 PM, Dave Page wrote: > > > On Mon, Feb 22, 2016 at 10:53 AM, Dave Page wrote: > >> >> >> On Fri, Feb 19, 2016 at 10:48

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-22 Thread Dave Page
On Mon, Feb 22, 2016 at 10:53 AM, Dave Page wrote: > > > On Fri, Feb 19, 2016 at 10:48 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> On Mon, Feb 15, 2016 at 3:47 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Feb 15, 2016 at 7:29

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-22 Thread Dave Page
On Fri, Feb 19, 2016 at 10:48 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi All > > On Mon, Feb 15, 2016 at 3:47 PM, Dave Page wrote: > >> >> >> On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>>

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-19 Thread Akshay Joshi
Hi All On Mon, Feb 15, 2016 at 3:47 PM, Dave Page wrote: > > > On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> Attached is the new patch after fixing review comments given by Dave. >> >> On Fri, Feb 12, 2016 at 10:04

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-15 Thread Dave Page
On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi wrote: > Hi All > > Attached is the new patch after fixing review comments given by Dave. > > On Fri, Feb 12, 2016 at 10:04 PM, Dave Page wrote: > >> >> >> On Fri, Feb 12, 2016 at 11:21 AM, Harshal

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-14 Thread Akshay Joshi
Hi All Attached is the new patch after fixing review comments given by Dave. On Fri, Feb 12, 2016 at 10:04 PM, Dave Page wrote: > > > On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> New language patch is working

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-12 Thread Harshal Dhumal
Hi, New language patch is working fine. Ashesh - Can you please review it ? If it looks good then can you please commit ? Thank you, Harshal -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, Feb 11, 2016 at 4:01 PM, Akshay Joshi

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-11 Thread Harshal Dhumal
Hi Akshay, Please find the review comments below for Language node. - On postgres9.1 language node failed with below error when clicked on properties or sql tab. * function expression in FROM cannot refer to other relations of same query level LINE 15: aclexplode(lanacl) d ^* *- *Error when

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-11 Thread Akshay Joshi
Hi All Attached is the modified patch, please review it. On Thu, Feb 11, 2016 at 2:06 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the review comments below for Language node. > > - On postgres9.1 language node failed with below error when clicked on

[pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-08 Thread Akshay Joshi
Hi All Attached is the patch for the Language Module. Please review it and if it looks good then please commit it. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Languages.patch Description: Binary data -- Sent via pgadmin-hackers