Hi
On Wed, Apr 11, 2018 at 4:46 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Dave,
> Do you still have issues in your environment?
>
I just tested on my MBP, and got the following failure:
==
ERROR: r
Hi Dave,
Do you still have issues in your environment?
Thanks
Joao
On Wed, Apr 11, 2018 at 5:56 AM Dave Page wrote:
> Joao, are you looking at this?
>
> On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software
Joao, are you looking at this?
On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Tue, Apr 3, 2018 at 6:10 PM,
--
*Harshal Dhumal*
*Sr. Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Apr 3, 2018 at 6:10 PM, Dave Page wrote:
> Argh, managed to send before I finished typing...
>
> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote:
>
>> Hi
>>
>>
Argh, managed to send before I finished typing...
On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote:
> Hi
>
> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Dave,
>> That looks like in the surrounding area of the change. We run our
>> pipe
Hi
On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Dave,
> That looks like in the surrounding area of the change. We run our pipeline
> and everything was green.
> Can you provide more details, which python version are you using? OS?
>
That wa
Hi Dave,
That looks like in the surrounding area of the change. We run our pipeline
and everything was green.
Can you provide more details, which python version are you using? OS?
Thanks
Joao
On Thu, Mar 29, 2018 at 9:03 AM Dave Page wrote:
> Hi
>
> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Alme
Hi
On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hey Akshay and Neethu
>
> We refactored the patch to add tests for the resize feature. We were able
> to write test cases for the drag event by using spies and setting the rect
> dimensions. In
Thanks Joao.
On Wed, Mar 28, 2018 at 11:36 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hey Akshay and Neethu
>
> We refactored the patch to add tests for the resize feature. We were able
> to write test cases for the drag event by using spies and setting the rect
> dimen
Hey Akshay and Neethu
We refactored the patch to add tests for the resize feature. We were able
to write test cases for the drag event by using spies and setting the rect
dimensions. In cases like this, we can just test some components in order
to have enough confidence in the code. So we isola
Hi
On Fri, Mar 2, 2018 at 3:40 AM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Neethu,
> We passed the patch through our CI pipeline and all tests pass.
> The code looks good, but we are trying to decouple files as much as we
> can so that we do not end up with files w
Hello Neethu,
We passed the patch through our CI pipeline and all tests pass.
The code looks good, but we are trying to decouple files as much as we can
so that we do not end up with files with over 1000 lines, that are hard to
read and to maintain. Also we are trying to create Unit Tests to have
12 matches
Mail list logo
