subject:"Re\: Bug #3083 fix"

Re: Bug #3083 fix

2018-04-11 Thread Dave Page

Hi

On Wed, Apr 11, 2018 at 4:46 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Dave,
> Do you still have issues in your environment?
>

I just tested on my MBP, and got the following failure:

==
ERROR: runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
Query tool feature test
--
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_feature_test.py",
line 43, in setUp
self.before()
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
line 46, in before
self._reset_options()
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
line 113, in _reset_options
self.page.fill_codemirror_area_with('')
  File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 227, in fill_codemirror_area_with
until(find_codemirror, "Timed out waiting for codemirror "
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 80, in click
self._execute(Command.CLICK_ELEMENT)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 628, in _execute
return self._parent.execute(command, params)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 312, in execute
self.error_handler.check_response(response)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 242, in check_response
raise exception_class(message, screen, stacktrace)
WebDriverException: Message: unknown error: Element ... is not
clickable at point (813, 155). Other element would receive the click: ...
  (Session info: chrome=65.0.3325.181)
  (Driver info: chromedriver=2.37.544337
(8c0344a12e552148c185f7d5117db1f28d6c9e85),platform=Mac OS X 10.12.6 x86_64)



>
> Thanks
> Joao
>
> On Wed, Apr 11, 2018 at 5:56 AM Dave Page  wrote:
>
>> Joao, are you looking at this?
>>
>> On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, Apr 3, 2018 at 6:10 PM, Dave Page  wrote:
>>>
 Argh, managed to send before I finished typing...

 On Tue, Apr 3, 2018 at 1:38 PM, Dave Page  wrote:

> Hi
>
> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Dave,
>> That looks like in the surrounding area of the change. We run our
>> pipeline and everything was green.
>> Can you provide more details, which python version are you using? OS?
>>
>
> That was on my travel laptop, which is macOS Sierra with the Apple
> supplied Python 2.7.
>
> Interestingly, I'm on my dev laptop today (same OS and Python) and
> it's working just fine. The difference is that the travel machine is a 12"
> Macbook, whilst the dev machine is
>

 a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if
 the small screen size is causing a problem with this test, something we
 have seen before.


>>>
>>> Yes, screen size does cause problem. Slick grid does not render all
>>> columns if viewport is not wide enough (like it does for rows).
>>> Remaining columns would render when user scrolls right.
>>>
>>> To avoid similar problem in datatype feature test (commit:
>>> 88bcd3b5129db88975421e26c1bf188daf4892f9
>>> )
>>> I have executed
>>> queries in batch to limit number of columns in single query result.
>>>
>>>
>>>

>
>>
>> Thanks
>> Joao
>>
>> On Thu, Mar 29, 2018 at 9:03 AM Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hey Akshay and Neethu

 We refactored the patch to add tests for the resize feature.  We
 were able to write test cases for the drag event by using spies and 
 setting
 the rect dimensions.  In cases like this, we can just test some 
 components
 in order to have enough confidence in the code.  So we isolated the
 function that implements the behavior of this feature and tested that 
 it
 was performing as expected.

 We ran the patch through the pipelines and all of the tests passed.

>>>
>>> I'm consistently seeing the feature test failure below with this
>>> patch

Re: Bug #3083 fix

2018-04-11 Thread Joao De Almeida Pereira

Hi Dave,
Do you still have issues in your environment?

Thanks
Joao

On Wed, Apr 11, 2018 at 5:56 AM Dave Page  wrote:

> Joao, are you looking at this?
>
> On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Tue, Apr 3, 2018 at 6:10 PM, Dave Page  wrote:
>>
>>> Argh, managed to send before I finished typing...
>>>
>>> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page  wrote:
>>>
 Hi

 On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hi Dave,
> That looks like in the surrounding area of the change. We run our
> pipeline and everything was green.
> Can you provide more details, which python version are you using? OS?
>

 That was on my travel laptop, which is macOS Sierra with the Apple
 supplied Python 2.7.

 Interestingly, I'm on my dev laptop today (same OS and Python) and it's
 working just fine. The difference is that the travel machine is a 12"
 Macbook, whilst the dev machine is

>>>
>>> a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if
>>> the small screen size is causing a problem with this test, something we
>>> have seen before.
>>>
>>>
>>
>> Yes, screen size does cause problem. Slick grid does not render all
>> columns if viewport is not wide enough (like it does for rows).
>> Remaining columns would render when user scrolls right.
>>
>> To avoid similar problem in datatype feature test (commit:
>> 88bcd3b5129db88975421e26c1bf188daf4892f9
>> )
>> I have executed
>> queries in batch to limit number of columns in single query result.
>>
>>
>>
>>>

>
> Thanks
> Joao
>
> On Thu, Mar 29, 2018 at 9:03 AM Dave Page  wrote:
>
>> Hi
>>
>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hey Akshay and Neethu
>>>
>>> We refactored the patch to add tests for the resize feature.  We
>>> were able to write test cases for the drag event by using spies and 
>>> setting
>>> the rect dimensions.  In cases like this, we can just test some 
>>> components
>>> in order to have enough confidence in the code.  So we isolated the
>>> function that implements the behavior of this feature and tested that it
>>> was performing as expected.
>>>
>>> We ran the patch through the pipelines and all of the tests passed.
>>>
>>
>> I'm consistently seeing the feature test failure below with this
>> patch applied:
>>
>> ==
>> FAIL: runTest
>> (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
>> Validate Insert, Update operations in View/Edit data with given test
>> data
>> --
>> Traceback (most recent call last):
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
>> line 125, in runTest
>> self._verify_row_data(True)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
>> line 325, in _verify_row_data
>> self.assertEquals(cells[idx], config_data[str(idx)][1])
>> AssertionError: u'[null]' != u'1'
>> - [null]
>> + 1
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: Bug #3083 fix

2018-04-11 Thread Dave Page

Joao, are you looking at this?

On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Tue, Apr 3, 2018 at 6:10 PM, Dave Page  wrote:
>
>> Argh, managed to send before I finished typing...
>>
>> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hi Dave,
 That looks like in the surrounding area of the change. We run our
 pipeline and everything was green.
 Can you provide more details, which python version are you using? OS?

>>>
>>> That was on my travel laptop, which is macOS Sierra with the Apple
>>> supplied Python 2.7.
>>>
>>> Interestingly, I'm on my dev laptop today (same OS and Python) and it's
>>> working just fine. The difference is that the travel machine is a 12"
>>> Macbook, whilst the dev machine is
>>>
>>
>> a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if
>> the small screen size is causing a problem with this test, something we
>> have seen before.
>>
>>
>
> Yes, screen size does cause problem. Slick grid does not render all
> columns if viewport is not wide enough (like it does for rows).
> Remaining columns would render when user scrolls right.
>
> To avoid similar problem in datatype feature test (commit:
> 88bcd3b5129db88975421e26c1bf188daf4892f9
> )
> I have executed
> queries in batch to limit number of columns in single query result.
>
>
>
>>
>>>

 Thanks
 Joao

 On Thu, Mar 29, 2018 at 9:03 AM Dave Page  wrote:

> Hi
>
> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hey Akshay and Neethu
>>
>> We refactored the patch to add tests for the resize feature.  We were
>> able to write test cases for the drag event by using spies and setting 
>> the
>> rect dimensions.  In cases like this, we can just test some components in
>> order to have enough confidence in the code.  So we isolated the function
>> that implements the behavior of this feature and tested that it was
>> performing as expected.
>>
>> We ran the patch through the pipelines and all of the tests passed.
>>
>
> I'm consistently seeing the feature test failure below with this patch
> applied:
>
> ==
> FAIL: runTest (pgadmin.feature_tests.view_da
> ta_dml_queries.CheckForViewDataTest)
> Validate Insert, Update operations in View/Edit data with given test
> data
> --
> Traceback (most recent call last):
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 125, in runTest
> self._verify_row_data(True)
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 325, in _verify_row_data
> self.assertEquals(cells[idx], config_data[str(idx)][1])
> AssertionError: u'[null]' != u'1'
> - [null]
> + 1
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Bug #3083 fix

2018-04-03 Thread Harshal Dhumal

-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Apr 3, 2018 at 6:10 PM, Dave Page  wrote:

> Argh, managed to send before I finished typing...
>
> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hi Dave,
>>> That looks like in the surrounding area of the change. We run our
>>> pipeline and everything was green.
>>> Can you provide more details, which python version are you using? OS?
>>>
>>
>> That was on my travel laptop, which is macOS Sierra with the Apple
>> supplied Python 2.7.
>>
>> Interestingly, I'm on my dev laptop today (same OS and Python) and it's
>> working just fine. The difference is that the travel machine is a 12"
>> Macbook, whilst the dev machine is
>>
>
> a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if
> the small screen size is causing a problem with this test, something we
> have seen before.
>
>

Yes, screen size does cause problem. Slick grid does not render all columns
if viewport is not wide enough (like it does for rows).
Remaining columns would render when user scrolls right.

To avoid similar problem in datatype feature test (commit:
88bcd3b5129db88975421e26c1bf188daf4892f9
)
I have executed
queries in batch to limit number of columns in single query result.



>
>>
>>>
>>> Thanks
>>> Joao
>>>
>>> On Thu, Mar 29, 2018 at 9:03 AM Dave Page  wrote:
>>>
 Hi

 On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hey Akshay and Neethu
>
> We refactored the patch to add tests for the resize feature.  We were
> able to write test cases for the drag event by using spies and setting the
> rect dimensions.  In cases like this, we can just test some components in
> order to have enough confidence in the code.  So we isolated the function
> that implements the behavior of this feature and tested that it was
> performing as expected.
>
> We ran the patch through the pipelines and all of the tests passed.
>

 I'm consistently seeing the feature test failure below with this patch
 applied:

 ==
 FAIL: runTest (pgadmin.feature_tests.view_da
 ta_dml_queries.CheckForViewDataTest)
 Validate Insert, Update operations in View/Edit data with given test
 data
 --
 Traceback (most recent call last):
   File 
 "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
 line 125, in runTest
 self._verify_row_data(True)
   File 
 "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
 line 325, in _verify_row_data
 self.assertEquals(cells[idx], config_data[str(idx)][1])
 AssertionError: u'[null]' != u'1'
 - [null]
 + 1


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: Bug #3083 fix

2018-04-03 Thread Dave Page

Argh, managed to send before I finished typing...

On Tue, Apr 3, 2018 at 1:38 PM, Dave Page  wrote:

> Hi
>
> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Dave,
>> That looks like in the surrounding area of the change. We run our
>> pipeline and everything was green.
>> Can you provide more details, which python version are you using? OS?
>>
>
> That was on my travel laptop, which is macOS Sierra with the Apple
> supplied Python 2.7.
>
> Interestingly, I'm on my dev laptop today (same OS and Python) and it's
> working just fine. The difference is that the travel machine is a 12"
> Macbook, whilst the dev machine is
>

a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if the
small screen size is causing a problem with this test, something we have
seen before.


>
>
>>
>> Thanks
>> Joao
>>
>> On Thu, Mar 29, 2018 at 9:03 AM Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hey Akshay and Neethu

 We refactored the patch to add tests for the resize feature.  We were
 able to write test cases for the drag event by using spies and setting the
 rect dimensions.  In cases like this, we can just test some components in
 order to have enough confidence in the code.  So we isolated the function
 that implements the behavior of this feature and tested that it was
 performing as expected.

 We ran the patch through the pipelines and all of the tests passed.

>>>
>>> I'm consistently seeing the feature test failure below with this patch
>>> applied:
>>>
>>> ==
>>> FAIL: runTest (pgadmin.feature_tests.view_da
>>> ta_dml_queries.CheckForViewDataTest)
>>> Validate Insert, Update operations in View/Edit data with given test data
>>> --
>>> Traceback (most recent call last):
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
>>> line 125, in runTest
>>> self._verify_row_data(True)
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
>>> line 325, in _verify_row_data
>>> self.assertEquals(cells[idx], config_data[str(idx)][1])
>>> AssertionError: u'[null]' != u'1'
>>> - [null]
>>> + 1
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Bug #3083 fix

2018-04-03 Thread Dave Page

Hi

On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Dave,
> That looks like in the surrounding area of the change. We run our pipeline
> and everything was green.
> Can you provide more details, which python version are you using? OS?
>

That was on my travel laptop, which is macOS Sierra with the Apple supplied
Python 2.7.

Interestingly, I'm on my dev laptop today (same OS and Python) and it's
working just fine. The difference is that the travel machine is a 12"
Macbook, whilst the dev machine is


>
> Thanks
> Joao
>
> On Thu, Mar 29, 2018 at 9:03 AM Dave Page  wrote:
>
>> Hi
>>
>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hey Akshay and Neethu
>>>
>>> We refactored the patch to add tests for the resize feature.  We were
>>> able to write test cases for the drag event by using spies and setting the
>>> rect dimensions.  In cases like this, we can just test some components in
>>> order to have enough confidence in the code.  So we isolated the function
>>> that implements the behavior of this feature and tested that it was
>>> performing as expected.
>>>
>>> We ran the patch through the pipelines and all of the tests passed.
>>>
>>
>> I'm consistently seeing the feature test failure below with this patch
>> applied:
>>
>> ==
>> FAIL: runTest (pgadmin.feature_tests.view_data_dml_queries.
>> CheckForViewDataTest)
>> Validate Insert, Update operations in View/Edit data with given test data
>> --
>> Traceback (most recent call last):
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
>> line 125, in runTest
>> self._verify_row_data(True)
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
>> line 325, in _verify_row_data
>> self.assertEquals(cells[idx], config_data[str(idx)][1])
>> AssertionError: u'[null]' != u'1'
>> - [null]
>> + 1
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Bug #3083 fix

2018-03-29 Thread Joao De Almeida Pereira

Hi Dave,
That looks like in the surrounding area of the change. We run our pipeline
and everything was green.
Can you provide more details, which python version are you using? OS?

Thanks
Joao

On Thu, Mar 29, 2018 at 9:03 AM Dave Page  wrote:

> Hi
>
> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hey Akshay and Neethu
>>
>> We refactored the patch to add tests for the resize feature.  We were
>> able to write test cases for the drag event by using spies and setting the
>> rect dimensions.  In cases like this, we can just test some components in
>> order to have enough confidence in the code.  So we isolated the function
>> that implements the behavior of this feature and tested that it was
>> performing as expected.
>>
>> We ran the patch through the pipelines and all of the tests passed.
>>
>
> I'm consistently seeing the feature test failure below with this patch
> applied:
>
> ==
> FAIL: runTest
> (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
> Validate Insert, Update operations in View/Edit data with given test data
> --
> Traceback (most recent call last):
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 125, in runTest
> self._verify_row_data(True)
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 325, in _verify_row_data
> self.assertEquals(cells[idx], config_data[str(idx)][1])
> AssertionError: u'[null]' != u'1'
> - [null]
> + 1
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: Bug #3083 fix

2018-03-29 Thread Dave Page

Hi

On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hey Akshay and Neethu
>
> We refactored the patch to add tests for the resize feature.  We were able
> to write test cases for the drag event by using spies and setting the rect
> dimensions.  In cases like this, we can just test some components in order
> to have enough confidence in the code.  So we isolated the function that
> implements the behavior of this feature and tested that it was performing
> as expected.
>
> We ran the patch through the pipelines and all of the tests passed.
>

I'm consistently seeing the feature test failure below with this patch
applied:

==
FAIL: runTest
(pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Update operations in View/Edit data with given test data
--
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 125, in runTest
self._verify_row_data(True)
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 325, in _verify_row_data
self.assertEquals(cells[idx], config_data[str(idx)][1])
AssertionError: u'[null]' != u'1'
- [null]
+ 1


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Bug #3083 fix

2018-03-29 Thread Akshay Joshi

Thanks Joao.

On Wed, Mar 28, 2018 at 11:36 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hey Akshay and Neethu
>
> We refactored the patch to add tests for the resize feature.  We were able
> to write test cases for the drag event by using spies and setting the rect
> dimensions.  In cases like this, we can just test some components in order
> to have enough confidence in the code.  So we isolated the function that
> implements the behavior of this feature and tested that it was performing
> as expected.
>
> We ran the patch through the pipelines and all of the tests passed.
>
> Sincerely,
>
> Joao and Victoria
>
> On Wed, Mar 28, 2018 at 8:03 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi
>>
>> On Fri, Mar 2, 2018 at 3:40 AM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello Neethu,
>>> We passed the patch through our CI pipeline and all tests pass.
>>> The code looks good, but we are trying to decouple files as much  as we
>>> can so that we do not end up with files with over 1000 lines, that are hard
>>> to read and to maintain. Also we are trying to create Unit Tests to have
>>> more coverage in our Javascript code.
>>>
>>> Can you split the new implementation code into it's own file and create
>>> some tests to ensure the behavior will not be broken in the future?iYou
>>> have some examples on: pgadmin/browser/server_groups/servers/databases/
>>> external_tables/*
>>>
>>
>> I have spilt the new implementation into different file. Its' been
>> hard to write jasmine/feature test case as it requires drag event and exact
>> co-ordinate to resize the slickgrid cell.
>> Attached is the modified patch.
>>
>>
>>>
>>> Thanks
>>> Joao
>>>
>>> On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <
>>> neethumariya...@gmail.com> wrote:
>>>
 Hi,
 I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer
 Science at BITS Pilani.

 I've attempted to fix https://redmine.postgresql.org/issues/3083.
 Since the textarea resize feature is the default HTML feature, I have not
 changed it. Instead, I've added draggable borders to the wrapper which
 expands the textarea inside it.

 I'm attaching my patch as bug3083.diff below as per the contribution
 guidelines.

 Hope this helps. Thank you for your consideration!

 Sincerely,
 Neethu Mariya Joy
 GitHub  | Linkedin
 



>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: Bug #3083 fix

2018-03-28 Thread Joao De Almeida Pereira

Hey Akshay and Neethu

We refactored the patch to add tests for the resize feature.  We were able
to write test cases for the drag event by using spies and setting the rect
dimensions.  In cases like this, we can just test some components in order
to have enough confidence in the code.  So we isolated the function that
implements the behavior of this feature and tested that it was performing
as expected.

We ran the patch through the pipelines and all of the tests passed.

Sincerely,

Joao and Victoria

On Wed, Mar 28, 2018 at 8:03 AM Akshay Joshi 
wrote:

> Hi
>
> On Fri, Mar 2, 2018 at 3:40 AM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Neethu,
>> We passed the patch through our CI pipeline and all tests pass.
>> The code looks good, but we are trying to decouple files as much  as we
>> can so that we do not end up with files with over 1000 lines, that are hard
>> to read and to maintain. Also we are trying to create Unit Tests to have
>> more coverage in our Javascript code.
>>
>> Can you split the new implementation code into it's own file and create
>> some tests to ensure the behavior will not be broken in the future?iYou
>> have some examples
>> on: pgadmin/browser/server_groups/servers/databases/external_tables/*
>>
>
> I have spilt the new implementation into different file. Its' been
> hard to write jasmine/feature test case as it requires drag event and exact
> co-ordinate to resize the slickgrid cell.
> Attached is the modified patch.
>
>
>>
>> Thanks
>> Joao
>>
>> On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <
>> neethumariya...@gmail.com> wrote:
>>
>>> Hi,
>>> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science
>>> at BITS Pilani.
>>>
>>> I've attempted to fix https://redmine.postgresql.org/issues/3083. Since
>>> the textarea resize feature is the default HTML feature, I have not changed
>>> it. Instead, I've added draggable borders to the wrapper which expands the
>>> textarea inside it.
>>>
>>> I'm attaching my patch as bug3083.diff below as per the contribution
>>> guidelines.
>>>
>>> Hope this helps. Thank you for your consideration!
>>>
>>> Sincerely,
>>> Neethu Mariya Joy
>>> GitHub  | Linkedin
>>> 
>>>
>>>
>>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>
diff --git a/web/pgadmin/static/js/slickgrid/editors.js b/web/pgadmin/static/js/slickgrid/editors.js
index 7652bf3b..a7df4baf 100644
--- a/web/pgadmin/static/js/slickgrid/editors.js
+++ b/web/pgadmin/static/js/slickgrid/editors.js
@@ -3,8 +3,9 @@
  * @module Editors
  * @namespace Slick
  */
+import {resizeContentOnDrag} from 'resize_editor';
 
-(function($) {
+(function ($) {
   // register namespace
   $.extend(true, window, {
 'Slick': {
@@ -52,6 +53,7 @@
 val = $.trim(val);
 return !(val != '' && (val.charAt(0) != '{' || val.charAt(val.length - 1) != '}'));
   }
+
   /*
* This function handles the [default] and [null] values for cells
* if row is copied, otherwise returns the editor value.
@@ -129,7 +131,7 @@
 var defaultValue;
 var scope = this;
 
-this.init = function() {
+this.init = function () {
   var $container = $('body');
 
   $wrapper = getWrapper().appendTo($container);
@@ -140,11 +142,12 @@
   $buttons.find('button:last').on('click', this.cancel);
   $input.bind('keydown', this.handleKeyDown);
 
+  resizeContentOnDrag($wrapper, $input);
   scope.position(args.position);
   $input.focus().select();
 };
 
-this.handleKeyDown = function(e) {
+this.handleKeyDown = function (e) {
   if (e.which == $.ui.keyCode.ENTER && e.ctrlKey) {
 scope.save();
   } else if (e.which == $.ui.keyCode.ESCAPE) {
@@ -159,40 +162,40 @@
   }
 };
 
-this.save = function() {
+this.save = function () {
   args.commitChanges();
 };
 
-this.cancel = function() {
+this.cancel = function () {
   $input.val(defaultValue);
   args.cancelChanges();
 };
 
-this.hide = function() {
+this.hide = function () {
   $wrapper.hide();
 };
 
-this.show = function() {
+this.show = function () {
   $wrapper.show();
 };
 
-this.position = function(position) {
+this.position = function (position) {
   calculateEditorPosition(position, $wrapper);
   $wrapper
 .css('top', position.top)
 .css('left', position.left);
 };
 
-this.destroy = function() {
+this.destroy = function () {
   $wrapper.remove();
 };
 
-this.focus = function() {
+this.focus = function () {
   $input.focus();
 };
 
 // When text editor opens
-this.loadValue = function(item) {
+this.loadValue = function (item) {
   if (
 _.isUndefined(item[args.column.field]) ||
 _.isNull

Re: Bug #3083 fix

2018-03-28 Thread Akshay Joshi

Hi

On Fri, Mar 2, 2018 at 3:40 AM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Neethu,
> We passed the patch through our CI pipeline and all tests pass.
> The code looks good, but we are trying to decouple files as much  as we
> can so that we do not end up with files with over 1000 lines, that are hard
> to read and to maintain. Also we are trying to create Unit Tests to have
> more coverage in our Javascript code.
>
> Can you split the new implementation code into it's own file and create
> some tests to ensure the behavior will not be broken in the future?iYou
> have some examples on: pgadmin/browser/server_groups/servers/databases/
> external_tables/*
>

I have spilt the new implementation into different file. Its' been hard
to write jasmine/feature test case as it requires drag event and exact
co-ordinate to resize the slickgrid cell.
Attached is the modified patch.


>
> Thanks
> Joao
>
> On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <
> neethumariya...@gmail.com> wrote:
>
>> Hi,
>> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science
>> at BITS Pilani.
>>
>> I've attempted to fix https://redmine.postgresql.org/issues/3083. Since
>> the textarea resize feature is the default HTML feature, I have not changed
>> it. Instead, I've added draggable borders to the wrapper which expands the
>> textarea inside it.
>>
>> I'm attaching my patch as bug3083.diff below as per the contribution
>> guidelines.
>>
>> Hope this helps. Thank you for your consideration!
>>
>> Sincerely,
>> Neethu Mariya Joy
>> GitHub  | Linkedin
>> 
>>
>>
>>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


RM_3083_v2.patch
Description: Binary data

Re: Bug #3083 fix

2018-03-01 Thread Joao De Almeida Pereira

Hello Neethu,
We passed the patch through our CI pipeline and all tests pass.
The code looks good, but we are trying to decouple files as much  as we can
so that we do not end up with files with over 1000 lines, that are hard to
read and to maintain. Also we are trying to create Unit Tests to have more
coverage in our Javascript code.

Can you split the new implementation code into it's own file and create
some tests to ensure the behavior will not be broken in the future?iYou
have some examples
on: pgadmin/browser/server_groups/servers/databases/external_tables/*

Thanks
Joao

On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy 
wrote:

> Hi,
> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science
> at BITS Pilani.
>
> I've attempted to fix https://redmine.postgresql.org/issues/3083. Since
> the textarea resize feature is the default HTML feature, I have not changed
> it. Instead, I've added draggable borders to the wrapper which expands the
> textarea inside it.
>
> I'm attaching my patch as bug3083.diff below as per the contribution
> guidelines.
>
> Hope this helps. Thank you for your consideration!
>
> Sincerely,
> Neethu Mariya Joy
> GitHub  | Linkedin
> 
>
>
>

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

Re: Bug #3083 fix

12 matches

Site Navigation

Mail list logo

Footer information