Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hello Dave and Ashesh, Do you still need us to provide more information about this patch or is it ready to be merged? Thanks Joao On Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > We found out a issue

[pgadmin-hackers] Change color of selected rows on SQLEditor

Hi Hackers, >From a visual standpoint, grey highlight makes selection look deselected rather than selected. A brighter color would quickly provide visual feedback on an action. With this patch the color of selected rows look more highlighted. Thanks Joao

Re: [pgadmin-hackers][patch] Move test_utils.py into python_test_utils/

Hi Hackers, Sorry for not being more careful about the creation of patches and the Python 2 vs Python 3 issue. Thanks Joao & Sarah On Thu, Mar 23, 2017 at 8:00 AM, Dave Page wrote: > Thanks, committed. Note that this patch also touched >

[pgadmin-hackers][patch] Raise InternalServerError while retrieving table DDL

Hi Hackers, While doing the DDL patch we found out that the code was not working properly when errors happened during SQL execution: One example of this can be found in the file: web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py The function '*_formatter*' that

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hello Hackers, We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached. Also we would like to know the status of this. Thanks Joao & Sarah On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear wrote: > Hi! > > We

[pgadmin-hackers][patch] Column selection on SQLEditor

Hi Hackers, Attached you can find the patches that finish the following Redmine Issue https://redmine.postgresql.org/issues/2216 *Note:* These changes depend on the acceptance of the patch that we submitted on the email thread: "Refactor: clipboard, translations, jasmine" This makes some

[pgadmin-hackers][patch] Update Selenium and Chrome driver

Hello Hackers, Chrome's latest update to version 57 is not compatible with the Chrome driver of Selenium. This patch updates Selenium and adds the latest Chrome driver to make the tests run. Thanks Joao & Sarah 0001-Update-Selenium-and-ChromeDriver-to-support-chrome-v.patch Description: Binary

[pgadmin-hackers][patch] Correct syntax errors on Javascript test

Hello Hackers, We noticed that some Python comments were added to the fake_translations.js file. We flushed out this issue running the Jasmine tests by doing(do not forget to install node dependencies instructions in web/regression/README): cd $PGADMIN4_SRC/web/ karma start This patch corrects

[pgadmin-hackers][patch] Update chrome driver to support chrome version 58 in tests

Hi Hackers, With the update to version 58 of chrome the version of the chrome driver of Selenium need to be updated to version 2.29. This patch does that change. Note: If you had previously installed the old driver you need to uninstall and install again it. $ pip uninstall

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Apr 20, 2017 at 8:15 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Ashesh, >> >> Did you had time to review this patch? >> > Yes - I did. > > Please my review comments: > Everytime I start pgAdmin 4, I am

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Hello Hackers, We review the patch, just noticed a spelling issue so we regenerated the patch. Thanks Joao & Oliver On Fri, Apr 21, 2017 at 1:21 AM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > Hi Joao & Oliver, > > On Fri, Apr 21, 2017 at 3:39 AM, Joao P

Re: [pgadmin-hackers][patch] Move to Alembic migration system

d = user_info()* >>>>>> * File >>>>>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/user_info.py", >>>>>> line 50, in user_info* >>>>>> *email = input("Email address: ")* >>>&g

Re: [pgadmin-hackers] Pains and thoughts about refactoring the Tree Menu using React

Hi Hackers, The attachment was missing in the previous email, so there you go. Note: We had to remove the extension of the file due to security reasons, just add a .js Thanks Joao & Oliver On Fri, Apr 21, 2017 at 2:47 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io

[pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Hackers, We found out that when you are connected to a GreenPlum database and try to get Dependents and Dependencies of an object the application was returning a SQL error. This patch splits the SQL query used to retrieve the Dependents, Dependencies, and Roles SQL file into multiple

Re: [pgadmin-hackers][patch] Update chrome driver to support chrome version 58 in tests

s] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] >or: -c --help [cmd1 cmd2 ...] >or: -c --help-commands >or: -c cmd --help > > error: option --chromedriver-version not recognized > > > > On Fri, Apr 21, 2017 at 9:54 AM, Dave Page <dp...@pgadmin.or

[pgadmin-hackers] Pains and thoughts about refactoring the Tree Menu using React

Hi Hackers, After a conversation with Dave we believe that we need to provide more context on our pains and what we propose as a first step for implementing the Tree Menu using React. The pain: Here is a quick description of what we think we understand and where we got stuck while doing our

Re: [pgadmin-hackers][patch] Shows titles for disabled buttons on hover

Hello Dave, We were looking into this request and we found at least one location where the Hover does not make sense when it is disabled (the stylized "i' in the lower left of dialogs, which has the alt-text "SQL help for this object type".) Could this patch be pulled in, as the buttons for

[pgadmin-hackers] Introduce Migration system for SQLite database

Hi Hackers, We were looking at the migration pattern created for the SQLite database and tried to look into the possibility of using a library that could handle them for us. - Migrations allow us to have a single path of creating the table instead of creating tables using SQLAlchemy or hand

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

ave Page <dp...@pgadmin.org> wrote: > Hi > > On Wed, Mar 1, 2017 at 9:34 PM, Joao Pedro De Almeida Pereira > <jpere...@pivotal.io> wrote: > > Hi Hackers > > > > We noticed that the feature test dependencies were removed in a recent > > patch, so we

[pgadmin-hackers][patch] Test dependencies and screenshots

Hi Hackers We noticed that the feature test dependencies were removed in a recent patch, so we added them back. We also now create a screenshot with a timestamp when tests fail. This should help with debugging issues in CI. -- Thanks Joao & Tira 0001-Added-feature-test-dependencies.patch

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hello Hackers, We just looked into this patch and have some questions about it. - Where is the JSON file created? Do we need to call it with some special argument in order for it to be created? - There is a print statement in the line 275 of runtests.py is it supposed to be there? - The function

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

> wrote: > On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Ashesh, can you review/commit this please? >> >> On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >&g

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

same format for "Size" everywhere in the UI. Thanks Joao & Sarah On Tue, Apr 25, 2017 at 11:48 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao & Sarah, > > Thanks for reviewing the patch. > > On Tue, Apr 25, 2017 at 8:34 PM, Joao Pedro D

[pgadmin-hackers] Issue with SlickGrid

Hello Hackers, While doing some changes to the Query Results we found out that there was a issue with Slick grid. The issue that we found was with the CellSelectModel, behaved differently when pressing Ctrl and Command(Mac). We created a PR with the

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Thanks for reviewing, Ashesh. We have updated the patch. The headers are all consistent and we removed the __init__.py files in directories containing only .sql. Thanks! Joao & Matt On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote

Re: [pgadmin-hackers] Issue with SlickGrid

ot;appendRowHtml()" function to calculating >> the correct number of rows in SlickGrid result as we have added our own >> custom row as mentioned earlier. >> 3) Abbreviated long CSS classes as mentioed in README file. >> >> Apologies we missed to update this change

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

Hello Khushboo, We reviewed the this patch and have some suggestions: *Python:* ​ The functionality for adding the "can_prettify" is repeated in multiple places. Maybe this could be extracted into a function. *Javascript:* ​ - The class Backgrid.SizeFormatter doesn't seem to have any tests.

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of menu visibility when node is hidden

Hi Murtuza, Since you are adding a new function to the browser.js component, we would encourage you to extract the function out of the templated javascript file so that it can be tested. A good example of this would be the pgadmin/static/js/size_prettify.js. For this specific function we found

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

gt;>> Aww, nuts. I thought we had tests for that? Did we miss that particular >>>> case? >>>> >>>> Anyway, copying of a single value still works (with Cmd+C), so I'm not >>>> inclined to re-wrap everything for this unless someone can get a patch

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hello Hackers, We looked into this patch and it looks like it touches part of the tree menu am I correct? In our previous conversations with Dave, he mentioned that he wanted to replace the tree menu with a more stable version of it. In our perspective, every time that we have the opportunity

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi hackers, We were checking out the selection functionality after this commit--looks like selection no longer works for single cells. If you press a cell in the grid the following message is console logged: sqleditor.js:869 Uncaught TypeError: Cannot read property 'indexOf' of undefined at

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

orge On Thu, May 11, 2017 at 7:33 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello all, > This test is trying to check if the sql to retrieve the role dependencies > of a object in the database is correct. Using a different user to connect > to the data

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

Hello Hackers, We sent the wrong patch. Attached is the correct one. Sorry Shruti & Joao On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We were trying to run the feature tests against GreenPlum and

[pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

Hi Hackers, We were trying to run the feature tests against GreenPlum and one of the tests was failing (CheckForViewDataTest). In this test, we are creating a table using COLLATE, and the COLLATE command is only available starting in version 9.1 of Postgres, per the documentation. We decided to

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hello Hackers, @Dave, @Murtuza We do understand that the changes are tightly coupled with the tree, but if we want to be able to upgrade our tree menu in the future, we need to start decoupling functionality and the underlaying tree. Another step that we can take is to change our variable naming

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hello Hackers, We reviewed the PR, and there are a lot of new lines of code in this patch, are we sure that we can have a good coverage of the functionality just by doing feature tests? Adding more code to a 3.5k+ lines file doesn't look like a good option, do you think it is possible to extract

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hello Harshal, We review the patch and have some questions: 1) Is there any particular reason to initialize variables and functions in the same place? We believe that it would be more readable there were no chaining of variable creation, specially if those variables are functions. Check line:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

Hello ​I wrote few grunt tasks using r.js optimizer this weekend > > How did it compare to webpack? I am already starting to wonder if Grunt is the best way to do this though. > It might be easier (though not quite as efficient) to have the Python > module all return their static/template JS

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

appear ​ We also noticed that the function _wait is no longer used. Maybe we can remove it. Thanks Joao & Shruti On Fri, May 26, 2017 at 9:07 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Please find updated patch. > > On Fri, May 26, 2017 at 3:15 AM, Joao P

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

; > >c) Insert a string \’\’, expected value is '' > > > >d) Insert a string \\’\\’, expected value is \’\’ > > > >e) Insert a string \\\\’\\\\’, expected value is \\’\\’ > > > >f) If a checkbox cell is double clicked, return value must be '

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

Hello Dave, By the description on the email, it looks like the process is very similar to the Grunt process that we were talking about, but without the patch, it is a bit hard to get more specifics. Can you forward the patch so we can take a look at it. We believe that every effort done to

Re: [pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

Hello Hackers, We will create a new patch to solve this issue. Thanks Joao & Shruti On Tue, Jun 13, 2017 at 9:37 AM, Dave Page wrote: > Pivotal team, > > Per the commit below, and the probably many messages you've likely > seen from Jenkins, I've had to disable the

[pgadmin-hackers][patch] Correct bundle test that polluted Python modules

Hi Hackers, Attached you can find the patch that corrects that Bundle tests that was polluting the os and subprocess modules. This patch reverts the commit that skipped the test. Thanks Shruti & Joao correct-bundle-test.patch Description: Binary data -- Sent via pgadmin-hackers mailing

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

Hi Hackers, Good catch Dave. You can find attached the new diff with the correction of the problem above. Thanks Shruti & Joao On Tue, Jun 13, 2017 at 10:35 AM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereir

Re: [pgadmin-hackers] Pains and thoughts about refactoring the Tree Menu using React

api, we would simply add the new nodes as children in the tree. Joao & Matt On Fri, Apr 28, 2017 at 5:51 AM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > On Sat, Apr 22, 2017 at 12:17 AM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >&

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

easonable to me and I am going to use a single javascript >>> function which will support PB also (as per Dave we should add support till >>> PB) . >>> >>>> If the community believes we can live with this risk, let's move >>>> forward. >>>> >>>

[pgadmin-hackers] Running feature tests in CI

Hello Hackers, We were looking through the CI configuration and we did not understand why the feature tests are not running. What is the reason for excluding them? Thanks Joao & Sarah

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

> > The motivation is simple - we want a solution that works for the whole > app, can handle debug vs. release execution, pluggable modules, and > installations in read-only directories. With the current configuration of Grunt, all the requirements you mention are available. The tasks on Grunt