pgsql: Remove redundant JSON parser typedefs

2024-04-27 Thread Andrew Dunstan
Remove redundant JSON parser typedefs JsonNonTerminal and JsonParserSem were added in commit 3311ea86ed These names of these two enums are not actually used, so there is no need for typedefs. Instead use plain enums to declare the constants. Noticed by Alvaro Herera. Branch -- master

pgsql: Add pg_logging_init() calls missing in commit ba3e6e2bca

2024-04-24 Thread Andrew Dunstan
Add pg_logging_init() calls missing in commit ba3e6e2bca As noticed by Michael Paquier. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cc893b82370b5d68e0a72f5bb1663644a3a0351d Modified Files --

pgsql: Post review fixes for test_json_parser test module

2024-04-23 Thread Andrew Dunstan
Post review fixes for test_json_parser test module . Add missing copytight notices . improve code coverage . put work files in a temp directory in the standard location . improve error checking in C code . indent perl files with perltidy . add some comments per comments from Michael Paquier

Re: pgsql: Fix assorted bugs in ecpg's macro mechanism.

2024-04-18 Thread Andrew Dunstan
define.c and define_prelim.c. Not sure who has the requisite knowledge to do that - I don't. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

pgsql: Shrink test file for test_json_parser module

2024-04-12 Thread Andrew Dunstan
Shrink test file for test_json_parser module Also delete live URLs Jacob Champion Discussion: https://postgr.es/m/CAOYmi+mtH=v1wzkaoaucd5qqqwr61hnxmjbj9h-czxaa1jx...@mail.gmail.com Branch -- master Details ---

pgsql: Assorted minor cleanups in the test_json_parser module

2024-04-12 Thread Andrew Dunstan
Assorted minor cleanups in the test_json_parser module Per gripes from Michael Paquier Discussion: https://postgr.es/m/zhtq6_w1vwohq...@paquier.xyz Along the way, also clean up a handful of typos in 3311ea86ed and ea7b4e9a2a, found by Alexander Lakhin, and a couple of stylistic snafus noted by

pgsql: Add a TAP test for test_json_parser_perf

2024-04-12 Thread Andrew Dunstan
Add a TAP test for test_json_parser_perf This just makes sure the test can run with a single iteration. A real performance test would test with many more. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/daf554dbeabf0957a25c9e37488d42c047c0ce23 Modified Files

pgsql: Don't allocate large buffer on the stack in pg_verifybackup

2024-04-12 Thread Andrew Dunstan
Don't allocate large buffer on the stack in pg_verifybackup Per complaint from Andres Freund. Follow his suggestion to allocate the buffer once in the calling routine instead. Also make a tiny indentation improvement. Discussion:

pgsql: Fix some memory leaks associated with parsing json and manifests

2024-04-12 Thread Andrew Dunstan
Fix some memory leaks associated with parsing json and manifests Coverity complained about not freeing some memory associated with incrementally parsing backup manifests. To fix that, provide and use a new shutdown function for the JsonManifestParseIncrementalState object, in line with a

pgsql: Silence some compiler warnings in commit 3311ea86ed

2024-04-05 Thread Andrew Dunstan
Silence some compiler warnings in commit 3311ea86ed Per report from Nathan Bossart Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c3e60f3d7e4268c6448ec592053b3b893899867d Modified Files -- src/common/jsonapi.c | 7 +++ 1 file changed, 7

pgsql: Tidy up after incremental JSON parser patch

2024-04-04 Thread Andrew Dunstan
Tidy up after incremental JSON parser patch Remove junk left over from non-vpath builds. Try to remedy gettext error on some platforms. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/88620824c2a62376e224c4b595b9fe69fb858978 Modified Files --

pgsql: Fix warnings re typedef redefinition in ea7b4e9a2a and 3311ea86e

2024-04-04 Thread Andrew Dunstan
Fix warnings re typedef redefinition in ea7b4e9a2a and 3311ea86ed Per gripe from Tom Lane and the buildfarm Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1b00fe30a67774e55c5fc776096a3c96f1a147d2 Modified Files -- src/common/jsonapi.c| 12

Re: pgsql: Add basic JSON_TABLE() functionality

2024-04-04 Thread Andrew Dunstan
On 2024-04-04 Th 09:20, Amit Langote wrote: Hi Andrew, On Thu, Apr 4, 2024 at 10:06 PM Andrew Dunstan wrote: On 2024-04-04 Th 07:21, Amit Langote wrote: Add basic JSON_TABLE() functionality Excellent! But I am getting this: ../../../src/interfaces/ecpg/test/sql/sqljson_jsontable.pgc:23

Re: pgsql: Add basic JSON_TABLE() functionality

2024-04-04 Thread Andrew Dunstan
On 2024-04-04 Th 07:21, Amit Langote wrote: Add basic JSON_TABLE() functionality Excellent! But I am getting this: ../../../src/interfaces/ecpg/test/sql/sqljson_jsontable.pgc:23: WARNING: unsupported feature will be passed to server Is that intended? cheers andrew -- Andrew Dunstan

pgsql: Use incremental parsing of backup manifests.

2024-04-04 Thread Andrew Dunstan
. Author: Andrew Dunstan Reviewed-By: Jacob Champion Discussion: https://postgr.es/m/7b0a51d6-0d9d-7366-3a1a-f74397a02...@dunslane.net Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/222e11a10ae9840929cff617c01cc6f8f695536f Modified Files -- src/backend

pgsql: Add support for incrementally parsing backup manifests

2024-04-04 Thread Andrew Dunstan
of the manifest, including the checksum. Author: Andrew Dunstan Reviewed-By: Jacob Champion Discussion: https://postgr.es/m/7b0a51d6-0d9d-7366-3a1a-f74397a02...@dunslane.net Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ea7b4e9a2a7c23c62278d9a3e0c77310778f62b2

pgsql: Introduce a non-recursive JSON parser

2024-04-04 Thread Andrew Dunstan
, but is an additional parser available to callers. For testing purposes, if the build is done with -DFORCE_JSON_PSTACK, all JSON parsing is done with the non-recursive parser, in which case only trivial regression differences in error messages should be observed. Author: Andrew Dunstan Reviewed-By: Jacob Champion

Re: pgsql: Fix indentation from cafe1056558f

2024-04-03 Thread Andrew Dunstan
On 2024-04-03 We 03:49, Daniel Gustafsson wrote: Fix indentation from cafe1056558f Per buildfarm animal koel Thanks, you beat me to it. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: pgsql: make dist uses git archive

2024-03-26 Thread Andrew Dunstan
On Tue, Mar 26, 2024 at 6:10 AM Andrew Dunstan wrote: > > > On Tue, Mar 26, 2024 at 5:15 AM Magnus Hagander > wrote: > >> >> >> On Tue, Mar 26, 2024 at 9:13 AM Andrew Dunstan >> wrote: >> >>> >>> >>> On Tue, Mar 26,

Re: pgsql: make dist uses git archive

2024-03-26 Thread Andrew Dunstan
On Tue, Mar 26, 2024 at 5:15 AM Magnus Hagander wrote: > > > On Tue, Mar 26, 2024 at 9:13 AM Andrew Dunstan > wrote: > >> >> >> On Tue, Mar 26, 2024 at 3:20 AM Peter Eisentraut >> wrote: >> >>> On 25.03.24 23:20, Andrew Dunstan wrote:

Re: pgsql: make dist uses git archive

2024-03-26 Thread Andrew Dunstan
On Tue, Mar 26, 2024 at 3:20 AM Peter Eisentraut wrote: > On 25.03.24 23:20, Andrew Dunstan wrote: > > The problem occurs because except in vpath mode the buildfarm operates > > on a copy of the code, and for efficiency reasons we don't copy the ,git > > directory. >

Re: pgsql: make dist uses git archive

2024-03-25 Thread Andrew Dunstan
On Mon, Mar 25, 2024 at 5:22 PM Magnus Hagander wrote: > > > On Mon, Mar 25, 2024 at 8:30 PM Peter Eisentraut > wrote: > >> On 25.03.24 10:04, Magnus Hagander wrote: >> > This seems to have broken buildfarm member guaibasaurus, which I >> believe >> > is the only one that runs "make dist" as

Re: pgsql: Add template for adaptive radix tree

2024-03-07 Thread Andrew Dunstan
On 2024-03-07 Th 00:49, John Naylor wrote: Add template for adaptive radix tree drongo and fairywren don't like this, See e.g. <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=drongo=2024-03-07%2016%3A51%3A00> cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

pgsql: Rationalize and improve error messages for some jsonpath items

2024-02-27 Thread Andrew Dunstan
Rationalize and improve error messages for some jsonpath items This is a followup to commit 66ea94e8e6. Error mssages concerning incorrect formats for date-time types are unified and parameterized, instead of using a fully separate error message for each type. Similarly, error messages

pgsql: Disallow jsonpath methods involving TZ in immutable functions

2024-02-10 Thread Andrew Dunstan
Disallow jsonpath methods involving TZ in immutable functions Timezones are not immutable and so neither is any function that relies on them. In commit 66ea94e8, we introduced a few methods which do casting from one time to another and thus may involve the current timezone. To preserve the

pgsql: Avoid package qualification of $windows_os

2024-02-01 Thread Andrew Dunstan
Avoid package qualification of $windows_os Further fallout from commit 6ee26c6a4b. To keep code in sync and avoid issues on older releases with different package names, simply use the unqualified name like many other places in our code. Branch -- REL_16_STABLE Details ---

pgsql: Avoid package qualification of $windows_os

2024-02-01 Thread Andrew Dunstan
Avoid package qualification of $windows_os Further fallout from commit 6ee26c6a4b. To keep code in sync and avoid issues on older releases with different package names, simply use the unqualified name like many other places in our code. Branch -- REL_15_STABLE Details ---

pgsql: Avoid package qualification of $windows_os

2024-02-01 Thread Andrew Dunstan
Avoid package qualification of $windows_os Further fallout from commit 6ee26c6a4b. To keep code in sync and avoid issues on older releases with different package names, simply use the unqualified name like many other places in our code. Branch -- REL_14_STABLE Details ---

pgsql: Avoid package qualification of $windows_os

2024-02-01 Thread Andrew Dunstan
Avoid package qualification of $windows_os Further fallout from commit 6ee26c6a4b. To keep code in sync and avoid issues on older releases with different package names, simply use the unqualified name like many other places in our code. Branch -- REL_13_STABLE Details ---

pgsql: Avoid package qualification of $windows_os

2024-02-01 Thread Andrew Dunstan
Avoid package qualification of $windows_os Further fallout from commit 6ee26c6a4b. To keep code in sync and avoid issues on older releases with different package names, simply use the unqualified name like many other places in our code. Branch -- master Details ---

pgsql: Avoid package qualification of $windows_os

2024-02-01 Thread Andrew Dunstan
Avoid package qualification of $windows_os Further fallout from commit 6ee26c6a4b. To keep code in sync and avoid issues on older releases with different package names, simply use the unqualified name like many other places in our code. Branch -- REL_12_STABLE Details ---

pgsql: Use older name for test_primary_datadir

2024-01-30 Thread Andrew Dunstan
Use older name for test_primary_datadir Releases prior to 14 used the older naming scheme. This fixes a bug un the back-patches of 6ee26c6a4b in releases 12 and 13. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4c1422553bf4e1435c02a57a161c7e58f5aa9c04

pgsql: Use older name for test_primary_datadir

2024-01-30 Thread Andrew Dunstan
Use older name for test_primary_datadir Releases prior to 14 used the older naming scheme. This fixes a bug un the back-patches of 6ee26c6a4b in releases 12 and 13. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c944bf2f07f26aff9fcdfb8f4bf0e4973daeac54

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions,

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions,

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions,

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions,

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions,

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions,

pgsql: Clean up a bug in sql/json items commit 66ea94e8e6

2024-01-25 Thread Andrew Dunstan
Clean up a bug in sql/json items commit 66ea94e8e6 Remove a buggy and unnecessary test, along with an unnecessary pstrdup() and a line of dead code. Per report, diagnosis and fix from Tom Lane Discussion: https://postgr.es/m/439811.1706211...@sss.pgh.pa.us Branch -- master Details ---

pgsql: Implement various jsonpath methods

2024-01-25 Thread Andrew Dunstan
, except for .date(), the date/time related methods take an optional precision to adjust the fractional seconds. Jeevan Chalke, reviewed by Peter Eisentraut and Andrew Dunstan. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/66ea94e8e606529bb334515f388c62314956739e

pgsql: Add copyright notices to a few perl scripts that don't have them

2024-01-05 Thread Andrew Dunstan
Add copyright notices to a few perl scripts that don't have them Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/dbad1c53e92e364e2675f1246e443b95545d4070 Modified Files -- config/check_modules.pl| 3 +++

Re: pgsql: Reorganise jsonpath operators and methods

2024-01-03 Thread Andrew Dunstan
_dumpall: error: pg_dump failed on database "regression", exiting (I also need to make sure we capture the output of pg_dumpall) cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: pgsql: Follow-up fixes for "Make all Perl warnings fatal"

2024-01-02 Thread Andrew Dunstan
kerberos\b/) +elsif (!$ENV{PG_TEST_EXTRA} || $ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/) I think I would have changed it like this   elsif (($ENV{PG_TEST_EXTRA" || "") !~ /\bkerberos\b/) which is an idiom we've used elsewhere. Still, TIMTOWTDI. cheers andrew (japh) --

pgsql: Make win32tzlist.pl checkable again

2023-12-22 Thread Andrew Dunstan
Make win32tzlist.pl checkable again Commit 1301c80b21 removed some infrastructure needed to check windows-oriented perl scripts. It also removed most such scripts, but this one was left over. We repair the damage by making Win32::Registry a conditional requirement that is only loaded on Windows.

pgsql: Rename pgindent options

2023-12-20 Thread Andrew Dunstan
Rename pgindent options --show-diff becomes --diff, and --silent-diff becomes --check. These options may now be given together. Without --check, --diff will exit with a zero status even if diffs are found. With --check, it will now exit with a non-zero status in that case. Author: Tristan Partin

Re: pgsql: Remove MSVC scripts

2023-12-20 Thread Andrew Dunstan
the commit removed our dummy version of Win32/Registry.pm. I have disabled the test for that file on branches later than 16, and koel and crake are back to green. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-12-01 Thread Andrew Dunstan
On 2023-12-01 Fr 09:04, Andrew Dunstan wrote: On 2023-11-29 We 07:20, Andrew Dunstan wrote: On 2023-11-28 Tu 21:28, Andres Freund wrote: Hi, On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote: On 2023-11-20 Mo 20:53, Andres Freund wrote: meson: docs: Add {html,man} targets, rename

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-12-01 Thread Andrew Dunstan
On 2023-11-29 We 07:20, Andrew Dunstan wrote: On 2023-11-28 Tu 21:28, Andres Freund wrote: Hi, On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote: On 2023-11-20 Mo 20:53, Andres Freund wrote: meson: docs: Add {html,man} targets, rename install-doc-* We have toplevel html, man targets

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-29 Thread Andrew Dunstan
On 2023-11-29 We 08:49, Tom Lane wrote: Andrew Dunstan writes: On 2023-11-28 Tu 21:28, Andres Freund wrote: I don't really understand why meson compile complains in this case. I assume you don't want to disambiguate as suggested, by building html:alias instead? I've done

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-29 Thread Andrew Dunstan
On 2023-11-28 Tu 21:28, Andres Freund wrote: Hi, On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote: On 2023-11-20 Mo 20:53, Andres Freund wrote: meson: docs: Add {html,man} targets, rename install-doc-* We have toplevel html, man targets in the autoconf build as well. It'd be odd to have

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-27 Thread Andrew Dunstan
On 2023-11-23 Th 08:32, Andrew Dunstan wrote: On 2023-11-20 Mo 20:53, Andres Freund wrote: meson: docs: Add {html,man} targets, rename install-doc-* We have toplevel html, man targets in the autoconf build as well. It'd be odd to have an 'html' target but have the install target be 'install

Re: pgsql: Doc: un-break PDF build.

2023-11-25 Thread Andrew Dunstan
are you invoking to build the docs? The default docs make target doesn't build the PDFs - you have to build those explicitly. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-23 Thread Andrew Dunstan
ake=2023-11-23%2012%3A52%3A04> cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: pgsql: Migrate logical slots to the new node during an upgrade.

2023-11-06 Thread Andrew Dunstan
be started in the source directory, but we want # to run pg_upgrade in the build directory so that any files generated finish # in it, like delete_old_cluster.{sh,bat}. chdir ${PostgreSQL::Test::Utils::tmp_check}; cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

pgsql: Only evaluate default values as required when doing COPY FROM

2023-10-01 Thread Andrew Dunstan
Only evaluate default values as required when doing COPY FROM Commit 9f8377f7a2 was a little too eager in fetching default values. Normally this would not matter, but if the default value is not valid for the type (e.g. a varchar that's too long) it caused an unnecessary error. Complaint and fix

pgsql: Only evaluate default values as required when doing COPY FROM

2023-10-01 Thread Andrew Dunstan
Only evaluate default values as required when doing COPY FROM Commit 9f8377f7a2 was a little too eager in fetching default values. Normally this would not matter, but if the default value is not valid for the type (e.g. a varchar that's too long) it caused an unnecessary error. Complaint and fix

pgsql: Provide FORCE_NULL * and FORCE_NOT_NULL * options for COPY FROM

2023-09-30 Thread Andrew Dunstan
Provide FORCE_NULL * and FORCE_NOT_NULL * options for COPY FROM These options already exist, but you need to specify a column list for them, which can be cumbersome. We already have the possibility of all columns for FORCE QUOTE, so this is simply extending that facility to FORCE_NULL and

Re: pgsql: Cache by-reference missing values in a long lived context

2023-08-27 Thread Andrew Dunstan
withdrawn then. OK, thanks, done. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

pgsql: Silence compiler warning in release 11 and 12 branches

2023-08-27 Thread Andrew Dunstan
Silence compiler warning in release 11 and 12 branches The offending code is not present in later branches. Discussion: https://postgr.es/m/ba2150c1-8485-6597-fafe-4fcd39e49...@dunslane.net Branch -- REL_12_STABLE Details ---

pgsql: Silence compiler warning in release 11 and 12 branches

2023-08-27 Thread Andrew Dunstan
Silence compiler warning in release 11 and 12 branches The offending code is not present in later branches. Discussion: https://postgr.es/m/ba2150c1-8485-6597-fafe-4fcd39e49...@dunslane.net Branch -- REL_11_STABLE Details ---

Re: pgsql: Cache by-reference missing values in a long lived context

2023-08-25 Thread Andrew Dunstan
On 2023-08-24 Th 16:57, Tom Lane wrote: Andrew Dunstan writes: On 2023-08-24 Th 11:27, Tom Lane wrote: The v11 version of this patch is causing a compiler warning for me: Sorry about that, fixed. Thanks! While we're about it, let's also fix these warnings which are seen on my systems

Re: pgsql: Cache by-reference missing values in a long lived context

2023-08-24 Thread Andrew Dunstan
On 2023-08-24 Th 11:27, Tom Lane wrote: Andrew Dunstan writes: Cache by-reference missing values in a long lived context The v11 version of this patch is causing a compiler warning for me: In file included from heaptuple.c:58: heaptuple.c: In function 'missing_hash': heaptuple.c:97:3

pgsql: Include header file inadvertently missed in commit 2d13dab048

2023-08-24 Thread Andrew Dunstan
Include header file inadvertently missed in commit 2d13dab048 per gripe from Tom Lane. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b915bf495ff48c4f57a22a90dfddc38be7a9845e Modified Files -- src/backend/access/common/heaptuple.c | 1 + 1 file

pgsql: Cache by-reference missing values in a long lived context

2023-08-23 Thread Andrew Dunstan
of the datum in the TopMemoryContext. Since we first search for the value this only needs to be done once per session for any such value. Original complaint from Tom Lane, idea for mitigation by Andrew Dunstan, tweaked by Tom Lane. Backpatch to version 11 where missing values were introduced

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
of the datum in the TopMemoryContext. Since we first search for the value this only needs to be done once per session for any such value. Original complaint from Tom Lane, idea for mitigation by Andrew Dunstan, tweaked by Tom Lane. Backpatch to version 11 where missing values were introduced

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
of the datum in the TopMemoryContext. Since we first search for the value this only needs to be done once per session for any such value. Original complaint from Tom Lane, idea for mitigation by Andrew Dunstan, tweaked by Tom Lane. Backpatch to version 11 where missing values were introduced

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
of the datum in the TopMemoryContext. Since we first search for the value this only needs to be done once per session for any such value. Original complaint from Tom Lane, idea for mitigation by Andrew Dunstan, tweaked by Tom Lane. Backpatch to version 11 where missing values were introduced

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
of the datum in the TopMemoryContext. Since we first search for the value this only needs to be done once per session for any such value. Original complaint from Tom Lane, idea for mitigation by Andrew Dunstan, tweaked by Tom Lane. Backpatch to version 11 where missing values were introduced

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
of the datum in the TopMemoryContext. Since we first search for the value this only needs to be done once per session for any such value. Original complaint from Tom Lane, idea for mitigation by Andrew Dunstan, tweaked by Tom Lane. Backpatch to version 11 where missing values were introduced

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
of the datum in the TopMemoryContext. Since we first search for the value this only needs to be done once per session for any such value. Original complaint from Tom Lane, idea for mitigation by Andrew Dunstan, tweaked by Tom Lane. Backpatch to version 11 where missing values were introduced

pgsql: Fix tmpdir issues with commit e213de8e78

2023-07-08 Thread Andrew Dunstan
Fix tmpdir issues with commit e213de8e78 Commit e213de8e78 fixed a problem with path lengths to a tempdir on Windows, but caused problems on at least some Unix systems where the system tempdir is on a different file system. To work around this, only used the system temdir for the destination of

pgsql: Fix tmpdir issues with commit e213de8e78

2023-07-08 Thread Andrew Dunstan
Fix tmpdir issues with commit e213de8e78 Commit e213de8e78 fixed a problem with path lengths to a tempdir on Windows, but caused problems on at least some Unix systems where the system tempdir is on a different file system. To work around this, only used the system temdir for the destination of

pgsql: Fix tmpdir issues with commit e213de8e78

2023-07-08 Thread Andrew Dunstan
Fix tmpdir issues with commit e213de8e78 Commit e213de8e78 fixed a problem with path lengths to a tempdir on Windows, but caused problems on at least some Unix systems where the system tempdir is on a different file system. To work around this, only used the system temdir for the destination of

pgsql: Fix tmpdir issues with commit e213de8e78

2023-07-08 Thread Andrew Dunstan
Fix tmpdir issues with commit e213de8e78 Commit e213de8e78 fixed a problem with path lengths to a tempdir on Windows, but caused problems on at least some Unix systems where the system tempdir is on a different file system. To work around this, only used the system temdir for the destination of

pgsql: Use shorter location for pg_replslot in pg_basebackup test

2023-07-08 Thread Andrew Dunstan
Use shorter location for pg_replslot in pg_basebackup test The symlink to a longer location tripped up some Windows limit on buildfarm animal fairywren when running with meson, which uses slightly longer paths. Backpatch to release 14 to keep the script in sync. Before that the script skipped

pgsql: Use shorter location for pg_replslot in pg_basebackup test

2023-07-08 Thread Andrew Dunstan
Use shorter location for pg_replslot in pg_basebackup test The symlink to a longer location tripped up some Windows limit on buildfarm animal fairywren when running with meson, which uses slightly longer paths. Backpatch to all live branches to keep the script in sync. Branch --

pgsql: Use shorter location for pg_replslot in pg_basebackup test

2023-07-08 Thread Andrew Dunstan
Use shorter location for pg_replslot in pg_basebackup test The symlink to a longer location tripped up some Windows limit on buildfarm animal fairywren when running with meson, which uses slightly longer paths. Backpatch to release 14 to keep the script in sync. Before that the script skipped

pgsql: Use shorter location for pg_replslot in pg_basebackup test

2023-07-08 Thread Andrew Dunstan
Use shorter location for pg_replslot in pg_basebackup test The symlink to a longer location tripped up some Windows limit on buildfarm animal fairywren when running with meson, which uses slightly longer paths. Backpatch to release 14 to keep the script in sync. Before that the script skipped

pgsql: Skip pg_baseback long filename test if path too long on Windows

2023-07-06 Thread Andrew Dunstan
Skip pg_baseback long filename test if path too long on Windows On Windows, it's sometimes difficult to create a file with a path longer than 255 chars, and if it can be created it might not be seen by the archiver. This can be triggered by the test for tar backups with filenames greater than 100

pgsql: Skip pg_baseback long filename test if path too long on Windows

2023-07-06 Thread Andrew Dunstan
Skip pg_baseback long filename test if path too long on Windows On Windows, it's sometimes difficult to create a file with a path longer than 255 chars, and if it can be created it might not be seen by the archiver. This can be triggered by the test for tar backups with filenames greater than 100

pgsql: Skip pg_baseback long filename test if path too long on Windows

2023-07-06 Thread Andrew Dunstan
Skip pg_baseback long filename test if path too long on Windows On Windows, it's sometimes difficult to create a file with a path longer than 255 chars, and if it can be created it might not be seen by the archiver. This can be triggered by the test for tar backups with filenames greater than 100

pgsql: Skip pg_baseback long filename test if path too long on Windows

2023-07-06 Thread Andrew Dunstan
Skip pg_baseback long filename test if path too long on Windows On Windows, it's sometimes difficult to create a file with a path longer than 255 chars, and if it can be created it might not be seen by the archiver. This can be triggered by the test for tar backups with filenames greater than 100

pgsql: Skip pg_baseback long filename test if path too long on Windows

2023-07-06 Thread Andrew Dunstan
Skip pg_baseback long filename test if path too long on Windows On Windows, it's sometimes difficult to create a file with a path longer than 255 chars, and if it can be created it might not be seen by the archiver. This can be triggered by the test for tar backups with filenames greater than 100

pgsql: Skip pg_baseback long filename test if path too long on Windows

2023-07-06 Thread Andrew Dunstan
Skip pg_baseback long filename test if path too long on Windows On Windows, it's sometimes difficult to create a file with a path longer than 255 chars, and if it can be created it might not be seen by the archiver. This can be triggered by the test for tar backups with filenames greater than 100

pgsql: Skip pg_baseback long filename test if path too long on Windows

2023-07-06 Thread Andrew Dunstan
Skip pg_baseback long filename test if path too long on Windows On Windows, it's sometimes difficult to create a file with a path longer than 255 chars, and if it can be created it might not be seen by the archiver. This can be triggered by the test for tar backups with filenames greater than 100

Re: pgsql: Improve pg_basebackup long file name test Windows robustness

2023-07-03 Thread Andrew Dunstan
On 2023-07-03 Mo 10:51, Andrew Dunstan wrote: On 2023-07-03 Mo 10:19, Daniel Gustafsson wrote: On 3 Jul 2023, at 16:08, Andrew Dunstan wrote: Improve pg_basebackup long file name test Windows robustness Creation of a file with a very long name can create problems on Windows due to its

pgsql: Revert "Improve pg_basebackup long file name test Windows robust

2023-07-03 Thread Andrew Dunstan
Revert "Improve pg_basebackup long file name test Windows robustness" Version 13 and older are missing the required infrastructure. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/753f20c179f7be94a335e9dc67a5d58c6036d119 Modified Files --

pgsql: Revert "Improve pg_basebackup long file name test Windows robust

2023-07-03 Thread Andrew Dunstan
Revert "Improve pg_basebackup long file name test Windows robustness" Version 12 and older are missing the required infrastructure. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4463a78460eed9d16a2f554a19de574a2fdda0af Modified Files --

pgsql: Revert "Improve pg_basebackup long file name test Windows robust

2023-07-03 Thread Andrew Dunstan
Revert "Improve pg_basebackup long file name test Windows robustness" Version 12 and older are missing the required infrastructure. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bec0dcb62963403490abdb89983f3472377c828e Modified Files --

Re: pgsql: Improve pg_basebackup long file name test Windows robustness

2023-07-03 Thread Andrew Dunstan
On 2023-07-03 Mo 10:19, Daniel Gustafsson wrote: On 3 Jul 2023, at 16:08, Andrew Dunstan wrote: Improve pg_basebackup long file name test Windows robustness Creation of a file with a very long name can create problems on Windows due to its file path limits. Work around that by creating

pgsql: Use older package name in pg_basebackup test

2023-07-03 Thread Andrew Dunstan
Use older package name in pg_basebackup test Commit 83ed4de20f inadvertently used the new package names. In version 14 or older, use TestLib intead of using PostgreSQL::Test::Utils Branch -- REL_13_STABLE Details ---

pgsql: Use older package name in pg_basebackup test

2023-07-03 Thread Andrew Dunstan
Use older package name in pg_basebackup test Commit 83ed4de20f inadvertently used the new package names. In version 14 or older, use TestLib intead of using PostgreSQL::Test::Utils Branch -- REL_14_STABLE Details ---

pgsql: Use older package name in pg_basebackup test

2023-07-03 Thread Andrew Dunstan
Use older package name in pg_basebackup test Commit 83ed4de20f inadvertently used the new package names. In version 14 or older, use TestLib intead of using PostgreSQL::Test::Utils Branch -- REL_11_STABLE Details ---

pgsql: Use older package name in pg_basebackup test

2023-07-03 Thread Andrew Dunstan
Use older package name in pg_basebackup test Commit 83ed4de20f inadvertently used the new package names. In version 14 or older, use TestLib intead of using PostgreSQL::Test::Utils Branch -- REL_12_STABLE Details ---

pgsql: Improve pg_basebackup long file name test Windows robustness

2023-07-03 Thread Andrew Dunstan
Improve pg_basebackup long file name test Windows robustness Creation of a file with a very long name can create problems on Windows due to its file path limits. Work around that by creating the file via a symlink with a shorter name. Error displayed by buildfarm animal fairywren.o Backpatch to

pgsql: Improve pg_basebackup long file name test Windows robustness

2023-07-03 Thread Andrew Dunstan
Improve pg_basebackup long file name test Windows robustness Creation of a file with a very long name can create problems on Windows due to its file path limits. Work around that by creating the file via a symlink with a shorter name. Error displayed by buildfarm animal fairywren.o Backpatch to

pgsql: Improve pg_basebackup long file name test Windows robustness

2023-07-03 Thread Andrew Dunstan
Improve pg_basebackup long file name test Windows robustness Creation of a file with a very long name can create problems on Windows due to its file path limits. Work around that by creating the file via a symlink with a shorter name. Error displayed by buildfarm animal fairywren.o Backpatch to

pgsql: Improve pg_basebackup long file name test Windows robustness

2023-07-03 Thread Andrew Dunstan
Improve pg_basebackup long file name test Windows robustness Creation of a file with a very long name can create problems on Windows due to its file path limits. Work around that by creating the file via a symlink with a shorter name. Error displayed by buildfarm animal fairywren.o Backpatch to

pgsql: Improve pg_basebackup long file name test Windows robustness

2023-07-03 Thread Andrew Dunstan
Improve pg_basebackup long file name test Windows robustness Creation of a file with a very long name can create problems on Windows due to its file path limits. Work around that by creating the file via a symlink with a shorter name. Error displayed by buildfarm animal fairywren.o Backpatch to

  1   2   3   4   5   6   7   8   9   >