Thank you, both patches are pushed.
Alexander Korotkov wrote:
On Wed, Apr 18, 2018 at 9:21 PM, Peter Geoghegan > wrote:
On Wed, Apr 18, 2018 at 11:12 AM, Fujii Masao > wrote:
> On Thu, Apr 5,
On Thu, Apr 19, 2018 at 9:19 AM, Teodor Sigaev wrote:
> Another thing that I noticed is that the metapage stores
>> btm_last_cleanup_num_heap_tuples as a float4, even though
>> xl_btree_metadata stores it as a double. I suggest that both places
>> store it as
Another thing that I noticed is that the metapage stores
btm_last_cleanup_num_heap_tuples as a float4, even though
xl_btree_metadata stores it as a double. I suggest that both places
store it as float8, to be consistent. (It should not be double because
we always avoid using
On Wed, Apr 18, 2018 at 9:21 PM, Peter Geoghegan wrote:
> On Wed, Apr 18, 2018 at 11:12 AM, Fujii Masao
> wrote:
> > On Thu, Apr 5, 2018 at 1:29 AM, Teodor Sigaev wrote:
> >> Skip full index scan during cleanup of B-tree indexes when
On Thu, Apr 5, 2018 at 1:29 AM, Teodor Sigaev wrote:
> Skip full index scan during cleanup of B-tree indexes when possible
This commit added XLOG_BTREE_META_CLEANUP, so btree_desc() and
btree_identify() should be updated so that they handle XLOG_BTREE_META_CLEANUP.
But ISTM
On Thu, Apr 5, 2018 at 3:24 PM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> On Thu, Apr 5, 2018 at 2:26 PM, Alexander Korotkov <
> a.korot...@postgrespro.ru> wrote:
>
>> On Thu, Apr 5, 2018 at 6:28 AM, Tom Lane wrote:
>>
>>> Peter Geoghegan writes:
On Thu, Apr 5, 2018 at 2:26 PM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> On Thu, Apr 5, 2018 at 6:28 AM, Tom Lane wrote:
>
>> Peter Geoghegan writes:
>> >>> TRAP: FailedAssertion("!(metad->btm_version == 3)", File:
>> >>>
On Thu, Apr 5, 2018 at 6:28 AM, Tom Lane wrote:
> Peter Geoghegan writes:
> >>> TRAP: FailedAssertion("!(metad->btm_version == 3)", File:
> >>> "/home/pg/postgresql/root/build/../source/src/backend/
> access/nbtree/nbtpage.c",
> >>> Line: 619)
>
> >> Hm,
On Thu, Apr 5, 2018 at 1:32 AM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> On Wed, Apr 4, 2018 at 7:29 PM, Teodor Sigaev wrote:
>
>> Skip full index scan during cleanup of B-tree indexes when possible
>>
>
> Thank you for committing this.
>
> It appears that patch
On Wed, Apr 4, 2018 at 8:28 PM, Tom Lane wrote:
>> This was discovered while testing/reviewing the latest version of the
>> INCLUDE covering indexes patch. It now seems to be unrelated.
>
> Oh, wait ... I wonder if you saw that because you were running a new
> backend without
Peter Geoghegan writes:
>>> TRAP: FailedAssertion("!(metad->btm_version == 3)", File:
>>> "/home/pg/postgresql/root/build/../source/src/backend/access/nbtree/nbtpage.c",
>>> Line: 619)
>> Hm, buildfarm's not complaining --- what's the test case?
> This was discovered while
On Wed, Apr 4, 2018 at 5:58 PM, Tom Lane wrote:
>> TRAP: FailedAssertion("!(metad->btm_version == 3)", File:
>> "/home/pg/postgresql/root/build/../source/src/backend/access/nbtree/nbtpage.c",
>> Line: 619)
>
> Hm, buildfarm's not complaining --- what's the test case?
This was
On Wed, Apr 04, 2018 at 08:58:14PM -0400, Tom Lane wrote:
> Peter Geoghegan writes:
> > I also see an assertion failure within _bt_getrootheight():
>
> > TRAP: FailedAssertion("!(metad->btm_version == 3)", File:
> >
Peter Geoghegan writes:
> I also see an assertion failure within _bt_getrootheight():
> TRAP: FailedAssertion("!(metad->btm_version == 3)", File:
> "/home/pg/postgresql/root/build/../source/src/backend/access/nbtree/nbtpage.c",
> Line: 619)
Hm, buildfarm's not complaining ---
On Wed, Apr 4, 2018 at 3:32 PM, Alexander Korotkov
wrote:
> Hi!
>
> On Wed, Apr 4, 2018 at 7:29 PM, Teodor Sigaev wrote:
>>
>> Skip full index scan during cleanup of B-tree indexes when possible
>
>
> Thank you for committing this.
>
> It appears that
15 matches
Mail list logo