Re: [COMMITTERS] pgsql: Add a test framework for recovery

2016-02-26 Thread Thom Brown
On 26 February 2016 at 19:26, Thom Brown <t...@linux.com> wrote: > On 26 February 2016 at 19:15, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: >> Add a test framework for recovery >> >> This long-awaited framework is an expansion of the existing PostgresNo

Re: [COMMITTERS] pgsql: Add a test framework for recovery

2016-02-26 Thread Thom Brown
On 26 February 2016 at 19:15, Alvaro Herrera wrote: > Add a test framework for recovery > > This long-awaited framework is an expansion of the existing PostgresNode > stuff to support additional features for recovery testing; the recovery > tests included in this commit

Re: [COMMITTERS] pgsql: Perform an immediate shutdown if the postmaster.pid file is remo

2015-10-09 Thread Thom Brown
On 6 October 2015 at 22:16, Tom Lane wrote: > Perform an immediate shutdown if the postmaster.pid file is removed. > > The postmaster now checks every minute or so (worst case, at most two > minutes) that postmaster.pid is still there and still contains its own PID. > If not,

Re: [COMMITTERS] pgsql: Allow per-tablespace effective_io_concurrency

2015-09-08 Thread Thom Brown
On 8 September 2015 at 16:59, Alvaro Herrera wrote: > Allow per-tablespace effective_io_concurrency > > Per discussion, nowadays it is possible to have tablespaces that have > wildly different I/O characteristics from others. Setting different > effective_io_concurrency

Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension

2015-05-15 Thread Thom Brown
On 15 May 2015 at 10:56, Pavel Stehule pavel.steh...@gmail.com wrote: Hi I am testing it, and output is strange 2015-05-15 11:49:25.046 CEST pavel postgres: LOG: AUDIT: SESSION,1,1,DDL,DROP TABLE,,,drop table foo;,not logged 2015-05-15 11:49:25.046 CEST pavel postgres: STATEMENT: drop

Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension

2015-05-15 Thread Thom Brown
On 15 May 2015 at 11:20, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-05-15 12:14 GMT+02:00 Thom Brown t...@linux.com: On 15 May 2015 at 10:56, Pavel Stehule pavel.steh...@gmail.com wrote: Hi I am testing it, and output is strange 2015-05-15 11:49:25.046 CEST pavel postgres

Re: [COMMITTERS] pgsql: TABLESAMPLE system_time(limit)

2015-05-15 Thread Thom Brown
On 15 May 2015 at 20:20, Simon Riggs si...@2ndquadrant.com wrote: TABLESAMPLE system_time(limit) Contrib module implementing a tablesample method that allows you to limit the sample by a hard time limit. tsm-system-time.sgml (and tsm-system-rows.sgml in the previous commit) appear to be

Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension

2015-05-14 Thread Thom Brown
On 14 May 2015 at 17:45, Stephen Frost sfr...@snowman.net wrote: Thom, * Thom Brown (t...@linux.com) wrote: On 14 May 2015 at 15:36, Stephen Frost sfr...@snowman.net wrote: Add pg_audit, an auditing extension A quick glance shows a parameter called pg_audit.log_statement_once, which isn't

Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension

2015-05-14 Thread Thom Brown
On 14 May 2015 at 15:36, Stephen Frost sfr...@snowman.net wrote: Add pg_audit, an auditing extension This extension provides detailed logging classes, ability to control logging at a per-object level, and includes fully-qualified object names for logged statements (DML and DDL) in independent

Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.

2015-05-11 Thread Thom Brown
On 8 May 2015 at 04:43, Andres Freund and...@anarazel.de wrote: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. The newly added ON CONFLICT clause allows to specify an alternative to raising a unique or exclusion constraint violation error when inserting. ON CONFLICT refers to

Re: [COMMITTERS] pgsql: Allow empty target list in SELECT.

2015-03-25 Thread Thom Brown
On 25 March 2015 at 01:04, Bruce Momjian br...@momjian.us wrote: On Fri, Mar 20, 2015 at 08:25:50AM -0400, Bruce Momjian wrote: regression=# create table foo(); CREATE TABLE regression=# insert into foo default values; INSERT 0 1 regression=# insert into foo default values;

Re: [COMMITTERS] pgsql: Rework 'MOVE ALL' to 'ALTER .. ALL IN TABLESPACE'

2014-11-11 Thread Thom Brown
On 22 August 2014 00:13, Stephen Frost sfr...@snowman.net wrote: Rework 'MOVE ALL' to 'ALTER .. ALL IN TABLESPACE' As 'ALTER TABLESPACE .. MOVE ALL' really didn't change the tablespace but instead changed objects inside tablespaces, it made sense to rework the syntax and supporting functions

Re: [COMMITTERS] pgsql: BRIN: Block Range Indexes

2014-11-08 Thread Thom Brown
On 7 November 2014 19:43, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: BRIN: Block Range Indexes ... doc/src/sgml/brin.sgml| 490 ++ Here's a typo correction: The core productnamePostgreSQL/productname distribution includes - includes the

Re: [COMMITTERS] pgsql: Allow empty target list in SELECT.

2014-10-22 Thread Thom Brown
On 22 October 2014 21:57, Tom Lane t...@sss.pgh.pa.us wrote: Thom Brown t...@linux.com writes: On 15 December 2013 02:23, Tom Lane t...@sss.pgh.pa.us wrote: Allow empty target list in SELECT. This commit introduces another bug: # create table colours (id serial, name text, visible

Re: [COMMITTERS] pgsql: Allow empty target list in SELECT.

2014-10-22 Thread Thom Brown
On 22 October 2014 22:06, Thom Brown t...@linux.com wrote: On 22 October 2014 21:57, Tom Lane t...@sss.pgh.pa.us wrote: Thom Brown t...@linux.com writes: On 15 December 2013 02:23, Tom Lane t...@sss.pgh.pa.us wrote: Allow empty target list in SELECT. This commit introduces another bug

Re: [COMMITTERS] pgsql: Add cluster_name GUC which is included in process titles if set.

2014-06-30 Thread Thom Brown
On 29 June 2014 13:24, Andres Freund and...@anarazel.de wrote: Add cluster_name GUC which is included in process titles if set. When running several postgres clusters on one OS instance it's often inconveniently hard to identify which postgres process belongs to which postgres instance.

Re: [COMMITTERS] pgsql: Remove ipc_test.

2014-04-07 Thread Thom Brown
On 7 April 2014 15:42, Robert Haas rh...@postgresql.org wrote: Remove ipc_test. This doesn't seem to be useful any more, and it's not really worth the effort to keep updating it every time relevant dependencies or calling signatures in the shared memory or semaphore code change. Branch

Re: [COMMITTERS] pgsql: Remove ipc_test.

2014-04-07 Thread Thom Brown
On 7 April 2014 15:51, Robert Haas robertmh...@gmail.com wrote: On Mon, Apr 7, 2014 at 10:45 AM, Thom Brown t...@linux.com wrote: N! That was my favourite test! /me blinks. Is that a serious objection, or are you just being flip? I've never used it. -- Thom -- Sent via pgsql

Re: [COMMITTERS] pgsql: Introduce jsonb, a structured format for storing json.

2014-03-23 Thread Thom Brown
On 23 March 2014 21:17, Andrew Dunstan and...@dunslane.net wrote: Introduce jsonb, a structured format for storing json. The new format accepts exactly the same data as the json type. However, it is stored in a format that does not require reparsing the orgiginal text in order to process it,

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Thom Brown
On 18 March 2014 17:21, Robert Haas rh...@postgresql.org wrote: Documentation for logical decoding. Craig Ringer, Andres Freund, Christian Kruse, with edits by me. In doc/src/sgml/logicaldecoding.sgml: s/demonstartes/demonstrates/ s/ot at least 1/to at least 1/ In this example:

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Thom Brown
On 18 March 2014 18:16, Andres Freund and...@2ndquadrant.com wrote: On 2014-03-18 18:12:25 +, Thom Brown wrote: I'd have put this in a patch, but I don't know if the output in the example is wrong, or just dependent on environmental factors. It's out of date, it should be integer now, so

Re: [COMMITTERS] pgsql: Fix typos in comments.

2014-03-17 Thread Thom Brown
On 17 March 2014 12:44, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fujii Masao wrote: src/backend/access/heap/rewriteheap.c |6 +++--- This one wasn't strictly a typo: @@ -1046,7 +1046,7 @@ logical_rewrite_log_mapping(RewriteState state, TransactionId xid, /* * Perform

Re: [COMMITTERS] pgsql: Fix typos in comments.

2014-03-17 Thread Thom Brown
On 17 March 2014 17:00, Tom Lane t...@sss.pgh.pa.us wrote: Thom Brown t...@linux.com writes: On 17 March 2014 12:44, Alvaro Herrera alvhe...@2ndquadrant.com wrote: iff was discussed in pg-hackers a fortnight ago or so. In this particular case I don't think iff rather than if added too much

Re: [COMMITTERS] pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

2014-03-13 Thread Thom Brown
On 12 March 2014 15:52, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Allow opclasses to provide tri-valued GIN consistent functions. With the GIN fast scan feature, GIN can skip items without fetching all the keys for them, if it can prove that they don't match regardless of those

Re: [COMMITTERS] pgsql: Fix issues with pg_ctl

2014-03-05 Thread Thom Brown
On 5 March 2014 06:33, Stephen Frost sfr...@snowman.net wrote: Fix issues with pg_ctl The new, small, free_readfile managed to have bug in it which could cause it to try and free something it shouldn't, and fix the case where it was being called with an invalid pointer leading to a

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-03-05 Thread Thom Brown
On 25 February 2014 16:25, Robert Haas robertmh...@gmail.com wrote: Since Fujii Masao doesn't seem to be around, I'll commit this. But don't we need to update the documentation as well, for those using the file-copy method of taking a backup? Yes, that sounds like a sensible idea. --

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-28 Thread Thom Brown
On 1 February 2014 03:50, Robert Haas rh...@postgresql.org wrote: Introduce replication slots. Replication slots are a crash-safe data structure which can be created on either a master or a standby to prevent premature removal of write-ahead log segments needed by a standby, as well as (with

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-28 Thread Thom Brown
On 28 February 2014 19:22, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-28 19:05:40 +, Thom Brown wrote: On 1 February 2014 03:50, Robert Haas rh...@postgresql.org wrote: Introduce replication slots. Replication slots are a crash-safe data structure which can

Re: [COMMITTERS] pgsql: Allow time delayed standbys and recovery

2014-02-26 Thread Thom Brown
On 19 December 2013 19:33, Simon Riggs si...@2ndquadrant.com wrote: On 19 December 2013 19:19, Thom Brown t...@linux.com wrote: On 12 December 2013 10:56, Simon Riggs si...@2ndquadrant.com wrote: Allow time delayed standbys and recovery Set min_recovery_apply_delay to force a delay

Re: [COMMITTERS] pgsql: Allow time delayed standbys and recovery

2014-02-26 Thread Thom Brown
On 26 February 2014 13:32, Simon Riggs si...@2ndquadrant.com wrote: On 26 February 2014 13:07, Thom Brown t...@linux.com wrote: On 19 December 2013 19:33, Simon Riggs si...@2ndquadrant.com wrote: On 19 December 2013 19:19, Thom Brown t...@linux.com wrote: On 12 December 2013 10:56

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-25 Thread Thom Brown
On 6 February 2014 10:29, Andres Freund and...@2ndquadrant.com wrote: Hi Fujii, On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: This patch changed basebackup.c so that it skips pg_replslot. It's OK to skip all files in that directory, but an empty pg_replslot must be included in the

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-06 Thread Thom Brown
On 4 February 2014 05:19, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Feb 1, 2014 at 6:33 PM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: On Sat, Feb 1, 2014

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Thom Brown
On 1 February 2014 04:50, Robert Haas rh...@postgresql.org wrote: doc/src/sgml/high-availability.sgml| 94 +- s/configuration a replication slot/configuring a replication/ doc/src/sgml/ref/pg_receivexlog.sgml s/paramter/parameter/ src/backend/replication/slot.c

Re: [COMMITTERS] pgsql: New json functions.

2014-01-28 Thread Thom Brown
On 28 January 2014 22:55, Andrew Dunstan and...@dunslane.net wrote: New json functions. json_build_array() and json_build_object allow for the construction of arbitrarily complex json trees. json_object() turns a one or two dimensional array, or two separate arrays, into a json_object of

Re: [COMMITTERS] pgsql: Add recovery_target='immediate' option.

2014-01-25 Thread Thom Brown
On 25 January 2014 15:34, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Add recovery_target='immediate' option. This allows ending recovery as a consistent state has been reached. Without this, there was no easy way to e.g restore an online backup, without replaying any extra WAL after

Re: [COMMITTERS] pgsql: Allow time delayed standbys and recovery

2013-12-19 Thread Thom Brown
On 12 December 2013 10:56, Simon Riggs si...@2ndquadrant.com wrote: Allow time delayed standbys and recovery Set min_recovery_apply_delay to force a delay in recovery apply for commit and restore point WAL records. Other records are replayed immediately. Delay is measured between WAL record

Re: [COMMITTERS] pgsql: doc: Clarify under what circumstances pg_dump needs superuser ac

2013-11-11 Thread Thom Brown
On 8 November 2013 20:12, Robert Haas rh...@postgresql.org wrote: doc: Clarify under what circumstances pg_dump needs superuser access. Inspired by, but different from, a patch from Ivan Lezhnjov IV Branch -- master Details ---

Re: [COMMITTERS] pgsql: Minor spelling fixes

2013-06-01 Thread Thom Brown
On 1 June 2013 15:20, Stephen Frost sfr...@snowman.net wrote: Minor spelling fixes Fix a few spelling mistakes. Per bug report #8193 from Lajos Veres. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c9fc28a7f12e27d530e2657c9dc6080fbfbe8a14 Oh, if

Re: [COMMITTERS] pgsql: Push 9.3 release SGML file

2013-04-20 Thread Thom Brown
On 20 April 2013 21:32, Bruce Momjian br...@momjian.us wrote: Push 9.3 release SGML file Forgotten in previous commit. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/22f956f50cac33287daf76d79890057ba2fb3789 s/Darold Gilles/Gilles Darold/ -- Thom --

Re: [COMMITTERS] pgsql: sepgsql: Support for new post-ALTER access hook.

2013-03-27 Thread Thom Brown
On 27 March 2013 12:33, Robert Haas rh...@postgresql.org wrote: sepgsql: Support for new post-ALTER access hook. I notice that due to commit bc5334d8 I can't actually build the docs at the moment. But I think the language here definitely needs improving: On CREATE FUNCTION, install permission

Re: [COMMITTERS] pgsql: Allow external recovery_config_directory

2013-03-27 Thread Thom Brown
On 27 March 2013 11:47, Simon Riggs si...@2ndquadrant.com wrote: Allow external recovery_config_directory If required, recovery.conf can now be located outside of the data directory. Server needs read/write permissions on this directory. The docs don't build due to this commit. Please remove

Re: [COMMITTERS] pgsql: Add CREATE RECURSIVE VIEW syntax

2013-02-28 Thread Thom Brown
On 1 February 2013 03:33, Peter Eisentraut pete...@gmx.net wrote: Add CREATE RECURSIVE VIEW syntax This is specified in the SQL standard. The CREATE RECURSIVE VIEW specification is transformed into a normal CREATE VIEW statement with a WITH RECURSIVE clause. Recursive views aren't

Re: [COMMITTERS] pgsql: Fix pg_dumpall with database names containing =

2013-02-27 Thread Thom Brown
On 26 February 2013 16:29, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 26.02.2013 18:03, Thom Brown wrote: On 20 February 2013 15:14, Heikki Linnakangasheikki.linnakan...@iki.fi wrote: Fix pg_dumpall with database names containing = If a database name contained a '=' character

Re: [COMMITTERS] pgsql: Add support for piping COPY to/from an external program.

2013-02-27 Thread Thom Brown
On 27 February 2013 16:22, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Add support for piping COPY to/from an external program. This includes backend COPY TO/FROM PROGRAM '...' syntax, and corresponding psql \copy syntax. Like with reading/writing files, the backend version is

Re: [COMMITTERS] pgsql: Add support for piping COPY to/from an external program.

2013-02-27 Thread Thom Brown
On 27 February 2013 19:12, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 27.02.2013 18:35, Thom Brown wrote: On 27 February 2013 16:22, Heikki Linnakangasheikki.linnakan...@iki.fi wrote: Add support for piping COPY to/from an external program. This includes backend COPY TO/FROM

Re: [COMMITTERS] pgsql: Fix pg_dumpall with database names containing =

2013-02-26 Thread Thom Brown
On 20 February 2013 15:14, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Fix pg_dumpall with database names containing = If a database name contained a '=' character, pg_dumpall failed. The problem was in the way pg_dumpall passes the database name to pg_dump on the command line. If it

Re: [COMMITTERS] pgsql: Add pg_xlogdump contrib program

2013-02-22 Thread Thom Brown
On 22 February 2013 19:58, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Add pg_xlogdump contrib program This program relies on rm_desc backend routines and the xlogreader infrastructure to emit human-readable rendering of WAL records. Author: Andres Freund, with many reworks by Álvaro

Re: [COMMITTERS] pgsql: Add pg_xlogdump contrib program

2013-02-22 Thread Thom Brown
On 22 February 2013 20:09, Peter Geoghegan peter.geoghega...@gmail.com wrote: On 22 February 2013 19:58, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Add pg_xlogdump contrib program I feel slightly silly reporting this, but you probably should have updated the copyright years to 2013 before

Re: [COMMITTERS] pgsql: Fix typo in comment

2013-02-08 Thread Thom Brown
On 8 February 2013 10:46, Magnus Hagander mag...@hagander.net wrote: Fix typo in comment Etsuro Fujita Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/733701d2748b6bbbe5f3cdc6421fdc83f6aa0c01 Modified Files -- src/backend/storage/file/fd.c |

Re: [COMMITTERS] pgsql: Minor enhancements to MVCC chapter

2013-01-23 Thread Thom Brown
On 26 December 2011 22:11, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Minor enhancements to MVCC chapter Author: Erik Rijkers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7db101c36ef7c998cfcf3f4a324c58c23f88927c Modified Files --

Re: [COMMITTERS] pgsql: Add ddl_command_end support for event triggers.

2013-01-21 Thread Thom Brown
On 21 January 2013 23:01, Robert Haas rh...@postgresql.org wrote: Add ddl_command_end support for event triggers. Dimitri Fontaine, with slight changes by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/841a5150c575ccd89e4b03aec66fb21f3cbe

Re: [COMMITTERS] pgsql: Add hash index caution to CREATE INDEX docs

2012-10-17 Thread Thom Brown
On 17 October 2012 08:37, Simon Riggs si...@2ndquadrant.com wrote: Add hash index caution to CREATE INDEX docs Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6166c7301ed9286c1e2af2f83a39e8b8225338bf Modified Files --

Re: [COMMITTERS] pgsql: Add hash index caution to CREATE INDEX docs

2012-10-17 Thread Thom Brown
On 17 October 2012 09:02, Thom Brown t...@linux.com wrote: On 17 October 2012 08:37, Simon Riggs si...@2ndquadrant.com wrote: Add hash index caution to CREATE INDEX docs Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff

Re: [COMMITTERS] pgsql: Use the regular main processing loop also in walsenders.

2012-10-08 Thread Thom Brown
On 8 October 2012 11:34, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 07.10.2012 12:24, Thom Brown wrote: On 6 October 2012 22:52, Thom Brownt...@linux.com wrote: On 5 October 2012 15:26, Heikki Linnakangasheikki.linnakan...@iki.fi wrote: Use the regular main processing loop also

Re: [COMMITTERS] pgsql: Use the regular main processing loop also in walsenders.

2012-10-07 Thread Thom Brown
On 6 October 2012 22:52, Thom Brown t...@linux.com wrote: On 5 October 2012 15:26, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Use the regular main processing loop also in walsenders. The regular backend's main loop handles signal handling and error recovery better than the current

Re: [COMMITTERS] pgsql: Use the regular main processing loop also in walsenders.

2012-10-06 Thread Thom Brown
On 5 October 2012 15:26, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Use the regular main processing loop also in walsenders. The regular backend's main loop handles signal handling and error recovery better than the current WAL sender command loop does. For example, if the client

Re: [COMMITTERS] pgsql: Warn more vigorously about the non-transactional behavior of seq

2012-08-06 Thread Thom Brown
On 6 August 2012 19:27, Robert Haas rh...@postgresql.org wrote: Warn more vigorously about the non-transactional behavior of sequences. Craig Ringer, edited fairly heavily by me Branch -- master Details ---

Re: [COMMITTERS] pgsql: Fix psql doc typo.

2012-05-05 Thread Thom Brown
On 5 May 2012 17:00, Bruce Momjian br...@momjian.us wrote: Fix psql doc typo. Are you sure about this? Looked fine before. -- Thom -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription:

Re: [COMMITTERS] pgsql: More duplicate word removal.

2012-05-02 Thread Thom Brown
On 2 May 2012 14:28, Robert Haas rh...@postgresql.org wrote: More duplicate word removal. While you're there... (attached) There's also this in src/bin/initdb/po/it.po: msgstr creazione del database template1 in in %s/base/1 ... in looks like an unnecessary duplicate, but maybe someone who

Re: [COMMITTERS] pgsql: Recast ONLY column CHECK constraints as NO INHERIT

2012-04-21 Thread Thom Brown
On 21 April 2012 03:57, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Recast ONLY column CHECK constraints as NO INHERIT The original syntax wasn't universally loved, and it didn't allow its usage in CREATE TABLE, only ALTER TABLE.  It now works everywhere, and it also allows using ALTER

Re: [COMMITTERS] pgsql: Update struct Trigger in docs

2012-03-20 Thread Thom Brown
On 20 March 2012 19:39, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Update struct Trigger in docs Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/11d7d11e53bfe02091cfafec5f716776acdaeeca While you're at it, can you apply the following patch to

Re: [COMMITTERS] pgsql: Update struct Trigger in docs

2012-03-20 Thread Thom Brown
On 20 March 2012 20:13, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Thom Brown's message of mar mar 20 16:55:04 -0300 2012: On 20 March 2012 19:39, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Update struct Trigger in docs Branch -- REL8_3_STABLE Details

Re: [COMMITTERS] pgsql: Make each pg_stat_ view into it's own table in the documentation

2012-02-27 Thread Thom Brown
On 25 February 2012 15:20, Thom Brown t...@linux.com wrote: On 25 February 2012 14:33, Magnus Hagander mag...@hagander.net wrote: Make each pg_stat_ view into it's own table in the documentation This makes it easier to match a column name with the description of it, and makes it possible

Re: [COMMITTERS] pgsql: Make each pg_stat_ view into it's own table in the documentation

2012-02-25 Thread Thom Brown
On 25 February 2012 14:33, Magnus Hagander mag...@hagander.net wrote: Make each pg_stat_ view into it's own table in the documentation This makes it easier to match a column name with the description of it, and makes it possible to add more detailed documentation in the future. This patch

Re: [COMMITTERS] pgsql: Merge the list of statistics functions into the view documentati

2012-02-25 Thread Thom Brown
On 25 February 2012 14:33, Magnus Hagander mag...@hagander.net wrote: Merge the list of statistics functions into the view documentation Most people won't read them individually anyway, it's an easy way to find them, and it's a lot of duplicated information if they are kept in two different

Re: [COMMITTERS] pgsql: Add some enumeration commas, for consistency

2012-02-24 Thread Thom Brown
On 24 February 2012 09:05, Peter Eisentraut pete...@gmx.net wrote: Add some enumeration commas, for consistency Are you sure about this? Generally a serial comma isn't used before and unless splitting a list into larger sub-groups. e.g. The sun and the moon, flora and fauna, and flotsam and

Re: [COMMITTERS] pgsql: Add some enumeration commas, for consistency

2012-02-24 Thread Thom Brown
On 24 February 2012 09:28, Peter Eisentraut pete...@gmx.net wrote: On fre, 2012-02-24 at 09:16 +, Thom Brown wrote: On 24 February 2012 09:05, Peter Eisentraut pete...@gmx.net wrote: Add some enumeration commas, for consistency Are you sure about this?  Generally a serial comma isn't

Re: [COMMITTERS] pgsql: Document random page cost is only 4x seqeuntial, and not 40x.

2012-02-14 Thread Thom Brown
On 14 February 2012 22:46, Bruce Momjian br...@momjian.us wrote: On Tue, Feb 14, 2012 at 10:44:08PM +, Thom Brown wrote: On 14 February 2012 21:55, Bruce Momjian br...@momjian.us wrote: Document random page cost is only 4x seqeuntial, and not 40x. Branch -- master Details

Re: [COMMITTERS] pgsql: Add --section option to pg_dump and pg_restore.

2011-12-17 Thread Thom Brown
On 17 December 2011 02:32, Andrew Dunstan and...@dunslane.net wrote: On 12/16/2011 07:57 PM, Thom Brown wrote: On 17 December 2011 00:17, Andrew Dunstanand...@dunslane.net  wrote: Add --section option to pg_dump and pg_restore. Valid values are --pre-data, data and post-data. The option

Re: [COMMITTERS] pgsql: Add --section option to pg_dump and pg_restore.

2011-12-17 Thread Thom Brown
On 17 December 2011 18:11, Andrew Dunstan and...@dunslane.net wrote: On 12/17/2011 08:13 AM, Thom Brown wrote: On 17 December 2011 02:32, Andrew Dunstanand...@dunslane.net  wrote: On 12/16/2011 07:57 PM, Thom Brown wrote: On 17 December 2011 00:17, Andrew Dunstanand...@dunslane.net

Re: [COMMITTERS] pgsql: Add --section option to pg_dump and pg_restore.

2011-12-16 Thread Thom Brown
On 17 December 2011 00:17, Andrew Dunstan and...@dunslane.net wrote: Add --section option to pg_dump and pg_restore. Valid values are --pre-data, data and post-data. The option can be given more than once. --schema-only is equivalent to --section=pre-data --section=post-data. --data-only is

Re: [COMMITTERS] pgsql: Don't quote language name

2011-11-17 Thread Thom Brown
On 17 November 2011 21:30, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Don't quote language name It's been deprecated for ages according to Tom, and it breaks now given the previous patch anyway. This also applies to isn and pgcrypto. -- Thom Brown Twitter: @darkixion IRC (freenode

Re: [COMMITTERS] pgsql: Don't quote language name

2011-11-17 Thread Thom Brown
to Tom, and it breaks now given the previous patch anyway. This also applies to isn and pgcrypto. Yeah, I noticed right after pushing, thanks.  I pushed another patch. Cheers. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http

Re: [COMMITTERS] pgsql: Remove hstore's text = text operator.

2011-11-07 Thread Thom Brown
.sql */ -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http

Re: [COMMITTERS] pgsql: Make VACUUM avoid waiting for a cleanup lock, where possible.

2011-11-07 Thread Thom Brown
, as long as its not got data Should be: It's OK to skip vacuuming a page, as long as it's not got data -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql

Re: [COMMITTERS] pgsql: Consider index-only scans even when there is no matching qual or

2011-10-11 Thread Thom Brown
time=4920.709..4920.709 rows=1 loops=1) - Index Only Scan using idx_stuff_thing on stuff (cost=0.00..398205.06 rows=18300046 width=0) (actual time=0.330..3353.140 rows=1830 loops=1) Total runtime: 4920.846 ms (3 rows) -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered

Re: [COMMITTERS] pgsql: Consider index-only scans even when there is no matching qual or

2011-10-11 Thread Thom Brown
On 11 October 2011 21:45, Tom Lane t...@sss.pgh.pa.us wrote: Thom Brown t...@linux.com writes: So an index-only scan is 30 times slower in this particular test case. Don't see why you'd find that unexpected.  If you have to visit all the rows, a seqscan is usually going to be the best way

Re: [COMMITTERS] pgsql: Cascading replication feature for streaming log-based replicatio

2011-10-10 Thread Thom Brown
On 10 October 2011 15:18, Robert Haas robertmh...@gmail.com wrote: On Sat, Oct 8, 2011 at 8:59 AM, Thom Brown t...@linux.com wrote: s/and may also/and you may also/ This was already fixed in a later commit. In doc/src/sgml/high-availability.sgml: s/effected/affected/ I fixed this. Also

Re: [COMMITTERS] pgsql: Cascading replication feature for streaming log-based replicatio

2011-10-08 Thread Thom Brown
/all walsender/ -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your

Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.

2011-09-08 Thread Thom Brown
otherwise be needed to traverse all the way down the tree to the find right leaf page for tuple. Sorry Heikki... s/additionaly/additionally/ -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise

Re: [COMMITTERS] pgsql: In pg_upgrade, avoid dumping orphaned temporary tables. This ma

2011-08-17 Thread Thom Brown
messages? I can do that if others are doing it. I don't think I can put it in now. He didn't just report the bug. He sent patches to fix it, even if you didn't base yours off his, so here's yours truly agitating to get him credit :) Can this now be removed as a beta-blocker? -- Thom Brown

Re: [COMMITTERS] pgsql: In pg_upgrade, avoid dumping orphaned temporary tables. This ma

2011-08-17 Thread Thom Brown
On 17 August 2011 17:02, David Fetter da...@fetter.org wrote: On Wed, Aug 17, 2011 at 04:40:26PM +0100, Thom Brown wrote: On 17 August 2011 06:13, David Fetter da...@fetter.org wrote: On Tue, Aug 16, 2011 at 10:17:21PM -0400, Bruce Momjian wrote: David Fetter wrote: Any way

Re: [COMMITTERS] pgsql: Fix pg_restore's direct-to-database mode for standard_conforming

2011-07-28 Thread Thom Brown
branches. So presumably this doesn't need to be on the Open Items list as a beta blocker? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing

Re: [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed

2011-06-25 Thread Thom Brown
On 26 June 2011 00:02, pg...@postgresql.org wrote: Branch refs/heads/REL9_1_STABLE was removed. What just happened here?! -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [COMMITTERS] pgsql: In pg_upgrade, check there are no prepared transactions.

2011-06-14 Thread Thom Brown
On 14 June 2011 19:42, Bruce Momjian br...@momjian.us wrote: In pg_upgrade, check there are no prepared transactions. Out of curiosity, why would you check the new cluster for prepared transactions? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935

Re: [COMMITTERS] pgsql: Add a local replication sample entry

2011-05-24 Thread Thom Brown
On 24 May 2011 20:24, Magnus Hagander mag...@hagander.net wrote: Hmm. We intentionally did not include the local case, because there really aren't any usecases for it. It seems you disagree? ;) pg_basebackup? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user

Re: [COMMITTERS] pgsql: Support comments on FOREIGN DATA WRAPPER and SERVER objects.

2011-04-01 Thread Thom Brown
/foreign_data.out |    2 + src/test/regress/sql/foreign_data.sql      |    2 + 11 files changed, 124 insertions(+), 55 deletions(-) Should we also have support for comments on user mappings? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http

Re: [COMMITTERS] pgsql: Fix ancient typo in user-defined-aggregates documentation.

2011-03-23 Thread Thom Brown
value. Maybe this should say two or three-element given the example that immediately follows it. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql

Re: [COMMITTERS] pgsql: Improve user-defined-aggregates documentation.

2011-03-23 Thread Thom Brown
the examples to be exactly correct, I suppose we'd better explain.  Per comment from Thom Brown. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/03c77337209f0b2b3059d6ee9df2f94c6f66d910 Modified Files -- doc/src/sgml/xaggr.sgml |   16

Re: [COMMITTERS] pgsql: Reorder some 9.1 release item documentation entries, fix some aw

2011-03-20 Thread Thom Brown
-- doc/src/sgml/release-9.1.sgml |  113 +++- 1 files changed, 54 insertions(+), 59 deletions(-) One typo: The old snapshot isolation level is still accessible by the requesting REPEATABLE READ isolation level. s/the requesting/requesting the/ -- Thom Brown

Re: [COMMITTERS] pgsql: Fix various possible problems with synchronous replication.

2011-03-17 Thread Thom Brown
but might have not been replicated to the standby.))); errdetail(The transaction has committed locally, but may not have replicated to the standby.))); Could we have these saying precisely the same thing? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935

Re: [COMMITTERS] pgsql: Support multiple concurrent pg_basebackup backups.

2011-01-31 Thread Thom Brown
/xlog.h            |   11 +- 5 files changed, 295 insertions(+), 113 deletions(-) s/the the result/the result/ -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes

Re: [COMMITTERS] pgsql: sepgsql, an SE-Linux integration for PostgreSQL

2011-01-24 Thread Thom Brown
On 24 January 2011 03:52, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 23, 2011 at 9:39 PM, Thom Brown t...@linux.com wrote: There are quite a few sentences which I'm not sure how to correct as I don't know how they're supposed to read.  But I've put together a patch to correct some

Re: [COMMITTERS] pgsql: sepgsql, an SE-Linux integration for PostgreSQL

2011-01-24 Thread Thom Brown
On 24 January 2011 13:45, Robert Haas robertmh...@gmail.com wrote: On Mon, Jan 24, 2011 at 8:18 AM, Thom Brown t...@linux.com wrote: On 24 January 2011 03:52, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 23, 2011 at 9:39 PM, Thom Brown t...@linux.com wrote: There are quite a few

Re: [COMMITTERS] pgsql: sepgsql, an SE-Linux integration for PostgreSQL

2011-01-23 Thread Thom Brown
(-) There are quite a few sentences which I'm not sure how to correct as I don't know how they're supposed to read. But I've put together a patch to correct some of the typos and grammar. There's a lot I haven't yet gone through though. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion

Re: [COMMITTERS] pgsql: Wording improvements for pg_ctl manual page.

2010-12-22 Thread Thom Brown
. :) -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Add index entries for more functions

2010-11-28 Thread Thom Brown
, max, min, and sum in the tutorial area, because that was felt to be confusing. Thom Brown Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=4fc09ad00c3cc95003a5523d85999da1dd4f9d75 Modified Files -- doc/src/sgml/func.sgml

Re: [COMMITTERS] pgsql: Document the dummy_seclabel contrib module.

2010-11-18 Thread Thom Brown
: + The filenamedummy_seclabel/ provides only four hardcoded + labels: literalunclassified/, literalclassified/, + literalsecret/, literaltop secret/ and literaltrusted/. Shouldn't this be ...dummy_seclabel/ module provides...? And there are five hardcoded labels. -- Thom Brown Twitter: @darkixion IRC

Re: [COMMITTERS] pgsql: Fix low-risk potential denial of service against RADIUS login.

2010-10-15 Thread Thom Brown
, I'm assuming this makes it... timeoutval = ((endtime.tv_sec * 100) + endtime.tv_usec) - ((now.tv_sec * 100) + now.tv_usec); -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 -- Sent via pgsql-committers mailing list (pgsql-committers

Re: [COMMITTERS] pgsql: Put per-letter quicklinks at the top of the HTML bookindex page

2010-10-14 Thread Thom Brown
-- doc/src/sgml/stylesheet.dsl |   43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) Works well. Thanks Peter. This is something many have wanted for a while. :) -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion

  1   2   >