Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-11-09 Thread Peter Eisentraut
On 2019-11-07 18:10, Fujii Masao wrote: After reading this again and again, I think the best fix to get PG12 into "correct" shape is to just remove the offending sentence: +1 done -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, T

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-11-07 Thread David Steele
On 11/6/19 4:49 AM, Fujii Masao wrote: On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut wrote: On 2019-11-06 05:48, Fujii Masao wrote: Patch attached. As I argued upthread, IMO it's better to remove the latter description from the doc and the patch does that. Also the patch adds "mainly" into

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-11-07 Thread Fujii Masao
On Fri, Nov 8, 2019 at 12:23 AM Peter Eisentraut wrote: > > On 2019-11-06 10:49, Fujii Masao wrote: > > On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut > > wrote: > >> > >> On 2019-11-06 05:48, Fujii Masao wrote: > >>> Patch attached. As I argued upthread, IMO it's better to remove > >>> the latt

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-11-07 Thread Peter Eisentraut
On 2019-11-06 10:49, Fujii Masao wrote: On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut wrote: On 2019-11-06 05:48, Fujii Masao wrote: Patch attached. As I argued upthread, IMO it's better to remove the latter description from the doc and the patch does that. Also the patch adds "mainly" into

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-11-06 Thread Fujii Masao
On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut wrote: > > On 2019-11-06 05:48, Fujii Masao wrote: > > Patch attached. As I argued upthread, IMO it's better to remove > > the latter description from the doc and the patch does that. > > Also the patch adds "mainly" into the former description. > >

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-11-05 Thread Peter Eisentraut
On 2019-11-06 05:48, Fujii Masao wrote: Patch attached. As I argued upthread, IMO it's better to remove the latter description from the doc and the patch does that. Also the patch adds "mainly" into the former description. I think we should list explicitly what is applied and what is not. This

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-11-05 Thread Fujii Masao
On Tue, Nov 5, 2019 at 10:28 PM Alvaro Herrera wrote: > > On 2019-Oct-18, Fujii Masao wrote: > > > > Thanks for improving the documentation. > > > > > > + In this mode, the parameters from both this section and > > + linkend="runtime-config-wal-recovery-target"/> will be used. > > > Par

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-11-05 Thread Alvaro Herrera
On 2019-Oct-18, Fujii Masao wrote: > > Thanks for improving the documentation. > > > > + In this mode, the parameters from both this section and > + linkend="runtime-config-wal-recovery-target"/> will be used. > > Parameters > > + from will not be > > + used. > > > > The latter

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-10-18 Thread Fujii Masao
On Mon, Sep 30, 2019 at 10:14 PM Fujii Masao wrote: > > On Mon, Sep 30, 2019 at 6:10 AM Peter Eisentraut wrote: > > > > doc: Further clarify how recovery target parameters are applied > > > > Recovery target parameters are all applied even in standby mode. The > > previous documentation mostly w

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-09-30 Thread Fujii Masao
On Mon, Sep 30, 2019 at 6:10 AM Peter Eisentraut wrote: > > doc: Further clarify how recovery target parameters are applied > > Recovery target parameters are all applied even in standby mode. The > previous documentation mostly wished they were not but this was never > the case. Thanks for impr