On Thu, Jul 03, 2025 at 01:30:13AM +0900, Fujii Masao wrote:
> BTW, all current index entries point to the top of the pg_buffercache
> docs. Would it be better if each entry pointed directly to its relevant
> section using a zone attribute like this?
>
> -
> +
>pg_buffercache_summary
>
T
On Tue, Jun 24, 2025 at 09:36:20AM +0200, Magnus Hagander wrote:
> On Tue, Jun 24, 2025 at 9:20 AM Daniel Gustafsson wrote:
>> Downloading what newbiedoc still ships shows no trace of docbook
>> introdoctions,
>> so whatever we decided valuable back in the 8.1 days when this was added
>> seems
>>
On Tue, Jun 24, 2025 at 12:17:46PM +0800, jian he wrote:
> in https://www.postgresql.org/docs/current/docguide-docbook.html
> the link (https://newbiedoc.sourceforge.net/metadoc/docbook-guide.html)
> for (NewbieDoc Docbook Guide) is broken.
>
> google around I found this [2]
> [2]:
> https://ftp.
On Wed, Jun 18, 2025 at 04:55:56PM +0900, Fujii Masao wrote:
> Thanks for the review! I will commit the patch barring any other objections.
Thanks.
--
Michael
signature.asc
Description: PGP signature
On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote:
> Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
> In this feature, since indexes are not created for foreign tables,
> comments on indexes are not copied either.
Good point. This doc fix sounds fine to me.
--
Michae
On Sat, May 17, 2025 at 08:44:09AM -0400, Michael Paquier wrote:
> Right, following the rules defined internally by ChooseRelationName()
> when creating the new/old indexes in the process. So this could be
> added. Would you like to suggest a rewording of this sentence for the
>
On Thu, May 15, 2025 at 06:12:54PM +, PG Doc comments form wrote:
> The following paragraph:
> "If the index marked INVALID is suffixed ccnew, then it corresponds to the
> transient index created during the concurrent operation, and the recommended
> recovery method is to drop it using DROP IND
On Fri, Dec 13, 2024 at 12:08:06AM +0900, Fujii Masao wrote:
> Yes, that sounds like a good idea. I've updated the patch accordingly.
LGTM.
--
Michael
signature.asc
Description: PGP signature
On Fri, Oct 18, 2024 at 02:25:15AM +0900, Fujii Masao wrote:
> The documentation in wal.sgml explains that old WAL files cannot be
> removed or recycled until they are archived (when WAL archiving is used)
> or replicated (when using replication slots). However, it did not
> mention that, similarly
On Tue, Dec 03, 2024 at 04:58:04PM +1100, Peter Smith wrote:
> Patch v6-0001 LGTM.
Right, it's true that this is a bit confusing when worded with terms
that are not in the description of the command.
The docs tend to prefer "the --foo option" when
referring to a specific switch in the notes secti
On Thu, Nov 21, 2024 at 04:31:07PM +0100, Erik Wienhold wrote:
> Good catch! That's a leftover from Python 2 and missed in commit
> 4228cabb72b after Python 2 was dropped in 15.0. Patch attached.
>
> While looking at, we can also simplify a couple of plpython3u test
> functions that still try re
On Wed, Nov 20, 2024 at 11:22:51AM -0500, Bruce Momjian wrote:
> I think we kept 'on' just for backward compatibility, so we don't
> mention it in the docs anymore.
True, but we show it based on wal_compression_options and list it in
postgresql.conf.sample. So we could as well add this extra line
On Fri, Sep 13, 2024 at 07:39:13AM +0900, Michael Paquier wrote:
> I am not so sure, TBH. One example: I know these values in
> tablecmds.c for some time because that's an area I tend to focus on
> for bug fixes, but forgot entirely about the SQL function in event
> triggers that
On Thu, Sep 12, 2024 at 08:52:00AM -0400, Greg Sabino Mullane wrote:
> I do like the simplicity of the bitmap:
>
> if (reason & 1)
> print "Table has changed from logged to unlogged"
> if (reason & 2)
> print "Default has been changed"
>
> versus with text[]:
>
> foreach reason in tablereaso
On Wed, Sep 11, 2024 at 10:14:27AM -0400, Greg Sabino Mullane wrote:
> I dunno - so would we smush them together and return something like:
>
> "ALTER_PERSISTENCE and COLUMN_REWRITE"
If multiple are set, let's just make it text[], then.
> That would be a step backwards for anyone possibly using
On Tue, Jul 23, 2024 at 01:25:39PM +0200, Philipp Salvisberg wrote:
> read "optional" as "mandatory".
They're optional, like in empty being optional. If not specified, the
block goes to its END.
> Therefore, I suggest to change this example by adding a NULL
> statement as in other examples. This
On Tue, Sep 03, 2024 at 09:34:02PM +0200, Laurenz Albe wrote:
> On Tue, 2024-09-03 at 11:54 -0400, Greg Sabino Mullane wrote:
>> How about something like this?
>
> This patch looks good to me.
-Returns a code explaining the reason(s) for rewriting. The exact
-meaning of the codes
On Mon, Jul 22, 2024 at 01:55:52PM +, PG Doc comments form wrote:
> In
> https://www.postgresql.org/docs/16/plpgsql-control-structures.html#PLPGSQL-ERROR-TRAPPING
> handler_statements are documented as optional.
>
> However, the following example shows that handler_statements can be omitted.
On Fri, Jul 19, 2024 at 10:46:04AM +0900, 日向充 wrote:
> I have found executable examples that do not work correctly
> in the doc of "SQL Functions Returning Sets" in xfunc.sgml.
> So I fixed the examples as follows.
> - Changed CREATE TABLE tab
> '(y int, z int)' to '(x int, y int, z int)'
> - Cha
On Wed, May 22, 2024 at 02:12:36PM +0900, Michael Paquier wrote:
> Will fix once we are out of release freeze time on HEAD. Thanks!
And done as of dd087e1c13bf.
--
Michael
signature.asc
Description: PGP signature
On Wed, May 22, 2024 at 02:59:37AM +0200, Erik Wienhold wrote:
> Here's a patch for $SUBJECT. Looks like the current wording was copied
> from ALTER TABLE. In ALTER VIEW we correctly state that column_name
> must be an existing column.
Fun. You are right, none of the patterns supported by this
On Wed, Feb 21, 2024 at 08:50:59AM +0100, Daniel Gustafsson wrote:
> On 21 Feb 2024, at 03:24, Erik Wienhold wrote:
>>
>> The docs on pg_reload_conf() in v15, v16, and devel have an incorrect
>> link to pg_ident_file_mappings. The attached patch fixes that.
>
> Nice catch, will fix.
Thanks you
On Sat, Dec 02, 2023 at 05:52:50PM +0900, Shinya Kato wrote:
> Thanks for the review.
> Yes, that's true. A new patch is attached.
Thanks, applied.
--
Michael
signature.asc
Description: PGP signature
On Fri, Dec 01, 2023 at 11:54:14AM +0900, Shinya Kato wrote:
> later disconnected, the standby goes back to step 1 and tries to
> restore the file from the archive again. This loop of retries from the
> archive, pg_wal, and via streaming replication goes
> on until the server
> -
On Wed, Nov 01, 2023 at 09:18:47AM +0900, Michael Paquier wrote:
> So you mean something like the attached then?
Fixed that with f8b96c211da0 down to 11, in time for next week's
release set.
--
Michael
signature.asc
Description: PGP signature
On Tue, Oct 31, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote:
> I don't remember details, but I think the primary reason for the change
> was that "RAISE_EXCEPTION" occurred in the whole tree only once (before
> 66bde49d96). Now I see, that I had chosen the wrong replacement — I agree
> with Eu
On Mon, Oct 23, 2023 at 12:33:03PM +0300, Maxim Yablokov wrote:
> We have also prepared a small patch concerning spelling, punctuation, etc.
> We've decided to send it separately, so it'll be easier to review. Please
> have a look.
Yep, these are improvements. So applied and backpatched (all thes
On Sat, Oct 21, 2023 at 04:11:50PM +0900, Michael Paquier wrote:
> But not this one. This could just be "WAL senders", but we also use
> the term "walsender" in physical and logical replication areas, so a
> plural looks OK for me here, leaving it as it is now.
I hav
On Fri, Oct 20, 2023 at 11:22:55AM +0300, Maxim Yablokov wrote:
> PostgresPro documentation team (Ekaterina Kiryanova, Elena Indrupskaya, Oleg
> Sibiryakov and me) have prepared a patch with some improvements concerning
> missed/inapt tags. Please have a look.
Most of what you are proposing makes
On Mon, Sep 18, 2023 at 10:08:30PM +0200, Laurenz Albe wrote:
> On Mon, 2023-09-18 at 15:29 +, PG Doc comments form wrote:
>> My main issue is that `pg_basebackup` page does not mention that this backup
>> is compatible only with current version of database. I can not do basebackup
>> on v11 an
On Sat, Jul 15, 2023 at 05:57:40AM +, PG Doc comments form wrote:
> I was reading the documentation about pg_ctl and there everything was well
> written about the usage and option that can be used with the pg_ctl command
> but there is not mentioned that we can not run pg_ctl command as root an
On Fri, Jun 23, 2023 at 10:50:20PM -0400, Bruce Momjian wrote:
> Applied patch is "With decades of development".
Thanks.
--
Michael
signature.asc
Description: PGP signature
On Fri, Jun 23, 2023 at 03:17:26AM +0200, Erik Wienhold wrote:
> An SGML entity [0] or an xsltproc stringparam [1] looks viable. Question is
> how to calculate the number of decades in the Makefile. It's trivial in SQL
> :)
- University of California at Berkeley. With over two decades of
+ U
On Tue, May 23, 2023 at 08:52:25PM +, PG Doc comments form wrote:
> There appears to be a typo, here:
> https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20ANSI%20C.
> A word or two should be added between 'completely' and 'ANSI C', such as
> 're-
On Mon, Apr 10, 2023 at 09:47:08AM +0100, Steve Atkins wrote:
> Yes, I’ll do that once I get some time to get the doc toolchain working.
Well, if you don't want to spend time setting up a toolchain, feel
free to send a patch just hacking the SGML files. I am OK to take it
from there, as long as t
On Tue, Mar 28, 2023 at 04:28:24PM +0200, Peter Eisentraut wrote:
> Sure, some cross-linking between those two sections seems sensible.
Steve, would you like to propose a patch?
--
Michael
signature.asc
Description: PGP signature
On Mon, Feb 27, 2023 at 07:24:37PM +, PG Doc comments form wrote:
> In your examples, AS t1(proname name, prosrc text)
> should actually be AS t1(proname text, prosrc text)
>
> This occurs frequently in the documentation at the following link:
> https://www.postgresql.org/docs/cur
On Wed, Feb 22, 2023 at 09:24:37AM +0100, Peter Eisentraut wrote:
> Yeah, this is just in the long tail of things to work through.
I am going through that, and found out what can be done to do coverage
reports. I will post a patch separately on -hackers.
--
Michael
signature.asc
Description: PG
On Tue, Feb 21, 2023 at 10:40:12AM +0100, Jelte Fennema wrote:
> The -Dcassert and -Db_coverage of the meson build didn't show in the
> docs that they needed to be passed true or false. All other options
> specified the arguments they expected. This patch fixes that.
Indeed, values have to be spec
On Tue, Feb 14, 2023 at 09:06:13AM +, Katsuragi Yuta wrote:
> The parameter name "-Dtap-tests" in the meson's doc seems to be a typo.
> I think "-Dtap_tests" is the correct name. Attached patch fixes that.
>
> I got an unknown options error by using "-Dtap-tests=enabled". However,
> meson_opt
On Tue, Jan 24, 2023 at 10:38:28PM -0500, Tom Lane wrote:
> Works for me.
Thanks for checking, applied that.
--
Michael
signature.asc
Description: PGP signature
On Tue, Jan 24, 2023 at 03:22:44PM -0500, Tom Lane wrote:
> I wonder whether we shouldn't just revert this table to
> showing opclass names, and avert our eyes from the theoretical
> inconsistency. Michael, looks like it was your 7a1cd5260
> that changed it; what do you think?
Yes, the docs shoul
On Mon, Nov 21, 2022 at 03:14:20PM +0100, Guillaume Lelarge wrote:
> While translating the new minor release docs, I've found an issue. Patch
> attached fixes this issue. The issue is only available on v11 and v12.
> Patch made on v11, but should also work on v12.
Indeed, applied to REL_12_STABLE
On Thu, Nov 03, 2022 at 07:53:55PM -0400, Tom Lane wrote:
> Agreed, done.
Thanks for taking care of that!
--
Michael
signature.asc
Description: PGP signature
On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote:
> Thanks, that's wrong :/
Anyway, this one is on me, so applied. Thanks for the patch and the
report!
--
Michael
signature.asc
Description: PGP signature
On Mon, Oct 24, 2022 at 12:53:26AM -0400, Tom Lane wrote:
> Tatsuo Ishii writes:
>> Yeah, that's a typo. Patch attached.
Thanks, that's wrong :/
> Shouldn't it be "integer"?
When it comes down to the data types of a JSON object, these are
referred as "number", as these can be either integers or
On Tue, Sep 27, 2022 at 03:58:10PM +0300, Elena Indrupskaya wrote:
> My colleagues from the Postgres Pro documentation team and I noticed a few
> minor inconsistencies in recently updated sections of the PostgreSQL 15
> documentation. The attached patch fixes them.
>
> Two contributor names in the
On Fri, Sep 30, 2022 at 06:10:01PM +0300, Ekaterina Kiryanova wrote:
> I've prepared a small patch to fix a broken link and some inconsistencies
> with upper/lower case letters.
> Please take a look.
Thanks Ekaterina, this looks fine to me so applied. The cosmetic part
in func.sgml is older than
On Thu, Aug 18, 2022 at 12:46:41PM +0300, Maxim Yablokov wrote:
> Yeah, sorry about that, I fixed it in the new patch.
> As for the tag, it is written above:
> pg_basebackup --target=shell
> And also in backup.sgml there is the following:
> createdb -T template0 class="parameter">dbname
> So I b
On Wed, Aug 17, 2022 at 06:09:13PM +0300, Максим Яблоков wrote:
> I have prepared a small patch with possible changes of these places, and
> also a separate patch with some improvements concerning missed/inapt tags.
> Please have a look.
archive_command is used only when archive_library is not set
On Mon, Aug 01, 2022 at 11:00:20PM +0300, Ekaterina Kiryanova wrote:
> I didn't include it in the patch but I also suggest removing single quotes
> around 'method' for the COMPRESSION option to help avoid confusion. (All the
> supported compression methods consist of a single word so in my opinion
On Wed, Jul 20, 2022 at 01:51:36PM +0900, Fujii Masao wrote:
> Attached is the updated version of the patch. It separates the list
> for GUC flags from the table entry for pg_settings_get_flags() and
> adds the table for it at the bottom of the existing function table.
Thanks a lot for sending a
On Fri, Jul 15, 2022 at 03:40:08PM +0200, Alvaro Herrera wrote:
> I think it should be a separate table, like tables 9.75-9.77 lists
> properties for various functions.
Err, sorry for missing that. I did not notice that a list would be
treated as separate lines in the existing function table. Ad
On Thu, Jul 07, 2022 at 12:27:01AM +, PG Doc comments form wrote:
> Towards the end of the section, the code examples given have comments where
> the JSON is using single quotes instead of double quotes around the
> properties. For example this:
>
> -- Where jsonb_field was {}, it is now {
On Tue, Jun 28, 2022 at 12:42:08PM +0900, Noboru Saito wrote:
> If you want to separate hashes or add links,
> I think it would be better to stop the current comment and make it a paragraph
> (I think it is possible to keep them folded
> when converted to html even if they are paragraphs).
> I agr
On Sun, Jun 26, 2022 at 09:19:21PM +0900, Noboru Saito wrote:
> Currently the comments in the document are removed when converting to html.
> I propose to keep them as html comments.
OK. The format of the HTML pages is rather clean, so this would be
rather readable.
> The release notes have the
On Wed, May 18, 2022 at 03:02:04AM +, PG Doc comments form wrote:
> There are 3 periods instead of 2 which I believe is incorrect.
It seems to me that those three periods refer to the root path of the
source tree that you'd need to type by yourself to reach it.
--
Michael
signature.asc
Desc
Hi Leslie,
On Sat, Mar 05, 2022 at 10:15:33AM +, PG Doc comments form wrote:
> "ALTER ROUTINE" and "DROP ROUTINE" are not listed in the "Event Trigger
> Firing Matrix" documentation page, even though these tags seem supported
> from PostgreSQL 11 onwards.
>
> It would be really useful to ment
On Tue, Mar 08, 2022 at 06:34:34PM +0900, Dong Wook Lee wrote:
> Patch looks good to me.
Okay, applied then.
--
Michael
signature.asc
Description: PGP signature
On Tue, Mar 08, 2022 at 09:31:49AM +0900, Dong Wook Lee wrote:
> I don't know about it, so should I use at FSM for all the
> acronyms in the section dedicated to acronyms?
Yes, I would do that on consistency grounds. Your idea to add a link
to the section describing what a FSM is from pgfreespac
On Mon, Mar 07, 2022 at 11:08:16AM +0100, Laurenz Albe wrote:
> On Sun, 2022-03-06 at 23:42 +0900, Dong Wook Lee wrote:
>>
>> The pg_freespacemap module provides a means for
>> examining the
>> - free space map (FSM). It provides a function called
>> + free space map (FSM). It provides a
On Wed, Jan 19, 2022 at 01:45:07PM +0900, Michael Paquier wrote:
> No objections to add more details for all that. Will fix.
And done as of b2a76bb.
--
Michael
signature.asc
Description: PGP signature
On Tue, Jan 18, 2022 at 03:37:35PM +0100, Laurenz Albe wrote:
> On Tue, 2022-01-18 at 14:11 +, nikolai.berkoff wrote:
>> I wanted to know what lock the COMMENT ON command took and I had to look in
>> the
>> source code, makes sense to me that it should be documented. I've also added
>> it to
On Mon, Dec 20, 2021 at 07:19:32AM -0500, Dave Cramer wrote:
> The docs say it returns 3 values ?
They do. Here is the relevant part:
https://www.postgresql.org/docs/devel/functions-admin.html#FUNCTIONS-ADMIN-BACKUP
"The result of the function is a single record. The lsn column holds
the backup's
On Thu, Oct 28, 2021 at 01:34:40PM +0200, Daniel Gustafsson wrote:
> AFAICT it's the same document, but updated. If we want to leave 9.6 in as
> much
> of a working state as possible I think it makes sense to change to that one.
> I'm happy to do it if you concur.
Sure. That's fine by me.
--
Mi
On Wed, Oct 27, 2021 at 05:09:41PM +0900, Michael Paquier wrote:
> Indeed, that's broken. Will fix as per your suggestion.
And done down to 10 as of cc1853b. 9.6 used a different link that was
already dead, and this version will be EOL'd soon, so I did not bother
changing i
On Wed, Oct 27, 2021 at 02:01:24PM +0700, Anton Voloshin wrote:
> on https://www.postgresql.org/docs/current/sepgsql.html
> the "SELinux User's and Administrator's Guide" link to
> https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/SELinux_Users_and_Administrators_Guide/
On Tue, Oct 19, 2021 at 06:41:54PM -0700, David G. Johnston wrote:
> On Tue, Oct 19, 2021 at 2:33 PM Tom Lane wrote:
>> ... although I think this text is mine, so naturally I'd think
>> that. Anyone else have an opinion?
>
> If I read that aloud to myself there is a comma after iteration.
Agreed
On Tue, Oct 19, 2021 at 12:16:44PM -0300, Alvaro Herrera wrote:
> Dunno, putting it in the middle of the existing paragraph looks odd to
> me. I would put it in a separate one instead, as in the attached.
Fine by me. Thanks!
--
Michael
signature.asc
Description: PGP signature
On Mon, Oct 18, 2021 at 05:15:59PM -0300, Euler Taveira wrote:
> I agree that it might surprise an user and it would be good to document it.
> However, it does not belong to the description. I would add it to the Notes
> section at the end of the ALTER TABLE page.
No objections to the suggested ad
On Mon, Sep 27, 2021 at 06:07:57PM +0900, Michael Paquier wrote:
> Thanks. These are good catches.
Now that 14.0 has been tagged, applied.
--
Michael
signature.asc
Description: PGP signature
On Mon, Sep 27, 2021 at 11:42:40AM +0300, Ekaterina Kiryanova wrote:
> I've come across some minor inconsistencies in PostgreSQL 14 docs.
> Please review the attached patch.
Thanks. These are good catches.
--
Michael
signature.asc
Description: PGP signature
On Sat, Sep 25, 2021 at 07:51:15AM +0900, Michael Paquier wrote:
> WFM.
This has been applied and backpatched as of 1ba8410.
--
Michael
signature.asc
Description: PGP signature
On Fri, Sep 24, 2021 at 02:36:58PM -0400, rir wrote:
> The CREATE EVENT TRIGGER synopsis uses the
> bare word 'filter_value' when it seems
> filter_variable
> was intended.
Right, there was one incorrect place. Thanks!
--
Michael
signature.asc
Description: PGP signature
On Fri, Sep 24, 2021 at 12:21:40PM -0300, Euler Taveira wrote:
> Good point. However, I prefer "if set".
WFM.
--
Michael
signature.asc
Description: PGP signature
On Thu, Sep 23, 2021 at 10:48:37AM +0200, Laurenz Albe wrote:
> Thanks, and +1 from me.
maintenance_work_mem would be used in the context of autovacuum if
autovacuum_work_mem is -1, but it seems to me that the suggested
wording sounds like only autovacuum_work_mem is used and that it would
never f
On Wed, Sep 01, 2021 at 10:34:42PM +0900, Michael Paquier wrote:
> Thanks Elena for caring about that. Agreed that these are
> improvements.
And done. There were extra conflicts with 10 and 9.6 simple enough to
solve, so backpatched all the way down.
--
Michael
signature.asc
Descriptio
On Wed, Sep 01, 2021 at 01:24:18PM +0300, Elena Indrupskaya wrote:
> Since the content of parallel.sgml is not new, the documentation for earlier
> versions of PostgreSQL has the same inaccuracies, and it would be great to
> fix them there too. The patch also applies to versions 12 and 13, except o
On Thu, May 27, 2021 at 07:21:16PM +0900, 近藤雄太 wrote:
> First, the config option that specified the kerberos installation
> directory was still "krb5", so we changed it to "gss".
Thanks Kondo-san. Wow. So this has been actually untested for many
years. The stuff got renamed in the MSVC scripts
On Wed, May 26, 2021 at 05:40:45AM +, tanghy.f...@fujitsu.com wrote:
> You're right, backtick notation doesn't work at my windows machine.
> But I made the fix in accordance with the pg-doc as below. So maybe
> we need a fix there, too?
>
> https://www.postgresql.org/docs/current/libpq-pgservi
On Mon, May 24, 2021 at 07:39:27PM +, PG Doc comments form wrote:
> I tried to build using Visual Studio 2019.
> Although I have enable the kerberos support in the configuration file,
> the generated Visual Studio project files do not define "ENABLE_GSS".
> Running the binaries (as a service) r
On Thu, May 20, 2021 at 06:11:40AM +, PG Doc comments form wrote:
> "This role is a member of pg_read_all_settings, pg_read_all_stats and
> pg_stat_scan_tables."
> Is it correct sentence?
> It seems for me that pg_read_all_stats is a member of pg_monitor. But not
> vice versa.
Here is what I a
On Thu, May 20, 2021 at 11:04:05AM +0900, 近藤雄太 wrote:
>> @ Owners of hamerkop, could you look at updating the krb5 installation
>> on this animal? This include path used seems out of date compared to
>> the MSI installers upstream provides.
>
> OK. We'll have it done in a few days.
Thanks!
--
Mi
On Wed, May 19, 2021 at 10:56:23AM -0400, Andrew Dunstan wrote:
> I have no idea - it's not my animal. Maybe ask the owner
>
Oops, I thought that this was yours. I am adding those folks in CC of
this thread.
> I guess maybe I should look at adding kerberos to one of the animals I
> do control.
Hi Andrew,
On Tue, May 18, 2021 at 08:15:35AM -0500, Brian Ye wrote:
> Thanks for the reply.
> Yes I also saw that after installing 64-bit, the 32-bit "bin" and "include"
> directories were removed.
> I think the content of the "include" are common for both 32- and 64-bit.
> Windows can run both 3
On Mon, May 17, 2021 at 08:07:02PM +, PG Doc comments form wrote:
> The Solution.pm file has the following lines:
> if ($self->{options}->{gss})
> {
> $proj->AddIncludeDir($self->{options}->{gss} . '\inc\krb5');
> $proj->AddLibrary($self->{options}->{gss} .
> '\
On Fri, Apr 30, 2021 at 03:48:27AM +, tanghy.f...@fujitsu.com wrote:
> Indeed, column added. Thanks.
I was looking at this thread, and please note that there is no need to
do anything here as the WAL prefetch has been reverted for now as of
c2dc1934.
--
Michael
signature.asc
Description: PG
On Sun, May 02, 2021 at 11:27:22AM +0800, Julien Rouhaud wrote:
> I think you can open %APPDATA% in Windows explorer to get the correct location
> if needed.
Yes, specifying an environment variable in the explorer works. This
is in line with what src/port/path.c does, so I see no actual bugs
here
On Fri, Apr 16, 2021 at 08:11:53AM +0200, Erik Rijkers wrote:
> FWIW, I agree with this and already sent a doc-patch [1], which is
> be applied from 12, 13, and master.
Arf. I completely forgot about this thread but I marked it as
something to look at. Will do so now.
--
Michael
signature.asc
On Thu, Apr 15, 2021 at 11:24:07PM +0900, Fujii Masao wrote:
> I'm not sure why. But +1 to make them in alphabetical order.
> Patch attached.
LGTM.
--
Michael
signature.asc
Description: PGP signature
On Thu, Apr 15, 2021 at 09:55:53AM +0200, Ludovic Kuty wrote:
> Yes indeed, thanks. I re-tested the example this morning and it worked
> correctly with the space. I guess I had messed up things when I first tried
> it.
After seeing Tom's argument that this behavior become more consistent
in 9.2, a
On Wed, Apr 14, 2021 at 11:46:58PM +0900, Fujii Masao wrote:
> The syntax for like_option in CREATE TABLE docs seems to forget to mention
> INCLUDING COMPRESSION option. I think the following fix is necessary.
> Patch attached.
>
> -{ INCLUDING | EXCLUDING } { COMMENTS | CONSTRAINTS | DEFAULTS | G
On Wed, Apr 14, 2021 at 10:12:02AM -0400, Tom Lane wrote:
> As you say, both ways now give the same result. Since it's not the
> point of this example to illustrate \set's space-eating behavior,
> it might be clearer to revert the addition of the space.
Oh, interesting point. I did not notice th
On Tue, Apr 13, 2021 at 07:57:54AM +, PG Doc comments form wrote:
> There is a spurious space inside the documentation:
> \set HISTFILE ~/.psql_history- :DBNAME
> instead of
> \set HISTFILE ~/.psql_history-:DBNAME
Both commands sey in your .psqlrc results in the same path being
used, as I gues
On Sun, Apr 04, 2021 at 09:47:08AM -0400, Jonathan S. Katz wrote:
> Diving deeper while updating the links, I stumbled across this note:
>
> "The MinGW.org web‑site is undergoing an overhaul, whilst in the process
> of transferring to a new hosting provider. During this transitional
> phase, some
On Sat, Apr 03, 2021 at 02:01:38PM +0200, Erik Rijkers wrote:
> Attached is a small but confusing mistake in the json documentation
> (a @@ instead of @?) that has been there since version 12. (It took
> me quite some time to figure that out while testing with the recent
> SQL/JSON patches -- whic
On Thu, Mar 25, 2021 at 12:19:36AM +0100, Daniel Gustafsson wrote:
> As discussed in the NSS thread, we've had TLS defined as an since
> commit c6763156589 in 2014 without actually having it defined in
> acronyms.sgml.
>
> The attached adds the definition linking to the Wikipedia entry for TLS.
On Thu, Feb 25, 2021 at 06:03:57PM +0900, Fujii Masao wrote:
> Regarding the section "Standalone Hot Backups", all the directories and
> file seem to be placed under /var/lib/pgsql, so at least for me it looks a bit
> strange to change only the path of archive directory. So I don't think that
> we
On Wed, Feb 24, 2021 at 02:29:31PM +0900, Michael Paquier wrote:
> Yeah, let's fix that. Adding only PGDATABASE to the list of
> environment variables supported does not look enough to me, so I
> propose the simple patch attached to clarify what happens to dbname in
> more detai
On Wed, Feb 24, 2021 at 08:15:59PM +0900, Fujii Masao wrote:
> But I have one question; why do those commands use different
> archive directories? Isn't it better to use the same one?
storage.sgml uses /var/lib/pgsql/data for the location of the data,
and the archive path is a mix between /mnt/ser
1 - 100 of 286 matches
Mail list logo
