Re: updatable cursors and ORDER BY

2018-05-09 Thread David G. Johnston
On Wed, May 9, 2018 at 7:43 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > The DECLARE reference page says: > > """ > Another reason to use FOR UPDATE is that without it, a subsequent WHERE > CURRENT OF might fail if the cursor query does not meet the SQL > standard's rules for

Re: ALTER

2018-05-02 Thread David G. Johnston
On Wednesday, May 2, 2018, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/static/tutorial-sql.html > Description: > > where is ALTER? > Command reference. Part VI, Chapter I

Re: 40 commands are missing. inserted or missing character?

2018-05-02 Thread David G. Johnston
On Wednesday, May 2, 2018, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/static/queries.html > Description: > > try checking your XML syntax. missing attribute? > I don't

Re: Isn't "publication" wrongly defined here?

2018-04-28 Thread David G. Johnston
On Friday, April 27, 2018, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/static/logical- > replication-publication.html > Description: > > In section 31.1 it says "A

Re: Advice on Contiguous IDs

2018-01-09 Thread David G. Johnston
On Tue, Jan 9, 2018 at 2:06 AM, Brian McKiernan < brian.mckier...@firstcircle.com> wrote: > 1) What event would cause the CACHE clause in CREATE SEQUENCE to make an > out of sequence next number? > ​None - it will always issue the next sequential value when asked. But the transaction asking

Re: SPI not defined.

2018-01-29 Thread David G. Johnston
On Monday, January 29, 2018, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/static/contrib-spi.html > Description: > > In the appendix for Additional Supplied Modules there is

Re: pg_upgrade docs are confusing if PostgreSQL's versioning system/language isn't known to reader

2018-01-29 Thread David G. Johnston
On Sat, Jan 27, 2018 at 8:05 AM, Bruce Momjian wrote: > I decided I needed to be more explicit about the major version numbers > so I have added major and minor examples for the 9.6.x series and 10.x > series releases. Patch attached. > > ​Thanks!​ ​+1 ​David J.

Re: SPI not defined.

2018-01-29 Thread David G. Johnston
On Mon, Jan 29, 2018 at 8:55 PM, Bruce Momjian wrote: > On Mon, Jan 29, 2018 at 10:51:59PM -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > How is the attached patch? > > > > Maybe also make that text into a hyperlink to the SPI manual chapter? > > Yes,

Re: SPI not defined.

2018-01-29 Thread David G. Johnston
On Monday, January 29, 2018, Bruce Momjian wrote: > > How is the attached patch? > > Maybe add a link to: https://www.postgresql.org/docs/10/static/spi.html Also, on that page, the error handling mechanisms have been "in flux" since 8.0 ... ? " This is not currently

Re: complex documentation and hard to find the reference

2018-02-12 Thread David G. Johnston
On Mon, Feb 12, 2018 at 7:01 AM, PG Doc comments form < nore...@postgresql.org> wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/static/functions-json.html > Description: > > with the prior experience of mysql or mongoDb or

Re: Functions in sort order - undocumented restriction

2018-02-10 Thread David G. Johnston
On Sat, Feb 10, 2018 at 4:40 AM, PG Doc comments form < nore...@postgresql.org> wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/static/queries-order.html > Description: > > This works: > > select distinct o.bid,

Re: Functions in sort order - undocumented restriction

2018-02-10 Thread David G. Johnston
On Saturday, February 10, 2018, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/static/queries-order.html > Description: > > This works: > > select distinct o.bid,

Re: Text operators "~<=~ ~<~ ~>=~ ~>~" not documented

2018-02-08 Thread David G. Johnston
On Thu, Feb 8, 2018 at 6:26 AM, Adrien Nayrat wrote: > Hello, > > While reading [1] I notice $subject operators lacks of explanation in > documentation. > ​[..]​ > > > ~<~ less than > ~>~ greater than > ~<=~less than or equal to > ~>=~greater than or

Re: Pltcl install

2018-02-21 Thread David G. Johnston
On Wednesday, February 21, 2018, PG Doc comments form < nore...@postgresql.org> wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/static/pltcl-overview.html > Description: > > How can I install pltcl? > Is possible to copy a

Re: mistake. "whereas cidr does not."

2018-02-20 Thread David G. Johnston
On Tue, Feb 20, 2018 at 9:23 AM, PG Doc comments form < nore...@postgresql.org> wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.1/static/datatype-net-types.html > Description: > ​ ​9.1 is no longer supported and the

Re: dblink_error_message return value

2018-08-08 Thread David G. Johnston
On Wed, Aug 8, 2018 at 8:57 AM, Tom Lane wrote: > > Secondly > > dblink_is_busy must be first called to make dblink_error_message returns > an > > error message. (Tested on 9.6.9) > > Meh. I see what you're getting at here, I think, but that seems like a > completely wrong/misleading statement

Re: Postgre Licence

2018-08-13 Thread David G. Johnston
On Mon, Aug 13, 2018 at 10:02 AM, Mark Williams wrote: > Whilst the PostgreSql licence is refreshingly simple, I find the > instruction on how to use it a little confusing. > You should probably just ignore whatever it is that you found and refer to the following on the website:

Re: PostgreSQL 9.5.14 Documentation /Chapter 28 / 28.1. Determining Disk Usage

2018-09-05 Thread David G. Johnston
On Wed, Sep 5, 2018 at 4:43 AM, PG Doc comments form wrote: > I'm wondering if the two statements given showing the index space size as > described. > I've the impression they show the space size of the tables. > "Each page is typically 8 kilobytes. (Remember, relpages is only updated by

Re: Extend phrase by an example

2018-09-09 Thread David G. Johnston
On Saturday, September 8, 2018, PG Doc comments form wrote: > the constraints shown in the table > definition do not apply to values of the composite type outside the table. > (A partial workaround is to use domain types as members of composite > types.) > > The part: > >(A partial workaround is

Re: \i and \ir separated by \if now...

2018-07-07 Thread David G. Johnston
On Saturday, July 7, 2018, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 27.05.18 05:08, Tom Lane wrote: > > "Vianello, Daniel A" writes: > >>> Uh, why would we list \ir before the simpler \i? > > > >> So that the request is to merge \ir into the \i section (not before \i >

Re: Dead link in ltree documentation

2018-04-04 Thread David G. Johnston
On Wed, Apr 4, 2018 at 1:02 PM, David G. Johnston < david.g.johns...@gmail.com> wrote: > On Wed, Apr 4, 2018 at 12:06 PM, Bruce Momjian <br...@momjian.us> wrote: > FYI - Bruce's "I've committed this" email is the only one in the thread that made it into my in

Re: Documentation for varbit is missing size parameter

2018-03-30 Thread David G. Johnston
On Friday, March 30, 2018, Bruce Momjian wrote: > > I looked at this patch and thought it was more a stylistic item rather > than a correction. Is that right? > Looks like a syntax bug fix to me - especially since it is a reference table. Those should be back-patched. David

Re: Getting started guide does not start from first step

2018-03-25 Thread David G. Johnston
On Sunday, March 25, 2018, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.0/static/tutorial-createdb.html > Description: You should learn from the most recent version of the

Re: Blanks in the first line before the first word in the code boxes

2018-03-29 Thread David G. Johnston
On Thu, Mar 29, 2018 at 6:40 AM, Tom Lane wrote: > Magnus Hagander writes: > > Is it possible that this issue actually showed up around 4-5 February, > but > > just has gone unnoticed since? > > It's been there a few weeks, anyway --- I remember somebody

Re: Keep me update every new development

2018-03-18 Thread David G. Johnston
On Sunday, March 18, 2018, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.1/static/sql-listen.html > Description: > > Keep me update every new development > Sorry,

Re: Synopsis of SELECT statement: UNION, INTERSECTION, EXCEPT

2018-03-18 Thread David G. Johnston
As a first step we could do something like: ​basic_select_statement is: ​ > SELECT [ ALL | DISTINCT [ ON ( expression [, ...] ) ] ] > [ * | expression [ [ AS ] output_name ] [, ...] ] > [ FROM from_item [, ...] ] > [ WHERE condition ] > [ GROUP BY grouping_element [, ...] ] >

Re: Extra indentation in first line

2018-02-26 Thread David G. Johnston
On Mon, Feb 26, 2018 at 6:43 AM, PG Doc comments form < nore...@postgresql.org> wrote: > In some queries there is an extra indentation > ​. > ​I just now noticed the same thing while looking a report on GRANT syntax. I've spotted checked a couple of other pages and found the same. The "code"

Re: Ambiguous usage of 'any' in explanation

2018-10-15 Thread David G. Johnston
On Saturday, October 13, 2018, Bruce Momjian wrote: > On Sat, Oct 13, 2018 at 12:25:38PM +0300, KES wrote: > > >or NULL if any of the comparisons result in unknown > > result in unknown?? > > Well, SQL has a three-valued logic, and UNKOWN values are treated like > NULL. For me they have always

Re: citext plugin is not working with java applications

2019-01-21 Thread David G. Johnston
On Mon, Jan 21, 2019 at 7:39 PM Bruce Momjian wrote: > You have not explained what "does not work" means. True...but assuming it is true would we accept placing a driver-specific warning here? We do not do so anywhere else in the documentation that I am aware. The main issue, IIUC, is that

Re: DOC not so clear

2019-01-14 Thread David G. Johnston
On Monday, January 14, 2019, Eugen Konkov wrote: > Hello Tom, > > Monday, January 14, 2019, 6:15:31 PM, you wrote: > > > =?utf-8?q?PG_Doc_comments_form?= writes: > >> https://www.postgresql.org/docs/current/queries-table- > expressions.html#QUERIES-LATERAL > > >>> The resulting row(s) are

Re: CREATE/ALTER ROLE with NULL password

2018-11-22 Thread David G. Johnston
On Thursday, November 22, 2018, Michael Paquier wrote: > On Wed, Nov 21, 2018 at 11:58:25PM -0700, David G. Johnston wrote: > > Should tweak the paragraph to point out this exception as well. > > > > The ENCRYPTED keyword has no effect, but is accepted for backwards >

Re: Incorect path

2019-02-11 Thread David G. Johnston
On Mon, Feb 11, 2019 at 8:25 AM PG Doc comments form wrote: > At https://www.postgresql.org/docs/9.4/tutorial-sql-intro.html it is > written: > $ cd /src/tutorial > The four dots are not valid, either remove two of them or replace all four > with proper path such as ../.. Your solutions are

Re: Confusing information in sections 8.5 and 9.9 (date and time types, functions and operators)

2019-04-13 Thread David G. Johnston
On Friday, April 12, 2019, Bruce Momjian wrote: > On Tue, Apr 9, 2019 at 02:50:14PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > I think > > this is a serious issue, especially because the alternative possibility > of > > using

Re: \W excludes underscore

2019-05-07 Thread David G. Johnston
On Tue, May 7, 2019 at 4:36 PM Erwin Brandstetter wrote: > > https://www.postgresql.org/docs/current/functions-matching.html#POSIX-CLASS-SHORTHAND-ESCAPES-TABLE > Table 9.19. Regular Expression Class-shorthand Escape: > > > \w [[:alnum:]_] (note underscore is included) > > ... > > \W

Re: intarray overlap (have elements in common) operator

2019-05-03 Thread David G. Johnston
On Thursday, May 2, 2019, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/functions-array.html > Description: > > Hi > > How do i write below native query to JPA/Hibernate. (JPQL) > > SELECT * FROM

Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-08 Thread David G. Johnston
On Mon, Jul 8, 2019 at 7:59 PM Michael Paquier wrote: > Attached is an idea of patch for the documentation, using this > wording: > + > + > + When defining a primary key on a partitioned table, the primary > + key column must be included in the partition key. > + > +

Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-09 Thread David G. Johnston
On Mon, Jul 8, 2019 at 11:34 PM Michael Paquier wrote: > On Mon, Jul 08, 2019 at 08:12:18PM -0700, David G. Johnston wrote: > > Reads a bit backward. How about: > > > > "As uniqueness can only be enforced within an individual partition when > > defining a primar

Re: @> (contains)

2019-08-18 Thread David G. Johnston
On Sun, Aug 18, 2019 at 8:53 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/functions-array.html > Description: > > Hi. > Noticed strange thin with @> > Query "select '{1,2}'::int[] @>

Re: returning does not act as expected after viewing documentation

2019-09-23 Thread David G. Johnston
On Mon, Sep 23, 2019 at 2:45 PM PG Doc comments form wrote: > update batch_log > set status=('in-progress'), > updated_at=now() > [...] > returning id, batch_log.update_at > ; > > column batch_log.update_at does not exist > LINE 14: returning id, batch_log.update_at > HINT: Perhaps you

Re: Adding a Column documentation is misleading

2019-11-06 Thread David G. Johnston
On Tuesday, November 5, 2019, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/ddl-alter.html > Description: > > In 5.6.1. Adding a Column, there is a kind of example 'ALTER TABLE products > ADD COLUMN

Re: no mention of GRANT USAGE in postgres_fdw docs

2019-11-15 Thread David G. Johnston
On Fri, Nov 15, 2019 at 12:05 PM Tom Lane wrote: > PG Doc comments form writes: > > The documentation page for postgres_fdw > > gives a nice > > step by step on what's needed to configure a FOREIGN SERVER. However, > one > > crucial

Re: Example for unnest(anyarray, anyarray) fails

2019-12-11 Thread David G. Johnston
On Wed, Dec 11, 2019 at 3:21 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/functions-array.html > Description: > > [...] > ghowe=# select unnest(ARRAY[1,2],ARRAY['foo','bar','baz']); > ERROR:

Re: description of Aggregate Expressions

2019-12-05 Thread David G. Johnston
On Thu, Dec 5, 2019 at 3:18 PM John Lumby wrote: > In PostgreSQL 12.1 Documentation chapter 4.2.7. Aggregate Expressions it > says > > > The syntax of an aggregate expression is one of the following: > ... > aggregate_name (DISTINCT expression [ , ... ] [ order_by_clause ] ) [ > FILTER (

Re: Make default values bold in Synopsis / bnf diagram

2019-12-20 Thread David G. Johnston
On Fri, Dec 20, 2019 at 1:56 PM Bruce Momjian wrote: > On Mon, Dec 2, 2019 at 09:19:32PM +, PG Doc comments form wrote: > > > In this example the words to words "READ COMMITTED", "READ WRITE" should > be > > bold since they are default values if I execute the statement "BEGIN;" > see > >

Re: COPY manual is ambiguous about column list

2019-12-19 Thread David G. Johnston
On Thu, Dec 19, 2019 at 9:46 PM Tom Lane wrote: > Bruce Momjian writes: > > How is the attached patch? > > !In COPY FROM, the number of columns specified > !must match the number of fields in the file; any table columns not > !specified in the COPY FROM column list will insert > !

Re: COPY manual is ambiguous about column list

2019-12-19 Thread David G. Johnston
On Thursday, December 19, 2019, Tom Lane wrote: > "David G. Johnston" writes: > > Seems better to simply talk about each form independently: > > > If a list of columns is specified, COPY TO will only > > copy the data in the specified columns to the file. CO

Re: COPY manual is ambiguous about column list

2019-12-20 Thread David G. Johnston
On Fri, Dec 20, 2019 at 7:13 AM Tom Lane wrote: > Bruce Momjian writes: > > OK, how is this? > > I do not like the phrasing of > > If a column list is > specified in COPY FROM, the number and position of > the columns must match those fields in the file. > > I'm not quite sure why,

Re: COPY manual is ambiguous about column list

2019-12-20 Thread David G. Johnston
On Fri, Dec 20, 2019 at 9:21 AM Tom Lane wrote: > Bruce Momjian writes: > > OK, this wording is obviously harder than I thought. Updated patch > > attached. > > That one works for me. > Me too. David J.

Re: Lack of detailed documentation

2020-02-10 Thread David G. Johnston
On Monday, February 10, 2020, Strauss, Randy (ARC-AF)[SGT, INC] < randolph.a.stra...@nasa.gov> wrote: > Yes, I figured this out. People shouldn't have to figure out that the 2 > numbers in the vector are the scale and rotation. > They could be the rotation and scale. The rotation could be in

Re: LOGIN/NOLOGIN in psql

2020-02-13 Thread David G. Johnston
On Thu, Feb 13, 2020 at 2:53 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/sql-createrole.html > Description: > > Please add something like this to the LOGIN/NOLOGIN part: > > The `psql` commands

Re: 9.4. String Functions and Operators page does not document that encode adds line breaks

2020-02-08 Thread David G. Johnston
On Sat, Feb 8, 2020 at 12:10 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/functions-string.html > Description: > > It took me a long time to discover why a base 64 encoded SHA-512 hash was > 89 >

Re: 9.4. String Functions and Operators page does not document that encode adds line breaks

2020-02-09 Thread David G. Johnston
On Sun, Feb 9, 2020 at 9:03 AM Tom Lane wrote: > PG Doc comments form writes: > > The base64 format is that of RFC 2045 Section 6.8. As per the RFC, > encoded lines are broken at 76 characters > > > By the way, this is a very poor design decision. > > So far as I can tell, that RFC's

Re: Lack of detailed documentation

2020-02-08 Thread David G. Johnston
On Fri, Feb 7, 2020 at 4:53 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/functions-geometry.html > Description: > > On: https://www.postgresql.org/docs/current/functions-geometry.html > > The

Re: the concept of a database cluster

2020-01-03 Thread David G. Johnston
On Thursday, January 2, 2020, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/creating-cluster.html > Description: > > In 18.2, a database cluster is said to be "a database storage area on > disk", >

Re: the concept of a database cluster

2020-01-04 Thread David G. Johnston
On Saturday, January 4, 2020, Paul Weiss wrote: > Oh, I didn't mean to imply that I am confused. It is clear that there are > two concepts here, sharing a term. I was trying to communicate that the > manual does not always make it immediately clear from context which concept > is meant in a

Re: caes insensitivity

2020-04-17 Thread David G. Johnston
On Fri, Apr 17, 2020 at 4:10 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/sql-syntax-lexical.html > Description: > > The docs are misleading about the case insensitive nature, as someone new > to

Re: Proposal to improve the content in subsection 8.16.6. "Composite Type Input and Output Syntax"

2020-04-06 Thread David G. Johnston
On Mon, Apr 6, 2020 at 12:46 AM Bryn Llewellyn wrote: > Tom Lane wrote: > > ... > > > It's already an example, so I don't see this as an improvement. > > ... > > > The proposed additional text is flat-out wrong. > > What actually happens here is that text between quotes is considered > quoted

Re: Lack of detailed documentation

2020-04-22 Thread David G. Johnston
On Wed, Apr 22, 2020 at 5:18 PM David G. Johnston < david.g.johns...@gmail.com> wrote: > On Wed, Apr 22, 2020 at 4:36 PM Tom Lane wrote: > >> One thing that surprised me is that I couldn't find any well-known >> name for what the * and / operators are doing; digg

Re: Lack of detailed documentation

2020-04-22 Thread David G. Johnston
On Wed, Apr 22, 2020 at 4:36 PM Tom Lane wrote: > Surely Lockhart[1] got this > definition from someplace, though, and didn't invent it out of thin air. > I actually viewed quite a few YouTube math videos between then and now and looking at it now it seems familiar. It is basically treating

Re: Lack of detailed documentation

2020-04-22 Thread David G. Johnston
On Wed, Apr 22, 2020 at 4:36 PM Tom Lane wrote: > One thing that surprised me is that I couldn't find any well-known > name for what the * and / operators are doing; digging around on > the net and in some dusty old math textbooks didn't yield any exact > matches. I ended up adding footnotes

Re: Where is the typo?

2020-04-29 Thread David G. Johnston
On Wed, Apr 29, 2020 at 8:32 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/protocol-flow.html > Description: > > In "52.2.2.1. Multiple Statements in a Simple Query" there is supposed to > be > a

Re: adding a TOC to the psql reference page

2020-04-30 Thread David G. Johnston
On Thu, Apr 30, 2020 at 3:17 PM Bruce Momjian wrote: > On Thu, Apr 30, 2020 at 08:48:09PM +, PG Doc comments form wrote: > > > Since https://www.postgresql.org/docs/current/app-psql.html is quite > long, > > it would be nice to add a detailed table of contents at its beginning, in > > order

Re: The suggestion of reducing autovacuum_vacuum_cost_delay should be documented

2020-05-12 Thread David G. Johnston
On Tue, May 12, 2020 at 2:41 PM Bruce Momjian wrote: > On Tue, May 12, 2020 at 05:40:14PM -0400, Bruce Momjian wrote: > > On Tue, May 12, 2020 at 10:26:27AM +, PG Doc comments form wrote: > > > The following documentation comment has been logged on the website: > > > > > > Page: >

Re: The suggestion of reducing autovacuum_vacuum_cost_delay should be documented

2020-05-12 Thread David G. Johnston
On Tue, May 12, 2020 at 4:30 PM Bruce Momjian wrote: > On Tue, May 12, 2020 at 07:26:07PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Tue, May 12, 2020 at 03:38:16PM -0700, David G. Johnston wrote: > > >> The proposal is to document in versions 9.

Re: The suggestion of reducing autovacuum_vacuum_cost_delay should be documented

2020-05-12 Thread David G. Johnston
On Tue, May 12, 2020 at 4:59 PM Tom Lane wrote: > "David G. Johnston" writes: > > To be clear, because my cursory reading of the thread that was linked > from > > the commit suggested that this specific situation was more "lets catch up > &

Re: application_name parameter

2020-09-15 Thread David G. Johnston
On Tuesday, September 15, 2020, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/runtime-config-logging.html > Description: > > Hi! > > In section "19.8.3. What to Log" appears "application name

Re: Forgotten quote signs in description of "array value as a literal constant"

2020-10-06 Thread David G. Johnston
On Mon, Oct 5, 2020 at 9:32 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/arrays.html > Description: > > Documentation should mention single quotes in "array value as a literal > constant"

Re: nondeterministic collations and statistics and pattern matching

2020-10-11 Thread David G. Johnston
On Tuesday, October 6, 2020, Tom Lane wrote: > PG Doc comments form writes: > > If exists statistic with nondeteministic collation inherited from column > > collation then using pattern matching with collation will give an error. > > Yeah, that's a known problem we fixed months ago. > > > There

Re: https://www.postgresql.org/docs/13/tutorial-join.html missing a table

2020-10-18 Thread David G. Johnston
On Sun, Oct 18, 2020 at 2:29 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/13/tutorial-join.html > Description: > > This page references a "cities" table, but not prior page showed this > table. >

Re: 42.6.8.1. Obtaining Information About An Error

2020-10-07 Thread David G. Johnston
On Wed, Oct 7, 2020 at 12:57 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/plpgsql-control-structures.html > Description: > > 42.6.8.1. Obtaining Information About An Error > > This example omits

Re: doc bug for continuous archiving

2020-10-07 Thread David G. Johnston
On Wed, Oct 7, 2020 at 2:35 PM Jeff Janes wrote: > Quoting the docs: > > https://www.postgresql.org/docs/13/continuous-archiving.html > > "As with base backups, the easiest way to produce a standalone hot backup > is to use the pg_basebackup tool. If you include the -X parameter when > calling

Re: https://www.postgresql.org/docs/current/functions-sequence.html

2020-10-19 Thread David G. Johnston
On Mon, Oct 19, 2020 at 1:13 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/13/functions-sequence.html > Description: > > This page: > https://www.postgresql.org/docs/current/functions-sequence.html >

Re: Inaccurate description of UNION/CASE/etc type selection

2020-08-17 Thread David G. Johnston
On Mon, Aug 17, 2020 at 10:11 AM Tom Lane wrote: > "David G. Johnston" writes: > > On Mon, Aug 17, 2020 at 8:31 AM Tom Lane wrote: > >> So this is just a verbatim statement of the algorithm, which is what > >> I was hoping to avoid :-(. But maybe there

Re: obsolete indexing method "rtree"

2020-08-18 Thread David G. Johnston
On Fri, Aug 7, 2020 at 8:46 AM Jürgen Purtz wrote: > > On 06.08.20 10:12, David G. Johnston wrote: > > On Thu, Aug 6, 2020 at 12:18 AM Jürgen Purtz wrote: > >> >> > Why? >> >> Because it can hinder the learning process. > > > > Such a

Re: need for "see also" section or similar thing at hub pages

2020-08-18 Thread David G. Johnston
On Wed, Aug 5, 2020 at 5:29 PM Bruce Momjian wrote: > On Tue, Aug 4, 2020 at 03:56:32PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/functions-textsearch.html > > Description: > > > >

Re: small clairifcation

2020-08-27 Thread David G. Johnston
On Thu, Aug 27, 2020 at 6:17 PM Tom Lane wrote: > PG Doc comments form writes: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/ssh-tunnels.html > > Description: > > > "The first number in the -L argument, 6, is the port

Re: Typo in the Section "3.6. Inheritance"

2020-08-21 Thread David G. Johnston
On Fri, Aug 21, 2020 at 4:36 PM Bruce Momjian wrote: > On Wed, Aug 5, 2020 at 11:29:31PM -0700, David G. Johnston wrote: > > > Removing "char" from the tutorial is a nice side-effect that we probably > want > > to do even if we keep "state". > >

Re: Procedures

2020-08-21 Thread David G. Johnston
On Fri, Aug 21, 2020 at 3:52 PM Bruce Momjian wrote: > > > Agreed, this doc area needs help. > > I developed the attached patach for this. Is this sufficient? > For consistency I would change "statement" to "command" at the end of that paragraph . the command. and to contrast with "a

Re: Subscript expressions do not have to evaluate to integers

2020-08-21 Thread David G. Johnston
On Fri, Aug 21, 2020 at 6:22 PM Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Jul 22, 2020 at 02:59:18AM +, PG Doc comments form wrote: > >> I believe a more appropriate statement would acknowledge that at least > some > >> values undergo an explicit-style conversion to an integer. >

Re: Create a Foreign Table for PostgreSQL CSV Logs

2020-08-21 Thread David G. Johnston
On Fri, Aug 21, 2020 at 2:58 PM Bruce Momjian wrote: > On Fri, Aug 21, 2020 at 09:25:20AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/runtime-config-logging.html > > Description: > > >

Re: Procedures

2020-08-22 Thread David G. Johnston
On Saturday, August 22, 2020, Jürgen Purtz wrote: > On 22.08.20 13:05, Robin Abbi wrote: > > On Fri, 21 Aug 2020 at 23:52, Bruce Momjian wrote: > >> I developed the attached patach for this. Is this sufficient? >> > > Would it be appropriate to consider including some language with a similar >

Re: Subscript expressions do not have to evaluate to integers

2020-08-22 Thread David G. Johnston
On Sat, Aug 22, 2020 at 8:47 AM Bruce Momjian wrote: > On Fri, Aug 21, 2020 at 07:21:30PM -0700, David G. Johnston wrote: > > On Fri, Aug 21, 2020 at 6:22 PM Tom Lane wrote: > > > > Bruce Momjian writes: > > > On Wed, Jul 22, 2020 at 02:59:18AM +

Re: Procedures

2020-08-22 Thread David G. Johnston
On Sat, Aug 22, 2020 at 10:14 AM Bruce Momjian wrote: > On Fri, Aug 21, 2020 at 07:42:35PM -0700, David G. Johnston wrote: > > > [...] the CALL command. If the CALL command is not part of an explicit > > transaction a procedure can also manage multiple transactions during

Re: Create a Foreign Table for PostgreSQL CSV Logs

2020-08-22 Thread David G. Johnston
On Sat, Aug 22, 2020 at 10:51 AM Bruce Momjian wrote: > On Fri, Aug 21, 2020 at 08:41:54PM -0700, David G. Johnston wrote: > > Adding CHECK constraints and -- > > comments to the CREATE TABLE command would be a welcome addition. In > > particular I noticed: > > >

Re: Create a Foreign Table for PostgreSQL CSV Logs

2020-08-24 Thread David G. Johnston
On Mon, Aug 24, 2020 at 6:17 AM Олег Самойлов wrote: > There must not be constraints at all. Constraints are needed to check > incoming data to the table. But here table is read-only for database! > Please don't top-post. > So all your constraints is totally useless. > > > could become: > > >

Re: Procedures

2020-08-24 Thread David G. Johnston
On Mon, Aug 24, 2020 at 9:09 AM Pavel Stehule wrote: > > > po 24. 8. 2020 v 18:00 odesílatel Bruce Momjian napsal: > >> On Mon, Aug 24, 2020 at 05:51:29PM +0200, Pavel Stehule wrote: >> > sure. Maybe enhancing about sentence like "it is not possible in a >> function." >> > >> > and >> > >> > "a

Re: PostgreSQL 12: Cryptic documentation

2020-08-15 Thread David G. Johnston
On Sat, Aug 15, 2020 at 6:58 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/app-pgbasebackup.html > Description: > > The pg_basebackup page says that the --waldir parameter "Specifies the >

Re: Inaccurate description of UNION/CASE/etc type selection

2020-08-17 Thread David G. Johnston
On Mon, Aug 17, 2020 at 8:31 AM Tom Lane wrote: > "David G. Johnston" writes: > > More concisely: > > > Make the first input type a candidate type. Each subsequent input type > is > > compared to the current candidate, with a new candidate being chosen o

Re: Please provide examples of rows from

2020-09-29 Thread David G. Johnston
On Thu, Sep 24, 2020 at 12:37 PM Bruce Momjian wrote: > On Thu, Sep 24, 2020 at 03:05:24PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Yes, this is very helpful. I was afraid the JSON would overwhelm the > > > example, but this looks good. I wrote the attached doc patch which I > >

Re: Detecting which columns a query will modify in a function called by a trigger

2020-10-02 Thread David G. Johnston
On Tue, Mar 3, 2020 at 4:19 PM David G. Johnston wrote: > On Tue, Mar 3, 2020 at 4:11 PM Adrian Klaver > wrote: > >> On 3/3/20 3:06 PM, David G. Johnston wrote: >> > On Tue, Mar 3, 2020 at 3:48 PM Adrian Klaver > > <mailto:adrian.kla...@aklaver.co

Re: Chapter 7. Queries

2020-10-02 Thread David G. Johnston
On Mon, Sep 14, 2020 at 6:03 PM David G. Johnston < david.g.johns...@gmail.com> wrote: > Given that 7.6 is named "LIMIT and OFFSET" I don't have an issue with > adding the relevant keywords (including EXCEPT and INTERSECT) in those two > places. > Patch attached.

Re: Please provide examples of rows from

2020-09-14 Thread David G. Johnston
On Thu, Sep 3, 2020 at 6:46 PM Bruce Momjian wrote: > On Wed, Apr 8, 2020 at 09:50:44PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/queries-table-expressions.html > > Description: > >

Re: Installation instructions vs binaries

2020-09-14 Thread David G. Johnston
On Tue, Sep 8, 2020 at 8:05 AM Magnus Hagander wrote: > On Tue, Sep 8, 2020 at 4:51 PM Tom Lane wrote: > >> Magnus Hagander writes: >> > I think we're talking about a different repetitiveness. If I apply >> Davids >> > suggestion to that patch, then instead of: >> >> > + >> > + If you are

Re: max_wal_size

2020-05-27 Thread David G. Johnston
On Wed, May 27, 2020 at 9:17 AM wrote: > David, > > > This setting is the indirect means to ensure that the WAL directory > > doesn't get too large by forcing a checkpoint thus allowing the > > corresponding WAL to be removed. > > > This is a soft limit, ok. > But the question is a little

Re: max_wal_size

2020-05-27 Thread David G. Johnston
On Wed, May 27, 2020 at 8:18 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/runtime-config-wal.html > Description: > > About parameter max_wal_size the documentation says that "Maximum size to >

Re: max_wal_size

2020-05-27 Thread David G. Johnston
On Wed, May 27, 2020, 14:12 wrote: > David, > > > For 0.5 you get 2/3rds consumption: ( n / ( 1 + 0.5 ) ) = n * 2/3 > > Exactly, for checkpoint_completion_target=0.5 the distance between > checkpoints is 2/3 of max_wal_size. > > But back to the documentation of max_wal_size. > "Maximum size to

Re: max_wal_size

2020-05-28 Thread David G. Johnston
On Thu, May 28, 2020 at 2:21 AM wrote: > > Now we have the glossary. According to the glossary, a checkpoint has two > meanings. > > The first meaning is that this is a point: > "A point in the WAL sequence at which it is guaranteed that the heap and > index data files have been updated with all

Re: Change JOIN tutorial to focus more on explicit joins

2020-10-21 Thread David G. Johnston
On Fri, Sep 4, 2020 at 2:36 AM Jürgen Purtz wrote: > On 04.09.20 08:52, Peter Eisentraut wrote: > > > > For the remaining patch I have a couple of concerns: > This patch should not be changing the formatting choices for these queries, just the addition of a JOIN clause and modification of the

Re: Please add best practice concerning user accounts

2020-10-20 Thread David G. Johnston
On Tue, Oct 20, 2020 at 9:08 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/postgres-user.html > Description: > > The page describes the postgres user typically used as superuser for a > PostgreSQL

Re: Additional Chapter for Tutorial

2020-10-23 Thread David G. Johnston
On Fri, Oct 23, 2020 at 6:58 AM Jürgen Purtz wrote: > Creating such a chapter in "VII. Internals" will increase the existing > chapter numbers 50 - 71, which may lead to some confusion. On the other > hand the content can possibly be applied to all supported PG versions at > the same time, which

  1   2   3   4   >