Re: [DOCS] Two fixes for plpgsql.sgml

2007-11-28 Thread Neil Conway
On Wed, 2007-11-28 at 08:17 +0100, Guillaume Lelarge wrote: > This patch fixes two issues on plpgsql.sgml. The first hunk seems like a regression to me: AFAICS the current phrasing is what is intended. *** 133,139 PL/pgSQL functions can also be declared to return ! a se

Re: [DOCS] Last patch

2007-10-10 Thread Neil Conway
On Wed, 2007-10-10 at 20:34 +0200, Guillaume Lelarge wrote: > ... for revoke.sgml. Applied, thanks. -Neil ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/

Re: [DOCS] Yet another small patch :)

2007-10-09 Thread Neil Conway
On Tue, 2007-10-09 at 15:52 +0200, Guillaume Lelarge wrote: > ... this time, for config.sgml. Applied, thanks. -Neil ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Neil Conway
On Wed, 2007-08-29 at 13:53 -0400, Tom Lane wrote: > Why wouldn't we just remove the README files altogether? I can't > see maintaining duplicate sets of documentation. I agree that duplication is bad, but I think README files in the individual contrib directories is useful and worth keeping: if

Re: [DOCS] rename of a view

2007-06-29 Thread Neil Conway
On Sat, 2007-30-06 at 01:36 -0400, Tom Lane wrote: > No objection to that; it'd square with our treatment of TYPE and DOMAIN > commands. What I'm wondering though is whether the whole patch has > a reason to live at all, as compared to documenting someplace more > prominent than now that ALTER TAB

Re: [DOCS] rename of a view

2007-06-29 Thread Neil Conway
On Sat, 2007-30-06 at 00:26 -0400, Tom Lane wrote: > There is exactly 0 chance of that happening, because it's always worked > historically. Agreed, but I think the patch should disallow ALTER VIEW ... RENAME on a non-view, and ALTER SEQUENCE ... RENAME on a non-sequence. -Neil ---

Re: [DOCS] rename of a view

2007-06-28 Thread Neil Conway
On Thu, 2007-28-06 at 13:31 +0200, Susanne Ebrecht wrote: > Than I just tried: alter table pgview rename to bettername; > > that works, but there is no hint at the documentation, that you can > rename a view via alter table. >From the ALTER TABLE reference page: "The RENAME forms change the nam

Re: [PATCHES] [DOCS] Autovacuum and XID wraparound

2007-05-15 Thread Neil Conway
On Tue, 2007-15-05 at 09:07 -0400, Alvaro Herrera wrote: > I agree, the note should be added there (but it should be a short one > and refer the reader someplace else for more complete details). I've applied the attached patch to HEAD and REL8_2_STABLE. -Neil Index: doc/src/sgml/config.sgml

Re: [PATCHES] [DOCS] Autovacuum and XID wraparound

2007-05-14 Thread Neil Conway
On Mon, 2007-14-05 at 16:22 -0400, Bruce Momjian wrote: > I agree with Tom. I don't think the current behavior is a major issue > for users for it to be mentioned more than it already is Are you really suggesting that we shouldn't modify config.sgml to note that "autovacuum = off" does not actual

Re: [PATCHES] [DOCS] OS/X startup scripts

2007-05-13 Thread Neil Conway
On Sun, 2007-13-05 at 18:58 -0700, David Fetter wrote: > cvs diff works just great until you want to add or remove a file > without write permissions to the CVS repository, i.e. when you've > checked out as anonymous. Personally, I usually work against a checkout from a local mirror of the CVS rep

Re: [PATCHES] [DOCS] Autovacuum and XID wraparound

2007-05-13 Thread Neil Conway
On Sun, 2007-13-05 at 22:06 -0400, Tom Lane wrote: > This fact is already documented in at least three places; do we really > need two more? I think we need to at least modify the documentation for the autovacuum GUC parameter, which currently states only that it "controls whether the server shoul

Re: [DOCS] row-level stats and last analyze time

2007-05-03 Thread Neil Conway
On Thu, 2007-26-04 at 18:07 -0400, Neil Conway wrote: > (1) I believe the reasoning for Tom's earlier change was not to reduce > the I/O between the backend and the pgstat process [...] Tom, any comments on this? Your change introduced an undocumented regression into 8.2. I think yo

Re: [DOCS] patch for doubled words

2007-05-03 Thread Neil Conway
On Thu, 2007-03-05 at 15:32 +0100, Brian Gough wrote: > Here is a patch for some doubled words in the manual > (e.g. "the the"). Applied, thanks for the patch. -Neil ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send a

[DOCS] Doc tweak: remove outdated discussion of stats params

2007-04-26 Thread Neil Conway
Attached is a patch that removes a now-false statement from the documentation: stats_row_level is enabled by default in HEAD, so the stats traffic in the default configuration is not necessarily small. I just removed the whole paragraph; anyone want to argue we should rephrase the paragraph instead

Re: [DOCS] row-level stats and last analyze time

2007-04-26 Thread Neil Conway
On Tue, 2007-04-24 at 17:38 -0400, Neil Conway wrote: > which included other modifications to reduce the pgstat I/O volume in > 8.1. I don't think this particular change was wise I looked into this a bit further: (1) I believe the reasoning for Tom's earlier change was not t

[DOCS] row-level stats and last analyze time

2007-04-24 Thread Neil Conway
[ CC'ing -hackers ] On Sun, 2007-04-22 at 16:10 +0200, Guillaume Lelarge wrote: > This patch adds a sentence on monitoring.sgml explaining that > stats_row_level needs to be enabled if user wants to get last > vacuum/analyze execution time. This behavior was introduced in r1.120 of postmaster/p

Re: [DOCS] Patch for monitoring.sgml

2007-04-24 Thread Neil Conway
BTW, context diffs (diff -c) are preferred. For SGML patches, unified diffs (diff -u) are okay as well. On Sun, 2007-04-22 at 16:10 +0200, Guillaume Lelarge wrote: > This patch adds a sentence on monitoring.sgml explaining that > stats_row_level needs to be enabled if user wants to get last > va

Re: [DOCS] uuid type not documented

2007-04-10 Thread Neil Conway
On Tue, 2007-04-10 at 17:24 +0200, Peter Eisentraut wrote: > The new uuid type is lacking documentation. We had also talked about including some UUID generation functionality in 8.3, but it should be okay to leave that for 8.4. -Neil ---(end of broadcast)---

Re: [DOCS] 14.4 If You Are Upgrading - Suggested Improvements

2007-01-26 Thread Neil Conway
On Sat, 2007-01-20 at 16:48 -0600, Thomas F. O'Connell wrote: > I've done a number of upgrades of postgres from one minor release to > another, and unless I'm missing something, there's nothing anywhere in > section 14 that provides documentation on how to do this. > Just a suggestion. If this str

Re: [DOCS] Cross-referencing

2006-08-09 Thread Neil Conway
On Wed, 2006-08-09 at 15:29 -0500, Jim Nasby wrote: > It's always bugged me that the docs don't do a better job of cross- > referencing things. IE: if a webpage mentions pg_start_backup(), that > mention should be a link to the documentation for that function. > > Is there a historical reason

Re: [DOCS] vacuum and routine maintenance docs

2006-01-19 Thread Neil Conway
On Wed, 2006-01-18 at 17:24 -0800, Joshua D. Drake wrote: > Why is Managing Database and Routine Database Management separate? I assume you mean the "Managing Databases" and "Routine Database Maintenance Tasks" chapters. I think these chapters are separate because they address fairly different sub

Re: [DOCS] [PATCHES] Partitioning docs

2005-11-02 Thread Neil Conway
On Wed, 2005-02-11 at 19:55 +, Simon Riggs wrote: > Trying to identify which bit of advice you refer to I put some > comments in based upon feedback from the beta on specific queries that > were not optimised the same as non-inherited tables. ISTM that query optimization *always* works dif

Re: [DOCS] [PATCHES] Partitioning docs

2005-10-31 Thread Neil Conway
On Mon, 2005-31-10 at 23:15 -0500, Tom Lane wrote: > I'd argue for editing first and then applying. I'll take up the job > if you don't have time for the editing part Okay. I'll do a round of copy editing and then commit to CVS -- there will likely be room for additional improvements, so once it

Re: [DOCS] [PATCHES] Partitioning docs

2005-10-31 Thread Neil Conway
On Mon, 2005-31-10 at 22:41 +, Simon Riggs wrote: > I believe this is now complete and ready for application. The changes need a fair bit of copy editing and SGML policy work, but that is probably easier to do once it has been applied. Barring any objections I'll apply the patch within 24 hour

Re: [DOCS] Confusing names

2005-10-20 Thread Neil Conway
On Thu, 2005-20-10 at 22:21 +0100, Simon Riggs wrote: > I like very much the split of that into two sections, but I think the > new chapter names are somewhat confusing. Yeah, I wasn't really sure about how to name them myself. > My proposal would be to rename the chapters called > > Serve

Re: [DOCS] COPY example for partial tables

2005-10-12 Thread Neil Conway
On Wed, 2005-12-10 at 10:55 -0400, Bruce Momjian wrote: > > +To copy into a file just the countries whose names start with 'A' > +using a temporary table which is automatically deleted: > + > + > + BEGIN; > + CREATE TEMP TABLE a_list_COUNTRIES AS > + SELECT * FROM country WHERE

Re: [DOCS] [PATCHES] Clarifying Autovacuum docs in the release notes

2005-09-12 Thread Neil Conway
David Fetter wrote: *** *** 173,179 Integrating autovacuum into the server allows it to be automatically started and stopped in sync with the database server, and allows autovacuum to be configured from ! postgresql.conf.

Re: [DOCS] [PATCHES] Doc patch: New PL/Perl Features

2005-07-12 Thread Neil Conway
David Fetter wrote: On Tue, Jul 12, 2005 at 12:21:29PM -0700, David Fetter wrote: Folks, Please find enclosed document patches for PL/Perl features recently introduced in CVS TIP. These include: return_next returning PostgreSQL arrays spi_query/spi_fetchrow use strict Cheers, D Oops. Pe

Re: [DOCS] process hangs when converting sgml documentation to PDF

2005-06-07 Thread Neil Conway
Saquib Farooq Malik wrote: openjade -D . -c /usr/share/sgml/docbook/dsssl-stylesheets/catalog -d stylesheet.dsl -t tex -V tex-backend -i output-print -V texpdf-output -o postgres.tex-pdf postgres.sgml and that's it, the prompt never comes back. Some people have reported extremely long build

Re: [DOCS] punctuation in function tables

2005-05-22 Thread Neil Conway
Neil Conway wrote: The function definition tables in func.sgml use punctuation inconsistently: some descriptions are terminated by a period, some are not. Is there any opinion on which variant is "correct"? I ended up not including a period in single-sentence function descriptions,

Re: [DOCS] [patch] Typo in ECPG Docs

2005-05-20 Thread Neil Conway
Andreas Seltenreich wrote: I just stumbled across a spurious indefinite article in the ECPG docs. See the attached patch. Patch applied to HEAD and REL8_0_STABLE. Thanks for the patch. Speaking of indefinite articles, there seems to be some inconsistency in using "a SQL ..." and "an SQL ..." throug

Re: [DOCS] create rule syntax

2005-05-20 Thread Neil Conway
Robert Treat wrote: Sorry I missed this before, but the first examples use of create rule on *object* rather than *table* seems like something important enough to keep, since obviously rules can be on more than just tables. I can't get too excited about this. CREATE RULE uses "table" as well, a

Re: [DOCS] Add cross references for CREATE FUNCTION to PLs

2005-05-19 Thread Neil Conway
David Fetter wrote: Please find enclosed a patch which adds cross-references to the CREATE FUNCTION syntax in the PL/* docs. I thought the PL/PgSQL hunk wasn't an appropriate place for an , so I didn't apply that. The rest of the patch was applied with minor edits -- thanks for the patch. -Neil

[DOCS] punctuation in function tables

2005-05-19 Thread Neil Conway
The function definition tables in func.sgml use punctuation inconsistently: some descriptions are terminated by a period, some are not. Is there any opinion on which variant is "correct"? If not, I'll update the docs so that sentences in descriptions are separated by periods, rather than termin

Re: [DOCS] create rule syntax

2005-05-19 Thread Neil Conway
Kris Jurka wrote: The manual shows slightly different variations for the create rule syntax here and here: http://www.postgresql.org/docs/8.0/static/rules-update.html http://www.postgresql.org/docs/8.0/static/sql-createrule.html The attached patches makes the first look like the second. Applied, th

Re: [DOCS] question about markup

2005-03-01 Thread Neil Conway
Robert Treat wrote: someone suggested that the insert command at the end of http://wwwmaster.postgresql.org/docs/8.0/interactive/dml.html would be better if it were a link like the copy command is. Is there some reason not to make it a link? No particular reason. I've applied the following pat

Re: [DOCS] Minor corrections in xfunc.sgml

2005-02-20 Thread Neil Conway
Hashem Masoud wrote: This patch corrects typos in xfunc.sgml [...] Thanks; typos fixed in HEAD and REL8_0_STABLE. -Neil ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Re: [DOCS] raise not in index

2005-02-09 Thread Neil Conway
On Wed, 2005-02-09 at 15:38 +0100, Rainer Brandt wrote: > a suggestion for a small improvement in the 8.0 manual: > > The term 'raise' (see section 35.9) is not in the index. Thanks for the suggestion; I've applied the attached patch to CVS HEAD. -Neil Index: doc/src/sgml/plpgsql.sgml =

Re: [DOCS] planner stats

2005-02-02 Thread Neil Conway
On Wed, 2005-02-02 at 11:02 +0100, Roman Neuhauser wrote: > the SET STATISTICS description under ALTER TABLE doesn't explain how > to choose the right target (is there a formula?) There's no simple formula; in particular, it's not merely a matter of raising the target for the columns of a large ta

Re: [DOCS] Documentation of server configuration

2004-11-14 Thread Neil Conway
On Sun, 2004-11-14 at 16:25 +, Simon Riggs wrote: > For me, this section is the No.1 most hit section of the manual. I agree that this section is frequently accessed. Given that, I think it is somewhat difficult to find -- we've all memorized that it is in the "Server Run-time Environment" cha

Re: [DOCS] PostgreSQL 8.0.0beta3 Documentation

2004-10-24 Thread Neil Conway
On Sat, 2004-10-23 at 21:30, stig erikson wrote: > http://developer.postgresql.org/docs/postgres/index.html > third line: Copyright © 1996-2003 > > suggest change to: Copyright © 1996-2004 Fixed. Thanks! Bruce: I updated RELEASE_CHANGES so that this isn't forgotten in the future. If I have done

Re: [DOCS] SQL 2003 conformance

2004-10-17 Thread Neil Conway
On Wed, 2004-10-13 at 03:52, Peter Eisentraut wrote: > Is anyone feeling masochistic and wants to review the SQL standards > conformance chapter in the documentation for SQL 2003? Another useful improvement would be to update the "Standards conformance" section of the SQL command reference pages

Re: [DOCS] Add tablespace index entry

2004-09-29 Thread Neil Conway
On Thu, 2004-09-30 at 13:58, Alvaro Herrera wrote: > Cool! Please apply this one as well ;-) Patch applied, with some editorializing. Thanks! -Neil ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if yo

Re: [DOCS] Add tablespace index entry

2004-09-29 Thread Neil Conway
On Wed, 2004-09-29 at 23:21, Kris Jurka wrote: > This adds an index entry for tablespaces which is tricky to find > otherwise. Patch applied -- thanks! (FWIW, adding index entries for stuff is a pretty easy TODO item, if anyone's looking for something worth contributing...) -Neil ---

Re: [DOCS] Minor Typo in SELECT docs

2004-09-12 Thread Neil Conway
On Sat, 2004-09-11 at 02:41, Thomas F.O'Connell wrote: > Well, here's a patch for select.sgml should a committer ever feel > inspired: Patch applied -- thanks. -Neil ---(end of broadcast)--- TIP 6: Have you searched our list archives?

Re: [DOCS] Minor Typo in SELECT docs

2004-09-09 Thread Neil Conway
Tom Lane wrote: There are a lot of typos besides this one, and always have been. Personally I'd rather spend the time proofing current docs. Also, there's been a tendency in the past to not regenerate the online docs for each point release in a stable branch (particularly for formats like PS and

Re: [DOCS] Minor Typo in SELECT docs

2004-09-09 Thread Neil Conway
Thomas F.O'Connell wrote: There is a reference to the "sql_interitance" configuration in the 7.4.x docs: Since it's fixed in HEAD, I think we're fine -- we usually don't bother applying documentation fixes to release branches, even if there were plans for another 7.4.x release. -Neil --

[DOCS] adding GUC variable xrefs

2004-03-06 Thread Neil Conway
I'm planning to replace most of the tags enclosing GUC variables in the docs with tags that allow the user to directly jump to the documentation for that particular configuration variable (that also requires adding "id" and "xreflabel" attributes to the GUC var documentation). The "xreflabel"

Re: [DOCS] [HACKERS] initdb should create a warning message [was Re:

2003-12-01 Thread Neil Conway
Oliver Elphick <[EMAIL PROTECTED]> writes: > The use of the word "log" in the directory name does tend to invite > this error, and some have acted on it without asking first. I think > initdb should put a README.IMPORTANT file in $PGDATA to say [...] If someone deletes something from $PGDATA with