Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

On Fri, Nov 17, 2017 at 11:00 AM, Michael Paquier wrote: > On Thu, Nov 16, 2017 at 8:17 PM, Masahiko Sawada > wrote: >> On Thu, Nov 16, 2017 at 1:11 PM, Michael Paquier >> wrote: >>> + /* >>> +* Quick exit if

Re: no library dependency in Makefile?

2017-11-20 2:25 GMT+08:00 Tom Lane : > =?UTF-8?B?6auY5aKe55Cm?= writes: > > I very much look forward to hearing everyone's views on this issue. > > If the solution mentioned before is ok, I will start to complete it. > > Please don't top-post, it makes the

Allowing SSL connection of v11 client to v10 server with SCRAM channel binding

HI all, When a client connects during a SCRAM exchange, it has multiple ways to let the server know what the client supports or not when using channel binding: - "n" -> client doesn't support channel binding. - "y" -> client does support channel binding but thinks the server does not. - "p" ->

Re: [HACKERS] [PATCH] A hook for session start

Michael Paquier writes: > On Mon, Nov 20, 2017 at 12:11 PM, Tom Lane wrote: >> The stuff related to AuxProcType is in miscadmin.h, so one possibility >> is to put the new enum there. But I could see inventing a whole new >> header for this,

Re: [HACKERS] [PATCH] A hook for session start

On Mon, Nov 20, 2017 at 12:11 PM, Tom Lane wrote: > This is really about consolidating a whole bunch of ad-hoc stuff. > I don't think pgstat has any particular pride of place here. It > should be one consumer of a common API. > > The stuff related to AuxProcType is in

Re: [HACKERS] [PATCH] A hook for session start

Michael Paquier writes: > I was the one suggesting to Fabrizio to look at how backend types are > evaluated in pgstat.c after an off-list discussion. Agreed that this > result is fragile as this makes two places dependent on the process > types. Why not simply moving

Re: [HACKERS] CUBE seems a bit confused about ORDER BY

On 10/30/2017 03:04 PM, Alexander Korotkov wrote: > On Sun, Oct 29, 2017 at 1:30 AM, Alexander Korotkov > > wrote: ... > > Thus, I heard no objection to my approach.  Attached patch changes ~> > operator in the proposed way and fixes

RE: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

>> I spent a little more time looking at this patch today. I think that the >> patch >> should actually send NegotiateProtocolVersion when *either* the requested >> version is differs from the latest one we support *or* an unsupported >> protocol >> option is present. Otherwise, you only find

Re: [HACKERS] GnuTLS support

Hi, On 11/02/2017 11:33 PM, Andreas Karlsson wrote: > On 09/18/2017 07:04 PM, Jeff Janes wrote:> You fixed the first issue, > but I still get the second one: >> >> be-secure-gnutls.c: In function 'get_peer_certificate': >> be-secure-gnutls.c:667: error: 'GNUTLS_X509_CRT_LIST_SORT' undeclared >>

RE: Speed up the removal of WAL files

Thanks, it seems to require a bit more consideration about RemoveOldXLogFiles(). Let me continue this next month. Regards Takayuki Tsunakawa > -Original Message- > From: Michael Paquier [mailto:michael.paqu...@gmail.com] > Sent: Saturday, November 18, 2017 10:37 PM > To: Fujii Masao

Re: [HACKERS] Custom compression methods

On 11/15/2017 02:13 PM, Robert Haas wrote: > On Wed, Nov 15, 2017 at 4:09 AM, Ildus Kurbangaliev > wrote: >> So in the next version of the patch I can just unlink the options from >> compression methods and dropping compression method will not affect >> already

Re: [HACKERS] Custom compression methods

Hi, On 11/14/2017 02:23 PM, Ildus Kurbangaliev wrote: > > ... > > Attached version 4 of the patch. Fixed pg_upgrade and few other bugs. > I did a review of this today, and I think there are some things that need improvement / fixing. Firstly, some basic comments from just eye-balling the diff,

Re: [HACKERS] [PATCH] A hook for session start

On 11/19/2017 04:49 PM, Tom Lane wrote: > Andrew Dunstan writes: >> I think this: >> #define IsClientBackend() \ >>     (MyBackendId != InvalidBackendId &&    \ >> !IsAutoVacuumLauncherProcess() &&    \ >> !IsAutoVacuumWorkerProcess() &&

Re: [HACKERS] [PATCH] A hook for session start

Andrew Dunstan writes: > I think this: > #define IsClientBackend() \ >     (MyBackendId != InvalidBackendId &&    \ > !IsAutoVacuumLauncherProcess() &&    \ > !IsAutoVacuumWorkerProcess() && \ > !am_walsender && \ >

Re: [HACKERS] [PATCH] A hook for session start

On 11/16/2017 10:38 PM, Fabrízio de Royes Mello wrote: > Hi all, > > Attached new version of the patch fixing issues about installcheck and > some assertions reported before (based on Michael Paquier code): > >

Re: [HACKERS] [PATCH] Incremental sort

On Wed, Nov 15, 2017 at 7:42 AM, Alexander Korotkov wrote: > Sure, please find rebased patch attached. + /* + * Check if first "skipCols" sort values are equal. + */ + static bool + cmpSortSkipCols(IncrementalSortState *node, TupleTableSlot *a, +

Re: percentile value check can be slow

On 19.11.2017 18:49, David Fetter wrote: On Sun, Nov 19, 2017 at 01:23:42PM +0100, Tomas Vondra wrote: Hi, On 11/19/2017 03:10 AM, David Fetter wrote: On Sat, Nov 18, 2017 at 11:05:47PM +0100, Tomas Vondra wrote: Hi, ... Is 'recognizer' an established definition I should know? Is it the

Re: [HACKERS] [PATCH] Improve geometric types

> dist_pl is changed to take the smaller distance of both ends of > the segment. It seems absorbing error, so it might be better > taking the mean of the two distances. If you have a firm reason > for the change, it is better to be written there, or it might be > better left alone. I am sorry for

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

Hello Fabien, Sorry for not respondingfor long time. > Two typos: > - "usinng" -> "using" > - "a rejection method used" -> "a rejection method is used" > > I'm not sure of "least_recently_used_i", this naming style is not used in > pgbench. "least_recently_used" would be ok. > >

Re: Patch to add dependency between client executes and static libraries

=?UTF-8?B?6auY5aKe55Cm?= writes: > The attached patch trying to add dependency between client executes > and static libraries. If this is intended to solve the problem described in then it should be

Re: [HACKERS] [PATCH] Generic type subscripting

On Thu, Nov 16, 2017 at 10:37:40PM +0100, Dmitry Dolgov wrote: > I had hard time parsing this, but from your examples I assume you're talking > about passing little bit different arguments to `fetch` function (am I > right?). Yes, I meant to pass the following arguments: Datum source,

Re: [HACKERS] Bug in to_timestamp().

On Sat, Nov 18, 2017 at 05:48:26PM -0500, Tom Lane wrote: > This patch needs a rebase over the formatting.c fixes that have gone > in over the last couple of days. > > Looking at the rejects, I notice that in your changes to parse_format(), > you seem to be making it rely even more heavily on

Re: percentile value check can be slow

Hi, On 11/19/2017 03:10 AM, David Fetter wrote: > On Sat, Nov 18, 2017 at 11:05:47PM +0100, Tomas Vondra wrote: >> Hi, >> >> ... >> >> Is 'recognizer' an established definition I should know? Is it the same >> as 'validator' or is it something new/different? > > I borrowed it from

Patch to add dependency between client executes and static libraries

Hi, all The attached patch trying to add dependency between client executes and static libraries. As described in message: