> On 22 Feb 2018, at 05:10, Tom Lane wrote:
>
> I wrote;
>> Daniel Gustafsson writes:
>>> I also (again) forgot about the # comments not being allowed inside setup
>>> and
>>> teardown blocks, so patch 0002 proposes adding support for these as the
>>> documentation implies.
>
>> Hmm, not sure
> On 22 Feb 2018, at 05:12, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> On 21 Feb 2018, at 21:41, Tom Lane wrote:
>>> I can't think of one; but I wonder if it's worth working a bit harder and
>>> removing the fixed limit altogether, probably by using a PQExpBuffer.
>>> If you've hit 1024 t
Hi,
I have a question of how to use pg_rewind.
I see the manual. It says bringing an old master server back online after
failover is typical case.
manual:
A typical scenario is to bring an old master server back online after
failover, as a standby that follows the new master.
I came up with
On Wed, Feb 21, 2018 at 6:07 AM, Robert Haas wrote:
> On Tue, Feb 13, 2018 at 5:42 AM, Masahiko Sawada
> wrote:
>>> The fdw-transactions section of the documentation seems to imply that
>>> henceforth every FDW must call FdwXactRegisterForeignServer, which I
>>> think is an unacceptable API brea
On Thu, Feb 15, 2018 at 3:27 AM, Peter Eisentraut
wrote:
> Here is a patch with a test suite for the Kerberos/GSSAPI authentication
> functionality. It's very similar in principle to the recently added
> LDAP tests, and similar caveats apply.
+not run by default. You might need to adjust some p
> On 27 Feb 2018, at 11:10, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>>> On 27 Feb 2018, at 05:25, Tom Lane wrote:
>>> BTW, I noticed while doing this that the adjacent "funny_dup17"
>>> trigger is dead code, and has been since commit 1547ee01 of
>>> 1999-09-29. I'm inclined to rip it out
Patrick,
>> Sure, although leaving a commit message with a pointer to the fix in git
>> would document this better.
>
> Right. We should always do that.
Would you like to do this yourself? Or shall I do this?
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/ind
On Wed, Feb 14, 2018 at 09:27:04AM -0500, Peter Eisentraut wrote:
> Here is a patch with a test suite for the Kerberos/GSSAPI authentication
> functionality. It's very similar in principle to the recently added
> LDAP tests, and similar caveats apply.
>
> You will need the client and server parts
From: Michael Paquier [mailto:mich...@paquier.xyz]
> By the way, as long as I have my mind of it. Another strategy would be
> to just make the checks in XLogReadRecord() a bit smarter if the whole record
> header is not on the page. If we check at least for
> AllocSizeIsValid(total_len) then ther
On 2018/02/27 3:27, Robert Haas wrote:
> On Sun, Feb 25, 2018 at 11:10 PM, Amit Langote
> wrote:
>> I think I'm convinced that partopcintype OIDs can be used where I thought
>> parttypid ones were necessary. The pruning patch uses the respective OID
>> from this array when extracting the datum fr
> Sure, although leaving a commit message with a pointer to the fix in git
> would document this better.
Right. We should always do that.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
Tatsuo Ishii writes:
> I would prefer to mark it done then remove the item just for leaving
> an editing history.
Sure, although leaving a commit message with a pointer to the fix in git
would document this better.
regards, tom lane
Daniel Gustafsson writes:
>> On 27 Feb 2018, at 05:25, Tom Lane wrote:
>> BTW, I noticed while doing this that the adjacent "funny_dup17"
>> trigger is dead code, and has been since commit 1547ee01 of
>> 1999-09-29. I'm inclined to rip it out, because anyone looking
>> at regress.c would natural
On Mon, Feb 26, 2018 at 02:03:19PM -0500, Tom Lane wrote:
> I'm not sure that other patch will get in; AFAICS it's incomplete and
> rather controversial. But I guess we could put this issue on the
> open-items list so we don't forget.
+1. We already know that we want to do a switch to prokind an
> I think that, back when we were actively maintaining the TODO list,
> the idea was that items got marked as "Done" when committed and then
> removed from the list after the fix was released. In this case, since
> the fix went out years ago, we might as well just remove the entry
> immediately.
Tatsuo Ishii writes:
> Ok, let's mark it as "Done.", (rather than removing it) if there's no
> objection.
I think that, back when we were actively maintaining the TODO list,
the idea was that items got marked as "Done" when committed and then
removed from the list after the fix was released. In
On Mon, Feb 26, 2018 at 05:38:56PM +, Greg Stark wrote:
> I tried loading the jsonlog module from
> https://github.com/michaelpq/pg_plugins into Postgres 9.6.
>
> However it seems it resulted in logs only for session log messages but
> not any background worker log messages. We have log_checkp
Thanks Tom.
On Tue, Feb 27, 2018 at 2:55 AM, Tom Lane wrote:
> I wrote:
> > I wonder whether it is worth creating a C trigger function
> > (probably in regress.c) specifically to exercise this situation.
>
> Actually, that doesn't seem too bad at all. I propose applying
> and back-patching the
On Tue, Feb 27, 2018 at 4:18 AM, Tom Kazimiers wrote:
> On Mon, Feb 26, 2018 at 11:15:44PM +1300, Thomas Munro wrote:
>> On Sat, Feb 24, 2018 at 4:47 PM, Tom Kazimiers
>> wrote:
>> Thanks for the reproducer. Yeah, that seems to be a bug.
>> nodeNamedTuplestorescan.c allocates a new read pointer
> On Mon, Feb 26, 2018 at 4:54 PM, Tatsuo Ishii wrote:
>>> It appears this was fixed back in 2014 with 750c5ee. I propose for it
>>> to be removed from the TODO list.
>>
>> Yes, I confirmed it by using Ubuntu + libedit. I have not tested it on
>> Mac OS X yet though.
>>
>> Best regards,
>> --
>> T
On Mon, Feb 26, 2018 at 02:03:56PM -0500, Tom Lane wrote:
> David Steele writes:
> > I'm planning to fill the CFM role, unless there are objections.
>
> Thanks for volunteering!
+1. I have also added a new commit fest entry marked as future, which
will likely be used for 12 development:
https:/
On Mon, Feb 26, 2018 at 4:54 PM, Tatsuo Ishii wrote:
>> It appears this was fixed back in 2014 with 750c5ee. I propose for it
>> to be removed from the TODO list.
>
> Yes, I confirmed it by using Ubuntu + libedit. I have not tested it on
> Mac OS X yet though.
>
> Best regards,
> --
> Tatsuo Ishii
> On 27 Feb 2018, at 05:25, Tom Lane wrote:
>
> I wrote:
>> I wonder whether it is worth creating a C trigger function
>> (probably in regress.c) specifically to exercise this situation.
>
> Actually, that doesn't seem too bad at all. I propose applying
> and back-patching the attached.
LGTM
On Tue, Feb 27, 2018 at 1:44 AM, Claudio Freire wrote:
> On Mon, Feb 26, 2018 at 1:32 PM, Claudio Freire
> wrote:
>> On Mon, Feb 26, 2018 at 11:31 AM, Claudio Freire
>> wrote:
>>> On Mon, Feb 26, 2018 at 6:00 AM, Masahiko Sawada
>>> wrote:
Here is review comment for v4 patch.
On Mon, Feb 26, 2018 at 01:22:01PM +, Vasundhar Boddapati wrote:
> I have gone through the comments, both look straight forward to go
Thanks for the input. Please note that this has been pushed already as
the following commit:
commit: 5c15a54e851ecdd2b53e6d6a84f8ec0802ffc3cb
author: Magnus Ha
> It appears this was fixed back in 2014 with 750c5ee. I propose for it
> to be removed from the TODO list.
Yes, I confirmed it by using Ubuntu + libedit. I have not tested it on
Mac OS X yet though.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
J
On Tue, Feb 13, 2018 at 7:47 PM, Thomas Munro
wrote:
> One way to avoid all that might be to use pseudo page numbers that
> don't suffer from splits. I don't know how you'd choose the
> constant, but it could be something like pseudo page number = hash
> value % 1024. In other words, you'd use
It appears this was fixed back in 2014 with 750c5ee. I propose for it
to be removed from the TODO list.
Thanks,
Patrick
On Mon, Feb 26, 2018 at 11:28 PM, Andres Freund wrote:
> So RTLD_LOCAL is out of the question, but I think we can get a good bit
> of the benefit by either specifying -Wl,-Bsymbolic at shlib build time,
> or RTLD_DEEPBIND at dlopen() time. Either leads to the opened shared
> library effectively b
On 2018-02-23 11:05:23 -0500, Tom Lane wrote:
> Andres Freund writes:
> > I think using RTLD_LOCAL on most machines would be a much better
> > idea. I've not found proper explanations why GLOBAL is used. We started
> > using it ages ago, with [2], but that commit contains no explanation,
> > and a
I wrote:
> I wonder whether it is worth creating a C trigger function
> (probably in regress.c) specifically to exercise this situation.
Actually, that doesn't seem too bad at all. I propose applying
and back-patching the attached.
BTW, I noticed while doing this that the adjacent "funny_dup17"
On Mon, Feb 26, 2018 at 11:29 AM, Tom Lane wrote:
> Chapman Flack writes:
> > The 0002-*.patch is a proof-of-concept patching float4_numeric and
> > float8_numeric in the trivial way (just using FLT_DECIMAL_DIG and
> > DBL_DECIMAL_DIG in place of FLT_DIG and DBL_DIG). It makes the new
> > regres
Chapman Flack writes:
> I wonder if an alternative to making a cast that can't be immutable,
> because it looks at a GUC, could be to offer a choice of cast
> functions: if you need the other behavior, create a schema, do a
> CREATE CAST in it, and put it on your search path ahead of pg_catalog.
Rushabh Lathia writes:
> In ExecBRUpdateTriggers(), we need to add a check that if trigtuple is same
> as newtuple, then we don't require to free the trigtuple.
Hm. Seems like this is a very old bug: it's always been legal for a
trigger to return the "old" tuple if it felt like it, even if plpgs
On 02/26/2018 01:29 PM, Tom Lane wrote:
> I think there's probably a bigger chance of complaints that
> "casting 1.1::float8 to numeric now produces some weird,
> incorrectly-rounded result" than that we make anyone happier.
Arguably, though, that's a moment that can be used to explain
exactly wh
On Mon, Feb 26, 2018 at 6:34 PM, Nikita Glukhov wrote:
> Attached 10th version of the jsonpath patches.
>
> 1. Fixed error handling in arithmetic operators.
>
>Now run-time errors in arithmetic operators are catched (added
>PG_TRY/PG_CATCH around operator's functions calls) and converted i
David Steele writes:
> I'm planning to fill the CFM role, unless there are objections.
Thanks for volunteering!
regards, tom lane
Peter Eisentraut writes:
> On 2/24/18 14:08, Tom Lane wrote:
>> I took a quick look through this and noted a few small problems; the
>> only one worth mentioning here is that you've broken psql tab completion
>> for functions and aggregates when talking to a pre-v11 server.
>> I don't think that's
On Mon, Feb 26, 2018 at 1:29 PM, Tom Lane wrote:
> The bigger question here is whether people actually want this behavioral
> change. I think there's probably a bigger chance of complaints that
> "casting 1.1::float8 to numeric now produces some weird,
> incorrectly-rounded result" than that we m
On 2/24/18 14:08, Tom Lane wrote:
> I took a quick look through this and noted a few small problems; the
> only one worth mentioning here is that you've broken psql tab completion
> for functions and aggregates when talking to a pre-v11 server.
> I don't think that's acceptable; however, since tab-
Hackers,
Just a few days left until the last Commitfest for the PG11 release begins!
I'm planning to fill the CFM role, unless there are objections.
Regards,
--
-David
da...@pgmasters.net
On 2/26/18 01:32, Daniel Gustafsson wrote:
> +replaced by a prompt string. (Write %% for a
> +literal %.) Note that the prompt string will
>
> I might be thick, but I don’t see where the %% handled?
Ah, I had broken that in my submitted patch. New patch attached.
> Also, AFAIC
Chapman Flack writes:
> The 0002-*.patch is a proof-of-concept patching float4_numeric and
> float8_numeric in the trivial way (just using FLT_DECIMAL_DIG and
> DBL_DECIMAL_DIG in place of FLT_DIG and DBL_DIG). It makes the new
> regression test pass. (It will only work under a compiler that has
>
On Sun, Feb 25, 2018 at 11:10 PM, Amit Langote
wrote:
> I think I'm convinced that partopcintype OIDs can be used where I thought
> parttypid ones were necessary. The pruning patch uses the respective OID
> from this array when extracting the datum from an OpExpr to be compared
> with the partiti
I tried loading the jsonlog module from
https://github.com/michaelpq/pg_plugins into Postgres 9.6.
However it seems it resulted in logs only for session log messages but
not any background worker log messages. We have log_checkpoints set
but there were no log messages in the json log about checkpo
On Mon, Feb 26, 2018 at 1:32 PM, Claudio Freire wrote:
> On Mon, Feb 26, 2018 at 11:31 AM, Claudio Freire
> wrote:
>> On Mon, Feb 26, 2018 at 6:00 AM, Masahiko Sawada
>> wrote:
>>> Here is review comment for v4 patch.
>>>
>>> @@ -1922,6 +1988,8 @@ count_nondeletable_pages(Relation onerel,
>>>
On Mon, Feb 26, 2018 at 11:31 AM, Claudio Freire wrote:
> On Mon, Feb 26, 2018 at 6:00 AM, Masahiko Sawada
> wrote:
>> Here is review comment for v4 patch.
>>
>> @@ -1922,6 +1988,8 @@ count_nondeletable_pages(Relation onerel,
>> LVRelStats *vacrelstats)
>> * We don't insert a va
Hi Vik,
this is my review of your patch. I hope I've ticked all the necessary
boxes.
Submission review:
Patch has context, applies cleanly, make and make check run
successfully, patch contains tests for the added functionality.
The patch doesn't seem to contain any documentation regarding the ne
On 26.02.2018 17:20, Amit Kapila wrote:
On Tue, Feb 20, 2018 at 10:34 PM, Konstantin Knizhnik
wrote:
On 20.02.2018 19:39, Simon Riggs wrote:
On 20 February 2018 at 16:07, Konstantin Knizhnik
wrote:
On 20.02.2018 14:26, Simon Riggs wrote:
Try locking the root tid rather than the TID, tha
On 26.02.2018 17:00, Amit Kapila wrote:
On Thu, Feb 15, 2018 at 9:30 PM, Konstantin Knizhnik
wrote:
Hi,
PostgreSQL performance degrades signficantly in case of high contention.
You can look at the attached YCSB results (ycsb-zipf-pool.png) to estimate
the level of this degradation.
Postgres
On Mon, Feb 26, 2018 at 11:31 AM, Claudio Freire wrote:
>>
>> + /*
>> +* If there are no indexes then we should periodically
>> vacuum the FSM
>> +* on huge relations to make free space visible early.
>> +*/
>> + if (
On Mon, Feb 26, 2018 at 6:38 AM, Jeevan Chalke
wrote:
> One idea I thought about is to memcpy the struct once we have set all
> required fields for grouped_rel so that we don't have to do similar stuff
> for partially_grouped_rel.
I think that would be a poor idea. We want to copy a few specific
On Mon, Feb 26, 2018 at 6:00 AM, Masahiko Sawada wrote:
> Here is review comment for v4 patch.
>
> @@ -1922,6 +1988,8 @@ count_nondeletable_pages(Relation onerel,
> LVRelStats *vacrelstats)
> * We don't insert a vacuum delay point here, because we have
> an
> * e
On Tue, Feb 20, 2018 at 10:34 PM, Konstantin Knizhnik
wrote:
>
>
> On 20.02.2018 19:39, Simon Riggs wrote:
>>
>> On 20 February 2018 at 16:07, Konstantin Knizhnik
>> wrote:
>>>
>>>
>>> On 20.02.2018 14:26, Simon Riggs wrote:
Try locking the root tid rather than the TID, that is at least
On Thu, Feb 15, 2018 at 9:30 PM, Konstantin Knizhnik
wrote:
> Hi,
>
> PostgreSQL performance degrades signficantly in case of high contention.
> You can look at the attached YCSB results (ycsb-zipf-pool.png) to estimate
> the level of this degradation.
>
> Postgres is acquiring two kind of heavy w
On Mon, Feb 26, 2018 at 12:36 AM, Michael Paquier wrote:
> I would be of the opinion to drop them.
+1. On this point, I am in agreement with the gentleman who wrote
http://postgr.es/m/7903.1310671...@sss.pgh.pa.us
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreS
On Thu, Feb 22, 2018 at 9:13 PM, Ahuja, Nitin wrote:
> Patch Description
> Currently, while saving the TOAST entry the call to index access method
> insert (aminsert) passed IndexInfo attribute as NULL. IndexInfo parameter
> was introduced in Postgres 10 for the aminsert method to allow caching da
On 26 February 2018 at 04:05, Anthony Communier wrote:
> Hello,
>
> It would be nice if application connected to a Postrgesql database could
> send and receive JSONB in binary. It could save some useless text
> conversion. All works could be done on application side which are often
> more scalabl
On Sun, Feb 25, 2018 at 10:51 AM, Lætitia Avrot
wrote:
> Hi all,
>
> For most beginners (and even a lot of advanced users) there is a strong
> confusion between simple VACUUM and VACUUM FULL. They think "full" is
> simply an option to the maintenance operation vacuum while it's not. It's a
> com
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:tested, passed
It works. Can be Merged.
I have gone through the comments, both look straight forward to go
2018-02-26 9:56 GMT+01:00 Lætitia Avrot :
> Although VACUUM and VACUUM FULL is different, then result is same (depends
>> on detail level) - the data files are optimized for other processing. You
>> should to see a VACUUM like family of commands that does some data files
>> optimizations. VACUUM,
Hello Charles,
> I saw PostgreSQL is selected in GSOC 2018 and pretty interested in the
> ideas of thrift data types support that proposed by you. So, I want to
> prepare for a proposal based on this idea.
Glad you are interested in this project!
> Can I have more detailed information of what do
(2018/02/23 16:38), Amit Langote wrote:
On Thu, Feb 22, 2018 at 8:49 PM, Etsuro Fujita
wrote:
This would introduce an asymmetry (we can move tuples from plain partitions
to foreign partitions, but the reverse is not true), but I am thinking that
it would be probably okay to document about that
Hi,
In a multi-level partitioned table, a parent whole-row reference gets
translated into nested ConvertRowtypeExpr with child whole-row
reference as the leaf. During the execution, the child whole-row
reference gets translated into all all intermediate parents' whole-row
references, ultimately rep
Hi Robert,
On Fri, Feb 23, 2018 at 2:53 AM, Robert Haas wrote:
> On Thu, Feb 8, 2018 at 8:05 AM, Jeevan Chalke
> wrote:
> > In this attached version, I have rebased my changes over new design of
> > partially_grouped_rel. The preparatory changes of adding
> > partially_grouped_rel are in 0001.
Hello Daniel,
This patch implements csv as an output format in psql
(\pset format csv). It's quite similar to the unaligned format,
except that it applies CSV quoting rules (obviously!) and that
it prints no footer and no title.
As with unaligned, a header with column names is output unless
tup
Hello,
It would be nice if application connected to a Postrgesql database could
send and receive JSONB in binary. It could save some useless text
conversion. All works could be done on application side which are often
more scalable than database itself.
Regards,
Anthony Communier
On Mon, Feb 26, 2018 at 08:13:02AM +, Tsunakawa, Takayuki wrote:
> From: Michael Paquier [mailto:mich...@paquier.xyz]
>> Your patch is able to fix that. I have also checked that after diverging
>> the promoted server with more data and inserting data on the old primary
>> then the correct set
On Mon, Feb 26, 2018 at 05:08:49PM +0900, Michael Paquier wrote:
> This was mentioned back in 2001 by the way, but this did not count much
> for the case discussed here:
> https://www.postgresql.org/message-id/24901.995381770%40sss.pgh.pa.us
> The issue here is that the streaming case makes it easi
On Tue, Feb 20, 2018 at 5:04 PM, Masahiko Sawada wrote:
> On Fri, Feb 16, 2018 at 5:00 AM, Claudio Freire
> wrote:
>> On Thu, Feb 15, 2018 at 4:47 PM, Claudio Freire
>> wrote:
>>> On Wed, Feb 14, 2018 at 3:59 AM, Masahiko Sawada
>>> wrote:
>>
> The final FSM vacuum pass isn't partial, to
>
> Although VACUUM and VACUUM FULL is different, then result is same (depends
> on detail level) - the data files are optimized for other processing. You
> should to see a VACUUM like family of commands that does some data files
> optimizations. VACUUM, VACUUM FULL, VACUUM FREEZE, VACUUM ANALYZE,
On Fri, Feb 23, 2018 at 2:20 AM, Robert Haas wrote:
> On Fri, Feb 16, 2018 at 5:56 AM, Alexander Korotkov
> wrote:
> > BTW, EnterpriseDB announces zheap table access method (heap with undo
> log)
> > [2]. I think this is great, and I'm looking forward for publishing
> zheap in
> > mailing lists
From: Michael Paquier [mailto:mich...@paquier.xyz]
> Your patch is able to fix that. I have also checked that after diverging
> the promoted server with more data and inserting data on the old primary
> then the correct set of blocks from the tablespace is fetched as well by
> pg_rewind. This pat
On Mon, Feb 26, 2018 at 07:25:46AM +, Tsunakawa, Takayuki wrote:
> From: Michael Paquier [mailto:mich...@paquier.xyz]
>> The WAL receiver approach also has a drawback. If WAL is streamed at full
>> speed, then the primary sends data with a maximum of 6 WAL pages.
>> When beginning streaming wi
75 matches
Mail list logo
