Re: Strange failure in LWLock on skink in REL9_5_STABLE

2018-09-21 Thread Amit Kapila
On Sat, Sep 22, 2018 at 2:28 AM Andres Freund wrote: > > On 2018-09-22 08:54:57 +1200, Thomas Munro wrote: > > On Fri, Sep 21, 2018 at 4:43 PM Tom Lane wrote: > > > Thomas Munro writes: > > > > On Fri, Sep 21, 2018 at 4:06 PM Tom Lane wrote: > > > >> Why would we fix it rather than just

Re: [HACKERS] proposal: schema variables

2018-09-21 Thread Pavel Stehule
pá 21. 9. 2018 v 21:46 odesílatel Arthur Zakirov napsal: > On Wed, Sep 19, 2018 at 04:36:40PM +0200, Pavel Stehule wrote: > > ON COMMIT DROP is used only for temp variables (transaction or not > > transaction). The purpose is same like for tables. Sometimes you can to > > have object with

Re: Proposal for disk quota feature

2018-09-21 Thread Pavel Stehule
pá 21. 9. 2018 v 16:21 odesílatel Hubert Zhang napsal: > just fast reaction - why QUOTA object? >> Isn't ALTER SET enough? >> Some like >> ALTER TABLE a1 SET quote = 1MB; >> ALTER USER ... >> ALTER SCHEMA .. >> New DDL commans looks like too hard hammer . > > > It's an option. Prefer to consider

Re: vary read_only in SPI calls? or poke at the on-entry snapshot?

2018-09-21 Thread Chapman Flack
On 09/20/18 00:44, Tom Lane wrote: >> 1. fiddle the loader to always pass read_only => false to SPI calls, >>regardless of the volatility of the function it is loading for. >> 2. leave the loader alone, and adjust install_jar (an infrequent >>operation) to do something heretical with its

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Andres Freund
Hi, On 2018-09-22 09:56:00 +1200, Thomas Munro wrote: > I vote for doing it this way then. It may turn out to be useful for > efficient SearchSysCache(...), DirectFunctionCall(...) and other > things like that. Yea, especially the *FunctionCall* stuff is awfully verbose. I also wonder if it

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Andres Freund
Hi, On 2018-09-21 19:27:48 -0400, Tom Lane wrote: > > You earlier were talking about tackling this - do you still want to? I > > can otherwise, but it'll not be today, but likely tomorrow. > > On it now. Thanks, looks good. msvc and icc are, as expected, ok too. Greetings, Andres Freund

Re: [patch] Support LLVM 7

2018-09-21 Thread Andres Freund
On 2018-09-20 23:08:04 +0200, Christoph Berg wrote: > Re: To Andres Freund 2018-09-20 <20180920210315.gb21...@msg.df7cb.de> > > Server beendete die Verbindung unerwartet > > Something ate the attachments. Sorry. > > FATAL: fatal llvm error: Cannot select: 0x57e61d40: ch,glue = X86ISD::CALL >

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Tom Lane
Andres Freund writes: > On 2018-09-21 18:00:35 -0400, Tom Lane wrote: >> If you want to rename it, then to what? VA_ARGS_NARGS, perhaps? > I like your suggestion. I mainly didn't like the PP_ prefix. Sold. The original author overcomplicated it anyway; I now have /* * VA_ARGS_NARGS *

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Andres Freund
On 2018-09-21 18:00:35 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2018-09-22 09:15:27 +1200, Thomas Munro wrote: > >> On Sat, Sep 22, 2018 at 8:51 AM Andres Freund wrote: > >>> I think there's some argument to be made about the "mental" complexity > >>> of the macros - if we went for

Re: transction_timestamp() inside of procedures

2018-09-21 Thread Bruce Momjian
On Fri, Sep 21, 2018 at 06:28:22AM -0400, Bruce Momjian wrote: > On Fri, Sep 21, 2018 at 02:34:25PM +0900, Michael Paquier wrote: > > On Thu, Sep 20, 2018 at 10:12:06PM -0700, Andres Freund wrote: > > > Isn't the point that transaction_timestamp() does *not* currently change > > > its value, even

Re: [PATCH] Include application_name in "connection authorized" log message

2018-09-21 Thread Don Seiler
On Tue, Aug 7, 2018 at 12:32 PM Tom Lane wrote: > Don Seiler writes: > > > 1. We want to make a generic, central ascii-lobotomizing function similar > > to check_application_name that we can re-use there and for other checks > (eg > > user name). > > 2. Change check_application_name to call

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Tom Lane
Andres Freund writes: > On 2018-09-22 09:15:27 +1200, Thomas Munro wrote: >> On Sat, Sep 22, 2018 at 8:51 AM Andres Freund wrote: >>> I think there's some argument to be made about the "mental" complexity >>> of the macros - if we went for them, we'd certainly need to add some >>> docs about how

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Thomas Munro
On Sat, Sep 22, 2018 at 9:46 AM Andres Freund wrote: > On 2018-09-22 09:15:27 +1200, Thomas Munro wrote: > > On Sat, Sep 22, 2018 at 8:51 AM Andres Freund wrote: > > > I think there's some argument to be made about the "mental" complexity > > > of the macros - if we went for them, we'd certainly

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Andres Freund
Hi, On 2018-09-22 09:15:27 +1200, Thomas Munro wrote: > On Sat, Sep 22, 2018 at 8:51 AM Andres Freund wrote: > > I think there's some argument to be made about the "mental" complexity > > of the macros - if we went for them, we'd certainly need to add some > > docs about how they work. One

Re: Proposal for disk quota feature

2018-09-21 Thread Jeremy Finzel
On Fri, Sep 21, 2018 at 9:21 AM Hubert Zhang wrote: > just fast reaction - why QUOTA object? >> Isn't ALTER SET enough? >> Some like >> ALTER TABLE a1 SET quote = 1MB; >> ALTER USER ... >> ALTER SCHEMA .. >> New DDL commans looks like too hard hammer . > > > It's an option. Prefer to consider

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Thomas Munro
On Sat, Sep 22, 2018 at 8:51 AM Andres Freund wrote: > I think there's some argument to be made about the "mental" complexity > of the macros - if we went for them, we'd certainly need to add some > docs about how they work. One argument for having PP_NARGS (renamed) is > that it doesn't seem

Re: Strange failure in LWLock on skink in REL9_5_STABLE

2018-09-21 Thread Andres Freund
On 2018-09-22 08:54:57 +1200, Thomas Munro wrote: > On Fri, Sep 21, 2018 at 4:43 PM Tom Lane wrote: > > Thomas Munro writes: > > > On Fri, Sep 21, 2018 at 4:06 PM Tom Lane wrote: > > >> Why would we fix it rather than just removing it? > > > > > I assumed we wouldn't remove an extern C function

Re: Strange failure in LWLock on skink in REL9_5_STABLE

2018-09-21 Thread Thomas Munro
On Fri, Sep 21, 2018 at 4:43 PM Tom Lane wrote: > Thomas Munro writes: > > On Fri, Sep 21, 2018 at 4:06 PM Tom Lane wrote: > >> Why would we fix it rather than just removing it? > > > I assumed we wouldn't remove an extern C function extension code > > somewhere might use. Though admittedly

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Andres Freund
Hi, On 2018-09-21 16:20:42 -0400, Tom Lane wrote: > Thomas Munro writes: > > On Fri, Sep 21, 2018 at 5:52 PM Andres Freund wrote: > >> Here's a very quick-and-dirty implementation of this approach. Some very > >> very brief testing seems to indicate it works, although I'm sure not > >>

Re: Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

2018-09-21 Thread Tom Lane
Thomas Munro writes: > On Fri, Sep 21, 2018 at 5:52 PM Andres Freund wrote: >> Here's a very quick-and-dirty implementation of this approach. Some very >> very brief testing seems to indicate it works, although I'm sure not >> perfectly. > And here is a quick-and-dirty variadic

Re: Redundant psql tab-completion for CREATE PUBLICATION

2018-09-21 Thread Tom Lane
[ This seems to have slipped through the cracks, sorry about that ] Edmund Horner writes: > While looking at Justin's patch for VACUUM completions, I found an > existing bit of code that tries to match on a word with a space: >/* Complete "CREATE PUBLICATION FOR TABLE " */ > else if

Re: [HACKERS] proposal: schema variables

2018-09-21 Thread Arthur Zakirov
On Wed, Sep 19, 2018 at 04:36:40PM +0200, Pavel Stehule wrote: > ON COMMIT DROP is used only for temp variables (transaction or not > transaction). The purpose is same like for tables. Sometimes you can to > have object with shorter life than is session. > > ON TRANSACTION END RESET has sense

Re: adding tab completions

2018-09-21 Thread Tom Lane
I wrote: > The main thing that is bothering me about the remainder is its desire > to offer single-punctuation-character completions such as "(". I do > not see the point of that. You can't select a completion without > typing at least one character, so what does it accomplish to offer > those

Re: doc - add missing documentation for "acldefault"

2018-09-21 Thread Joe Conway
On 09/19/2018 11:18 AM, Joe Conway wrote: > On 09/19/2018 10:54 AM, Tom Lane wrote: >> Joe Conway writes: >>> * I do believe aclitemeq() has utility outside internal purposes. >> >> Our normal policy is that we do not document functions that are meant to >> be invoked through operators. The \df

Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru

2018-09-21 Thread Andres Freund
Hi, On 2018-09-21 20:38:16 +0300, Sergei Kornilov wrote: > > My first question was whether TWO of them were dead code ... isn't an > > aggressive vacuum to prevent wraparound, and a vacuum to prevent > > wraparound aggressive? > Maybe i am wrong, aggressive autovacuum was your commit. > Message

Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru

2018-09-21 Thread Sergei Kornilov
Hello, Robert > My first question was whether TWO of them were dead code ... isn't an > aggressive vacuum to prevent wraparound, and a vacuum to prevent > wraparound aggressive? Maybe i am wrong, aggressive autovacuum was your commit. Message split was in b55509332f50f998b6e8b3830a51c5b9d8f666aa

pg_atomic_exchange_u32() in ProcArrayGroupClearXid()

2018-09-21 Thread Alexander Korotkov
Hi! While investigating ProcArrayGroupClearXid() code I wonder why do we have this loop instead of plain pg_atomic_exchange_u32() call? Is it intentional? /* * Now that we've got the lock, clear the list of processes waiting for * group XID clearing, saving a pointer to the head of the list.

Re: proposal: prefix function

2018-09-21 Thread Pavel Stehule
Hi pá 21. 9. 2018 v 12:37 odesílatel Chris Travers napsal: > > > On Fri, Sep 21, 2018 at 10:09 AM Pavel Stehule > wrote: > >> Hi >> >> can we implement prefix function for fast test if substr is prefix of >> some string? >> >> create or replace function prefix(str text, substr text) >> returns

Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru

2018-09-21 Thread Robert Haas
On Fri, Sep 14, 2018 at 11:35 AM, Alvaro Herrera wrote: > On 2018-Sep-13, Michael Paquier wrote: >> Improve autovacuum logging for aggressive and anti-wraparound runs >> >> A log message was being generated when log_min_duration is reached for >> autovacuum on a given relation to indicate if it

Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

2018-09-21 Thread Tom Lane
I wrote: > So ... why exactly is this patch insisting on ppoll() rather than just > plain poll()? AFAICS, all you're doing with that is being able to > specify the timeout in microsec not millisec, which does not really > justify taking much of a hit in portability, to my mind. To check into my

[patch] Bug in pg_dump/pg_restore using --no-publication

2018-09-21 Thread Gilles Darold
Hi, Attached is a patch that fixes a bug in pg_dump since 10.0 and reproducible in master. When using option --no-publication : ALTER PUBLICATION orders are still present in the dump. Steps to reproduce: postgres=# CREATE DATABASE test; CREATE DATABASE postgres=# \c test You are now connected

Re: FETCH FIRST clause PERCENT option

2018-09-21 Thread Mark Dilger
> On Sep 20, 2018, at 5:29 PM, Andres Freund wrote: > > Hi, > > On 2018-09-20 17:06:36 -0700, Mark Dilger wrote: >> I should think that spilling anything to a tuplestore would only be needed >> if the query contains an ORDER BY expression. If you query >> >> FETCH FIRST 50 PERCENT *

Re: Proposal for disk quota feature

2018-09-21 Thread Hubert Zhang
> > just fast reaction - why QUOTA object? > Isn't ALTER SET enough? > Some like > ALTER TABLE a1 SET quote = 1MB; > ALTER USER ... > ALTER SCHEMA .. > New DDL commans looks like too hard hammer . It's an option. Prefer to consider quota setting store together: CREATE DISK QUOTA way is more

Re: [HACKERS] SERIALIZABLE on standby servers

2018-09-21 Thread Thomas Munro
On Sat, Sep 22, 2018 at 12:28 AM Thomas Munro wrote: > I'll add it to the next > Commitfest so I know when to rebase it. And cfbot immediately showed that this assertion in OldSerXidSetActiveSerXmin() could fail in the isolation tests: Assert(!TransactionIdIsValid(oldSerXidControl->tailXid)

Re: Size and size_t in dsa API

2018-09-21 Thread Thomas Munro
On Thu, Sep 20, 2018 at 10:13 PM Ideriha, Takeshi wrote: > >> As a non-expert developer's opinion, I think mixing of Size and size_t > >> makes difficult > >to understand source code. > > > >Agreed. Let's change them all to size_t and back-patch that to keep future > >back-patching easy. Patch

Re: [HACKERS] SERIALIZABLE on standby servers

2018-09-21 Thread Thomas Munro
Hi Kevin, all, /me pokes ancient thread I haven't done any more work on the problems mentioned above, but I ran into Kevin at PostgresOpen in San Francisco and he said he might have some time to look at this problem. So, here is a long overdue rebase of the WIP patch. It shows a first order

Re: Proposal for disk quota feature

2018-09-21 Thread Pavel Stehule
pá 21. 9. 2018 v 13:32 odesílatel Hubert Zhang napsal: > > > > > *Hi all,We redesign disk quota feature based on the comments from Pavel > Stehule and Chapman Flack. Here are the new design.OverviewBasically, disk > quota feature is used to support multi-tenancy environment, different level >

Re: Problem while setting the fpw with SIGHUP

2018-09-21 Thread Amit Kapila
On Tue, Sep 18, 2018 at 12:46 PM Kyotaro HORIGUCHI wrote: > > At Fri, 14 Sep 2018 16:30:37 +0530, Amit Kapila > wrote in > > On Fri, Sep 14, 2018 at 12:57 PM Michael Paquier > > wrote: > > > > > > On Thu, Sep 06, 2018 at 04:37:28PM -0700, Michael Paquier wrote: > > > > /* > > > > * Properly

Re: Connection slots reserved for replication

2018-09-21 Thread Alexander Kukushkin
Hi, On 20 September 2018 at 08:18, Kyotaro HORIGUCHI wrote: > > Instaed, we can iterally "reserve" connection slots for the > specific use by providing ProcGlobal->walsenderFreeProcs. The > slots are never stolen for other usage. Allowing additional > walsenders comes after all the slots are

Re: proposal: prefix function

2018-09-21 Thread Pavel Stehule
pá 21. 9. 2018 v 12:37 odesílatel Chris Travers napsal: > > > On Fri, Sep 21, 2018 at 10:09 AM Pavel Stehule > wrote: > >> Hi >> >> can we implement prefix function for fast test if substr is prefix of >> some string? >> >> create or replace function prefix(str text, substr text) >> returns

Re: Proposal for disk quota feature

2018-09-21 Thread Hubert Zhang
*Hi all,We redesign disk quota feature based on the comments from Pavel Stehule and Chapman Flack. Here are the new design.OverviewBasically, disk quota feature is used to support multi-tenancy environment, different level of database objects could be set a quota limit to avoid over use of disk

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2018-09-21 Thread Pavel Stehule
"empty translation unit" warnings from > some compilers in builds without USE_LIBXML. > > * Documentation, comments, and error messages could all use some > copy-editing by a native English speaker (you knew that of course). > I hope so some native speakers looks there. Thank you for comments Attached updated patch Regards Pavel > regards, tom lane > default_namespace-20180921.patch.gz Description: application/gzip

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

2018-09-21 Thread Etsuro Fujita
(2018/09/18 21:14), Kyotaro HORIGUCHI wrote: At Fri, 14 Sep 2018 22:01:39 +0900, Etsuro Fujita wrote in<5b9bb133.1060...@lab.ntt.co.jp> @@ -126,8 +173,18 @@ get_relation_info(PlannerInfo *root, Oid relationObjectId,\ bool inhparent, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),

Re: proposal: prefix function

2018-09-21 Thread Chris Travers
On Fri, Sep 21, 2018 at 10:09 AM Pavel Stehule wrote: > Hi > > can we implement prefix function for fast test if substr is prefix of some > string? > > create or replace function prefix(str text, substr text) > returns boolean as $$ > select substr(str, 1, length(substr)) = substr > $$

Re: Proposal for Signal Detection Refactoring

2018-09-21 Thread Chris Travers
On Fri, Sep 21, 2018 at 6:46 AM Michael Paquier wrote: > On Thu, Sep 20, 2018 at 03:08:34PM +0200, Chris Travers wrote: > > So here's a small patch. I will add it for the next commit fest unless > > anyone has any reason I shouldn't. > > - return InterruptPending && (QueryCancelPending ||

Re: transction_timestamp() inside of procedures

2018-09-21 Thread Bruce Momjian
On Fri, Sep 21, 2018 at 02:34:25PM +0900, Michael Paquier wrote: > On Thu, Sep 20, 2018 at 10:12:06PM -0700, Andres Freund wrote: > > Isn't the point that transaction_timestamp() does *not* currently change > > its value, even though the transaction (although not the outermost > > statement) has

RE: impact of SPECTRE and MELTDOWN patches

2018-09-21 Thread REIX, Tony
No. I work in Power world only. I know nothing about Intel. I was asking since these days we are executing a performance benchmark with PostgreSQL 10.4 on AIX/Power9 and Linux/Power9. I'll suggest my colleague to run a try with the Firmware check of SPECTRUM set on (now off), so that it will

RE: impact of SPECTRE and MELTDOWN patches

2018-09-21 Thread ROS Didier
Hi No, 80% of our IT infrastructure is INTEL HW. Have you any recommendations to correct the impact on the performance ? Best Regards [cid:image002.png@01D14E0E.8515EB90] Didier ROS Expertise SGBD DS IT/IT DMA/Solutions Groupe EDF/Expertise Applicative - SGBD Nanterre Picasso - E2 565D (aile

RE: impact of SPECTRE and MELTDOWN patches

2018-09-21 Thread REIX, Tony
Thx. So, it isIntel HW. Have you experimented too with Power HW? Regards Cordialement, Tony Reix tony.r...@atos.net ATOS / Bull SAS ATOS Expert IBM Coop Architect & Technical Leader Office : +33 (0) 4 76 29 72 67 1 rue de Provence - 38432 Échirolles - France

RE: impact of SPECTRE and MELTDOWN patches

2018-09-21 Thread ROS Didier
Hi Here is the HW information : [root@pcyyymm9 ~]# cat /proc/cpuinfo processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 62 model name : Intel(R) Xeon(R) CPU E5-4610 v2 @ 2.30GHz stepping: 4 microcode : 0x427 cpu MHz : 2300.000 cache

RE: impact of SPECTRE and MELTDOWN patches

2018-09-21 Thread REIX, Tony
Hi, Which HW have you experimented with? Thx/Regards Cordialement, Tony Reix tony.r...@atos.net ATOS / Bull SAS ATOS Expert IBM Coop Architect & Technical Leader Office : +33 (0) 4 76 29 72 67 1 rue de Provence - 38432 Échirolles - France

Re: Changing the setting of wal_sender_timeout per standby

2018-09-21 Thread Michael Paquier
On Fri, Sep 21, 2018 at 06:26:19AM +, Tsunakawa, Takayuki wrote: > Agreed. Sorry to cause you to take this long time for such a tiny > patch... Well, that is arguing about how to shape things and agree on those, which is not wasted time, far from that. -- Michael signature.asc Description:

proposal: prefix function

2018-09-21 Thread Pavel Stehule
Hi can we implement prefix function for fast test if substr is prefix of some string? create or replace function prefix(str text, substr text) returns boolean as $$ select substr(str, 1, length(substr)) = substr $$ language sql; This function can be very effective in C language. Now it should

Re: Pluggable Storage - Andres's take

2018-09-21 Thread Haribabu Kommi
On Fri, Sep 21, 2018 at 5:05 PM Andres Freund wrote: > Hi, > > On 2018-09-21 16:57:43 +1000, Haribabu Kommi wrote: > > > For example, in the sequential scan, the heap returns the slot with > > the tuple or with value array of all the columns and then the data gets > > filtered and later removed

Re: View to get all the extension control file details

2018-09-21 Thread Haribabu Kommi
On Thu, Sep 20, 2018 at 3:18 PM Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hello. > > At Mon, 17 Sep 2018 16:49:41 +1000, Haribabu Kommi < > kommi.harib...@gmail.com> wrote in > > > Hi Hackers, > > > > Currently PostgreSQL provides following views to get the extension >

Re: Pluggable Storage - Andres's take

2018-09-21 Thread Andres Freund
Hi, On 2018-09-21 16:57:43 +1000, Haribabu Kommi wrote: > During the porting of Fujitsu in-memory columnar store on top of pluggable > storage, I found that the callers of the "heap_beginscan" are expecting > the returned data is always contains all the records. Right. > For example, in the

Re: Pluggable Storage - Andres's take

2018-09-21 Thread Haribabu Kommi
On Mon, Sep 10, 2018 at 5:42 PM Haribabu Kommi wrote: > On Wed, Sep 5, 2018 at 2:04 PM Haribabu Kommi > wrote: > >> >> On Tue, Sep 4, 2018 at 10:33 AM Andres Freund wrote: >> >>> Hi, >>> >>> Thanks for the patches! >>> >>> On 2018-09-03 19:06:27 +1000, Haribabu Kommi wrote: >>> > I found

RE: Changing the setting of wal_sender_timeout per standby

2018-09-21 Thread Tsunakawa, Takayuki
From: Michael Paquier [mailto:mich...@paquier.xyz] > I think that the description of wal_sender_timeout and its properties should > remain where the parameter is defined, so (3) is not a good option in my > opinion. (2) has a point with the use of quotes actually, so why not just > mention

Re: Changing the setting of wal_sender_timeout per standby

2018-09-21 Thread Michael Paquier
On Fri, Sep 21, 2018 at 05:37:42AM +, Tsunakawa, Takayuki wrote: > I think all of these are almost equally good. I chose (1) at first, > and you chose (3). But (2) may be the best, because it's the natural > place the user will see when configuring the standby, and it already > contains an