RE: Timeout parameters

2019-03-28 Thread Nagaura, Ryohei
Hi, Tsunakawa-san, Kirk-san. Thank you for your review. Tsunakawa-san, > From: Tsunakawa, Takayuki [mailto:tsunakawa.ta...@jp.fujitsu.com] > The client-side tcp_user_timeout patch looks good. Thanks, but I minorly changed that patch. It is the declaration place of sebuf[], moving to just before

RE: Timeout parameters

2019-03-28 Thread Jamison, Kirk
Hi, >The socket_timeout patch needs the following fixes. Now that others have >already tested these patches >successfully, they appear committable to me. In addition, regarding socket_timeout parameter. I referred to the doc in libpq.sgml, corrected misspellings, and rephrased the doc a

Re: speeding up planning with partitions

2019-03-28 Thread Amit Langote
Thanks a lot for hacking on the patch. I'm really happy with the direction you took for inheritance_planner, as it allows UPDATE/DELETE to use partition pruning. On 2019/03/29 7:38, Tom Lane wrote: > I've been hacking on this pretty hard over the last couple days, > because I really didn't like

Re: Syntax diagrams in user documentation

2019-03-28 Thread Tom Lane
Christopher Browne writes: > An especially cool idea if we could automatically dig input directly from > src/backend/parser/gram.y FWIW, I think the odds of getting desirable diagrams that way are nil. There are *way* too many things about our Bison grammar that can be described charitably as

RE: Timeout parameters

2019-03-28 Thread Tsunakawa, Takayuki
Nagaura-san, The socket_timeout patch needs the following fixes. Now that others have already tested these patches successfully, they appear committable to me. (1) + else + goto iiv_error; ... + +iiv_error: + conn->status = CONNECTION_BAD; +

RE: Timeout parameters

2019-03-28 Thread Nagaura, Ryohei
Hello, In the last client-side tcp user timeout patch: + appendPQExpBuffer(>errorMessage, + libpq_gettext("setsockopt(TCP_USER_TIMEOUT) not supported: %s\n"), + SOCK_STRERROR(SOCK_ERRNO, sebuf,

Re: Misleading errors with column references in default expressions and partition bounds

2019-03-28 Thread Amit Langote
On 2019/03/28 21:14, Michael Paquier wrote: > On Wed, Mar 27, 2019 at 12:13:16PM +0900, Michael Paquier wrote: >> ParseExprKind is an enum, so listing all the options without the >> default has the advantage to generate a warning if somebody adds a >> value. This way anybody changing this code

Re: Syntax diagrams in user documentation

2019-03-28 Thread Corey Huinker
On Thu, Mar 28, 2019 at 6:49 PM Peter Geoghegan wrote: > On Thu, Mar 28, 2019 at 3:46 PM Jeremy Schneider > wrote: > > We're just gearing up for the Google Season of Docs and I think this > > would be a great task for a doc writer to help with. Any reason to > > expect serious objections to

RE: Timeout parameters

2019-03-28 Thread Tsunakawa, Takayuki
Nagaura-san, The client-side tcp_user_timeout patch looks good. The server-side tcp_user_timeout patch needs fixing the following: (1) + GUC_UNIT_MS | GUC_NOT_IN_SAMPLE + 12000, 0, INT_MAX, GUC_NOT_IN_SAMPLE should be removed because the parameter appears

Re: [HACKERS] Block level parallel vacuum

2019-03-28 Thread Masahiko Sawada
On Fri, Mar 29, 2019 at 4:53 AM Robert Haas wrote: > > On Tue, Mar 26, 2019 at 10:31 AM Masahiko Sawada > wrote: > > Thank you for reviewing the patch. > > I don't think the approach in v20-0001 is quite right. > > if (strcmp(opt->defname, "verbose") == 0) > -params.options

RE: Log a sample of transactions

2019-03-28 Thread Kuroda, Hayato
Dear Adrien, I understood the cost of randomizing is very low. Maybe it's OK.. I'll change the status to "Ready For Committer." Finally, I apologize for having delayed review. Thank you for your good opportunities. Best Regards, Hayato Kuroda Fujitsu LIMITED

Re: PostgreSQL pollutes the file system

2019-03-28 Thread Tatsuo Ishii
> Andreas Karlsson writes: >> On 3/27/19 3:26 PM, Tomas Vondra wrote: >>> That is true, of course. But are there actual examples of such conflicts >>> in practice? I mean, are there tools/packages that provide commands with >>> a conflicting name? I'm not aware of any, and as was pointed before,

Re: Re: FETCH FIRST clause WITH TIES option

2019-03-28 Thread Tomas Vondra
On Tue, Mar 26, 2019 at 10:46:00AM +0300, Surafel Temesgen wrote: On Mon, Mar 25, 2019 at 11:56 AM David Steele wrote: This patch no longer passes testing so marked Waiting on Author. Thank you for informing. Fixed Thanks for the updated patch. I do have this on my list of patches that

RE: Timeout parameters

2019-03-28 Thread Nagaura, Ryohei
Hello, Kirk-san. > From: Jamison, Kirk [mailto:k.jami...@jp.fujitsu.com] > >In TCP_USER_TIMEOUT backend patch: > > 1) linux ver 2.6.26 -> 2.6.36 > "Linux" should be capitalized. Oh, yes. I see. > In config.sgml it uses both "zero" and "0", while in libpq.sgml it only > uses "zero". > Since you

Re: amcheck verification for GiST

2019-03-28 Thread Peter Geoghegan
On Thu, Mar 28, 2019 at 10:08 AM Andrey Borodin wrote: > >> Is this really needed? Isn't the ShareLock on the index sufficient? If so, > >> why? > > There may be concurrent inserts? In GiST they can reorder items on page. > > Looks like I've tried to cope with same problem twice: > v3 of the

RE: Timeout parameters

2019-03-28 Thread Jamison, Kirk
Hi Nagaura-san, >I updated my patches. Thanks. >In TCP_USER_TIMEOUT backend patch: > 1) linux ver 2.6.26 -> 2.6.36 "Linux" should be capitalized. I confirmed that you followed Horiguchi-san's advice to base the doc from keepalives*. About your question: > 3) Same as keepalives*, I used both

Re: patch to allow disable of WAL recycling

2019-03-28 Thread Thomas Munro
On Fri, Mar 29, 2019 at 10:47 AM Thomas Munro wrote: > On Fri, Mar 29, 2019 at 8:59 AM Robert Haas wrote: > > On Tue, Mar 26, 2019 at 3:24 PM Jerry Jelinek > > wrote: > > > The latest patch is rebased, builds clean, and passes some basic testing. > > > Please let me know if there is anything

Re: Fix XML handling with DOCTYPE

2019-03-28 Thread Chapman Flack
On 03/27/19 19:27, Chapman Flack wrote: > A column marked FOR ORDINALITY will be populated with row numbers > matching the order in which the output rows appeared in the original > input XML document. > > I've been skimming right over it all this time, and that right there is > a glaring

Re: Ordered Partitioned Table Scans

2019-03-28 Thread David Rowley
On Fri, 29 Mar 2019 at 00:00, Amit Langote wrote: > > On 2019/03/28 8:04, David Rowley wrote: > > If it's *always* scanned last then it's fine for ORDER BY partkey > > NULLS LAST. If they have ORDER BY partkey NULLS FIRST then we won't > > match on the pathkeys. > > Sorry, I had meant to say

RE: Timeout parameters

2019-03-28 Thread Nagaura, Ryohei
Hello, I updated my patches. In TCP_USER_TIMEOUT backend patch: 1) linux ver 2.6.26 -> 2.6.36 2) error for systems where doesn't support this parameter In TCP_USER_TIMEOUT interface patch: error for systems where doesn't support this parameter Best regards, - Ryohei

Re: Syntax diagrams in user documentation

2019-03-28 Thread Peter Geoghegan
On Thu, Mar 28, 2019 at 3:46 PM Jeremy Schneider wrote: > We're just gearing up for the Google Season of Docs and I think this > would be a great task for a doc writer to help with. Any reason to > expect serious objections to syntax diagram graphics in the docs? It might be hard to come to a

Re: speeding up planning with partitions

2019-03-28 Thread Tom Lane
I've been hacking on this pretty hard over the last couple days, because I really didn't like the contortions you'd made to allow inheritance_planner to call expand_inherited_rtentry in a completely different context than the regular code path did. I eventually got rid of that by having

Re: Syntax diagrams in user documentation

2019-03-28 Thread Christopher Browne
On Thu, 28 Mar 2019 at 17:56, Peter Geoghegan wrote: > SQLite has a bubble generator tool that they use to generate syntax > diagrams for their documentation: > > > https://www.sqlite.org/docsrc/doc/tip/art/syntax/bubble-generator.tcl?mimetype=text/plain > > I think that the results are rather

Re: Syntax diagrams in user documentation

2019-03-28 Thread Alvaro Herrera
On 2019-Mar-28, Peter Geoghegan wrote: > SQLite has a bubble generator tool that they use to generate syntax > diagrams for their documentation: > > https://www.sqlite.org/docsrc/doc/tip/art/syntax/bubble-generator.tcl?mimetype=text/plain Interesting. SQLite itself is in the public domain, so

Syntax diagrams in user documentation

2019-03-28 Thread Peter Geoghegan
SQLite has a bubble generator tool that they use to generate syntax diagrams for their documentation: https://www.sqlite.org/docsrc/doc/tip/art/syntax/bubble-generator.tcl?mimetype=text/plain I think that the results are rather good. See, for example, the INSERT documentation:

Re: patch to allow disable of WAL recycling

2019-03-28 Thread Thomas Munro
On Fri, Mar 29, 2019 at 8:59 AM Robert Haas wrote: > On Tue, Mar 26, 2019 at 3:24 PM Jerry Jelinek > wrote: > > The latest patch is rebased, builds clean, and passes some basic testing. > > Please let me know if there is anything else I could do on this. > > I agree with Thomas Munro's earlier

Re: Online verification of checksums

2019-03-28 Thread Tomas Vondra
On Thu, Mar 28, 2019 at 01:11:40PM -0700, Andres Freund wrote: Hi, On 2019-03-28 21:09:22 +0100, Michael Banck wrote: I agree that the current patch might have some corner-cases where it does not guarantee 100% accuracy in online mode, but I hope the current version at least has no more false

Re: Online verification of checksums

2019-03-28 Thread Andres Freund
Hi, On 2019-03-28 21:09:22 +0100, Michael Banck wrote: > I agree that the current patch might have some corner-cases where it > does not guarantee 100% accuracy in online mode, but I hope the current > version at least has no more false negatives. False positives are *bad*. We shouldn't

Re: Online verification of checksums

2019-03-28 Thread Michael Banck
Hi, Am Donnerstag, den 28.03.2019, 18:19 +0100 schrieb Tomas Vondra: > On Thu, Mar 28, 2019 at 05:08:33PM +0100, Michael Banck wrote: > > I also fixed the two issues Andres reported, namely a zeroed-out > > pageheader and a random LSN. The first is caught be checking for an all- > > zero-page in

Re: patch to allow disable of WAL recycling

2019-03-28 Thread Robert Haas
On Tue, Mar 26, 2019 at 3:24 PM Jerry Jelinek wrote: > The latest patch is rebased, builds clean, and passes some basic testing. > Please let me know if there is anything else I could do on this. I agree with Thomas Munro's earlier critique of the documentation. The documentation of the new

Re: [HACKERS] Block level parallel vacuum

2019-03-28 Thread Robert Haas
On Tue, Mar 26, 2019 at 10:31 AM Masahiko Sawada wrote: > Thank you for reviewing the patch. I don't think the approach in v20-0001 is quite right. if (strcmp(opt->defname, "verbose") == 0) -params.options |= VACOPT_VERBOSE; +params.options |= defGetBoolean(opt)

Re: New vacuum option to do only freezing

2019-03-28 Thread Robert Haas
On Thu, Mar 28, 2019 at 2:00 AM Masahiko Sawada wrote: > The patch adds the basic functionality to disable index cleanup but > one possible argument could be whether we should always disable it > when anti-wraparound vacuum. As discussed on another thread[1] > anti-wraparound vacuum still could

Re: monitoring CREATE INDEX [CONCURRENTLY]

2019-03-28 Thread Robert Haas
On Thu, Mar 28, 2019 at 12:07 PM Simon Riggs wrote: > Seems more like our own labelling of the phases is responsible for that, > rather than it being a specific problem. The numbering should reflect the > ordinal executed step number. So if a VACUUM has required two sets of index > scanning,

Re: partitioned tables referenced by FKs

2019-03-28 Thread Alvaro Herrera
On 2019-Mar-18, Alvaro Herrera wrote: > A pretty silly bug remains here. Watch: > > create table pk (a int primary key) partition by list (a); > create table pk1 partition of pk for values in (1); > create table fk (a int references pk); > insert into pk values (1); > insert into fk values (1);

Re: Online verification of checksums

2019-03-28 Thread Tomas Vondra
On Thu, Mar 28, 2019 at 05:08:33PM +0100, Michael Banck wrote: Hi, I have rebased this patch now. I also fixed the two issues Andres reported, namely a zeroed-out pageheader and a random LSN. The first is caught be checking for an all- zero-page in the way PageIsVerified() does. The second is

Re: propagating replica identity to partitions

2019-03-28 Thread Simon Riggs
On Thu, 28 Mar 2019 at 16:46, Alvaro Herrera wrote: > Thanks, Michael and Peter, for responding; however there is a second > part to the question, which is "should I change the recursivity of > REPLICA IDENTITY, while not simultaneously changing the recusivity of > the TABLESPACE and OWNER TO

Re: propagating replica identity to partitions

2019-03-28 Thread Simon Riggs
On Sat, 23 Mar 2019 at 01:34, Michael Paquier wrote: > I'm slightly baffled that we would even allow having different owners on > > different partitions, but that seems to be a separate discussion. > > Different owners can make sense for multiple layers of partitions > where the children have

Re: amcheck verification for GiST

2019-03-28 Thread Andrey Borodin
> 28 марта 2019 г., в 18:35, Andrey Borodin написал(а): >> >> Is this really needed? Isn't the ShareLock on the index sufficient? If so, >> why? > There may be concurrent inserts? In GiST they can reorder items on page. Looks like I've tried to cope with same problem twice: v3 of the patch

Re: propagating replica identity to partitions

2019-03-28 Thread Alvaro Herrera
Thanks, Michael and Peter, for responding; however there is a second part to the question, which is "should I change the recursivity of REPLICA IDENTITY, while not simultaneously changing the recusivity of the TABLESPACE and OWNER TO forms of ALTER TABLE?" I think everyone agrees that REPLICA

Re: jsonpath

2019-03-28 Thread Andrew Dunstan
On 3/28/19 9:50 AM, Tom Lane wrote: > Andres Freund writes: >> On March 28, 2019 9:31:14 AM EDT, Tom Lane wrote: >>> Has anybody gotten through a valgrind run on this code yet? >> Skink has successfully passed since - but that's x86... > Yeah, there is a depressingly high chance that this is

Re: Online verification of checksums

2019-03-28 Thread Michael Banck
Hi, I have rebased this patch now. I also fixed the two issues Andres reported, namely a zeroed-out pageheader and a random LSN. The first is caught be checking for an all- zero-page in the way PageIsVerified() does. The second is caught by comparing the upper 32 bits of the LSN as well and

Re: monitoring CREATE INDEX [CONCURRENTLY]

2019-03-28 Thread Simon Riggs
On Thu, 28 Mar 2019 at 15:39, Alvaro Herrera wrote: > On 2019-Mar-28, Simon Riggs wrote: > > > On Thu, 28 Mar 2019 at 14:56, Alvaro Herrera > > wrote: > > > > > I have not reinstated phase numbers; I have Rahila's positive vote for > > > them. Do I hear any more votes on this issue? > > > > If

Re: Berserk Autovacuum (let's save next Mandrill)

2019-03-28 Thread Masahiko Sawada
On Thu, Mar 28, 2019 at 8:58 PM Darafei "Komяpa" Praliaskouski wrote: > > Hi, > > > > Why not select a table that has inserts, updates and deletes for > > > autovacuum just like we do for autoanalyze, not only deletes and updates > > > like we do now? >> >> > >> > Sounds like a good idea,

Re: monitoring CREATE INDEX [CONCURRENTLY]

2019-03-28 Thread Alvaro Herrera
On 2019-Mar-28, Simon Riggs wrote: > On Thu, 28 Mar 2019 at 14:56, Alvaro Herrera > wrote: > > > I have not reinstated phase numbers; I have Rahila's positive vote for > > them. Do I hear any more votes on this issue? > > If there is a specific technical issue, I'd like to understand that

Re: monitoring CREATE INDEX [CONCURRENTLY]

2019-03-28 Thread Simon Riggs
On Thu, 28 Mar 2019 at 14:56, Alvaro Herrera wrote: > I have not reinstated phase numbers; I have Rahila's positive vote for > them. Do I hear any more votes on this issue? > If there is a specific technical issue, I'd like to understand that more. If it is just a usability preference, then I

Re: git head crash/regression failures

2019-03-28 Thread Bruce Momjian
On Thu, Mar 28, 2019 at 12:10:23PM -0300, Alvaro Herrera wrote: > On 2019-Mar-28, Bruce Momjian wrote: > > > I am seeing psql crash and massive regression test failures in git head. > > The psql crash happens if .psqlrc contains: > > > > \set COMP_KEYWORD_CASE upper > > > > and the crash

Re: git head crash/regression failures

2019-03-28 Thread Alvaro Herrera
On 2019-Mar-28, Bruce Momjian wrote: > I am seeing psql crash and massive regression test failures in git head. > The psql crash happens if .psqlrc contains: > > \set COMP_KEYWORD_CASE upper > > and the crash backtrace is: > > Program received signal SIGSEGV, Segmentation fault. >

git head crash/regression failures

2019-03-28 Thread Bruce Momjian
I am seeing psql crash and massive regression test failures in git head. The psql crash happens if .psqlrc contains: \set COMP_KEYWORD_CASE upper and the crash backtrace is: Program received signal SIGSEGV, Segmentation fault. 0x5557f350 in slash_yylex

Re: monitoring CREATE INDEX [CONCURRENTLY]

2019-03-28 Thread Alvaro Herrera
On 2019-Mar-10, David Fetter wrote: > Would it be a very large lift to report progress for the rest of the > index types we support? Patch v7 I just posted does that. Please give it a look and let me know what you think. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL

Compile from source using latest Microsoft Windows SDK

2019-03-28 Thread Peifeng Qiu
Hi, hackers. The current Windows build system supports compiling with Windows SDK up to v8.1. When building with the latest Windows SDK v10 which is the default for Visual Studio 2017, we will get the following error: error MSB8036: The Windows SDK version 8.1 was not found. When the build

Re: clean up docs for log_statement_sample_rate

2019-03-28 Thread Adrien NAYRAT
On 3/28/19 2:59 PM, Justin Pryzby wrote: Following the dicussion here, https://www.postgresql.org/message-id/flat/CAD21AoB9%2By8N4%2BFan-ne-_7J5yTybPttxeVKfwUocKp4zT1vNQ%40mail.gmail.com#90a8316b1e643532e1cdb352c91c22a7 I'm proposing these changes to clean up docs for previous (more or less

Re: monitoring CREATE INDEX [CONCURRENTLY]

2019-03-28 Thread Alvaro Herrera
Here's v7. This is rebased on top of yesterday's tableam commit reworking the index build API (thanks Rahila for letting me know it had already rot). No changes otherwise. Got rid of 0001 because the tableam changes made that unnecessary. (Each new table AM will have to include its own

Re: Progress reporting for pg_verify_checksums

2019-03-28 Thread Fabien COELHO
Hallo Michael, but I'd advise that you split it in (1) progress and (2) signal toggling so that the first part is more likely to make it before 12 freeze. Ok, done so in the attached. Fine. I think that it is good to show the overall impact of the signal stuff, in particular the fact

Re: Sparse bit set data structure

2019-03-28 Thread Adrien NAYRAT
Hello, According to the draw and simple8b_mode struct comment, it seems there is a typo: * 20-bit integer 20-bit integer 20-bit integer * 1101 00010010 00110010 00010100 * ^ * selector * * The selector 1101 is 13 in decimal. From the

Re: PostgreSQL pollutes the file system

2019-03-28 Thread Fred .Flintstone
So what we could do is: * Rename executables to be prefixed with pg_. Symlink old names to renamed executables. This while remaining 100% backwards compatibility, not breaking anything legacy. * Print warnings when the executables are executed using the symlink. * Have the option to have the

Re: clean up docs for log_statement_sample_rate

2019-03-28 Thread Christoph Berg
Re: Justin Pryzby 2019-03-28 <20190328135918.ga27...@telsasoft.com> > + Determines the fraction of statements that exceed > + to be logged. > + The default is 1, meaning log all such ^ 1.0 Thanks for taking care of this! Christoph

clean up docs for log_statement_sample_rate

2019-03-28 Thread Justin Pryzby
Following the dicussion here, https://www.postgresql.org/message-id/flat/CAD21AoB9%2By8N4%2BFan-ne-_7J5yTybPttxeVKfwUocKp4zT1vNQ%40mail.gmail.com#90a8316b1e643532e1cdb352c91c22a7 I'm proposing these changes to clean up docs for previous (more or less unrelated) commit. >From

Re: PostgreSQL pollutes the file system

2019-03-28 Thread Tom Lane
Alvaro Herrera writes: > There are provisions in the manpage system to have some pages be > symlinks to other pages. We don't currently use that anywhere, Actually we do, eg WITH is a link to SELECT. regards, tom lane

Re: PostgreSQL pollutes the file system

2019-03-28 Thread Alvaro Herrera
On 2019-Mar-28, Abel Abraham Camarillo Ojeda wrote: > On Thursday, March 28, 2019, Fred .Flintstone wrote: > > > There would be no need to remove anything if we just renamed the > > executable and created symlinks for them. > > Will there still be man pages for both commands? > > man

Re: jsonpath

2019-03-28 Thread Tom Lane
Andres Freund writes: > On March 28, 2019 9:31:14 AM EDT, Tom Lane wrote: >> Has anybody gotten through a valgrind run on this code yet? > Skink has successfully passed since - but that's x86... Yeah, there is a depressingly high chance that this is somehow specific to the bison version, flex

Re: basebackup checksum verification

2019-03-28 Thread Michael Paquier
On Tue, Mar 26, 2019 at 05:23:01PM -0700, Peter Geoghegan wrote: > I have personally seen real world corruption that involved a page > image consisting of random noise. Several times. Failing to detect > blatant corruption is unacceptable IMV. Yeah, I have seen that as well. If we have a tool

Re: amcheck verification for GiST

2019-03-28 Thread Andrey Borodin
Thanks for looking into this! > 27 марта 2019 г., в 22:29, Heikki Linnakangas написал(а): > > On 27/03/2019 11:51, Andrey Borodin wrote: >> Hi! >> Here's new version of GiST amcheck, which takes into account recently >> committed GiST VACUUM. >> It tests that deleted pages do not contain any

Re: jsonpath

2019-03-28 Thread Andres Freund
On March 28, 2019 9:31:14 AM EDT, Tom Lane wrote: >Andrew Dunstan writes: >> I mean repeated invocations of >>     psql -c "select '$ ? (@ like_regex \"pattern\" flag >\"a\")'::jsonpath" >> These get crash, no crash, crash, no crash ... > >That is just wacko ... but it does seem to support my

Re: jsonpath

2019-03-28 Thread Alexander Korotkov
On Thu, Mar 28, 2019 at 4:31 PM Tom Lane wrote: > Andrew Dunstan writes: > > I mean repeated invocations of > > psql -c "select '$ ? (@ like_regex \"pattern\" flag \"a\")'::jsonpath" > > These get crash, no crash, crash, no crash ... > > That is just wacko ... but it does seem to support my

Re: PostgreSQL pollutes the file system

2019-03-28 Thread Abel Abraham Camarillo Ojeda
On Thursday, March 28, 2019, Fred .Flintstone wrote: > There would be no need to remove anything if we just renamed the > executable and created symlinks for them. Will there still be man pages for both commands? man pg_createuser man createuser ? > > On Wed, Mar 27, 2019 at 10:20 PM Peter

Re: jsonpath

2019-03-28 Thread Tom Lane
Andrew Dunstan writes: > I mean repeated invocations of >     psql -c "select '$ ? (@ like_regex \"pattern\" flag \"a\")'::jsonpath" > These get crash, no crash, crash, no crash ... That is just wacko ... but it does seem to support my thought of a wild store somewhere. The mechanism for this

Re: Planning counters in pg_stat_statements (using pgss_store)

2019-03-28 Thread Julien Rouhaud
On Thu, Mar 28, 2019 at 9:48 AM Julien Rouhaud wrote: > > On Thu, Mar 28, 2019 at 8:45 AM Sergei Kornilov wrote: > > > > >> Ok, but keep in mind that this is the last commitfest for pg12, and > > >> there are only 4 days left. Will you have time to take care of it, or > > >> do you need help

Re: PostgreSQL pollutes the file system

2019-03-28 Thread Fred .Flintstone
There would be no need to remove anything if we just renamed the executable and created symlinks for them. On Wed, Mar 27, 2019 at 10:20 PM Peter Eisentraut wrote: > > On 2019-03-27 18:09, Tom Lane wrote: > > My recollection of the discussion is that people argued that "postmaster" > > might be

Re: Libpq support to connect to standby server as priority

2019-03-28 Thread Haribabu Kommi
On Wed, Mar 27, 2019 at 5:17 PM Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > I've looked through 0004-0007. I've only found the following: > > (5) 0005 > With this read-only option type, application can connect to > connecting to a read-only server in the list of hosts, in case

Re: jsonpath

2019-03-28 Thread Andrew Dunstan
On 3/28/19 8:49 AM, Alexander Korotkov wrote: > >> Here's an interesting data point. If I run the whole jsonpath.sql script >> it crashes every time. If I run just the offending statement it crashes >> exactly every other time. It looks like in that case something gets >> clobbered and then

Re: jsonpath

2019-03-28 Thread Alexander Korotkov
On Thu, Mar 28, 2019 at 3:25 PM Andrew Dunstan wrote: > On 3/28/19 5:38 AM, Alexander Korotkov wrote: > > On Thu, Mar 28, 2019 at 5:55 AM Andrew Dunstan > > wrote: > >> On 3/27/19 9:48 AM, Tom Lane wrote: > >>> Alexander Korotkov writes: > Still no reproduction. > >>> Annoying, but it's

Multitenancy optimization

2019-03-28 Thread Konstantin Knizhnik
Hi hacker, Postgres is quite frequently used in different Internet services with multi-tenant architecture. It means that all object stored in the database have something like "tenant_id" foreign key. This key is used in all queries, i.e. select * from Product where tenant_id=? and

Re: jsonpath

2019-03-28 Thread Andrew Dunstan
On 3/28/19 5:38 AM, Alexander Korotkov wrote: > On Thu, Mar 28, 2019 at 5:55 AM Andrew Dunstan > wrote: >> On 3/27/19 9:48 AM, Tom Lane wrote: >>> Alexander Korotkov writes: Still no reproduction. >>> Annoying, but it's probably not worth expending more effort on >>> right now. I wonder

Re: COPY FROM WHEN condition

2019-03-28 Thread Andres Freund
Hi, On 2019-03-28 20:48:47 +1300, David Rowley wrote: > I had a look at this and performance has improved again, thanks. > However, I'm not sure if the patch is exactly what we need, let me > explain. I'm not entirely sure either, I just haven't really seen an alternative that's convincing. >

Re: Log a sample of transactions

2019-03-28 Thread Adrien NAYRAT
On 3/28/19 10:45 AM, Christoph Berg wrote: Re: Adrien NAYRAT 2019-03-28 Sorry, I changed that, someone suggest using either "0" and "1", or "0.0" and "1.0" but not mixing both. Agreed with using "0.0" and "1.0". I will remove this change. +#log_transaction_sample_rate = 0 #

Re: Misleading errors with column references in default expressions and partition bounds

2019-03-28 Thread Michael Paquier
On Wed, Mar 27, 2019 at 12:13:16PM +0900, Michael Paquier wrote: > ParseExprKind is an enum, so listing all the options without the > default has the advantage to generate a warning if somebody adds a > value. This way anybody changing this code will need to think about > it. A bit late, but

Re: Enable data checksums by default

2019-03-28 Thread Peter Eisentraut
On 2019-03-22 16:16, Christoph Berg wrote: > I think, the next step in that direction would be to enable data > checksums by default. They make sense in most setups, and people who > plan to run very performance-critical systems where checksums might be > too much need to tune many knobs anyway,

Re: Berserk Autovacuum (let's save next Mandrill)

2019-03-28 Thread Komяpa
Hi, > > Why not select a table that has inserts, updates and deletes for autovacuum just like we do for autoanalyze, not only deletes and updates like we do now? > > > > Sounds like a good idea, although I do agree with Alvaro when he > > mentions that it would be good to only invoke a worker

Re: jsonpath

2019-03-28 Thread Andrew Dunstan
On 3/28/19 1:01 AM, Tom Lane wrote: > Andrew Dunstan writes: >> I was able to get this stack trace. >> >> (gdb) bt >> #0 0x7ffb9ce6a458 in ntdll!RtlRaiseStatus () >>from C:\WINDOWS\SYSTEM32\ntdll.dll >> #1 0x7ffb9ce7760e in ntdll!memset () from C:\WINDOWS\SYSTEM32\ntdll.dll >> #2

Re: Berserk Autovacuum (let's save next Mandrill)

2019-03-28 Thread Komяpa
On Thu, Mar 28, 2019 at 12:32 PM David Rowley wrote: > On Thu, 28 Mar 2019 at 22:04, Darafei "Komяpa" Praliaskouski > wrote: > > > > On Thu, Mar 28, 2019 at 2:36 AM David Rowley < > david.row...@2ndquadrant.com> wrote: > >> I thought recently that it would be good to have some sort of > >>

Re: Ordered Partitioned Table Scans

2019-03-28 Thread Amit Langote
Hi David, On 2019/03/28 8:04, David Rowley wrote: > On Wed, 27 Mar 2019 at 21:24, Amit Langote > wrote: >> Noticed a typo. >> >> + * multiple subpaths then we can't make guarantees about the >> + * order tuples in those subpaths, so we must leave the >> >> order

Re: Berserk Autovacuum (let's save next Mandrill)

2019-03-28 Thread Masahiko Sawada
On Thu, Mar 28, 2019 at 6:32 PM David Rowley wrote: > > On Thu, 28 Mar 2019 at 22:04, Darafei "Komяpa" Praliaskouski > wrote: > > > > On Thu, Mar 28, 2019 at 2:36 AM David Rowley > > wrote: > >> I thought recently that it would be good to have some sort of > >> pro-active auto-vacuum mode that

Re: Progress reporting for pg_verify_checksums

2019-03-28 Thread Michael Banck
Hi, Am Donnerstag, den 28.03.2019, 10:08 +0100 schrieb Fabien COELHO: > I marked it as ready, Thanks! > but I'd advise that you split it in (1) progress and (2) signal > toggling so that the first part is more likely to make it before 12 > freeze. Ok, done so in the attached. Michael --

Re: speeding up planning with partitions

2019-03-28 Thread Amit Langote
On 2019/03/28 14:03, Tom Lane wrote: > Amit Langote writes: >> On 2019/03/27 23:57, Tom Lane wrote: >>> Yeah, there's something to be said for having plancat.c open each table >>> *and store the Relation pointer in the RelOptInfo*, and then close that >>> again at the end of planning rather than

RE: Timeout parameters

2019-03-28 Thread Nagaura, Ryohei
Hi, all. # This is a supplement of my current patches. > From: Nagaura, Ryohei [mailto:nagaura.ryo...@jp.fujitsu.com] > > In TCP_backend patch: > > I think this is not mentioning backend. Why don't you copy'n paste > > then modify the description of tcp_keepalives_idle? Perhaps it needs > a > >

Re: Index Skip Scan

2019-03-28 Thread Dmitry Dolgov
> On Tue, Mar 19, 2019 at 2:07 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Sat, Mar 16, 2019 at 5:14 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > > > On Fri, Mar 15, 2019 at 4:55 AM Kyotaro HORIGUCHI > > > wrote: > > > I have some comments on the latest v11 patch. > > > >

Re: Log a sample of transactions

2019-03-28 Thread Christoph Berg
Re: Adrien NAYRAT 2019-03-28 > > > > Sorry, I changed that, someone suggest using either "0" and "1", or > > > > "0.0" and "1.0" but not mixing both. > > > > Agreed with using "0.0" and "1.0". > > > > > > I will remove this change. > +#log_transaction_sample_rate = 0 # Fraction of

Re: Log a sample of transactions

2019-03-28 Thread Masahiko Sawada
On Thu, Mar 28, 2019 at 6:33 PM Adrien NAYRAT wrote: > > Hello, > > On 3/28/19 3:18 AM, Masahiko Sawada wrote: > >>> > >>> Sorry, I changed that, someone suggest using either "0" and "1", or > >>> "0.0" and "1.0" but not mixing both. > > > > Agreed with using "0.0" and "1.0". > > > >>> I will

Re: jsonpath

2019-03-28 Thread Alexander Korotkov
On Thu, Mar 28, 2019 at 5:55 AM Andrew Dunstan wrote: > On 3/27/19 9:48 AM, Tom Lane wrote: > > Alexander Korotkov writes: > >> Still no reproduction. > > Annoying, but it's probably not worth expending more effort on > > right now. I wonder whether that buildfarm animal can be upgraded > > to

Re: Berserk Autovacuum (let's save next Mandrill)

2019-03-28 Thread David Rowley
On Thu, 28 Mar 2019 at 22:04, Darafei "Komяpa" Praliaskouski wrote: > > On Thu, Mar 28, 2019 at 2:36 AM David Rowley > wrote: >> I thought recently that it would be good to have some sort of >> pro-active auto-vacuum mode that made use of idle workers. > > Problem with "idle" is that it never

Re: ToDo: show size of partitioned table

2019-03-28 Thread Amit Langote
On 2019/03/28 18:31, Amit Langote wrote: > Hi, > > On 2019/03/28 18:12, Peter Eisentraut wrote: >> On 2019-03-22 01:21, Amit Langote wrote: >>> On 2019/03/22 2:23, David Steele wrote: On 3/14/19 6:19 AM, Amit Langote wrote: > On 2019/03/14 2:11, Pavel Stehule wrote: >> >>> I've

Re: Log a sample of transactions

2019-03-28 Thread Adrien NAYRAT
Hello, On 3/28/19 3:18 AM, Masahiko Sawada wrote: Sorry, I changed that, someone suggest using either "0" and "1", or "0.0" and "1.0" but not mixing both. Agreed with using "0.0" and "1.0". I will remove this change. --- a/src/backend/utils/misc/postgresql.conf.sample +++

Re: ToDo: show size of partitioned table

2019-03-28 Thread Amit Langote
Hi, On 2019/03/28 18:12, Peter Eisentraut wrote: > On 2019-03-22 01:21, Amit Langote wrote: >> On 2019/03/22 2:23, David Steele wrote: >>> On 3/14/19 6:19 AM, Amit Langote wrote: On 2019/03/14 2:11, Pavel Stehule wrote: > >> I've attached v11 of the patch, which merges most of

Re: ToDo: show size of partitioned table

2019-03-28 Thread Pavel Stehule
čt 28. 3. 2019 v 10:12 odesílatel Peter Eisentraut < peter.eisentr...@2ndquadrant.com> napsal: > On 2019-03-22 01:21, Amit Langote wrote: > > On 2019/03/22 2:23, David Steele wrote: > >> On 3/14/19 6:19 AM, Amit Langote wrote: > >>> On 2019/03/14 2:11, Pavel Stehule wrote: > > > I've

Re: ToDo: show size of partitioned table

2019-03-28 Thread Peter Eisentraut
On 2019-03-22 01:21, Amit Langote wrote: > On 2019/03/22 2:23, David Steele wrote: >> On 3/14/19 6:19 AM, Amit Langote wrote: >>> On 2019/03/14 2:11, Pavel Stehule wrote: > I've attached v11 of the patch, which merges most of Justin's changes and > some of my own on top --

Re: idle-in-transaction timeout error does not give a hint

2019-03-28 Thread Peter Eisentraut
On 2018-11-28 04:17, Tatsuo Ishii wrote: > + errmsg("terminating connection due to > idle-in-transaction timeout"), > + errhint("In a moment you should be > able to reconnect to the" > +

Re: Berserk Autovacuum (let's save next Mandrill)

2019-03-28 Thread Komяpa
On Thu, Mar 28, 2019 at 2:36 AM David Rowley wrote: > On Thu, 28 Mar 2019 at 11:01, Alvaro Herrera > wrote: > > > > On 2019-Mar-28, Darafei "Komяpa" Praliaskouski wrote: > > > "Nearing wraparound" is too late already. In Amazon, reading table > from gp2 > > > after you exhausted your IOPS burst

RE: Timeout parameters

2019-03-28 Thread Nagaura, Ryohei
Hi, Tsunakawa-san. > From: Tsunakawa, Takayuki [mailto:tsunakawa.ta...@jp.fujitsu.com] > I think that's for the case where the modules is built on an OS that > supports TCP_USER_TIMEOUT (#ifdef TCP_USER_TIMEOUT is true), and the > module is used on an older OS that doesn't support

Re: Progress reporting for pg_verify_checksums

2019-03-28 Thread Michael Banck
Hi, Am Donnerstag, den 28.03.2019, 09:41 +0100 schrieb Fabien COELHO: > Hallo Michael, > > > > Or anything which converts to double early. > > Are you sure, seeing elapsed is a double already? > > > Argh, I missed that. You are right that a double elapsed is enough for the > second part.

Re: Planning counters in pg_stat_statements (using pgss_store)

2019-03-28 Thread Julien Rouhaud
On Thu, Mar 28, 2019 at 8:45 AM Sergei Kornilov wrote: > > >> Ok, but keep in mind that this is the last commitfest for pg12, and > >> there are only 4 days left. Will you have time to take care of it, or > >> do you need help on it? > > > > Oups, sorry, I won't have time nor knowledge to

  1   2   >