Re: Revert back to standard AC_STRUCT_TIMEZONE Autoconf macro

2019-10-01 Thread Peter Eisentraut
On 2019-09-30 21:36, Tom Lane wrote: > Peter Eisentraut writes: >> Instead of AC_STRUCT_TIMEZONE we use our own variant called >> PGAC_STRUCT_TIMEZONE that checks for tzname even if other variants were >> found first. But since 63bd0db12199c5df043e1dea0f2b574f622b3a4c we >> don't use tzname

Re: dropdb --force

2019-10-01 Thread Amit Kapila
On Thu, Sep 26, 2019 at 7:18 PM Pavel Stehule wrote: > > út 24. 9. 2019 v 14:52 odesílatel Amit Kapila > napsal: > >> >> One other minor comment: >> + >> + This will also fail, if the connections do not terminate in 5 >> seconds. >> + >> >> Is there any implementation in the patch for

Is querying SPITupleTable with SQL possible?

2019-10-01 Thread Tom Mercha
Dear Hackers I am using PostgreSQL's SPI to execute a simple SQL query (SELECT * FROM ...) via SPI_exec. As a a result, I get an SPITupleTable with the results of my query. Now that I have the SPITupleTable, I was wondering if it would be possible to later query over it further in my SQL

Re: Peripatus: Can someone look?

2019-10-01 Thread Larry Rosenman
On 10/01/2019 8:33 pm, Thomas Munro wrote: On Wed, Oct 2, 2019 at 4:49 AM Larry Rosenman wrote: On 10/01/2019 10:46 am, Tom Lane wrote: > Larry Rosenman writes: >> My Buildfarm animal (peripatus) has been failing check since >> yesterday. >> Can someone look at it? > > It's been doing this in

Re: Transparent Data Encryption (TDE) and encrypted files

2019-10-01 Thread Bruce Momjian
On Mon, Sep 30, 2019 at 05:26:33PM -0400, Bruce Momjian wrote: > For full-cluster Transparent Data Encryption (TDE), the current plan is > to encrypt all heap and index files, WAL, and all pgsql_tmp (work_mem > overflow). The plan is: > > >

Re: Peripatus: Can someone look?

2019-10-01 Thread Thomas Munro
On Wed, Oct 2, 2019 at 4:49 AM Larry Rosenman wrote: > On 10/01/2019 10:46 am, Tom Lane wrote: > > Larry Rosenman writes: > >> My Buildfarm animal (peripatus) has been failing check since > >> yesterday. > >> Can someone look at it? > > > > It's been doing this in parallel queries, in v11 and

Re: My buildfarm member now giving permission denied

2019-10-01 Thread Larry Rosenman
On 10/01/2019 8:27 pm, Larry Rosenman wrote: FreeBSD SVN rev: r352600 - - 1.69G 2019-09-22 13:13 r352873 NR / 43.1G 2019-09-29 16:36 I went from r352600 to r352873 and now I'm getting PostgreSQL permission denied errors on the check phase of the build. FreeBSD

My buildfarm member now giving permission denied

2019-10-01 Thread Larry Rosenman
FreeBSD SVN rev: r352600 - - 1.69G 2019-09-22 13:13 r352873 NR / 43.1G 2019-09-29 16:36 I went from r352600 to r352873 and now I'm getting PostgreSQL permission denied errors on the check phase of the build. FreeBSD folks: Any ideas? PostgreSQL folks: FYI. --

RE: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Smith, Peter
From: Amit Kapila Sent: Tuesday, 1 October 2019 8:12 PM > +1. This seems like an improvement. I can review and take this forward > unless there are objections from others. FYI - I created a Commitfest entry for this here: https://commitfest.postgresql.org/25/2290/ Kind Regards -- Peter

Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Amit Kapila
On Wed, Oct 2, 2019 at 4:53 AM Smith, Peter wrote: > From: Isaac Morland Sent: Tuesday, 1 October > 2019 11:32 PM > > >Typical Example: > >Before: > >Datum values[Natts_pg_attribute]; > >boolnulls[Natts_pg_attribute]; > >... > >

Re: pgbench - allow to create partitioned tables

2019-10-01 Thread Amit Kapila
On Tue, Oct 1, 2019 at 8:45 PM Rafia Sabih wrote: > On Tue, 1 Oct 2019 at 16:48, Fabien COELHO wrote: > >> >> >> Yeah, I know that, but this doesn't look quite right. I mean to say >> >> whatever we want to say via this message is correct, but I am not >> >> completely happy with the display

RE: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Smith, Peter
From: Isaac Morland Sent: Tuesday, 1 October 2019 11:32 PM >Typical Example: >Before: >        Datum           values[Natts_pg_attribute]; >        bool            nulls[Natts_pg_attribute]; >        ... >        memset(values, 0, sizeof(values)); >        memset(nulls, false, sizeof(nulls));

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2019-10-01 Thread Amit Kapila
On Tue, Oct 1, 2019 at 7:21 PM Tomas Vondra wrote: > On Tue, Oct 01, 2019 at 06:55:52PM +0530, Amit Kapila wrote: > > > >On further testing, I found that the patch seems to have problems with > >toast. Consider below scenario: > >Session-1 > >Create table large_text(t1 text); > >INSERT INTO

Re: Modest proposal for making bpchar less inconsistent

2019-10-01 Thread Tom Lane
Kyotaro Horiguchi writes: > At Sat, 28 Sep 2019 08:22:22 -0400, Bruce Momjian wrote in > <2019092812.ga26...@momjian.us> >> On Fri, Sep 13, 2019 at 09:50:10PM +0200, Pavel Stehule wrote: >>> Dne pá 13. 9. 2019 16:43 uživatel Tom Lane napsal: It struck me that the real reason that we

Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Thomas Munro
On Wed, Oct 2, 2019 at 5:49 AM Andres Freund wrote: > On 2019-10-01 12:17:08 -0400, Tom Lane wrote: > > Note though that InsertPgAttributeTuple uses memset(), while some of > > these other places use MemSet(). The code I see being generated for > > MemSet() is also the same(!) on clang, but it

Re: pgsql: Implement jsonpath .datetime() method

2019-10-01 Thread Alexander Korotkov
On Mon, Sep 30, 2019 at 10:56 PM Robert Haas wrote: > On Sun, Sep 29, 2019 at 10:30 AM Alexander Korotkov > wrote: > > So, jsonpath behaves like 100 is not greater than 2020. This > > looks like plain false. And user can't expect that unless she is > > familiar with our particular issues.

Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Andres Freund
Hi, On 2019-10-01 12:17:08 -0400, Tom Lane wrote: > FYI, I checked into whether this would result in worse generated code. > In the one place I checked (InsertPgAttributeTuple, which hopefully > is representative), I got *exactly the same* assembly code before > and after, on both a

Re: Value of Transparent Data Encryption (TDE)

2019-10-01 Thread Bruce Momjian
On Tue, Oct 1, 2019 at 11:54:26AM -0400, Bruce Momjian wrote: > On Tue, Oct 1, 2019 at 03:43:05PM +0200, Tomas Vondra wrote: > > Plus it allows features you can't easily achieve with fs encryption, > > because the filesystem only sees opaque data files. So having keys per > > database/user/...

Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Tom Lane
Bruce Momjian writes: >>> On Tue, Oct 1, 2019 at 1:25 PM Smith, Peter >>> wrote: There are lots of tuple operations where arrays of values and flags are being passed. Typically these arrays are being previously initialised 0/false by memset. By modifying code to use C99

RE: Shared Memory: How to use SYSV rather than MMAP ?

2019-10-01 Thread REIX, Tony
Hi, I've been able to rebuild the 12rc1 on AIX 7.2 with my old patches, except the one dealing with shared memory for sure. Tests are running. I'll look at the proposed patch tomorrow. Regards, Tony De : Alvaro Herrera Envoyé : vendredi 27 septembre 2019 14:39

Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Bruce Momjian
On Tue, Oct 1, 2019 at 08:40:26AM -0400, Andrew Dunstan wrote: > > On 10/1/19 6:12 AM, Amit Kapila wrote: > > On Tue, Oct 1, 2019 at 1:25 PM Smith, Peter > > wrote: > >> Dear Hackers, > >> > >> I have identified some OSS code which maybe can make use of C99 designated > >> initialisers for

Re: Value of Transparent Data Encryption (TDE)

2019-10-01 Thread Bruce Momjian
On Tue, Oct 1, 2019 at 03:43:05PM +0200, Tomas Vondra wrote: > On Mon, Sep 30, 2019 at 05:40:52PM -0400, Bruce Momjian wrote: > Maybe. I think this is approaching the problem from the wrong angle. > Encryption is more a means of achieving something. OK, for compliance > purposes it's useful to be

Re: Peripatus: Can someone look?

2019-10-01 Thread Larry Rosenman
On 10/01/2019 10:46 am, Tom Lane wrote: Larry Rosenman writes: My Buildfarm animal (peripatus) has been failing check since yesterday. Can someone look at it? It's been doing this in parallel queries, in v11 and up: 2019-09-29 19:00:15.534 CDT [49513:1] ERROR: could not open shared memory

Re: Peripatus: Can someone look?

2019-10-01 Thread Tom Lane
Larry Rosenman writes: > My Buildfarm animal (peripatus) has been failing check since yesterday. > Can someone look at it? It's been doing this in parallel queries, in v11 and up: 2019-09-29 19:00:15.534 CDT [49513:1] ERROR: could not open shared memory segment "/PostgreSQL.1225945786":

Re: Optimize partial TOAST decompression

2019-10-01 Thread Tom Lane
Tomas Vondra writes: > On Tue, Oct 01, 2019 at 10:10:37AM -0400, Tom Lane wrote: >> Maybe it accidentally seems to work on little-endian, thanks to the >> different definitions of varlena headers? > Maybe. Let's see if just using VARSIZE_ANY does the trick. If not, I'll > investigate further.

Peripatus: Can someone look?

2019-10-01 Thread Larry Rosenman
My Buildfarm animal (peripatus) has been failing check since yesterday. Can someone look at it? -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: l...@lerctr.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106

Re: pgbench - allow to create partitioned tables

2019-10-01 Thread Rafia Sabih
On Tue, 1 Oct 2019 at 16:48, Fabien COELHO wrote: > > >> Yeah, I know that, but this doesn't look quite right. I mean to say > >> whatever we want to say via this message is correct, but I am not > >> completely happy with the display part. How about something like: > >> "pgbench_accounts is

Re: Optimize partial TOAST decompression

2019-10-01 Thread Tomas Vondra
On Tue, Oct 01, 2019 at 10:10:37AM -0400, Tom Lane wrote: Tomas Vondra writes: Hmmm, this seems to trigger a failure on thorntail, which is a sparc64 machine (and it seems to pass on all x86 machines, so far). gharial's not happy either, and I bet if you wait a bit longer you'll see the same

Re: Transparent Data Encryption (TDE) and encrypted files

2019-10-01 Thread Bruce Momjian
On Tue, Oct 1, 2019 at 03:48:31PM +0200, Tomas Vondra wrote: > IMO leaks of sensitive data into the server log (say, as part of error > messages, slow queries, ...) are a serious issue. It's one of the main > issues with pgcrypto-style encryption, because it's trivial to leak e.g. > keys into the

Re: pgbench - allow to create partitioned tables

2019-10-01 Thread Fabien COELHO
Yeah, I know that, but this doesn't look quite right. I mean to say whatever we want to say via this message is correct, but I am not completely happy with the display part. How about something like: "pgbench_accounts is missing, you need to do initialization (\"pgbench -i\") in database

Re: pgbench - allow to create partitioned tables

2019-10-01 Thread Rafia Sabih
On Tue, 1 Oct 2019 at 15:39, Amit Kapila wrote: > On Tue, Oct 1, 2019 at 11:51 AM Fabien COELHO wrote: > >> >> Hello Amit, >> >> > 1. ran pgindent >> > 2. As per Alvaro's suggestions move few function definitions. >> > 3. Changed one or two comments and fixed spelling at one place. >> >> Thanks

Re: Optimize partial TOAST decompression

2019-10-01 Thread Tom Lane
Tomas Vondra writes: > Hmmm, this seems to trigger a failure on thorntail, which is a sparc64 > machine (and it seems to pass on all x86 machines, so far). gharial's not happy either, and I bet if you wait a bit longer you'll see the same on other big-endian machines. > I wonder if that's

pg_basebackup from REL_12_STABLE hands on solaris/sparch

2019-10-01 Thread Victor Wagner
Collegues, I've encountered following problem on some old Sparc64 machine running solaris 10: When I compile postgresql 12 with --enable-tap-tests and run make check in src/bin, test src/bin/pg_basebackup/t/010_pg_basebackup.pl hangs and hangs infinitely. I've tried to attach gdb to the

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2019-10-01 Thread Tomas Vondra
On Tue, Oct 01, 2019 at 06:55:52PM +0530, Amit Kapila wrote: On Sun, Sep 29, 2019 at 11:24 AM Amit Kapila wrote: On Sun, Sep 29, 2019 at 12:39 AM Tomas Vondra wrote: > Yeah, it is better to deal it separately as I am also not entirely convinced at this stage about this parameter. I have

Re: Transparent Data Encryption (TDE) and encrypted files

2019-10-01 Thread Tomas Vondra
On Tue, Oct 01, 2019 at 06:30:39PM +0900, Moon, Insung wrote: Dear Magnus Hagander. On Tue, Oct 1, 2019 at 5:37 PM Magnus Hagander wrote: On Tue, Oct 1, 2019 at 9:33 AM Tels wrote: Moin, On 2019-09-30 23:26, Bruce Momjian wrote: > For full-cluster Transparent Data Encryption (TDE),

Re: Value of Transparent Data Encryption (TDE)

2019-10-01 Thread Tomas Vondra
On Mon, Sep 30, 2019 at 05:40:52PM -0400, Bruce Momjian wrote: For plan for full-cluster Transparent Data Encryption (TDE) is here: https://wiki.postgresql.org/wiki/Transparent_Data_Encryption#TODO_for_Full-Cluster_Encryption The values it has, I think, are: * encrypts data for

Re: pgbench - allow to create partitioned tables

2019-10-01 Thread Amit Kapila
On Tue, Oct 1, 2019 at 11:51 AM Fabien COELHO wrote: > > Hello Amit, > > > 1. ran pgindent > > 2. As per Alvaro's suggestions move few function definitions. > > 3. Changed one or two comments and fixed spelling at one place. > > Thanks for the improvements. > > Not sure why you put "XXX - " in

Re: [HACKERS] Block level parallel vacuum

2019-10-01 Thread Masahiko Sawada
On Tue, Oct 1, 2019 at 10:31 PM Amit Kapila wrote: > > On Sat, Sep 21, 2019 at 6:01 PM Amit Kapila wrote: >> >> On Fri, Jun 7, 2019 at 12:03 PM Masahiko Sawada >> wrote: >> > >> > Since the previous version patch conflicts with current HEAD, I've >> > attached the updated version patches. >> >

Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Isaac Morland
On Tue, 1 Oct 2019 at 03:55, Smith, Peter wrote: > Typical Example: > Before: > Datum values[Natts_pg_attribute]; > boolnulls[Natts_pg_attribute]; > ... > memset(values, 0, sizeof(values)); > memset(nulls, false, sizeof(nulls)); >

Re: [HACKERS] Block level parallel vacuum

2019-10-01 Thread Amit Kapila
On Sat, Sep 21, 2019 at 6:01 PM Amit Kapila wrote: > On Fri, Jun 7, 2019 at 12:03 PM Masahiko Sawada > wrote: > > > > Since the previous version patch conflicts with current HEAD, I've > > attached the updated version patches. > > > > Review comments: > -- >

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2019-10-01 Thread Amit Kapila
On Sun, Sep 29, 2019 at 11:24 AM Amit Kapila wrote: > On Sun, Sep 29, 2019 at 12:39 AM Tomas Vondra > wrote: > > > > Yeah, it is better to deal it separately as I am also not entirely > convinced at this stage about this parameter. I have mentioned the > same in the previous email as well. > >

Re: Optimize partial TOAST decompression

2019-10-01 Thread Tomas Vondra
On Tue, Oct 01, 2019 at 02:34:20PM +0200, Tomas Vondra wrote: On Tue, Oct 01, 2019 at 12:08:05PM +0200, Tomas Vondra wrote: On Tue, Oct 01, 2019 at 11:20:39AM +0500, Andrey Borodin wrote: 30 сент. 2019 г., в 22:29, Tomas Vondra написал(а): On Mon, Sep 30, 2019 at 09:20:22PM +0500, Andrey

Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Andrew Dunstan
On 10/1/19 6:12 AM, Amit Kapila wrote: > On Tue, Oct 1, 2019 at 1:25 PM Smith, Peter > wrote: >> Dear Hackers, >> >> I have identified some OSS code which maybe can make use of C99 designated >> initialisers for nulls/values arrays. >> >> ~ >> >> Background: >> There are lots of tuple

Re: Optimize partial TOAST decompression

2019-10-01 Thread Tomas Vondra
On Tue, Oct 01, 2019 at 12:08:05PM +0200, Tomas Vondra wrote: On Tue, Oct 01, 2019 at 11:20:39AM +0500, Andrey Borodin wrote: 30 сент. 2019 г., в 22:29, Tomas Vondra написал(а): On Mon, Sep 30, 2019 at 09:20:22PM +0500, Andrey Borodin wrote: 30 сент. 2019 г., в 20:56, Tomas Vondra

Re: Drop Trigger Mechanism with Detached partitions

2019-10-01 Thread Robert Haas
On Mon, Sep 30, 2019 at 5:59 AM M Beena Emerson wrote: > Detach partition does not remove the partition trigger dependency as seen in > below scenario. Sounds like a bug. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: backup manifests

2019-10-01 Thread Robert Haas
On Mon, Sep 30, 2019 at 5:31 AM Jeevan Chalke wrote: > Entry for directory is not added in manifest. So it might be difficult > at client to get to know about the directories. Will it be good to add > an entry for each directory too? May be like: > Dir Well, what kind of corruption would

Re: Libpq support to connect to standby server as priority

2019-10-01 Thread Greg Nancarrow
On Wed, Sep 11, 2019 at 10:17 AM Alvaro Herrera from 2ndQuadrant wrote: > > > Oh, oops. Here they are then. > With the permission of the original patch author, Haribabu Kommi, I’ve rationalized the existing 8 patches into 3 patches, merging patches 1-5 and 6-7, and tidying up some documentation

Re: Libpq support to connect to standby server as priority

2019-10-01 Thread Greg Nancarrow
On Wed, Sep 11, 2019 at 10:17 AM Alvaro Herrera from 2ndQuadrant wrote: > > Oh, oops. Here they are then. > With the permission of the original patch author, Haribabu Kommi, I’ve rationalized the existing 8 patches into 3 patches, merging patches 1-5 and 6-7, and tidying up some documentation

Re: Change atoi to strtol in same place

2019-10-01 Thread Kyotaro Horiguchi
At Tue, 01 Oct 2019 19:32:08 +0900 (Tokyo Standard Time), Kyotaro Horiguchi wrote in <20191001.193208.264851337.horikyota@gmail.com> > Hello. > > At Sun, 29 Sep 2019 23:51:23 -0500, Joe Nelson wrote in > <20190930045123.gc68...@begriffs.com> > > Alvaro Herrera wrote: > > > ... can we

Re: Change atoi to strtol in same place

2019-10-01 Thread Kyotaro Horiguchi
Hello. At Sun, 29 Sep 2019 23:51:23 -0500, Joe Nelson wrote in <20190930045123.gc68...@begriffs.com> > Alvaro Herrera wrote: > > ... can we have a new patch? > > OK, I've attached v4. It works cleanly on 55282fa20f with > str2int-16.patch applied. My patch won't compile without the other one >

Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Amit Kapila
On Tue, Oct 1, 2019 at 1:25 PM Smith, Peter wrote: > > Dear Hackers, > > I have identified some OSS code which maybe can make use of C99 designated > initialisers for nulls/values arrays. > > ~ > > Background: > There are lots of tuple operations where arrays of values and flags are being >

Re: Optimize partial TOAST decompression

2019-10-01 Thread Tomas Vondra
On Tue, Oct 01, 2019 at 11:20:39AM +0500, Andrey Borodin wrote: 30 сент. 2019 г., в 22:29, Tomas Vondra написал(а): On Mon, Sep 30, 2019 at 09:20:22PM +0500, Andrey Borodin wrote: 30 сент. 2019 г., в 20:56, Tomas Vondra написал(а): I mean this: /* * Use int64 to prevent overflow

Re: Modest proposal for making bpchar less inconsistent

2019-10-01 Thread Kyotaro Horiguchi
At Sat, 28 Sep 2019 08:22:22 -0400, Bruce Momjian wrote in <2019092812.ga26...@momjian.us> > On Fri, Sep 13, 2019 at 09:50:10PM +0200, Pavel Stehule wrote: > > > > > > Dne pá 13. 9. 2019 16:43 uživatel Tom Lane napsal: > > > > It struck me that the real reason that we keep getting

Re: Transparent Data Encryption (TDE) and encrypted files

2019-10-01 Thread Moon, Insung
Dear Magnus Hagander. On Tue, Oct 1, 2019 at 5:37 PM Magnus Hagander wrote: > > > > On Tue, Oct 1, 2019 at 9:33 AM Tels wrote: >> >> Moin, >> >> On 2019-09-30 23:26, Bruce Momjian wrote: >> > For full-cluster Transparent Data Encryption (TDE), the current plan is >> > to encrypt all heap and

About Google Code-in

2019-10-01 Thread Sakshi Munjal
Greetings, I am Sakshi Munjal and I would like to know how I can apply to google code-in as mentor with your organization. I have great interest in coding and I like to spend my free time learning new things. I have developed my skills in full stack web development, I have knowledge about machine

Re: Attempt to consolidate reading of XLOG page

2019-10-01 Thread Kyotaro Horiguchi
At Tue, 01 Oct 2019 08:28:03 +0200, Antonin Houska wrote in <2188.1569911283@antos> > Kyotaro Horiguchi wrote: > > > > XLogRead() tests for NULL so it should not crash but I don't insist on > > > > doing > > > > it this way. XLogRead() actually does not have to care whether the "open > > > >

Re: Transparent Data Encryption (TDE) and encrypted files

2019-10-01 Thread Magnus Hagander
On Tue, Oct 1, 2019 at 9:33 AM Tels wrote: > Moin, > > On 2019-09-30 23:26, Bruce Momjian wrote: > > For full-cluster Transparent Data Encryption (TDE), the current plan is > > to encrypt all heap and index files, WAL, and all pgsql_tmp (work_mem > > overflow). The plan is: > > > > >

Re: Transparent Data Encryption (TDE) and encrypted files

2019-10-01 Thread Moon, Insung
Dear Tels. On Tue, Oct 1, 2019 at 4:33 PM Tels wrote: > > Moin, > > On 2019-09-30 23:26, Bruce Momjian wrote: > > For full-cluster Transparent Data Encryption (TDE), the current plan is > > to encrypt all heap and index files, WAL, and all pgsql_tmp (work_mem > > overflow). The plan is: > > > >

Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-10-01 Thread Smith, Peter
Dear Hackers, I have identified some OSS code which maybe can make use of C99 designated initialisers for nulls/values arrays. ~ Background: There are lots of tuple operations where arrays of values and flags are being passed. Typically these arrays are being previously initialised 0/false by

Declaring a strict function returns not null / eval speed

2019-10-01 Thread Andres Freund
Hi, We spend a surprising amount of time during expression evaluation to reevaluate whether input to a strict function (or similar) is not null, even though the value either comes from a strict function, or a column declared not null. Now you can rightfully say that a strict function still

Re: Transparent Data Encryption (TDE) and encrypted files

2019-10-01 Thread Tels
Moin, On 2019-09-30 23:26, Bruce Momjian wrote: For full-cluster Transparent Data Encryption (TDE), the current plan is to encrypt all heap and index files, WAL, and all pgsql_tmp (work_mem overflow). The plan is:

Re: Commit fest 2019-09

2019-10-01 Thread Michael Paquier
On Mon, Sep 30, 2019 at 06:20:31PM -0400, David Steele wrote: > On 9/30/19 5:26 PM, David Fetter wrote: >> >> Thanks for doing all this work! > > +1! Thanks, Alvaro! -- Michael signature.asc Description: PGP signature

Re: Keep compiler silence (clang 10, implicit conversion from 'long' to 'double' )

2019-10-01 Thread Kyotaro Horiguchi
Hello. At Fri, 27 Sep 2019 16:43:53 +0900, Yuya Watari wrote in > Hello, > > I add further information. This issue also has a problem about > *overflow checking*. > > The original code is as follows. > > src/backend/utils/adt/timestamp.c:3222 > - > if (result_double > PG_INT64_MAX ||

Re: Attempt to consolidate reading of XLOG page

2019-10-01 Thread Antonin Houska
Kyotaro Horiguchi wrote: > At Sat, 28 Sep 2019 15:00:35 +0200, Antonin Houska wrote > in <9236.1569675635@antos> > > Antonin Houska wrote: > > > > > Alvaro Herrera wrote: > > > > > > > BTW that tli_p business to the openSegment callback is horribly > > > > inconsistent. Some callers

Re: Optimize partial TOAST decompression

2019-10-01 Thread Andrey Borodin
> 30 сент. 2019 г., в 22:29, Tomas Vondra > написал(а): > > On Mon, Sep 30, 2019 at 09:20:22PM +0500, Andrey Borodin wrote: >> >> >>> 30 сент. 2019 г., в 20:56, Tomas Vondra >>> написал(а): >>> >>> I mean this: >>> >>> /* >>> * Use int64 to prevent overflow during calculation. >>>

Re: pgbench - allow to create partitioned tables

2019-10-01 Thread Fabien COELHO
Hello Amit, 1. ran pgindent 2. As per Alvaro's suggestions move few function definitions. 3. Changed one or two comments and fixed spelling at one place. Thanks for the improvements. Not sure why you put "XXX - " in front of "append_fillfactor" comment, though. + fprintf(stderr, + "no