Re: xl_heap_header alignment?

On Fri, Aug 21, 2020 at 5:41 PM Bruce Momjian wrote: > On Wed, Jul 22, 2020 at 06:58:33AM +0200, Antonin Houska wrote: > > Tom Lane wrote: > > > > > I don't particularly want to remove the field, but we ought to > > > change or remove the comment. > > > > I'm not concerned about the existence

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

On Fri, Aug 21, 2020 at 5:10 PM Dilip Kumar wrote: > > I have reviewed and tested the patch and the changes look fine to me. > Thanks, I will push the next patch early next week (by Tuesday) unless you or someone else has any more comments on it. The summary of the patch

Re: Improve Managing Databases Overview Doc Page

On Thu, Jul 16, 2020 at 02:55:54PM -0700, David G. Johnston wrote: > Hackers, > > As a reaction to this documentation comment [1] I went through the main > paragraph of the Database Management Overview and came up with the reworded > and > expanded page.  Proposed for HEAD only.  Added to the

Re: xl_heap_header alignment?

On Wed, Jul 22, 2020 at 06:58:33AM +0200, Antonin Houska wrote: > Tom Lane wrote: > > > I don't particularly want to remove the field, but we ought to > > change or remove the comment. > > I'm not concerned about the existence of the field as well. The comment just > made me worried that I

Re: Documentation patch for backup manifests in protocol.sgml

On Tue, Aug 18, 2020 at 02:41:09PM +0200, Bernd Helmle wrote: > Hi, > > protocol.sgml describes the protocol messages received by a BASE_BACKUP > streaming command, but doesn't tell anything about the additional > CopyResponse data message containing the contents of the backup > manifest (if

Re: Problems with the FSM, heap fillfactor, and temporal locality

Hi John, On Fri, Aug 21, 2020 at 3:10 AM John Naylor wrote: > Interesting stuff. Is lower-than-default fillfactor important for the > behavior you see? It's hard to say. It's definitely not important as far as the initial bulk loading behavior is concerned (the behavior where related tuples get

Re: deb repo doesn't have latest. or possible to update web page?

On Thu, Aug 20, 2020 at 10:38 PM Roger Pack wrote: > On Wed, Aug 19, 2020 at 11:23 AM Magnus Hagander > wrote: > > > > > > > > On Wed, Aug 19, 2020 at 7:04 PM Roger Pack > wrote: > >> > >> As a note I tried to use the deb repo today: > >> > >> https://www.postgresql.org/download/linux/debian/

Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)

On 2020/08/22 1:04, Fujii Masao wrote: On 2020/08/21 23:53, Tom Lane wrote: Fujii Masao writes: Pushed. Thanks! Buildfarm shows this patch has got problems under -DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:

Re: run pgindent on a regular basis / scripted manner

On Fri, Aug 14, 2020 at 10:26 PM Alvaro Herrera wrote: > On 2020-Aug-13, Magnus Hagander wrote: > > > That is: > > 1. Whenever a patch is pushed on master on the main repo a process kicked > > off (or maybe wait 5 minutes to coalesce multiple patches if there are) > > 2. This process checks out

Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits

On Wed, Aug 19, 2020 at 6:15 PM Anastasia Lubennikova < a.lubennik...@postgrespro.ru> wrote: > On 18.08.2020 02:54, Alvaro Herrera wrote: > > On 2020-Aug-14, Ibrar Ahmed wrote: > > > >> The table used for the test contains three columns (integer, text, > >> varchar). > >> The total number of rows

Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)

On 2020/08/21 23:53, Tom Lane wrote: Fujii Masao writes: Pushed. Thanks! Buildfarm shows this patch has got problems under -DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion=2020-08-21%2011%3A54%3A12 Thanks for the

Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)

Fujii Masao writes: > Pushed. Thanks! Buildfarm shows this patch has got problems under -DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion=2020-08-21%2011%3A54%3A12 regards, tom lane

Re: Creating a function for exposing memory usage of backend process

Thanks for all your comments! Thankfully it seems that this feature is regarded as not meaningless one, I'm going to do some improvements. On Wed, Aug 19, 2020 at 10:56 PM Michael Paquier wrote: On Wed, Aug 19, 2020 at 06:12:02PM +0900, Fujii Masao wrote: On 2020/08/19 17:40, torikoshia

Re: recovering from "found xmin ... from before relfrozenxid ..."

Hi Masahiko-san, Please find the updated patch with the following new changes: 1) It adds the code changes in heap_force_kill function to clear an all-visible bit on the visibility map corresponding to the page that is marked all-visible. Along the way it also clears PD_ALL_VISIBLE flag on the

Re: Implementing Incremental View Maintenance

From: Yugo NAGATA Subject: Re: Implementing Incremental View Maintenance Date: Fri, 21 Aug 2020 17:23:20 +0900 Message-ID: <20200821172320.a2506577d5244b6066f69...@sraoss.co.jp> > On Wed, 19 Aug 2020 10:02:42 +0900 (JST) > Tatsuo Ishii wrote: > >> I have looked into this. > > Thank you for

Re: [POC] Fast COPY FROM command for the table with foreign partitions

On 8/7/20 2:14 PM, Amit Langote wrote: I was playing around with v5 and I noticed an assertion failure which I concluded is due to improper setting of ri_usesBulkModify. You can reproduce it with these steps. create extension postgres_fdw; create server lb foreign data wrapper postgres_fdw ;

Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)

On 2020/08/21 14:54, Pierre Giraud wrote: Le 20/08/2020 à 17:41, Fujii Masao a écrit : On 2020/08/20 22:34, Julien Rouhaud wrote: On Thu, Aug 20, 2020 at 12:29 PM David Rowley wrote: On Thu, 20 Aug 2020 at 19:58, Fujii Masao wrote: On 2020/08/20 13:00, David Rowley wrote: I forgot

Re: [POC]Enable tuple change partition caused by BEFORE TRIGGER

On Fri, Aug 21, 2020 at 1:28 PM movead...@highgo.ca wrote: > > Hello hackers, > > Currently, if BEFORE TRIGGER causes a partition change, it reports an error > 'moving row > to another partition during a BEFORE FOR EACH ROW trigger is not supported' > and fails > to execute. I want to try to

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

On Fri, Aug 21, 2020 at 3:13 PM Amit Kapila wrote: > > On Fri, Aug 21, 2020 at 10:33 AM Dilip Kumar wrote: > > > > On Fri, Aug 21, 2020 at 9:14 AM Amit Kapila wrote: > > > > > > 2. > > > + /* > > > + * If the new location is smaller then the current location in file then > > > + * we need to

Re: Bogus documentation for bogus geometric operators

> While revising the docs for the geometric operators, I came across > these entries: > > <^ Is below (allows touching)? circle '((0,0),1)' <^ circle > '((0,5),1)' > >^ Is above (allows touching)? circle '((0,5),1)' >^ circle > >'((0,0),1)' > > These have got more than a few

Re: Problems with the FSM, heap fillfactor, and temporal locality

On Fri, Aug 21, 2020 at 2:48 AM Peter Geoghegan wrote: > > I'm concerned about how the FSM gives out pages to heapam. Disabling > the FSM entirely helps TPC-C/BenchmarkSQL, which uses non-default heap > fillfactors for most tables [1]. Hi Peter, Interesting stuff. Is lower-than-default

Re: proposal - function string_to_table

pá 21. 8. 2020 v 11:08 odesílatel Pavel Stehule napsal: > > > pá 21. 8. 2020 v 9:44 odesílatel Peter Smith > napsal: > >> On Fri, Aug 21, 2020 at 5:21 AM Pavel Stehule >> wrote: >> >> > new patch attached >> >> Thanks for taking some of my previous review comments. >> >> I have re-checked the

Re: proposal - function string_to_table

pá 21. 8. 2020 v 9:44 odesílatel Peter Smith napsal: > On Fri, Aug 21, 2020 at 5:21 AM Pavel Stehule > wrote: > > > new patch attached > > Thanks for taking some of my previous review comments. > > I have re-checked the string_to_table_20200820.patch. > > Below are some remaining

[POC]Enable tuple change partition caused by BEFORE TRIGGER

Hello hackers, Currently, if BEFORE TRIGGER causes a partition change, it reports an error 'moving row to another partition during a BEFORE FOR EACH ROW trigger is not supported' and fails to execute. I want to try to address this limitation and have made an initial patch to get feedback from

Re: Implementing Incremental View Maintenance

On Wed, 19 Aug 2020 10:02:42 +0900 (JST) Tatsuo Ishii wrote: > I have looked into this. Thank you for your reviewing! > - 0004-Allow-to-prolong-life-span-of-transition-tables-unti.patch: > This one needs a comment to describe what the function does etc. > > +void >

Re: Libpq support to connect to standby server as priority

Hi Greg, > Thanks for the further review, an updated patch is attached. Please > see my responses to your comments below: > Thanks for addressing all of my previous review comments in your new v19 patch. Everything looks good to me now, so I am marking this as "ready for committer". Kind

Re: proposal - function string_to_table

On Fri, Aug 21, 2020 at 5:21 AM Pavel Stehule wrote: > new patch attached Thanks for taking some of my previous review comments. I have re-checked the string_to_table_20200820.patch. Below are some remaining questions/comments: COMMENT (help text) +Splits the string at

Re: display offset along with block number in vacuum errors

On Thu, 20 Aug 2020 at 21:12, Amit Kapila wrote: > > On Thu, Aug 20, 2020 at 12:32 PM Amit Kapila wrote: > > > > On Thu, Aug 20, 2020 at 12:18 PM Masahiko Sawada > > wrote: > > > > > > On Thu, 20 Aug 2020 at 14:01, Amit Kapila wrote: > > > > > > > > On Wed, Aug 19, 2020 at 12:54 PM Masahiko

Re: Fix typo in procarrary.c

On Fri, 21 Aug 2020 at 12:39, Fujii Masao wrote: > > > > On 2020/08/21 12:29, Masahiko Sawada wrote: > > On Fri, 21 Aug 2020 at 11:18, Fujii Masao > > wrote: > >> > >> > >> > >> On 2020/08/21 10:58, Masahiko Sawada wrote: > >>> Hi, > >>> > >>> I've attached the patch for $subject. > >>> > >>>

Re: Asymmetric partition-wise JOIN

On 7/1/20 2:10 PM, Daniel Gustafsson wrote: On 27 Dec 2019, at 08:34, Kohei KaiGai wrote: The attached v2 fixed the problem, and regression test finished correctly. This patch no longer applies to HEAD, please submit an rebased version. Marking the entry Waiting on Author in the meantime.