Re: Log message for GSS connection is missing once connection authorization is successful.

2021-03-21 Thread Bharath Rupireddy
On Sat, Mar 20, 2021 at 4:59 PM Michael Paquier wrote: > > On Sat, Mar 20, 2021 at 05:37:47PM +0900, Michael Paquier wrote: > > It seems to me that this would make the tests faster, that the test > > would not need to wait for the logging collector and that the code > > could just use

Re: pg_upgrade failing for 200+ million Large Objects

2021-03-21 Thread Andrew Dunstan
On 3/20/21 12:55 PM, Jan Wieck wrote: > On 3/20/21 11:23 AM, Tom Lane wrote: >> Jan Wieck writes: >>> All that aside, the entire approach doesn't scale. >> >> Yeah, agreed.  When we gave large objects individual ownership and ACL >> info, it was argued that pg_dump could afford to treat each

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-03-21 Thread er
> On 2021.03.20. 19:48 Gilles Darold wrote: > > This is a new version of the patch that now implements all the XQUERY > regexp functions as described in the standard, minus the differences of > PostgerSQL regular expression explain in [1]. > > The standard SQL describe functions like_regex(),

RE: [HACKERS] logical decoding of two-phase transactions

2021-03-21 Thread osumi.takami...@fujitsu.com
Hello On Sunday, March 21, 2021 4:37 PM Amit Kapila > On Sat, Mar 20, 2021 at 10:09 AM Ajin Cherian wrote: > > > > On Sat, Mar 20, 2021 at 1:35 AM Amit Kapila > wrote: > >> > >> On Fri, Mar 19, 2021 at 5:03 AM Ajin Cherian wrote: > >> > > >> > Missed the patch - 0001, resending. > >> > > >>

Re: [PATCH] Provide more information to filter_prepare

2021-03-21 Thread Amit Kapila
On Sat, Mar 13, 2021 at 3:43 PM Amit Kapila wrote: > > On Thu, Mar 11, 2021 at 2:44 PM Markus Wanner > wrote: > > > > On 11.03.21 04:58, Amit Kapila wrote: > > > But this happens when we are decoding prepare, so it is clear that the > > > transaction is prepared, why any additional check? > > >

Re: proposal - psql - use pager for \watch command

2021-03-21 Thread Pavel Stehule
so 20. 3. 2021 v 23:45 odesílatel Thomas Munro napsal: > On Thu, Mar 4, 2021 at 11:28 PM Pavel Stehule > wrote: > > čt 4. 3. 2021 v 7:37 odesílatel Pavel Stehule > napsal: > >> Here is a little bit updated patch - detection of end of any child > process cannot be used on WIN32. > > Yeah, it's

Re: Replication slot stats misgivings

2021-03-21 Thread Amit Kapila
On Sun, Mar 21, 2021 at 2:56 AM Andres Freund wrote: > > On 2021-03-20 09:25:40 +0530, Amit Kapila wrote: > > On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote: > > > > > > And then more generally about the feature: > > > - If a slot was used to stream out a large amount of changes (say an >

Re: Replication slot stats misgivings

2021-03-21 Thread Amit Kapila
On Sun, Mar 21, 2021 at 2:57 AM Andres Freund wrote: > > Hi, > > On 2021-03-20 10:28:06 +0530, Amit Kapila wrote: > > On Sat, Mar 20, 2021 at 9:25 AM Amit Kapila wrote: > > > This idea is worth exploring to address the complaints but what do we > > > do when we detect that the stats are from the

Re: replication cleanup code incorrect way to use of HTAB HASH_REMOVE ?

2021-03-21 Thread Amit Kapila
On Sat, Mar 20, 2021 at 12:54 PM Peter Smith wrote: > > PSA my patch to correct this by firstly doing a HASH_FIND, then only > HASH_REMOVE after we've finished using the ent. > Why can't we keep using HASH_REMOVE as it is but get the output (entry found or not) in the last parameter of

Re: Logical Replication vs. 2PC

2021-03-21 Thread Amit Kapila
On Sun, Mar 21, 2021 at 2:47 PM Markus Wanner wrote: > > On 20.03.21 16:14, Amit Kapila wrote: > > Right, but I guess in our case using user-provided GID will conflict > > if we use multiple subscriptions on the same node. So, it is better to > > generate a unique identifier like we are

Re: proposal - psql - use pager for \watch command

2021-03-21 Thread Pavel Stehule
ne 21. 3. 2021 v 0:42 odesílatel Thomas Munro napsal: > On Sun, Mar 21, 2021 at 11:44 AM Thomas Munro > wrote: > > [review] > > Oh, just BTW, to save confusion for others who might try this: It > seems there is something wrong with pspg --stream on macOS, at least > when using MacPorts. I

Re: Using COPY FREEZE in pgbench

2021-03-21 Thread Tatsuo Ishii
> The feature is a little disappointing because if someone has partition > tables then probably they have a lot of data and probably they would > like freeze to work there. Maybe freeze would work on table partitions > themselves, but I do not think it is worth the effort to do that. Agreed. >

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-03-21 Thread Gilles Darold
Le 20/03/2021 à 19:48, Gilles Darold a écrit : > > Hi, > > > This is a new version of the patch that now implements all the XQUERY > regexp functions as described in the standard, minus the differences > of PostgerSQL regular expression explain in [1]. > > > The standard SQL describe functions

Re: Logical Replication vs. 2PC

2021-03-21 Thread Markus Wanner
On 20.03.21 16:14, Amit Kapila wrote: Right, but I guess in our case using user-provided GID will conflict if we use multiple subscriptions on the same node. So, it is better to generate a unique identifier like we are discussing here, something like (origin_id of subscription + xid of the

Re: Using COPY FREEZE in pgbench

2021-03-21 Thread Fabien COELHO
V3 works for me and looks ok. I changed it to ready in the CF app. Thank you for your review! Unfortunately it seems cfbot is not happy with the patch. Argh. Indeed, I did not thought of testing on a partitioned table:-( ISTM I did "make check" in pgbench to trigger tap tests, but

Re: cleaning up a few CLOG-related things

2021-03-21 Thread Noah Misch
On Wed, Jan 27, 2021 at 12:35:30PM -0500, Robert Haas wrote: > On Mon, Jan 25, 2021 at 2:11 PM Heikki Linnakangas wrote: > > Having a separate FullTransactionIdToLatestPageNumber() function for > > this seems like overkill to me. > > I initially thought so too, but it turned out to be pretty

Re: New IndexAM API controlling index vacuum strategies

2021-03-21 Thread Greg Stark
On Thu, 18 Mar 2021 at 14:37, Peter Geoghegan wrote: > They usually involve some *combination* of Postgres problems, > application code problems, and DBA error. Not any one thing. I've seen > problems with application code that runs DDL at scheduled intervals, > which interacts badly with vacuum

Re: fdatasync performance problem with large number of DB files

2021-03-21 Thread Greg Stark
On Wed, 10 Mar 2021 at 20:25, Tom Lane wrote: > > So this means that in less-than-bleeding-edge kernels, syncfs can > only be regarded as a dangerous toy. If we expose an option to use > it, there had better be large blinking warnings in the docs. Isn't that true for fsync and everything else

Re: Logical Replication vs. 2PC

2021-03-21 Thread Amit Kapila
On Sat, Mar 20, 2021 at 8:53 PM Amit Kapila wrote: > > On Sat, Mar 20, 2021 at 4:02 PM Dilip Kumar wrote: > > > > On Sat, Mar 20, 2021 at 7:50 AM Amit Kapila wrote: > > > > > > On Fri, Mar 19, 2021 at 9:22 PM Markus Wanner > > > wrote: > > > > > So, I think you are using xid of publisher and

Re: [HACKERS] Custom compression methods (mac+lz4.h)

2021-03-21 Thread Dilip Kumar
On Sun, Mar 21, 2021 at 7:03 AM Tom Lane wrote: > Also, I see some diffs in the > indirect_toast test, which seems perhaps worthy of investigation. > (The diffs look to be just row ordering, but why?) I have investigated that, actually in the below insert, after compression the data size of

Re: [PATCH] Identify LWLocks in tracepoints

2021-03-21 Thread Peter Eisentraut
On 19.03.21 21:06, Peter Eisentraut wrote: On 18.03.21 07:34, Craig Ringer wrote:     In patch 0001, why was the TRACE_POSTGRESQL_LWLOCK_RELEASE() call     moved?   Is there some correctness issue?  If so, we should explain that (at     least in the commit message, or as a separate

Re: new release pspg

2021-03-21 Thread Pavel Stehule
Hi ne 21. 3. 2021 v 7:40 odesílatel Greg Stark napsal: > This is really cool. Now I just need to figure out how to > integrate it with using Emacs for my terminal. I still want to use > emacs enter and edit my queries but it would be cool to be able to hit > a key and launch an xterm and

Re: new release pspg

2021-03-21 Thread Greg Stark
This is really cool. Now I just need to figure out how to integrate it with using Emacs for my terminal. I still want to use emacs enter and edit my queries but it would be cool to be able to hit a key and launch an xterm and send the query output to pspg

Re: Using COPY FREEZE in pgbench

2021-03-21 Thread Tatsuo Ishii
>> V3 works for me and looks ok. I changed it to ready in the CF app. > > Thank you for your review! Unfortunately it seems cfbot is not happy with the patch. # Failed test 'pgbench scale 1 initialization status (got 1 vs expected 0)' # at t/001_pgbench_with_server.pl line 116. # Failed

<    1   2