Re: Fix a few typos in brin_minmax_multi.c

On Sat, 5 Jun 2021 at 16:33, David Rowley wrote: > During a recent cleanup of brin_minmax_multi.c I noticed a few typos. > I've attached a patch to fix these. I ended up finding a few more in mcv.c and push them. David

Re: Fix dropped object handling in pg_event_trigger_ddl_commands

On Wed, Jun 09, 2021 at 09:55:08AM -0400, Alvaro Herrera wrote: > I'm not sure if we can reasonably implement a fix for older releases. > I mean, it's a relatively easy test: do a syscache search for the object > or a catalog indexscan (easy to do with get_object_property_data-based > API), and if

Re: A test for replay of regression tests

On Thu, Jun 10, 2021 at 7:37 PM Anastasia Lubennikova wrote: > вт, 8 июн. 2021 г. в 02:44, Anastasia Lubennikova : >> Thank you for working on this test set! >> I was especially glad to see the skip-tests option for pg_regress. I think >> it will become a very handy tool for hackers. >> >> To

Re: A test for replay of regression tests

вт, 8 июн. 2021 г. в 02:44, Anastasia Lubennikova : > > вт, 8 июн. 2021 г. в 02:25, Thomas Munro : > >> Ok, here's a new version incorporating feedback so far. >> >> 1. Invoke pg_regress directly (no make). >> >> 2. Use PG_TEST_EXTRA="wal_consistency_checking" as a way to opt in to >> the more

"an SQL" vs. "a SQL"

I thought it might be worth having this conversation before we branch for v15. It seems we have no standard as to if we say "a SQL" or "an SQL". Personally, I pronounce the language as es-que-ell, so I'd write "an SQL". If you say "sequel", then you'll think differently. The reason I do this is

RE: Transactions involving multiple postgres foreign servers, take 2

From: Kyotaro Horiguchi > If we accept each elementary-commit (via FDW connection) to fail, the > parent(?) there's no way the root 2pc-commit can succeed. How can we > ignore the fdw-error in that case? No, we don't ignore the error during FDW commit. As mentioned at the end of this mail,

Re: Logical replication keepalive flood

On Thu, Jun 10, 2021 at 11:42 AM Kyotaro Horiguchi wrote: > > At Thu, 10 Jun 2021 15:00:16 +0900 (JST), Kyotaro Horiguchi > wrote in > > At Wed, 9 Jun 2021 17:32:25 +0500, Abbas Butt > > wrote in > > > > > > On Wed, Jun 9, 2021 at 2:30 PM Amit Kapila > > > wrote: > > > > Is it possible that

Re: Logical replication keepalive flood

At Thu, 10 Jun 2021 15:00:16 +0900 (JST), Kyotaro Horiguchi wrote in > At Wed, 9 Jun 2021 17:32:25 +0500, Abbas Butt > wrote in > > > > On Wed, Jun 9, 2021 at 2:30 PM Amit Kapila wrote: > > > Is it possible that the write/flush location is not > > > updated at the pace at which we expect?

Re: Logical replication keepalive flood

At Wed, 9 Jun 2021 17:32:25 +0500, Abbas Butt wrote in > > On Wed, Jun 9, 2021 at 2:30 PM Amit Kapila wrote: > > Does these keepalive messages are sent at the same frequency even for > > subscribers? > > Yes, I have tested it with one publisher and one subscriber. > The moment I start

<    1   2