Re: POC: Cleaning up orphaned files using undo logs

2021-09-19 Thread Antonin Houska
Amit Kapila wrote: > On Thu, Sep 9, 2021 at 8:33 PM Antonin Houska wrote: > > The problem of the temporary undo log is that it's loaded into local buffers > > and that backend can exit w/o flushing local buffers to disk, and thus we > > are > > not guaranteed to find enough information when

Re: WIP: System Versioned Temporal Table

2021-09-19 Thread Corey Huinker
On Sun, Sep 19, 2021 at 3:12 PM Hannu Krosing wrote: > A side table has the nice additional benefit that we can very easily > version the *table structure* so when we ALTER TABLE and the table > structure changes we just make a new side table with now-currents > structure. > It's true that

Re: WIP: System Versioned Temporal Table

2021-09-19 Thread Corey Huinker
> > Thanks for giving this a lot of thought. When you asked the question > the first time you hadn't discussed how that might work, but now we > have something to discuss. > My ultimate goal is to unify this effort with the application period effort. Step 1 in that was to understand what each was

Re: POC: Cleaning up orphaned files using undo logs

2021-09-19 Thread Antonin Houska
Amit Kapila wrote: > On Fri, Sep 17, 2021 at 9:50 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > > > On Tue, Sep 14, 2021 at 10:51:42AM +0200, Antonin Houska wrote: > > > > * What happened with the idea of abandoning discard worker for the sake > > of simplicity? From what I see

Re: Deduplicate code updating ControleFile's DBState.

2021-09-19 Thread Amul Sul
On Thu, Sep 16, 2021 at 5:17 AM Michael Paquier wrote: > > On Wed, Sep 15, 2021 at 10:49:39PM +, Bossart, Nathan wrote: > > Ah, I was missing this context. Perhaps this should be included in > > the patch set for the other thread, especially if it will need to be > > exported. > > This part

Re: Undocumented AT TIME ZONE INTERVAL syntax

2021-09-19 Thread Corey Huinker
> > >> Yeah, I really didn't expect to change the behavior, but wanted to make > sure that the existing behavior was understood. I'll whip up a patch. > Attached is an attempt at an explanation of the edge cases I was encountering, as well as some examples. If nothing else, the examples will draw

Unintended interaction between bottom-up deletion and deduplication's single value strategy

2021-09-19 Thread Peter Geoghegan
The return value of _bt_bottomupdel_pass() is advisory; it reports "failure" for a deletion pass that was just suboptimal (it rarely reports failure because it couldn't delete anything at all). Bottom-up deletion preemptively falls back on a version-orientated deduplication pass when it didn't

Re: Release 14 Schedule

2021-09-19 Thread Amit Kapila
On Mon, Sep 20, 2021 at 3:15 AM Jonathan S. Katz wrote: > > On 9/19/21 12:32 PM, Justin Pryzby wrote: > > On Sat, Sep 18, 2021 at 01:37:19PM -0400, Tom Lane wrote: > >> We don't yet have a list-of-major-features for the v14 release notes. > >> Anybody care to propose one? > > > > . Allow

Re: Improved PostgreSQL Mathematics Support.

2021-09-19 Thread Private Information Retrieval(PIR)
Your request is essentially to wrap the GMP library into native types in Postgres. This can be done as custom types and adding postgres extensions as you suggested originally. The work to be done is straightforward, but there is a lot of work so it would take a awhile to implement. The big

Re: Improved PostgreSQL Mathematics Support.

2021-09-19 Thread David G. Johnston
On Sunday, September 19, 2021, A Z wrote: > > Is there someone on this email list which could please have a look > at the specifications that I have posted, and reply and get back to > me? > Given the number of posts you’ve made I would have to conclude that the answer to that question is no.

Re: Logical replication keepalive flood

2021-09-19 Thread Greg Nancarrow
On Sun, Sep 19, 2021 at 3:47 PM Amit Kapila wrote: > > > > > Yes, pg_recvlogical seems to be relying on receiving a keepalive for > > its "--endpos" logic to work (and the 006 test is relying on '' record > > output from pg_recvlogical in this case). > > But is it correct to be relying on a

Improved PostgreSQL Mathematics Support.

2021-09-19 Thread A Z
Dear PostgreSQL Hackers, I have been trying to get a reply or interest in either updating PostgreSQL to support High Precision mathematical types, with arithmetic and elementary functions support, or release of an Extension which has accomplished the same thing. Is there someone on this email

Re: PoC/WIP: Extended statistics on expressions

2021-09-19 Thread Tomas Vondra
On 9/3/21 5:56 AM, Justin Pryzby wrote: On Wed, Sep 01, 2021 at 06:45:29PM +0200, Tomas Vondra wrote: However while polishing the second patch, I realized we're allowing statistics on expressions referencing system attributes. So this fails; CREATE STATISTICS s ON ctid, x FROM t; but this

Re: Release 14 Schedule

2021-09-19 Thread Jonathan S. Katz
On 9/19/21 12:32 PM, Justin Pryzby wrote: > On Sat, Sep 18, 2021 at 01:37:19PM -0400, Tom Lane wrote: >> We don't yet have a list-of-major-features for the v14 release notes. >> Anybody care to propose one? > > . Allow extended statistics on column expressions; > . Memoize node which can

Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert

2021-09-19 Thread Andrew Dunstan
On 9/17/21 5:35 PM, Greg Stark wrote: > Hm. Let's Encrypt's FAQ tells me I'm on the right track with that > question but the distinctinos are far more coarse than I was worried > about: > > > Does Let’s Encrypt issue certificates for anything other than SSL/TLS > for websites? > > Let’s Encrypt

Re: Undocumented AT TIME ZONE INTERVAL syntax

2021-09-19 Thread Corey Huinker
On Sun, Sep 19, 2021 at 10:56 AM Tom Lane wrote: > Corey Huinker writes: > >> SELECT '2018-03-04' AT TIME ZONE INTERVAL '2' HOUR TO MINUTE; > > > ... But none of this is in our own documentation. > > That's not entirely true. [1] says > > When writing an interval constant with a fields

Re: WIP: System Versioned Temporal Table

2021-09-19 Thread Hannu Krosing
A side table has the nice additional benefit that we can very easily version the *table structure* so when we ALTER TABLE and the table structure changes we just make a new side table with now-currents structure. Also we may want different set of indexes on historic table(s) for whatever reason

Re: WIP: System Versioned Temporal Table

2021-09-19 Thread Simon Riggs
On Sun, 19 Sept 2021 at 01:16, Corey Huinker wrote: >> >> 1. Much of what I have read about temporal tables seemed to imply or almost >> assume that system temporal tables would be implemented as two actual >> separate tables. Indeed, SQLServer appears to do it that way [1] with syntax >> like

Re: Release 14 Schedule

2021-09-19 Thread Justin Pryzby
On Sat, Sep 18, 2021 at 01:37:19PM -0400, Tom Lane wrote: > We don't yet have a list-of-major-features for the v14 release notes. > Anybody care to propose one? . Allow extended statistics on column expressions; . Memoize node which can improve speed of nested loop joins; . Allow use of LZ4

Re: postgres.h included from relcache.h - but removing it breaks pg_upgrade

2021-09-19 Thread Alexander Korotkov
On Sat, Sep 18, 2021 at 11:35 PM Alvaro Herrera wrote: > On 2021-Sep-18, Alexander Korotkov wrote: > > > I see now. I think I'm rather favoring splitting visibilitymap.h. > > Agreed, this looks sane to me. However, I think the > VM_ALL_{VISIBLE,FROZEN} macros should remain in visibilitymap.h,

Re: Undocumented AT TIME ZONE INTERVAL syntax

2021-09-19 Thread Tom Lane
Corey Huinker writes: >> SELECT '2018-03-04' AT TIME ZONE INTERVAL '2' HOUR TO MINUTE; > ... But none of this is in our own documentation. That's not entirely true. [1] says When writing an interval constant with a fields specification, or when assigning a string to an interval column