Re: pg_receivewal - couple of improvements

2022-02-05 Thread Bharath Rupireddy
On Sun, Feb 6, 2022 at 12:16 PM Michael Paquier wrote: > > On Thu, Feb 03, 2022 at 10:01:42PM +0800, Julien Rouhaud wrote: > > I don't get it. If you're missing WAL it means that will you have to do > > that > > tedious manual work to retrieve them no matter what. So on top of that > > tedious

Re: pg_upgrade should truncate/remove its logs before running

2022-02-05 Thread Tom Lane
Michael Paquier writes: > On Sun, Feb 06, 2022 at 01:58:21AM -0500, Tom Lane wrote: >> As already mentioned, there's been no notice to buildfarm owners ... >> so has Andrew actually made a release? > There has been one as of 8 days ago: > https://github.com/PGBuildFarm/client-code/releases [ scr

Re: pg_upgrade should truncate/remove its logs before running

2022-02-05 Thread Michael Paquier
On Sun, Feb 06, 2022 at 01:58:21AM -0500, Tom Lane wrote: > As already mentioned, there's been no notice to buildfarm owners ... > so has Andrew actually made a release? There has been one as of 8 days ago: https://github.com/PGBuildFarm/client-code/releases And I have just looked at that as poin

Re: pg_upgrade should truncate/remove its logs before running

2022-02-05 Thread Julien Rouhaud
On Sun, Feb 06, 2022 at 01:58:21AM -0500, Tom Lane wrote: > Michael Paquier writes: > > So, it took me some time to get back to this thread, and looked at it > > for the last couple of days... The buildfarm client v14 has been > > released on the 29th of January, which means that we are good to g

Re: Ensure that STDERR is empty during connect_ok

2022-02-05 Thread Michael Paquier
On Wed, Feb 02, 2022 at 03:40:39PM +0100, Daniel Gustafsson wrote: > As part of the NSS patchset, quite a few bugs (and NSS quirks) were found by > inspecting STDERR in connect_ok and require it to be empty. This is not > really > NSS specific, and could help find issues in other libraries as wel

Re: pg_upgrade should truncate/remove its logs before running

2022-02-05 Thread Tom Lane
Michael Paquier writes: > So, it took me some time to get back to this thread, and looked at it > for the last couple of days... The buildfarm client v14 has been > released on the 29th of January, which means that we are good to go. As already mentioned, there's been no notice to buildfarm owne

Re: libpq async duplicate error results

2022-02-05 Thread Fabien COELHO
Hello Tom, I concur with Fabien's analysis: we report the FATAL message from the server during the first PQgetResult, and then the second call discovers that the connection is gone and reports "server closed the connection unexpectedly". Those are two independent events (in libpq's view anywa

Re: 2022-01 Commitfest

2022-02-05 Thread Julien Rouhaud
Hi, On Sun, Feb 06, 2022 at 03:49:50PM +0900, Michael Paquier wrote: > On Wed, Feb 02, 2022 at 01:00:18PM -0500, Tom Lane wrote: > > Agreed, we're not here to cause make-work for submitters. RWF is > > appropriate if the patch has been in Waiting On Author for awhile > > and doesn't seem to be go

Re: Ensure that STDERR is empty during connect_ok

2022-02-05 Thread Michael Paquier
On Wed, Feb 02, 2022 at 04:42:09PM +0100, Daniel Gustafsson wrote: > Disclaimer: longer term I would prefer to remove test plan counting like above > and Toms comment downthread. That would be really nice. -- Michael signature.asc Description: PGP signature

Re: 2022-01 Commitfest

2022-02-05 Thread Michael Paquier
On Wed, Feb 02, 2022 at 01:00:18PM -0500, Tom Lane wrote: > Agreed, we're not here to cause make-work for submitters. RWF is > appropriate if the patch has been in Waiting On Author for awhile > and doesn't seem to be going anywhere, but otherwise we should > just punt it to the next CF. FWIW, I

Re: pg_receivewal - couple of improvements

2022-02-05 Thread Michael Paquier
On Thu, Feb 03, 2022 at 10:01:42PM +0800, Julien Rouhaud wrote: > I don't get it. If you're missing WAL it means that will you have to do that > tedious manual work to retrieve them no matter what. So on top of that > tedious > work, you also have to make sure that you don't provide a bogus star

Re: Windows now has fdatasync()

2022-02-05 Thread Michael Paquier
On Sun, Dec 12, 2021 at 03:48:10PM +1300, Thomas Munro wrote: > I tried out a quick POC patch and it runs a bit faster than fsync(), as > expected. Good news, as a too high difference would be suspect :) How much difference does it make in % and are the numbers rather reproducible? Just wonderin

Re: pg_upgrade should truncate/remove its logs before running

2022-02-05 Thread Michael Paquier
On Sun, Feb 06, 2022 at 02:03:44PM +0800, Julien Rouhaud wrote: > I didn't follow that thread closely, but if having the latest buildfarm client > version installed is a hard requirement this will likely be a problem. First, > there was no email to warn buildfarm owners that a new version is avail

Re: Unclear problem reports

2022-02-05 Thread Bharath Rupireddy
On Sun, Feb 6, 2022 at 5:28 AM Noah Misch wrote: > > > > - Canned responses are noise to every list reader other than the OP. > > > - Canned responses make the list feel like a sales funnel rather than a > > > normal > > > free software mailing list. > > > > All bug reports posted through the b

Re: pg_upgrade should truncate/remove its logs before running

2022-02-05 Thread Julien Rouhaud
Hi, On Sun, Feb 06, 2022 at 01:36:07PM +0900, Michael Paquier wrote: > > The buildfarm client v14 has been > released on the 29th of January, which means that we are good to go. I didn't follow that thread closely, but if having the latest buildfarm client version installed is a hard requirement

Re: GUC flags

2022-02-05 Thread Michael Paquier
On Mon, Jan 31, 2022 at 04:56:45PM -0600, Justin Pryzby wrote: > I'm not clear on what things are required/prohibited to allow/expect > "installcheck" to pass. It's possible that postgresql.conf doesn't even exist > in the data dir, right ? There are no written instructions AFAIK, but I have as p

Re: pg_upgrade should truncate/remove its logs before running

2022-02-05 Thread Michael Paquier
On Sat, Jan 29, 2022 at 09:53:25AM +0900, Michael Paquier wrote: > On Fri, Jan 28, 2022 at 06:27:29PM -0500, Andrew Dunstan wrote: >> I have committed this. But it will take time to get every buildfarm own >> to upgrade. > > Thanks for that. So, it took me some time to get back to this thread, an

Re: Adding CI to our tree

2022-02-05 Thread Andres Freund
Hi, On 2022-02-03 23:04:04 -0600, Justin Pryzby wrote: > > I assume this doesn't yet work to a meaningful degree? Last time I checked > > there were quite a few tests that needed to be invoked in a specific > > directory. > > It works - tap_check() does chdir(). Ah, I thought you'd implemented a

Re: Condition pushdown: why (=) is pushed down into join, but BETWEEN or >= is not?

2022-02-05 Thread Andy Fan
Hi, On Sat, Feb 5, 2022 at 9:32 PM Tomas Vondra wrote: > > I'm also not claiming this is 100% worth it - queries with a suitable > combination of clauses (conditions on the join keys) seems rather > uncommon. Thanks for showing interest in this. I want to add some other user cases which seem n

Re: Unclear problem reports

2022-02-05 Thread Noah Misch
On Sun, Feb 06, 2022 at 12:41:52AM +0100, Magnus Hagander wrote: > On Sun, Feb 6, 2022 at 12:02 AM Noah Misch wrote: > > On Fri, Feb 04, 2022 at 01:36:46PM -0500, Bruce Momjian wrote: > > > On Wed, Feb 2, 2022 at 07:21:19PM -0700, David G. Johnston wrote: > > > > Have pg_lister queue up a check f

Re: Unclear problem reports

2022-02-05 Thread Magnus Hagander
On Sun, Feb 6, 2022 at 12:02 AM Noah Misch wrote: > > On Fri, Feb 04, 2022 at 01:36:46PM -0500, Bruce Momjian wrote: > > On Wed, Feb 2, 2022 at 07:21:19PM -0700, David G. Johnston wrote: > > > On Wed, Feb 2, 2022 at 5:35 PM Bruce Momjian wrote: > > > Have pg_lister queue up a check for, say, two

Re: [BUG]Update Toast data failure in logical replication

2022-02-05 Thread Andres Freund
Hi, On 2022-02-04 17:45:36 +0530, Amit Kapila wrote: > diff --git a/contrib/test_decoding/expected/toast.out > b/contrib/test_decoding/expected/toast.out > index cd03e9d..a757e7d 100644 > --- a/contrib/test_decoding/expected/toast.out > +++ b/contrib/test_decoding/expected/toast.out > @@ -77,7 +7

Re: Unclear problem reports

2022-02-05 Thread Andres Freund
Hi, On 2022-02-02 19:35:36 -0500, Bruce Momjian wrote: > The Postgres community is great at diagnosing problems and giving users > feedback. In most cases, we can either diagnose a problem and give a > fix, or at least give users a hint at finding the cause. > > However, there is a class of probl

Re: Unclear problem reports

2022-02-05 Thread Noah Misch
On Fri, Feb 04, 2022 at 01:36:46PM -0500, Bruce Momjian wrote: > On Wed, Feb 2, 2022 at 07:21:19PM -0700, David G. Johnston wrote: > > On Wed, Feb 2, 2022 at 5:35 PM Bruce Momjian wrote: > > Have pg_lister queue up a check for, say, two or three days after the bug > > reporting form is filled out

Re: Release notes for February minor releases

2022-02-05 Thread Andres Freund
Hi, On 2022-02-04 14:58:59 -0500, Tom Lane wrote: > I've pushed the first draft for $SUBJECT at > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=ab22eea83169c8d0eb15050ce61cbe3d7dae4de6 +Author: Andres Freund +Branch: master [18b87b201] 2022-01-13 18:13:41 -0800 +Branch: RE

Re: Release notes for February minor releases

2022-02-05 Thread Andres Freund
Hi, On 2022-02-04 22:27:54 +0100, Michael Banck wrote: > On Fri, Feb 04, 2022 at 02:58:59PM -0500, Tom Lane wrote: > > I've pushed the first draft for $SUBJECT at > > > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=ab22eea83169c8d0eb15050ce61cbe3d7dae4de6 > > > > Please se

Re: Synchronizing slots from primary to standby

2022-02-05 Thread Andres Freund
Hi, On 2022-01-03 14:46:52 +0100, Peter Eisentraut wrote: > From ec00dc6ab8bafefc00e9b1c78ac9348b643b8a87 Mon Sep 17 00:00:00 2001 > From: Peter Eisentraut > Date: Mon, 3 Jan 2022 14:43:36 +0100 > Subject: [PATCH v3] Synchronize logical replication slots from primary to > standby I've just skim

Re: pg_walinspect - a new extension to get raw WAL data and WAL stats

2022-02-05 Thread Bharath Rupireddy
On Tue, Feb 1, 2022 at 3:10 AM Greg Stark wrote: > > So I looked at this patch and I have the same basic question as Bruce. Thanks a lot for the comments. > Do we really want to expose every binary tool associated with Postgres > as an extension? Obviously this is tempting for cloud provider use

Re: Condition pushdown: why (=) is pushed down into join, but BETWEEN or >= is not?

2022-02-05 Thread Tomas Vondra
Hi, there's been an interesting case [1] of a slow query on pgsql-general, related to the topic discussed in this thread. It causes an order the query to run slower by multiple orders of magnitude, and I think it's interesting, so let me present a simple example demonstrating it. ---

Re: [BUG]Update Toast data failure in logical replication

2022-02-05 Thread Alvaro Herrera
On 2022-Feb-05, Amit Kapila wrote: > On Fri, Feb 4, 2022 at 9:06 PM Alvaro Herrera wrote: > > > > I don't have a reason not to commit this patch. > > > > It is not very clear to me from this so just checking again, are you > fine with back-patching this as well? Hmm, of course, I never thought

Re: row filtering for logical replication

2022-02-05 Thread Amit Kapila
On Fri, Feb 4, 2022 at 2:58 PM houzj.f...@fujitsu.com wrote: > > On Thursday, February 3, 2022 11:11 PM houzj.f...@fujitsu.com > > > Since the v76--clean-up-pgoutput-cache-invalidation.patch has been > committed, attach a new version patch set to make the cfbot happy. Also > addressed the ab

Re: Latest LLVM breaks our code again

2022-02-05 Thread Thomas Munro
On Fri, Feb 4, 2022 at 8:12 AM Andres Freund wrote: > On 2022-02-03 10:44:11 +0100, Fabien COELHO wrote: > > For these reasons, I'm inclined to let seawasp as it is. It might be easier to use the nightly packages at https://apt.llvm.org/. You could update daily and still save so much CPU that ..

Re: Release notes for February minor releases

2022-02-05 Thread Michael Banck
On Fri, Feb 04, 2022 at 04:35:07PM -0500, Tom Lane wrote: > Michael Banck writes: > > On Fri, Feb 04, 2022 at 02:58:59PM -0500, Tom Lane wrote: > >> + If this seems to have affected a table, REINDEX > >> + should repair the damage. > > > I don't think this is very helpful to the reader,