On 3/4/22 23:09, Nikita Glukhov wrote:
> On 04.03.2022 23:28, Tom Lane wrote:
>
>> Tomas Vondra writes:
>>> On 3/4/22 20:29, Nikita Glukhov wrote:
So, we probably have corrupted indexes that were updated since such
"incomplete" upgrade of ltree.
>>> IIRC pg_upgrade is not expected to
On Fri, Mar 04, 2022 at 08:19:26PM -0500, Tom Lane wrote:
> Jacob Champion writes:
>> Here is my take on option 2, then: you get to choose exactly one method
>> that the client will accept. If you want to use client certificates,
>> use require_auth=cert. If you want to force SCRAM, use
>>
On 2022-03-04 20:06:43 -0800, Andres Freund wrote:
> On 2022-03-05 16:39:21 +1300, Thomas Munro wrote:
> > I vote for committing that workaround into the tree temporarily,
> > because it's not just cfbot, it's also everyone's dev branches on
> > Github + the official mirror that are red.
>
> I'll
Hi,
On 2022-03-05 16:39:21 +1300, Thomas Munro wrote:
> On Sat, Mar 5, 2022 at 4:19 PM Andres Freund wrote:
> > https://github.com/cirruslabs/cirrus-ci-agent/issues/218#issuecomment-1059657781
>
> Oof. Nice detective work.
Thanks.
> > As indicated in the message above it, there's a
On Sat, Mar 5, 2022 at 4:19 PM Andres Freund wrote:
> https://github.com/cirruslabs/cirrus-ci-agent/issues/218#issuecomment-1059657781
Oof. Nice detective work.
> As indicated in the message above it, there's a workaround. Not sure if worth
> committing, if they were to fix it in a few days?
Hi,
On 2022-03-05 13:21:26 +1300, Thomas Munro wrote:
> On Sat, Mar 5, 2022 at 10:56 AM Andres Freund wrote:
> > I suspect one also needs the console detach thing.
>
> I tried adding DETACHED_PROCESS (which should be like calling
> FreeConsole() in child process) and then I tried
Hi,
On 2022-03-03 22:56:15 -0600, Justin Pryzby wrote:
> On Sun, Feb 20, 2022 at 12:47:31PM -0800, Andres Freund wrote:
> > On 2022-02-20 13:36:55 -0600, Justin Pryzby wrote:
> > > Have you tried to use the yet-to-be-released ccache with MSVC ?
> >
> > Yes, it doesn't work, because it requires
Jacob Champion writes:
> $subject keeps coming up in threads. I think my first introduction to
> it was after the TLS injection CVE, and then it came up again in the
> pluggable auth thread. It's hard for me to generalize based on "sound
> bites", but among the proposals I've seen are
> 1.
On Fri, Mar 4, 2022 at 6:02 PM Euler Taveira wrote:
>
> On Fri, Mar 4, 2022, at 2:54 AM, Amit Kapila wrote:
>
> The LSN of the transaction that contains the change violating the
> constraint and the replication origin name can be found from the
> server log (LSN 0/14C0378 and replication origin
>
Hello,
TL;DR: this patch lets you specify exactly one authentication method in
the connection string, and libpq will fail the connection if the server
doesn't use that method.
(This is not intended for PG15. I'm generally anxious about posting
experimental work during a commitfest, but there's
On Sat, Mar 5, 2022 at 10:56 AM Andres Freund wrote:
> I suspect one also needs the console detach thing.
I tried adding DETACHED_PROCESS (which should be like calling
FreeConsole() in child process) and then I tried CREATE_NEW_CONSOLE
instead, on top of CREATE_NEW_PROCESS_GROUP. Neither
>> I still don't understand why using plaintex password authentication
>> over SSL connection is considered insecure. Actually we have been
>> stating opposite in the manual:
>> https://www.postgresql.org/docs/14/auth-password.html
>>
>> "If the connection is protected by SSL encryption then
On 2022-03-04 14:04:44 -0800, Andres Freund wrote:
> Trying to make it use the current user now - I don't know what
> permissions services are needed to run a service as a user or such.
My first attempt of using %USERNAME% failed:
[22:10:20.862] c:\cirrus>call tmp_install\bin\pg_ctl.exe register
On Fri, Mar 4, 2022 at 1:50 PM Robert Haas wrote:
> On Mon, Feb 28, 2022 at 2:09 PM Stephen Frost wrote:
> > The ability of a role to revoke itself from some other role is just
> > something we need to accept as being a change that needs to be made, and
> > I do believe that such a change is
On 04.03.2022 23:28, Tom Lane wrote:
Tomas Vondra writes:
On 3/4/22 20:29, Nikita Glukhov wrote:
So, we probably have corrupted indexes that were updated since such
"incomplete" upgrade of ltree.
IIRC pg_upgrade is not expected to upgrade extensions - it keeps the
installed version of the
Andres Freund writes:
> I don't really understand why start_postmaster() bothers to wrap postmaster
> start through cmd.exe, particularly when it prevents us from getting
> postmaster's pid. Also the caveats around cmd.exe and sharing mode.
I think the basic idea is to avoid having to write our
Hi,
On 2022-03-04 16:51:32 -0500, Tom Lane wrote:
> Andres Freund writes:
> > That fixed the immediate problem, but dblink, postgres_fdw tests failed:
> > +ERROR: could not establish connection
> > +DETAIL: connection to server at "localhost" (::1), port 5432 failed:
> > FATAL:
> > role
On Wed, Mar 2, 2022 at 8:09 PM Justin Pryzby wrote:
>
> Rebased to appease cfbot.
>
> I ran these paches under a branch which shows code coverage in cirrus. It
> looks good to my eyes.
> https://api.cirrus-ci.com/v1/artifact/task/5212346552418304/coverage/coverage/00-index.html
thanks for doing
Hi,
On 2022-03-05 09:29:01 +1300, Thomas Munro wrote:
> On Sat, Mar 5, 2022 at 7:10 AM Andres Freund wrote:
> > Or perhaps pg_ctl ought to pass CREATE_NEW_PROCESS_GROUP to CreateProcess()?
> > The lack of a process group would explain why we're getting signalled on
> > ctrl-c...
>
> I thought
Andres Freund writes:
> That fixed the immediate problem, but dblink, postgres_fdw tests failed:
> +ERROR: could not establish connection
> +DETAIL: connection to server at "localhost" (::1), port 5432 failed: FATAL:
> role "SYSTEM" does not exist
[ scratches head... ] Where is libpq getting
Hi,
On 2022-03-04 09:57:35 -0800, Andres Freund wrote:
> On 2022-03-04 09:46:44 -0800, Andres Freund wrote:
> > On 2022-03-04 09:30:37 -0800, Andres Freund wrote:
> > > I wonder if we're missing some steps, at least on windows, to make pg_ctl
> > > start independent of the starting shell?
> >
> >
Robert Haas writes:
> 1. What should be the exact rule for whether A can remove a grant made
> by B? Is it has_privs_of_role()? is_member_of_role()? Something else?
No strong opinion here, but I'd lean slightly to the more restrictive
option.
> 2. What happens if the same GRANT is enacted by
On Mon, Feb 28, 2022 at 2:09 PM Stephen Frost wrote:
> The ability of a role to revoke itself from some other role is just
> something we need to accept as being a change that needs to be made, and
> I do believe that such a change is supported by the standard, in that a
> REVOKE will only work
On Sat, Mar 5, 2022 at 7:10 AM Andres Freund wrote:
> Or perhaps pg_ctl ought to pass CREATE_NEW_PROCESS_GROUP to CreateProcess()?
> The lack of a process group would explain why we're getting signalled on
> ctrl-c...
I thought that sounded promising, given that the recent Cirrus agent
commit
Tomas Vondra writes:
> On 3/4/22 20:29, Nikita Glukhov wrote:
>> So, we probably have corrupted indexes that were updated since such
>> "incomplete" upgrade of ltree.
> IIRC pg_upgrade is not expected to upgrade extensions - it keeps the
> installed version of the extension, and that's
On 3/4/22 13:13, Erikjan Rijkers wrote:
> Op 04-03-2022 om 17:33 schreef Andrew Dunstan:
>>
>
>> This set of patches deals with items 1..7 above, but not yet the ERROR
>> ON ERROR issue. It also makes some message cleanups, but there is more
>> to come in that area.
>>
>> It is based on the
On 3/4/22 20:29, Nikita Glukhov wrote:
> On 25.02.2022 00:15, Tomas Vondra wrote:
>
>> Hi,
>>
>> Victor Yegorov reported a crash related to a GiST index on ltree [1],
>> following a pg_upgrade from 12.x to 14.x, with a data set reproducing
>> this. I spent some time investigating this, and it
On Wed, Mar 02, 2022 at 09:47:09AM +0530, Bharath Rupireddy wrote:
> On Wed, Mar 2, 2022 at 2:57 AM Nathan Bossart
> wrote:
>> I think there are a couple of advantages. For one, spinning is probably
>> not the best from a resource perspective.
>
> Just to be on the same page - by spinning do
On 25.02.2022 00:15, Tomas Vondra wrote:
Hi,
Victor Yegorov reported a crash related to a GiST index on ltree [1],
following a pg_upgrade from 12.x to 14.x, with a data set reproducing
this. I spent some time investigating this, and it seems this is a silly
bug in commit
commit
On Thu, 2022-03-03 at 11:12 +0100, Peter Eisentraut wrote:
> At the moment, it is not possible to judge whether the hook interface
> you have chosen is appropriate.
>
> I suggest you actually implement the Azure provider, then make the hook
> interface, and then show us both and we can see what
On Thu, Mar 3, 2022 at 11:50 PM Tatsuo Ishii wrote:
>
> >> So, dropping plaintext password authentication support from libpq will
> >> make it impossible for users to use the former method.
> >
> > Yes, just like dropping support for md5 would make it impossible for
> > users to have their
Op 04-03-2022 om 17:33 schreef Andrew Dunstan:
This set of patches deals with items 1..7 above, but not yet the ERROR
ON ERROR issue. It also makes some message cleanups, but there is more
to come in that area.
It is based on the latest SQL/JSON Functions patch set, which does not
include
Hi,
On 2022-03-04 09:57:35 -0800, Andres Freund wrote:
> On 2022-03-04 09:46:44 -0800, Andres Freund wrote:
> > On 2022-03-04 09:30:37 -0800, Andres Freund wrote:
> > > I wonder if we're missing some steps, at least on windows, to make pg_ctl
> > > start independent of the starting shell?
> >
> >
On 2022-03-04 09:46:44 -0800, Andres Freund wrote:
> On 2022-03-04 09:30:37 -0800, Andres Freund wrote:
> > I wonder if we're missing some steps, at least on windows, to make pg_ctl
> > start independent of the starting shell?
>
> Sure looks that way. On windows, if I do pg_ctl start, then hit
Hi,
On 2022-03-04 09:30:37 -0800, Andres Freund wrote:
> I wonder if we're missing some steps, at least on windows, to make pg_ctl
> start independent of the starting shell?
Sure looks that way. On windows, if I do pg_ctl start, then hit ctrl-c, the
server shuts down.
Greetings,
Andres Freund
Andres Freund writes:
> On 2022-03-04 12:23:43 -0500, Tom Lane wrote:
>> pg_regress thinks the postmaster is listening to a Unix socket.
> pg_regress outputs the above message when neither PGHOST, PGPORT or
> --host/--port are set. On windows that nevertheless ends up with connecting to
>
Hi,
On 2022-03-04 12:23:43 -0500, Tom Lane wrote:
> Actually ... looking closer at the failure log:
>
> [09:41:50.589] Checking plpgsql
> [09:41:50.608] (using postmaster on Unix socket, default port)
> ^^^
> [09:41:50.608] == dropping
Hi,
On 2022-03-04 09:10:14 -0800, Andres Freund wrote:
> > I find it a little suspicious that startcreate is merrily starting
> > the postmaster on port 5432, without concern for the possibility
> > that that port is in use or blocked by a packet filter.
>
> It's a container that's just created
Andres Freund writes:
> On 2022-03-04 09:54:28 -0500, Tom Lane wrote:
>> I find it a little suspicious that startcreate is merrily starting
>> the postmaster on port 5432, without concern for the possibility
>> that that port is in use or blocked by a packet filter.
> It's a container that's
Hi,
On 2022-03-04 09:54:28 -0500, Tom Lane wrote:
> Thomas Munro writes:
> > https://github.com/postgres/postgres/commits/master
>
> > I don't see what that patch has to do with the symptoms.
>
> The buildfarm is not unhappy, so I'd be looking at what changed
> recently in the cfbot's setup.
Is this patch targetting pg15 ?
There's no discussion since June.
Latest at 2021-06-08 21:29:25 by Jeff Davis
2022-02-02 16:37:58 Julien Rouhaud (rjuju) Closed in commitfest 2022-01
with status: Moved to next CF
2021-12-03 06:18:05 Michael Paquier (michael-kun) Closed in commitfest
The patch is failing on cfbot/freebsd.
http://cfbot.cputube.org/georgios-kokolatos.html
Also, I wondered if you'd looked at the "high compression" interfaces in
lz4hc.h ? Should pg_dump use that ?
On Fri, Feb 25, 2022 at 08:03:40AM -0600, Justin Pryzby wrote:
> Thanks for working on this. Your
Thomas Munro writes:
> On Fri, Mar 4, 2022 at 10:37 PM Bharath Rupireddy
> wrote:
>> It looks like regression tests are failing on Windows Server 2019 [1].
>> Ignore if it's reported elsewhere.
> It's broken since 46ab07ff "Clean up assorted failures under clang's
> -fsanitize=undefined
On Mon, 19 Apr 2021 at 06:52, Bharath Rupireddy
wrote:
>
> On Mon, Apr 5, 2021 at 9:49 AM Bharath Rupireddy
> wrote:
> >
> > On Wed, Mar 10, 2021 at 10:21 AM Bharath Rupireddy
> > wrote:
> > > Attaching the v4 patch set. Please review it further.
> >
> > Attaching v5 patch set after rebasing
On Fri, Mar 4, 2022 at 3:32 AM Dipesh Pandit wrote:
> GZIP manages to overcome this problem as it provides an option to turn on/off
> compression on the fly while writing a compressed archive with the help of
> zlib
> library function deflateParams(). The current gzip implementation for
>
Hi,
While using pg_rewind, I found that it is a bit difficult to use pg_rewind
as it seems to copy even the configuration files and also remove some of
the files created on the old primary which may not be present on the new
primary. Similarly it copies files under the data directory of the new
Just FYI. Better to follow up to the thread for the patch that's
already in the CF. Otherwise your patch will missed by someone who
looks at the CF entry to see the latest patch.
Indeed. Done.
--
Fabien.
Are you planning to send a rebased patch for this commit fest?
Argh, I did it in a reply in another thread:-( Attached v15.
So as to help moves things forward, I'd suggest that we should not to care
too much about corner case repetition of some error messages which are due
to libpq
On 2/22/22 18:19, Justin Pryzby wrote:
> As writen, this patch uses zstd level=1 (whereas the ZSTD's default compress
> level is 6).
I think this choice needs to be supported by some benchmarks.
>
> 0001 adds support for zstd
> 0002 makes more efficient our use of bits in the WAL header
>
On Fri, Mar 4, 2022 at 6:44 AM Justin Pryzby wrote:
> > Why? ZSTD using this default has its reasons, no? And it would be
> > consistent to do the same for ZSTD as for the other two methods.
>
> In my 1-off test, it gets 610/633 = 96% of the benefit at 209/273 = 77% of the
> cost.
I agree with
Le 04/03/2022 à 11:56, Justin Pryzby a écrit :
On Fri, Mar 04, 2022 at 10:11:28AM +0100, Gilles Darold wrote:
The attached patch implements that. Option -n | --schema can be used
multiple time and can not be used together with options -a or -t.
Yes, thanks.
I suggest there should also be an
On Fri, Mar 4, 2022, at 2:54 AM, Amit Kapila wrote:
> The LSN of the transaction that contains the change violating the
> constraint and the replication origin name can be found from the
> server log (LSN 0/14C0378 and replication origin
> pg_16395 in the above case). To skip the
> transaction,
Thanks Bharath for working on all my review comments. I took a quick
look at the new version of the patch (v7-pg_walinspect.patch) and this
version looks a lot better. I'll do some detailed review later (maybe
next week or so) and let you know my further comments, if any.
--
With Regards,
Please don't mix comments from multiple reviewers into one thread.
It's hard to understand which comments are mine or Julien's or from
others. Can you please respond to the email from each of us separately
with an inline response. That will be helpful to understand your
thoughts on our review
On Fri, Mar 4, 2022 at 2:55 PM Amit Kapila wrote:
>
> On Fri, Mar 4, 2022 at 6:40 AM Masahiko Sawada wrote:
> >
> > Attached updated version patches.
> >
>
> The patch looks mostly good to me. Few minor comments:
Thank you for the comments!
> 1. I think we can have an Assert for
On Fri, Mar 04, 2022 at 04:19:32PM +0900, Michael Paquier wrote:
> On Tue, Feb 22, 2022 at 05:19:48PM -0600, Justin Pryzby wrote:
>
> > As writen, this patch uses zstd level=1 (whereas the ZSTD's default compress
> > level is 6).
>
> Why? ZSTD using this default has its reasons, no? And it
Thanks for reviewing.
> 6) How about shutdown and end-of-recovery checkpoint? Are you planning
> to have an ereport_startup_progress mechanism as 0002?
I thought of including it earlier then I felt lets first make the
current patch stable. Once all the fields are properly decided and the
patch
On Fri, 4 Mar 2022 at 14:41, Gilles Darold wrote:
> Hi,
>
>
> When we want to vacuum and/or analyze all tables in a dedicated schema,
> let's say pg_catalog for example, there is no easy way to do that. The
> VACUUM command doesn't allow it so we have to use \gexec or a SQL script
> to do that.
On Fri, Mar 04, 2022 at 10:11:28AM +0100, Gilles Darold wrote:
> The attached patch implements that. Option -n | --schema can be used
> multiple time and can not be used together with options -a or -t.
Yes, thanks.
I suggest there should also be an --exclude-schema.
> I do not propose to extend
On Fri, Mar 4, 2022 at 10:37 PM Bharath Rupireddy
wrote:
> It looks like regression tests are failing on Windows Server 2019 [1].
> Ignore if it's reported elsewhere.
It's broken since 46ab07ff "Clean up assorted failures under clang's
-fsanitize=undefined checks.":
On 1/3/2022 03:03, Greg Stark wrote:
On Thu, 1 Jul 2021 at 02:38, Ronan Dunklau wrote:
Well in some cases they can't, when the query is not emitting redundant
predicates by itself but they are added by something else like a view or a RLS
policy.
Maybe it would be worth it to allow spending a
On Wed, Mar 2, 2022 at 5:43 PM Tomas Vondra
wrote:
>
> Attached is an updated patch, addressing most of the issues reported so
> far. There are various minor tweaks, but the main changes are:
...
>
> 3) checks of column filter vs. publish_via_partition_root and replica
> identity, following the
On Fri, Mar 04, 2022 at 06:04:00PM +0900, Kyotaro Horiguchi wrote:
> And I made a quick hack on do_pg_start_backup. And I found that
> pg_basebackup copies in-place tablespaces under the *current
> directory*, which is not ok at all:(
Yeah, I have noticed that as well while testing such
On Fri, Mar 4, 2022 at 10:04 PM Kyotaro Horiguchi
wrote:
> And I made a quick hack on do_pg_start_backup. And I found that
> pg_basebackup copies in-place tablespaces under the *current
> directory*, which is not ok at all:(
Hmm. Which OS are you on? Looks OK here -- the "in place" tablespace
On Thu, Mar 3, 2022 at 10:05 PM Robert Haas wrote:
>
> On Fri, Feb 25, 2022 at 6:03 AM Bharath Rupireddy
> wrote:
> > Added a new function that returns the first and last valid WAL record
> > LSN of a given WAL file.
>
> Sounds like fuzzy thinking to me. WAL records can cross file
> boundaries,
On Fri, 04 Mar 2022 at 14:05, Kyotaro Horiguchi wrote:
> At Fri, 04 Mar 2022 12:18:29 +0800, Japin Li wrote in
>>
>> On Thu, 03 Mar 2022 at 12:10, Japin Li wrote:
>>
>> Attach v3 patch to fix missing close varname tag.
>
> +A precondition for using minimal WAL is to disable WAL
Hi,
It looks like regression tests are failing on Windows Server 2019 [1].
Ignore if it's reported elsewhere.
[1] https://github.com/postgres/postgres/runs/5419324953
❌ 00:02 test_pl
[08:28:53.758]
[08:28:53.758] c:\cirrus>call "C:/Program
Files/Git/usr/bin/timeout.exe" -v -k60s 15m perl
Hi,
When we want to vacuum and/or analyze all tables in a dedicated schema,
let's say pg_catalog for example, there is no easy way to do that. The
VACUUM command doesn't allow it so we have to use \gexec or a SQL script
to do that. We have an external command vacuumdb that could be used to
At Fri, 04 Mar 2022 17:28:45 +0900 (JST), Kyotaro Horiguchi
wrote in
> > By the way, regardless of the patch, I got an error from pg_basebackup
> > for an in-place tablespace. pg_do_start_backup calls readlink
> > believing pg_tblspc/* is always a symlink.
> >
> > # Running: pg_basebackup -D
On 15.01.22 10:00, Fabien COELHO wrote:
The reason this test constantly fails on cfbot windows is a
use-after-free
bug.
Indeed! Thanks a lot for the catch and the debug!
The ClearOrSaveResult function is quite annoying because it may or may
not clear the result as a side effect.
Attached
Hi,
> > It will be good if we can also fix
> > CreateWalTarMethod to support LZ4 and ZSTD.
> Ok we will see, either Dipesh or I will take care of it.
I took a look at the CreateWalTarMethod to support LZ4 compression
for WAL files. The current implementation involves a 3 step to backup
a WAL
At Fri, 04 Mar 2022 16:54:49 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Fri, 04 Mar 2022 16:41:03 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > At Fri, 4 Mar 2022 15:44:22 +0900, Michael Paquier
> > wrote in
> > > The use may be limited to any automated testing and
> > >
Dear Wang,
> Some codes were added in ReorderBufferProcessTXN() for treating DDL,
My mailer went wrong, so I'll put comments again. Sorry.
Some codes were added in ReorderBufferProcessTXN() for treating DDL,
but I doubted updating accept_writes is needed.
IMU, the parameter is read by
73 matches
Mail list logo
