Re: Build-farm - intermittent error in 031_column_list.pl

At Thu, 19 May 2022 14:26:56 +1000, Peter Smith wrote in > Hi hackers. > > FYI, I saw that there was a recent Build-farm error on the "grison" machine > [1] > [1] https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=grison&br=HEAD > > The error happened during "subscriptionCheck" phase

Re: Perform streaming logical transactions by background workers and parallel apply

Here are my review comments for v6-0002. == 1. src/test/subscription/t/015_stream.pl + +# Test using streaming mode 'on' + $node_subscriber->safe_psql('postgres', "CREATE SUBSCRIPTION tap_sub CONNECTION '$publisher_connstr ap

Re: First draft of the PG 15 release notes

On Thu, 19 May 2022 at 14:41, Amit Langote wrote: > Though a bit late given beta is now wrapped, I have another partition > item wording improvement suggestion: > > -Previously, a partitioned table with any LIST partition containing > multiple values could not be used for ordered partition scans.

Re: weird comments in Memoize nodes

On Tue, 17 May 2022 at 08:02, David Rowley wrote: > Yeah, must be a copy-pasto. I'll fix it with the attached after beta1 > is tagged. Pushed. David

Re: bogus: logical replication rows/cols combinations

On Mon, May 16, 2022 at 6:50 PM Alvaro Herrera wrote: > > On 2022-May-16, Amit Kapila wrote: > > > Few comments: > > = > > 1. > > postgres=# select * from pg_publication_tables; > > pubname | schemaname | tablename | columnlist | rowfilter > > -++---+-

Build-farm - intermittent error in 031_column_list.pl

Hi hackers. FYI, I saw that there was a recent Build-farm error on the "grison" machine [1] [1] https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=grison&br=HEAD The error happened during "subscriptionCheck" phase in the TAP test t/031_column_list.pl This test file was added by this [2]

Re: Skipping schema changes in publication

On Tue, May 17, 2022 at 7:35 AM Peter Smith wrote: > > Below are my review comments for v5-0002. > > There may be an overlap with comments recently posted by Osumi-san [1]. > > (I also have review comments for v5-0002; will post them tomorrow) > > == > > 1. General > > Is it really necessary t

Re: First draft of the PG 15 release notes

On Sat, May 14, 2022 at 12:42 AM Bruce Momjian wrote: > On Fri, May 13, 2022 at 10:48:41AM +0900, Amit Langote wrote: > > Btw, perhaps the following should be listed under E.1.3.2.1. Logical > > Replication, not E.1.3.1.1. Partitioning? > > > > > > > > > > > > Remove incorrect duplicate partiti

RE: Multi-Master Logical Replication

Hi hackers, I created a small PoC. Please see the attached patches. REQUIREMENT Before patching them, patches in [1] must also be applied. DIFFERENCES FROM PREVIOUS DESCRIPTIONS * LRG is now implemented as SQL functions, not as a contrib module. * New tables are added as system catalogs. Ther

Re: create_help.pl treats as replaceable

At Wed, 18 May 2022 18:23:57 +0200, Peter Eisentraut wrote in > "Boolean" is correct; see for > example. Ok, so, don't we in turn need to replace "boolean"s with "Boolean"? "only boolean operators can have negators" "only boolean operators can have rest

RE: Skipping schema changes in publication

On Thursday, May 19, 2022 2:45 AM vignesh C wrote: > On Mon, May 16, 2022 at 8:32 AM osumi.takami...@fujitsu.com > wrote: > > (3) src/test/regress/expected/publication.out > > > > +-- Verify that only superuser can reset a publication ALTER > > +PUBLICATION testpub_reset OWNER TO regress_publicat

Re: Add --{no-,}bypassrls flags to createuser

On Wed, May 18, 2022 at 6:35 PM Shinya Kato wrote: > > Too bad there's no --comment parameter to do COMMENT ON ROLE name IS > > 'Comment'; > > > > As you already make such changes in createuser, I would like to ask > > for an additional --comment parameter > > that will allow sysadmins to set a c

Addition of PostgreSQL::Test::Cluster::pg_version()

Hi all, (Added Andrew in CC.) While working more on expanding the tests of pg_upgrade for cross-version checks, I have noticed that we don't expose a routine able to get back _pg_version from a node, which should remain a private field of Cluster.pm. We already do that for install_path, as of cas

Re: Add --{no-,}bypassrls flags to createuser

Thanks for reviews and comments! On 2022-05-06 07:08, Przemysław Sztoch wrote: Thanks for the new patch! Would you mind adding some tests for the new options? I created a new patch to test the new options! However, not all option tests exist, so it may be necessary to consider whether to ac

Re: ALTER TABLE SET ACCESS METHOD on partitioned tables

On Wed, May 18, 2022 at 5:49 PM Soumyadeep Chakraborty < soumyadeep2...@gmail.com> wrote: > > On Wed, May 18, 2022 at 4:14 PM Justin Pryzby > wrote: > > > I didn't look closely yet, but this comment is wrong: > > > > + * Since these have no storage the tablespace can be updated with a > simple >

Re: ALTER TABLE SET ACCESS METHOD on partitioned tables

On Wed, May 18, 2022 at 4:14 PM Justin Pryzby wrote: > I didn't look closely yet, but this comment is wrong: > > + * Since these have no storage the tablespace can be updated with a simple > + * metadata only operation to update the tablespace. Good catch. Fixed. > It'd be convenient if AMs

Re: PostgreSQL 15 Beta 1 release announcement draft

On Wed, May 18, 2022 at 1:50 AM Jonathan S. Katz wrote: > On 5/15/22 10:58 PM, Amit Kapila wrote: > > On Sun, May 15, 2022 at 12:22 AM Jonathan S. Katz > > wrote: > >> Please provide feedback no later than 2022-05-19 0:00 AoE[1]. > > > >> [`recovery_prefetch`](https://www.postgresql.org/docs/15/

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

Em qua., 18 de mai. de 2022 às 19:57, David Rowley escreveu: > On Thu, 19 May 2022 at 02:08, Ranier Vilela wrote: > > That would initialize the content at compilation and not at runtime, > correct? > > Your mental model of compilation and run-time might be flawed here. > Here's no such thing as

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

Em qua., 18 de mai. de 2022 às 20:20, Tom Lane escreveu: > zeroing > relatively small, known-aligned node structs is THE use case. > Currently, especially on 64-bit Windows, MemSet can break alignment. regards, Ranier Vilela

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

Em qua., 18 de mai. de 2022 às 19:57, David Rowley escreveu: > On Thu, 19 May 2022 at 02:08, Ranier Vilela wrote: > > That would initialize the content at compilation and not at runtime, > correct? > > Your mental model of compilation and run-time might be flawed here. > Here's no such thing as

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

David Rowley writes: > I've been wondering for a while if we really need to have the MemSet() > macro. I see it was added in 8cb415449 (1997). I think compilers have > evolved quite a bit in the past 25 years, so it could be time to > revisit that. Yeah, I've thought for awhile that technology h

Re: ALTER TABLE SET ACCESS METHOD on partitioned tables

Thanks for copying me. I didn't look closely yet, but this comment is wrong: + * Since these have no storage the tablespace can be updated with a simple

Re: ALTER TABLE SET ACCESS METHOD on partitioned tables

Hi, + tup = SearchSysCache1(RELOID, ObjectIdGetDatum(relid)); + accessMethodId = ((Form_pg_class) GETSTRUCT(tup))->relam; - /* look up the access method, verify it is for a table */ - if (accessMethod != NULL) - accessMethodId = get_table_am_oid(accessMethod, false); +

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

On Thu, 19 May 2022 at 02:08, Ranier Vilela wrote: > That would initialize the content at compilation and not at runtime, correct? Your mental model of compilation and run-time might be flawed here. Here's no such thing as zeroing memory at compile time. There's only emitting instructions that pe

Re: Limiting memory allocation

On 5/18/22 16:20, Alvaro Herrera wrote: On 2022-May-18, Joe Conway wrote: On 5/18/22 11:11, Alvaro Herrera wrote: > Apparently, if the cgroup goes over the "high" limit, the processes are > *throttled*. Then if the group goes over the "max" limit, OOM-killer is > invoked. You may be misi

Re: Limiting memory allocation

On 2022-May-18, Joe Conway wrote: > On 5/18/22 11:11, Alvaro Herrera wrote: > > Apparently, if the cgroup goes over the "high" limit, the processes are > > *throttled*. Then if the group goes over the "max" limit, OOM-killer is > > invoked. > You may be misinterpreting "throttle" in this contex

Re: [RFC] building postgres with meson -v8

Hi, On 2022-05-18 10:30:12 +0200, Peter Eisentraut wrote: > Here are some more patches that clean up various minor issues. I rebased the meson tree, squashed a lot of the existing commits, merged your changes, and fixed a few more differences between autoconf and meson. For me the difference in

Re: Limiting memory allocation

On 5/18/22 11:11, Alvaro Herrera wrote: Now that's where cgroup's memory limiting features would prove useful, if they weren't totally braindead: https://www.kernel.org/doc/Documentation/cgroup-v2.txt Apparently, if the cgroup goes over the "high" limit, the processes are *throttled*. Then if th

Re: Zstandard support for toast compression

On Wed, May 18, 2022 at 9:17 AM Robert Haas wrote: > But I want to point out here that you haven't really offered any kind > of argument in favor of supporting Zstd. You basically seem to just be > arguing that it's dumb to worry about running out of bit space, and I > think that's just obviously

Re: support for MERGE

On 2022-May-18, Tom Lane wrote: > I don't think the committed patch will behave nicely in edge cases: [...] > If it's text format and total is 0, I'd wish it to print nothing, > not to revert to the verbose format. Oops, true. Fixed. -- Álvaro Herrera 48°01'N 7°57'E — https://w

Re: Zstandard support for toast compression

On Tue, May 17, 2022 at 02:54:28PM -0400, Robert Haas wrote: > I don't particularly have anything against adding Zstandard > compression here, but I wonder whether there's any rush. If we decide > not to add this now, we can always change our minds and add it later, > but if we decide to add it now

Re: Privileges on PUBLICATION

On Wed, May 18, 2022, at 6:44 AM, Antonin Houska wrote: > ok, please see the next version. The new paragraph looks good to me. I'm not sure if the CREATE PUBLICATION is the right place to provide such information. As I suggested in a previous email [1], you could add it to "Logical Replication > Se

Re: Privileges on PUBLICATION

On Wed, May 18, 2022, at 6:16 AM, Antonin Houska wrote: > The patch is attached to this message. Great. Add it to the next CF. I'll review it when I have some spare time. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Skipping schema changes in publication

On Mon, May 16, 2022 at 2:00 PM osumi.takami...@fujitsu.com wrote: > > On Saturday, May 14, 2022 10:33 PM vignesh C wrote: > > Thanks for the comments, the attached v5 patch has the changes for the same. > > Also I have made the changes for SKIP Table based on the new syntax, the > > changes for

Re: Skipping schema changes in publication

On Wed, May 18, 2022 at 8:30 AM shiy.f...@fujitsu.com wrote: > > On Sat, May 14, 2022 9:33 PM vignesh C wrote: > > > > Thanks for the comments, the attached v5 patch has the changes for the > > same. Also I have made the changes for SKIP Table based on the new > > syntax, the changes for the same

Re: Skipping schema changes in publication

On Mon, May 16, 2022 at 2:53 PM Peter Smith wrote: > > Below are my review comments for v5-0001. > > There is some overlap with comments recently posted by Osumi-san [1]. > > (I also have review comments for v5-0002; will post them tomorrow) > > == > > 1. Commit message > > This patch adds a n

Re: Skipping schema changes in publication

On Mon, May 16, 2022 at 8:32 AM osumi.takami...@fujitsu.com wrote: > > On Saturday, May 14, 2022 10:33 PM vignesh C wrote: > > Thanks for the comments, the attached v5 patch has the changes for the same. > > Also I have made the changes for SKIP Table based on the new syntax, the > > changes for

Re: support for MERGE

Alvaro Herrera writes: > I chose the other way :-) I don't think the committed patch will behave nicely in edge cases: + if (es->format == EXPLAIN_FORMAT_TEXT && total > 0) + { + ExplainIndentText(es); + appendStringInfoString(es->str, "Tuples:");

Re: support for MERGE

On Wed, May 18, 2022 at 06:42:38PM +0200, Alvaro Herrera wrote: > On 2022-May-11, Justin Pryzby wrote: > > > I suggest to reference the mvcc docs from the merge docs, or to make the > > merge > > docs themselves include the referenced information. > > > > diff --git a/doc/src/sgml/ref/merge.sgml

Re: Limiting memory allocation

Greetings, * Jan Wieck (j...@wi3ck.info) wrote: > On 5/17/22 18:30, Stephen Frost wrote: > >This isn’t actually a solution though and that’s the problem- you end up > >using swap but if you use more than “expected” the OOM killer comes in and > >happily blows you up anyway. Cgroups are containers

Re: support for MERGE

On 2022-May-11, Justin Pryzby wrote: > I suggest to reference the mvcc docs from the merge docs, or to make the merge > docs themselves include the referenced information. > > diff --git a/doc/src/sgml/ref/merge.sgml b/doc/src/sgml/ref/merge.sgml > index f68aa09736c..99dd5814f36 100644 > --- a/do

Re: support for MERGE

On 2022-May-18, Justin Pryzby wrote: > On Wed, May 11, 2022 at 11:33:50AM -0500, Justin Pryzby wrote: > > > That's separate from the question about eliding zeros. > > Actually, the existing uses suggest that these *aren't* separate. > > The cases where 0 output is elided (like Heap Blocks and B

Re: create_help.pl treats as replaceable

Peter Eisentraut writes: > On 17.05.22 17:09, Tom Lane wrote: >> Isn't that a documentation bug rather than a problem with create_help? > Yeah, there is no need for a inside a . So I just > removed it. I think you should have upper-cased MATCH while at it, to make it clear that it acts like a

Re: create_help.pl treats as replaceable

On 18.05.22 02:58, Kyotaro Horiguchi wrote: Oh, agreed. Thanks for the correction. By the way the error message in defGetCopyHeaderChoice is as follows. "%s requires a Boolean value or \"match\"" Should it be "%s requires a boolean value or MATCH"? The documentation of COPY currently appears

Re: create_help.pl treats as replaceable

On 17.05.22 17:09, Tom Lane wrote: By a quick look it seems to me that the "match" in "COPY.. HEADER match" is the first and only instance of a literal parameter as of PG15. Isn't that a documentation bug rather than a problem with create_help? Yeah, there is no need for a inside a . So I ju

Re: Zstandard support for toast compression

On Tue, May 17, 2022 at 4:12 PM Stephen Frost wrote: > I'm getting a bit of deja-vu here from when I was first trying to add > TRUNCATE as a GRANT'able option and being told we didn't want to burn > those precious bits. Right, it's the same issue ... although in that case there are a lot more bit

Re: Valgrind mem-check for postgres extension

On 2022-05-18 We 01:12, Tom Lane wrote: > Natarajan R writes: >> I have few doubts in here, >> 1. When I run with *--leak-check=full*, I get memory leaks for postgres >> functions under possibly or definitely lost categories.. Is this expected? > Maybe ... you did not show your test case, so it'

Re: Limiting memory allocation

On 5/18/22 11:11, Alvaro Herrera wrote: On 2022-May-18, Jan Wieck wrote: Maybe I'm missing something, but what is it that you would actually consider a solution? Knowing your current memory consumption doesn't make the need for allocating some right now go away. What do you envision the respons

Re: Limiting memory allocation

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > On Tue, May 17, 2022 at 18:12 Tom Lane wrote: > >> ulimit might be interesting to check into as well. The last time I > >> looked, it wasn't too helpful for this on Linux, but that was years ago. > > > Unfortunately

Re: Limiting memory allocation

On 2022-May-18, Jan Wieck wrote: > Maybe I'm missing something, but what is it that you would actually consider > a solution? Knowing your current memory consumption doesn't make the need > for allocating some right now go away. What do you envision the response of > PostgreSQL to be if we had tha

Re: Limiting memory allocation

Le mercredi 18 mai 2022, 16:23:34 CEST Jan Wieck a écrit : > On 5/17/22 18:30, Stephen Frost wrote: > > Greetings, > > > > On Tue, May 17, 2022 at 18:12 Tom Lane > > > > wrote: > > Jan Wieck mailto:j...@wi3ck.info>> writes: > > > On 5/17/22 15:42, Stephen Fros

Re: Limiting memory allocation

On 5/17/22 18:30, Stephen Frost wrote: Greetings, On Tue, May 17, 2022 at 18:12 Tom Lane > wrote: Jan Wieck mailto:j...@wi3ck.info>> writes: > On 5/17/22 15:42, Stephen Frost wrote: >> Thoughts? > Using cgroups one can actually force a certain pro

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

Em qua., 18 de mai. de 2022 às 10:52, Peter Eisentraut < peter.eisentr...@enterprisedb.com> escreveu: > On 18.05.22 01:18, Justin Pryzby wrote: > > Take the first one as an example. It says: > > > > GenericCosts costs; > > MemSet(&costs, 0, sizeof(costs)); > > > > You sent a pat

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

On 18.05.22 01:18, Justin Pryzby wrote: Take the first one as an example. It says: GenericCosts costs; MemSet(&costs, 0, sizeof(costs)); You sent a patch to change it to sizeof(GenericCosts). But it's not a pointer, so they are the same. This instance can more easily be wr

Re: Minor improvements to test log navigability

On 16.05.22 01:01, Thomas Munro wrote: 2. The TAP test logs are strangely named. Any reason not to call them 001_testname.log, instead of regress_log_001_testname, so they appear next to the corresponding 001_testname_{primary,standby,xxx}.log in directory listings (CI) and dumps (build farm, p

Re: support for MERGE

On Wed, May 11, 2022 at 11:33:50AM -0500, Justin Pryzby wrote: > I suggest to reference the mvcc docs from the merge docs, or to make the merge > docs themselves include the referenced information. No comments here ? > Also, EXPLAIN output currently looks like this: > > | Merge on ex_mtarget t (

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

Em qua., 18 de mai. de 2022 às 05:54, Alvaro Herrera < alvhe...@alvh.no-ip.org> escreveu: > This one caught my attention: > > diff --git a/contrib/pgcrypto/crypt-blowfish.c > b/contrib/pgcrypto/crypt-blowfish.c > index a663852ccf..63fcef562d 100644 > --- a/contrib/pgcrypto/crypt-blowfish.c > +++ b

Re: Handle infinite recursion in logical replication setup

On Wed, May 18, 2022 at 10:29 AM Amit Kapila wrote: > > On Wed, May 4, 2022 at 12:17 PM vignesh C wrote: > > > > Thanks for the comments, the attached v13 patch has the changes for the > > same. > > > > Few comments on v13-0001 > == > Few comments on v13-0002 ===

Re: Privileges on PUBLICATION

Euler Taveira wrote: > On Fri, May 13, 2022, at 3:36 AM, Antonin Houska wrote: > > Attached is my proposal. It tries to be more specific and does not mention > the > absence of the privileges explicitly. > > You explained the current issue but say nothing about the limitation. This > informa

Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

On Wed, May 18, 2022 at 01:03:15AM -0700, Noah Misch wrote: > On Mon, May 16, 2022 at 02:30:00PM +0900, Michael Paquier wrote: >> Because the shape of the new names does not change the test coverage >> ("regression" prefix or the addition of the double quotes with >> backslashes for all the databas

Re: Privileges on PUBLICATION

Antonin Houska wrote: > Euler Taveira wrote: > > > On Tue, May 10, 2022, at 5:37 AM, Antonin Houska wrote: > > > > My understanding is that the rows/columns filtering is a way for the > > *publisher* to control which data is available to particular replica. From > > this point of view, the

Re: Remove support for Visual Studio 2013

On Wed, May 18, 2022 at 10:06:50AM +0200, Juan José Santamaría Flecha wrote: > Right now we are ifdefing that code out for MinGW, so it's not a visible > issue, but it'll be when we do. OK. Thanks, got it. -- Michael signature.asc Description: PGP signature

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

This one caught my attention: diff --git a/contrib/pgcrypto/crypt-blowfish.c b/contrib/pgcrypto/crypt-blowfish.c index a663852ccf..63fcef562d 100644 --- a/contrib/pgcrypto/crypt-blowfish.c +++ b/contrib/pgcrypto/crypt-blowfish.c @@ -750,7 +750,7 @@ _crypt_blowfish_rn(const char *key, const char *

RE: Data is copied twice when specifying both child and parent table in publication

On Wed, May 18, 2022 4:38 PM I wrote: > Attach the patches.(Only changed the patch for HEAD.) Sorry, I forgot to update commit message. Attach the new patch. 1. Only update the commit message for HEAD_v5. Regards, Wang wei HEAD_v5-0001-Fix-data-replicated-twice-when-specifying-PUBLISH.patch Des

RE: Data is copied twice when specifying both child and parent table in publication

On Fri, May 13, 2022 10:57 PM Osumi, Takamichi/大墨 昂道 wrote: > On Friday, May 13, 2022 6:42 PM Wang, Wei/王 威 > wrote: > > Attach the patches.(Only changed the patch for HEAD.). > > 1. Optimize the code. Reduce calls to function filter_partitions. > > [suggestions by Amit-san] 2. Improve the alias

RE: Data is copied twice when specifying both child and parent table in publication

On Tues, May 17, 2022 9:03 PM Amit Kapila wrote: > On Fri, May 13, 2022 at 3:11 PM wangw.f...@fujitsu.com > wrote: > > > > Attach the patches.(Only changed the patch for HEAD.). > > Thanks for your comments. > # publications > -{ oid => '6119', descr => 'get OIDs of tables in a publication', >

Re: [RFC] building postgres with meson -v8

Here are some more patches that clean up various minor issues.From bc06fda7198d182dce73f39cfff8e4724e00b12d Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 4 May 2022 14:38:02 +0200 Subject: [PATCH 1/7] meson: Put genbki header files back into original order The order affects the out

RE: Handle infinite recursion in logical replication setup

On Wed, May 4, 2022 2:47 PM vignesh C wrote: > > Thanks for the comments, the attached v13 patch has the changes for the same. > Thanks for your patch. Here are some comments on v13-0001 patch. 1) @@ -152,6 +152,18 @@ CREATE SUBSCRIPTION subscription_name + +local_on

Re: [PATCH] New [relation] option engine

forbid_realloc is only tested in an assert. There needs to be an "if" test for it somewhere (suppose some extension author uses this API and only runs it in assert-disabled environment; they'll never know they made a mistake). But do we really need this option? Why do we need a hardcoded limit i

Re: Remove support for Visual Studio 2013

On Wed, May 18, 2022 at 2:27 AM Michael Paquier wrote: > > @@ -1757,7 +1757,7 @@ get_collation_actual_version(char collprovider, > const char *collcollate) > collcollate, > GetLastError(; > } > -collversion = psprintf(

Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

On Mon, May 16, 2022 at 02:30:00PM +0900, Michael Paquier wrote: > On Sat, May 14, 2022 at 01:27:28AM -0700, Noah Misch wrote: > > Here, I requested the rationale for the differences you had just described. > > You made a choice to stop testing one list of database names and start > > testing > >

Re: Intermittent buildfarm failures on wrasse

On Sun, May 15, 2022 at 12:29 AM Alvaro Herrera wrote: > > On 2022-Apr-20, Masahiko Sawada wrote: > > > > MyProc->statusFlags = (MyProc->statusFlags & ~PROC_XMIN_FLAGS) | > > > (proc->statusFlags & PROC_XMIN_FLAGS); > > > > > > Perhaps the latter is more future-proof.

Re: Allow file inclusion in pg_hba and pg_ident files

Hi, On Tue, Mar 29, 2022 at 04:14:54PM +0800, Julien Rouhaud wrote: > > I'm attaching a rebase of the rest of the patchset. Note that I also added > support for an "include_dir" directive, as it's also something that would be > quite helpful (and very welcome for my $work use case). The cfbot r

Re: Perform streaming logical transactions by background workers and parallel apply

"Here are my review comments for v6-0001. == 1. General I saw that now in most places you are referring to the new kind of worker as the "apply background worker". But there are a few comments remaining that still refer to "bgworker". Please search the entire patch for "bgworker" in the comm