Re: proposal: possibility to read dumped table's name from file

2022-10-01 Thread Andres Freund
Hi, On 2022-09-12 09:58:37 +0200, Daniel Gustafsson wrote: > Correct, fixed in the attached. Updated patch adding meson compatibility attached. Greetings, Andres Freund >From 5d3ba4d2d6567626ccc0019208ea4c0ea91ac866 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Wed, 7 Sep 2022 15:22:0

Re: Documentation building fails on HTTPS redirect (again)

2022-10-01 Thread Andres Freund
Hi, On 2022-09-30 11:35:36 +0200, Daniel Gustafsson wrote: > Installing the stylesheets locally as we document solves the issue of course, > but maybe it's time to move to using --nonet as we discussed in [0] and > require > the stylesheets locally? It's a shame that casual contributions require

Re: CI and test improvements

2022-10-01 Thread Andres Freund
Hi, On 2022-10-01 19:58:01 -0500, Justin Pryzby wrote: > One other thing is that your -m32 changes caused the linux/meson task to > take an additional 3+ minutes (total ~8). That's no issue, except that > the Warnings task depends on the linux/mason task, and itself can take > up to 15 minutes.

Re: Eliminating SPI from RI triggers - take 2

2022-10-01 Thread Andres Freund
Hi, On 2022-10-01 18:21:15 -0700, Andres Freund wrote: > On 2022-09-29 18:18:10 +0900, Amit Langote wrote: > > So, here's a final revision for today. Sorry for the noise. > > This appears to fail on 32bit systems. Seems the new test is indeed > worthwhile... > > https://cirrus-ci.com/task/6581521

Re: Eliminating SPI from RI triggers - take 2

2022-10-01 Thread Andres Freund
Hi, On 2022-09-29 18:18:10 +0900, Amit Langote wrote: > So, here's a final revision for today. Sorry for the noise. This appears to fail on 32bit systems. Seems the new test is indeed worthwhile... https://cirrus-ci.com/task/6581521615159296?logs=test_world_32#L406 [19:12:24.452] Summary of Fa

Re: Tightening behaviour for non-immutable behaviour in immutable functions

2022-10-01 Thread Andres Freund
Hi, On 2022-06-16 12:04:12 -0400, Greg Stark wrote: > Of course this patch is still very WIP. Only one or the other function > makes sense to keep. And I'm not opposed to having a GUC to > enable/disable the enforcement or warnings. And the code itself needs > to be cleaned up with parts of it mov

Re: TAP output format in pg_regress

2022-10-01 Thread Andres Freund
Hi, On 2022-09-01 14:21:18 +0200, Daniel Gustafsson wrote: > Attached is a v8 which fixes a compiler warning detected by the CFBot. cfbot at the moment does show a warning. A bit surprised to see this warning enabled by default in gcc, but it seems correct here: [20:57:02.892] make -s -j${BUILD_

Re: CI and test improvements

2022-10-01 Thread Justin Pryzby
On Sat, Oct 01, 2022 at 05:45:01PM -0700, Andres Freund wrote: > Hi, > > On 2022-09-10 15:05:42 -0500, Justin Pryzby wrote: > > From 4ed5eb427de4508a4c3422e60891b45c8512814a Mon Sep 17 00:00:00 2001 > > From: Justin Pryzby > > Date: Sun, 3 Apr 2022 00:10:20 -0500 > > Subject: [PATCH 03/23] cirrus

Re: CI and test improvements

2022-10-01 Thread Andres Freund
Hi, On 2022-09-10 15:05:42 -0500, Justin Pryzby wrote: > From 4ed5eb427de4508a4c3422e60891b45c8512814a Mon Sep 17 00:00:00 2001 > From: Justin Pryzby > Date: Sun, 3 Apr 2022 00:10:20 -0500 > Subject: [PATCH 03/23] cirrus/ccache: disable compression and show stats > > Since v4.0, ccache enables z

Re: ci: reduce macos test concurrency

2022-10-01 Thread Andres Freund
Hi, On 2022-09-26 21:02:08 -0700, Andres Freund wrote: > The x86 mac VMs from cirrus-ci claim to have 12 CPUs, but when working on > initdb caching for tests I noticed that using all those CPUs for tests hurts > the test times noticably. > > See [1] (note that the overall time is influenced by di

Re: longfin and tamandua aren't too happy but I'm not sure why

2022-10-01 Thread Justin Pryzby
On Sat, Oct 01, 2022 at 03:15:14PM -0700, Andres Freund wrote: > On 2022-10-01 11:14:20 -0500, Justin Pryzby wrote: > > (I still suggest my patches to run all tests using vcregress. The number of > > people who remember that, for v15, cirrusci runs incomplete tests is > > probably > > fewer than

Re: Question: test "aggregates" failed in 32-bit machine

2022-10-01 Thread Tom Lane
"Jonathan S. Katz" writes: > On 10/1/22 3:13 PM, Tom Lane wrote: >> I'm still of the opinion that we need to revert this code for now. > [RMT hat, but speaking just for me] reading through Tom's analysis, this > seems to be the safest path forward. I have a few questions to better > understand:

Re: longfin and tamandua aren't too happy but I'm not sure why

2022-10-01 Thread Andres Freund
Hi, On 2022-10-01 11:14:20 -0500, Justin Pryzby wrote: > I just tried this, which works fine at least for v11-v14: > | git checkout origin/REL_15_STABLE .cirrus.yml src/tools/ci > > https://cirrus-ci.com/task/5742859943936000 v15a > https://cirrus-ci.com/task/6725412431593472 v15b > https://cirru

Re: Question: test "aggregates" failed in 32-bit machine

2022-10-01 Thread Jonathan S. Katz
On 10/1/22 3:13 PM, Tom Lane wrote: I'm still of the opinion that we need to revert this code for now. [RMT hat, but speaking just for me] reading through Tom's analysis, this seems to be the safest path forward. I have a few questions to better understand: 1. How invasive would the revert

Re: interrupted tap tests leave postgres instances around

2022-10-01 Thread Andres Freund
Hi, On 2022-09-30 11:17:00 +0200, Alvaro Herrera wrote: > But on testing, some nodes linger after being sent a shutdown signal. > I'm not clear why this is -- I think it's due to the fact that we send > the signal just as the node is starting up, which means the signal > doesn't reach the process.

Re: pg_regress: lookup shellprog in $PATH

2022-10-01 Thread Noah Misch
On Thu, Aug 25, 2022 at 04:04:39PM -0400, Tom Lane wrote: > Robert Haas writes: > > On Thu, Aug 25, 2022 at 10:48 AM Tom Lane wrote: > >> If we were executing a program that the user needs to have some control > >> over, sure, but what we have here is an implementation detail that I > >> doubt an

Re: Question: test "aggregates" failed in 32-bit machine

2022-10-01 Thread Tom Lane
Peter Geoghegan writes: > Reminds me of the other sort testing program that you wrote when the > B&M code first went in: > https://www.postgresql.org/message-id/18732.1142967...@sss.pgh.pa.us Ha, I'd totally forgotten about that ... regards, tom lane

Re: [PATCH v1] [meson] add a default option prefix=/usr/local/pgsql

2022-10-01 Thread Andres Freund
Hi, On 2022-09-30 19:07:21 -0700, Andres Freund wrote: > The attached 0001 calls into a meson helper command to do this. Not > particularly pretty, but less code than before, and likely more reliable. I pushed Junwang Zhao's patch together with this change, after adding a comment to the setting o

Re: Question: test "aggregates" failed in 32-bit machine

2022-10-01 Thread Peter Geoghegan
On Sat, Oct 1, 2022 at 12:14 PM Tom Lane wrote: > I spent some time today looking into the question of what our qsort > code actually does. I wrote a quick-n-dirty little test module > (attached) to measure the number of comparisons qsort really uses > for assorted sample inputs. Reminds me of t

Re: Question: test "aggregates" failed in 32-bit machine

2022-10-01 Thread Tom Lane
I wrote: > So at this point I've lost all faith in the estimates being meaningful > at all. I spent some time today looking into the question of what our qsort code actually does. I wrote a quick-n-dirty little test module (attached) to measure the number of comparisons qsort really uses for asso

Re: missing indexes in indexlist with partitioned tables

2022-10-01 Thread Arne Roland
On Tue, Sep 20, 2022 at 4:53 PM David Rowley wrote: > Arne sent me an off-list > message to say he's planning on working on the patch that uses the > existing field instead of the new one he originally added. Let's hold > off for that patch. I wouldn't say, I explicitly stated that. But I ended u

Re: longfin and tamandua aren't too happy but I'm not sure why

2022-10-01 Thread Justin Pryzby
On Wed, Sep 28, 2022 at 08:45:31PM -0700, Andres Freund wrote: > Hi, > > On 2022-09-28 21:22:26 +0200, Alvaro Herrera wrote: > > I have an additional, unrelated complaint about CI, which is that we > > don't have anything for past branches. I have a partial hack(*), but > > I wish we had somethin

Re: postgres_fdw: dead lock in a same transaction when postgres_fdw server is lookback

2022-10-01 Thread Laurenz Albe
On Sat, 2022-10-01 at 04:02 +, Xiaoran Wang wrote: > I created a postgers_fdw server lookback as the test does. Then run the > following SQLs > > [create a foreign server via loopback and manipulate the same data locally > and via foreign table] > > Then the transaction got stuck. Should th

Re: ICU for global collation

2022-10-01 Thread Peter Eisentraut
On 22.09.22 20:06, Marina Polyakova wrote: On 2022-09-21 17:53, Peter Eisentraut wrote: Committed with that test, thanks.  I think that covers all the ICU issues you reported for PG15 for now? I thought about the order of the ICU checks - if it is ok to check that the selected encoding is sup

Re: kerberos/001_auth test fails on arm CPU darwin

2022-10-01 Thread Peter Eisentraut
On 27.09.22 17:35, Nazir Bilal Yavuz wrote: I updated my patch regarding these reviews. The current logic is it will try to find all executables in that order(if it finds all executables, it won't try remaining steps): 1 - 'krb5-config --prefix' 2 - hardcoded paths(I added arm and MacPorts

Re: [PATCH] Log details for client certificate failures

2022-10-01 Thread Peter Eisentraut
On 29.09.22 06:52, Masahiko Sawada wrote: While this seems a future-proof idea, I wonder if it might be overkill since we don't need to worry about accumulation of leaked memory in this case. Given that only check_cluter_name is the case where we found a small memory leak, I think it's adequate t

Re: Bloom filter Pushdown Optimization for Merge Join

2022-10-01 Thread Zhihong Yu
On Fri, Sep 30, 2022 at 9:20 PM Zhihong Yu wrote: > > > On Fri, Sep 30, 2022 at 8:40 PM Zhihong Yu wrote: > >> >> >> On Fri, Sep 30, 2022 at 3:44 PM Zheng Li wrote: >> >>> Hello, >>> >>> A bloom filter provides early filtering of rows that cannot be joined >>> before they would reach the join o