Added patch to upcoming commitfest
https://commitfest.postgresql.org/patch/5908/
Thanks & Regards,
Sunil S
On Wed, Jul 9, 2025 at 12:01 AM sunil s wrote:
> Hello Hackers,
>
> I recently had the opportunity to continue the effort originally led by a
> valued contributor.
> I’ve addressed most o
On Thu, Jul 10, 2025 at 11:18 AM Dilip Kumar wrote:
>
> On Thu, Jul 10, 2025 at 11:11 AM vignesh C wrote:
> >
> > On Wed, 9 Jul 2025 at 17:47, Dilip Kumar wrote:
> > >
> > > On Wed, Jul 9, 2025 at 5:29 PM Álvaro Herrera
> > > wrote:
> > > >
> > > > On 2025-Jul-09, Dilip Kumar wrote:
> > > >
>
On Tue, 08 Jul 2025 at 10:11, Peter Smith wrote:
> Hi. Here is the latest patch set.
>
> Main differences are:
>
> Patch 0001 (core)
> - removed embedded vci code from autovacuum.c / postinit.c (now these
> are same as master)
>
> Patch 0002 (vci module)
> - a few changes to facilitate the fix to
Steve Lau writes:
> 1. Will the thread-safety issue of getpwuid() affect Postgres? Why?
You have to pay attention to context. AFAICS the two extant calls
to getpwuid() are in
1. psql's exec_command_cd(). psql is not multithreaded and I'd
be surprised if there is a reason to make it so.
2. src
On Thu, Jul 10, 2025 at 11:11 AM vignesh C wrote:
>
> On Wed, 9 Jul 2025 at 17:47, Dilip Kumar wrote:
> >
> > On Wed, Jul 9, 2025 at 5:29 PM Álvaro Herrera wrote:
> > >
> > > On 2025-Jul-09, Dilip Kumar wrote:
> > >
> > > > On Wed, Jul 9, 2025 at 9:07 AM Dilip Kumar
> > > > wrote:
> > >
> > >
On Wed, 9 Jul 2025 at 17:47, Dilip Kumar wrote:
>
> On Wed, Jul 9, 2025 at 5:29 PM Álvaro Herrera wrote:
> >
> > On 2025-Jul-09, Dilip Kumar wrote:
> >
> > > On Wed, Jul 9, 2025 at 9:07 AM Dilip Kumar wrote:
> >
> > > > After further consideration, I believe your proposed method is
> > > > super
On Thu, Jul 10, 2025 at 5:10 PM Steve Lau wrote:
> Hi hackers, when reading the source code, I noticed that Postgres is still
> using getpwuid(), which is not thread-safe since it returns a pointer to the
> static memory that can be overwritten by concurrent calls. Then I searched
> "getpwuid"
On Wed, Jul 09, 2025 at 04:31:31PM +0900, Michael Paquier wrote:
> Attached is a rebased version of the rest, with the recent stanza
> related to fef6da9e9c87 taken into account. 0002 still has a change
> that should be in 0001: I have not really touched the structure of the
> two remaining patche
On Thu, Jul 10, 2025 at 10:34 AM Dilip Kumar wrote:
>
> On Thu, Jul 10, 2025 at 9:55 AM Dilip Kumar wrote:
> >
> > On Thu, Jul 10, 2025 at 9:31 AM Fujii Masao
> > wrote:
> > >
> > >
> > >
> > > On 2025/07/10 4:26, Nathan Bossart wrote:
> > > > Here is what I have staged for commit, which I'm pl
On Thu, 10 Jul 2025 13:23:47 +0900
Fujii Masao wrote:
>
>
> On 2025/07/10 10:30, Yugo Nagata wrote:
> > You're right. I must have overlooked something. I think I saw "TO" being
> > suggested after "FOREIGN SERVER" when no foreign servers were defined.
> >
> > The attached patch still prevents
Hi hackers, when reading the source code, I noticed that Postgres is still
using getpwuid(), which is not thread-safe since it returns a pointer to the
static memory that can be overwritten by concurrent calls. Then I searched
"getpwuid" in the mailing list[1], and there was a committed patch th
On Thu, Jul 10, 2025 at 9:55 AM Dilip Kumar wrote:
>
> On Thu, Jul 10, 2025 at 9:31 AM Fujii Masao
> wrote:
> >
> >
> >
> > On 2025/07/10 4:26, Nathan Bossart wrote:
> > > Here is what I have staged for commit, which I'm planning to do on Friday.
> >
> > Thanks for updating the patches!
> >
> >
On Thu, Jul 10, 2025 at 3:45 PM Thomas Munro wrote:
> [03:28:24.318] Program msgfmt found: NO
Correction, that ^ is the reason it's not reached on the MSVC task,
while -Dnls=disabled is the reason for the MinGW task. But the
conclusion is the same: MinGW is the easiest way to test this code
on C
On Thu, Jul 10, 2025 at 9:31 AM Fujii Masao wrote:
>
>
>
> On 2025/07/10 4:26, Nathan Bossart wrote:
> > Here is what I have staged for commit, which I'm planning to do on Friday.
>
> Thanks for updating the patches!
>
> Regarding the 0005 patch:
>
> - COMPLETE_WITH("MODE");
On 2025/07/10 10:30, Yugo Nagata wrote:
You're right. I must have overlooked something. I think I saw "TO" being
suggested after "FOREIGN SERVER" when no foreign servers were defined.
The attached patch still prevents "TO/FROM" from being suggested after
"FOREIGN SERVER" in such cases.
Than
On Thu, Jul 10, 2025 at 9:42 AM Tom Lane wrote:
>
> Amit Kapila writes:
> > What shall we do for exposed check_hook functions
> > check_max_slot_wal_keep_size() and
> > check_idle_replication_slot_timeout() in backbranch? Shall we remove
> > there as well or leave them to avoid the risk of breaki
Amit Kapila writes:
> What shall we do for exposed check_hook functions
> check_max_slot_wal_keep_size() and
> check_idle_replication_slot_timeout() in backbranch? Shall we remove
> there as well or leave them to avoid the risk of breaking any
> application?
It's impossible to believe that any ex
On Wed, Jul 9, 2025 at 5:46 PM Dilip Kumar wrote:
>
> On Wed, Jul 9, 2025 at 5:29 PM Álvaro Herrera wrote:
> >
>
> > I propose a few comment updates on top of your patch.
>
> This comment updates LGTM, so included in v3.
>
What shall we do for exposed check_hook functions
check_max_slot_wal_keep
On 2025/07/10 4:26, Nathan Bossart wrote:
Here is what I have staged for commit, which I'm planning to do on Friday.
Thanks for updating the patches!
Regarding the 0005 patch:
- COMPLETE_WITH("MODE");
+ COMPLETE_WITH("MODE, FLUSH_UNLOGGED");
Sho
On Tue, Jul 8, 2025 at 2:37 PM jian he wrote:
>
> On Tue, Apr 15, 2025 at 4:36 PM jian he wrote:
> >
> > comment out tests are for to be implemented feature.
> > There are some test changes that are indeed not necessary, I restored it
> > back,
> > please check attached.
>
> hi.
> refactor and r
On Thu, Jul 10, 2025 at 5:32 AM Jeff Davis wrote:
> I was trying to exercise the function IsoLocaleName(), which is
> surrounded by:
>
>#if defined(WIN32) && defined(LC_MESSAGES)
>
> but, at least in CI, that combination never seems to be true, which
> surprised me. What platforms exercise thi
On Wed, Jul 09, 2025 at 06:21:05PM -0700, Paul Jungwirth wrote:
> Here is a patch with the new order.
Thanks, done.
--
Michael
signature.asc
Description: PGP signature
Thanks for the review Aleksander,
> On 9 Jul 2025, at 10:45 PM, Aleksander Alekseev
> wrote:
>
> Hi Florents,
>
> Thanks for the update!
>
>> here's a v4 patch set
>>
>> - Extracted pg_base64_{en,de}_internal with an additional bool url param,
>> to be used by other functions
>> - Added a
On Wed, Jul 9, 2025 at 6:50 PM Ashutosh Bapat
wrote:
>
> On Wed, Jul 9, 2025 at 8:30 AM shveta malik wrote:
> > >
> > > I have split your top up patch into 2 - one related to the document
> > > change being the subject of this thread and the other for fixing the
> > > query. Committer may squash
On Thu, Jul 10, 2025 at 3:40 AM Tom Lane wrote:
> Now that v19 development is open, I'd like to get this work
> pushed sooner rather than later, before the patches bit-rot
> too much, and so that we can get started on follow-on work
> to remove remaining leaks. Does anyone want to review it
> fur
Hi,
The v2 patch maybe more clear:
We can calc bucket just by hashvalue & high_mask when expanding table
because the if condition in calc_bucket() must be false.
--
Regards,
ChangAo Chen
v2-0001-Small-optimization-with-expanding-dynamic-hash-ta.patch
Description: Binary data
On Tue, Jul 08, 2025 at 11:43:17PM -0400, Peter Geoghegan wrote:
> On Tue, Jul 8, 2025 at 11:04 PM Noah Misch wrote:
> > > -backwards_scan_session: NOTICE: notice triggered for injection point
> > > lock-and-validate-new-lastcurrblkno
> > > +ERROR: could not find injection point lock-and-valida
On Wed, 9 Jul 2025 20:42:42 +0900
Fujii Masao wrote:
>
>
> On 2025/06/11 13:57, Yugo Nagata wrote:
> > On Wed, 11 Jun 2025 13:33:07 +0900
> > Fujii Masao wrote:
> >
> >>
> >>
> >> On 2025/06/11 11:49, Yugo Nagata wrote:
> >>> While looking at the thread [1], I've remembered this thread.
> >>>
On 7/9/25 16:16, Michael Paquier wrote:
On Wed, Jul 09, 2025 at 01:52:08PM -0400, Tom Lane wrote:
I considered putting the sortsupport functions first, since they have a lower
support function
number, but I thought defining them in the same order as we've been doing was a
tiny bit safer.
Maybe
On Thu, Jul 03, 2025 at 12:14:55PM +0530, Rahila Syed wrote:
> #include "miscadmin.h"
> +#include "nodes/execnodes.h"
> #include "nodes/pg_list.h"
> #include "nodes/value.h"
>
> Do we need to include this? I did not see any compilation error when I
> removed this.
Right, this one was not neede
On Wed, Jul 09, 2025 at 03:46:43PM -0400, Tom Lane wrote:
> Andres Freund writes:
>> Seems like we should just remove TransactionIdIsActive()?
>
> +1. I wondered if any extensions might depend on it, but
> could not find any trace of that in Debian code search.
> And it's a sufficiently odd test
On Tue, Jul 8, 2025 at 1:14 PM Jeff Davis wrote:
> v4-0008 uses LC_C_LOCALE, and I'm not sure if that's portable, but if
> the buildfarm complains then I'll fix it or revert it.
(Catching up with this thread...)
LC_C_LOCALE is definitely not portable: I've only seen it on macOS and
NetBSD. It w
On Wed, Jul 9, 2025 at 12:42 PM Tom Lane wrote:
> Nah, let's keep them. We do document for at least some libraries
> how to manually specify the include and link options without
> depending on pkg-config. If someone tries that with libcurl,
> it'd be good to have sanity checks on the results.
S
On Thu, Jul 10, 2025 at 10:52 AM Jeff Davis wrote:
> The first problem -- how to affect the encoding of strings returned by
> strerror() on windows -- may be solvable as well. It looks like
> LC_MESSAGES is not supported at all on windows, so the only thing to be
> concerned about is the encoding,
Hi,
On 2025-01-22 10:07:51 +0900, Amit Langote wrote:
> On Fri, Jan 17, 2025 at 2:05 PM Amit Langote wrote:
> > Here's v5 with a few commit message tweaks.
> >
> > Barring objections, I would like to push this early next week.
>
> Pushed yesterday. Thank you all.
While looking at a profile I r
Hi,
On 2025-07-02 22:13:17 +0800, jian he wrote:
> On Thu, Jun 5, 2025 at 3:00 AM Andres Freund wrote:
> > I've been once more annoyed by this warning. Here's a prototype for the
> > approach outlined above.
> >
>
> I can confirm the warning disappears when using gcc-14.0 compile
> source code w
Hi,
On 2025-06-05 15:50:48 -0400, Tom Lane wrote:
> Andres Freund writes:
> >> I've been wondering about adding wrapping something like that in a
> >> pg_assume(expr) or such.
>
> > I've been once more annoyed by this warning. Here's a prototype for the
> > approach outlined above.
>
> Looks pl
On Wed, Jul 09, 2025 at 01:52:08PM -0400, Tom Lane wrote:
>> I considered putting the sortsupport functions first, since they have a
>> lower support function
>> number, but I thought defining them in the same order as we've been doing
>> was a tiny bit safer.
>> Maybe that is superstitious.
>
Hi,
I got pinged about issues (compiler warnings, and some test failures) in
the simple patch version shared in May. So here's a rebased and cleaned
up version addressing that, and a couple additional issues I ran into.
FWIW if you run check-world on this, you may get failures in io_workers
TAP t
On Mon, 2025-07-07 at 17:56 -0700, Jeff Davis wrote:
> I looked into this a bit, and if I understand correctly, the only
> problem is with strerror() and strerror_r(), which depend on
> LC_MESSAGES for the language but LC_CTYPE to find the right encoding.
...
> Windows would be a different story,
Damien Clochard writes:
> So this adds 5 new variants of the random() function:
> random(min date, max date) returns date
> random(min time, max time) returns time
> random(min time, max time, zone text) returns timetz
> random(min timestamp, max timestamp) returns timestamp
>
Hi,
This is a follow-up to a discussion started in [0].
LWLocks in PostgreSQL are categorized into tranches, and the tranche name
appears as the wait_event in pg_stat_activity. There are both built-in
tranche names and tranche names that can be registered by extensions using
RequestNamedLWLockTra
On Wed, 9 Jul 2025 at 18:27, Andres Freund wrote:
>
> I think we should wire this up to the buildsystem and our testsuite... Having
> testcode that is not run automatically may be helpful while originally
> developing something, but it doesn't do anything to detect portability issues
> or regress
Re: Nathan Bossart
> Here is what I have staged for commit, which I'm planning to do on Friday.
> diff --git a/doc/src/sgml/ref/pg_basebackup.sgml
> b/doc/src/sgml/ref/pg_basebackup.sgml
> index 9659f76042c..9be752fc12b 100644
> --- a/doc/src/sgml/ref/pg_basebackup.sgml
> +++ b/doc/src/sgml/ref/p
On Wednesday, July 9, 2025, Hari Krishna Sunder
wrote:
> > I disagree here. There are regular ON TRUNCATE triggers on tables, so I
> don't
> > see the need. You can define a trigger with the same trigger function on
> > several tables.
>
> You have to create a trigger for each table, and drop t
Hello,
As I am involved in the PostgreSQL Anonymizer extension, I found that
the random(min,max) functions introduced recently are very useful to
generate synthetic data or define a masking policy.
I decided to submit a similar set of functions for random dates and
times.
So this adds 5 ne
Ah, I see.
I retried and now it runs for 21 to 29 seconds for 1 million large
objects with two grants each, 3M total rows inserted.
Yesterday it ran 8 seconds. Unfortunately I do not have the plan from
yesterday saved .
Anyway it looks like just dumping pg_shdepend it is better, and likely
also
> I disagree here. There are regular ON TRUNCATE triggers on tables, so I
don't
> see the need. You can define a trigger with the same trigger function on
> several tables.
You have to create a trigger for each table, and drop them before you drop
the table. The DDL trigger will just work more s
Hi,
On 2025-07-09 16:10:25 -0400, Tom Lane wrote:
> Andrew Dunstan writes:
> > /*
> > To turn off/hide the contents of this file:
> > #define
> > MICROSOFT_WINDOWS_WINBASE_H_DEFINE_INTERLOCKED_CPLUSPLUS_OVERLOADS 0
> > */
>
> > I don't think we have any other VS 2019 machin
Andrew Dunstan writes:
> On 2025-07-08 Tu 4:10 PM, Andrew Dunstan wrote:
>> On 2025-07-08 Tu 3:45 PM, Tom Lane wrote:
>>> In the no-good-deed-goes-unpunished department ... drongo is now spewing
>>> a boatload of these warnings:
>>>
>>> C:\\Program Files (x86)\\Windows
>>> Kits\\10\\include\\10.
On 2025-07-08 Tu 4:10 PM, Andrew Dunstan wrote:
On 2025-07-08 Tu 3:45 PM, Tom Lane wrote:
Andrew Dunstan writes:
It's done and running. Testing before I re-enabled the animal it shows
it was happy.
In the no-good-deed-goes-unpunished department ... drongo is now spewing
a boatload of these
Andres Freund writes:
> Seems like we should just remove TransactionIdIsActive()?
+1. I wondered if any extensions might depend on it, but
could not find any trace of that in Debian code search.
And it's a sufficiently odd test (as noted in its comments)
that one could debate whether using it fo
Jacob Champion writes:
> On Wed, Jul 9, 2025 at 12:07 PM Tom Lane wrote:
>> I'm confused about why this moves up the temporary changes of
>> CPPFLAGS and LDFLAGS, but not LIBS? Maybe that's actually correct,
>> but it looks strange (and perhaps deserves a comment about why).
> Does the attached
Hi,
Thanks for working on this! I think it's an area we have long neglected...
On 2025-07-01 21:07:00 +0200, Tomas Vondra wrote:
> Each patch has a numa_ GUC, intended to enable/disable that part. This
> is meant to make development easier, not as a final interface. I'm not
> sure how exactly t
On Wed, Jul 9, 2025 at 12:11 PM Tom Lane wrote:
> "David G. Johnston" writes:
> > On Wed, Jul 9, 2025 at 9:15 AM Tom Lane wrote:
> >> TBH, I find this proposal to be useless nannyism.
>
> > Isn't preventing a dump-restore hazard sufficient reason to do this?
>
> No, I don't think so. If you're
On Wed, Jul 9, 2025 at 12:07 PM Tom Lane wrote:
> Jacob Champion writes:
> > Here is a draft patch for Ivan's reported issue; I still need to put
> > it through its paces with some more unusual setups, but I want to get
> > cfbot on it.
>
> I'm confused about why this moves up the temporary chang
Here is what I have staged for commit, which I'm planning to do on Friday.
--
nathan
>From ffb16241a57bcbe35445754e606e47a073eedf0d Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Wed, 9 Jul 2025 10:05:10 -0500
Subject: [PATCH v8 1/5] Rename CHECKPOINT_FLUSH_ALL to
CHECKPOINT_FLUSH_UNLOGGED
"David G. Johnston" writes:
> On Wed, Jul 9, 2025 at 9:15 AM Tom Lane wrote:
>> TBH, I find this proposal to be useless nannyism.
> Isn't preventing a dump-restore hazard sufficient reason to do this?
No, I don't think so. If you're not being very careful about revising
functions used in index
Jacob Champion writes:
> Here is a draft patch for Ivan's reported issue; I still need to put
> it through its paces with some more unusual setups, but I want to get
> cfbot on it.
I'm confused about why this moves up the temporary changes of
CPPFLAGS and LDFLAGS, but not LIBS? Maybe that's actu
On Wed, Jul 9, 2025 at 9:15 AM Tom Lane wrote:
> "=?utf-8?B?c3VuZGF5amlhbmco6JKL5rWp5aSpKQ==?="
> writes:
> > > The purpose of this patch is to prevent replacing a function via
> `CREATE OR REPLACE FUNCTION` with a new definition that is not marked as
> `IMMUTABLE`, if the existing function is r
Thanks Noah for the comments.
On Wed, 9 Jul 2025 at 02:58, Noah Misch wrote:
>
> On Fri, Apr 04, 2025 at 04:11:05PM -0400, Andrew Dunstan wrote:
> > Thanks. I have pushed these now with a few further small tweaks.
>
> This drops all databases:
>
> pg_dumpall --clean -Fd -f /tmp/dump
> pg_restore
I wrote:
> Here's a v3 patchset that's rebased up to HEAD (on top of the
> extracted fixes I already pushed) and responds to your review
> comments.
Now that v19 development is open, I'd like to get this work
pushed sooner rather than later, before the patches bit-rot
too much, and so that we can
On Wed, Jul 9, 2025 at 11:13 AM Tom Lane wrote:
> Jacob Champion writes:
> > I'll work up a patch to send through the CI. I can't currently test
> > RHEL8 easily -- Rocky 8 is incompatible with my Macbook? -- which I
> > will need to rectify eventually, but I can't this week.
>
> No need, I alrea
Hi,
While looking at Tomas' NUMA patchset I got curious what we use
TransactionIdIsActive() for (it's modified in the patchset). Turns out we
don't. And haven't for a long while, the last use was removed in
commit bb38fb0d43c
Author: Heikki Linnakangas
Date: 2014-05-15 16:37:50 +0300
Fix
Jacob Champion writes:
> I'll work up a patch to send through the CI. I can't currently test
> RHEL8 easily -- Rocky 8 is incompatible with my Macbook? -- which I
> will need to rectify eventually, but I can't this week.
No need, I already tested locally. Will push shortly.
hi.
the attached patch is to implement the $subject feature.
i was mainly intrigued by the discussion in
https://www.postgresql.org/message-id/20190226061450.ga1665...@rfd.leadboat.com
the main gotcha is struct NewColumnValue.
we do ``palloc0(sizeof(NewColumnValue));`` in ATExecAddColumn,
ATExecS
On Wed, Jul 9, 2025 at 10:36 AM Tom Lane wrote:
> Per "man dlopen", you have to link with libdl to use these functions
> on this platform. (Curiously, although RHEL9 still says that in the
> documentation, it doesn't seem to actually need -ldl.) I was able
> to resolve this by adding -ldl in lib
Hi,
On 2025-07-08 16:06:00 +, Cédric Villemain wrote:
> > Assuming we want to actually pin tasks from within Postgres, what I
> > think might work is allowing modules to "advise" on where to place the
> > task. But the decision would still be done by core.
>
> Possibly exactly what you're doi
On Wed, Jul 09, 2025 at 04:52:16PM +0200, Hannu Krosing wrote:
> If you run it without the last WHERE it is reasonably fast. And it
> behaves the same as just inserting from the dump which also does not
> have any checks against duplicates.
With that change, the query is much faster, but my testin
Paul Jungwirth writes:
> On 7/9/25 08:51, Tom Lane wrote:
>> +1 for merging those two while we still can.
> Patch attached, based on REL_18_STABLE.
> I considered putting the sortsupport functions first, since they have a lower
> support function
> number, but I thought defining them in the sa
Hi,
On 2025-07-09 13:36:26 -0400, Tom Lane wrote:
> It doesn't look like the Meson support needs such explicit tracking of
> required libraries, but perhaps I'm missing something?
It should be fine, -ldl is added to "os_deps" if needed, and os_deps is used
for all code in pg.
Greetings,
Andres
On 7/9/25 08:51, Tom Lane wrote:
Michael Paquier writes:
On Tue, Jul 08, 2025 at 04:49:30PM -0700, Paul Jungwirth wrote:
A related question: In the v18 release we are adding two upgrade files:
btree_gist--1.7--1.8.sql and btree_gist--1.8-1.9.sql. Why not collapse them
into one? Technically we
Jacob Champion writes:
> On Wed, Jul 2, 2025 at 5:45 AM Ivan Kush wrote:
>> Why don't we set LIBS in the configure in "checking for curl_multi_init"
>> using LIBCURL_LIBS or LIBCURL_LDFLAGS?
>> [...]
>> Without these LIBCURL... variables we will check a system libcurl, not
>> our local.
> Ah, th
I was trying to exercise the function IsoLocaleName(), which is
surrounded by:
#if defined(WIN32) && defined(LC_MESSAGES)
but, at least in CI, that combination never seems to be true, which
surprised me. What platforms exercise this code path?
Regards,
Jeff Davis
Hi,
On 2025-07-09 10:38:31 +0100, Dean Rasheed wrote:
> On Wed, 9 Jul 2025 at 07:41, John Naylor wrote:
> >
> > Hi Dean, I went to take a look at this and got stuck at building the
> > test file. The usual pointing gcc to the src and build include
> > directories didn't cut it. How did you get it
Hi,
On 2025-07-09 12:55:51 -0400, Greg Burd wrote:
> On Jul 9 2025, at 12:35 pm, Andres Freund wrote:
>
> > FWIW, I've started to wonder if we shouldn't just get rid of the freelist
> > entirely. While clocksweep is perhaps minutely slower in a single
> > thread than
> > the freelist, clock sweep
Hi,
On 2025-07-09 12:04:00 +0200, Jakub Wartak wrote:
> On Tue, Jul 8, 2025 at 2:56 PM Andres Freund wrote:
> > On 2025-07-08 14:27:12 +0200, Tomas Vondra wrote:
> > > On 7/8/25 05:04, Andres Freund wrote:
> > > > On 2025-07-04 13:05:05 +0200, Jakub Wartak wrote:
> > > > The reason it would be ad
On 2025-07-09 We 4:28 AM, Vamshikrishna T wrote:
Hi Team,
Here are few updates on the buildfarm setup for AIX.
We got a latest Power9 node in OSU lab dedicated for Postgres
community development activity.
In the last couple of weeks, we have setup the buildfarm on a node in
OSU lab for all
On Jul 9 2025, at 12:35 pm, Andres Freund wrote:
> FWIW, I've started to wonder if we shouldn't just get rid of the freelist
> entirely. While clocksweep is perhaps minutely slower in a single
> thread than
> the freelist, clock sweep scales *considerably* better [1]. As it's rather
> rare to
Hi,
On 2025-07-02 14:36:31 +0200, Tomas Vondra wrote:
> On 7/2/25 13:37, Ashutosh Bapat wrote:
> > On Wed, Jul 2, 2025 at 12:37 AM Tomas Vondra wrote:
> >>
> >>
> >> 3) v1-0003-freelist-Don-t-track-tail-of-a-freelist.patch
> >>
> >> Minor optimization. Andres noticed we're tracking the tail of bu
"=?utf-8?B?c3VuZGF5amlhbmco6JKL5rWp5aSpKQ==?=" writes:
> > The purpose of this patch is to prevent replacing a function via `CREATE OR
> > REPLACE FUNCTION` with a new definition that is not marked as `IMMUTABLE`,
> > if the existing function is referenced by an index expression.
> >
> > Replaci
Michael Paquier writes:
> On Tue, Jul 08, 2025 at 04:49:30PM -0700, Paul Jungwirth wrote:
>> A related question: In the v18 release we are adding two upgrade files:
>> btree_gist--1.7--1.8.sql and btree_gist--1.8-1.9.sql. Why not collapse them
>> into one? Technically we briefly had btree_gist--1.
On Jul 9, 2025, at 11:33, Andres Freund wrote:
> It'd be nice if we could get there, but it'd require annotating *all*
> intentionally exported functions in the backend with PGDLLIMPORT (rather than
> just doing that for variables). Then we could make some symbols
> *intentionally* not exported,
Hi,
On 2025-06-05 19:05:28 +0200, Álvaro Herrera wrote:
> On 2025-Jun-04, Mankirat Singh wrote:
>
> > Here's the workflow I tried to compile
> > $ ./configure CFLAGS="-Og -g -fvisibility=hidden"
> > --prefix=/home/mankirat/install/REL_17_4
> > $ make -j$(nproc)
> >
> > /usr/bin/ld: /home/
Hannu Krosing writes:
> Yes, this should say average
OK, I tweaked that and increased NUM_DIRECT to 1,
along with a couple of nitpicky code improvements.
regards, tom lane
Hi,
On 2025-07-09 07:26:05 +, Bertrand Drouvot wrote:
> On Tue, Jul 08, 2025 at 10:19:07PM -0400, Andres Freund wrote:
> > On 2025-06-30 13:36:12 +, Bertrand Drouvot wrote:
> > > * we don't want to allocate memory in some places where the counters are
> > > incremented (see 4feba03d8b9).
Hi,
On 2025-07-09 13:26:09 +0200, Matthias van de Meent wrote:
> I've been going through the new AIO code as an effort to rebase and
> adapt Neon to PG18. In doing so, I found the following
> items/curiosities:
>
> 1. In aio/README.md, the following code snippet is found:
>
> [...]
> pgaio_io_se
Hi,
Thank you for the kind comments.
I've updated the previous patch.
Below is a summary of the changes:
1. The code path and documentation have been corrected based on your feedback.
2. The following message is now suppressed by default. Instead, an error message
is added when a client aborts d
Hi hackers,
Currently the `body.attributes` template in
doc/src/sgml/stylesheet-html-common.xsl unconditionally adds
`class="container-fluid col-10"` to every HTML output. Those classes only
make sense when the “website” stylesheet (docs-complete.css, which
includes Bootstrap’s grid) is actually
On Tue, Jul 8, 2025 at 11:06 PM Nathan Bossart wrote:
>
> On Sun, Jul 06, 2025 at 02:48:08PM +0200, Hannu Krosing wrote:
> > Did a quick check of the patch and it seems to work ok.
>
> Thanks for taking a look.
>
> > What do you think of the idea of not dumping pg_shdepend here, but
> > instead ad
Hi Florents,
Thanks for the update!
> here's a v4 patch set
>
> - Extracted pg_base64_{en,de}_internal with an additional bool url param, to
> be used by other functions
> - Added a few more test cases
>
> Cary mentioned above
>
> > In addition, you may also want to add the C versions of base64
On 7/9/25 16:06, Mihail Nikalayeu wrote:
Hello!
No, I think the comment is correct, it is about [0].
[0]:
https://github.com/postgres/postgres/blob/f5a987c0e5f6bbf0cc0420228dc57e7aae4d7e8f/src/backend/commands/indexcmds.c#L4217
Aaahhh... yes, you're right! thanks!
Committed.
--
nathan
Hello!
No, I think the comment is correct, it is about [0].
[0]:
https://github.com/postgres/postgres/blob/f5a987c0e5f6bbf0cc0420228dc57e7aae4d7e8f/src/backend/commands/indexcmds.c#L4217
Hi,
I believe that the description of which transactions will block a CREATE
INDEX CONCURRENTLY command from proceeding isn't right.
Please find the attached patch.
Best regards,
FrédéricFrom cf3ecfda5155584e7c1d81c5daaf04e78d4fddef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=
On Wed, Jul 9, 2025 at 5:39 PM Amit Kapila wrote:
>
> On Tue, Jul 8, 2025 at 12:18 AM Masahiko Sawada wrote:
> >
> > On Mon, Jul 7, 2025 at 12:03 PM Zhijie Hou (Fujitsu)
> > wrote:
> >
> > I think these performance regressions occur because at some point the
> > subscriber can no longer keep up
On Wed, Jul 9, 2025 at 8:30 AM shveta malik wrote:
> >
> > I have split your top up patch into 2 - one related to the document
> > change being the subject of this thread and the other for fixing the
> > query. Committer may squash the patch, if they think so.
> >
>
> The changes look good to me.
On Thu, Jul 3, 2025 at 10:30 PM torikoshia wrote:
>
> On 2025-07-03 11:37, Masahiko Sawada wrote:
> > On Wed, Jul 2, 2025 at 2:46 PM torikoshia
> > wrote:
> >>
> >> On 2025-07-01 14:20, Masahiko Sawada wrote:
> >> > On Thu, Jun 12, 2025 at 3:47 AM Masahiko Sawada
> >> > wrote:
> >> >>
> >> >> On
And yet again after the changes introduced in
93001888d85c21a5b9ab1fe8dabfecb673fc007c by Tom Lane I had to rebase my
patches (see attachments).
An open question on the 2nd patch remains how to properly expose
xml_parse(). That is, if somebody is interested in merging it at all.
You might want to
Dear hackers,
All the tests in [1] are done with autovacuum=off, so I checked how would be in
autovacuum=on case.
Highlights
==
* Regression on subscriber-side became bit larger than autovacuum=on case
when pgbench was run on both side
* Other than that, they were mostly same.
Used sou
1 - 100 of 125 matches
Mail list logo
