I have just realized that this proposal has a rather nasty defect.
Per the following comment in spgist_private.h:
* If the prefix datum is of a pass-by-value type, it is stored in its
* Datum representation, that is its on-disk representation is of length
* sizeof(Datum). This is a fairly unfo
Shinya Kato writes:
> On Fri, Aug 1, 2025 at 2:16 AM Dagfinn Ilmari Mannsåker
> wrote:
>>
>> Dagfinn Ilmari Mannsåker writes:
>>
>> > I just noticed that in addition to ALTER ROLE ... RESET being buggy, the
>> > ALTER DATABASE ... RESET query doesn't schema-qualify the unnest() call.
>> > Here'
Hi,
On 2025-08-07 11:24:18 +0200, Tomas Vondra wrote:
> 2) I'm a bit unsure what "NUMA nodes" actually means. The patch mostly
> assumes each core / piece of RAM is assigned to a particular NUMA node.
There are systems in which some NUMA nodes do *not* contain any CPUs. E.g. if
you attach memory
Hi,
As $subject says, I'd like to introduce stamp files for generated headers. The
immediate motivation is that more than half of build.ninja just consists out
of repetitions of the list of generated headers (listed as order-only
dependencies). That makes invocations of ninja a tad slower and make
Hi,
On 2025-08-06 16:12:53 +0200, Tomas Vondra wrote:
> That's quite possible. What concerns me about using tables like pgbench
> accounts table is reproducibility - initially it's correlated, and then
> it gets "randomized" by the workload. But maybe the exact pattern
> depends on the workload -
Hi,
On 2025-08-07 10:58:56 -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > kwlist_d.h doesn't show up in my run, probably because I'm using a
> > separate build directory, which headerscheck doesn't handle? Another
> > thing to fix.
>
> Yeah, as it stands headerscheck is really only meant
[ resurrecting an old thread ]
I wrote:
> I did discover that plperl works for me after adding --with-openssl
> to the configure options. Not sure if it's worth digging any further
> than that.
FYI, I just observed this exact same behavior (PL/Perl fails with
a panic inside libperl if you build
On Fri, Aug 8, 2025 at 3:25 PM Masahiko Sawada wrote:
> On the other hand, I found a blog post[3] (10 years-old post) that on
> Solaris the output of getentropy() should not be used where randomness
> is needed. I'm not sure it's still true but I guess that it might be
> reasonable to consider tha
Hi,
On 2025-08-08 13:18:39 +0900, Shinya Kato wrote:
> I would like to propose a series of patches that enhance the behavior
> of various statistics reset functions by making them return the reset
> timestamp. This change improves usability and aligns with the behavior
> introduced in commit dc9f8
Hi,
On 2025-08-08 18:28:09 -0400, Andres Freund wrote:
> > From 6574ac9267fe9938f59ed67c8f0282716d8c28f3 Mon Sep 17 00:00:00 2001
> > From: Thomas Munro
> > Date: Sun, 3 Aug 2025 00:15:01 +1200
> > Subject: [PATCH v1 3/4] aio: Support I/O methods without true vectored I/O.
Oh, I forgot (at least
Hi,
On 2025-08-05 23:26:23 +1200, Thomas Munro wrote:
> Up against io_method=worker in simple tests, you can't win sometimes
> because of the help they supply with checksum validation when they run
> completion, and if the data is served straight out of kernel cache
> that might be a bigger factor
On Wed, Jul 30, 2025 at 2:04 PM Jacob Champion
wrote:
>
> On Wed, Jul 30, 2025 at 12:58 PM Peter Eisentraut
> wrote:
> > I imagine a "get entropy" operation could be very slow or even blocking,
> > whereas a random number generator might just have to do some arithmetic
> > starting from the prev
On 26.06.25 17:10, Matheus Alcantara wrote:
On Wed Jun 25, 2025 at 3:07 PM -03, Alexander Pyhalov wrote:
Matheus Alcantara писал(а) 2025-06-25 14:36:
Hi, thanks for testing and reporting the issue!
On 25/06/25 11:37, Alexander Pyhalov wrote:
Hi.
I've started to look at this feature and found
On Thu, Jul 31, 2025 at 4:31 PM SATYANARAYANA NARLAPURAM
wrote:
>
> Please find attached patch that adds CHECK_FOR_INTERRUPTS while scanning the
> buffers in pg_buffercache_pages. I checked other functions in the module and
> this check already exists in pg_buffercache_numa_pages.
Thank you for
Hi Team,
We are currently experiencing prolonged restoration times when restoring a 30GB
PostgreSQL database backup from Mendix Cloud to our local system. The process
is taking approximately 8 hours to complete.
Could you please advise us on how we can optimize or reduce the restoration
time?
On Mon, Jul 14, 2025 at 2:21 PM Tom Lane wrote:
> I got around to looking at this again. I generally agree with your
> approach to the refactoring in clauses.c, with minor nitpicks:
Thanks for taking another look! Revisions attached.
> * I don't like postponing the early exit for its-not-a-SELE
On Fri, Aug 8, 2025 at 2:16 PM Dagfinn Ilmari Mannsåker
wrote:
> That's because encode_json has a prototype[1], which changes how the
> argument list is parsed: no longer just as a flat list of values like a
> normal function. Specifically, it has a prototype of '$', which means
> it only takes o
Hi,
On 2025-07-29 00:21:32 -0700, Lukas Fittl wrote:
> On Mon, Jul 28, 2025 at 10:30 PM Michael Paquier
> wrote:
> > > I'm not sure how to get CI to run MinGW (it appears paused for me?), so I
> > > can't test this myself easily.
> >
> > src/tools/ci/README, "Enabling cirrus-ci in a github reposi
Hi,
On 2025-08-08 15:32:16 -0400, Tom Lane wrote:
> Michael Paquier writes:
> > Attached is a v4, due to conflicts mainly caused by the recent changes
> > in varatt.h done by e035863c9a04.
>
> I found some time to look at the v4 patchset, and have a bunch of
> comments of different sizes.
>
> 0
Jacob Champion writes:
> On Fri, Aug 8, 2025 at 1:07 PM Dagfinn Ilmari Mannsåker
> wrote:
>> $ perl -MJSON::PP=encode_json -E 'say encode_json([1, 2, 3])'
>> [1,2,3]
>>
>> $ perl -MJSON::PP=encode_json -E 'say encode_json([1 => (2, 3)])'
>> [1,2,3]
>
> I swear, this language.
>
>
On 2025-07-28 08:18:01 +0900, Michael Paquier wrote:
> I have used that and applied it down to v18, closing the open item.
Thanks!
On Fri, Aug 8, 2025 at 1:07 PM Dagfinn Ilmari Mannsåker
wrote:
> $ perl -MJSON::PP=encode_json -E 'say encode_json([1, 2, 3])'
> [1,2,3]
>
> $ perl -MJSON::PP=encode_json -E 'say encode_json([1 => (2, 3)])'
> [1,2,3]
I swear, this language.
But:
$ perl -MJSON::PP=encode_json
Andres Freund writes:
> On 2025-07-31 16:02:35 +0200, Peter Eisentraut wrote:
>> diff --git a/contrib/ltree/_ltree_gist.c b/contrib/ltree/_ltree_gist.c
>> index 286ad24fbe8..2d71cea7e5a 100644
>> --- a/contrib/ltree/_ltree_gist.c
>> +++ b/contrib/ltree/_ltree_gist.c
>> @@ -84,7 +84,7 @@ _ltree_com
Hi,
On 2025-07-31 16:02:35 +0200, Peter Eisentraut wrote:
> Another draft patch set that I had lying around that was mentioned in [0].
Nice, thanks for doing that. I tried this a few years back and was scared away
by the churn, but I think it's well worth tackling.
One thing that would be an int
Jacob Champion writes:
> On Thu, Aug 7, 2025 at 9:35 AM Dagfinn Ilmari Mannsåker
> wrote:
>> I haven't read the meat of the patch, but I have some comments on the
>> tests:
>
> Thanks for the review!
>
>> > +IPC::Run::run ['oauth_tests'],
>> > + '>', IPC::Run::new_chunker, sub { print {$out} $_
Hi,
On 2025-08-05 19:20:20 +0200, Peter Eisentraut wrote:
> On 31.07.25 19:17, Tom Lane wrote:
> > Also I see a "// XXX" in pg_get_aios, which I guess is a note
> > to confirm the data type to use for ioh_id?
>
> Yes, the stuff returned from pgaio_io_get_id() should be int, but some code
> uses u
Michael Paquier writes:
> Attached is a v4, due to conflicts mainly caused by the recent changes
> in varatt.h done by e035863c9a04.
I found some time to look at the v4 patchset, and have a bunch of
comments of different sizes.
0001:
I'm good with widening all these values to 64 bits, but I won
>From this discussion, and the fact that the tranche name could come from
either local or shared memory, I think we should have tests.
So, I am working on adding tests using INJECTION_POINTS.
Some of the tests I have in mind now are:
1/ Does the shared memory grow correctly,
2/ Is the tranche nam
Hi,
I am a software engineer with Google's AlloyDB. We recently implemented
more granular spinlock wait event tracking and I wanted to propose it here.
I can create a patch if the community here deems it suitable for
incorporating into postgres. Here is the overall idea:
We categorise the spinlock
... at
https://git.postgresql.org/pg/commitdiff/b70d9de77f337828ca3a0a3064a6827b1ce68977
As usual, please send corrections by Sunday.
regards, tom lane
On Tue, Aug 5, 2025 at 11:54 AM Jacob Champion
wrote:
> Ping. I'll plan to commit this by the beta3 cutoff but it'd be nice to
> verify that I'm not missing something obvious. :D
(Committed yesterday.)
I wonder if there's a Meson feature request in here somewhere, to be
able to compose targets f
On Fri, Aug 8, 2025 at 3:39 AM Thomas Munro wrote:
> LGTM.
Committed!
Thanks,
--Jacob
Hi michael,
I have a question regarding TOAST pointer handling.
As I understand, in the current design, each attribute in a HeapTuple
can have its own TOAST pointer, and TOAST pointers are possible only
for top-level attributes.
Would it make sense to maintain an array for ttc_toast_pointer_size
On 08/08/2025 17:01, Tom Lane wrote:
Heikki Linnakangas writes:
I noticed that there's a similar, existing case in getNotify(), where
libpq just hangs if an allocation fails. To simulate that, apply this
change and use LISTEN/NOTIFY:
--- a/src/interfaces/libpq/fe-protocol3.c
+++ b/src/interf
Heikki Linnakangas writes:
> I noticed that there's a similar, existing case in getNotify(), where
> libpq just hangs if an allocation fails. To simulate that, apply this
> change and use LISTEN/NOTIFY:
> --- a/src/interfaces/libpq/fe-protocol3.c
> +++ b/src/interfaces/libpq/fe-protocol3.c
> @@
Thanks Shveta for coming on this point again and fixing the link.
The idea is to check if the slot has same name to try to resynchronize it
with the primary.
ok the check on the failover status for the remote slot is perhaps
redundant.
I'm not sure what impact setting the synced flag to true might
On Wed, Aug 6, 2025 at 8:48 AM shveta malik wrote:
>
> On Wed, Aug 6, 2025 at 7:35 AM Ajin Cherian wrote:
> >
> > On Tue, Aug 5, 2025 at 4:22 PM Amit Kapila wrote:
> > >
> > > On Tue, Aug 5, 2025 at 9:28 AM shveta malik
> > > wrote:
> > > >
> > > > On Mon, Aug 4, 2025 at 3:41 PM Amit Kapila
On Fri, Aug 8, 2025 at 5:19 PM Ashutosh Bapat
wrote:
>
> On Tue, Aug 5, 2025 at 9:50 AM Amit Kapila wrote:
> >
> > On Fri, Aug 1, 2025 at 5:06 PM Ashutosh Bapat
> > wrote:
> > >
> > > On Fri, Aug 1, 2025 at 4:03 PM Amit Kapila
> > > wrote:
> > > >
> > > > Now, seeing this report, it seems the
On Tue, Aug 5, 2025 at 9:50 AM Amit Kapila wrote:
>
> On Fri, Aug 1, 2025 at 5:06 PM Ashutosh Bapat
> wrote:
> >
> > On Fri, Aug 1, 2025 at 4:03 PM Amit Kapila wrote:
> > >
> > > Now, seeing this report, it seems the customer(s) are probably okay to
> > > skip a missing publication and let repli
On Thu, Aug 7, 2025 at 6:31 PM Kirill Reshke wrote:
>
> Hi hackers!
>
> In the nearby thread[0], enhancements for CREATE TABLE LIKE/REPLICA
> IDENTITY were proposed.
>
> > To me, it makes sense to copy the replica identity definition if
> INCLUDING INDEXES or INCLUDING CONSTRAINTS is given.
>
> I
Hi, Tom!
Thanks for looking at this.
On Fri, Aug 8, 2025 at 2:20 AM Tom Lane wrote:
>
> Xuneng Zhou writes:
> > V9 replaces the original partitioned xid-wait htab with a single,
> > unified one, reflecting the modest entry count and rare contention for
> > waiting. To prevent possible races whe
Hi!
On Fri, 8 Aug 2025 at 08:04, Shinya Kato wrote:
> In addition to SET SCHEMA, I think you should add tab completion for
> SET WITHOUT OIDS.
This is unsupported since v12 [1]
[1]
https://www.postgresql.org/docs/current/sql-altertable.html#SQL-ALTERTABLE-DESC-SET-WITHOUT-OIDS
--
Best regar
On Fri, Aug 8, 2025 at 8:04 AM Jacob Champion
wrote:
> On Thu, Aug 7, 2025 at 11:11 AM Jacob Champion
> wrote:
> > Thank you so much for the reviews!
>
> Here is v4, with the feedback from both of you. 0001-0004 are planned
> for backport; 0005 is slated for master only. Thanks again for the
> re
Hi,
Thank you for looking into this! And sorry for the late reply.
On Fri, 16 May 2025 at 10:58, Xuneng Zhou wrote:
>
> Hey,
>
> I noticed a couple of small clarity issues in the current version of patch
> for potential clean up:
>
> 1. Commit message wording
I changed the commit message. I ma
Hi,
Thank you for looking into this! And sorry for the late reply.
On Mon, 12 May 2025 at 13:24, Amit Kapila wrote:
>
> On Mon, Apr 28, 2025 at 2:43 PM Nazir Bilal Yavuz wrote:
> >
> > Hi,
> >
> > On Fri, 25 Apr 2025 at 19:17, Xuneng Zhou wrote:
> > >
> > >
> > > Would love to hear if this mak
On Friday, August 8, 2025 2:34 PM shveta malik wrote:
>
> On Thu, Aug 7, 2025 at 10:10 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Tuesday, August 5, 2025 10:09 AM Zhijie Hou (Fujitsu)
> wrote:
> > > Here is V57 patch set which addressed most of comments.
> > >
> > > In this version, I also fix
On 07.08.25 03:55, Tom Lane wrote:
I wrote:
I think that on a 32-bit machine this would actually result in a
null-pointer core dump, since the 0.0 would be coerced to a zero
Datum value. The line is not reached in our regression tests,
and given the lack of field complaints, it must be hard to
On Mon, Jul 14, 2025 at 8:00 PM Etsuro Fujita wrote:
> After re-reading the patch I noticed two minor things:
>
> * The existing code in ExecAR* functions already dereferences the
> passed-in ResultRelInfo pointer without checking that it is not NULL.
> The Assert I added to those functions would
On 2025-Aug-08, Jelte Fennema-Nio wrote:
> Thanks to the Claude Code AI tool I was able to get some boring
> cleanup done on the CF app in not that much time. I'll release all of
> it on August 19th.
>
> List of the changes:
> - Update to Bootstrap 5 for more modern visual look and better default
On Mon, Aug 4, 2025 at 11:46 AM Naga Appani wrote:
> > In PG14+, the transaction wraparound is triggered if the size of the
> > directory exceeds 10GB. This function does not help monitoring that
> > condition. So a user will need to use du or pg_ls_multixactdir()
> > anyway, which defeats the pur
Hi,
CFbot indicated that the patch requires a rebase, so I've attached an
updated version.
The documentation for this feature is now included in the new
func-admin.sgml file,
due to recent changes in the documentation of sql functions.
The following are results from a performance test:
pgbench i
On Tue, Jul 15, 2025 at 5:26 PM Etsuro Fujita wrote:
> Yet another thing I noticed about transition tables is $SUBJECT:
>
> create table parent (a text, b int) partition by list (a);
> create table child partition of parent for values in ('AAA');
> create function dump_insert() returns trigger lan
On 08/08/2025 11:49, Jelte Fennema-Nio wrote:
On Fri, 8 Aug 2025 at 10:42, Heikki Linnakangas wrote:
I'm not sure how to best fix that. If we can't process a Notify message
because of out of memory, what should we do?
a) silently drop the Notify messsage.
b) report an error on the next query
c
Indeed, nothing exotic about our replication.
As for the object 4169049057, I am not able to find it anywhere in the
catalogs. Perhaps it was something that was dropped in the meantime.
На чт, 7.08.2025 г. в 2:18 Michael Paquier написа:
> On Mon, Aug 04, 2025 at 01:00:35PM +0300, Kouber Saparev
On Fri, Aug 8, 2025 at 10:01 AM Dilip Kumar wrote:
>
> On Fri, Aug 8, 2025 at 8:58 AM shveta malik wrote:
> >
> > On Thu, Aug 7, 2025 at 3:08 PM Dilip Kumar wrote:
> > >
> > > So logically for PostgreSQL its an
> > > user table but yeah this is created and managed by the extension.
> > >
> >
> >
On Fri, 8 Aug 2025 at 10:42, Heikki Linnakangas wrote:
> I'm not sure how to best fix that. If we can't process a Notify message
> because of out of memory, what should we do?
>
> a) silently drop the Notify messsage.
> b) report an error on the next query
> c) drop the connection with the error.
On 08/08/2025 09:44, Jelte Fennema-Nio wrote:
On Fri, 8 Aug 2025 at 00:03, Heikki Linnakangas wrote:
That was not necessary for handleSyncLoss() to work, or for any other
errors. If an error has occurred, PQgetResult() returns an error result,
which is handled here.
You're right. I think I si
On Fri, Aug 8, 2025 at 5:06 PM Michael Paquier wrote:
>
> On Fri, Aug 08, 2025 at 01:18:39PM +0900, Shinya Kato wrote:
> > The following functions have been modified to return a TIMESTAMP WITH
> > TIME ZONE value indicating when the statistics were reset:
> > - pg_stat_reset()
> > - pg_stat_reset_
On Wednesday, August 6, 2025 7:23 PM vignesh C wrote:
> On Fri, 1 Aug 2025 at 13:33, Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Monday, July 28, 2025 1:07 PM Hayato Kuroda (Fujitsu)
> wrote:
> > >
> > > Dear Shubham,
> > >
> > > > The attached patch introduces a new '--table' option that can be
>
On Fri, Aug 08, 2025 at 01:18:39PM +0900, Shinya Kato wrote:
> The following functions have been modified to return a TIMESTAMP WITH
> TIME ZONE value indicating when the statistics were reset:
> - pg_stat_reset()
> - pg_stat_reset_shared()
> - pg_stat_reset_single_table_counters()
> - pg_stat_rese
On Fri, 8 Aug 2025 at 09:19, Jelte Fennema-Nio wrote:
> I'll release all of it on August 19th.
As always, you can see the changes live here:
https://commitfest-test.postgresql.org/ (username and password are "pgtest")
Feedback is welcome. Especially if you think something looks off or
buttons d
Thanks to the Claude Code AI tool I was able to get some boring
cleanup done on the CF app in not that much time. I'll release all of
it on August 19th.
List of the changes:
- Update to Bootstrap 5 for more modern visual look and better default
contrast of a bunch of UI elements.
- Add a navigatio
Hi, Xuneng Zhou!
On Thu, Aug 7, 2025 at 6:01 PM Xuneng Zhou wrote:
> Thanks for working on this.
>
> I’ve just come across this thread and haven’t had a chance to dig into
> the patch yet, but I’m keen to review it soon.
Great. Thank you for your attention to this patch. I appreciate your
inte
63 matches
Mail list logo
