Re: PG 18 relnotes and RC1

2025-08-30 Thread Jonathan S. Katz
> On Aug 30, 2025, at 5:56 PM, Bruce Momjian wrote: > > On Sat, Aug 30, 2025 at 03:02:10PM -0500, Nathan Bossart wrote: >>> On Sat, Aug 30, 2025 at 02:42:47PM -0500, Nathan Bossart wrote: >>> On Sat, Aug 30, 2025 at 01:51:23PM -0500, Nathan Bossart wrote: AFAIK nobody has started on the "

Re: PG 18 relnotes and RC1

2025-08-30 Thread Nathan Bossart
On Sat, Aug 30, 2025 at 05:56:12PM -0400, Bruce Momjian wrote: > On Sat, Aug 30, 2025 at 03:02:10PM -0500, Nathan Bossart wrote: >> The 18beta1 announcement [0] has a good list, too. *facepalm* That one >> seems to match mine pretty closely. > > Yes, the list usually comes from the press release

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Richard Guo
On Sun, Aug 31, 2025 at 9:50 AM Alexander Korotkov wrote: > On Sun, Aug 31, 2025 at 2:51 AM Richard Guo wrote: > > I think it's better to push this patch sooner rather than later, as > > multiple people have encountered the issue in different ways. I'll go > > ahead and push 0001 from my patch s

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Korotkov
On Sun, Aug 31, 2025 at 2:51 AM Richard Guo wrote: > On Sun, Aug 31, 2025 at 8:41 AM Richard Guo wrote: > > On Sun, Aug 31, 2025 at 8:12 AM Alexander Korotkov > > wrote: > > > The same patch with a bit revised comment and commit message. > > > FWIW, I reported this same issue and proposed the p

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Richard Guo
On Sun, Aug 31, 2025 at 8:41 AM Richard Guo wrote: > On Sun, Aug 31, 2025 at 8:12 AM Alexander Korotkov > wrote: > > The same patch with a bit revised comment and commit message. > FWIW, I reported this same issue and proposed the patch last week in > Discussion: > https://postgr.es/m/CAMbWs48

High CPU consumption in cascade replication with large number of walsenders

2025-08-30 Thread Alexey Makhmutov
Hello hackers, This is a continuation of the thread https://www.postgresql.org/message-id/flat/076eb7bd-52e6-4a51-ba00-c744d027b15c%40postgrespro.ru, with focus only on the patch related to improving performance in case of large number of cascaded walsenders. We’ve faced an interesting situa

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Richard Guo
On Sun, Aug 31, 2025 at 8:12 AM Alexander Korotkov wrote: > > The draft patch fixing this is attached. I will continue the investigation. > > The same patch with a bit revised comment and commit message. FWIW, I reported this same issue and proposed the patch last week in Discussion: https://po

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Korotkov
On Sat, Aug 30, 2025 at 10:29 PM Alexander Korotkov wrote: > On Sat, Aug 30, 2025 at 9:54 PM Alexander Korotkov > wrote: > > On Sat, Aug 30, 2025 at 4:00 PM Alexander Lakhin > > wrote: > > > > > > Hello Alexander, > > > > > > 24.08.2025 03:44, Alexander Korotkov wrote: > > > > > > Thank you fo

Re: PG 18 relnotes and RC1

2025-08-30 Thread Bruce Momjian
On Sat, Aug 30, 2025 at 06:04:16PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Actually, in this case, it caught an obvious missing attribution, so it > > actually helped, so let's not change it. > > Fair enough. I'd still like to put in the bit about > > my $major_version = $1; >

Re: PG 18 relnotes and RC1

2025-08-30 Thread Tom Lane
Bruce Momjian writes: > Actually, in this case, it caught an obvious missing attribution, so it > actually helped, so let's not change it. Fair enough. I'd still like to put in the bit about my $major_version = $1; + die "file name $file is not in the expected format\n" +

Re: PG 18 relnotes and RC1

2025-08-30 Thread Bruce Momjian
On Sat, Aug 30, 2025 at 03:02:10PM -0500, Nathan Bossart wrote: > On Sat, Aug 30, 2025 at 02:42:47PM -0500, Nathan Bossart wrote: > > On Sat, Aug 30, 2025 at 01:51:23PM -0500, Nathan Bossart wrote: > >> AFAIK nobody has started on the "new features and enhancements" section. > > > > Quick first at

Re: PG 18 relnotes and RC1

2025-08-30 Thread Bruce Momjian
On Sat, Aug 30, 2025 at 02:17:15PM -0400, Tom Lane wrote: > I wrote: > > If we're okay with items not having credits, then > > add_commit_links.pl's logic for where to put the s needs > > improvement. I don't really understand why it's looking for > > parens in the first place -- why isn't the rul

Re: PG 18 relnotes and RC1

2025-08-30 Thread Bruce Momjian
On Sat, Aug 30, 2025 at 12:52:45PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Second, the release note item added by this commit: > > commit d1073c3b4cc > > Author: Peter Eisentraut > > Date: Fri Aug 29 10:18:10 2025 +0200 > > > Unfortunately src/tools/add_commit_links.pl c

Re: PG 18 relnotes and RC1

2025-08-30 Thread Nathan Bossart
On Sat, Aug 30, 2025 at 02:42:47PM -0500, Nathan Bossart wrote: > On Sat, Aug 30, 2025 at 01:51:23PM -0500, Nathan Bossart wrote: >> AFAIK nobody has started on the "new features and enhancements" section. > > Quick first attempt: > > * btree skip scan > * async i/o > * oauth > * virtual generate

ecpg test thread/alloc hangs on sidewinder running NetBSD 9.3

2025-08-30 Thread Alexander Lakhin
Hello hackers, I've noticed several timeout failures occurred during this month on sidewinder: [1] [2] [3]. All three hangs happened at test thread/alloc: ... ok 60    - thread/thread  95 ms ok 61    - thread/thread_implicit 89 ms ok 62 

Re: PG 18 relnotes and RC1

2025-08-30 Thread Nathan Bossart
On Sat, Aug 30, 2025 at 01:51:23PM -0500, Nathan Bossart wrote: > AFAIK nobody has started on the "new features and enhancements" section. Quick first attempt: * btree skip scan * async i/o * oauth * virtual generated columns * OLD/NEW support in RETURNING * pg_upgrade improvements (stats, --jobs

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Korotkov
On Sat, Aug 30, 2025 at 9:54 PM Alexander Korotkov wrote: > On Sat, Aug 30, 2025 at 4:00 PM Alexander Lakhin wrote: > > > > Hello Alexander, > > > > 24.08.2025 03:44, Alexander Korotkov wrote: > > > > Thank you for catching this. And thank you for the fix. I think it > > worth separating fix an

Re: PG 18 relnotes and RC1

2025-08-30 Thread Daniel Gustafsson
> On 30 Aug 2025, at 20:51, Nathan Bossart wrote: > On Sat, Aug 30, 2025 at 12:38:06PM -0400, Bruce Momjian wrote: >> First, the release notes are incomplete because the "new features and >> enhancements" and "Acknowledgments" sections are empty. > > Corey Huinker claims to be working on the lis

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Korotkov
On Sat, Aug 30, 2025 at 4:00 PM Alexander Lakhin wrote: > > Hello Alexander, > > 24.08.2025 03:44, Alexander Korotkov wrote: > > Thank you for catching this. And thank you for the fix. I think it > worth separating fix and refactoring. This helps to understand what > exactly the fix is by looki

Re: PG 18 relnotes and RC1

2025-08-30 Thread Nathan Bossart
On Sat, Aug 30, 2025 at 12:38:06PM -0400, Bruce Momjian wrote: > First, the release notes are incomplete because the "new features and > enhancements" and "Acknowledgments" sections are empty. Corey Huinker claims to be working on the list of acknowledgments [0], but I don't see any patches propos

Re: Move block_range_read_stream_cb batchmode comment

2025-08-30 Thread Arseniy Mukhin
On Sat, Aug 30, 2025 at 9:14 PM Andres Freund wrote: > > Hi, > > On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote: > > Currently, each usage of block_range_read_stream_cb is accompanied by > > the same comment about the safety of using batchmode (there are 7 > > identical comments) > > -1 - I th

Re: PG 18 relnotes and RC1

2025-08-30 Thread Tom Lane
I wrote: > If we're okay with items not having credits, then > add_commit_links.pl's logic for where to put the s needs > improvement. I don't really understand why it's looking for > parens in the first place -- why isn't the rule simply "put them > before the first in the item"? I revised the

Re: Move block_range_read_stream_cb batchmode comment

2025-08-30 Thread Andres Freund
Hi, On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote: > Currently, each usage of block_range_read_stream_cb is accompanied by > the same comment about the safety of using batchmode (there are 7 > identical comments) -1 - I think it's better to have the analysis at the point of using the flag an

Re: COPY TO: provide hint when WHERE clause is used

2025-08-30 Thread Jim Jones
Hi On 19.08.25 03:35, torikoshia wrote: > Considering what the user was trying to do, it might be helpful to > provide a similar hint in this case as well. > I’ve attached a patch that adds such a hint. > > What do you think? > +1 I tested the patch and the error message now has the intended HIN

Move block_range_read_stream_cb batchmode comment

2025-08-30 Thread Arseniy Mukhin
Hi, Currently, each usage of block_range_read_stream_cb is accompanied by the same comment about the safety of using batchmode (there are 7 identical comments) /* * It is safe to use batchmode as block_range_read_stream_cb takes no * locks. */ The idea is to write it once near block_range_rea

Re: PG 18 relnotes and RC1

2025-08-30 Thread Tom Lane
Bruce Momjian writes: > Second, the release note item added by this commit: > commit d1073c3b4cc > Author: Peter Eisentraut > Date: Fri Aug 29 10:18:10 2025 +0200 > Unfortunately src/tools/add_commit_links.pl can't process the > and throws an error because the previous line

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-30 Thread Tom Lane
Vik Fearing writes: > On 30/08/2025 13:49, Joel Jacobson wrote: >> This polymorphic function produces an error if the input value is null, >> otherwise it returns the input value unchanged. > This only checks for the null value. I don't think we need to change > the function's name, but we do n

Re: aio/README.md comments

2025-08-30 Thread Andres Freund
Hi, On 2025-08-29 15:23:48 -0700, Jeff Davis wrote: > On Fri, 2025-08-29 at 12:32 -0400, Andres Freund wrote: > > I don't really see an advantage of sync in those cases either. > > It seems a bit early to say that it's just there for debugging. But > it's just in a README, so I won't argue the po

PG 18 relnotes and RC1

2025-08-30 Thread Bruce Momjian
If RC1 is supposed to actually match a release candidate, we have two problems with its release notes. First, the release notes are incomplete because the "new features and enhancements" and "Acknowledgments" sections are empty. Second, the release note item added by this commit: commi

Re: Improve LWLock tranche name visibility across backends

2025-08-30 Thread Sami Imseih
>> I've also attached a rebased patch that addresses all the latest feedback. >> A reworked verison of the test patch is also included, but that's mostly >> intended for CI purposes and is still not intended for commit (yet). > And here's an attempt at fixing the alignment problems revealed by cfb

Re: [PATCH] meson: Update meson to enable building postgres as a subproject

2025-08-30 Thread Andres Freund
Hi, On 2025-08-30 04:18:05 +, Elliot Haisley wrote: > While working on another project which needed libpq, I tried building postgres > as a subproject to consume a recent version of libpq, and noticed it failed. > I've put together a small patch that updates build files to not use > the global

Re: Improve LWLock tranche name visibility across backends

2025-08-30 Thread Nathan Bossart
On Fri, Aug 29, 2025 at 09:51:38PM -0500, Nathan Bossart wrote: > I've also attached a rebased patch that addresses all the latest feedback. > A reworked verison of the test patch is also included, but that's mostly > intended for CI purposes and is still not intended for commit (yet). And here's

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Lakhin
Hello Alexander, 24.08.2025 03:44, Alexander Korotkov wrote: Thank you for catching this. And thank you for the fix. I think it worth separating fix and refactoring. This helps to understand what exactly the fix is by looking at the patch. I also edited commit message. I'm going to push thi

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-30 Thread Vik Fearing
On 30/08/2025 13:49, Joel Jacobson wrote: Dear fellow hackers, This polymorphic function produces an error if the input value is null, otherwise it returns the input value unchanged. This only checks for the null value.  I don't think we need to change the function's name, but we do need t

[PATCH] Add error_on_null() to produce an error if the input is null

2025-08-30 Thread Joel Jacobson
Dear fellow hackers, This polymorphic function produces an error if the input value is null, otherwise it returns the input value unchanged. This need for this function originates from the discussion "Assert single row returning SQL-standard functions" [1]. /Joel [1] https://www.postgresql.org

Re: Assert single row returning SQL-standard functions

2025-08-30 Thread Pavel Stehule
so 30. 8. 2025 v 9:46 odesílatel Joel Jacobson napsal: > On Fri, Aug 29, 2025, at 22:42, David G. Johnston wrote: > > I think the file location is fine but have an idea for where within the > > file to place this: or rather a minor re-working of these so three > > variants that do the same test a

[PATCH] meson: Update meson to enable building postgres as a subproject

2025-08-30 Thread Elliot Haisley
Hello all, While working on another project which needed libpq, I tried building postgres as a subproject to consume a recent version of libpq, and noticed it failed. I've put together a small patch that updates build files to not use the global source root, which allows postgres to be built as a

Re: Assert single row returning SQL-standard functions

2025-08-30 Thread Joel Jacobson
On Fri, Aug 29, 2025, at 22:42, David G. Johnston wrote: > I think the file location is fine but have an idea for where within the > file to place this: or rather a minor re-working of these so three > variants that do the same test aren't spread across the whole page. > ...docs diff... I like t

Re: Conflict detection for update_deleted in logical replication

2025-08-30 Thread Nisha Moond
On Sat, Aug 30, 2025 at 10:17 AM Nisha Moond wrote: > > On Fri, Aug 29, 2025 at 11:49 AM Zhijie Hou (Fujitsu) > wrote: > > > > Here is the new version patch set which also addressed Shveta's comments[1]. > > > > Thanks for the patches here, I tested the v68-001 patch alone, please > find review c