Re: pg_plan_advice

On Mon Nov 24, 2025 at 11:14 AM EST, Robert Haas wrote: > On Sat, Nov 22, 2025 at 7:43 PM Dian Fay wrote: >> Since the policies don't contain any execution boundaries, all the quals >> should be going into a single bucket for planning if I understand the >> process correctly. The bitmap heap scan

Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().

On Sun, Nov 30, 2025 at 3:53 AM Andres Freund wrote: > On 2025-11-28 15:40:19 -0500, Tom Lane wrote: > > =?utf-8?Q?=C3=81lvaro?= Herrera writes: > > > On 2025-Nov-26, Jeff Davis wrote: > > >> Inline pg_ascii_tolower() and pg_ascii_toupper(). > > > > > I think this broke the CI on (some flavors of

Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain

On Thu, Nov 13, 2025 at 11:17 AM Bryan Green wrote: > Corrected master patch and back patch for v16-v18. Thanks. I wondered what system-generated new handles might appear in a child process and potentially collide with a non-inherited handle's numerical value (perhaps a thread handle or somethin

Re: Remaining dependency on setlocale()

On Thu, 2025-11-27 at 09:08 +0800, Chao Li wrote: > > On Nov 26, 2025, at 09:50, Chao Li wrote: > > > > I will review the rest 3 commits tomorrow. > > 10 - 0009 > > Just curious. As isaplha() and toupper() come from the same header > file ctype.h, if we replace toupper with pg_ascii_toupper, do

Re: Remaining dependency on setlocale()

On Wed, 2025-11-26 at 09:50 +0800, Chao Li wrote: > * The retry logic implies that a single-byte char may become multiple > bytes after folding, otherwise retry is not needed because you have > allocated s+1 bytes for dest buffers. From this perspective, we > should use two needed variables: needed

Re: [PoC] XMLCast (SQL/XML X025)

Em sáb., 29 de nov. de 2025 às 09:38, Jim Jones escreveu: > Perhaps listing the data types would make things easier to understand? > Something like: > > * Casting is supported between xml and the built-in character > (character, character varying, or text), numeric, boolean, binary, and > date/ti

Re: Simplify code building the LR conflict messages

I wrote: > So I think this area desperately needs significant editorial > attention, as well as some fundamental rethinking of just what > information we should show. Perhaps using errcontext would help, > but I'm not sure. I think a large part of the problem stems from > trying to cram multiple

Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY

Hi Mihail, Looking at 0004, I think IsIndexCompatibleAsArbiter() should map the attribute numbers, in case the partition has a different column layout than the parent (e.g. in case there are dropped columns or just different column orders) Regards -- Álvaro Herrera 48°01'N 7°57'E

Re: Simplify code building the LR conflict messages

=?utf-8?Q?=C3=81lvaro?= Herrera writes: > So, what we're doing here is to append further row-identifying details > to an errdetail string that already contains some explanation of the > problem. That is, we have something like > DETAIL: The row to be updated was deleted. > and then we add whate

Re: Migrate to autoconf 2.72?

On 28.11.25 09:34, Chao Li wrote: Looks like some efforts have to be made to upgrade to autoconf 2.72 (or another version), which is not a task I have confident to take. So I’m just reporting the problem, hope someone can take care of it. See also here: https://www.postgresql.org/message-id/

Re: Cleanup shadows variable warnings, round 1

On 28.11.25 09:16, Chao Li wrote: Hi Hackers, While reviewing [1], it makes me recall an experience where I had a patch ready locally, but CommitFest CI failed with a shadows-variable warning. Now I understand that -Wall doesn't by default enable -Wshadows with some compilers like clang. I

Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().

Hi, On 2025-11-28 15:40:19 -0500, Tom Lane wrote: > =?utf-8?Q?=C3=81lvaro?= Herrera writes: > > On 2025-Nov-26, Jeff Davis wrote: > >> Inline pg_ascii_tolower() and pg_ascii_toupper(). > > > I think this broke the CI on (some flavors of?) Windows. In > > https://cirrus-ci.com/task/6080935063453

Re: should we have a fast-path planning for OLTP starjoins?

On Fri, Nov 28, 2025 at 6:34 PM Tomas Vondra wrote: > True. I started working on this with two assumptions: (a) we can detect > cases when this is guaranteed to be the optimal join order, and (b) it > would be cheap to do so. Maybe one of those assumptions is not correct. Probably needs testing,

Re: Second RewriteQuery complains about first RewriteQuery in edge case

On Fri, 28 Nov 2025 at 09:21, Bernice Southey wrote: > > This is neat. > Should the test be the rules one? Updatable views are more used, but > your rules example has more coverage. Yes, I think that's probably better. I've tweaked the test to use both rules and updatable views, so that it has to

Re: Second RewriteQuery complains about first RewriteQuery in edge case

On Thu, 27 Nov 2025 at 21:40, Tom Lane wrote: > > Yeah, this looks pretty good. Two nitpicky suggestions: > > * Perhaps using foreach_current_index() would be better than > adding the separate loop variable "i" in RewriteQuery. Ah, good point. I'd forgotten about that macro. > * I think it woul

Re: [PoC] XMLCast (SQL/XML X025)

On 29/11/2025 12:38, Marcos Pegoraro wrote: > Em sex., 28 de nov. de 2025 às 17:07, Jim Jones muenster.de > escreveu: > > Character data type in this sentence means the character types[1] as a > category, not the type character or character varying. >

Re: [PATCH] Add error hints for invalid COPY options

On Fri, Nov 28, 2025 at 2:59 AM Kirill Reshke wrote: > On Wed, 26 Nov 2025 at 11:55, Sugamoto Shinya > wrote: > > > > > > > > 2025年11月25日(火) 6:50 Nathan Bossart : > >> > >> On Mon, Nov 24, 2025 at 11:56:34AM -0800, Masahiko Sawada wrote: > >> > On Sat, Nov 22, 2025 at 8:33 PM Sugamoto Shinya < >

Re: [PoC] XMLCast (SQL/XML X025)

Em sex., 28 de nov. de 2025 às 17:07, Jim Jones escreveu: > Character data type in this sentence means the character types[1] as a > category, not the type character or character varying. > Yes, I understand that, but saying character confuses me a bit. Interval is already part of the date/time

Re: [PATCH] Add `headerscheck` run_target to meson

pt., 28 lis 2025 o 16:17 Nazir Bilal Yavuz napisał(a): > > Hi, > > On Fri, 28 Nov 2025 at 18:05, Nazir Bilal Yavuz wrote: > > > > On Fri, 28 Nov 2025 at 17:03, Miłosz Bieniek > > wrote: > > > > > > pt., 28 lis 2025 o 12:53 Peter Eisentraut > > > napisał(a): > > > > > > > > On 27.11.25 10:28,