Re: HEAD build error on Fedora 39

2024-05-23 Thread Andrew Dunstan
s andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Speed up JSON escape processing with SIMD plus other optimisations

2024-05-23 Thread Andrew Dunstan
! I'd take the win on this rather than wait for some hypothetical patch that changes how output functions work. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: zlib detection in Meson on Windows broken?

2024-05-21 Thread Andrew Dunstan
to the environment LIB and INCLUDE settings before calling `"meson setup". cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

tydedef extraction - back to the future

2024-05-20 Thread Andrew Dunstan
for non-core code such as third party extensions, which isn't entirely difficult (<https://adpgtech.blogspot.com/2015/05/running-pgindent-on-non-core-code-or.html>) but it's not as easy as it should be either. Comments welcome. cheers andrew -- Andrew Dunstan EDB:

Re: zlib detection in Meson on Windows broken?

2024-05-20 Thread Andrew Dunstan
something silly? Hi Dave! Not sure ;-) But this works for the buildfarm animal drongo, so we should be able to make it work for you. I'll contact you offlist and see if I can help. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-18 Thread Andrew Dunstan
On 2024-05-18 Sa 16:54, Yasir wrote: On Sun, May 19, 2024 at 1:45 AM Andrew Dunstan wrote: On 2024-05-18 Sa 15:43, Yasir wrote: On Sat, May 18, 2024 at 7:27 PM Josef Šimánek wrote: pá 17. 5. 2024 v 8:09 odesílatel Yasir napsal: > &

Re: Why is citext/regress failing on hamerkop?

2024-05-18 Thread Andrew Dunstan
On 2024-05-16 Th 17:34, Tom Lane wrote: Andrew Dunstan writes: On 2024-05-16 Th 17:15, Tom Lane wrote: I'd rather have some visible status on the BF dashboard. Invariably, with a problem like this, the animal's owner is unaware there's a problem. If it's just silently not reporting

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-18 Thread Andrew Dunstan
d. eh? git creates .git/info/exclude in every git repository AFAIK. And it's referred to here: <https://git-scm.com/docs/gitignore> cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: First draft of PG 17 release notes

2024-05-18 Thread Andrew Dunstan
On 2024-05-18 Sa 12:50, Bruce Momjian wrote: On Thu, May 16, 2024 at 11:50:20AM -0400, Andrew Dunstan wrote: Maybe "Introduce an incremental JSON parser" would have been a better headline. Well, this gets into a level of detail that is beyond the average reader. I think at

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-18 Thread Andrew Dunstan
local tooling. That way we don't have to maintain ignore lists for all the tools in the world in the PostgreSQL source tree. or if you want something repo-specific, you can add entries to .git/info/exclude cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Why is citext/regress failing on hamerkop?

2024-05-16 Thread Andrew Dunstan
On 2024-05-16 Th 17:15, Tom Lane wrote: Andrew Dunstan writes: On 2024-05-16 Th 16:18, Tom Lane wrote: Andrew: maybe the buildfarm server could be made to flag animals building exceedingly old commits? This is the second problem of this sort that I've noticed this month, and you really

Re: Why is citext/regress failing on hamerkop?

2024-05-16 Thread Andrew Dunstan
andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: First draft of PG 17 release notes

2024-05-16 Thread Andrew Dunstan
On 2024-05-14 Tu 20:39, Bruce Momjian wrote: On Sat, May 11, 2024 at 03:32:55PM -0400, Andrew Dunstan wrote: On 2024-05-09 Th 00:03, Bruce Momjian wrote: I have committed the first draft of the PG 17 release notes; you can see the results here: https://momjian.us/pgsql_docs/release

Re: Why is citext/regress failing on hamerkop?

2024-05-13 Thread Andrew Dunstan
On 2024-05-12 Su 18:05, Thomas Munro wrote: On Mon, May 13, 2024 at 12:26 AM Andrew Dunstan wrote: Well, this is more or less where I came in back in about 2002 :-) I've been trying to help support it ever since, mainly motivated by stubborn persistence than anything else. Still, I agree

Re: Why is citext/regress failing on hamerkop?

2024-05-12 Thread Andrew Dunstan
On 2024-05-12 Su 08:26, Andrew Dunstan wrote: On 2024-05-12 Su 01:34, Tom Lane wrote: BTW, I've also been wondering why hamerkop has been failing isolation-check in the 12 and 13 branches for the last six months or so. It is surely unrelated to this issue, and it looks like it must be due

Re: Why is citext/regress failing on hamerkop?

2024-05-12 Thread Andrew Dunstan
anything else. Still, I agree that the lack of support for the Windows port from Microsoft over the years has been more than disappointing. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: First draft of PG 17 release notes

2024-05-11 Thread Andrew Dunstan
isting API. Maybe "Introduce an incremental JSON parser" would have been a better headline. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: First draft of PG 17 release notes

2024-05-09 Thread Andrew Dunstan
for example drongo on the buildfarm) cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail.

2024-05-07 Thread Andrew Dunstan
CLOBBER_FREED_MEMORY... or if we should ask on the buildfarm-members list if someone wouldn't mind defining it? +1 to have build farm coverage of REALLOCATE_BITMAPSETS. This flag seems quite useful. I have added it to the CPPFLAGS on prion. cheers andrew -- Andrew Dunstan EDB:https

Re: pgsql: psql: add an optional execution-count limit to \watch.

2024-04-27 Thread Andrew Dunstan
that via appropriate environment settings, I guess. Would it be enough to set LANG, or do we need to set the LC_foo settings individually? Not sure how we manage it on Windows. Maybe just not enable it for the first go-round. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: New committers: Melanie Plageman, Richard Guo

2024-04-26 Thread Andrew Dunstan
about both of these. Many congratulations to Melanie and Richard. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-04-24 Thread Andrew Dunstan
. As of ba3e6e2bca97, did you notice that test_json_parser_perf generates two core files because progname is not set, failing an assertion when using the frontend logging? No, it didn't for me. Thanks for noticing, I've pushed a fix. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Why does pgindent's README say to download typedefs.list from the buildfarm?

2024-04-24 Thread Andrew Dunstan
/test/perl/Postgres/Test/AdjustUpgrade.pm). Regarding testing with your patch, some years ago I wrote this blog post: <http://adpgtech.blogspot.com/2015/05/running-pgindent-on-non-core-code-or.html> cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Why does pgindent's README say to download typedefs.list from the buildfarm?

2024-04-24 Thread Andrew Dunstan
On 2024-04-23 Tu 06:23, Alvaro Herrera wrote: But there are others: InjectionPointEntry, ResourceOwnerData, JsonNonTerminal, JsonParserSem, ... The last two are down to me. Let's just get rid of them like the attached (no need for a typedef at all) cheers andrew -- Andrew Dunstan

Re: pgsql: Introduce "builtin" collation provider.

2024-04-23 Thread Andrew Dunstan
On 2024-03-14 Th 02:39, Jeff Davis wrote: Introduce "builtin" collation provider. The new value "b" for pg_collation.collprovider doesn't seem to be documented. Is that deliberate? cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: pgsql: Fix restore of not-null constraints with inheritance

2024-04-18 Thread Andrew Dunstan
/Test/AdjustUpgrade.pm. This is used to adjust the dump files before we diff them. Maybe you can remedy the problem by adding some code in there. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com Cluster.pm Description: Perl program

Re: WIP Incremental JSON Parser

2024-04-18 Thread Andrew Dunstan
On 2024-04-18 Th 02:04, Michael Paquier wrote: On Wed, Apr 10, 2024 at 07:47:38AM -0400, Andrew Dunstan wrote: Here's v2 of the cleanup patch 4, that fixes some more typos kindly pointed out to me by Alexander Lakhin. I can see that this has been applied as of 42fa4b660143 with some extra

Re: HEAD build error on Fedora 39

2024-04-15 Thread Andrew Dunstan
andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Should we add a compiler warning for large stack frames?

2024-04-12 Thread Andrew Dunstan
all to-be-checked files. Yes, I agree. I'll make that happen in the next day or two. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Should we add a compiler warning for large stack frames?

2024-04-11 Thread Andrew Dunstan
andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Typos in the code and README

2024-04-11 Thread Andrew Dunstan
   | 4 ++-- src/test/modules/test_json_parser/test_json_parser_perf.c | 2 +- cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: type in basebackup_incremental.c ?

2024-04-11 Thread Andrew Dunstan
e cleanups I'm intending to push today. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-04-10 Thread Andrew Dunstan
On 2024-04-09 Tu 15:42, Andrew Dunstan wrote: On 2024-04-09 Tu 07:54, Andrew Dunstan wrote: On 2024-04-09 Tu 01:23, Michael Paquier wrote: On Tue, Apr 09, 2024 at 09:48:18AM +0900, Michael Paquier wrote: There is no direct check on test_json_parser_perf.c, either, only a custom rule

Re: WIP Incremental JSON Parser

2024-04-09 Thread Andrew Dunstan
On 2024-04-09 Tu 09:45, Jacob Champion wrote: On Tue, Apr 9, 2024 at 4:54 AM Andrew Dunstan wrote: On 2024-04-09 Tu 01:23, Michael Paquier wrote: There is no direct check on test_json_parser_perf.c, either, only a custom rule in the Makefile without specifying something for meson. So

Re: IPC::Run::time[r|out] vs our TAP tests

2024-04-09 Thread Andrew Dunstan
that you need to delve further, to where timeout/timer objects are created and passed around. I'll take a closer look when I have done some incremental json housekeeping. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: PostgreSQL 17 Release Management Team & Feature Freeze

2024-04-09 Thread Andrew Dunstan
On 2024-04-08 Mo 19:26, Tom Lane wrote: Andrew Dunstan writes: I quite like the triage idea. But I think there's also a case for being more a bit more flexible with those patches we don't throw out. A case close to my heart: I'd have been very sad if the NESTED piece of JSON_TABLE hadn't

Re: WIP Incremental JSON Parser

2024-04-09 Thread Andrew Dunstan
me concerns upthread, as far as I can see. I have posted a patch already that addresses the issue Tom raised. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: PostgreSQL 17 Release Management Team & Feature Freeze

2024-04-08 Thread Andrew Dunstan
it's the thin end of the wedge and rulez is rulez, but this is my view. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-04-08 Thread Andrew Dunstan
On 2024-04-08 Mo 09:29, Andrew Dunstan wrote: On 2024-04-07 Su 20:58, Tom Lane wrote: Coverity complained that this patch leaks memory: /srv/coverity/git/pgsql-git/postgresql/src/bin/pg_combinebackup/load_manifest.c: 212 in load_backup_manifest() 206 bytes_left -= rc; 207

Re: WIP Incremental JSON Parser

2024-04-08 Thread Andrew Dunstan
thing else. It doesn't have to be URLs at all. That happened simply because it was easy to extract from a very large piece of JSON I had lying around, probably from the last time I wrote a JSON parser :-) cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-04-08 Thread Andrew Dunstan
n across the board. Shouldn't there be a "json_parse_manifest_incremental_shutdown()" or the like to deallocate all the storage allocated by the parser? yeah, probably. Will work on it. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Cluster::restart dumping logs when stop fails

2024-04-07 Thread Andrew Dunstan
$!";     } cheers andrew cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: meson vs windows perl

2024-04-05 Thread Andrew Dunstan
On 2024-04-05 Fr 10:12, Andrew Dunstan wrote: On 2024-04-05 Fr 08:25, Andrew Dunstan wrote: Here is an attempt to fix all that. It's ugly, but I think it's more principled. First, instead of getting the ldopts and then trying to filter out the ldflags and ccdlflags, it tells perl

Re: WIP Incremental JSON Parser

2024-04-05 Thread Andrew Dunstan
On 2024-04-05 Fr 11:43, Nathan Bossart wrote: On Fri, Apr 05, 2024 at 10:15:45AM -0400, Andrew Dunstan wrote: On 2024-04-04 Th 15:54, Nathan Bossart wrote: On Thu, Apr 04, 2024 at 03:31:12PM -0400, Andrew Dunstan wrote: Does the attached patch fix it for you? It clears up 2 of the 3

Re: WIP Incremental JSON Parser

2024-04-05 Thread Andrew Dunstan
On 2024-04-04 Th 15:54, Nathan Bossart wrote: On Thu, Apr 04, 2024 at 03:31:12PM -0400, Andrew Dunstan wrote: Does the attached patch fix it for you? It clears up 2 of the 3 warnings for me: ../postgresql/src/common/jsonapi.c: In function ‘IsValidJsonNumber’: ../postgresql/src/common

Re: IPC::Run::time[r|out] vs our TAP tests

2024-04-05 Thread Andrew Dunstan
n an eval block and testing for the is_expired setting in an exception block. The other cases look more suspect. I'll take a closer look. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: meson vs windows perl

2024-04-05 Thread Andrew Dunstan
On 2024-04-05 Fr 08:25, Andrew Dunstan wrote: Here is an attempt to fix all that. It's ugly, but I think it's more principled. First, instead of getting the ldopts and then trying to filter out the ldflags and ccdlflags, it tells perl not to include those in the first place

Re: meson vs windows perl

2024-04-05 Thread Andrew Dunstan
On 2024-04-02 Tu 09:34, Andrew Dunstan wrote: meson.build has this code     ldopts = run_command(perl, '-MExtUtils::Embed', '-e', 'ldopts', check: true).stdout().strip()     undesired = run_command(perl_conf_cmd, 'ccdlflags', check: true).stdout().split()     undesired

Re: WIP Incremental JSON Parser

2024-04-04 Thread Andrew Dunstan
302 | return (!numeric_error) && (total_len == dummy_lex.input_length); | ~^~~~ Please pile on. I want to get this fixed. It seems odd that my much later gcc didn't complain. Does the attached patch fix it for you? cheer

Re: WIP Incremental JSON Parser

2024-04-04 Thread Andrew Dunstan
d" to track) So we're short several .gitignore entries, and apparently also shy a couple of make-clean rules. Argh. You get out of the habit when you're running with meson :-( There's another issue I'm running down too. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-04-04 Thread Andrew Dunstan
that the typedef appears in thus-and-such header file; see examples in our tree.) Done cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-04-04 Thread Andrew Dunstan
On 2024-04-04 Th 10:26, Tom Lane wrote: Andrew Dunstan writes: pushed. My animals don't like this [1][2]: parse_manifest.c:99:3: error: redefinition of typedef 'JsonManifestParseIncrementalState' is a C11 feature [-Werror,-Wtypedef-redefinition] } JsonManifestParseIncrementalState

Re: WIP Incremental JSON Parser

2024-04-04 Thread Andrew Dunstan
On 2024-04-02 Tu 17:12, Andrew Dunstan wrote: On 2024-04-02 Tu 15:38, Jacob Champion wrote: On Mon, Apr 1, 2024 at 4:53 PM Andrew Dunstan wrote: Anyway, here are new patches. I've rolled the new semantic test into the first patch. Looks good! I've marked RfC. Thanks! I appreciate all

Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?

2024-04-03 Thread Andrew Dunstan
-- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Extension for PostgreSQL cast jsonb to hstore WIP

2024-04-02 Thread Andrew Dunstan
errors. But the above is only a tiny fraction of those. If the error cases are going to be so much more than the cases that work it seems a bit pointless. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-04-02 Thread Andrew Dunstan
On 2024-04-02 Tu 15:38, Jacob Champion wrote: On Mon, Apr 1, 2024 at 4:53 PM Andrew Dunstan wrote: Anyway, here are new patches. I've rolled the new semantic test into the first patch. Looks good! I've marked RfC. Thanks! I appreciate all the work you've done on this. I will give it one

meson vs windows perl

2024-04-02 Thread Andrew Dunstan
: Command line warning D9024 : unrecognized source file type 'Visual', object file assumed cl : Command line warning D9024 : unrecognized source file type 'C:\Program', object file assumed cl : Command line warning D9024 : unrecognized source file type 'Files', object file assumed cl : Command line warning D9024 : unrecognized source file type '(x86)\Windows', object file assumed It looks like we need to get smarter about how we process the ldopts and strip out the ccdlflags and ldflags cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Extension for PostgreSQL cast jsonb to hstore WIP

2024-04-02 Thread Andrew Dunstan
always an object / hash. Thus it's easy to reliably cast hstore to json but far less easy to cast json to hstore in the general case. What do you propose to do in the case or json consisting of scalars, or arrays, or with nested elements? cheers andrew -- Andrew Dunstan EDB:

Re: Security lessons from liblzma

2024-04-01 Thread Andrew Dunstan
-- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Broken error detection in genbki.pl

2024-04-01 Thread Andrew Dunstan
buy back a little bit of the cost compared to this quick hack. Thoughts? regards, tom lane [1] https://www.postgresql.org/message-id/60EF4E11-BC1C-4034-B37B-695662D28AD2%40justatheory.com Makes sense cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-03-29 Thread Andrew Dunstan
ehensive set of JSON errors. I'll play with that. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Possibility to disable `ALTER SYSTEM`

2024-03-26 Thread Andrew Dunstan
> On Mar 27, 2024, at 3:53 AM, Tom Lane wrote: > > Bruce Momjian writes: >> I am thinking "enable_alter_system_command" is probably good because we >> already use "enable" so why not reuse that idea, and I think "command" >> is needed because we need to clarify we are talking about the

Re: WIP Incremental JSON Parser

2024-03-25 Thread Andrew Dunstan
On Mon, Mar 25, 2024 at 7:12 PM Jacob Champion < jacob.champ...@enterprisedb.com> wrote: > On Mon, Mar 25, 2024 at 4:02 PM Andrew Dunstan > wrote: > > Well, what's the alternative? The current parser doesn't check stack > depth in frontend code. Presumably it too will ev

Re: session username in default psql prompt?

2024-03-25 Thread Andrew Dunstan
On Mon, Mar 25, 2024 at 9:14 AM Jelte Fennema-Nio wrote: > On Mon, 25 Mar 2024 at 14:06, Robert Haas wrote: > > On Mon, Mar 25, 2024 at 4:30 AM Jelte Fennema-Nio > wrote: > > > That problem seems easy to address by adding a newline into the > > > default prompt. > > > > Ugh. Please, no! > > I

Re: WIP Incremental JSON Parser

2024-03-25 Thread Andrew Dunstan
On Mon, Mar 25, 2024 at 6:15 PM Jacob Champion < jacob.champ...@enterprisedb.com> wrote: > On Wed, Mar 20, 2024 at 11:56 PM Andrew Dunstan > wrote: > > Thanks, included that and attended to the other issues we discussed. I > think this is pretty close now. > > Ok

Re: pg_dump versus enum types, round N+1

2024-03-23 Thread Andrew Dunstan
On Sat, Mar 23, 2024 at 3:00 PM Tom Lane wrote: > I have a patch in the queue [1] that among other things tries to > reduce the number of XIDs consumed during pg_upgrade by making > pg_restore group its commands into batches of a thousand or so > per transaction. This had been passing tests, so

Re: session username in default psql prompt?

2024-03-22 Thread Andrew Dunstan
On Fri, Mar 22, 2024 at 7:34 PM Tom Lane wrote: > > On the whole, I think we'd get more complaints about the default > prompt having more-or-less doubled in length than we'd get kudos > about this being a great usability improvement. Prompt space is > expensive and precious, at least for people

Re: session username in default psql prompt?

2024-03-22 Thread Andrew Dunstan
On Fri, Mar 22, 2024 at 4:04 PM Robert Haas wrote: > On Wed, Mar 13, 2024 at 4:56 AM Andrew Dunstan > wrote: > > Reposting as the archive mail processor doesn't seem to like the Apple > > mail attachment. > > I'm not really a fan of this. Right now my prompt looks li

Re: automating RangeTblEntry node support

2024-03-21 Thread Andrew Dunstan
On Mon, Mar 11, 2024 at 5:29 AM Peter Eisentraut wrote: > On 20.02.24 08:57, Peter Eisentraut wrote: > > On 18.02.24 00:06, Matthias van de Meent wrote: > >> I'm not sure that the cleanup which is done when changing a RTE's > >> rtekind is also complete enough for this purpose. > >> Things like

Re: Trying to build x86 version on windows using meson

2024-03-20 Thread Andrew Dunstan
On Wed, Mar 20, 2024 at 6:21 PM Andres Freund wrote: > Hi, > > On 2024-03-21 11:02:27 +1300, David Rowley wrote: > > On Thu, 21 Mar 2024 at 11:00, Andres Freund wrote: > > > > > > On 2024-03-20 17:49:14 -0400, Dave Cramer wrote: > > > > First off this is on an ARM64 machine > > > > > > Uh,

Re: WIP Incremental JSON Parser

2024-03-20 Thread Andrew Dunstan
On Tue, Mar 19, 2024 at 6:07 PM Andrew Dunstan wrote: > > > > > It also removes the frontend exits I had. In the case of stack depth, we > follow the example of the RD parser and only check stack depth for backend > code. In the case of the check that the lexer is s

Re: Possibility to disable `ALTER SYSTEM`

2024-03-19 Thread Andrew Dunstan
On Tue, Mar 19, 2024 at 2:28 PM Magnus Hagander wrote: > On Tue, Mar 19, 2024 at 3:52 PM Tom Lane wrote: > > > > Heikki Linnakangas writes: > > > Perhaps we could make that even better with a GUC though. I propose a > > > GUC called 'configuration_managed_externally = true / false". If you >

Re: documentation structure

2024-03-19 Thread Andrew Dunstan
On Mon, Mar 18, 2024 at 10:12 AM Robert Haas wrote: > I was looking at the documentation index this morning[1], and I can't > help feeling like there are some parts of it that are over-emphasized > and some parts that are under-emphasized. I'm not sure what we can do > about this exactly, but I

Re: Possibility to disable `ALTER SYSTEM`

2024-03-19 Thread Andrew Dunstan
On Tue, Mar 19, 2024 at 5:26 AM Heikki Linnakangas wrote: > I want to remind everyone of this from Gabriele's first message that > started this thread: > > > At the moment, a possible workaround is that `ALTER SYSTEM` can be > blocked > > by making the postgresql.auto.conf read only, but the

Re: What about Perl autodie?

2024-03-18 Thread Andrew Dunstan
On Mon, Mar 18, 2024 at 2:28 AM Peter Eisentraut wrote: > On 21.02.24 08:26, Peter Eisentraut wrote: > > On 14.02.24 17:52, Peter Eisentraut wrote: > >> A gentler way might be to start using some perlcritic policies like > >> InputOutput::RequireCheckedOpen or the more general > >>

Re: Support json_errdetail in FRONTEND builds

2024-03-15 Thread Andrew Dunstan
> On Mar 16, 2024, at 8:53 AM, Daniel Gustafsson wrote: > >  >> >> On 15 Mar 2024, at 21:56, Andrew Dunstan wrote: >> On Fri, Mar 15, 2024 at 10:15 AM Tom Lane > <mailto:t...@sss.pgh.pa.us>> wrote: >> Daniel Gustafsson mailto:dan...@yesql.se&g

Re: Support json_errdetail in FRONTEND builds

2024-03-15 Thread Andrew Dunstan
On Fri, Mar 15, 2024 at 10:15 AM Tom Lane wrote: > Daniel Gustafsson writes: > > I can't see how refusing to free memory owned and controlled by someone > else, > > and throwing an error if attempted, wouldn't be a sound defensive > programming > > measure. > > I think the argument is about

Re: session username in default psql prompt?

2024-03-13 Thread Andrew Dunstan
On 2024-02-27 Tu 19:19, Kori Lane wrote: Here’s a patch for this. Reposting as the archive mail processor doesn't seem to like the Apple mail attachment. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref

Re: meson vs tarballs

2024-03-13 Thread Andrew Dunstan
On 2024-03-13 We 02:31, Andrew Dunstan wrote: On 2024-03-13 We 02:22, Peter Eisentraut wrote: On 13.03.24 07:11, Andrew Dunstan wrote: I and several colleagues have just been trying to build from a tarball with meson. That seems pretty awful and unfriendly and I didn't see anything about

Re: meson vs tarballs

2024-03-13 Thread Andrew Dunstan
On 2024-03-13 We 02:22, Peter Eisentraut wrote: On 13.03.24 07:11, Andrew Dunstan wrote: I and several colleagues have just been trying to build from a tarball with meson. That seems pretty awful and unfriendly and I didn't see anything about it in the docs. At https://www.postgresql.org

meson vs tarballs

2024-03-13 Thread Andrew Dunstan
it in the docs. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: perl: unsafe empty pattern behavior

2024-03-12 Thread Andrew Dunstan
I'll have a go, but it might take a while. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Support json_errdetail in FRONTEND builds

2024-03-12 Thread Andrew Dunstan
the program will just exit anyway. 2. the fix is simple where it's needed. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: [PROPOSAL] Skip test citext_utf8 on Windows

2024-03-12 Thread Andrew Dunstan
On 2024-03-11 Mo 22:50, Thomas Munro wrote: On Tue, Mar 12, 2024 at 2:56 PM Andrew Dunstan wrote: On 2024-03-11 Mo 04:21, Oleg Tselebrovskiy wrote: Greetings, everyone! While running "installchecks" on databases with UTF-8 encoding the test citext_utf8 fails because of Turkis

Re: [PROPOSAL] Skip test citext_utf8 on Windows

2024-03-11 Thread Andrew Dunstan
er ---  İ (1 row) Which I find strange since lower() uses collation that was passed (default in this case but still) Wouldn't we be better off finding a Windows fix for this, instead of sweeping it under the rug? cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-03-07 Thread Andrew Dunstan
helpful when a test fails spuriously due to code coverage spray on stderr. Makes sense, thanks. I'll have a fresh patch set soon which will also take care of the bitrot. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: speed up a logical replica setup

2024-02-28 Thread Andrew Dunstan
%3Dfilename [2]: ``` The target server must be shut down cleanly before running pg_rewind ``` Even though that is a difference I'd still rather we did more or less the same thing more or less the same way across utilities, so I agree with Euler's suggestion. cheers andrew -- Andrew Dunstan EDB

Re: [PoC] Federated Authn/z with OAUTHBEARER

2024-02-28 Thread Andrew Dunstan
details about what this python gadget would buy us? I note that there are a couple of CPAN modules that provide OAuth2 servers, not sure if they would be of any use. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Logging parallel worker draught

2024-02-27 Thread Andrew Dunstan
k "1066 And All That": "For 'pheasant' read 'peasant' throughout." cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: More new SQL/JSON item methods

2024-02-26 Thread Andrew Dunstan
well, which currently has the following form: > > "string argument of jsonpath item method .%s() is not a valid > representation.." Agreed. Attached are patches based on the discussion. Thanks, I combined these and pushed the result. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-02-26 Thread Andrew Dunstan
On 2024-02-26 Mo 19:20, Andrew Dunstan wrote: On 2024-02-26 Mo 10:10, Jacob Champion wrote: On Mon, Feb 26, 2024 at 7:08 AM Jacob Champion wrote: As a brute force example of the latter, with the attached diff I get test failures at chunk sizes 1, 2, 3, 4, 6, and 12. But this time

Re: WIP Incremental JSON Parser

2024-02-26 Thread Andrew Dunstan
! cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Can we include capturing logs of pgdata/pg_upgrade_output.d/*/log in buildfarm

2024-02-25 Thread Andrew Dunstan
e does nothing. More generally, the collection of logs etc. for pg_upgrade will improve with the next release, which will be soon after I return from a vacation in about 2 weeks - experience shows that making releases just before a vacation is not a good idea :-) cheers andrew -- Andrew D

Re: WIP Incremental JSON Parser

2024-02-22 Thread Andrew Dunstan
On 2024-02-22 Th 15:29, Jacob Champion wrote: On Thu, Feb 22, 2024 at 1:38 AM Andrew Dunstan wrote: Patch 5 in this series fixes those issues and adjusts most of the tests to add some trailing junk to the pieces of json, so we can be sure that this is done right. This fixes the test failure

Re: WIP Incremental JSON Parser

2024-02-20 Thread Andrew Dunstan
On 2024-02-20 Tu 19:53, Jacob Champion wrote: On Tue, Feb 20, 2024 at 2:10 PM Andrew Dunstan wrote: Well, that didn't help a lot, but meanwhile the CFBot seems to have decided in the last few days that it's now happy, so full steam aead! ;-) I haven't been able to track down the root cause

Re: WIP Incremental JSON Parser

2024-02-19 Thread Andrew Dunstan
On 2024-01-26 Fr 12:15, Andrew Dunstan wrote: On 2024-01-24 We 13:08, Robert Haas wrote: Maybe you should adjust your patch to dump the manifests into the log file with note(). Then when cfbot runs on it you can see exactly what the raw file looks like. Although I wonder if it's possible

Re: What about Perl autodie?

2024-02-18 Thread Andrew Dunstan
checking at the sites it points out.  And then if we start using autodie in the future, any inappropriate backpatching of calls lacking error checks would be caught. Yeah, that should work. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Andrew Dunstan
On 2024-02-12 Mo 11:44, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Mon, 12 Feb 2024 at 09:19, Andrew Dunstan wrote: On 2024-02-12 Mo 08:51, Dave Cramer wrote: On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: On 2024-02-10 Sa 12:20, Dave Cramer wrote

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Andrew Dunstan
On 2024-02-12 Mo 08:51, Dave Cramer wrote: On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: On 2024-02-10 Sa 12:20, Dave Cramer wrote: On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: On 2024-02-09 Fr 14:23, Dave Cramer wrote: Dave Cramer

Re: Feature request support MS Entra ID Authentication from On-premises PostreSQL server

2024-02-11 Thread Andrew Dunstan
. What is the difference between this and ActiveDirectory? AD is already usable as an authentication mechanism. See for example <https://www.crunchydata.com/blog/windows-active-directory-postgresql-gssapi-kerberos-authentication> cheers andrew -- Andrew Dunstan EDB

  1   2   3   4   5   6   7   8   9   10   >