d we do something more like GUC_check_errdetail() instead to maintain
> backward compatibility with v16?
We'd still need something exported to call into which isn't in 16, so it
wouldn't be more than optically backwards compatible since a module written for
17 won't compile for 16, or am I missing something?
--
Daniel Gustafsson
> On 24 Sep 2023, at 10:22, Kuwamura Masaki
> wrote:
>
> LGTM too!
I've applied this down to v16 now, thanks for the submission!
--
Daniel Gustafsson
is a psql problem, it's exacerbated by a slow login EVT and it breaks
what I would guess is the mental model of many who press ^C in a stalled login.
At the very least we should probably document the risk?
--
Daniel Gustafsson
> On 25 Sep 2023, at 09:52, Daniel Gustafsson wrote:
>
>> On 25 Sep 2023, at 09:50, Michael Paquier wrote:
>>
>> On Mon, Sep 25, 2023 at 09:19:35AM +0200, Daniel Gustafsson wrote:
>>> Fair enough, although I used "fire" instead of "run"
depends on another earlier change.
--
Daniel Gustafsson
> On 4 Jul 2023, at 14:50, Daniel Gustafsson wrote:
>
>> On 4 Jul 2023, at 13:59, Heikki Linnakangas wrote:
>> On 08/03/2023 00:05, Daniel Gustafsson wrote:
>
>>> If we are going to continue using this for reading $stuff from pipes, maybe
>>> we
>&g
> On 25 Sep 2023, at 09:50, Michael Paquier wrote:
>
> On Mon, Sep 25, 2023 at 09:19:35AM +0200, Daniel Gustafsson wrote:
>> Fair enough, although I used "fire" instead of "run" which is consistent with
>> the event trigger documentation.
>
&
ore stable, if the Makefile is ever restructured it's almost
guaranteed that this comment will be missed with the location info becoming
stale.
--
Daniel Gustafsson
e is in a
single commit with a commit message which describes the motivation for the
change. A reviewer can second-guess the rationale for the changes, but they
shouldn't have to.
The resulting patchset can all be in the same thread though.
--
Daniel Gustafsson
> On 25 Sep 2023, at 01:35, Michael Paquier wrote:
>
> On Fri, Sep 22, 2023 at 05:29:01PM +0200, Daniel Gustafsson wrote:
>> Since the main driver for this is to reduce the usage/need for single-user
>> mode
>> I also reworded the patch slightly. Instead of phrasing
> On 25 Sep 2023, at 08:58, Michael Paquier wrote:
> I would say yes, but with a backpatch.
Agreed.
--
Daniel Gustafsson
That makes sense, we already point to other related files on that page so this
is line with that.
--
Daniel Gustafsson
n driver for this is to reduce the usage/need for single-user mode
I also reworded the patch slightly. Instead of phrasing this as an alternative
to single-user mode, I reversed it such that single-user mode is an alternative
to this GUC.
--
Daniel Gustafsson
v9-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch
Description: Binary data
ler,
as well as removed the (in some cases) superfluous space in the generated SQL
query mentioned upthread. The attached two patches is what I propose we commit
to fix this, with a backpatch to v16 where it was introduced.
--
Daniel Gustafsson
v3-0002-vacuumdb-Reword-help-message-for-clarity
wanted to point it out.
Revisiting an old patch. Agreed, I think that's fine, so I went ahead and
pushed this. Thanks for review!
It's unfortunately not that common for buildfarm animals to run the SSL tests,
so I guess I'll keep an extra eye on the CFBot for this one.
--
Daniel Gustafsson
> On 20 Sep 2023, at 10:58, Daniel Gustafsson wrote:
>> On 20 Sep 2023, at 10:55, Sergey Shinderuk
>> wrote:
>> There is a typo: upon en error. Otherwise, looks good to me. Thank you.
>
> Thanks, will fix before pushing.
I've applied this down to v15 now and the
> On 18 Sep 2023, at 14:11, Daniel Gustafsson wrote:
> Unless something sticks out in a second pass over it I will go ahead and apply
> it.
And applied, closing the CF entry.
--
Daniel Gustafsson
nk the odds of introducing a bug we can't fix later
> outweigh any arguable portability gain.
Agreed.
--
Daniel Gustafsson
ke a transient infrastructure error and not something related to
your patch, it will most likely go away for the next run.
--
Daniel Gustafsson
wamura.html>
> I'm sorry, I didn't know that. I attached both the test and fix patch to this
> mail.
No worries at all. If you look at the page now you will see all green
checkmarks indicating that the patch was tested in CI. So now we know that
your tests fail without the fix and work
has any.
I think this paragraph needs to be updated to include how the returned
logdetail is emitted, since it currently shows the WARNING without mentioning
the added detail in case returned. It would also be good to mention that it
should be an allocated string which the caller can free.
--
Da
tible-pointer-types]
{"force", no_argument, , 1},
^~
1 warning generated.
--
Daniel Gustafsson
since without the fix the tests *should* fail), since the fix patch was
not applied:
http://cfbot.cputube.org/masaki-kuwamura.html
--
Daniel Gustafsson
> On 20 Sep 2023, at 10:55, Sergey Shinderuk wrote:
>
> On 20.09.2023 11:42, Daniel Gustafsson wrote:
>> Attached is a v2 on top of HEAD with commit message etc, which I propose to
>> backpatch to v15 where it was introduced.
> There is a typo: upon en error. Otherwise,
code it's clear that it does, so checking for -1 is safe for all supported
OpenSSL versions (supported by us that is).
Attached is a v2 on top of HEAD with commit message etc, which I propose to
backpatch to v15 where it was introduced.
--
Daniel Gustafsson
v2-0001-Avoid-potential-pfre
> On 13 Sep 2023, at 01:49, Andres Freund wrote:
> On 2023-08-30 10:57:10 +0200, Daniel Gustafsson wrote:
>>> On 28 Aug 2023, at 14:32, Daniel Gustafsson wrote:
>>
>>> Attached is a patch with a quick PoC for using PQPing instead of using psql
>>>
ic
one with build information detailed in the README. Having such a cert could
for sure be interesting for testing.
Awaiting resolution on this, I propose we go ahead with the original patch from
this thread. Any objections to that?
--
Daniel Gustafsson
ething sticks out in a second pass over it I will go ahead and apply
it.
--
Daniel Gustafsson
> On 18 Sep 2023, at 13:09, Heikki Linnakangas wrote:
> I propose the attached patch to reword the sentence a little more.
LGTM, +1
--
Daniel Gustafsson
> On 14 Sep 2023, at 11:30, Daniel Gustafsson wrote:
>
>> On 14 Sep 2023, at 08:28, Krishnakumar R wrote:
>
>> Please find a small patch to improve code readability by modifying
>> variable name to reflect the logic involved - finding diff between end
&g
easily).
Fair point, I agree with your reasoning that errdetail seems more appropriate.
--
Daniel Gustafsson
> On 12 Sep 2023, at 21:40, Jacob Champion wrote:
>
> Hello,
>
> On 7/25/23 07:21, Daniel Gustafsson wrote:
>> The attached version passes ssl tests for me on 1.0.2 through OpenSSL Git
>> HEAD.
>
> Tests pass for me too, including LibreSSL 3.8.
Thanks
> On 15 Sep 2023, at 12:49, Alvaro Herrera wrote:
>
> On 2023-Sep-15, Daniel Gustafsson wrote:
>
>> -basic_archive_configured(ArchiveModuleState *state)
>> +basic_archive_configured(ArchiveModuleState *state, const char **errmsg)
>>
>> The variable name
tence of any patents on any
code before studying it though. The most recent attempt to make a column-store
for PostgreSQL was, IIRC, zedstore. The zedstore thread might give some
insights:
https://postgr.es/m/calfoeiuf-m5jg51mjupm5gn8u396o5sa2af5n97vtraedya...@mail.gmail.com
--
Daniel Gustafsson
le name errmsg implies that it will contain the errmsg() data when it
in fact is used for errhint() data, so it should be named accordingly.
It's probably better to define the interface as ArchiveCheckConfiguredCB
functions returning an allocated string in the passed pointer which the caller
is responsible for freeing.
--
Daniel Gustafsson
be useful for other things as well...
Wouldn't having system wide EVTs be a generic solution which could be the
infrastructure for this requested change as well as others in the same area?
--
Daniel Gustafsson
than contorting the C code to produce less
whitespace in a query few will read in its generated form.
--
Daniel Gustafsson
tables not in the specified schema.
Maybe, but the point of vacuumdb is to analyze a database so I'm not sure who
would expect anything else than vacuuming everything but the excluded schema
when specifying -N. What else could "vacuumdb -N foo" be interpreted to do
that can be confusing?
--
Daniel Gustafsson
age.
If it's experimental it should probably be behind an opt-in flag in
autoconf/meson, or be reverted by the time REL_17_STABLE branches unless
coverage has materialized by then.
--
Daniel Gustafsson
me, duration, start);
+ INSTR_TIME_SET_CURRENT(end);
+ INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_sync_time, end, start);
Agreed, the duration is the result of the INSTR_TIME_ACCUM_DIFF calculation,
not what's stored in the instr_time variable.
--
Daniel Gustafsson
> On 14 Sep 2023, at 09:56, Michael Paquier wrote:
> (I'm OK with your patch as well, FWIW.)
Thanks for looking, pushed.
--
Daniel Gustafsson
slow
systems, but it's not probably not all that important really. Removed such
that "ok" aligns.
> Also, you should put gettext_noop() calls into the .status = "Checking ..."
> assignments and arrange to call gettext() where they are used, to maintain
> the translatabi
t; simple patch that removes Unique node from the plan.
Is this query pattern common enough to warrant spending time on in the planner
(are there perhaps ORMs that generate such)? Have you measured the overhead of
this?
--
Daniel Gustafsson
> On 13 Sep 2023, at 13:55, Peter Eisentraut wrote:
>
> On 13.09.23 13:48, Daniel Gustafsson wrote:
>> Looking at zqfugous5du4d...@paquier.xyz I noticed that we had a a few
>> instances
>> of filenames in userfacing log messages (ie not elog or DEBUGx etc) not bein
ss all log messages?
--
Daniel Gustafsson
quote_file_errmsg.diff
Description: Binary data
ntext about what's being read, so using this generic error
> message is fine. Will apply if there are no objections.
+1. This errmsg is already present so it eases the translation burden as well.
--
Daniel Gustafsson
f those source files change, or their
>> scripts, it would be helpful to build docs.
>
> Thanks! Are these the only files that are not in the doc subfolders
> but effect docs?
I believe so, the list of scripts and input files can be teased out of the
doc/src/sgml/meson.build file.
--
Daniel Gustafsson
> On 5 Sep 2023, at 16:37, Daniel Gustafsson wrote:
> I've gone over this version of the patch and I think it's ready to go in. I'm
> marking this Ready for Committer and will go ahead with it shortly barring any
> objections.
Pushed, after another round of review with some
> On 7 Sep 2023, at 13:24, Daniel Gustafsson wrote:
>
>> On 7 Sep 2023, at 13:09, Nazir Bilal Yavuz wrote:
>
>> With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking'
>> as default because it is resource intensive; but regress docs doesn't
>
cs based on files in src/, like src/backend/catalog/sql_features.txt
and src/include/parser/kwlist.h. If those source files change, or their
scripts, it would be helpful to build docs.
--
Daniel Gustafsson
eturn value. Did you get a compiler warning on unchecked return, and if so
with which flags?
--
Daniel Gustafsson
ially given its LTS status (which OpenSSL hasn't even
capped but sells by "for as long as it remains commercially viable to do so"
basis). That being said, my gut feeling is that 3.x has gotten pretty good
market penetration.
--
Daniel Gustafsson
. So, I created a patch for updating the docs.
Agreed, the current wording lacks the mention of skipping tests due to high
resource usage. Patch looks good from a quick skim, I'll backpatch it down to
15 which is where PG_TEST_EXTRA was first used in this capacity.
--
Daniel Gustafsson
k it makes sense to invent a new PG_TEST_EXTRA category which (for now)
only contains wal_consistency_checking to make it consistent, such that "all"
can be achieved by a set of categories.
--
Daniel Gustafsson
ut that hack.
--
Daniel Gustafsson
s attached patch?
Reads good to me, +1.
--
Daniel Gustafsson
> On 6 Sep 2023, at 16:22, Robert Haas wrote:
> On Wed, Sep 6, 2023 at 4:50 AM Daniel Gustafsson wrote:
>> Fair enough, how about disable_event_trigger instead as per the attached?
>
> I usually prefer to give things a positive sense, talking about
> whether things ar
)
Planning Time: 1.639 ms
Execution Time: 0.215 ms
(3 rows)
EXPLAIN
postgres=#
--
Daniel Gustafsson
> On 5 Sep 2023, at 17:29, Robert Haas wrote:
> On Tue, Sep 5, 2023 at 8:12 AM Daniel Gustafsson wrote:
>> The attached version of the patch replaces it with a boolean flag for turning
>> off all event triggers, and I also renamed it to the debug_xxx "GUC
>> na
_", no?
Ah, seems we came to same conclusion when looking simultaneously, I just pushed
the fix with the typo fix.
--
Daniel Gustafsson
> On 6 Sep 2023, at 07:18, Suraj Kharage wrote:
> we haven't changed the filename in other test cases.
> Did the same in the attached patch.
Pushed (along with a small typo fix), thanks!
--
Daniel Gustafsson
ion of the patch and I think it's ready to go in. I'm
marking this Ready for Committer and will go ahead with it shortly barring any
objections.
--
Daniel Gustafsson
mespace"
which seemed more appropriate.
--
Daniel Gustafsson
v6-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch
Description: Binary data
> On 5 Sep 2023, at 12:21, Jelte Fennema wrote:
>
> On Tue, 5 Sept 2023 at 11:39, Daniel Gustafsson wrote:
>>
>>> On 5 Sep 2023, at 09:09, Nishant Sharma
>>> wrote:
>>
>>> With this, I was thinking, isn't this a problem of pgbouncer filling
&
inclined to agree that anyone sending a value which is supposed to
represent a PID should be expected to send a value which corresponds to the
format of a PID.
--
Daniel Gustafsson
argued, but I'm far from an expert in this area.
--
Daniel Gustafsson
ink it could be useful for sandboxed testrunners which are destroyed after
each run. There is for sure a foot-gun angle to it, no question about that.
--
Daniel Gustafsson
> On 12 Jul 2023, at 01:36, Nathan Bossart wrote:
>
> On Wed, Jul 12, 2023 at 12:43:14AM +0200, Daniel Gustafsson wrote:
>> I did have coffee before now, but only found time to actually address this
>> now
>> so here is a v7 with just that change and a fresh re
> On 30 Aug 2023, at 00:55, Peter Geoghegan wrote:
>
> On Tue, Aug 29, 2023 at 3:37 PM Daniel Gustafsson wrote:
>>> It's handy when using pg_regress with a custom test suite, where I
>>> don't want to be nagged about disconnecting from the database every
>>>
> On 28 Aug 2023, at 14:32, Daniel Gustafsson wrote:
> Attached is a patch with a quick PoC for using PQPing instead of using psql
> for
> connection checks in pg_regress.
The attached v2 fixes a silly mistake which led to a compiler warning.
--
Daniel Gustafsson
v2-0
> On 30 Aug 2023, at 00:33, Peter Geoghegan wrote:
>
> On Tue, Aug 29, 2023 at 2:53 PM Daniel Gustafsson wrote:
>> Having looked a bit more on it I have a feeling that plain removing it would
>> be
>> the best option. Unless someone chimes in as a user of
> On 29 Aug 2023, at 23:38, Nathan Bossart wrote:
> On Mon, Aug 28, 2023 at 03:11:15PM +0200, Daniel Gustafsson wrote:
>> Does anyone here use it?
>
> I don't think I've ever used it. AFAICT it was added with hot standby mode
> (efc16ea) to support 'make standbycheck', w
> On 29 Aug 2023, at 13:11, Alvaro Herrera wrote:
>
> On 2023-Aug-29, Daniel Gustafsson wrote:
>
>> Agreed. While we have numerous "power of 2" these were the only ones
>> in translated user-facing messages, so I've pushed this to master (it
>> didn't s
ce they were overlapping and a bit too expensive to have
multiples of. Thanks for the patch!
--
Daniel Gustafsson
ns for 16 as we are so close to wrapping it, if
others disagree I can backpatch).
--
Daniel Gustafsson
o I will try to get that sorted shortly.
--
Daniel Gustafsson
that for a long time which seems to indicate that it
isn't really used and should probably be removed rather than fixed?
Does anyone here use it?
--
Daniel Gustafsson
pg_regress_use_existing.diff
Description: Binary data
> On 23 Aug 2023, at 23:12, Daniel Gustafsson wrote:
>
>> On 23 Aug 2023, at 23:02, Tom Lane wrote:
>>
>> Daniel Gustafsson writes:
>>> On 23 Aug 2023, at 21:22, Andres Freund wrote:
>>>> I think there's more effective ways to make this cheape
> On 25 Aug 2023, at 14:42, Jim Jones wrote:
> Is there any tool like pgindent to take care of it automatically?
No, pgindent doesn't address whitespace, only indentation of non-whitespace.
--
Daniel Gustafsson
to ensure a doc patch didn't break something subtle. As long as keep
them from being indexed by search engines and clearly separated from /docs/ it
should be fine.
--
Daniel Gustafsson
re very helpful for the community, and serve two
distincly different purposes. Option 2 is required for a platform to be
considered supported whereas option 3 assists developers in being proactive
rather than just reactive.
--
Daniel Gustafsson
> On 22 Aug 2023, at 07:49, Michael Paquier wrote:
>
> On Wed, Jul 12, 2023 at 01:47:51PM +0200, Daniel Gustafsson wrote:
>> +# bump the query timeout to avoid false negatives on slow test syetems.
>> +$ENV{PG_TEST_TIMEOUT_DEFAULT} = 600;
>> Does this ac
"margay". I think
> "cp -RPp" should be enough everywhere?
Agreed, AFAICT that should work equally well on all supported platforms.
--
Daniel Gustafsson
> On 4 Aug 2023, at 01:36, Nathan Bossart wrote:
>
> On Wed, Jul 19, 2023 at 09:38:12PM +0200, Daniel Gustafsson wrote:
>> Great, thanks! I had a quick look at this while rebasing (as well as your
>> updated patch) and it seems like a good idea to add this. Unless ther
> On 24 Aug 2023, at 10:11, Sergey Shinderuk wrote:
>
> On 23.08.2023 16:23, Daniel Gustafsson wrote:
>>> On 1 Aug 2023, at 16:44, Sergey Shinderuk
>>> wrote:
>>> A static analyzer reported a possible pfree(NULL) in be_tls_open_server().
>> This has t
> On 23 Aug 2023, at 23:47, Jacob Champion wrote:
>
> On Wed, Aug 23, 2023 at 6:23 AM Daniel Gustafsson wrote:
>> This has the smell of a theoretical problem, I can't really imagine a
>> certificate where which would produce this. Have you been able to trigger
>> i
> On 23 Aug 2023, at 23:02, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> On 23 Aug 2023, at 21:22, Andres Freund wrote:
>>> I think there's more effective ways to make this cheaper. The basic thing
>>> would be to use libpq instead of forking of psql to mak
> On 23 Aug 2023, at 21:22, Andres Freund wrote:
> On 2023-08-23 14:48:26 +0200, Daniel Gustafsson wrote:
>> I'll do another pass, but below are a few small comments so far.
>>
>> I don't know Windows to know the implications, but should the below file have
>&
better fix be to error out on len == -1 as in the attached, maybe
with a "Shouldn't happen" comment?
--
Daniel Gustafsson
X509_NAME_get_text_by_NID.diff
Description: Binary data
if (i >= wait_seconds)
{
It's a micro-optimization, but if we're changing things here to chase cycles it
might perhaps be worth doing?
--
Daniel Gustafsson
> On 21 Aug 2023, at 12:15, Junwang Zhao wrote:
>
> On Mon, Aug 21, 2023 at 5:16 PM Daniel Gustafsson wrote:
>>
>>> On 18 Aug 2023, at 11:10, Junwang Zhao wrote:
>>>
>>> In the following sentence, I believe either 'the' or 'a' should be kept, not
> On 23 Aug 2023, at 03:17, Andres Freund wrote:
> On 2023-08-22 23:47:24 +0200, Daniel Gustafsson wrote:
>> My only small gripe is that I keep thinking about template databases for
>> CREATE
>> DATABASE when reading the error messages in this patch, which is clearl
> On 23 Aug 2023, at 03:28, Peter Smith wrote:
> PSA a small patch to remove the unnecessary parameter, and so eliminate this
> shadowing.
Agreed, applied. Thanks!
--
Daniel Gustafsson
ose this one.
--
Daniel Gustafsson
separated, but thats personal taste.
All in all, I think this is committable as is.
--
Daniel Gustafsson
n repo before releases. The
commit can be seen here:
https://git.postgresql.org/gitweb/?p=pgtranslation/messages.git;a=commitdiff;h=14391f71ca61e90d52502093447fe1ee0080116f
--
Daniel Gustafsson
handle the caller wants created.
> + *new handle the caller wants created.
Since the handle doesn't exist for DSM_OP_CREATE, both "a handle" and "the
handle" seems a tad misleading, how about "the identifier for the new handle the
caller wants created"?
--
Daniel Gustafsson
f summer vacation, doing CFM and looking at things for
v16, and some things were left further down on the TODO stack duing this.
>> I thought v2 was ready to be pushed, but then this thread went silent
>> for 3 months
>
> Change looks fine, so applied.
Agreed, and thanks for applying.
--
Daniel Gustafsson
returned with feedback. Please feel free to continue the discussion here and
re-open a new entry in a future CF if there is a new version of the patch.
--
Daniel Gustafsson
> On 3 Jul 2023, at 15:57, Daniel Gustafsson wrote:
>
>> On 16 May 2023, at 20:51, Sergey Dudoladov
>> wrote:
>
>> I have attached the fourth version of the patch.
>
> This version fails the ldap_password test on all platforms on pg_ctl failing
> to s
401 - 500 of 2213 matches
Mail list logo
