enabling only in specialized debugging builds?
--
Daniel Gustafsson
> On 24 May 2023, at 23:05, Justin Pryzby wrote:
> I'm planning to set this patch as ready
This is marked RfC so I'm moving this to the next CF, but the patch no longer
applies so it needs a rebase.
--
Daniel Gustafsson
silencing static analyzers could be reason enough to delay allocation.
--
Daniel Gustafsson
> On 20 Jul 2023, at 17:24, Daniel Gustafsson wrote:
>
>> On 17 Jul 2023, at 20:26, Cary Huang wrote:
>
>>>> Perhaps calling "tm2timestamp(_time, 0, NULL, )" without checking
>>>> the return code would be just fine. I see some other usages of
gain (leaving certificate
changes in place) to keep the buildfarm green.
Will look closer at an implementation which works across all supported versions
of OpenSSL when I have more time.
--
Daniel Gustafsson
we should probably mark it returned with feedback.
--
Daniel Gustafsson
This patch no longer applies and needs a rebase.
Given where we are in the commitfest, do you think this patch has the potential
to go in or should it be moved?
--
Daniel Gustafsson
option, it may then additionally say: "If the
> --clean and --force options are specified, DROP DATABASE ... WITH
> FORCE command will be used to drop the database."
pg_restore --clean refers to dropping any pre-existing database objects and not
just databases, but --force would only appl
> On 9 Feb 2023, at 07:32, Masahiko Sawada wrote:
> I've attached the patch of this idea for discussion.
Amit, Andres: have you had a chance to look at the updated version of this
patch?
--
Daniel Gustafsson
> On 18 Jul 2023, at 18:04, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> Looking at the upgrade question in [0] made me realize that we discard
>> potentially useful information for troubleshooting. When we check if the
>> cluster is properly shut down we might
> On 19 Jul 2023, at 19:32, Dagfinn Ilmari Mannsåker wrote:
>
> Daniel Gustafsson writes:
>
>> This patch no longer applied but had a fairly trivial conflict so I've
>> attached
>> a rebased v3 addressing the conflict in the hopes of getting this further.
>
-free testrun. There are no functional
changes included, just changed names (and comments to match).
--
Daniel Gustafsson
v1-0001-Remove-backend-warnings-when-running-SSL-tests.patch
Description: Binary data
This patch no longer applied but had a fairly trivial conflict so I've attached
a rebased v3 addressing the conflict in the hopes of getting this further.
--
Daniel Gustafsson
v3-0001-Add-argument-names-to-multi-argument-aggregates.patch
Description: Binary data
diff.
Is there a reason not to be verbose here as users might copy/paste this output
when asking for help?
--
Daniel Gustafsson
[0] CACoPQdbQTysF=ekckyfngtdpodxxmesf_2acno+bcnqqcb5...@mail.gmail.com
pg_upgrade_controldata.diff
Description: Binary data
6.400 +
7.365 +
+
It's less obvious how the additional level of details should be represented
here.
+ int64 jit_deform_count; /* number of times deform time has been >
+ * 0 */
While not a new problem with this patch, the comments on this struct yields
pretty awkward reflows by pgindent. I wonder if we should make a separate pass
over this at some point to clean it up?
The patch also fails to update doc/src/sgml/jit.sgml with the new EXPLAIN
output.
--
Daniel Gustafsson
n the latter category.
As the size of the JWT depends on the number of claims in it, are you able to
reduce the number of claims to stay under the limit as a workaround?
--
Daniel Gustafsson
OpenSSL versions, so any change and
setting must in some way make sense for those installations (which may be a
no-op, a warning at startup for non-applicable settings, or something else).
--
Daniel Gustafsson
now about any failures, btu we can probably make it into an
elog() instead, as it should never fail.
--
Daniel Gustafsson
> On 13 Jul 2023, at 22:52, Andres Freund wrote:
> On 2023-07-12 11:54:18 +0200, Daniel Gustafsson wrote:
>> Looking more at this I wonder if we in HEAD should make this a bit nicer by
>> extending the --check phase to catch this? I did a quick hack along these
>>
efaults to TRUE.
> But in JsonObjectAgg, absent_on_null defaults to FALSE.
> Is that intentionally?
I would say so, an empty NULL|ABSENT ON NULL clause for arrays is defined as
true, while for objects it's defined as false (which is shared between both
json_object() and json_objectagg()).
--
Daniel Gustafsson
the tree for v17 - we
just need a date in the past). Your two patches are rolled into a single one
with a commit message added to get started on that part as well.
--
Daniel Gustafsson
v5-0001-Set-fixed-dates-for-test-certificates-validity.patch
Description: Binary data
v5-0002-Add-
updates it, making it more specific (and IMO more readable). I also add
> a comment to the enum definition, to remind people that the other one
> needs to be modified.
LGTM, a clear improvement.
> This ought to be backpatched to 16.
+1
--
Daniel Gustafsson
rogram
seems to confirm this but I might be missing something.
--
Daniel Gustafsson
> On 12 Jul 2023, at 03:59, Andres Freund wrote:
> On 2023-07-07 14:09:08 +0200, Daniel Gustafsson wrote:
>>> On 25 Jun 2023, at 19:03, Andres Freund wrote:
>>> On 2023-06-21 12:02:04 -0700, Andres Freund wrote:
>>> There don't need to be explict checks, beca
> On 11 Jul 2023, at 01:26, Daniel Gustafsson wrote:
>> On 11 Jul 2023, at 01:09, Nathan Bossart wrote:
>> I think we need to tmp++ somewhere here.
>
> Yuk, yes, will fix when caffeinated. Thanks.
I did have coffee before now, but only found time to actually address thi
> On 11 Jul 2023, at 01:09, Nathan Bossart wrote:
> On Mon, Jul 10, 2023 at 04:43:23PM +0200, Daniel Gustafsson wrote:
>>> +static int n_data_types_usage_checks = 7;
>>>
>>> Can we determine this programmatically so that folks don't need to remember
>>
since some check <= and
some == while some check the catversion as well (and new ones may have other
variants. I think this is the least paint-ourselves-in-a-corner version, if we
feel it's needlessly complicated and no other variants are added we can revisit
this.
--
Daniel Gustafsson
v6-0001-pg_upgrade-run-all-data-type-checks-per-connectio.patch
Description: Binary data
g this
> CF entry as RwF if this will be helpful. We may reopen it if and when
> necessary.
Ok, will do. Please feel free to resubmit to a future CF when there is a new
version for consideration.
--
Daniel Gustafsson
here that using square brackets to denote IPv6
> addresses will make it (unnecessarily?) harder to process this with a shell
> script.
This patch is Waiting on Author in the current commitfest with no new patch
presented following the discussion here. Is there an update ready or should we
close it in this CF in favour of a future one?
--
Daniel Gustafsson
> On 25 Apr 2023, at 16:47, Dave Cramer wrote:
> Patch attached with comments removed
This patch no longer applies, please submit a rebased version on top of HEAD.
--
Daniel Gustafsson
> On 28 Mar 2023, at 21:59, David Rowley wrote:
> I'll mark this as waiting on author while you work on that.
Richard: have you had a chance to incorporate the tests proposed by David in
this thread into your patch?
--
Daniel Gustafsson
> On 10 Jul 2023, at 11:32, Daniel Gustafsson wrote:
>
>> On 4 Apr 2023, at 06:50, David Rowley wrote:
>
>> Updated patches attached.
>
> This patch is marked Waiting on Author, but from the thread it seems Needs
> Review is more apt. I've changed status a
hanges in formatting for Perl
code.
--
Daniel Gustafsson
v2-0001-Add-pg_prefetch_mem-macro-to-load-cache-lines.patch
Description: Binary data
stalled. I'm marking this returned with feedback for now, please feel free
to resubmit to a future CF with a new version of the patch.
--
Daniel Gustafsson
Hi Thomas,
Have you have a chance to look at and address the feedback given in this
thread?
--
Daniel Gustafsson
or applying for a
while, so I am going to mark this Returned with Feebdback. Please feel free to
resubmit to a future CF when there is renewed interest/time to work on this.
--
Daniel Gustafsson
d, in order to produce a new version of the patch?
--
Daniel Gustafsson
gt;> move to the next CF for the next release?
>
> I moved it to the next commitfest and marked the target version as v17.
Have you had any chance to revisit this such that there is a new patch to
review, or should it be returned/moved for now?
--
Daniel Gustafsson
have
> that in the core module instead as a routine that would be used by the
> in-core TAP tests of pg_upgrade and the buildfarm code.
That however, would be a more interesting outcome.
--
Daniel Gustafsson
od.
+ if (database_is_invalid_form((Form_pg_database) dbform))
+ continue;
Would it make sense to stick a DEBUG2 log entry in there to signal that such a
database exist? (The same would apply for the similar hunk in autovacuum.c.)
--
Daniel Gustafsson
teRestrictedProcess(...))
>
> Probably, it's been a while. I doubt it's worth changing at this point, and
> we could just change pg_regress.c to use a boolean test like the above.
Done that way and pushed, thanks!
--
Daniel Gustafsson
he community.
--
Daniel Gustafsson
This patch no longer applies to master, please submit a rebased version to the
thread. I've marked the CF entry as waiting for author in the meantime.
--
Daniel Gustafsson
around so I consider it a
failure. If you have any suggestions, I would be more than happy to review and
incorporate those though.
Attached is a v5 with the above fixes and a pgindenting to fix up a few runaway
comments and indentations.
--
Daniel Gustafsson
v5-0001-pg_upgrade-run-all-data-type-checks-per-connectio.patch
Description: Binary data
> On 6 Jul 2023, at 16:42, Ranier Vilela wrote:
> Em qui., 6 de jul. de 2023 às 11:37, Daniel Gustafsson <mailto:dan...@yesql.se>> escreveu:
> #define SH_MAX_SIZE (((uint64) PG_UINT32_MAX) + 1)
> This is Assert, that is, in production this test is not done.
Correct, wh
#define SH_MAX_SIZE (((uint64) PG_UINT32_MAX) + 1)
Can you show a reproducer example where you are able to overflow?
--
Daniel Gustafsson
> On 5 Jul 2023, at 14:49, Andrew Dunstan wrote:
> On 2023-07-04 Tu 16:54, Daniel Gustafsson wrote:
>>> On 4 Jul 2023, at 20:19, Andrew Dunstan
>>> wrote:
>>>
>>> But sadly we're kinda back where we started. fairywren is failing on
>>> REL
> On 6 Jul 2023, at 15:29, Matthias van de Meent
> wrote:
>
> On Thu, 6 Jul 2023 at 14:24, Daniel Gustafsson wrote:
>>
>>> On 22 Jun 2023, at 20:30, Nikolay Samokhvalov wrote:
>>
>>> Some small updates as I see them:
>>> - there is r
F when there is renewed interest in working on
this.
--
Daniel Gustafsson
a patch, please consider doing so. If you are
signed up and actively reviewing, thank you very much!
--
Daniel Gustafsson
e current CF, not because we
don't want the feature but because it's unlikely that it will go in now given
that standardization is still underway. Comitting anything right now seems
premature, we might as well wait for standardization given that we have lots of
time before the v17 freeze.
--
Daniel Gustafsson
This patch hasn't applied for quite some time, has been waiting on author since
December, and the thread has stalled. I'm marking this Returned with Feedback
for now, please feel free to resubmit to a future CF when there is renewed
interest in working on this.
--
Daniel Gustafsson
ding due to it being summer and things slow down, but I've added Andrew
Dunstan who is the Buildfarm expert on CC:.
--
Daniel Gustafsson
This patch has now been waiting for author since December, with the thread
stalled. I am marking this returned with feedback for now, please feel free to
re-submit the patch to a future CF when there is renewed interest in working on
this.
--
Daniel Gustafsson
> On 6 Jul 2023, at 10:12, Peter Eisentraut
> wrote:
> it would make sense to either close this entry as returned with feedback, or
> move it to the next commit fest as waiting on author.
Fair enough, done.
--
Daniel Gustafsson
elatively straight forward. I'll put a patch together for
> that and then update this patch to alter the operator.
Did you have a chance to look at this for an updated patch for this commitfest?
--
Daniel Gustafsson
gt; Plan node so the executor has access to it during EXPLAIN.
Lukas: do you have an updated patch for this commitfest to address David's
comments?
--
Daniel Gustafsson
> On 16 May 2023, at 11:17, Daniel Gustafsson wrote:
> Parked in the July CF for now.
Rebased to fix a trivial conflict highlighted by the CFBot.
--
Daniel Gustafsson
v3-0001-pg_regress-Add-database-verification-test.patch
Description: Binary data
the patch no longer applies. Please rebase and send an updated version.
--
Daniel Gustafsson
");
"less than ROW minimum rows" reads a bit awkward IMO, how about calling it
[m=MIN] and describe as "stop if less than MIN rows are returned"? Also, there
is a typo: s/rerturned/returned/.
--
Daniel Gustafsson
to commit (the featurematrix
is stored in the postgresql.org django instance) since there was a change
performed.
Thanks for the report!
--
Daniel Gustafsson
> On 8 May 2023, at 10:39, Daniel Gustafsson wrote:
>> On 4 May 2023, at 14:18, Daniel Gustafsson wrote:
>>> On 4 May 2023, at 14:09, Tom Lane wrote:
>>> How about naming
>>> the hash "EventTriggerCacheHash" or so?
>>
>> I think the
does sound like a fairly large hammer for a nail small enough that we
should be able to fix it, but I don't have any other good ideas off the cuff.
--
Daniel Gustafsson
rror handler, but I can't see a reason not clean it up here.
The attached fix LGTM and passes make check with jit_above_cost set to zero.
--
Daniel Gustafsson
Please feel free to resubmit to a future CF when there
is renewed interest in working on this.
--
Daniel Gustafsson
> On 4 Jul 2023, at 13:59, Heikki Linnakangas wrote:
> On 08/03/2023 00:05, Daniel Gustafsson wrote:
>> If we are going to continue using this for reading $stuff from pipes, maybe
>> we
>> should think about presenting a nicer API which removes that risk? Returning
>
x introduced in
> 0003, and 0003 uses the function build_period_range() from 0004.
These patches no longer apply without a new rebase. Should this patch be
closed in while waiting for the prequisite of adding btree_gist to core
mentioned upthread? I see no patch registered in the CF for this unless I'm
missing sometihng.
--
Daniel Gustafsson
pdates soon I'll move this on to the next
> commitfest or mark it returned with feedback.
There are still no updates to this patch or thread, so I'm closing this as
Returned with Feedback. Please feel free to resubmit to a future CF when there
is renewed interest in working on this.
--
Daniel Gustafsson
Have you had a chance to address the comments raised by Michael in his last
review such that a new patch revision can be submitted?
--
Daniel Gustafsson
> On 17 Mar 2023, at 10:16, Amit Kapila wrote:
> Few minor comments:
Have you had a chance to address the comments raised by Amit in this thread?
--
Daniel Gustafsson
t, please feel
free to resubmit when there is renewed interest in working on this.
--
Daniel Gustafsson
with.
--
Daniel Gustafsson
chance to look at this such that there is something ready?
--
Daniel Gustafsson
elease.
>
> Sounds good. I actually thought I did that already, thanks for catching
> that.
This has been waiting on author since January, unless there is a new patch
ready I will close this as Returned with Feedback and you can resubmit for
another CF when there is a new patch.
--
Daniel Gustafsson
This patch has been waiting on the author for about a year now, so I will close
it as Returned with Feedback. Plesae feel free to resubmit to a future CF when
there is renewed interest in working on this.
--
Daniel Gustafsson
of backpatches.
--
Daniel Gustafsson
ort! OpenBSD 5.9 was released in 2016 and is thus well over
5 years EOL, so I agree that it doesn't warrant a code change from us to
support this.
--
Daniel Gustafsson
gness to try this out, I am happy to prepare a patch.
This has been discussed a number of times in the past, and the conclusion from
last time IIRC was to use size_t for new code and only change the existing
instances when touched for other reasons to avoid churn.
--
Daniel Gustafsson
ce January, I'm marking it
Returned with Feedback. Please feel free to resubmit when there is time and
interest to resume work on this.
--
Daniel Gustafsson
djust the patch accordingly. However,
> if there is a preference to keep the output of certain test cases unchanged,
> I can rebase and modify the patch accordingly to accommodate those
> preferences.
As there hasn't been any other comments I suggest updating your patch to
address Tom's comments to see if we can make progress here.
--
Daniel Gustafsson
> missing a header perhaps?
>
> #include "time.h"
This patch spent the March commitfest not building and still doesn't build, so
I'm marking this returned with feedback. Please feel free to resubmit to the
next commitfest if there is renewed interest in the patch.
--
Daniel Gustafsson
This thread has been stale since January with no movement at all during the
March CF, and according to the CFBot it stopped building at all ~ 14 weeks ago.
I'm marking this returned with feedback, it can be resubmitted for a future CF
if someone decides to pick it up.
--
Daniel Gustafsson
> On 3 Jul 2023, at 17:18, Andrew Dunstan wrote:
> On 2023-07-03 Mo 10:16, Daniel Gustafsson wrote:
>>> On 3 Jul 2023, at 16:12, Andrew Dunstan
>>> wrote:
>>>
>>> I've pushed a better solution, which creates the file via a short symlink.
>>&g
> On 3 Jul 2023, at 16:12, Andrew Dunstan wrote:
> I've pushed a better solution, which creates the file via a short symlink.
> Experimentation on fairywren showed this working.
The buildfarm seems a tad upset after this?
--
Daniel Gustafsson
meters marked as NOT_IN_SAMPLE in
postgresql.conf.sample
[08:31:26.680] 1..3
[08:31:26.680] # test failed
--
Daniel Gustafsson
odules/ldap_password_func/t/001_mutated_bindpasswd.pl with
the new GUC might solve the problem from skimming this.
Please send a fixed version, I'm marking the patch Waiting on Author in the
meantime.
--
Daniel Gustafsson
ch now no longer fit.
--
Daniel Gustafsson
v2-0001-Add-support-for-AT-LOCAL.patch
Description: Binary data
ate *planstate = (PlanState *) lfirst(l);
--
Daniel Gustafsson
see what might be going on there? The test passed about
4 days ago on Windows so unless it's the CI being flaky it should be due to a
recent change.
If you don't have access to a Windows environment you can run your own
instrumented builds in your Github account with the CI files in the postgres
r
This patch required a trivial rebase after conflicting with bfcf1b3480 so I've
attached a v2 to get the CFBot to run this.
--
Daniel Gustafsson
v2-0001-Ensure-that-creation-of-an-empty-relfile-is-fsync.patch
Description: Binary data
> On 28 Jun 2023, at 09:45, Daniel Gustafsson wrote:
>
> A quick scan of the archives doesn't turn up anyone who has volunteered in
> advance to run the upcoming commitfest. Is anyone keen at trying their hand
> at
> this very important community work? The July CF is goo
imestamp data types to save the user from
having to convert them. Same with the additions to pg_stat_get_activity.
You should add tests for the new functions in src/test/ssl/t/003_sslinfo.pl.
--
Daniel Gustafsson
--
1 /*--
plpy_util.h being the only one that sticks out.
--
Daniel Gustafsson
irectories" instead of "those directories" here.
--
Daniel Gustafsson
he control-file
> switch back in, so there's an explicit choice by extension developers.
This version fails the extension test since the comment from the .sql file is
missing from test_extensions.out. Can you fix that in a rebase such that the
CFBot can have a green build of this patch?
--
Daniel Gustafsson
the ones later in
the cycle.
--
Daniel Gustafsson
rpart to a static function since they are copies of
>> eachother.
>
> Yes agreed. I have made the adjustment attached as
> "v2-0001-sslinfo-add-notbefore-and-notafter-timestamps.patch"
The new patchset isn't updating contrib/sslinfo/meson with the 1.3 update so it
fails to build with Meson.
--
Daniel Gustafsson
gt;> I missed any more recent suggestions.)
+1. I think it simply got lost in that thread which had a lot of moving parts
as it was.
--
Daniel Gustafsson
> On 23 Jun 2023, at 22:10, Cary Huang wrote:
> would this feature be suitable to be added to commitfest? What do you think?
Yes, please add it to the July commitfest and feel free to set me as Reviewer,
I intend to take a look at it.
--
Daniel Gustafsson
Windows, still `perl -cw Solution.pm` is OK with
> it.
These patches LGTM from reading, but I think the Discussion link in the commit
messages should refer to this thread as well.
--
Daniel Gustafsson
501 - 600 of 2202 matches
Mail list logo
