Re: request for database identifier in the startup packet

2024-05-09 Thread Dave Cramer
On Thu, 9 May 2024 at 15:39, Robert Haas wrote: > On Thu, May 9, 2024 at 3:33 PM Dave Cramer wrote: > > On Thu, 9 May 2024 at 15:19, Robert Haas wrote: > >> On Thu, May 9, 2024 at 3:14 PM Andres Freund > wrote: > >> > ISTM that you could just as well query t

Re: request for database identifier in the startup packet

2024-05-09 Thread Dave Cramer
On Thu, 9 May 2024 at 15:19, Robert Haas wrote: > On Thu, May 9, 2024 at 3:14 PM Andres Freund wrote: > > ISTM that you could just as well query the information you'd like after > > connecting. And that's going to be a lot more flexible than having to > have > > precisely the right information

Re: request for database identifier in the startup packet

2024-05-09 Thread Dave Cramer
Dave Cramer On Thu, 9 May 2024 at 12:22, Robert Haas wrote: > On Thu, May 9, 2024 at 8:06 AM Dave Cramer wrote: > > The JDBC driver is currently keeping a per connection cache of types in > the driver. We are seeing cases where the number of columns is quite high. > In o

request for database identifier in the startup packet

2024-05-09 Thread Dave Cramer
com/pgjdbc/pgjdbc/issues/3241> 2.6 Million columns. If we knew that we were connecting to the same database we could use a single cache across connections. I think we would require a server/database identifier in the startup message. Dave Cramer

Possible to include xid8 in logical replication

2024-05-06 Thread Dave Cramer
Greetings, I've been asked by the debezium developers if it is possible to include xid8 in the logical replication protocol. Are there any previous threads on this topic? Any reason why we wouldn't include the epoch ? Dave Cramer

Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

2024-04-15 Thread Dave Cramer
On Mon, 15 Apr 2024 at 15:38, Jelte Fennema-Nio wrote: > On Mon, 15 Apr 2024 at 19:43, Robert Haas wrote: > > > > On Sat, Apr 6, 2024 at 6:14 PM Jelte Fennema-Nio wrote: > > > I think for clients/drivers, the work would generally be pretty > > > minimal. For almost all proposed changes,

Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

2024-04-05 Thread Dave Cramer
> > > Plus, you've got all of the consequences for non-core drivers, which > have to both add support for the new wire protocol - if they don't > want to seem outdated and eventually obsolete - and also test that > they're still compatible with all supported server versions. > Connection poolers

Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

2024-04-05 Thread Dave Cramer
On Fri, 5 Apr 2024 at 12:09, Jelte Fennema-Nio wrote: > On Fri, 5 Apr 2024 at 16:02, Robert Haas wrote: > > Often? > > > > I kind of hope that the protocol starts to evolve a bit more than it > > has, but I don't want a continuous stream of changes. That will be > > very hard to test and verify

Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

2024-04-05 Thread Dave Cramer
On Thu, 4 Apr 2024 at 12:45, Jelte Fennema-Nio wrote: > On Thu, 4 Apr 2024 at 14:50, Peter Eisentraut > wrote: > > It appears there are several different perspectives about this. My > > intuition was that a protocol version change indicates something that we > > eventually want all client

Re: incorrect results and different plan with 2 very similar queries

2024-03-27 Thread Dave Cramer
Dave Cramer On Wed, 27 Mar 2024 at 17:57, David Rowley wrote: > On Thu, 28 Mar 2024 at 10:33, Dave Cramer wrote: > > There is a report on the pgjdbc github JDBC Driver shows erratic > behavior when filtering on CURRENT_DATE · pgjdbc/pgjdbc · Discussion #3184 ( > github.co

incorrect results and different plan with 2 very similar queries

2024-03-27 Thread Dave Cramer
=0.035..0.035 rows=356 loops=1) Index Cond: (p.mutation >= ((CURRENT_DATE - `1971-12-31`::date) - 29)) Planning Time: 0.379 ms Execution Time: 5.443 ms <https://github.com/pgjdbc/pgjdbc/discussions/3184> Dave Cramer

Re: Trying to build x86 version on windows using meson

2024-03-21 Thread Dave Cramer
Andres, On Thu, 21 Mar 2024 at 12:51, Andres Freund wrote: > Hi, > > On 2024-03-21 07:11:23 -0400, Dave Cramer wrote: > > It seems that attempting to cross-compile on an ARM machine might be > asking > > too much as the use cases are pretty limited. > > It for sur

Re: Trying to build x86 version on windows using meson

2024-03-21 Thread Dave Cramer
On Thu, 21 Mar 2024 at 03:56, Peter Eisentraut wrote: > On 20.03.24 22:49, Dave Cramer wrote: > > > > > > > > On Wed, 20 Mar 2024 at 17:11, Andres Freund > <mailto:and...@anarazel.de>> wrote: > > > > Hi, > > > > On 2024-0

Trying to build x86 version on windows using meson

2024-03-20 Thread Dave Cramer
instructions ? Dave Cramer

Re: query_id, pg_stat_activity, extended query protocol

2024-03-20 Thread Dave Cramer
> > >> >> FWIW, I'd like to think that we could improve the situation, requiring >> a mix of calling pgstat_report_query_id() while feeding on some query >> IDs retrieved from CachedPlanSource->query_list. I have not in >> details looked at how much could be achieved, TBH. >> > This just cropped

Re: When extended query protocol ends?

2024-02-15 Thread Dave Cramer
Hi Tatsuo, Actually no need, I figured it out. I don't have a solution yet though. Dave Cramer www.postgres.rocks On Thu, 15 Feb 2024 at 19:43, Tatsuo Ishii wrote: > > Can you ask the OP what they are doing in the startup. I'm trying to > > replicate their situation. > > L

Re: When extended query protocol ends?

2024-02-15 Thread Dave Cramer
On Wed, 14 Feb 2024 at 17:55, Tatsuo Ishii wrote: > >>> From [1] I think the JDBC driver sends something like below if > >>> autosave=always option is specified. > >>> > >>> "BEGIN READ ONLY" Parse/Bind/Eexecute (in the extended query protocol) > >>> "SAVEPOINT PGJDBC_AUTOSAVE" (in the simple

Re: [PATCH] Add native windows on arm64 support

2024-02-13 Thread Dave Cramer
On Tue, 13 Feb 2024 at 12:52, Andres Freund wrote: > Hi, > > On 2024-02-13 12:49:33 -0500, Dave Cramer wrote: > > > I think I might have been on to something - if my human emulation of a > > > preprocessor isn't wrong, we'd end up with > > > > > &g

Re: [PATCH] Add native windows on arm64 support

2024-02-13 Thread Dave Cramer
Dave Cramer www.postgres.rocks On Mon, 12 Feb 2024 at 16:19, Andres Freund wrote: > Hi, > > On 2024-02-12 12:50:12 -0800, Andres Freund wrote: > > On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote: > > I wonder if this indicates that we are either missing memory b

Re: When extended query protocol ends?

2024-02-13 Thread Dave Cramer
HI Tatsuo, On Mon, 29 Jan 2024 at 20:15, Tatsuo Ishii wrote: > Hello Dave, > > > Tatsuo Ishii writes: > >> Below is outputs from "pgproto" command coming with Pgpool-II. > >> (Lines starting "FE" represents a message from frontend to backend. > >> Lines starting "BE" represents a message

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Dave Cramer
On Mon, 12 Feb 2024 at 15:50, Andres Freund wrote: > Hi, > > On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote: > > On 2024-02-12 Mo 11:44, Dave Cramer wrote: > > > OK, so I have managed to get a debugger attached to postgres.exe when > it > > > faults a

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Dave Cramer
Dave Cramer www.postgres.rocks On Mon, 12 Feb 2024 at 09:19, Andrew Dunstan wrote: > > On 2024-02-12 Mo 08:51, Dave Cramer wrote: > > > > On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: > >> >> On 2024-02-10 Sa 12:20, Dave Cramer wrote: >> >&g

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Dave Cramer
On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: > > On 2024-02-10 Sa 12:20, Dave Cramer wrote: > > > > On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: > >> >> On 2024-02-09 Fr 14:23, Dave Cramer wrote: >> >> >> Dave Cramer >> www.

Re: [PATCH] Add native windows on arm64 support

2024-02-10 Thread Dave Cramer
On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: > > On 2024-02-09 Fr 14:23, Dave Cramer wrote: > > > Dave Cramer > www.postgres.rocks > > > On Fri, 9 Feb 2024 at 07:18, Dave Cramer > wrote: > >> >> >> >> >> On Fri, 9 Feb 202

Re: [PATCH] Add native windows on arm64 support

2024-02-09 Thread Dave Cramer
On Fri, 9 Feb 2024 at 14:36, Andres Freund wrote: > Hi, > > On 2024-02-09 14:23:46 -0500, Dave Cramer wrote: > > > interestingly meson test does not produce any error > > > The buildfarm produces the following error for me: > > > > > > -SELECT r

Re: [PATCH] Add native windows on arm64 support

2024-02-09 Thread Dave Cramer
Dave Cramer www.postgres.rocks On Fri, 9 Feb 2024 at 07:18, Dave Cramer wrote: > > > > > On Fri, 9 Feb 2024 at 00:26, Michael Paquier wrote: > >> On Tue, Feb 06, 2024 at 07:01:49AM -0500, Dave Cramer wrote: >> > Thanks, this patch works and >>

Re: [PATCH] Add native windows on arm64 support

2024-02-09 Thread Dave Cramer
On Fri, 9 Feb 2024 at 00:26, Michael Paquier wrote: > On Tue, Feb 06, 2024 at 07:01:49AM -0500, Dave Cramer wrote: > > Thanks, this patch works and > > testing with meson passes. > > Only with the version posted at [1]? Interesting, that's the same > contents as v8 po

Re: [PATCH] Add native windows on arm64 support

2024-02-06 Thread Dave Cramer
On Wed, 31 Jan 2024 at 10:21, Andrew Dunstan wrote: > > On 2024-01-30 Tu 17:54, Dave Cramer wrote: > > > > > On Tue, Jan 30, 2024 at 4:56 PM Andrew Dunstan > wrote: > >> >> On 2024-01-30 Tu 09:50, Dave Cramer wrote: >> >> >&g

Re: When extended query protocol ends?

2024-02-01 Thread Dave Cramer
On Mon, 29 Jan 2024 at 20:15, Tatsuo Ishii wrote: > Hello Dave, > > > Tatsuo Ishii writes: > >> Below is outputs from "pgproto" command coming with Pgpool-II. > >> (Lines starting "FE" represents a message from frontend to backend. > >> Lines starting "BE" represents a message from backend to

Re: [PATCH] Add native windows on arm64 support

2024-01-30 Thread Dave Cramer
On Tue, Jan 30, 2024 at 4:56 PM Andrew Dunstan wrote: > > On 2024-01-30 Tu 09:50, Dave Cramer wrote: > > > > On Tue, 30 Jan 2024 at 08:38, Andrew Dunstan wrote: > >> >> On 2024-01-29 Mo 11:20, Dave Cramer wrote: >> >> >> Dave Cramer >>

Re: [PATCH] Add native windows on arm64 support

2024-01-30 Thread Dave Cramer
On Tue, 30 Jan 2024 at 08:38, Andrew Dunstan wrote: > > On 2024-01-29 Mo 11:20, Dave Cramer wrote: > > > Dave Cramer > www.postgres.rocks > > > On Mon, 29 Jan 2024 at 11:16, Andrew Dunstan wrote: > >> >> On 2024-01-26 Fr 09:18, Dave Cramer wrote: >&g

Re: [PATCH] Add native windows on arm64 support

2024-01-29 Thread Dave Cramer
Dave Cramer www.postgres.rocks On Mon, 29 Jan 2024 at 11:16, Andrew Dunstan wrote: > > On 2024-01-26 Fr 09:18, Dave Cramer wrote: > > > > On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: > >> >> On 2024-01-25 Th 20:32, Michael Paquier wrote: >> >

Re: [PATCH] Add native windows on arm64 support

2024-01-26 Thread Dave Cramer
On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: > > On 2024-01-25 Th 20:32, Michael Paquier wrote: > > On Thu, Jan 25, 2024 at 04:52:30PM -0500, Dave Cramer wrote: > >> On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan > wrote: > >>> On 2024-01-25 Th 16:17, Da

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan wrote: > > On 2024-01-25 Th 16:17, Dave Cramer wrote: > > > > On Thu, 25 Jan 2024 at 16:04, Anthony Roberts > wrote: > >> Hi David, >> >> Unix "file" or "dumpbin /headers" in vcva

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 16:04, Anthony Roberts wrote: > Hi David, > > Unix "file" or "dumpbin /headers" in vcvarsall are your best bets. > > Thanks, > Anthony > So there is another way, select the file in Windows Explorer and right click, in the compatibility tab if the "Windows on ARM" is

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 12:30, Andrew Dunstan wrote: > > On 2024-01-24 We 19:02, Michael Paquier wrote: > > On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: > > I managed to get it to build the vcvarsall arch needs to be x64. I need to > add some options, but

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 14:31, Andrew Dunstan wrote: > > On 2024-01-25 Th 08:45, Dave Cramer wrote: > > > > > > I tried running my buildfarm using my git repo and my branch, but get the > following error > Status Line: 492 bad branch parameter > Content: > bad

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 12:30, Andrew Dunstan wrote: > > On 2024-01-24 We 19:02, Michael Paquier wrote: > > On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: > > I managed to get it to build the vcvarsall arch needs to be x64. I need to > add some options, but

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 08:31, Dave Cramer wrote: > > > On Wed, 24 Jan 2024 at 19:03, Michael Paquier wrote: > >> On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: >> > I managed to get it to build the vcvarsall arch needs to be x64. I need >> to >

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Wed, 24 Jan 2024 at 19:03, Michael Paquier wrote: > On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: > > I managed to get it to build the vcvarsall arch needs to be x64. I need > to > > add some options, but the patch above needs to be applied to build it. >

Re: [PATCH] Add native windows on arm64 support

2024-01-24 Thread Dave Cramer
On Tue, 23 Jan 2024 at 18:32, Michael Paquier wrote: > On Tue, Jan 23, 2024 at 04:13:05PM -0500, Dave Cramer wrote: > > On Tue, 23 Jan 2024 at 08:46, Dave Cramer > wrote: > >> The attached patch works with v17. I will work on getting a buildfarm > >> animal u

Re: [PATCH] Add native windows on arm64 support

2024-01-23 Thread Dave Cramer
On Tue, 23 Jan 2024 at 08:46, Dave Cramer wrote: > > > On Tue, 19 Sept 2023 at 23:48, Michael Paquier > wrote: > >> On Tue, Sep 19, 2023 at 01:35:17PM +0100, Anthony Roberts wrote: >> > Was there an explicit request for something there? I was under the >>

Re: [PATCH] Add native windows on arm64 support

2024-01-23 Thread Dave Cramer
On Tue, 19 Sept 2023 at 23:48, Michael Paquier wrote: > On Tue, Sep 19, 2023 at 01:35:17PM +0100, Anthony Roberts wrote: > > Was there an explicit request for something there? I was under the > > impression that this was all just suggestion/theory at the moment. > > Yes. The addition of a

Re: Password leakage avoidance

2024-01-03 Thread Dave Cramer
e > to be using libpq in order to make use of this JDBC has it as of yesterday. I would imagine other clients will implement it. Dave Cramer > >

Re: Password leakage avoidance

2023-12-27 Thread Dave Cramer
On Wed, 27 Dec 2023 at 16:10, Tom Lane wrote: > Joe Conway writes: > > On 12/27/23 15:39, Peter Eisentraut wrote: > >> On 23.12.23 16:13, Joe Conway wrote: > >>> The attached patch set moves the guts of \password from psql into the > >>> libpq client side -- PQchangePassword() (patch 0001). > >

Re: Password leakage avoidance

2023-12-24 Thread Dave Cramer
Dave Cramer www.postgres.rocks On Sat, 23 Dec 2023 at 11:00, Tom Lane wrote: > Joe Conway writes: > > The attached patch set moves the guts of \password from psql into the > > libpq client side -- PQchangePassword() (patch 0001). > > Haven't really read the patch, ju

Re: Emitting JSON to file using COPY TO

2023-12-08 Thread Dave Cramer
On Thu, 7 Dec 2023 at 08:47, David G. Johnston wrote: > On Thursday, December 7, 2023, Daniel Verite > wrote: > >> Joe Conway wrote: >> >> > The attached should fix the CopyOut response to say one column. I.e. it >> > ought to look something like: >> >> Spending more time with the doc I

Re: errors building on windows using meson

2023-12-07 Thread Dave Cramer
On Thu, 7 Dec 2023 at 14:34, Andres Freund wrote: > Hi, > > On 2023-12-07 14:16:52 -0500, Dave Cramer wrote: > > On Thu, 7 Dec 2023 at 13:53, Andres Freund wrote: > > > > > Hi, > > > > > > On 2023-12-07 12:54:27 -0500, Dave Cramer wrote: &

Re: errors building on windows using meson

2023-12-07 Thread Dave Cramer
On Thu, 7 Dec 2023 at 13:53, Andres Freund wrote: > Hi, > > On 2023-12-07 12:54:27 -0500, Dave Cramer wrote: > > state-exec: run failed: cannot create new executor meta: cannot get > > matching bin by path: no matching binary by path > > > "C:\\Users\\Adminis

errors building on windows using meson

2023-12-07 Thread Dave Cramer
se contact support for assistance. anyone seen this or have a fix ? Dave Cramer

Re: building with meson on windows with ssl

2023-11-14 Thread Dave Cramer
On Mon, 13 Nov 2023 at 20:56, Andres Freund wrote: > Hi, > > On 2023-11-12 11:41:15 -0500, Dave Cramer wrote: > > On Sun, 12 Nov 2023 at 07:57, Dave Cramer wrote: > > > I am getting the following error > > > building on HEAD > > > > > > Li

Re: building with meson on windows with ssl

2023-11-12 Thread Dave Cramer
On Sun, 12 Nov 2023 at 07:57, Dave Cramer wrote: > Greetings, > > I am getting the following error > building on HEAD > > Library crypto found: YES > Checking for function "CRYPTO_new_ex_data" with dependencies -lssl, > -lcrypto: NO > So this is the erro

building with meson on windows with ssl

2023-11-12 Thread Dave Cramer
Greetings, I am getting the following error building on HEAD Library crypto found: YES Checking for function "CRYPTO_new_ex_data" with dependencies -lssl, -lcrypto: NO I have openssl 1.1.1 installed Dave Cramer

Re: Protocol question regarding Portal vs Cursor

2023-11-08 Thread Dave Cramer
Dave Cramer On Tue, 7 Nov 2023 at 10:26, Tom Lane wrote: > Dave Cramer writes: > > If we use a Portal it is possible to open the portal and do a describe > and > > then Fetch N records. > > > Using a Cursor we open the cursor. Is there a corresponding describe

Protocol question regarding Portal vs Cursor

2023-11-07 Thread Dave Cramer
ot; and we get the fields and the rows. This seems overly verbose. Dave Cramer

building 32bit windows version

2023-10-12 Thread Dave Cramer
quot; Apparently 32 bit dlls are required. If there is an easier way to get libpq.dll and the include files for building I'm all ears. Dave Cramer

Re: Request for comment on setting binary format output per session

2023-10-10 Thread Dave Cramer
On Tue, 10 Oct 2023 at 10:25, Robert Haas wrote: > On Mon, Oct 9, 2023 at 4:25 PM Jeff Davis wrote: > > Another thing to consider is that using a GUC for binary formats is a > > protocol change in a way that client_encoding is not. The existing > > documentation for the protocol already

Re: Request for comment on setting binary format output per session

2023-10-10 Thread Dave Cramer
On Mon, 9 Oct 2023 at 17:11, Jelte Fennema wrote: > On Mon, 9 Oct 2023 at 21:08, Dave Cramer wrote: > > So if we use . would it be possible to have something like > which represents a set of well known types? > > My goal here is to reduce the overhead of naming all the

Re: Request for comment on setting binary format output per session

2023-10-09 Thread Dave Cramer
On Mon, 9 Oct 2023 at 15:00, Robert Haas wrote: > On Mon, Oct 9, 2023 at 11:09 AM Jelte Fennema wrote: > > Since the protocol already returns OIDs in the ParameterDescription > > and RowDescription messages I don't see why using OIDs for this GUC > > would cause any additional problems. > >

Change of behaviour for creating same type name in multiple schemas

2023-10-05 Thread Dave Cramer
Greetings, Before 16 if I created an array type in schema1 it would be named schema1._array_type if I created the same type in schema 2 it would have been named schema2.__array_type Can someone point me to where the code was changed ? Thanks, Dave Cramer

Re: Request for comment on setting binary format output per session

2023-10-04 Thread Dave Cramer
On Wed, 4 Oct 2023 at 10:17, Peter Eisentraut wrote: > On 31.07.23 18:27, Dave Cramer wrote: > > On Mon, 10 Jul 2023 at 03:56, Daniel Gustafsson > <mailto:dan...@yesql.se>> wrote: > > > > > On 25 Apr 2023, at 16:47, Dave Cramer >

Speaker Bureau

2023-09-01 Thread Dave Cramer
Greetings, If you are on the speaker list can you send an email to ugc...@postgresql.us indicating whether you are available to travel for meetups? This serves the obvious purpose but also provides your email address to us. Thanks, Dave Cramer

Re: PostgreSQL 16 release announcement draft

2023-08-24 Thread Dave Cramer
> > > > Postgres, PostgreSQL, and the Elephant Logo (Slonik) are all registered > > trademarks of the [PostgreSQL Community Association of Canada]( > https://www.postgres.ca). > > Isn't this just the "PostgreSQL Community Association", no Canada? > Certainly confusing from the website, but in the

Re: Using defines for protocol characters

2023-08-17 Thread Dave Cramer
gt; I think this is going to be a major improvement in terms of readability! That was the primary goal > Dave > > -- Dave Cramer

Re: Using defines for protocol characters

2023-08-09 Thread Dave Cramer
On Wed, 9 Aug 2023 at 10:34, Tom Lane wrote: > Dave Cramer writes: > > On Wed, 9 Aug 2023 at 09:19, Peter Eisentraut > wrote: > >> 3. IMO, the names of the protocol messages in protocol.sgml are > >> canonical. Your patch appends "Request" and "R

Re: Using defines for protocol characters

2023-08-09 Thread Dave Cramer
On Wed, 9 Aug 2023 at 09:19, Peter Eisentraut wrote: > 1. As was discussed, these definitions should go into > src/include/libpq/pqcomm.h, not a new file. > I'm ambivalent, this is very easy to do. > > 2. I would prefer an underscore after PgMsg, like PqMsg_DescribeRequest, > so it's easier to

Re: Using defines for protocol characters

2023-08-07 Thread Dave Cramer
On Mon, 7 Aug 2023 at 16:50, Tatsuo Ishii wrote: > > On Mon, Aug 07, 2023 at 04:02:08PM -0400, Tom Lane wrote: > >> Dave Cramer writes: > >>> On Mon, 7 Aug 2023 at 12:59, Robert Haas > wrote: > >>>> PqMsgEmptyQueryResponse or something like

Re: Using defines for protocol characters

2023-08-07 Thread Dave Cramer
On Mon, 7 Aug 2023 at 12:59, Robert Haas wrote: > On Mon, Aug 7, 2023 at 2:25 PM Tom Lane wrote: > > +1. For ease of greppability, maybe even PQMSG_EmptyQueryResponse > > and so on? Then one grep would find both uses of the constants and > > code/docs references. Not sure if the prefix

Re: Using defines for protocol characters

2023-08-07 Thread Dave Cramer
On Mon, 7 Aug 2023 at 03:10, Alvaro Herrera wrote: > On 2023-Aug-07, Peter Smith wrote: > > > I guess, your patch would not be much different; you can still have > > all the nice names and assign the appropriate values to the enum > > values same as now, but using an enum you might also gain > >

Re: Using defines for protocol characters

2023-08-04 Thread Dave Cramer
On Fri, 4 Aug 2023 at 03:44, Alvaro Herrera wrote: > On 2023-Aug-03, Dave Cramer wrote: > > > New patch attached which uses PREPARED_SUB_COMMAND and > > PORTAL_SUB_COMMAND instead > > Hmm, I would keep the prefix in this case and make the message type a > second pr

Re: Using defines for protocol characters

2023-08-03 Thread Dave Cramer
fine CLOSE_PORTAL 'P' > >> > > > > Good catch. > > I recall when writing this it was a bit hacky. > > What do you think of PREPARED_SUB_COMMAND and PORTAL_SUB_COMMAND > instead > > of duplicating them ? > > Nice. Looks good to me. > New patch attached which uses PREPARED_SUB_COMMAND and PORTAL_SUB_COMMAND instead and uses PQMSG_REQ_* and PQMSG_RESP_* as per Alvaro's suggestion Dave Cramer 0001-Created-protocol.h.patch Description: Binary data

Re: Using defines for protocol characters

2023-08-03 Thread Dave Cramer
On Thu, 3 Aug 2023 at 15:22, Dave Cramer wrote: > > > On Thu, 3 Aug 2023 at 13:25, Tatsuo Ishii wrote: > >> > Greetings, >> > >> > Attached is a patch which introduces a file protocol.h. Instead of using >> > the actual characters everywhere

Re: Using defines for protocol characters

2023-08-03 Thread Dave Cramer
On Thu, 3 Aug 2023 at 13:25, Tatsuo Ishii wrote: > > Greetings, > > > > Attached is a patch which introduces a file protocol.h. Instead of using > > the actual characters everywhere in the code this patch names the > > characters and removes the comments beside each usage. > > > +#define

Re: Using defines for protocol characters

2023-08-03 Thread Dave Cramer
On Thu, 3 Aug 2023 at 11:59, Alvaro Herrera wrote: > On 2023-Aug-03, Dave Cramer wrote: > > > Greetings, > > > > Attached is a patch which introduces a file protocol.h. Instead of using > > the actual characters everywhere in the code this patch names the > >

Using defines for protocol characters

2023-08-03 Thread Dave Cramer
Greetings, Attached is a patch which introduces a file protocol.h. Instead of using the actual characters everywhere in the code this patch names the characters and removes the comments beside each usage. Dave Cramer 0001-Created-protocol.h.patch Description: Binary data

Re: Request for comment on setting binary format output per session

2023-07-31 Thread Dave Cramer
Dave Cramer On Mon, 10 Jul 2023 at 03:56, Daniel Gustafsson wrote: > > On 25 Apr 2023, at 16:47, Dave Cramer wrote: > > > Patch attached with comments removed > > This patch no longer applies, please submit a rebased version on top of > HEAD. > Rebased see

Re: CommandStatus from insert returning when using a portal.

2023-07-14 Thread Dave Cramer
On Fri, 14 Jul 2023 at 16:32, wrote: > On 2023-07-14 15:49, Dave Cramer wrote: > > On Fri, 14 Jul 2023 at 15:40, wrote: > >> Perhaps an easy rule would be, if the driver itself adds RETURNING > >> because of a RETURN_GENERATED_KEYS option, it should also force t

Re: CommandStatus from insert returning when using a portal.

2023-07-14 Thread Dave Cramer
On Fri, 14 Jul 2023 at 15:40, wrote: > On 2023-07-14 14:19, David G. Johnston wrote: > > Because of the returning they all need a portal so far as the server is > > concerned and the server will obligingly send the contents of the > > portal > > back to the client. > > Dave's pcap file, for the

Re: CommandStatus from insert returning when using a portal.

2023-07-14 Thread Dave Cramer
On Fri, 14 Jul 2023 at 14:34, wrote: > On 2023-07-12 21:30, David G. Johnston wrote: > > Right, and executeUpdate is the wrong API method to use, in the > > PostgreSQL > > world, when executing insert/update/delete with the non-SQL-standard > > returning clause. ... ISTM that you are trying to

Re: CommandStatus from insert returning when using a portal.

2023-07-14 Thread Dave Cramer
On Fri, 14 Jul 2023 at 13:39, wrote: > On 2023-07-14 12:58, Dave Cramer wrote: > > See attached pcap file > > So if the fetch count is zero and no portal is needed, > or if the fetch count exceeds the row count and the command > completion follows directly with no sus

Re: CommandStatus from insert returning when using a portal.

2023-07-14 Thread Dave Cramer
See attached pcap file after the execute of the portal it returns INSERT 0 0 Dave Cramer On Fri, 14 Jul 2023 at 12:57, David G. Johnston wrote: > On Fri, Jul 14, 2023 at 9:50 AM David G. Johnston < > david.g.johns...@gmail.com> wrote: > >> >> Fixing that test in

Re: CommandStatus from insert returning when using a portal.

2023-07-14 Thread Dave Cramer
ecuteUpdate result: " + ret); var rs = stmt.getGeneratedKeys(); System.out.print("ids: "); while (rs.next()) { System.out.print(rs.getInt(1) + " "); } System.out.print("\n\n"); } } Dave On Fri, 14 Jul 2023 a

Re: CommandStatus from insert returning when using a portal.

2023-07-13 Thread Dave Cramer
On Thu, 13 Jul 2023 at 10:24, David G. Johnston wrote: > On Thursday, July 13, 2023, Dave Cramer wrote: > >> >> Any comment on why the CommandComplete is incorrect ? >> It returns INSERT 0 0 if a cursor is used >> > > Looking at DECLARE it is surpr

Re: CommandStatus from insert returning when using a portal.

2023-07-13 Thread Dave Cramer
On Wed, 12 Jul 2023 at 21:31, David G. Johnston wrote: > On Wed, Jul 12, 2023 at 5:57 PM Dave Cramer wrote: > >> On Wed, 12 Jul 2023 at 20:00, wrote: >> >>> Dave Cramer writes: >>> > Obviously I am biased by the JDBC API which would like to have &

Re: CommandStatus from insert returning when using a portal.

2023-07-12 Thread Dave Cramer
On Wed, 12 Jul 2023 at 20:00, wrote: > Dave Cramer writes: > > Obviously I am biased by the JDBC API which would like to have > > PreparedStatement.execute() return the number of rows inserted > > without having to wait to read all of the rows returned

Re: CommandStatus from insert returning when using a portal.

2023-07-12 Thread Dave Cramer
On Wed, 12 Jul 2023 at 17:49, Tom Lane wrote: > Dave Cramer writes: > > Obviously I am biased by the JDBC API which would like to have > > PreparedStatement.execute() return the number of rows inserted > > without having to wait to read all of the rows returned >

Re: CommandStatus from insert returning when using a portal.

2023-07-12 Thread Dave Cramer
Dave Cramer On Wed, 12 Jul 2023 at 16:31, David G. Johnston wrote: > On Wed, Jul 12, 2023 at 1:03 PM Dave Cramer wrote: > >> >> INSERT INTO test_table (cnt) VALUES (1), (2) RETURNING id >> >> if a portal is used to get the results then the CommandStatus >>

CommandStatus from insert returning when using a portal.

2023-07-12 Thread Dave Cramer
without having to wait to read all of the rows returned Dave Cramer

Re: Why is DATESTYLE, ordering ignored for output but used for input ?

2023-07-04 Thread Dave Cramer
On Mon, 3 Jul 2023 at 17:13, Matthias van de Meent < boekewurm+postg...@gmail.com> wrote: > On Mon, 3 Jul 2023 at 20:06, Dave Cramer wrote: > > > > Greetings, > > > > For ISO and German dates the order DMY is completely ignored on output > but used for input.

Why is DATESTYLE, ordering ignored for output but used for input ?

2023-07-03 Thread Dave Cramer
; date 2023-07-08 (1 row) Note regardless of how the ordering is specified it is always output as YMD Dave Cramer

Re: Let's make PostgreSQL multi-threaded

2023-06-10 Thread Dave Cramer
On Fri, 9 Jun 2023 at 18:29, Stephen Frost wrote: > Greetings, > > * Dave Cramer (davecramer@postgres.rocks) wrote: > > One thing I can think of is upgrading. AFAIK dump and restore is the only > > way to change the on disk format. > > Presuming that eventually

Re: Let's make PostgreSQL multi-threaded

2023-06-09 Thread Dave Cramer
This is somewhat orthogonal to the topic of threading but relevant to the use of resources. If we are going to undertake some hard problems perhaps we should be looking at other problems that solve other long term issues before we commit to spending resources on changing the process model. One

Re: Let's make PostgreSQL multi-threaded

2023-06-08 Thread Dave Cramer
On Thu, 8 Jun 2023 at 13:08, Hannu Krosing wrote: > I discovered this thread from a Twitter post "PostgreSQL will finally > be rewritten in Rust" :) > By the time we got around to finishing this, there would be a better language to write it in. Dave

Re: Named Prepared statement problems and possible solutions

2023-06-08 Thread Dave Cramer
On Thu, 8 Jun 2023 at 15:49, Jan Wieck wrote: > On 6/8/23 13:31, Dave Cramer wrote: > > > > On Thu, 8 Jun 2023 at 11:22, Konstantin Knizhnik > <mailto:knizh...@garret.ru>> wrote: > > > > > So it will be responsibility of client to remember text of p

Re: Named Prepared statement problems and possible solutions

2023-06-08 Thread Dave Cramer
On Thu, 8 Jun 2023 at 11:22, Konstantin Knizhnik wrote: > > > On 08.06.2023 6:18 PM, Dave Cramer wrote: > > > > On Thu, 8 Jun 2023 at 11:15, Jan Wieck wrote: > >> On 6/8/23 10:56, Dave Cramer wrote: >> > >> > >> > >> > >&

Re: Named Prepared statement problems and possible solutions

2023-06-08 Thread Dave Cramer
On Thu, 8 Jun 2023 at 11:15, Jan Wieck wrote: > On 6/8/23 10:56, Dave Cramer wrote: > > > > > > > > > > On Thu, 8 Jun 2023 at 10:31, Jan Wieck > <mailto:j...@wi3ck.info>> wrote: > > > > On 6/8/23 09:53, Jan Wieck wrote: > >

Re: Named Prepared statement problems and possible solutions

2023-06-08 Thread Dave Cramer
On Thu, 8 Jun 2023 at 10:31, Jan Wieck wrote: > On 6/8/23 09:53, Jan Wieck wrote: > > On 6/8/23 09:21, Dave Cramer wrote: > > The server doesn't know about all the clients of the pooler, does it? It > > has no way of telling if/when a client disconnects from the pooler

Re: Named Prepared statement problems and possible solutions

2023-06-08 Thread Dave Cramer
On Thu, 8 Jun 2023 at 09:53, Jan Wieck wrote: > On 6/8/23 09:21, Dave Cramer wrote: > > > > > > On Thu, Jun 8, 2023 at 8:43 AM Jan Wieck > <mailto:j...@wi3ck.info>> wrote: > > > > On 6/8/23 02:15, Konstantin Knizhnik wrote: > > > >

Re: Named Prepared statement problems and possible solutions

2023-06-08 Thread Dave Cramer
welcome. > > I was about to say that the support would have to come from the pooler > as it is possible to have multiple applications in different languages > connecting to the same pool(s). Why from the pooler? If it were done at the server every client could use it? > > Dave > > -- Dave Cramer

Re: Named Prepared statement problems and possible solutions

2023-06-08 Thread Dave Cramer
Hi Konstantin, Yes, I ran into Euler at pgcon and he mentioned this. I intend to test it. I'd still like to see my proposal in the server. Dave Cramer On Thu, 8 Jun 2023 at 02:15, Konstantin Knizhnik wrote: > > > On 07.06.2023 10:48 PM, Dave Cramer wrote: > > Greetings, &g

  1   2   3   4   >