Hi,
Anyone else already volunteers that? It is my first time so need some
access, if all agree.
On Mon, Feb 1, 2021 at 10:17 PM Ibrar Ahmed wrote:
> As Commitfest 2021-01 is now closed. I am volunteering to manage next
> commitfest.
>
>
> --
> Ibrar Ahmed
>
--
Ibrar Ahmed
As Commitfest 2021-01 is now closed. I am volunteering to manage next
commitfest.
--
Ibrar Ahmed
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: tested, failed
Documentation:not tested
I am not very convinced to have that, but I have performed some testing o
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Thanks for the patch. The patch works on my machine as per specs
On Thu, Aug 27, 2020 at 2:14 AM Anastasia Lubennikova <
a.lubennik...@postgrespro.ru> wrote:
> On 21.08.2020 19:43, Ibrar Ahmed wrote:
>
>
>
> On Wed, Aug 19, 2020 at 6:15 PM Anastasia Lubennikova <
> a.lubennik...@postgrespro.ru> wrote:
>
>> On 18.08.20
On Wed, Aug 19, 2020 at 6:15 PM Anastasia Lubennikova <
a.lubennik...@postgrespro.ru> wrote:
> On 18.08.2020 02:54, Alvaro Herrera wrote:
> > On 2020-Aug-14, Ibrar Ahmed wrote:
> >
> >> The table used for the test contains three columns (integer, text,
> >>
On Mon, Aug 17, 2020 at 2:19 PM Hamid Akhtar wrote:
> Unfortunately the latest patch doesn't apply cleanly on the master branch.
> Can you please share an updated one.
Please see the attached patch rebased with master (
a28d731a1187e8d9d8c2b6319375fcbf0a8debd5)
--
Ibrar Ahmed
ains three columns (integer, text,
varchar).
The total number of rows is 1000 in total.
Unpatched (Master: 92c12e46d5f1e25fc85608a6d6a19b8f5ea02600)
COPY: 9069.432 ms vacuum; 2567.961ms
COPY: 9004.533 ms vacuum: 2553.075ms
COPY: 8832.422 ms vacuum: 2540.742ms
Patched (Master: 92c12e46d5f1e25fc85608a6d6a19b8f5ea02600)
COPY: 10031.723 ms vacuum: 127.524 ms
COPY: 9985.109 ms vacuum: 39.953 ms
COPY: 9283.373 ms vacuum: 37.137 ms
Time to take the copy slightly increased but the vacuum time significantly
decrease.
--
Ibrar Ahmed
On Mon, Mar 16, 2020 at 6:35 PM David Steele wrote:
> On 1/28/20 1:36 PM, Ibrar Ahmed wrote:
> > On Wed, Jan 22, 2020 at 11:17 AM k.jami...@fujitsu.com
> > I might have missed something more,
> >
> > but I'll continue reviewing after the rebased patc
On Tue, Mar 24, 2020 at 10:06 PM Ibrar Ahmed wrote:
>
>
> On Fri, Mar 13, 2020 at 6:58 AM Justin Pryzby
> wrote:
>
>>
>> Thanks for picking up this patch. There's a minor typo:
>>
>> +* readable outside of this sessoin. There
anks, please see the updated and rebased patch. (master
17a28b03645e27d73bf69a95d7569b61e58f06eb)
--
Ibrar Ahmed
diff --git a/contrib/pg_visibility/expected/pg_visibility.out b/contrib/pg_visibility/expected/pg_visibility.out
index f0dcb897c4..6ac3e525eb 100644
--- a/contrib/pg_visibility/expected
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
I tested the patch on the master branch
(a77315fdf2a197a925e670b
On Thu, Mar 5, 2020 at 11:38 PM Alvaro Herrera
wrote:
> On 2020-Mar-05, Ibrar Ahmed wrote:
>
> > Is this intentional that there is no error when removing a non-existing
> > dependency?
>
> Hmm, I think we can do nothing silently if nothing is called for.
> So, yes,
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
It works for me
On Mon, Mar 2, 2020 at 12:45 PM Ahsan Hadi wrote:
>
>
> On Sat, Feb 29, 2020 at 2:38 AM Alvaro Herrera
> wrote:
>
>> On 2020-Feb-28, ahsan hadi wrote:
>>
>>
>> > Tested the pg_dump patch for dumping "ALTER .. DEPENDS ON EXTENSION" in
>> case of indexes, functions, triggers etc. The "ALTER .. DEP
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: not tested
Documentation:not tested
Please fix the regression test cases.
The new status of this patch i
we need that for plain inserts?
2 - Andres: I think we should remove the WAL logging from
visibilitymap_set(), and
move it to a separate, heap specific, function. Right now different
tableams e.g. would have to reimplement visibilitymap_set(), so that's a
second need to separate that functionality. Let me try to come up with
a proposal.
--
Ibrar Ahmed
0003-copy-freeze-should-actually-freeze-right.patch
Description: Binary data
t I'll continue reviewing after the rebased patch.
>
>
>
> Regards,
>
> Kirk Jamison
>
>
>
> [1]
> https://www.postgresql.org/message-id/flat/CAGTBQpbDCaR6vv9%3DscXzuT8fSbckf%3Da3NgZdWFWZbdVugVht6Q%40mail.gmail.com
>
Hi,
Yes, I am working on that. I will send the rebased and updated patch.
--
Ibrar Ahmed
her hand yet, but let's see. If you take care
> of it, that would be great. Thanks!
> --
> Michael
> I want to be this time. This is my first time doing this.
--
Ibrar Ahmed
user of the KMS and pgcrypto can be more
> powerful with the KMS. I'll register this KMS patch to the next Commit
> Fest.
>
> It is already there "KMS - Internal key management system" (
https://commitfest.postgresql.org/26/2196/).
I really appreciate peoples (CC-ing) who participated in off-list
> discussion/meeting for many inputs, suggestions and reviewing codes.
>
> Regards,
>
>
> --
> Masahiko Sawada http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
--
Ibrar Ahmed
On Wed, Dec 11, 2019 at 9:29 PM Ibrar Ahmed wrote:
>
>
> On Wed, Dec 11, 2019 at 7:29 PM Robert Haas wrote:
>
>> On Mon, Dec 9, 2019 at 2:02 PM Ibrar Ahmed wrote:
>> >> Did you see this thread?
>> >>
>> https://postgr.es/m/CAGTBQpbDCaR6vv9=s
On Wed, Dec 11, 2019 at 7:29 PM Robert Haas wrote:
> On Mon, Dec 9, 2019 at 2:02 PM Ibrar Ahmed wrote:
> >> Did you see this thread?
> >>
> https://postgr.es/m/CAGTBQpbDCaR6vv9=scXzuT8fSbckf=a3ngzdwfwzbdvugvh...@mail.gmail.com
> >>
> > Yes, and somehow di
You are checking file->dirty twice, first before calling the function and
within the function too. Same for the Assert. For example.
size_t
BufFileRead(BufFile *file, void *ptr, size_t size)
{
size_t nread = 0;
size_t nthistime;
if (file->dirty)
{
BufFi
On Mon, Dec 9, 2019 at 11:54 PM Alvaro Herrera
wrote:
> On 2019-Dec-09, Ibrar Ahmed wrote:
>
> > Hi,
> >
> > The memory consumption of VACUUM has some issues and could be improved.
> > Some of its limitations are recorded in the comments of the
> “vacuumlazy.c
creates an array of ItemPointers and allocates
memory in chunks by dividing the maintenance_work_mem into multiple chunks.
Comments?
--
Ibrar Ahmed
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c
index a3c4a1df3b..73922a2e34 100644
--- a/src/backend/access
was on the 1st of November of course.
> --
> Michael
>
--
Ibrar Ahmed
On Fri, Nov 1, 2019 at 8:00 AM Fujii Masao wrote:
> On Fri, Nov 1, 2019 at 6:34 AM Ibrar Ahmed wrote:
> >
> >
> >
> > On Thu, Oct 31, 2019 at 6:56 PM Tom Lane wrote:
> >>
> >> Fujii Masao writes:
> >> > ... I found that the command tag
IZED VIEW mv RENAME COLUMN a to r;
ALTER TABLE
Attached patch fixes that for ALTER VIEW , ALTER MATERIALIZED VIEW and
ALTER FOREIGN TABLE
# ALTER MATERIALIZED VIEW mv RENAME COLUMN a to r;
ALTER MATERIALIZED VIEW
# ALTER FOREIGN TABLE ft RENAME COLUMN a to t;
ALTER FOREIGN TABLE
--
Ibrar Ahmed
001_alter_tag_ibrar_v1.patch
Description: Binary data
of windows.
Hmm, need to remove the assert in the function
"setup_cancel_handler"
-- Ibrar Ahmed
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Patch looks to me and works on my machine
73025140885c889410b9bf
7 Support, Remote DBA, Training & Services
>
>
>
I have updated the patch using OIDs > 8000
--
Ibrar Ahmed
v4-0001-Add-RESUME-option-to-VACUUM-and-autovacuum.patch
Description: Binary data
once this bug
> is fixed. I have also checked other calls of this API and the
> handling is done correctly.
>
> The patch works for me on master and on 12. I have rebased the patch for
Version 11.
> Wyatt, what do you think?
> --
> Michael
>
--
Ibrar Ahmed
diff --git a/src/backe
On Thu, Oct 31, 2019 at 5:28 PM Ibrar Ahmed wrote:
>
>
> On Thu, Oct 31, 2019 at 5:11 PM Ibrar Ahmed wrote:
>
>>
>>
>> On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao
>> wrote:
>>
>>> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed
>>> wro
On Thu, Oct 31, 2019 at 5:11 PM Ibrar Ahmed wrote:
>
>
> On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao wrote:
>
>> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed
>> wrote:
>> >
>> >
>> >
>> > On Thu, Oct 31, 2019 at 12:32 PM Fujii Masa
On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao wrote:
> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed wrote:
> >
> >
> >
> > On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao
> wrote:
> >>
> >> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote:
> >>
P COLUMN might be
> necessary to alleviate that situation.
>
>
- Is this intentional not implemented the "RENAME COLUMN" statement for
VIEW because it is implemented for Materialized View? I have made just a
similar
change to view and it works.
ALTER
, Hamid Akhtar is
also working with me on this
work.
--
Ibrar Ahmed
les or one
TAR file per thread. I really want to have a single tar file because the
main purpose of the TAR file is to
reduce the management of multiple files, but in case of one file per
thread, we end up with many tar
files. Therefore we need to have one master thread which is responsible for
writing on tar file and all
the other threads will receive the data from the network and stream to the
master thread. This also
supports the idea of using a thread-based model rather than a process-based
approach because it
requires too much data sharing between processes. If we cannot achieve
this, then we can disable the
TAR option for parallel backup in the first version.
- In the case of data sharing, we need to try to avoid unnecessary locking
and more suitable algorithm to
solve the reader-writer problem is required.
--
Ibrar Ahmed
le command.
>
What about have an API to get the single file or list of files? We will use
a single file in
our application and other tools can get the benefit of list of files.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
--
Ibrar Ahmed
:ltree;
> ltree
> ---
> a
> (1 row)
>
>
> 2. '*{a}.*{b}.*{c}' is not equivalent to '*{a+b+c}' (as I expect):
>
> SELECT ltree '1.2' ~ '*{2}';
> ?column?
> --
> t
> (1 row)
>
> -- expected true
> SELECT ltree '1.2' ~ '*{1}.*{1}';
> ?column?
> --
> f
> (1 row)
>
>
> Maybe these two bugs need a separate thread?
>
>
> Please create separate commitfest entry.
> --
> Nikita Glukhov
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
>
>
>
--
Ibrar Ahmed
Please create separate commitfest entry.
n │ 1
>
> Thanks,
>
> I think it is a lot of work if you want I can help with that. (Just start
getting your messages on threads)
> --
> Álvaro Herrerahttps://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
>
>
--
Ibrar Ahmed
?
>
> Yes, it is related to that, but we don't have that on our agenda in a
weekly meeting. It has
many conflicting points about what we are doing. Swada / Bruce can comment
on that.
> --
> Álvaro Herrerahttps://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
>
>
--
Ibrar Ahmed
already a pretty high barrier at a lot
of organizations,it requires a shared_preload_libraries setting,
which is pretty close to untenable in a lot of use cases.
We are thinking to move a module in core just because of
"barrier for turning it on is quite high" which is not a very compelling
reason. I am just thinking
why not have a system which makes that easy instead of adding to core.
--
Ibrar Ahmed
On Tue, Sep 3, 2019 at 7:39 PM Robert Haas wrote:
> On Tue, Sep 3, 2019 at 10:05 AM Ibrar Ahmed wrote:
> > +1 using the library to tar. But I think reason not using tar library is
> TAR is
> > one of the most simple file format. What is the best/newest format of
> TAR?
&
On Tue, Sep 3, 2019 at 8:00 PM Tom Lane wrote:
> Ibrar Ahmed writes:
> > +1 using the library to tar.
>
> Uh, *what* library?
>
I was just replying the Robert that he said
"But I think there must be a reason why tar libraries exist,
and I don't want to write a new
On Tue, Sep 3, 2019 at 6:00 PM Robert Haas wrote:
> On Sat, Aug 31, 2019 at 3:41 PM Ibrar Ahmed wrote:
> > Are we using any tar library in pg_basebackup.c? We already have the
> capability
> > in pg_basebackup to do that.
>
> I think pg_basebackup is using homebrew co
the
capability
in pg_basebackup to do that.
> I don't
> think it's worth doing that at this point; I definitely don't think it
> needs to be part of the first patch.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
--
Ibrar Ahmed
gt;
Hi,
I think its a user request and don't require to be in the core of
PostgreSQL.
A simple SQL function can fulfill the requirement of the user.
CREATE OR REPLACE FUNCTION pg_get_databasebyid(dboid integer) RETURNS name
AS $$
SELECT datname from pg_database WHERE oid = dboid;
$$ LANGUAGE SQL;
--
Ibrar Ahmed
m just curious why we need that "pg_get_databasebyid"
function. Is there a need for this function for the user?
--
Ibrar Ahmed
egards, Sergei
Please add that to commitfest.
--
Ibrar Ahmed
On Mon, Aug 26, 2019 at 9:46 AM Michael Paquier wrote:
> On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote:
> > I did some searching, and oid2name.c is also missing this.
>
> And pgbench, no?
>
Yes, the patch is slightly different.
> --
> Michael
&g
es it match the behavior of other
> > > PostgreSQL programs.
> >
> > +1 ... are we missing this anywhere else?
>
> I did some searching, and oid2name.c is also missing this.
>
> Yes, "oid2name" missing that check too.
--
Ibrar Ahmed
0001-oid2name-Error-out-on-too-many-command-line-argume.patch
Description: Binary data
coverage can be seen in the before and after
> pictures of GCOV test coverage analysis summary.
>
> The attached patch contain the test cases added in regression for
> increasing the coverage.
>
>
> --
> Movead Li
>
Hi Movead,
Please add that to commitfest.
--
Ibrar Ahmed
nd possibly
> encryption, and so it'd likely make sense to just have independent
> processes and connections through which to do that.
>
> +1 for compression and encryption, but I think parallelism will give us
the benefit with and without the compression.
Thanks,
>
> Stephen
>
--
Ibrar Ahmed
u can have some
worker threads.
But before doing that need to see the pg_basebackup bottleneck, after that,
we
can see what is the best way to solve that. Some numbers may help to
understand the
actual benefit.
--
Ibrar Ahmed
ows=0 loops=1)
Workers Planned: 2
Workers Launched: 2
-> Parallel Seq Scan on test (cost=0.00..97294.74 rows=1 width=8)
(actual time=1616.000..1616.000 rows=0 loops=3)
Filter: (b > 1)
Rows Removed by Filter: 337
Planning Time: 0.699 ms
Execution Time: 1622.325 ms
(8 rows)
--
Ibrar Ahmed
nCacheRelCallback and
> PlanCacheObjectCallback a bit so when a CachedPlanSource is invalidated
> the query_list is not only marked as invalid but it is also fully
> released to free memory here.
>
> Regards,
> Daniel Migowski
>
> PS@Konstantin: This patch also includes the CachedPlanMemoryUsage
> function you like, maybe you like the review the patch for me?
>
>
--
Ibrar Ahmed
t group are
moon_insung...@lab.ntt.co.jp,
sawada.m...@gmail.com,
shawn.w...@highgo.ca,
ahsan.h...@highgo.ca,
ibrar.ah...@gmail.com
I am able to do that for others as well.
>
> --
> Bruce Momjian http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + As you are, so once was I. As I am, so you will be. +
> + Ancient Roman grave inscription +
>
--
Ibrar Ahmed
On Fri, Aug 16, 2019 at 4:12 PM Ibrar Ahmed wrote:
>
>
>
>
> On Fri, Aug 16, 2019 at 3:24 PM Jeevan Chalke <
> jeevan.cha...@enterprisedb.com> wrote:
>
>>
>>
>> On Fri, Aug 2, 2019 at 6:43 PM vignesh C wrote:
>>
>>> Some comments:
>
need a consensus on that. Do we really need
that
feature or not. In the previous discussion, there was no resistance to have
that
in PostgreSQL, but some problem with the patch. Current patch is very simple
and not invasive, but still, we need a consensus on that.
Along with users, I request some senior hackers/committers to also
> weigh in about the desirability of this feature.
>
> --
> With Regards,
> Amit Kapila.
> EnterpriseDB: http://www.enterprisedb.com
>
>
>
--
Ibrar Ahmed
bles/indexes key and a WAL key, plus keys for
> rotation. I explained why per-tablespace keys don't add much value.
>
> --
> Bruce Momjian http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + As you are, so once was I. As I am, so you will be. +
> + Ancient Roman grave inscription +
>
--
Ibrar Ahmed
p://www.enterprisedb.com
>>
>
>
> Attached new sets of patches with refactoring done separately.
> Incremental backup patch became small now and hopefully more
> readable than the first version.
>
> --
> Jeevan Chalke
> Technical Architect, Product Development
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
+ buf = (char *) malloc(statbuf->st_size);
+ if (buf == NULL)
+ ereport(ERROR,
+ (errcode(ERRCODE_OUT_OF_MEMORY),
+errmsg("out of memory")));
Why are you using malloc, you can use palloc here.
--
Ibrar Ahmed
ould greatly increase IO cost which could attribute to the problem.
> However, I am really not sure what UNION ALL actually does to append both
> result sets so I was wondering if someone would be able to help me out with
> this.
>
>
>
>
> Mark
>
>
> 066ce...@free.fr: Please, avoid top-posting. It makes harder to follow
the
discussion.
--
Ibrar Ahmed
Patch conflict with this assertion
Assert(pstate->p_expr_kind == EXPR_KIND_UPDATE_SOURCE);
src/backend/parser/parse_expr.c line 1570
The new status of this patch is: Waiting on Author
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
The patch passed my review, I have not reviewed the documentation
NSERT INTO test VALUES(:two,0,0);
> > [...]
> > client 0 script 0 aborted in command 1 query 0: ERROR: syntax error at
> or near ":"
>
> Indeed, the user should test whether the variable was assigned before
> using it if the result is not warranted to return one row.
>
> > The new status of this patch is: Waiting on Author
>
> The attached patch implements the altered behavior described above.
>
> --
> Fabien.
--
Ibrar Ahmed
;
+1 for using fopen(), fread(), fwrite(), and fclose()
> Let me know if we still want to go with native OS calls.
>
>
-1 for OS call
>
>> --
>> Robert Haas
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Jeevan Chalke
> Technical Architect, Product Development
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
--
Ibrar Ahmed
On Fri, Aug 9, 2019 at 1:25 AM Mark G wrote:
>
>
> On Thu, Aug 8, 2019 at 8:25 PM Ibrar Ahmed wrote:
>
>> +1
>>
>> Patch successfully applied to the master (
>> 43211c2a02f39d6568496168413dc00e0399dc2e)
>>
>
> That change looks like an unrelated p
+1
Patch successfully applied to the master (
43211c2a02f39d6568496168413dc00e0399dc2e)
On Thu, Aug 8, 2019 at 12:30 PM Mark G wrote:
> Hello all,
>
> Please find attached a trivial patch making a few arrays const (in
> addition to the data they point to).
>
>
>
--
Ibrar Ahmed
macros.
>
> +1
>
> regards, tom lane
>
>
>
--
Ibrar Ahmed
initdb-print_v2.patch
Description: Binary data
ead the whole 1GB into Ram.
>
>> --
>> Robert Haas
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Jeevan Chalke
> Technical Architect, Product Development
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
--
Ibrar Ahmed
On Tue, Aug 6, 2019 at 11:31 PM Ibrar Ahmed wrote:
>
> I have not looked at the patch in detail, but just some nits from my side.
>
> On Fri, Aug 2, 2019 at 6:13 PM vignesh C wrote:
>
>> On Thu, Aug 1, 2019 at 5:06 PM Jeevan Chalke
>> wrote:
>> >
>>
s opinion on this.
>
> 9)
> + printf(_(" -i, --incr-backup=DIRECTORY incremental backup directory
> (maximum %d)\n"), MAX_INCR_BK_COUNT);
> + printf(_(" -o, --output-dir=DIRECTORY combine backup into
> directory\n"));
> + printf(_("\nGeneral options:\n"));
> + printf(_(" -n, --no-clean do not clean up after
> errors\n"));
>
> Combine backup into directory can be combine backup directory
>
> 10)
> +/* Max number of incremental backups to be combined. */
> +#define MAX_INCR_BK_COUNT 10
> +
> +/* magic number in incremental backup's .partial file */
>
> MAX_INCR_BK_COUNT can be increased little, some applications use 1
> full backup at the beginning of the month and use 30 incremental
> backups rest of the days in the month
>
> Regards,
> Vignesh
> EnterpriseDB: http://www.enterprisedb.com
>
>
>
--
Ibrar Ahmed
On Tue, Aug 6, 2019 at 8:28 PM Paul Jungwirth
wrote:
> Hi Ibrar,
>
> On 8/6/19 3:26 AM, Ibrar Ahmed wrote:
> > - Why we are not allowing any other datatype other than ranges in the
> > primary key. Without that there is no purpose of a primary key.
>
> A temporal prim
Hi Paul,
On Mon, Aug 5, 2019 at 3:11 AM Paul A Jungwirth
wrote:
> On Fri, Aug 2, 2019 at 1:49 PM Ibrar Ahmed wrote:
> > I did some clean-up on this patch. I have also refactored a small
> portion of the code
> > to reduce the footprint of the patch. For simplicity, I have d
Hi,
I have rebased the patch and currently reviewing the patch
on master (1e2fddfa33d3c7cc93ca3ee0f32852699bd3e012).
On Mon, Jul 1, 2019 at 4:45 PM Thomas Munro wrote:
> On Wed, Apr 3, 2019 at 2:12 AM Ibrar Ahmed wrote:
> > I start looking at the patch, there is a couple of prob
The patch does not work.
postgres=# CREATE TABLE foo (id int,r int4range, valid_at tsrange, CONSTRAINT
bar_pk PRIMARY KEY (r, valid_at WITHOUT OVERLAPS));
CREATE TABLE
postgres=# CREATE TABLE bar (id int,r int4range, valid_at tsrange, CONSTRAINT
bar_fk FOREIGN KEY (r, PERIOD valid_at) REFERENCES
mat.
> > I implemented the simplest one, while there are more ideas:
>
> I think we should start simple.
>
> I haven't had a chance to look at Jeevan's patch at all, or yours in
> any detail, as yet, so these are just some very preliminary comments.
> It will be good, however, if we can agree on who is going to do what
> part of this as we try to drive this forward together. I'm sorry that
> I didn't communicate EDB's plans to work on this more clearly;
> duplicated effort serves nobody well.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
--
Ibrar Ahmed
Hi Paul,
I have rebased the patch to master (1e2fddfa33d3c7cc93ca3ee0f32852699bd3e012)
and fixed some compilation warning. Now I am reviewing the actual code.
On Fri, Jul 26, 2019 at 6:35 PM Ibrar Ahmed wrote:
> The patch requires to rebase on the master branch.
>
> The new statu
The patch requires to rebase on the master branch.
The new status of this patch is: Waiting on Author
On Wed, Jul 17, 2019 at 6:43 PM Jeevan Chalke <
jeevan.cha...@enterprisedb.com> wrote:
> On Wed, Jul 17, 2019 at 2:15 PM Ibrar Ahmed wrote:
>
>>
>> At what stage you will apply the WAL generated in between the START/STOP
>> backup.
>>
>
> In this design
r
> information.
>
> 3. Now, we can write the output file - reading each block in turn from the
> correct backup and writing it to the write output file, using the map we
> constructed in the previous step. We should probably keep all of the input
> files open over steps 2 and 3 and then close them at the end because
> repeatedly closing and opening them is going to be expensive. When that's
> done,
> go on to the next file and start over at step 1.
>
>
> At what stage you will apply the WAL generated in between the START/STOP
backup.
> We are already started working on this design.
>
> --
> Jeevan Chalke
> Technical Architect, Product Development
> EnterpriseDB Corporation
>
>
--
Ibrar Ahmed
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Other than that, the patch looks good to me.
The new status of t
> SELECT 1 AS one \;
> SELECT 2 AS two UNION SELECT 2 \;
> SELECT 3 AS three \aset
>
> will set both "one" and "three", while "two" is not set because there were
> two rows. It is a kind of more permissive \gset.
Are you sure two is not set :)?
SELECT 2 AS two UNION SELECT 2; -- only return
Does both client/server side data generation in a single command make sense?
Now the patch is good now.
The new status of this patch is: Ready for Committer
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Patch looks good to me, and work fine on my machine. One mino
On Wed, Apr 24, 2019 at 1:15 AM Tom Lane wrote:
> Ibrar Ahmed writes:
> > I am working on an FDW where the database does not support any operator
> > other than "=" in JOIN condition. Some queries are genrating the plan
> with
> > JOIN having "<"
r2.o_custkey)) AND
((r2.o_orderdate < '1995-03-22')) AND ((r1.c_mktsegment = 'BUILDING')))
ORDER BY r2.o_orderkey, r2.o_orderdate, r2.o_shippriority
...
--
Ibrar Ahmed
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Patch works fine on my machine.
The new status of this patch is:
On Thu, Apr 11, 2019 at 2:44 PM Erikjan Rijkers wrote:
>
> On 2019-04-11 11:36, Ibrar Ahmed wrote:
> > Hi,
> >
> > Is it possible to have commit-message or at least git hash in
> > commitfest. It will be very easy to track commit against commitfest
> > item.
&
Hi,
Is it possible to have commit-message or at least git hash in
commitfest. It will be very easy to track commit against commitfest
item.
--
Ibrar Ahmed
ed to be consistent.
> And why not "drop tables" and "create tables"
>
> The new status of this patch is: Waiting on Author
--
Ibrar Ahmed
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Please ignore the last email.
Patch works perfectly and the code
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation:not tested
Patch works perfectly and the code is well-written. I have one mi
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
The feature works fine on my machine. The code is well-written.
gt;pid, SIGTERM);
On Tue, Apr 9, 2019 at 3:06 PM Ibrar Ahmed wrote:
>
> Is this the intended behavior? SIGTERM is received.
>
> test=# begin;
> BEGIN
> test=# create table test(a int);
> CREATE TABLE
>
>
> In another terminal drop the database.
>
> test=# begin;
>
Is this the intended behavior? SIGTERM is received.
test=# begin;
BEGIN
test=# create table test(a int);
CREATE TABLE
In another terminal drop the database.
test=# begin;
psql: FATAL: terminating connection due to administrator command
server closed the connection unexpectedly
This pro
I start looking at the patch, there is a couple of problems with the patch. The
first one is the OID conflict, which I fixed on my machine. The second problem
is assertion failure. I think you have not compiled the PostgreSQL code with
the assertion.
...
postgres=# SELECT *
FROM (projects p1 N
101 - 200 of 214 matches
Mail list logo
