Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions

2025-11-19 Thread Sugamoto Shinya
Thanks everyone for reviewing my proposal. Please let me know if you have something to discuss here. 2025年11月19日(水) 0:31 Nathan Bossart : > On Wed, Nov 19, 2025 at 12:20:34AM +0900, Sugamoto Shinya wrote: > > On Tue, Nov 18, 2025 at 1:07 PM Fujii Masao > wrote: > >> Is

Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions

2025-11-18 Thread Sugamoto Shinya
On Tue, Nov 18, 2025 at 1:07 PM Fujii Masao wrote: > On Tue, Nov 18, 2025 at 5:34 AM Masahiko Sawada > wrote: > > > > On Mon, Nov 17, 2025 at 8:44 AM Nathan Bossart > wrote: > > > > > > On Mon, Nov 17, 2025 at 04:04:17PM +0100, Daniel Gustafsson wrote: > > > > Oh right, I had forgotten about th

Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions

2025-11-17 Thread Sugamoto Shinya
On Thu, Nov 13, 2025 at 9:58 AM Fujii Masao wrote: > On Wed, Nov 12, 2025 at 10:23 PM Sugamoto Shinya > wrote: > > Thanks everyone for reviewing my proposal. > > I've hard-coded the valid list of encoding names. > > > > Also, I modified the hint string i

Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions

2025-11-12 Thread Sugamoto Shinya
On Wed, Nov 12, 2025 at 10:56 AM Fujii Masao wrote: > On Wed, Nov 12, 2025 at 10:10 AM Masahiko Sawada > wrote: > > +1 for hard-coding the supported encoding list. I think it's a good > > start point. We can revisit the idea of dynamically constructing the > > encoding list if we're concerned ab

Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions

2025-11-11 Thread Sugamoto Shinya
into hint texts (as Fujii pointed out), and - this approach does not violate our coding rules or make the code harder to understand, I tend to think that it’s acceptable to hard-code the list of possible encodings in the hint this time. Thoughts? Regards, On Tue, Nov 11, 2025 at 3:14 PM

[PATCH] Add hints for invalid binary encoding names in encode/decode functions

2025-11-07 Thread Sugamoto Shinya
Hi, When users pass an invalid encoding name to the built-in functions `encode()` or `decode()`, PostgreSQL currently reports only: ERROR: unrecognized encoding: "xxx" This patch adds an error hint listing the valid encoding names, so users can immediately see the supported options. Exampl