Re: [BUG] Unexpected action when publishing partition tables

On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com wrote: > > From Tues, Sep 7, 2021 12:02 PM Amit Kapila wrote: > > On Mon, Sep 6, 2021 at 1:49 PM houzj.f...@fujitsu.com > > wrote: > > > > > > I can reproduce this bug. > > > > > > I think the reason is it didn't invalidate all the leaf

Re: Added schema level support for publication.

On Tue, Sep 14, 2021 at 6:31 AM houzj.f...@fujitsu.com wrote: > > From Sun, Sept 12, 2021 11:13 PM vignesh C wrote: > > On Fri, Sep 10, 2021 at 11:21 AM Hou Zhijie wrote: > > > Attach the without-flag version and add comments about the pubobj_name. > > > > Than

Re: Added schema level support for publication.

On Mon, Sep 13, 2021 at 7:06 PM tanghy.f...@fujitsu.com wrote: > > On Sunday, September 12, 2021 11:13 PM vignesh C wrote: > > > > Thanks for the changes, the suggested changes make the parsing code > > simpler. I have merged the changes to the main patch. Attached v27 &

Re: Added schema level support for publication.

On Mon, Sep 6, 2021 at 6:56 AM houzj.f...@fujitsu.com wrote: > > From Thur, Sep 2, 2021 2:33 PM vignesh C wrote: > > On Wed, Sep 1, 2021 at 6:58 AM houzj.f...@fujitsu.com > > wrote: > > > > > > Here are some other co

Re: Added schema level support for publication.

On Tue, Sep 7, 2021 at 5:10 PM Amit Kapila wrote: > > On Tue, Sep 7, 2021 at 12:45 PM vignesh C wrote: > > > > On Fri, Sep 3, 2021 at 4:49 PM Amit Kapila wrote: > > > > > > > > 5. > > > If I modify the search path to remove public schema then

Re: Added schema level support for publication.

On Fri, Sep 3, 2021 at 4:06 PM Amit Kapila wrote: > > On Wed, Sep 1, 2021 at 12:05 PM Amit Kapila wrote: > > > > On Wed, Sep 1, 2021 at 8:52 AM Greg Nancarrow wrote: > > > > > > > > I'd expect a lot of users to naturally think that "ALTER PUBLICATION > > > pub1 DROP ALL TABLES IN SCHEMA sc1;"

Re: Added schema level support for publication.

On Fri, Sep 3, 2021 at 4:49 PM Amit Kapila wrote: > > On Thu, Sep 2, 2021 at 5:12 PM Amit Kapila wrote: > > > > On Thu, Sep 2, 2021 at 11:58 AM vignesh C wrote: > > > > > > > Below are few comments on v23. If you have already addressed anything > >

Re: Added schema level support for publication.

On Mon, Sep 6, 2021 at 6:56 AM houzj.f...@fujitsu.com wrote: > > From Thur, Sep 2, 2021 7:42 PM Amit Kapila wrote: > > On Thu, Sep 2, 2021 at 11:58 AM vignesh C wrote: > > > > > > > Below are few comments on v23. If you have already addressed anything in >

Re: Added schema level support for publication.

On Fri, Sep 3, 2021 at 3:12 PM Amit Kapila wrote: > > On Mon, Aug 30, 2021 at 8:56 PM vignesh C wrote: > > > > On Mon, Aug 30, 2021 at 9:10 AM houzj.f...@fujitsu.com > > wrote: > > > > > > > > 5) > > > +

Re: Added schema level support for publication.

On Wed, Sep 1, 2021 at 11:14 AM tanghy.f...@fujitsu.com wrote: > > > On Monday, August 30, 2021 11:28 PM vignesh C wrote: > > > > I have fixed these comments as part of v23 patch attached at [1]. > > [1] - https://www.postgresql.org/message- > > id/CALDaN

Re: Added schema level support for publication.

On Wed, Sep 1, 2021 at 6:58 AM houzj.f...@fujitsu.com wrote: > > Here are some other comments for v23-000x patches. > > 1) > > @@ -6225,6 +6342,9 @@ describePublications(const char *pattern) > boolhas_pubtruncate; > boolhas_pubviaroot; > > +

Re: Added schema level support for publication.

On Sat, Aug 28, 2021 at 3:19 PM Amit Kapila wrote: > > Don't you think some users might want to know all the schema names for > a publication? I am not completely sure on this point but I think it > is good to have information for users. It might be also useful to have > pg_publication_objects

Re: Added missing invalidations for all tables publication

On Tue, Aug 31, 2021 at 2:00 PM Kyotaro Horiguchi wrote: > > At Tue, 31 Aug 2021 08:31:05 +0530, vignesh C wrote in > > On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com > > wrote: > > Thanks for the comment, I have slightly modified the test case which > &g

Re: Added schema level support for publication.

On Tue, Aug 31, 2021 at 4:27 PM Amit Kapila wrote: > > On Tue, Aug 31, 2021 at 10:50 AM Greg Nancarrow wrote: > > > > On Tue, Aug 31, 2021 at 1:41 PM vignesh C wrote: > > > > > > > > > > > I notice that "CREATE PUBLICATION pub1 FOR ALL T

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 12:12 PM Amit Kapila wrote: > > > Okay, I got it but let's add few comments in the code related to it. > Also, I noticed that the code in InvalidatePublicationRels() already > exists in AlterPublicationOptions(). You can try to refactor the > existing code as a separate

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 2:14 PM Greg Nancarrow wrote: > > On Fri, Aug 27, 2021 at 4:13 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > > reduce the testing effort and also it will be easier if someone > > disagrees

Re: Added missing invalidations for all tables publication

On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com wrote: > > From Tuesday, August 31, 2021 1:10 AM vignesh C wrote: > > Hi, > > > > Relation invalidation was missing in case of create publication and drop > > publication of "FOR ALL TABLES" pu

Added missing invalidations for all tables publication

gnesh From fd58e547c22723856a2f18c306b17ab6e59cddb1 Mon Sep 17 00:00:00 2001 From: Vignesh C Date: Mon, 30 Aug 2021 22:29:07 +0530 Subject: [PATCH v1] Added missing invalidations for all tables publication. Relation invalidation was missing in case of create publication and drop publication of "FOR ALL TABL

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 1:31 PM tanghy.f...@fujitsu.com wrote: > > On Friday, August 27, 2021 2:13 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > > reduce the testing effort and also it will be easier if someone >

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 9:10 AM houzj.f...@fujitsu.com wrote: > > On Friday, August 27, 2021 2:13 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > > reduce the > > testing effort and also it will

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 8:23 AM Greg Nancarrow wrote: > > On Fri, Aug 27, 2021 at 4:13 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > > reduce the testing effort and also it will be easier if someone > > disagrees

Re: Added schema level support for publication.

On Sat, Aug 28, 2021 at 3:19 PM Amit Kapila wrote: > > On Fri, Aug 27, 2021 at 6:09 PM vignesh C wrote: > > > > On Fri, Aug 27, 2021 at 4:57 PM Amit Kapila wrote: > > > > > > On Fri, Aug 27, 2021 at 11:43 AM vignesh C wrote: > > > > > >

Re: Added schema level support for publication.

On Fri, Aug 27, 2021 at 4:57 PM Amit Kapila wrote: > > On Fri, Aug 27, 2021 at 11:43 AM vignesh C wrote: > > > > On Wed, Aug 25, 2021 at 3:07 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > >

Re: Added schema level support for publication.

On Thu, Aug 26, 2021 at 7:52 AM tanghy.f...@fujitsu.com wrote: > > On Wednesday, August 25, 2021 5:37 PM vignesh C wrote: > > > > Attached v21 patch has the changes based on the new syntax and fixes > > few of the other review comments provided by reviewers. > > &g

Re: Logical replication - schema change not invalidating the relation cache

On Fri, Jul 16, 2021 at 10:51 PM vignesh C wrote: > > On Sat, Jul 3, 2021 at 11:23 AM Dilip Kumar wrote: > > > > On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote: > > > > > > Yeah, this looks like a bug. I will look at the patch. > > > > >

Re: Printing backtrace of postgres processes

On Wed, Jul 21, 2021 at 10:56 PM vignesh C wrote: > > On Wed, Jul 21, 2021 at 3:52 PM Bharath Rupireddy > wrote: > > > > On Tue, Jul 13, 2021 at 9:03 PM vignesh C wrote: > > > > > > On Wed, May 12, 2021 at 2:27 AM Robert Haas wrote: >

Re: Identify missing publications from publisher while create/alter subscription.

On Thu, Jul 15, 2021 at 5:57 PM vignesh C wrote: > > On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote: > > > > On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote: > > > > > > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote: > > > > > &g

Re: Added schema level support for publication.

On Sat, Aug 14, 2021 at 3:02 PM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > > On 13.08.21 04:59, Amit Kapila wrote: > >> Even if we drop all tables added to the publication from it, 'pubkind' > >> doesn't go back to 'empty'. Is that intentional behavior? If we do > >> that, we

Re: Added schema level support for publication.

On Tue, Aug 17, 2021 at 6:55 PM Tom Lane wrote: > > Amit Kapila writes: > > On Tue, Aug 17, 2021 at 6:40 AM Peter Smith wrote: > >> On Mon, Aug 16, 2021 at 11:31 PM Tom Lane wrote: > >>> Abstractly it'd be > >>> > >>> createpub := CREATE PUBLICATION pubname FOR cpitem [, ... ] [ WITH ... ] >

Re: Added schema level support for publication.

On Fri, Aug 6, 2021 at 4:02 PM Amit Kapila wrote: > > On Fri, Aug 6, 2021 at 2:16 PM vignesh C wrote: > > > > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote: > > > > > > > > > Few more comments: > > > === > > >

Re: Added schema level support for publication.

On Mon, Aug 9, 2021 at 10:23 AM Amit Kapila wrote: > > On Sun, Aug 8, 2021 at 2:52 PM vignesh C wrote: > > > > On Fri, Aug 6, 2021 at 4:39 PM Amit Kapila wrote: > > > > > > On Fri, Aug 6, 2021 at 2:02 PM vignesh C wrote: > > > > > >

Re: Added schema level support for publication.

On Thu, Aug 12, 2021 at 5:54 PM Masahiko Sawada wrote: > > On Fri, Aug 6, 2021 at 5:33 PM vignesh C wrote: > > > > Thanks for the comments, the attached v19 patch has the fixes for the comments. > > Thank you for updating the patch! > > Here

Re: Added schema level support for publication.

On Tue, Aug 10, 2021 at 1:40 PM Greg Nancarrow wrote: > > On Fri, Aug 6, 2021 at 6:32 PM vignesh C wrote: > > > > Thanks for the comments, the attached v19 patch has the fixes for the comments. > > > > Some more review comments, this time for the v19 patch: > &

Re: Added schema level support for publication.

On Mon, Aug 9, 2021 at 9:50 PM Mark Dilger wrote: > > > > > On Aug 6, 2021, at 1:32 AM, vignesh C wrote: > > > > the attached v19 patch > > With v19 applied, a schema owner can publish the contents of a table regardless of ownership or permissions on that table:

Re: Added schema level support for publication.

On Mon, Aug 9, 2021 at 9:50 PM Mark Dilger wrote: > > > > > On Aug 6, 2021, at 1:32 AM, vignesh C wrote: > > > > the attached v19 patch > > With v19 applied, a schema owner can publish the contents of a table > regardless of ownership or permissions o

Re: Added schema level support for publication.

On Fri, Aug 6, 2021 at 2:00 PM Masahiko Sawada wrote: > > On Wed, Aug 4, 2021 at 12:08 AM vignesh C wrote: > > > > On Tue, Aug 3, 2021 at 12:00 PM tanghy.f...@fujitsu.com > > wrote: > > > > > > On Monday, August 2, 2021 11:40 PM vignesh C wrote: > &g

Re: [PATCH]Comment improvement in publication.sql

On Fri, Aug 6, 2021 at 3:33 PM tanghy.f...@fujitsu.com wrote: > > Hi > > I saw some inaccurate comments for AlterPublicationStmt structure when > reviewing patches related to publication[1]. > > The variable tables are used for 'ALTER PUBLICATION ... ADD/DROP/SET TABLE', > but the comments only

Re: Added schema level support for publication.

On Fri, Aug 6, 2021 at 4:39 PM Amit Kapila wrote: > > On Fri, Aug 6, 2021 at 2:02 PM vignesh C wrote: > > > > On Wed, Aug 4, 2021 at 4:10 PM Amit Kapila wrote: > > > > > > On Tue, Aug 3, 2021 at 8:38 PM vignesh C wrote: > > > > > 6. > >

Re: Added schema level support for publication.

On Fri, Aug 6, 2021 at 4:02 PM Amit Kapila wrote: > > On Fri, Aug 6, 2021 at 2:16 PM vignesh C wrote: > > > > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote: > > > > > > > > > Few more comments: > > > === > > >

Re: Added schema level support for publication.

On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote: > > On Wed, Aug 4, 2021 at 4:10 PM Amit Kapila wrote: > > > > On Tue, Aug 3, 2021 at 8:38 PM vignesh C wrote: > > > > > > Thanks for reporting this, this is fixed in the v18 patch attached. > > > &

Re: Added schema level support for publication.

On Wed, Aug 4, 2021 at 8:08 PM tanghy.f...@fujitsu.com < tanghy.f...@fujitsu.com> wrote: > > On Tuesday, August 3, 2021 11:08 PM vignesh C wrote: > > > > Thanks for reporting this, this is fixed in the v18 patch attached. > > Thanks for fixing it. > > Few sugge

Re: [PATCH]Comment improvement in publication.sql

On Tue, Aug 3, 2021 at 8:36 AM tanghy.f...@fujitsu.com wrote: > > On Monday, August 2, 2021 11:56 PM vignesh C wrote: > > > > Few minor suggestions: > > 1) Should we change below to "fail - tables can't be added, dropped or > > set to "FOR ALL TABLES

Re: Skipping logical replication transactions on subscriber side

On Tue, Aug 3, 2021 at 12:20 PM Masahiko Sawada wrote: > > On Mon, Aug 2, 2021 at 12:21 PM Amit Kapila wrote: > > > > On Mon, Aug 2, 2021 at 7:45 AM Masahiko Sawada > > wrote: > > > > > > On Fri, Jul 30, 2021 at 12:52 PM Amit Kapila > > > wrote: > > > > > > > > On Thu, Jul 29, 2021 at 11:18

Re: [HACKERS] logical decoding of two-phase transactions

On Tue, Aug 3, 2021 at 12:32 PM Amit Kapila wrote: > > On Tue, Aug 3, 2021 at 6:17 AM Peter Smith wrote: > > > > Please find attached the latest patch set v102* > > > > I have made minor modifications in the comments and docs, please see > attached. Can you please check whether the names of

Re: Failed transaction statistics to measure the logical replication progress

On Mon, Aug 2, 2021 at 1:13 PM Masahiko Sawada wrote: > > On Mon, Aug 2, 2021 at 2:52 PM osumi.takami...@fujitsu.com > wrote: > > > > On Thursday, July 29, 2021 10:50 AM Masahiko Sawada > > wrote: > > > On Thu, Jul 8, 2021 at 3:55 PM osumi.takami...@fujitsu.com > > > wrote: > > > > When the

Re: [PATCH]Comment improvement in publication.sql

On Mon, Aug 2, 2021 at 3:31 PM tanghy.f...@fujitsu.com wrote: > > Hi Hackers > > When review and test another patch at [1], I found some comments in existing > test code of " src/test/regress/sql/publication.sql " is a little bit > confused. > Attached a patch to fix them, please take a check.

Re: Corrected documentation of data type for the logical replication message formats.

On Mon, Aug 2, 2021 at 9:10 PM Tom Lane wrote: > > Peter Smith writes: > > I agree. The specified value looks better when it comes first, as you did > > it. > > Actually, it looks to me like we don't have to resolve the question of > which should come first, because I don't see any cases where

Re: Corrected documentation of data type for the logical replication message formats.

On Sun, Aug 1, 2021 at 4:11 PM Peter Smith wrote: > > On Sat, Jul 31, 2021 at 7:00 AM Tom Lane wrote: > > > > vignesh C writes: > > [ v6-0001-Included-the-actual-datatype-used-in-logical-repl.patch ] > > > > I see what you want to do here, but the way yo

Re: Corrected documentation of data type for the logical replication message formats.

On Sat, Jul 31, 2021 at 2:30 AM Tom Lane wrote: > > vignesh C writes: > [ v6-0001-Included-the-actual-datatype-used-in-logical-repl.patch ] > > I see what you want to do here, but the way you did it seems quite > detrimental to the readability of the field description

Re: [HACKERS] logical decoding of two-phase transactions

On Sat, Jul 31, 2021 at 11:12 AM Ajin Cherian wrote: > > On Sat, Jul 31, 2021 at 2:39 PM Amit Kapila wrote: > > > Here, the test is expecting 2 prepared transactions corresponding to > > two subscriptions but it waits for just one subscription via > > appname_copy. It should wait for the second

Re: [HACKERS] logical decoding of two-phase transactions

On Fri, Jul 30, 2021 at 9:32 AM Peter Smith wrote: > > Please find attached the latest patch set v100* > > v99-0002 --> v100-0001 > > Differences: > > * Rebased to HEAD @ today (needed because some recent commits [1][2] broke > v99) > The patch applies neatly, tests passes and documentation

Re: Added schema level support for publication.

On Tue, Jul 27, 2021 at 5:11 AM Greg Nancarrow wrote: > > On Mon, Jul 26, 2021 at 3:21 PM vignesh C wrote: > > > > Thanks for the comment, this is modified in the v15 patch attached. > > > > I have several minor review comments. > > (1) src/backend/catalog/ob

Re: Added schema level support for publication.

On Mon, Jul 26, 2021 at 7:41 AM tanghy.f...@fujitsu.com < tanghy.f...@fujitsu.com> wrote: > > On Friday, July 23, 2021 8:18 PM vignesh C wrote: > > > > I have changed it to not report any error, this issue is fixed in the > > v14 patch attached at [1]. > > [1]

Re: Corrected documentation of data type for the logical replication message formats.

On Fri, Jul 23, 2021 at 3:23 AM Peter Smith wrote: > > I think the patch maybe is not quite correct for all the flags. > > For example, > > @@ -7607,44 +7615,44 @@ are available since protocol version 3. > > Int8 > > -Flags; currently unused (must be 0). > +

Re: Added schema level support for publication.

On Fri, Jul 23, 2021 at 6:26 AM tanghy.f...@fujitsu.com wrote: > > On Thursday, July 22, 2021 1:30 AM vignesh C wrote: > > > > Thanks for reporting this issue, this issue is fixed in the attached v13 > > patch. > > I have changed relation name pg_publication_schem

Re: Added schema level support for publication.

On Thu, Jul 22, 2021 at 9:38 AM Greg Nancarrow wrote: > > On Thu, Jul 22, 2021 at 1:42 PM houzj.f...@fujitsu.com > wrote: > > > > Personally, the new name pg_publication_sch is not very easy to understand. > > (Maybe it's because I am not a native english speaker. If others feel ok, > > please

Re: Hook for extensible parsing.

On Sat, Jun 12, 2021 at 1:59 PM Julien Rouhaud wrote: > > On Tue, Jun 08, 2021 at 12:16:48PM +0800, Julien Rouhaud wrote: > > On Sun, Jun 06, 2021 at 02:50:19PM +0800, Julien Rouhaud wrote: > > > On Sat, May 01, 2021 at 03:24:58PM +0800, Julien Rouhaud wrote: > > > > > > > > I'm attaching some

Re: Enhanced error message to include hint messages for redundant options error

On Thu, Jul 15, 2021 at 5:12 PM vignesh C wrote: > > On Thu, Jul 15, 2021 at 1:40 PM Dean Rasheed wrote: > > > > On Tue, 13 Jul 2021 at 15:30, vignesh C wrote: > > > > > > On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed > > > wrote: > > >

Re: dynamic result sets support in extended query protocol

On Tue, Jun 29, 2021 at 7:10 PM Peter Eisentraut wrote: > > Here is an updated patch with some merge conflicts resolved, to keep it > fresh. It's still pending in the commit fest from last time. > > My focus right now is to work on the "psql - add SHOW_ALL_RESULTS > option" patch

Re: Delegating superuser tasks to new security roles (Was: Granting control of SUSET gucs to non-superusers)

On Thu, Jul 1, 2021 at 9:42 PM Mark Dilger wrote: > > > > > On Jun 29, 2021, at 6:25 PM, Mark Dilger > > wrote: > > > > Please find attached a new set of patches. > > And again, this time attaching a fifth patch which includes the work to allow > users who belong to the right security role to

Re: Automatic notification of top transaction IDs

On Thu, Jul 1, 2021 at 6:41 AM Gurjeet Singh wrote: > > The proposed patch is attached. There is one compilation warning: xid.c:165:1: warning: no previous prototype for ‘FullTransactionIdToStr’ [-Wmissing-prototypes] 165 | FullTransactionIdToStr(FullTransactionId fxid) |

Re: Allow batched insert during cross-partition updates

On Fri, Jul 2, 2021 at 7:35 AM Amit Langote wrote: > > On Fri, Jul 2, 2021 at 1:39 AM Tom Lane wrote: > > > > Amit Langote writes: > > > [ v6-0001-Allow-batching-of-inserts-during-cross-partition-.patch ] > > > > Per the cfbot, this isn't applying anymore, so I'm setting it back > > to Waiting

Re: alter table set TABLE ACCESS METHOD

On Fri, Jul 16, 2021 at 9:19 AM Justin Pryzby wrote: > > rebased. > > Also, there were two redundant checks for multiple SET ACCESS METHOD commands. > But one of them wasn't hit if the ALTER was setting the current AM due to the > no-op test. > > I think it's better to fail in every case, and not

Re: Added schema level support for publication.

On Wed, Jul 21, 2021 at 3:14 PM Rahila Syed wrote: > > > > On Mon, Jul 19, 2021 at 2:41 PM Greg Nancarrow wrote: >> >> On Fri, Jul 16, 2021 at 8:13 PM vignesh C wrote: >> > >> > Modified. >> > >> > Thanks for the comments, these issu

Re: Added schema level support for publication.

On Mon, Jul 19, 2021 at 2:41 PM Greg Nancarrow wrote: > > On Fri, Jul 16, 2021 at 8:13 PM vignesh C wrote: > > > > Modified. > > > > Thanks for the comments, these issues are fixed as part of the v12 patch > > posted at [1]. > > [1] -

Re: Added schema level support for publication.

On Mon, Jul 19, 2021 at 9:32 AM tanghy.f...@fujitsu.com < tanghy.f...@fujitsu.com> wrote: > > On Friday, July 16, 2021 6:10 PM vignesh C > > On Wed, Jul 14, 2021 at 6:25 PM houzj.f...@fujitsu.com > > wrote: > > > > > > Wednesday, July 14, 2021 6:17 P

Re: Printing backtrace of postgres processes

On Wed, Jul 21, 2021 at 3:52 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > > On Tue, Jul 13, 2021 at 9:03 PM vignesh C wrote: > > > > On Wed, May 12, 2021 at 2:27 AM Robert Haas wrote: > > > > > > Maybe we should have a role

Re: Added documentation for cascade and restrict option of drop statistics

On Mon, 19 Jul 2021, 09:16 Michael Paquier, wrote: > > On Sun, Jul 18, 2021 at 12:37:48PM +0900, Michael Paquier wrote: > > Indeed, good catch. The other commands document that, so let's fix > > it. > > Applied. Thanks for committing this patch. Regards, Vignesh

Re: Logical replication - schema change not invalidating the relation cache

On Sat, Jul 3, 2021 at 11:23 AM Dilip Kumar wrote: > > On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote: > > > > Yeah, this looks like a bug. I will look at the patch. > > > > While looking into this, I think the main cause of the problem is that > schema rename does not invalidate the

Re: psql tab auto-complete for CREATE PUBLICATION

On Fri, Jul 9, 2021 at 1:06 PM Peter Smith wrote: > > I found that the psql tab auto-complete was not working for some cases > of CREATE PUBLICATION [1]. > > CREATE PUBLICATION name > [ FOR TABLE [ ONLY ] table_name [ * ] [, ...] > | FOR ALL TABLES ] > [ WITH ( publication_parameter

Added documentation for cascade and restrict option of drop statistics

Hi, Cascade and restrict options are supported for drop statistics syntax: drop statistics stat1 cascade; drop statistics stat2 restrict; The documentation for this was missing, attached a patch which includes the documentation for these options. Regards, Vignesh From

Re: Add option --drop-cascade for pg_dump/restore

On Tue, Jul 13, 2021 at 9:16 PM Wu Haotian wrote: > > > 2) I felt pg_dump will include the cascade option for plain format and > > pg_restore will include the cascade option from pg_restore for other > > formats. If my understanding is correct, should we document this? > > I may not understand it

Re: Corrected documentation of data type for the logical replication message formats.

On Fri, Jul 16, 2021 at 8:52 AM Peter Smith wrote: > > Hi Vignesh. > > FYI - Because the other patch [1] was pushed ahead of this one, I > think your patch now needs to be updated for the new message types > that were introduced. Thanks, I have made the changes for the same in the v5 patch

Re: Added schema level support for publication.

On Fri, Jul 16, 2021 at 9:25 AM Greg Nancarrow wrote: > > On Wed, Jul 14, 2021 at 8:17 PM vignesh C wrote: > > > > Thanks for your comments, the attached v11 patch fixes the issues. > > > > Thanks for your work on this. > > I have some minor review comments

Re: [HACKERS] logical decoding of two-phase transactions

On Wed, Jul 14, 2021 at 2:03 PM Peter Smith wrote: > > On Wed, Jul 14, 2021 at 4:23 PM Amit Kapila wrote: > > > > On Mon, Jul 12, 2021 at 9:14 AM Peter Smith wrote: > > > > > > On Sun, Jul 11, 2021 at 8:20 PM Amit Kapila > > > wrote: > > > > > > > > On Fri, Jul 9, 2021 at 4:43 AM Peter Smith

Re: Identify missing publications from publisher while create/alter subscription.

On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote: > > On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote: > > > > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote: > > > > > > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote: > > > > > > >

Re: Split xlog.c

On Tue, Jun 22, 2021 at 2:37 AM Heikki Linnakangas wrote: > > On 17/06/2021 02:00, Andres Freund wrote: > > On 2021-06-16 16:30:45 +0300, Heikki Linnakangas wrote: > >> That's a fairly clean split. StartupXLOG() stays in xlog.c, but much of > >> the > >> code from it has been moved to new

Re: logical decoding and replication of sequences

On Wed, Jun 23, 2021 at 7:55 PM Tomas Vondra wrote: > > On 6/23/21 4:14 PM, Tomas Vondra wrote: > > A rebased patch, addressing a minor bitrot due to 4daa140a2f5. > > > > Meh, forgot to attach the patch as usual, of course ... The patch does not apply on Head anymore, could you rebase and post a

Re: postgres_fdw - make cached connection functions tests meaningful

On Mon, May 10, 2021 at 6:03 PM Bharath Rupireddy wrote: > > Hi, > > While working on [1], I got to know that there is a new GUC > debug_invalidate_system_caches_always that has been introduced in v14. > It can be used to switch off cache invalidation in > CLOBBER_CACHE_ALWAYS builds which makes

Re: psql - add SHOW_ALL_RESULTS option

On Sat, Jun 12, 2021 at 3:11 PM Fabien COELHO wrote: > > > Hello Peter, > > >> My overly naive trust in non regression test to catch any issues has been > >> largely proven wrong. Three key features do not have a single tests. Sigh. > >> > >> I'll have some time to look at it over next week-end,

Re: Rename of triggers for partitioned tables

On Mon, Jun 28, 2021 at 3:46 PM Arne Roland wrote: > > Hi! > > > From: Zhihong Yu > Sent: Saturday, June 26, 2021 20:32 > Subject: Re: Rename of triggers for partitioned tables > > > Hi, Arne: > > It seems the patch no longer applies cleanly on master branch. > > Do you mind updating the patch ?

Re: Removing unneeded self joins

On Thu, May 27, 2021 at 12:21 PM Andrey V. Lepikhov wrote: > > On 5/8/21 2:00 AM, Hywel Carver wrote: > > On Fri, May 7, 2021 at 8:23 AM Andrey Lepikhov > > mailto:a.lepik...@postgrespro.ru>> wrote: > > Here I didn't work on 'unnecessary IS NOT NULL filter'. > > > > I've tested the new patch,

Re: Remove redundant initializations

On Mon, Jun 28, 2021 at 3:30 PM Peter Eisentraut wrote: > > There are certain parts of code that laboriously initialize every field > of a struct to (some spelling of) zero, even though the whole struct was > just zeroed (by makeNode() or memset()) a few lines earlier. Besides > being redundant,

Re: A qsort template

On Sun, Jul 4, 2021 at 9:58 AM Thomas Munro wrote: > > On Fri, Jul 2, 2021 at 2:32 PM John Naylor > wrote: > > I suspect if we experiment on two extremes of type "heaviness" (accessing > > and comparing trivial or not), such as uint32 and tuplesort, we'll have a > > pretty good idea what the

Re: Enhanced error message to include hint messages for redundant options error

On Thu, Jul 15, 2021 at 1:40 PM Dean Rasheed wrote: > > On Tue, 13 Jul 2021 at 15:30, vignesh C wrote: > > > > On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed > > wrote: > > > > > > As it stands, the improvements from (3) seem quite worthwhile. Also,

Re: POC: Cleaning up orphaned files using undo logs

On Wed, Jun 30, 2021 at 11:10 PM Antonin Houska wrote: > > Antonin Houska wrote: > > > tsunakawa.ta...@fujitsu.com wrote: > > > > > I'm crawling like a snail to read the patch set. Below are my first set > > > of review comments, which are all minor. > > > > Thanks. > > I've added the patch

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On Thu, Apr 8, 2021 at 11:40 PM Simon Riggs wrote: > > On Thu, 8 Apr 2021 at 18:15, Alvaro Herrera wrote: > > > > On 2021-Apr-08, Simon Riggs wrote: > > > > > On Thu, 8 Apr 2021 at 16:58, David Steele wrote: > > > > > > It's not clear to me which patch is which, so perhaps move one CF entry > >

Re: storing an explicit nonce

On Sat, Jun 26, 2021 at 2:52 AM Bruce Momjian wrote: > > On Wed, May 26, 2021 at 05:02:01PM -0400, Bruce Momjian wrote: > > For these reasons, if we decide to go in the direction of using a > > non-LSN nonce, I no longer plan to continue working on this feature. I > > would rather work on things

Re: Release SPI plans for referential integrity with DISCARD ALL

On Wed, Mar 10, 2021 at 1:49 PM yuzuko wrote: > > Hello, > > I thought about this suggestion again. > > Amit's patch suggested in the thread [1] can eliminate SPI plans from > INSERT/UPDATE triggers, so our memory pressure issue would be solved. > But as far as I can see that thread, Amit's patch

Re: Reduce the number of special cases to build contrib modules on windows

On Mon, Apr 19, 2021 at 5:18 PM David Rowley wrote: > > On Wed, 3 Mar 2021 at 22:37, David Rowley wrote: > > I've attached a rebased patch. > > I've rebased this again. > > I also moved away from using hash tables for storing references and > libraries. I was having some problems getting psql

Re: [PATCH] New default role allowing to change per-role/database settings

On Wed, Apr 7, 2021 at 5:23 PM Michael Banck wrote: > > Hi, > > Am Dienstag, den 06.04.2021, 15:37 +0200 schrieb Michael Banck: > > Am Montag, den 05.04.2021, 14:33 -0400 schrieb Stephen Frost: > > > Should drop the 'DEFAULT_' to match the others since the rename to > > > 'predefined' roles went

Re: Make Append Cost aware of some run time partition prune case

On Thu, Mar 4, 2021 at 9:51 AM Andy Fan wrote: > > >> >> I have implemented a new one, which only handles 1 level of partitioned >> table, and >> only 1 partition key. and only handle the eq operators like partkey = $1 / >> partkey in ($1, $2) >> / parkey = $1 or partkey = $2; The patch works

Re: Implementing Incremental View Maintenance

On Mon, May 17, 2021 at 10:08 AM Yugo NAGATA wrote: > > On Fri, 7 May 2021 14:14:16 +0900 > Yugo NAGATA wrote: > > > On Mon, 26 Apr 2021 16:03:48 +0900 > > Yugo NAGATA wrote: > > > > > On Mon, 26 Apr 2021 15:46:21 +0900 > > > Yugo NAGATA wrote: > > > > > > > On Tue, 20 Apr 2021 09:51:34 +0900

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

On Tue, Mar 30, 2021 at 2:14 AM Mark Rofail wrote: > > Hey Alvaro > >> Yes, we should do that. > > I have attached v12 with more tests in “ src/test/regress/sql/gin.sql” > > Changelog: > - v12 (compatible with current master 2021/03/29, commit > 6d7a6feac48b1970c4cd127ee65d4c487acbb5e9) > *

Re: DROP INDEX CONCURRENTLY on partitioned index

On Wed, Oct 28, 2020 at 6:14 AM Justin Pryzby wrote: > > Forking this thread, since the existing CFs have been closed. > https://www.postgresql.org/message-id/flat/20200914143102.GX18552%40telsasoft.com#58b1056488451f8594b0f0ba40996afd > > On Mon, Sep 14, 2020 at 09:31:03AM -0500, Justin Pryzby

Re: [PATCH] Allow multiple recursive self-references

On Wed, Mar 31, 2021 at 7:28 PM Denis Hirn wrote: > > Sorry, I didn't append the patch properly. The patch does not apply on Head anymore, could you rebase and post a patch. I'm changing the status to "Waiting for Author". Regards, Vignesh

Re: libpq compression

On Wed, Jul 14, 2021 at 6:31 PM Daniil Zakhlystov wrote: > > **sorry for the noise, but I need to re-send the message because one of the > recipients is blocked on the pgsql-hackers for some reason** > > Hi! > > Done, the patch should apply to the current master now. > > Actually, I have an

Re: ResourceOwner refactoring

On Tue, Mar 9, 2021 at 6:10 PM Heikki Linnakangas wrote: > > On 08/03/2021 18:47, Ibrar Ahmed wrote: > > The patchset does not apply successfully, there are some hunk failures. > > > > http://cfbot.cputube.org/patch_32_2834.log > > > > > >

Re: Polyphase merge is obsolete

On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas wrote: > > On 22/10/2020 14:48, Heikki Linnakangas wrote: > > On 11/09/2017 13:37, Tomas Vondra wrote: > >> I planned to do some benchmarking on this patch, but apparently the > >> patch no longer applies. Rebase please? > > > > Here's a rebase

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

On Sun, Sep 13, 2020 at 9:34 PM Nikolay Shaplov wrote: > > В письме от понедельник, 20 июля 2020 г. 18:36:44 MSK пользователь Georgios > Kokolatos написал: > > Hi! Sorry for really long delay, I was at my summer vacations, and then has > urgent things to finish first. :-( Now I hope we can

<    5   6   7   8   9   10   11   12   13   14   >