Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2018-07-08 Thread Michael Paquier
On Fri, Jul 06, 2018 at 09:09:27PM +0900, Michael Paquier wrote: > Sure. I think I can finish the set on Monday JST then. So, I have been able to back-patch things down to 9.5, but further down I am not really convinced that it is worth meddling with that, particularly in light of 7cbee7c which

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2018-07-06 Thread Michael Paquier
On Fri, Jul 06, 2018 at 08:05:50AM -0400, Andrew Dunstan wrote: > On 07/06/2018 07:18 AM, Michael Paquier wrote: > > For what it's worth, I volunteer to finish the work :) > > > > The 2PC patch is really simple, and fixes a data loss issue. The second > > patch has been looked up by Heikki,

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2018-07-06 Thread Andrew Dunstan
On 07/06/2018 07:18 AM, Michael Paquier wrote: Robert Haas wrote: Although the state is now back to "Needs Review", I echo those sentiments. This issue has now been hanging around for about 18 months. No, those are my words, not Robert's :-) For what it's worth, I volunteer to finish

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2018-07-06 Thread Michael Paquier
Robert Haas wrote: > Although the state is now back to "Needs Review", I echo those > sentiments. This issue has now been hanging around for about 18 > months. For what it's worth, I volunteer to finish the work :) The 2PC patch is really simple, and fixes a data loss issue. The second patch

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2018-07-06 Thread Andrew Dunstan
On Thu, Jun 28, 2018 at 1:39 AM, Michael Paquier wrote: > On Thu, Jan 11, 2018 at 10:35:22PM -0500, Stephen Frost wrote: >> Magnus, this was your thread to begin with, though I know others have >> been involved, any chance you'll be able to review this for commit >> during this CF? I agree that

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2018-06-27 Thread Michael Paquier
On Thu, Jan 11, 2018 at 10:35:22PM -0500, Stephen Frost wrote: > Magnus, this was your thread to begin with, though I know others have > been involved, any chance you'll be able to review this for commit > during this CF? I agree that this is certainly a good thing to have > too, though I've not

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2018-01-13 Thread Thomas Munro
On Fri, Jan 12, 2018 at 4:35 PM, Stephen Frost wrote: > Appears to compile and pass make check-world still (not sure why Thomas' > bot currently thinks the build fails, since it worked here..). It looks good now. There was a brief window when all Travis CI builds said this

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2018-01-11 Thread Stephen Frost
Magnus, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Mon, Oct 2, 2017 at 3:29 PM, Michael Paquier > wrote: > > On Mon, Oct 2, 2017 at 8:13 AM, Daniel Gustafsson wrote: > >> I’ve moved this to the next CF, but since this no longer applies

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2017-11-26 Thread Michael Paquier
On Mon, Oct 2, 2017 at 3:29 PM, Michael Paquier wrote: > On Mon, Oct 2, 2017 at 8:13 AM, Daniel Gustafsson wrote: >> I’ve moved this to the next CF, but since this no longer applies cleanly I’ve >> reset it to Waiting for author. > > Thanks Daniel for