I have committed the patches
0001 Improve messaging during logical replication worker startup
0002 Split the SetSubscriptionRelState function into two
0004 doesn't apply anymore, 0003 doesn't seem to be very useful without
0004, as I understand it. It's also a bit more than I'm comfortable
revie
On Wed, Mar 7, 2018 at 11:13 PM, Alvaro Herrera
wrote:
> 0002 looks like a good improvement to me. The existing routine is
> messy, and apparently it's so just to save one LockSharedObject plus
> cache lookup; IMO it's not worth it. Patched code looks simpler. If
> there are cases where having
On Wed, Mar 7, 2018 at 11:13 PM, Alvaro Herrera wrote:
> 0001:
>
> there are a bunch of other messages of the same ilk in the file. I
> don't like how the current messages are worded; maybe Peter or Petr had
> some reason why they're like that, but I would have split out the reason
> for not star
On 3/7/18 9:37 AM, Alvaro Herrera wrote:
> David Steele wrote:
>
>> I'm marking this submission Returned with Feedback.
>
> Not yet please.
Back to Waiting on Author state.
Regards,
--
-David
da...@pgmasters.net
David Steele wrote:
> I'm marking this submission Returned with Feedback.
Not yet please.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 3/7/18 7:41 AM, Masahiko Sawada wrote:
> On Tue, Mar 6, 2018 at 11:17 PM, David Steele wrote:
>> Hi Masahiko,
>>
>> On 1/30/18 5:00 AM, Masahiko Sawada wrote:
>>> On Fri, Jan 26, 2018 at 11:41 AM, Peter Eisentraut
>>> wrote:
On 1/24/18 02:33, Masahiko Sawada wrote:
> Thank you for not
0002 looks like a good improvement to me. The existing routine is
messy, and apparently it's so just to save one LockSharedObject plus
cache lookup; IMO it's not worth it. Patched code looks simpler. If
there are cases where having the combined behavior is useful, it's not
clear what they are.
0001:
there are a bunch of other messages of the same ilk in the file. I
don't like how the current messages are worded; maybe Peter or Petr had
some reason why they're like that, but I would have split out the reason
for not starting or stopping into errdetail. Something like
errmsg("logical r
On Tue, Mar 6, 2018 at 11:17 PM, David Steele wrote:
> Hi Masahiko,
>
> On 1/30/18 5:00 AM, Masahiko Sawada wrote:
>> On Fri, Jan 26, 2018 at 11:41 AM, Peter Eisentraut
>> wrote:
>>> On 1/24/18 02:33, Masahiko Sawada wrote:
Thank you for notification. Since it seems to me that no one is
Hi Masahiko,
On 1/30/18 5:00 AM, Masahiko Sawada wrote:
> On Fri, Jan 26, 2018 at 11:41 AM, Peter Eisentraut
> wrote:
>> On 1/24/18 02:33, Masahiko Sawada wrote:
>>> Thank you for notification. Since it seems to me that no one is
>>> interested in this patch, it would be better to close out this
On Fri, Jan 26, 2018 at 11:41 AM, Peter Eisentraut
wrote:
> On 1/24/18 02:33, Masahiko Sawada wrote:
>> Thank you for notification. Since it seems to me that no one is
>> interested in this patch, it would be better to close out this patch.
>> This patch is a refactoring patch but subscription cod
On 1/24/18 02:33, Masahiko Sawada wrote:
> Thank you for notification. Since it seems to me that no one is
> interested in this patch, it would be better to close out this patch.
> This patch is a refactoring patch but subscription code seems to work
> fine so far. If a problem appears around subsc
On Tue, Jan 23, 2018 at 7:58 AM, Stephen Frost wrote:
> Greetings,
>
> * Michael Paquier (michael.paqu...@gmail.com) wrote:
>> On Fri, Aug 18, 2017 at 2:09 PM, Masahiko Sawada
>> wrote:
>> > On Thu, Aug 17, 2017 at 8:17 PM, Masahiko Sawada
>> > wrote:
>> >> On Thu, Aug 17, 2017 at 9:10 AM, Pet
Greetings,
* Michael Paquier (michael.paqu...@gmail.com) wrote:
> On Fri, Aug 18, 2017 at 2:09 PM, Masahiko Sawada
> wrote:
> > On Thu, Aug 17, 2017 at 8:17 PM, Masahiko Sawada
> > wrote:
> >> On Thu, Aug 17, 2017 at 9:10 AM, Peter Eisentraut
> >> wrote:
> >>> On 8/8/17 05:58, Masahiko Sawada
On Fri, Aug 18, 2017 at 2:09 PM, Masahiko Sawada wrote:
> On Thu, Aug 17, 2017 at 8:17 PM, Masahiko Sawada
> wrote:
>> On Thu, Aug 17, 2017 at 9:10 AM, Peter Eisentraut
>> wrote:
>>> On 8/8/17 05:58, Masahiko Sawada wrote:
Are you planning to work on remaining patches 0005 and 0006 that
>>
15 matches
Mail list logo
