Re: [PATCH] Print error when libpq-refs-stamp fails

2021-10-04 Thread Rachel Heaton
Thanks to you both! From: Daniel Gustafsson Date: Monday, October 4, 2021 at 11:36 AM To: Jacob Champion Cc: Rachel Heaton , pgsql-hackers@lists.postgresql.org , a.volos...@postgrespro.ru Subject: Re: [PATCH] Print error when libpq-refs-stamp fails > On 4 Oct 2021, at 19:21, Dan

Re: [PATCH] Print error when libpq-refs-stamp fails

2021-10-04 Thread Daniel Gustafsson
> On 4 Oct 2021, at 19:21, Daniel Gustafsson wrote: > >> On 4 Oct 2021, at 19:02, Jacob Champion wrote: >> >> On Mon, 2021-10-04 at 23:40 +0700, Anton Voloshin wrote: >>> >>> Could you please confirm that the change from -A to -a in nm arguments >>> in this patch is intentional? >> >> That

Re: [PATCH] Print error when libpq-refs-stamp fails

2021-10-04 Thread Daniel Gustafsson
> On 4 Oct 2021, at 19:02, Jacob Champion wrote: > > On Mon, 2021-10-04 at 23:40 +0700, Anton Voloshin wrote: >> >> Could you please confirm that the change from -A to -a in nm arguments >> in this patch is intentional? > > That was not intended by us, thank you for the catch! A stray > lo

Re: [PATCH] Print error when libpq-refs-stamp fails

2021-10-04 Thread Jacob Champion
On Mon, 2021-10-04 at 23:40 +0700, Anton Voloshin wrote: > > Could you please confirm that the change from -A to -a in nm arguments > in this patch is intentional? That was not intended by us, thank you for the catch! A stray lowercasing in vim, perhaps. --Jacob

Re: [PATCH] Print error when libpq-refs-stamp fails

2021-10-04 Thread Anton Voloshin
Hello, On 28/09/2021 05:55, Rachel Heaton wrote: Hello, While developing I got this error and it was difficult to figure out what was going on. Thanks to Jacob, I was able to learn the context of the failure, so we created this small patch. - ! nm -A -u $< 2>/dev/null | grep -v __cx

Re: [PATCH] Print error when libpq-refs-stamp fails

2021-10-04 Thread Daniel Gustafsson
> On 28 Sep 2021, at 17:52, Rachel Heaton wrote: > Patch attached. I tweaked the error message a little bit and pushed to master. Thanks! -- Daniel Gustafsson https://vmware.com/

Re: [PATCH] Print error when libpq-refs-stamp fails

2021-09-28 Thread Rachel Heaton
On Tue, Sep 28, 2021 at 6:14 AM Daniel Gustafsson wrote: > > Since it's not actually libpq which calls exit (no such patch would ever be > committed), I think it would be clearer to indicate that a library linked to > is > the culprit. How about something like "libpq must not be linked against

Re: [PATCH] Print error when libpq-refs-stamp fails

2021-09-28 Thread Daniel Gustafsson
> On 28 Sep 2021, at 00:55, Rachel Heaton wrote: > While developing I got this error and it was difficult to figure out what was > going on. > > Thanks to Jacob, I was able to learn the context of the failure, so we > created this small patch. I can see that, and I think this patch makes se

[PATCH] Print error when libpq-refs-stamp fails

2021-09-27 Thread Rachel Heaton
Hello, While developing I got this error and it was difficult to figure out what was going on. Thanks to Jacob, I was able to learn the context of the failure, so we created this small patch. The text of the error message, of course, is up for debate, but hopefully this will make it more clear