Thomas Munro writes:
> Clearly there is a more general question though, which is "should we
> buy into Apple's ABI management system or not", and I don't have a
> strong opinion on that.
Well, I definitely don't wish to clutter our core code with any
explicit dependencies on
On Tue, Jul 13, 2021 at 7:39 AM Peter Eisentraut
wrote:
> On 06.07.21 22:34, Tom Lane wrote:
> > 2. We'd really like to use preadv/pwritev where available.
>
> A couple of things that I haven't seen made clear in this thread yet:
>
> - Where is the availability boundary for preadv/pwritev on
On 06.07.21 22:34, Tom Lane wrote:
2. We'd really like to use preadv/pwritev where available.
A couple of things that I haven't seen made clear in this thread yet:
- Where is the availability boundary for preadv/pwritev on macOS?
- What is the impact of having vs. not having these functions?
James Hilliard writes:
> On Tue, Jul 6, 2021 at 2:34 PM Tom Lane wrote:
>> As far as I can tell, the only way to really deal with #2 is to
>> perform a runtime dlsym() probe to see whether pwritev exists, and
>> then fall back to our src/port/ implementation if not. This does
>> not look
On Tue, Jul 6, 2021 at 2:34 PM Tom Lane wrote:
>
> Peter Eisentraut writes:
> > I think this change is perfectly appropriate (modulo some small cleanups).
>
> I think there are a couple of issues here.
>
> 1. People who are already using MACOSX_DEPLOYMENT_TARGET to control
> their builds would
Peter Eisentraut writes:
> I think this change is perfectly appropriate (modulo some small cleanups).
I think there are a couple of issues here.
1. People who are already using MACOSX_DEPLOYMENT_TARGET to control
their builds would like to keep on doing so, but the AC_CHECK_FUNCS
probe doesn't
On 21.06.21 07:22, Thomas Munro wrote:
I'm not personally against the proposed change. I'll admit there is
something annoying about Apple's environment working in a way that
doesn't suit traditional configure macros that have been the basis of
portable software for a few decades, but when all's
On Mon, Jun 21, 2021 at 4:32 PM Sandeep Thakkar
wrote:
> Do we see any solution to this issue? or using the older SDK is the way to go?
> On Thu, May 20, 2021 at 2:04 PM Dave Page wrote:
>> The ability to target older releases with a newer SDK is essential for
>> packages such as the EDB
Hi,
Do we see any solution to this issue? or using the older SDK is the way to
go?
On Thu, May 20, 2021 at 2:04 PM Dave Page wrote:
>
>
> On Tue, Mar 30, 2021 at 6:58 AM Tom Lane wrote:
>
>> Thomas Munro writes:
>> > I'll move it when committing. I'll let this patch sit for another day
>> >
On Tue, Mar 30, 2021 at 6:58 AM Tom Lane wrote:
> Thomas Munro writes:
> > I'll move it when committing. I'll let this patch sit for another day
> > to see if any other objections show up.
>
> FWIW, I remain fairly strongly against this, precisely because of the
> point that it requires us to
Hi,
I see this issue persist when I compile PG v14 beta1 on macOS Apple M1
using macOS 11.1 SDK. Even though the build didn't fail, the execution of
initdb on macOS 10.15 failed with the same error. Here is the snippet of
the build log:
--
> gcc -Wall -Wmissing-prototypes -Wpointer-arith
>
On Tue, Mar 30, 2021 at 7:51 PM Tom Lane wrote:
>
> Thomas Munro writes:
> > Personally I'm mostly concerned about making it easy for new
> > contributors to get a working dev system going on a super common
> > platform without dealing with hard-to-diagnose errors, than people who
> > actually
Thomas Munro writes:
> Personally I'm mostly concerned about making it easy for new
> contributors to get a working dev system going on a super common
> platform without dealing with hard-to-diagnose errors, than people who
> actually want a different target as a deliberate choice. Do I
>
On Tue, Mar 30, 2021 at 6:43 PM Thomas Munro wrote:
>
> On Tue, Mar 30, 2021 at 7:39 PM James Hilliard
> wrote:
> > On Mon, Mar 29, 2021 at 11:58 PM Tom Lane wrote:
> > > We haven't claimed in the past to support MACOSX_DEPLOYMENT_TARGET,
> > > and I'm not sure we should start now. How many
On Tue, Mar 30, 2021 at 7:39 PM James Hilliard
wrote:
> On Mon, Mar 29, 2021 at 11:58 PM Tom Lane wrote:
> > We haven't claimed in the past to support MACOSX_DEPLOYMENT_TARGET,
> > and I'm not sure we should start now. How many people actually care
> > about that?
>
> Seems kinda important for
On Mon, Mar 29, 2021 at 11:58 PM Tom Lane wrote:
>
> Thomas Munro writes:
> > I'll move it when committing. I'll let this patch sit for another day
> > to see if any other objections show up.
>
> FWIW, I remain fairly strongly against this, precisely because of the
> point that it requires us
Thomas Munro writes:
> I'll move it when committing. I'll let this patch sit for another day
> to see if any other objections show up.
FWIW, I remain fairly strongly against this, precisely because of the
point that it requires us to start using a randomly different
feature-probing technology
On Tue, Mar 30, 2021 at 12:32 PM James Hilliard
wrote:
> Should I resend with that changed or can it just be fixed when applied?
I'll move it when committing. I'll let this patch sit for another day
to see if any other objections show up.
On Mon, Mar 29, 2021 at 4:10 PM Thomas Munro wrote:
>
> On Tue, Mar 30, 2021 at 6:37 AM James Hilliard
> wrote:
> > Should it work if I just attach it to the thread like this?
>
> Yes. It automatically tries patches that are attached to threads that
> are registered on commitfest.postgresql.org
On Tue, Mar 30, 2021 at 6:37 AM James Hilliard
wrote:
> Should it work if I just attach it to the thread like this?
Yes. It automatically tries patches that are attached to threads that
are registered on commitfest.postgresql.org on 4 OSes, and we can see
that it succeeded, and we can inspect
Should it work if I just attach it to the thread like this?
On Mon, Mar 29, 2021 at 7:52 AM David Steele wrote:
>
> Hi James,
>
> On 1/31/21 1:59 AM, James Hilliard wrote:
> > On Fri, Jan 22, 2021 at 12:32 PM James Hilliard
> > wrote:
> >>
> >> Fixes:
> >> gcc -Wall -Wmissing-prototypes
Hi James,
On 1/31/21 1:59 AM, James Hilliard wrote:
On Fri, Jan 22, 2021 at 12:32 PM James Hilliard
wrote:
Fixes:
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
-Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security
-fno-strict-aliasing
On Fri, Jan 22, 2021 at 12:32 PM James Hilliard
wrote:
>
> Fixes:
> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
> -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security
> -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2
>
Fixes:
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
-Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security
-fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2
-I../../../../src/include -isysroot
24 matches
Mail list logo
