Re: Add Information during standby recovery conflicts

2021-01-13 Thread Fujii Masao
On Fri, Jan 8, 2021 at 3:43 PM Drouvot, Bertrand wrote: > > > On 1/8/21 7:24 AM, Fujii Masao wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the sender > > and know the content is safe. > > > > > > > >

Re: Add Information during standby recovery conflicts

2021-01-13 Thread Fujii Masao
On Fri, Jan 8, 2021 at 2:15 PM Drouvot, Bertrand wrote: > > Hi, > > On 1/8/21 5:19 AM, Fujii Masao wrote: > > > > On 2021/01/08 11:17, Kyotaro Horiguchi wrote: > >> At Fri, 8 Jan 2021 01:32:11 +0900, Fujii Masao > >> wrote in > >>> > >>> Attached is the updated version of the patch. This can be

Re: Add Information during standby recovery conflicts

2021-01-07 Thread Fujii Masao
On 2021/01/08 14:02, Drouvot, Bertrand wrote: Hi, On 1/7/21 4:51 PM, Fujii Masao wrote: Thanks for the review! I pushed the latest patch. Thanks all of you for your precious help on this patch! The original idea behind this thread has been split into 3 pieces. Pieces 1

Re: Add Information during standby recovery conflicts

2021-01-07 Thread Fujii Masao
On 2021/01/08 11:17, Kyotaro Horiguchi wrote: At Fri, 8 Jan 2021 01:32:11 +0900, Fujii Masao wrote in Attached is the updated version of the patch. This can be applied to current master. With the patch, for example, if the startup process waited longer than deadlock_timeout for the

Re: Add Information during standby recovery conflicts

2021-01-07 Thread Kyotaro Horiguchi
At Fri, 8 Jan 2021 01:32:11 +0900, Fujii Masao wrote in > > Attached is the updated version of the patch. This can be applied to > current master. > > With the patch, for example, if the startup process waited longer than > deadlock_timeout for the recovery conflict on the lock, the latter

Re: Add Information during standby recovery conflicts

2021-01-07 Thread Fujii Masao
On 2020/12/15 2:00, Fujii Masao wrote: On 2020/12/15 0:49, Drouvot, Bertrand wrote: Hi, On 12/14/20 4:20 PM, Fujii Masao wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content

Re: Add Information during standby recovery conflicts

2021-01-07 Thread Fujii Masao
On 2021/01/07 22:39, Drouvot, Bertrand wrote: Hi, On 1/6/21 6:31 PM, Fujii Masao wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 2020/12/15 0:20, Fujii

Re: Add Information during standby recovery conflicts

2021-01-06 Thread Fujii Masao
On 2020/12/15 0:20, Fujii Masao wrote: On 2020/12/14 21:31, Fujii Masao wrote: On 2020/12/05 12:38, Masahiko Sawada wrote: On Fri, Dec 4, 2020 at 7:22 PM Drouvot, Bertrand wrote: Hi, On 12/4/20 2:21 AM, Fujii Masao wrote: On 2020/12/04 9:28, Masahiko Sawada wrote: On Fri, Dec 4,

Re: Add Information during standby recovery conflicts

2020-12-15 Thread Kyotaro Horiguchi
At Wed, 16 Dec 2020 14:49:25 +0900 (JST), Kyotaro Horiguchi wrote in > > > > Conflicting processes are 41171, 41194. > > > > Conflicting processes are: 41171, 41194. > > Or I came up with the following after scanning throught the tree. > > | Some processes are conflicting: 41171, 41194. Or

Re: Add Information during standby recovery conflicts

2020-12-15 Thread Kyotaro Horiguchi
At Wed, 16 Dec 2020 12:08:31 +0900, Masahiko Sawada wrote in On Wed, Dec 16, 2020 at 11:22 AM Kyotaro Horiguchi wrote: > > At Tue, 15 Dec 2020 15:40:03 +0900, Fujii Masao wrote in > > > > > > On 2020/12/15 12:04, Kyotaro Horiguchi wrote: > > > [40509:startup] DETAIL: Conflicting processes:

Re: Add Information during standby recovery conflicts

2020-12-15 Thread Masahiko Sawada
On Wed, Dec 16, 2020 at 11:22 AM Kyotaro Horiguchi wrote: > > At Tue, 15 Dec 2020 15:40:03 +0900, Fujii Masao > wrote in > > > > > > On 2020/12/15 12:04, Kyotaro Horiguchi wrote: > > > [40509:startup] DETAIL: Conflicting processes: 41171, 41194. > ... > > > I'm not sure, but it seems to me at

Re: Add Information during standby recovery conflicts

2020-12-15 Thread Masahiko Sawada
On Mon, Dec 14, 2020 at 9:31 PM Fujii Masao wrote: > > > > On 2020/12/05 12:38, Masahiko Sawada wrote: > > On Fri, Dec 4, 2020 at 7:22 PM Drouvot, Bertrand > > wrote: > >> > >> Hi, > >> > >> On 12/4/20 2:21 AM, Fujii Masao wrote: > >>> > >>> On 2020/12/04 9:28, Masahiko Sawada wrote: > On

Re: Add Information during standby recovery conflicts

2020-12-15 Thread Kyotaro Horiguchi
At Tue, 15 Dec 2020 15:40:03 +0900, Fujii Masao wrote in > > > On 2020/12/15 12:04, Kyotaro Horiguchi wrote: > > [40509:startup] DETAIL: Conflicting processes: 41171, 41194. ... > > I'm not sure, but it seems to me at least the period is unnecessary > > here. > > Since Error Message Style

Re: Add Information during standby recovery conflicts

2020-12-14 Thread Fujii Masao
On 2020/12/15 15:40, Fujii Masao wrote: On 2020/12/15 12:04, Kyotaro Horiguchi wrote: At Tue, 15 Dec 2020 02:00:21 +0900, Fujii Masao wrote in Thanks for the review! I'm thinking to wait half a day before commiting the patch just in the case someone may object the patch. Sorry for

Re: Add Information during standby recovery conflicts

2020-12-14 Thread Fujii Masao
On 2020/12/15 12:04, Kyotaro Horiguchi wrote: At Tue, 15 Dec 2020 02:00:21 +0900, Fujii Masao wrote in Thanks for the review! I'm thinking to wait half a day before commiting the patch just in the case someone may object the patch. Sorry for coming late. I have looked only the latest

Re: Add Information during standby recovery conflicts

2020-12-14 Thread Kyotaro Horiguchi
At Tue, 15 Dec 2020 02:00:21 +0900, Fujii Masao wrote in > Thanks for the review! I'm thinking to wait half a day before > commiting > the patch just in the case someone may object the patch. Sorry for coming late. I have looked only the latest thread so I should be missing many things so

Re: Add Information during standby recovery conflicts

2020-12-14 Thread Fujii Masao
On 2020/12/15 0:49, Drouvot, Bertrand wrote: Hi, On 12/14/20 4:20 PM, Fujii Masao wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 2020/12/14 21:31, Fujii

Re: Add Information during standby recovery conflicts

2020-12-14 Thread Fujii Masao
On 2020/12/14 21:31, Fujii Masao wrote: On 2020/12/05 12:38, Masahiko Sawada wrote: On Fri, Dec 4, 2020 at 7:22 PM Drouvot, Bertrand wrote: Hi, On 12/4/20 2:21 AM, Fujii Masao wrote: On 2020/12/04 9:28, Masahiko Sawada wrote: On Fri, Dec 4, 2020 at 2:54 AM Fujii Masao wrote: On

Re: Add Information during standby recovery conflicts

2020-12-14 Thread Fujii Masao
On 2020/12/05 12:38, Masahiko Sawada wrote: On Fri, Dec 4, 2020 at 7:22 PM Drouvot, Bertrand wrote: Hi, On 12/4/20 2:21 AM, Fujii Masao wrote: On 2020/12/04 9:28, Masahiko Sawada wrote: On Fri, Dec 4, 2020 at 2:54 AM Fujii Masao wrote: On 2020/12/01 17:29, Drouvot, Bertrand wrote:

Re: Add Information during standby recovery conflicts

2020-12-04 Thread Masahiko Sawada
On Fri, Dec 4, 2020 at 7:22 PM Drouvot, Bertrand wrote: > > Hi, > > On 12/4/20 2:21 AM, Fujii Masao wrote: > > > > On 2020/12/04 9:28, Masahiko Sawada wrote: > >> On Fri, Dec 4, 2020 at 2:54 AM Fujii Masao > >> wrote: > >>> > >>> > >>> > >>> On 2020/12/01 17:29, Drouvot, Bertrand wrote: >

Re: Add Information during standby recovery conflicts

2020-12-03 Thread Fujii Masao
On 2020/12/04 9:28, Masahiko Sawada wrote: On Fri, Dec 4, 2020 at 2:54 AM Fujii Masao wrote: On 2020/12/01 17:29, Drouvot, Bertrand wrote: Hi, On 12/1/20 12:35 AM, Masahiko Sawada wrote: CAUTION: This email originated from outside of the organization. Do not click links or open

Re: Add Information during standby recovery conflicts

2020-12-03 Thread Masahiko Sawada
On Fri, Dec 4, 2020 at 2:54 AM Fujii Masao wrote: > > > > On 2020/12/01 17:29, Drouvot, Bertrand wrote: > > Hi, > > > > On 12/1/20 12:35 AM, Masahiko Sawada wrote: > >> CAUTION: This email originated from outside of the organization. Do not > >> click links or open attachments unless you can

Re: Add Information during standby recovery conflicts

2020-12-03 Thread Fujii Masao
On 2020/12/01 17:29, Drouvot, Bertrand wrote: Hi, On 12/1/20 12:35 AM, Masahiko Sawada wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Tue, Dec 1, 2020 at

Re: Add Information during standby recovery conflicts

2020-11-30 Thread Masahiko Sawada
On Tue, Dec 1, 2020 at 3:25 AM Alvaro Herrera wrote: > > On 2020-Dec-01, Fujii Masao wrote: > > > + if (proc) > > + { > > + if (nprocs == 0) > > + appendStringInfo(, "%d", > > proc->pid); > >

Re: Add Information during standby recovery conflicts

2020-11-30 Thread Alvaro Herrera
On 2020-Dec-01, Fujii Masao wrote: > + if (proc) > + { > + if (nprocs == 0) > + appendStringInfo(, "%d", proc->pid); > + else > +

Re: Add Information during standby recovery conflicts

2020-11-30 Thread Fujii Masao
On 2020/11/30 16:26, Masahiko Sawada wrote: On Mon, Nov 30, 2020 at 3:46 PM Drouvot, Bertrand wrote: Hi, On 11/30/20 4:41 AM, Masahiko Sawada wrote: On Sun, Nov 29, 2020 at 3:47 PM Drouvot, Bertrand wrote: Hi Alvaro, On 11/28/20 6:36 PM, Alvaro Herrera wrote: Hi Bertrand, On

Re: Add Information during standby recovery conflicts

2020-11-30 Thread Fujii Masao
On 2020/11/20 18:17, Drouvot, Bertrand wrote: Hi, On 11/17/20 4:44 PM, Fujii Masao wrote: Thanks for updating the patch! Here are review comments. +    Controls whether a log message is produced when the startup process +    is waiting longer than deadlock_timeout +    for

Re: Add Information during standby recovery conflicts

2020-11-29 Thread Masahiko Sawada
On Mon, Nov 30, 2020 at 3:46 PM Drouvot, Bertrand wrote: > > Hi, > > On 11/30/20 4:41 AM, Masahiko Sawada wrote: > > On Sun, Nov 29, 2020 at 3:47 PM Drouvot, Bertrand > > wrote: > >> Hi Alvaro, > >> > >> On 11/28/20 6:36 PM, Alvaro Herrera wrote: > >>> Hi Bertrand, > >>> > >>> On 2020-Nov-28,

Re: Add Information during standby recovery conflicts

2020-11-29 Thread Masahiko Sawada
On Sun, Nov 29, 2020 at 3:47 PM Drouvot, Bertrand wrote: > > Hi Alvaro, > > On 11/28/20 6:36 PM, Alvaro Herrera wrote: > > Hi Bertrand, > > > > On 2020-Nov-28, Drouvot, Bertrand wrote: > > > >> + if (nprocs > 0) > >> + { > >> + ereport(LOG, > >> +

Re: Add Information during standby recovery conflicts

2020-11-28 Thread Alvaro Herrera
Hi Bertrand, On 2020-Nov-28, Drouvot, Bertrand wrote: > + if (nprocs > 0) > + { > + ereport(LOG, > + (errmsg("recovery still waiting after > %ld.%03d ms: %s", > +

Re: Add Information during standby recovery conflicts

2020-11-27 Thread Alvaro Herrera
On 2020-Nov-27, Drouvot, Bertrand wrote: > + if (nprocs > 0) > + { > + ereport(LOG, > + (errmsg("%s after %ld.%03d ms", > + > get_recovery_conflict_desc(reason),

Re: Add Information during standby recovery conflicts

2020-11-26 Thread Masahiko Sawada
On Thu, Nov 26, 2020 at 12:49 AM Drouvot, Bertrand wrote: > > Hi, > > On 11/25/20 2:20 PM, Masahiko Sawada wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. >

Re: Add Information during standby recovery conflicts

2020-11-25 Thread Masahiko Sawada
On Fri, Nov 20, 2020 at 6:18 PM Drouvot, Bertrand wrote: > > Hi, > > On 11/17/20 4:44 PM, Fujii Masao wrote: > > > > Thanks for updating the patch! Here are review comments. > > > > +Controls whether a log message is produced when the startup > > process > > +is waiting longer

Re: Add Information during standby recovery conflicts

2020-11-17 Thread Fujii Masao
On 2020/11/17 17:23, Drouvot, Bertrand wrote: On 11/17/20 2:09 AM, Masahiko Sawada wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Nov 16, 2020 at 4:55

Re: Add Information during standby recovery conflicts

2020-11-16 Thread Masahiko Sawada
On Mon, Nov 16, 2020 at 4:55 PM Drouvot, Bertrand wrote: > > Hi, > > On 11/16/20 6:44 AM, Masahiko Sawada wrote: > > Thank you for updating the patch. > > > > Here are review comments. > > > > + if (report_waiting && (!logged_recovery_conflict || > > new_status == NULL)) > > +

Re: Add Information during standby recovery conflicts

2020-11-15 Thread Masahiko Sawada
On Mon, Nov 9, 2020 at 2:49 PM Drouvot, Bertrand wrote: > > Hi, > > On 11/6/20 3:21 AM, Masahiko Sawada wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > >

Re: Add Information during standby recovery conflicts

2020-11-05 Thread Masahiko Sawada
On Fri, Oct 30, 2020 at 6:02 PM Drouvot, Bertrand wrote: > > Hi, > > On 10/30/20 4:25 AM, Fujii Masao wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the sender > > and know the content is safe. > > > >

Re: Add Information during standby recovery conflicts

2020-10-29 Thread Fujii Masao
On 2020/10/30 10:29, Masahiko Sawada wrote: , On Thu, 29 Oct 2020 at 00:16, Fujii Masao wrote: On 2020/10/27 9:41, Masahiko Sawada wrote: On Tue, 20 Oct 2020 at 22:02, Drouvot, Bertrand wrote: Hi, On 10/15/20 9:15 AM, Masahiko Sawada wrote: CAUTION: This email originated from

Re: Add Information during standby recovery conflicts

2020-10-29 Thread Masahiko Sawada
, On Thu, 29 Oct 2020 at 00:16, Fujii Masao wrote: > > > > On 2020/10/27 9:41, Masahiko Sawada wrote: > > On Tue, 20 Oct 2020 at 22:02, Drouvot, Bertrand wrote: > >> > >> Hi, > >> > >> On 10/15/20 9:15 AM, Masahiko Sawada wrote: > >>> CAUTION: This email originated from outside of the

Re: Add Information during standby recovery conflicts

2020-10-28 Thread Fujii Masao
On 2020/10/27 9:41, Masahiko Sawada wrote: On Tue, 20 Oct 2020 at 22:02, Drouvot, Bertrand wrote: Hi, On 10/15/20 9:15 AM, Masahiko Sawada wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and

Re: Add Information during standby recovery conflicts

2020-10-26 Thread Masahiko Sawada
On Tue, 20 Oct 2020 at 22:02, Drouvot, Bertrand wrote: > > Hi, > > On 10/15/20 9:15 AM, Masahiko Sawada wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > >

Re: Add Information during standby recovery conflicts

2020-10-15 Thread Masahiko Sawada
On Thu, 15 Oct 2020 at 14:52, Kyotaro Horiguchi wrote: > > At Thu, 15 Oct 2020 14:28:57 +0900, Masahiko Sawada > wrote in > > > ereport(..(errmsg("%s", _("hogehoge" results in > > > fprintf((translated("%s")), translate("hogehoge")). > > > > > > So your change (errmsg("%s",

Re: Add Information during standby recovery conflicts

2020-10-14 Thread Kyotaro Horiguchi
At Thu, 15 Oct 2020 14:28:57 +0900, Masahiko Sawada wrote in > > ereport(..(errmsg("%s", _("hogehoge" results in > > fprintf((translated("%s")), translate("hogehoge")). > > > > So your change (errmsg("%s", gettext_noop("hogehoge")) results in > > > > fprintf((translated("%s")),

Re: Add Information during standby recovery conflicts

2020-10-14 Thread Masahiko Sawada
On Thu, 15 Oct 2020 at 12:13, Kyotaro Horiguchi wrote: > > At Wed, 14 Oct 2020 17:39:20 +0900, Masahiko Sawada > wrote in > > On Wed, 14 Oct 2020 at 07:44, Alvaro Herrera > > wrote: > > > > > > On 2020-Oct-14, Masahiko Sawada wrote: > > > > > > > I've attached the patch as an idea of fixing

Re: Add Information during standby recovery conflicts

2020-10-14 Thread Kyotaro Horiguchi
At Wed, 14 Oct 2020 17:39:20 +0900, Masahiko Sawada wrote in > On Wed, 14 Oct 2020 at 07:44, Alvaro Herrera wrote: > > > > On 2020-Oct-14, Masahiko Sawada wrote: > > > > > I've attached the patch as an idea of fixing the above comments as > > > well as the comment from Alvaro. I can be applied

Re: Add Information during standby recovery conflicts

2020-10-14 Thread Masahiko Sawada
On Wed, 14 Oct 2020 at 07:44, Alvaro Herrera wrote: > > On 2020-Oct-14, Masahiko Sawada wrote: > > > I've attached the patch as an idea of fixing the above comments as > > well as the comment from Alvaro. I can be applied on top of v4 patch. > > One note about the translation stuff. Currently

Re: Add Information during standby recovery conflicts

2020-10-13 Thread Alvaro Herrera
On 2020-Oct-14, Masahiko Sawada wrote: > I've attached the patch as an idea of fixing the above comments as > well as the comment from Alvaro. I can be applied on top of v4 patch. One note about the translation stuff. Currently you have _("...") where the string is produced, and then

Re: Add Information during standby recovery conflicts

2020-10-13 Thread Masahiko Sawada
On Sun, 4 Oct 2020 at 20:48, Drouvot, Bertrand wrote: > > > On 8/28/20 4:14 PM, Drouvot, Bertrand wrote: > > > > On 8/28/20 7:03 AM, Masahiko Sawada wrote: > >> CAUTION: This email originated from outside of the organization. Do > >> not click links or open attachments unless you can confirm the

Re: Add Information during standby recovery conflicts

2020-10-04 Thread Alvaro Herrera
> +extern const char *get_procsignal_reason_desc(ProcSignalReason reason) > + { > + const char *reasonDesc = "unknown reason"; > + > + switch (reason) > + { > + case PROCSIG_RECOVERY_CONFLICT_BUFFERPIN: > +

Re: Add Information during standby recovery conflicts

2020-08-27 Thread Masahiko Sawada
On Thu, 27 Aug 2020 at 20:58, Drouvot, Bertrand wrote: > > > On 8/27/20 10:16 AM, Masahiko Sawada wrote > > > > On Mon, 10 Aug 2020 at 23:43, Drouvot, Bertrand wrote: > >> Hi, > >> > >> On 7/31/20 7:12 AM, Masahiko Sawada wrote: > >>> + tmpWaitlist = waitlist; > >>> + while

Re: Add Information during standby recovery conflicts

2020-08-27 Thread Masahiko Sawada
On Mon, 10 Aug 2020 at 23:43, Drouvot, Bertrand wrote: > > Hi, > > On 7/31/20 7:12 AM, Masahiko Sawada wrote: > > + tmpWaitlist = waitlist; > > + while (VirtualTransactionIdIsValid(*tmpWaitlist)) > > + { > > + tmpWaitlist++; > > + } > > + > > + num_waitlist_entries = (tmpWaitlist

Re: Add Information during standby recovery conflicts

2020-07-30 Thread Masahiko Sawada
On Sat, 11 Jul 2020 at 21:56, Drouvot, Bertrand wrote: > > > On 7/7/20 9:43 AM, Masahiko Sawada wrote: > > Fully makes sense, the new patch version attached is now producing: > >> 2020-07-06 06:10:36.022 UTC [14035] LOG: waiting for recovery conflict > >> on snapshot > > How about adding the

Re: Add Information during standby recovery conflicts

2020-07-07 Thread Masahiko Sawada
>> click links or open attachments unless you can confirm the sender and > >>> know the content is safe. > >>> > >>> > >>> > >>> On Thu, 18 Jun 2020 at 16:28, Drouvot, Bertrand > >>> wrote: >

Re: Add Information during standby recovery conflicts

2020-07-02 Thread Masahiko Sawada
> > the content is safe. > > > > > > > > On Thu, 18 Jun 2020 at 16:28, Drouvot, Bertrand wrote: > >> Hi hackers, > >> > >> I've attached a patch to add information during standby recovery conflicts. > >> The motive behind is t

Re: Add Information during standby recovery conflicts

2020-06-29 Thread Masahiko Sawada
On Thu, 18 Jun 2020 at 16:28, Drouvot, Bertrand wrote: > > Hi hackers, > > I've attached a patch to add information during standby recovery conflicts. > The motive behind is to be able to get some information: > > On the apply side > On the blocker(s) side > >