On 2023-04-24 Mo 03:08, Hayato Kuroda (Fujitsu) wrote:
Dear David,
It is great to make sure each file has the Copyright and I see this
patch has already been committed.
Thanks!
While checking more, I was surprised because I found many files which do not
have Copyright via " grep -Lr Copyright
Dear David,
> It is great to make sure each file has the Copyright and I see this
> patch has already been committed.
Thanks!
While checking more, I was surprised because I found many files which do not
have Copyright via " grep -Lr Copyright --exclude-dir .git ..." command.
I'm not sure whether
I checked the commit log.
About 001_basic.pl, it had been added at 2017 once but been reverted soon
[1][2].
322bec added the file again at 2022[3], so I chose 2022.
About 002_pg_upgrade.pl, it has been added at the same time[3].
Definitively it should be 2022.
It is great to make sure each
Dear Amit,
Thank you for responding!
>
> Yeah, it is good to have the Copyright to keep it consistent with
> other test files and otherwise as well.
>
> --- a/src/bin/pg_upgrade/t/001_basic.pl
> +++ b/src/bin/pg_upgrade/t/001_basic.pl
> @@ -1,3 +1,5 @@
> +# Copyright (c) 2022-2023, PostgreSQL G
On Mon, Apr 3, 2023 at 7:25 PM Hayato Kuroda (Fujitsu)
wrote:
>
> While reading codes, I noticed that pg_upgrade/t/001_basic.pl and
> pg_upgrade/t/002_pg_upgrade.pl do not contain the copyright.
>
> I checked briefly and almost all files have that, so I thought they missed it.
> PSA the patch to f
Dear hackers,
While reading codes, I noticed that pg_upgrade/t/001_basic.pl and
pg_upgrade/t/002_pg_upgrade.pl do not contain the copyright.
I checked briefly and almost all files have that, so I thought they missed it.
PSA the patch to fix them.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
ad
